Build failure of network:osmocom:nightly/libosmo-abis in Raspbian_10/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Raspbian_10/armv7l

Package network:osmocom:nightly/libosmo-abis failed to build in 
Raspbian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-abis

Last lines of build log:
[  553s] In file included from e1_input_vty.c:36:
[  553s] e1_input_vty.c:85:10: error: 'OSMO_ABIS_LIB_ATTR_LINE_UPD' undeclared 
here (not in a function); did you mean 'OSMO_SCCP_LIB_ATTR_RSTRT_ASP'?
[  553s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  553s]   ^~~
[  553s] e1_input_vty.c:85:8: note: in expansion of macro 'X'
[  553s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  553s] ^
[  553s] e1_input_vty.c:156:10: error: 'OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK' 
undeclared here (not in a function); did you mean 
'OSMO_SCCP_LIB_ATTR_RSTRT_ASP'?
[  553s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  553s]   ^~
[  553s] e1_input_vty.c:156:8: note: in expansion of macro 'X'
[  553s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  553s] ^
[  553s] make[3]: *** [Makefile:579: e1_input_vty.lo] Error 1
[  553s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  553s] make[2]: *** [Makefile:484: all-recursive] Error 1
[  553s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  553s] make[1]: *** [Makefile:389: all] Error 2
[  553s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  553s] dh_auto_build: make -j1 returned exit code 2
[  553s] make: *** [debian/rules:12: build] Error 2
[  553s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  553s] ### VM INTERACTION START ###
[  557s] [  467.737369] sysrq: SysRq : Power Off
[  557s] [  467.976816] reboot: Power down
[  557s] ### VM INTERACTION END ###
[  557s] 
[  557s] armbuild24 failed "build libosmo-abis_1.0.0.20.ef5b.dsc" at Fri Oct  9 
05:14:40 UTC 2020.
[  557s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_20.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  167s] [COMPILING libboard/qmod/source/wwan_perst.c]
[  167s] [COMPILING libboard/qmod/source/card_pres.c]
[  167s] [COMPILING libboard/qmod/source/wwan_led.c]
[  167s] [COMPILING libboard/qmod/source/i2c.c]
[  168s] [COMPILING libboard/qmod/source/board_qmod.c]
[  168s] [COMPILING apps/dfu/main.c]
[  168s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c]
[  168s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c]
[  168s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c]
[  168s] Memory region Used Size  Region Size  %age Used
[  168s]  rom:   16588 B16 KB101.25%
[  168s]  ram:   11672 B48 KB 
23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom'
[  168s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region 
`rom' overflowed by 204 bytes
[  168s] collect2: error: ld returned 1 exit status
[  168s] %
[  168s] make[2]: *** [Makefile:234: flash] Error 1
[  168s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  168s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2
[  168s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  168s] dh_auto_build: error: make -j1 returned exit code 2
[  168s] make: *** [debian/rules:16: build] Error 25
[  168s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  169s] ### VM INTERACTION START ###
[  172s] [  160.580478] sysrq: Power Off
[  172s] [  160.587694] reboot: Power down
[  172s] ### VM INTERACTION END ###
[  172s] 
[  172s] lamb06 failed "build simtrace2_0.7.0.63.39070.dsc" at Fri Oct  9 
03:21:45 UTC 2020.
[  172s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-abis in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_9.0/armv7l

Package network:osmocom:nightly/libosmo-abis failed to build in 
Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-abis

Last lines of build log:
[  357s] e1_input_vty.c:85:8: note: in expansion of macro 'X'
[  357s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  357s] ^
[  357s] e1_input_vty.c:156:10: error: 'OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK' 
undeclared here (not in a function)
[  357s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  357s]   ^
[  357s] e1_input_vty.c:156:8: note: in expansion of macro 'X'
[  357s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  357s] ^
[  357s] Makefile:560: recipe for target 'e1_input_vty.lo' failed
[  357s] make[3]: *** [e1_input_vty.lo] Error 1
[  357s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  357s] Makefile:484: recipe for target 'all-recursive' failed
[  357s] make[2]: *** [all-recursive] Error 1
[  357s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  357s] Makefile:389: recipe for target 'all' failed
[  357s] make[1]: *** [all] Error 2
[  357s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  357s] dh_auto_build: make -j1 returned exit code 2
[  357s] debian/rules:12: recipe for target 'build' failed
[  357s] make: *** [build] Error 2
[  357s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  357s] ### VM INTERACTION START ###
[  360s] [  327.293629] sysrq: SysRq : Power Off
[  360s] [  327.313241] reboot: Power down
[  361s] ### VM INTERACTION END ###
[  361s] 
[  361s] obs-arm-6 failed "build libosmo-abis_1.0.0.20.ef5b.dsc" at Fri Oct  9 
03:09:44 UTC 2020.
[  361s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-abis in Debian_10/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_10/armv7l

Package network:osmocom:nightly/libosmo-abis failed to build in Debian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-abis

Last lines of build log:
[  343s] In file included from e1_input_vty.c:36:
[  343s] e1_input_vty.c:85:10: error: 'OSMO_ABIS_LIB_ATTR_LINE_UPD' undeclared 
here (not in a function); did you mean 'OSMO_SCCP_LIB_ATTR_RSTRT_ASP'?
[  343s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  343s]   ^~~
[  343s] e1_input_vty.c:85:8: note: in expansion of macro 'X'
[  343s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  343s] ^
[  343s] e1_input_vty.c:156:10: error: 'OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK' 
undeclared here (not in a function); did you mean 
'OSMO_SCCP_LIB_ATTR_RSTRT_ASP'?
[  343s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  343s]   ^~
[  343s] e1_input_vty.c:156:8: note: in expansion of macro 'X'
[  343s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  343s] ^
[  343s] make[3]: *** [Makefile:579: e1_input_vty.lo] Error 1
[  343s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  343s] make[2]: *** [Makefile:484: all-recursive] Error 1
[  343s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  343s] make[1]: *** [Makefile:389: all] Error 2
[  343s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  343s] dh_auto_build: make -j1 returned exit code 2
[  343s] make: *** [debian/rules:12: build] Error 2
[  343s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  343s] ### VM INTERACTION START ###
[  346s] [  309.116201] sysrq: SysRq : Power Off
[  346s] [  309.131982] reboot: Power down
[  346s] ### VM INTERACTION END ###
[  346s] 
[  346s] obs-arm-6 failed "build libosmo-abis_1.0.0.20.ef5b.dsc" at Fri Oct  9 
02:12:42 UTC 2020.
[  346s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/armv7l

Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[ 1132s] | ## Running config.status. ##
[ 1132s] | ## -- ##
[ 1132s] | 
[ 1132s] | This file was extended by libosmocore config.status 1.4.0.120-a521, 
which was
[ 1132s] | generated by GNU Autoconf 2.69.  Invocation command line was
[ 1132s] | 
[ 1132s] |   CONFIG_FILES= 
[ 1132s] |   CONFIG_HEADERS  = 
[ 1132s] |   CONFIG_LINKS= 
[ 1132s] |   CONFIG_COMMANDS = 
[ 1132s] |   $ ./config.status Doxyfile.core
[ 1132s] | 
[ 1132s] | on obs-arm-5
[ 1132s] | 
[ 1132s] | config.status:1346: creating Doxyfile.core
[ 1132s] 
[ 1132s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[ 1132s] make[1]: *** [override_dh_auto_test] Error 1
[ 1132s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 1132s] debian/rules:15: recipe for target 'build' failed
[ 1132s] make: *** [build] Error 2
[ 1132s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 1132s] ### VM INTERACTION START ###
[ 1134s] [ 1102.590305] sysrq: SysRq : Power Off
[ 1134s] [ 1102.595210] reboot: Power down
[ 1135s] ### VM INTERACTION END ###
[ 1135s] 
[ 1135s] obs-arm-5 failed "build libosmocore_1.4.0.120.a521.dsc" at Fri Oct  9 
01:53:28 UTC 2020.
[ 1135s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in Debian_10/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_10/armv7l

Package network:osmocom:nightly/libosmocore failed to build in Debian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[ 1029s] | 
[ 1029s] | ## -- ##
[ 1029s] | ## Running config.status. ##
[ 1029s] | ## -- ##
[ 1029s] | 
[ 1029s] | This file was extended by libosmocore config.status 1.4.0.120-a521, 
which was
[ 1029s] | generated by GNU Autoconf 2.69.  Invocation command line was
[ 1029s] | 
[ 1029s] |   CONFIG_FILES= 
[ 1029s] |   CONFIG_HEADERS  = 
[ 1029s] |   CONFIG_LINKS= 
[ 1029s] |   CONFIG_COMMANDS = 
[ 1029s] |   $ ./config.status Doxyfile.core
[ 1029s] | 
[ 1029s] | on obs-arm-5
[ 1029s] | 
[ 1029s] | config.status:1341: creating Doxyfile.core
[ 1029s] 
[ 1029s] make[1]: *** [debian/rules:26: override_dh_auto_test] Error 1
[ 1029s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 1029s] make: *** [debian/rules:15: build] Error 2
[ 1029s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[ 1029s] ### VM INTERACTION START ###
[ 1032s] [  994.968519] sysrq: SysRq : Power Off
[ 1032s] [  994.974945] reboot: Power down
[ 1032s] ### VM INTERACTION END ###
[ 1033s] 
[ 1033s] obs-arm-5 failed "build libosmocore_1.4.0.120.a521.dsc" at Fri Oct  9 
01:51:45 UTC 2020.
[ 1033s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in Raspbian_10/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_10/armv7l

Package network:osmocom:nightly/libosmocore failed to build in 
Raspbian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[ 1022s] -osmo_int_to_float_str_buf(100, 23) -> rc=19 
str="0.1"
[ 1022s] -osmo_int_to_float_str_buf(-100, 23) -> rc=20 
str="-0.1"
[ 1022s] -osmo_int_to_float_str_buf(101, 23) -> rc=25 
str="0.101"
[ 1022s] -osmo_int_to_float_str_buf(-101, 23) -> rc=26 
str="-0.101"
[ 1022s] -osmo_int_to_float_str_buf(1000100, 23) -> rc=23 
str="0.10001"
[ 1022s] -osmo_int_to_float_str_buf(-101, 23) -> rc=22 
str="-0.101"
[ 1022s] -osmo_int_to_float_str_buf(110, 23) -> rc=20 
str="0.11"
[ 1022s] -osmo_int_to_float_str_buf(1000, 23) -> rc=18 
str="0.0001"
[ 1022s] -osmo_int_to_float_str_buf(-1000, 23) -> rc=19 
str="-0.0001"
[ 1022s] -osmo_int_to_float_str_buf(1, 23) -> rc=17 
str="0.001"
[ 1022s] -osmo_int_to_float_str_buf(-1, 23) -> rc=18 
str="-0.001"
[ 1022s] -osmo_int_to_float_str_buf(9223372036854775807, 23) -> rc=25 
str="0.9223372036854775807"
[ 1022s] -osmo_int_to_float_str_buf(-9223372036854775807, 23) -> rc=26 
str="-0.9223372036854775807"
[ 1022s] -osmo_int_to_float_str_buf(-9223372036854775808, 23) -> rc=4 str="-ERR"
[ 1022s] +osmo_float_str_to_int("-9223372036854775808", 0) -> rc=0 
val=-9223372036854775807
[ 1022s] +  ERROR: expected rc=-34=-ERANGE
[ 1022s] +  ERROR: expected val=0
[ 1022s] 36. testsuite.at:224: 36. utils (testsuite.at:224): FAILED 
(testsuite.at:228)
[ 1022s] make[1]: *** [debian/rules:26: override_dh_auto_test] Error 1
[ 1022s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 1022s] make: *** [debian/rules:15: build] Error 2
[ 1022s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[ 1022s] ### VM INTERACTION START ###
[ 1024s] [  990.192770] sysrq: SysRq : Power Off
[ 1024s] [  990.229441] reboot: Power down
[ 1025s] ### VM INTERACTION END ###
[ 1025s] 
[ 1025s] obs-arm-6 failed "build libosmocore_1.4.0.120.a521.dsc" at Fri Oct  9 
01:51:37 UTC 2020.
[ 1025s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-abis in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_8.0/i586

Package network:osmocom:nightly/libosmo-abis failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-abis

Last lines of build log:
[   81s] e1_input_vty.c:85:8: note: in expansion of macro 'X'
[   81s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[   81s] ^
[   81s] e1_input_vty.c:156:10: error: 'OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK' 
undeclared here (not in a function)
[   81s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[   81s]   ^
[   81s] e1_input_vty.c:156:8: note: in expansion of macro 'X'
[   81s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[   81s] ^
[   81s] Makefile:548: recipe for target 'e1_input_vty.lo' failed
[   81s] make[3]: *** [e1_input_vty.lo] Error 1
[   81s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   81s] Makefile:473: recipe for target 'all-recursive' failed
[   81s] make[2]: *** [all-recursive] Error 1
[   81s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   81s] Makefile:377: recipe for target 'all' failed
[   81s] make[1]: *** [all] Error 2
[   81s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   81s] dh_auto_build: make -j1 returned exit code 2
[   81s] debian/rules:12: recipe for target 'build' failed
[   81s] make: *** [build] Error 2
[   81s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   81s] ### VM INTERACTION START ###
[   82s] Powering off.
[   82s] [   75.846541] reboot: Power down
[   82s] ### VM INTERACTION END ###
[   82s] 
[   82s] build72 failed "build libosmo-abis_1.0.0.20.ef5b.dsc" at Fri Oct  9 
01:45:04 UTC 2020.
[   82s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-abis in Debian_10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_10/i586

Package network:osmocom:nightly/libosmo-abis failed to build in Debian_10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-abis

Last lines of build log:
[  110s] In file included from e1_input_vty.c:36:
[  110s] e1_input_vty.c:85:10: error: 'OSMO_ABIS_LIB_ATTR_LINE_UPD' undeclared 
here (not in a function); did you mean 'OSMO_SCCP_LIB_ATTR_RSTRT_ASP'?
[  110s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  110s]   ^~~
[  110s] e1_input_vty.c:85:8: note: in expansion of macro 'X'
[  110s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  110s] ^
[  110s] e1_input_vty.c:156:10: error: 'OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK' 
undeclared here (not in a function); did you mean 
'OSMO_SCCP_LIB_ATTR_RSTRT_ASP'?
[  110s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  110s]   ^~
[  110s] e1_input_vty.c:156:8: note: in expansion of macro 'X'
[  110s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  110s] ^
[  110s] make[3]: *** [Makefile:579: e1_input_vty.lo] Error 1
[  110s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  110s] make[2]: *** [Makefile:484: all-recursive] Error 1
[  110s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  110s] make[1]: *** [Makefile:389: all] Error 2
[  110s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  110s] dh_auto_build: make -j1 returned exit code 2
[  110s] make: *** [debian/rules:12: build] Error 2
[  110s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  110s] ### VM INTERACTION START ###
[  113s] [  104.380216] sysrq: Power Off
[  113s] [  104.384726] reboot: Power down
[  113s] ### VM INTERACTION END ###
[  113s] 
[  113s] sheep86 failed "build libosmo-abis_1.0.0.20.ef5b.dsc" at Fri Oct  9 
01:41:23 UTC 2020.
[  113s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/i586

Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  574s] | ## Running config.status. ##
[  574s] | ## -- ##
[  574s] | 
[  574s] | This file was extended by libosmocore config.status 1.4.0.120-a521, 
which was
[  574s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  574s] | 
[  574s] |   CONFIG_FILES= 
[  574s] |   CONFIG_HEADERS  = 
[  574s] |   CONFIG_LINKS= 
[  574s] |   CONFIG_COMMANDS = 
[  574s] |   $ ./config.status Doxyfile.core
[  574s] | 
[  574s] | on cloud119
[  574s] | 
[  574s] | config.status:1345: creating Doxyfile.core
[  574s] 
[  574s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  574s] make[1]: *** [override_dh_auto_test] Error 1
[  574s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  574s] debian/rules:15: recipe for target 'build' failed
[  574s] make: *** [build] Error 2
[  574s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  574s] ### VM INTERACTION START ###
[  574s] Powering off.
[  574s] [  556.658612] reboot: Power down
[  575s] ### VM INTERACTION END ###
[  575s] 
[  575s] cloud119 failed "build libosmocore_1.4.0.120.a521.dsc" at Fri Oct  9 
01:41:11 UTC 2020.
[  575s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_18.04/i586

Package network:osmocom:nightly/libosmo-abis failed to build in 
xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-abis

Last lines of build log:
[  115s] e1_input_vty.c:85:8: note: in expansion of macro 'X'
[  115s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  115s] ^
[  115s] e1_input_vty.c:156:10: error: 'OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK' 
undeclared here (not in a function); did you mean 'OSMO_ABIS_LIB_ATTR_LINE_UPD'?
[  115s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  115s]   ^
[  115s] e1_input_vty.c:156:8: note: in expansion of macro 'X'
[  115s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  115s] ^
[  115s] Makefile:560: recipe for target 'e1_input_vty.lo' failed
[  115s] make[3]: *** [e1_input_vty.lo] Error 1
[  115s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  115s] Makefile:484: recipe for target 'all-recursive' failed
[  115s] make[2]: *** [all-recursive] Error 1
[  115s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  115s] Makefile:389: recipe for target 'all' failed
[  115s] make[1]: *** [all] Error 2
[  115s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  115s] dh_auto_build: make -j1 returned exit code 2
[  115s] debian/rules:12: recipe for target 'build' failed
[  115s] make: *** [build] Error 2
[  115s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  115s] ### VM INTERACTION START ###
[  118s] [  108.716050] sysrq: Power Off
[  118s] [  108.721987] reboot: Power down
[  118s] ### VM INTERACTION END ###
[  118s] 
[  118s] lamb71 failed "build libosmo-abis_1.0.0.20.ef5b.dsc" at Fri Oct  9 
01:39:53 UTC 2020.
[  118s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_16.04/i586

Package network:osmocom:nightly/libosmo-abis failed to build in 
xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-abis

Last lines of build log:
[  139s] e1_input_vty.c:85:8: note: in expansion of macro 'X'
[  139s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  139s] ^
[  139s] e1_input_vty.c:156:10: error: 'OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK' 
undeclared here (not in a function)
[  139s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  139s]   ^
[  139s] e1_input_vty.c:156:8: note: in expansion of macro 'X'
[  139s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  139s] ^
[  139s] Makefile:560: recipe for target 'e1_input_vty.lo' failed
[  139s] make[3]: *** [e1_input_vty.lo] Error 1
[  139s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  139s] Makefile:484: recipe for target 'all-recursive' failed
[  139s] make[2]: *** [all-recursive] Error 1
[  139s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  139s] Makefile:389: recipe for target 'all' failed
[  139s] make[1]: *** [all] Error 2
[  139s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  139s] dh_auto_build: make -j1 returned exit code 2
[  139s] debian/rules:12: recipe for target 'build' failed
[  139s] make: *** [build] Error 2
[  139s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  139s] ### VM INTERACTION START ###
[  142s] [  133.668255] sysrq: Power Off
[  142s] [  133.715575] reboot: Power down
[  143s] ### VM INTERACTION END ###
[  143s] 
[  143s] lamb22 failed "build libosmo-abis_1.0.0.20.ef5b.dsc" at Fri Oct  9 
01:39:34 UTC 2020.
[  143s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-abis in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_9.0/i586

Package network:osmocom:nightly/libosmo-abis failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-abis

Last lines of build log:
[  106s] e1_input_vty.c:85:8: note: in expansion of macro 'X'
[  106s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  106s] ^
[  106s] e1_input_vty.c:156:10: error: 'OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK' 
undeclared here (not in a function)
[  106s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  106s]   ^
[  106s] e1_input_vty.c:156:8: note: in expansion of macro 'X'
[  106s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  106s] ^
[  106s] Makefile:560: recipe for target 'e1_input_vty.lo' failed
[  106s] make[3]: *** [e1_input_vty.lo] Error 1
[  106s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  106s] Makefile:484: recipe for target 'all-recursive' failed
[  106s] make[2]: *** [all-recursive] Error 1
[  106s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  106s] Makefile:389: recipe for target 'all' failed
[  106s] make[1]: *** [all] Error 2
[  106s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  106s] dh_auto_build: make -j1 returned exit code 2
[  106s] debian/rules:12: recipe for target 'build' failed
[  106s] make: *** [build] Error 2
[  106s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  106s] ### VM INTERACTION START ###
[  109s] [  100.037499] sysrq: Power Off
[  109s] [  100.044484] reboot: Power down
[  109s] ### VM INTERACTION END ###
[  109s] 
[  109s] lamb20 failed "build libosmo-abis_1.0.0.20.ef5b.dsc" at Fri Oct  9 
01:39:32 UTC 2020.
[  109s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_18.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_18.10/i586

Package network:osmocom:nightly/libosmo-abis failed to build in 
xUbuntu_18.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-abis

Last lines of build log:
[  199s] In file included from e1_input_vty.c:36:
[  199s] e1_input_vty.c:85:10: error: 'OSMO_ABIS_LIB_ATTR_LINE_UPD' undeclared 
here (not in a function); did you mean 'OSMO_SCCP_LIB_ATTR_RSTRT_ASP'?
[  199s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  199s]   ^~~
[  199s] e1_input_vty.c:85:8: note: in expansion of macro 'X'
[  199s] X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
[  199s] ^
[  199s] e1_input_vty.c:156:10: error: 'OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK' 
undeclared here (not in a function); did you mean 
'OSMO_SCCP_LIB_ATTR_RSTRT_ASP'?
[  199s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  199s]   ^~
[  199s] e1_input_vty.c:156:8: note: in expansion of macro 'X'
[  199s] X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
[  199s] ^
[  200s] make[3]: *** [Makefile:579: e1_input_vty.lo] Error 1
[  200s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  200s] make[2]: *** [Makefile:484: all-recursive] Error 1
[  200s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  200s] make[1]: *** [Makefile:389: all] Error 2
[  200s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  200s] dh_auto_build: make -j1 returned exit code 2
[  200s] make: *** [debian/rules:12: build] Error 2
[  200s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  200s] ### VM INTERACTION START ###
[  203s] [  193.493559] sysrq: Power Off
[  203s] [  193.571260] reboot: Power down
[  203s] ### VM INTERACTION END ###
[  203s] 
[  203s] lamb07 failed "build libosmo-abis_1.0.0.20.ef5b.dsc" at Fri Oct  9 
01:38:57 UTC 2020.
[  203s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in Debian_10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_10/i586

Package network:osmocom:nightly/libosmocore failed to build in Debian_10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  375s] -osmo_int_to_float_str_buf(100, 23) -> rc=19 
str="0.1"
[  375s] -osmo_int_to_float_str_buf(-100, 23) -> rc=20 
str="-0.1"
[  375s] -osmo_int_to_float_str_buf(101, 23) -> rc=25 
str="0.101"
[  375s] -osmo_int_to_float_str_buf(-101, 23) -> rc=26 
str="-0.101"
[  375s] -osmo_int_to_float_str_buf(1000100, 23) -> rc=23 
str="0.10001"
[  375s] -osmo_int_to_float_str_buf(-101, 23) -> rc=22 
str="-0.101"
[  375s] -osmo_int_to_float_str_buf(110, 23) -> rc=20 
str="0.11"
[  375s] -osmo_int_to_float_str_buf(1000, 23) -> rc=18 
str="0.0001"
[  375s] -osmo_int_to_float_str_buf(-1000, 23) -> rc=19 
str="-0.0001"
[  375s] -osmo_int_to_float_str_buf(1, 23) -> rc=17 
str="0.001"
[  375s] -osmo_int_to_float_str_buf(-1, 23) -> rc=18 
str="-0.001"
[  375s] -osmo_int_to_float_str_buf(9223372036854775807, 23) -> rc=25 
str="0.9223372036854775807"
[  375s] -osmo_int_to_float_str_buf(-9223372036854775807, 23) -> rc=26 
str="-0.9223372036854775807"
[  375s] -osmo_int_to_float_str_buf(-9223372036854775808, 23) -> rc=4 str="-ERR"
[  375s] +osmo_float_str_to_int("-9223372036854775808", 0) -> rc=0 
val=-9223372036854775807
[  375s] +  ERROR: expected rc=-34=-ERANGE
[  375s] +  ERROR: expected val=0
[  375s] 36. testsuite.at:224: 36. utils (testsuite.at:224): FAILED 
(testsuite.at:228)
[  375s] make[1]: *** [debian/rules:26: override_dh_auto_test] Error 1
[  375s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  375s] make: *** [debian/rules:15: build] Error 2
[  375s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  375s] ### VM INTERACTION START ###
[  378s] [  366.630904] sysrq: Power Off
[  378s] [  366.637499] reboot: Power down
[  378s] ### VM INTERACTION END ###
[  378s] 
[  378s] lamb12 failed "build libosmocore_1.4.0.120.a521.dsc" at Fri Oct  9 
01:37:54 UTC 2020.
[  378s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_18.04/i586

Package network:osmocom:nightly/libosmocore failed to build in 
xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  365s] -osmo_int_to_float_str_buf(101, 23) -> rc=25 
str="0.101"
[  365s] -osmo_int_to_float_str_buf(-101, 23) -> rc=26 
str="-0.101"
[  365s] -osmo_int_to_float_str_buf(1000100, 23) -> rc=23 
str="0.10001"
[  365s] -osmo_int_to_float_str_buf(-101, 23) -> rc=22 
str="-0.101"
[  365s] -osmo_int_to_float_str_buf(110, 23) -> rc=20 
str="0.11"
[  365s] -osmo_int_to_float_str_buf(1000, 23) -> rc=18 
str="0.0001"
[  365s] -osmo_int_to_float_str_buf(-1000, 23) -> rc=19 
str="-0.0001"
[  365s] -osmo_int_to_float_str_buf(1, 23) -> rc=17 
str="0.001"
[  365s] -osmo_int_to_float_str_buf(-1, 23) -> rc=18 
str="-0.001"
[  365s] -osmo_int_to_float_str_buf(9223372036854775807, 23) -> rc=25 
str="0.9223372036854775807"
[  365s] -osmo_int_to_float_str_buf(-9223372036854775807, 23) -> rc=26 
str="-0.9223372036854775807"
[  365s] -osmo_int_to_float_str_buf(-9223372036854775808, 23) -> rc=4 str="-ERR"
[  365s] +osmo_float_str_to_int("-9223372036854775808", 0) -> rc=0 
val=-9223372036854775807
[  365s] +  ERROR: expected rc=-34=-ERANGE
[  365s] +  ERROR: expected val=0
[  365s] 36. testsuite.at:224: 36. utils (testsuite.at:224): FAILED 
(testsuite.at:228)
[  365s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  365s] make[1]: *** [override_dh_auto_test] Error 1
[  365s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  365s] debian/rules:15: recipe for target 'build' failed
[  365s] make: *** [build] Error 2
[  365s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  365s] ### VM INTERACTION START ###
[  369s] [  358.548104] sysrq: Power Off
[  369s] [  358.555962] reboot: Power down
[  369s] ### VM INTERACTION END ###
[  369s] 
[  369s] lamb12 failed "build libosmocore_1.4.0.120.a521.dsc" at Fri Oct  9 
01:35:54 UTC 2020.
[  369s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/i586

Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  392s] | ## Running config.status. ##
[  392s] | ## -- ##
[  392s] | 
[  392s] | This file was extended by libosmocore config.status 1.4.0.120-a521, 
which was
[  392s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  392s] | 
[  392s] |   CONFIG_FILES= 
[  392s] |   CONFIG_HEADERS  = 
[  392s] |   CONFIG_LINKS= 
[  392s] |   CONFIG_COMMANDS = 
[  392s] |   $ ./config.status Doxyfile.core
[  392s] | 
[  392s] | on lamb06
[  392s] | 
[  392s] | config.status:1349: creating Doxyfile.core
[  392s] 
[  392s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  392s] make[1]: *** [override_dh_auto_test] Error 1
[  392s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  392s] debian/rules:15: recipe for target 'build' failed
[  392s] make: *** [build] Error 2
[  392s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  392s] ### VM INTERACTION START ###
[  396s] [  384.526070] sysrq: Power Off
[  396s] [  384.534203] reboot: Power down
[  396s] ### VM INTERACTION END ###
[  396s] 
[  396s] lamb06 failed "build libosmocore_1.4.0.120.a521.dsc" at Fri Oct  9 
01:36:10 UTC 2020.
[  396s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/i586

Package network:osmocom:nightly/libosmocore failed to build in 
xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  376s] | ## Running config.status. ##
[  376s] | ## -- ##
[  376s] | 
[  376s] | This file was extended by libosmocore config.status 1.4.0.120-a521, 
which was
[  376s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  376s] | 
[  376s] |   CONFIG_FILES= 
[  376s] |   CONFIG_HEADERS  = 
[  376s] |   CONFIG_LINKS= 
[  376s] |   CONFIG_COMMANDS = 
[  376s] |   $ ./config.status Doxyfile.core
[  376s] | 
[  376s] | on lamb61
[  376s] | 
[  376s] | config.status:1349: creating Doxyfile.core
[  376s] 
[  376s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  376s] make[1]: *** [override_dh_auto_test] Error 1
[  376s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  376s] debian/rules:15: recipe for target 'build' failed
[  376s] make: *** [build] Error 2
[  376s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  376s] ### VM INTERACTION START ###
[  379s] [  370.236723] sysrq: Power Off
[  379s] [  370.242432] reboot: Power down
[  380s] ### VM INTERACTION END ###
[  380s] 
[  380s] lamb61 failed "build libosmocore_1.4.0.120.a521.dsc" at Fri Oct  9 
01:35:08 UTC 2020.
[  380s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_18.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_18.10/i586

Package network:osmocom:nightly/libosmocore failed to build in 
xUbuntu_18.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  268s] | 
[  268s] | ## -- ##
[  268s] | ## Running config.status. ##
[  268s] | ## -- ##
[  268s] | 
[  268s] | This file was extended by libosmocore config.status 1.4.0.120-a521, 
which was
[  268s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  268s] | 
[  268s] |   CONFIG_FILES= 
[  268s] |   CONFIG_HEADERS  = 
[  268s] |   CONFIG_LINKS= 
[  268s] |   CONFIG_COMMANDS = 
[  268s] |   $ ./config.status Doxyfile.core
[  268s] | 
[  268s] | on hci-cnode2-m1
[  268s] | 
[  268s] | config.status:1349: creating Doxyfile.core
[  268s] 
[  268s] make[1]: *** [debian/rules:26: override_dh_auto_test] Error 1
[  268s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  268s] make: *** [debian/rules:15: build] Error 2
[  268s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  268s] ### VM INTERACTION START ###
[  272s] [  263.175730] sysrq: Power Off
[  272s] [  263.177436] reboot: Power down
[  272s] ### VM INTERACTION END ###
[  272s] 
[  272s] hci-cnode2-m1 failed "build libosmocore_1.4.0.120.a521.dsc" at Fri Oct 
 9 01:33:19 UTC 2020.
[  272s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-pcu[master]: pcu_l1_if: use network byte order for all ports

[lynxis lazus]

Hello Jenkins Builder, pespin, Vadim Yanitskiy,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/20498

to look at the new patch set (#2).

Change subject: pcu_l1_if: use network byte order for all ports
..

pcu_l1_if: use network byte order for all ports

Having all connection information in network byte order
make it more consistent to me.
Change-Id: I675cc2564eab5125e08291e44b6cb66082f694b9

Change-Id: Ia3829c8275520d1c6e694c16459658c5dc4714d7
---
M src/pcu_l1_if.cpp
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/98/20498/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20498
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia3829c8275520d1c6e694c16459658c5dc4714d7
Gerrit-Change-Number: 20498
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: bsc: copy osmo-bsc.cfg from docker-playground

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20499 )


Change subject: bsc: copy osmo-bsc.cfg from docker-playground
..

bsc: copy osmo-bsc.cfg from docker-playground

The old file wasn't valid anymore.

Change-Id: Ic72bd755828d0cb6c5858e2fb7800e875f64369a
---
M bts/osmo-bsc.cfg
1 file changed, 91 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/99/20499/1

diff --git a/bts/osmo-bsc.cfg b/bts/osmo-bsc.cfg
index 84a3a3c..153ae11 100644
--- a/bts/osmo-bsc.cfg
+++ b/bts/osmo-bsc.cfg
@@ -44,7 +44,7 @@
  handover1 power budget interval 6
  handover1 power budget hysteresis 3
  handover1 maximum distance 
- periodic location update 30
+ timer t3212 30
  bts 0
   type sysmobts
   band DCS1800
@@ -75,7 +75,6 @@
   si5 neighbor-list add arfcn 20
   codec-support fr
   gprs mode gprs
-  gprs 11bit_rach_support_for_egprs 0
   gprs routing area 0
   gprs network-control-order nc0
   gprs cell bvci 1234
@@ -133,13 +132,99 @@
timeslot 7
 phys_chan_config PDCH
 hopping enabled 0
+  trx 1
+   rf_locked 0
+   arfcn 873
+   nominal power 50
+   max_power_red 20
+   rsl e1 tei 1
+   timeslot 0
+phys_chan_config SDCCH8
+hopping enabled 0
+   timeslot 1
+phys_chan_config TCH/F
+hopping enabled 0
+   timeslot 2
+phys_chan_config TCH/F
+hopping enabled 0
+   timeslot 3
+phys_chan_config TCH/F_PDCH
+hopping enabled 0
+   timeslot 4
+phys_chan_config TCH/F_TCH/H_PDCH
+hopping enabled 0
+   timeslot 5
+phys_chan_config TCH/H
+hopping enabled 0
+   timeslot 6
+phys_chan_config SDCCH8
+hopping enabled 0
+   timeslot 7
+phys_chan_config PDCH
+hopping enabled 0
+  trx 2
+   rf_locked 0
+   arfcn 875
+   nominal power 50
+   max_power_red 20
+   rsl e1 tei 2
+   timeslot 0
+phys_chan_config SDCCH8
+hopping enabled 0
+   timeslot 1
+phys_chan_config TCH/F
+hopping enabled 0
+   timeslot 2
+phys_chan_config TCH/F
+hopping enabled 0
+   timeslot 3
+phys_chan_config TCH/F_PDCH
+hopping enabled 0
+   timeslot 4
+phys_chan_config TCH/F_TCH/H_PDCH
+hopping enabled 0
+   timeslot 5
+phys_chan_config TCH/H
+hopping enabled 0
+   timeslot 6
+phys_chan_config SDCCH8
+hopping enabled 0
+   timeslot 7
+phys_chan_config PDCH
+hopping enabled 0
+  trx 3
+   rf_locked 0
+   arfcn 877
+   nominal power 50
+   max_power_red 20
+   rsl e1 tei 3
+   timeslot 0
+phys_chan_config SDCCH8
+hopping enabled 0
+   timeslot 1
+phys_chan_config TCH/F
+hopping enabled 0
+   timeslot 2
+phys_chan_config TCH/F
+hopping enabled 0
+   timeslot 3
+phys_chan_config TCH/F_PDCH
+hopping enabled 0
+   timeslot 4
+phys_chan_config TCH/F_TCH/H_PDCH
+hopping enabled 0
+   timeslot 5
+phys_chan_config TCH/H
+hopping enabled 0
+   timeslot 6
+phys_chan_config SDCCH8
+hopping enabled 0
+   timeslot 7
+phys_chan_config PDCH
+hopping enabled 0
 msc 0
  core-location-area-code 666
  core-cell-identity 333
- ip.access rtp-base 4000
- timeout-ping 12
- timeout-pong 14
- no timeout-ping advanced
  no bsc-welcome-text
  no bsc-msc-lost-text
  no bsc-grace-text

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20499
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic72bd755828d0cb6c5858e2fb7800e875f64369a
Gerrit-Change-Number: 20499
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange

Change in osmo-pcu[master]: pcu_l1_if: use network byte order for all ports

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/20498 )


Change subject: pcu_l1_if: use network byte order for all ports
..

pcu_l1_if: use network byte order for all ports

Having all connection information in network byte order
make it more consistent to me.
Change-Id: I675cc2564eab5125e08291e44b6cb66082f694b9

Change-Id: Ia3829c8275520d1c6e694c16459658c5dc4714d7
---
M src/pcu_l1_if.cpp
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/98/20498/1

diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index b2a44d7..fb9cd12 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -586,20 +586,20 @@
case PCU_IF_ADDR_TYPE_IPV4:
local_sockaddr.u.sin.sin_family = AF_INET;
local_sockaddr.u.sin.sin_addr.s_addr = INADDR_ANY;
-   local_sockaddr.u.sin.sin_port = 
htons(info_ind->local_port[i]);
+   local_sockaddr.u.sin.sin_port = info_ind->local_port[i];

remote_sockaddr.u.sin.sin_family = AF_INET;
remote_sockaddr.u.sin.sin_addr = 
info_ind->remote_ip[i].v4;
-   remote_sockaddr.u.sin.sin_port = 
htons(info_ind->remote_port[i]);
+   remote_sockaddr.u.sin.sin_port = 
info_ind->remote_port[i];
break;
case PCU_IF_ADDR_TYPE_IPV6:
local_sockaddr.u.sin6.sin6_family = AF_INET6;
local_sockaddr.u.sin6.sin6_addr = in6addr_any;
-   local_sockaddr.u.sin6.sin6_port = 
htons(info_ind->local_port[i]);
+   local_sockaddr.u.sin6.sin6_port = 
info_ind->local_port[i];

remote_sockaddr.u.sin6.sin6_family = AF_INET6;
remote_sockaddr.u.sin6.sin6_addr = 
info_ind->remote_ip[i].v6;
-   remote_sockaddr.u.sin6.sin6_port = 
htons(info_ind->remote_port[i]);
+   remote_sockaddr.u.sin6.sin6_port = 
info_ind->remote_port[i];
break;
default:
continue;

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20498
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia3829c8275520d1c6e694c16459658c5dc4714d7
Gerrit-Change-Number: 20498
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange

Change in osmo-bsc[master]: sysmobts: expect feature IPV6_NSVC

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20477 )

Change subject: sysmobts: expect feature IPV6_NSVC
..


Patch Set 1:

It creates a notice if the expected features doesn't match the features of the 
bts.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20477
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I711efca931012b8e66516f2721390e9dbdbb72a8
Gerrit-Change-Number: 20477
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 23:39:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pcu_l1_if: cosmetic: use ARRAY_SIZE() in pcu_rx_info_ind()

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/20488 )

Change subject: pcu_l1_if: cosmetic: use ARRAY_SIZE() in pcu_rx_info_ind()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20488
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iff11c854b1687f75c1125a5bcd616da95ade69ee
Gerrit-Change-Number: 20488
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Thu, 08 Oct 2020 23:32:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pcu_l1_if: correct logging level in pcu_rx_info_ind()

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/20489 )

Change subject: pcu_l1_if: correct logging level in pcu_rx_info_ind()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20489
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib4bb9b907fc2bf279cf22a3bb9b95ea1a0fb3db6
Gerrit-Change-Number: 20489
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Thu, 08 Oct 2020 23:32:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: LCS: allow RSL EST IND during GSCON_ST_ACTIVE

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20358 )

Change subject: LCS: allow RSL EST IND during GSCON_ST_ACTIVE
..


Patch Set 8: Code-Review+2

combine


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20358
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib18a12f8b8bcfb356188b2c0d97d555c1850f23e
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 8
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 22:40:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: LCS: implement the bulk of Location Services

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20357 )

Change subject: LCS: implement the bulk of Location Services
..


Patch Set 10:

finally a V+1! thank heavens.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872
Gerrit-Change-Number: 20357
Gerrit-PatchSet: 10
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 22:39:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-bsc[master]: LCS: implement the bulk of Location Services

[neels]

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20357

to look at the new patch set (#10).

Change subject: LCS: implement the bulk of Location Services
..

LCS: implement the bulk of Location Services

Depends: I4d7302a4853518916b6b425e710c10568eb2ffe5 (libosmocore)
Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872
---
M TODO-RELEASE
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/bsc_msc_data.h
M include/osmocom/bsc/bsc_subscr_conn_fsm.h
M include/osmocom/bsc/debug.h
M include/osmocom/bsc/gsm_data.h
A include/osmocom/bsc/lb.h
A include/osmocom/bsc/lcs_loc_req.h
A include/osmocom/bsc/lcs_ta_req.h
M include/osmocom/bsc/paging.h
M include/osmocom/bsc/vty.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/bsc_init.c
M src/osmo-bsc/bsc_sccp.c
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/gsm_08_08.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/handover_fsm.c
A src/osmo-bsc/lb.c
A src/osmo-bsc/lcs_loc_req.c
A src/osmo-bsc/lcs_ta_req.c
M src/osmo-bsc/net_init.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/osmo_bsc_main.c
M src/osmo-bsc/osmo_bsc_msc.c
M src/osmo-bsc/paging.c
M tests/bsc/bsc_test.c
M tests/handover/Makefile.am
M tests/timer.vty
30 files changed, 1,858 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872
Gerrit-Change-Number: 20357
Gerrit-PatchSet: 10
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Introduce NM BTS Site Manager FSM

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20400 )

Change subject: Introduce NM BTS Site Manager FSM
..


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/20400/5/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20400/5/src/osmo-bsc/abis_nm.c@832
PS5, Line 832:  DEB
> shouldnt a NACK be ERROR or at least NOTICE ins tead of DEBUG?
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20400
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic001ce6ebeff6f51470ef58140b0235f4a30265e
Gerrit-Change-Number: 20400
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 21:35:06 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in libosmo-abis[master]: vty: add attributes to VTY commands indicating when they apply

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/20487 )

Change subject: vty: add attributes to VTY commands indicating when they apply
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/20487
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ie0182351bd8a10085563c403dfab04c4d1b4305c
Gerrit-Change-Number: 20487
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 21:02:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-abis[master]: vty: add attributes to VTY commands indicating when they apply

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/20487 )

Change subject: vty: add attributes to VTY commands indicating when they apply
..

vty: add attributes to VTY commands indicating when they apply

Change-Id: Ie0182351bd8a10085563c403dfab04c4d1b4305c
Depends: libosmocore I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Related: SYS#4937, OS#1601
---
M src/e1_input_vty.c
1 file changed, 59 insertions(+), 47 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/e1_input_vty.c b/src/e1_input_vty.c
index 2dc873f..d915c19 100644
--- a/src/e1_input_vty.c
+++ b/src/e1_input_vty.c
@@ -43,6 +43,8 @@
 #include 
 #include 

+#define X(x) (1 << x)
+
 /* CONFIG */

 #define E1_DRIVER_NAMES
"(misdn|misdn_lapd|dahdi|e1d|ipa|unixsocket)"
@@ -55,6 +57,8 @@

 #define E1_LINE_HELP   "Configure E1/T1/J1 Line\n" "Line Number\n"

+/* Note: This requires a full restart of the application, since once created
+ * an E1 line can not be destroyed again. */
 DEFUN(cfg_e1line_driver, cfg_e1_line_driver_cmd,
"e1_line <0-255> driver " E1_DRIVER_NAMES,
E1_LINE_HELP "Set driver for this line\n"
@@ -77,10 +81,11 @@
return CMD_SUCCESS;
 }

-DEFUN(cfg_e1line_port, cfg_e1_line_port_cmd,
-   "e1_line <0-255> port <0-255>",
-   E1_LINE_HELP "Set physical port/span/card number\n"
-   "E1/T1 Port/Span/Card number\n")
+DEFUN_USRATTR(cfg_e1line_port, cfg_e1_line_port_cmd,
+ X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
+ "e1_line <0-255> port <0-255>",
+ E1_LINE_HELP "Set physical port/span/card number\n"
+ "E1/T1 Port/Span/Card number\n")
 {
struct e1inp_line *line;
int e1_nr = atoi(argv[0]);
@@ -96,10 +101,11 @@
return CMD_SUCCESS;
 }

-DEFUN(cfg_e1line_socket, cfg_e1_line_socket_cmd,
-   "e1_line <0-255> socket .SOCKET",
-   E1_LINE_HELP "Set socket path for unixsocket\n"
-   "socket path\n")
+DEFUN_USRATTR(cfg_e1line_socket, cfg_e1_line_socket_cmd,
+ X(OSMO_ABIS_LIB_ATTR_LINE_UPD),
+ "e1_line <0-255> socket .SOCKET",
+ E1_LINE_HELP "Set socket path for unixsocket\n"
+ "socket path\n")
 {
struct e1inp_line *line;
int e1_nr = atoi(argv[0]);
@@ -146,29 +152,32 @@
return CMD_SUCCESS;
 }

-DEFUN(cfg_e1line_keepalive, cfg_e1_line_keepalive_cmd,
-   "e1_line <0-255> keepalive",
-   E1_LINE_HELP KEEPALIVE_HELP)
+DEFUN_USRATTR(cfg_e1line_keepalive, cfg_e1_line_keepalive_cmd,
+ X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
+ "e1_line <0-255> keepalive",
+ E1_LINE_HELP KEEPALIVE_HELP)
 {
return set_keepalive_params(vty, atoi(argv[0]),
E1INP_USE_DEFAULT, E1INP_USE_DEFAULT,
E1INP_USE_DEFAULT);
 }

-DEFUN(cfg_e1line_keepalive_params, cfg_e1_line_keepalive_params_cmd,
-   "e1_line <0-255> keepalive <1-300> <1-20> <1-300>",
-   E1_LINE_HELP KEEPALIVE_HELP
-   "Idle interval in seconds before probes are sent\n"
-   "Number of probes to sent\n"
-   "Delay between probe packets in seconds\n")
+DEFUN_USRATTR(cfg_e1line_keepalive_params, cfg_e1_line_keepalive_params_cmd,
+ X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
+ "e1_line <0-255> keepalive <1-300> <1-20> <1-300>",
+ E1_LINE_HELP KEEPALIVE_HELP
+ "Idle interval in seconds before probes are sent\n"
+ "Number of probes to sent\n"
+ "Delay between probe packets in seconds\n")
 {
return set_keepalive_params(vty, atoi(argv[0]),
atoi(argv[1]), atoi(argv[2]), 
atoi(argv[3]));
 }

-DEFUN(cfg_e1line_no_keepalive, cfg_e1_line_no_keepalive_cmd,
-   "no e1_line <0-255> keepalive",
-   NO_STR E1_LINE_HELP KEEPALIVE_HELP)
+DEFUN_USRATTR(cfg_e1line_no_keepalive, cfg_e1_line_no_keepalive_cmd,
+ X(OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK),
+ "no e1_line <0-255> keepalive",
+ NO_STR E1_LINE_HELP KEEPALIVE_HELP)
 {
return set_keepalive_params(vty, atoi(argv[0]), 0, 0, 0);
 }
@@ -198,25 +207,26 @@
return CMD_SUCCESS;
 }

-DEFUN(cfg_e1line_ipa_keepalive, cfg_e1_line_ipa_keepalive_cmd,
-   "e1_line <0-255> ipa-keepalive <1-300> <1-300>",
-   E1_LINE_HELP IPA_KEEPALIVE_HELP
-   "Idle interval in seconds before probes are sent\n"
-   "Time to wait for PONG response\n")
+DEFUN_ATTR(cfg_e1line_ipa_keepalive, cfg_e1_line_ipa_keepalive_cmd,
+  "e1_line <0-255> ipa-keepalive <1-300> <1-300>",
+  E1_LINE_HELP IPA_KEEPALIVE_HELP
+  "Idle interval in seconds before probes are sent\n"
+  "Time to wait for PONG response\n", CMD_ATTR_IMMEDIATE)
 {
return set_ipa_keepalive_params(vty, atoi(argv[0]), atoi(argv[1]), 
atoi(argv[2]));
 }

Change in osmo-bsc[master]: LCS: implement the bulk of Location Services

[neels]

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20357

to look at the new patch set (#9).

Change subject: LCS: implement the bulk of Location Services
..

LCS: implement the bulk of Location Services

Depends: I4d7302a4853518916b6b425e710c10568eb2ffe5 (libosmocore)
Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872
---
M TODO-RELEASE
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/bsc_msc_data.h
M include/osmocom/bsc/bsc_subscr_conn_fsm.h
M include/osmocom/bsc/debug.h
M include/osmocom/bsc/gsm_data.h
A include/osmocom/bsc/lb.h
A include/osmocom/bsc/lcs_loc_req.h
A include/osmocom/bsc/lcs_ta_req.h
M include/osmocom/bsc/paging.h
M include/osmocom/bsc/vty.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/bsc_init.c
M src/osmo-bsc/bsc_sccp.c
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/gsm_08_08.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/handover_fsm.c
A src/osmo-bsc/lb.c
A src/osmo-bsc/lcs_loc_req.c
A src/osmo-bsc/lcs_ta_req.c
M src/osmo-bsc/net_init.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/osmo_bsc_main.c
M src/osmo-bsc/osmo_bsc_msc.c
M src/osmo-bsc/paging.c
M tests/bsc/bsc_test.c
M tests/handover/Makefile.am
M tests/timer.vty
30 files changed, 1,858 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/9
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872
Gerrit-Change-Number: 20357
Gerrit-PatchSet: 9
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-mgw[master]: mgcp_vty: add user attributes to configuration commands

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/20250 )

Change subject: mgcp_vty: add user attributes to configuration commands
..

mgcp_vty: add user attributes to configuration commands

To make clear which configuration changes (configure terminal)
apply when, add appropriate user attributes to VTY commands.

Change-Id: I2d9487801b3b78f94577264b56d217c926ef76a9
Related: SYS#4937, OS#1601
---
M include/osmocom/mgcp/vty.h
M src/libosmo-mgcp/mgcp_vty.c
M src/osmo-mgw/mgw_main.c
3 files changed, 248 insertions(+), 180 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/include/osmocom/mgcp/vty.h b/include/osmocom/mgcp/vty.h
index bf6b7a8..862691f 100644
--- a/include/osmocom/mgcp/vty.h
+++ b/include/osmocom/mgcp/vty.h
@@ -6,3 +6,7 @@
MGCP_NODE = _LAST_OSMOVTY_NODE + 1,
TRUNK_NODE,
 };
+
+enum mgw_vty_cmd_attr {
+   MGW_CMD_ATTR_NEWCONN = 0,
+};
diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c
index 440452f..74e8da0 100644
--- a/src/libosmo-mgcp/mgcp_vty.c
+++ b/src/libosmo-mgcp/mgcp_vty.c
@@ -42,6 +42,7 @@
 #define RTP_KEEPALIVE_STR "Send dummy UDP packet to net RTP destination\n"
 #define RTP_TS101318_RFC5993_CONV_STR "Convert GSM-HR from TS101318 to RFC5993 
and vice versa\n"

+#define X(x) (1 << x)

 static struct mgcp_config *g_cfg = NULL;

@@ -408,13 +409,14 @@
return CMD_SUCCESS;
 }

-DEFUN(cfg_mgcp_local_ip,
-  cfg_mgcp_local_ip_cmd,
-  "local ip " VTY_IPV46_CMD,
-  "Local options for the SDP record\n"
-  IP_STR
-  "IPv4 Address to use in SDP record\n"
-  "IPv6 Address to use in SDP record\n")
+DEFUN_USRATTR(cfg_mgcp_local_ip,
+ cfg_mgcp_local_ip_cmd,
+ X(MGW_CMD_ATTR_NEWCONN),
+ "local ip " VTY_IPV46_CMD,
+ "Local options for the SDP record\n"
+ IP_STR
+ "IPv4 Address to use in SDP record\n"
+ "IPv6 Address to use in SDP record\n")
 {
osmo_talloc_replace_string(g_cfg, _cfg->local_ip, argv[0]);
return CMD_SUCCESS;
@@ -499,11 +501,12 @@
 RTP_STR "Range of ports to use for the NET side\n"
 RANGE_START_STR RANGE_END_STR)

-DEFUN(cfg_mgcp_rtp_bind_ip,
-  cfg_mgcp_rtp_bind_ip_cmd,
-  "rtp bind-ip A.B.C.D",
-  RTP_STR "Bind endpoints facing the Network\n"
-  "IPv4 Address to bind to\n")
+DEFUN_USRATTR(cfg_mgcp_rtp_bind_ip,
+ cfg_mgcp_rtp_bind_ip_cmd,
+ X(MGW_CMD_ATTR_NEWCONN),
+ "rtp bind-ip A.B.C.D",
+ RTP_STR "Bind endpoints facing the Network\n"
+ "IPv4 Address to bind to\n")
 {
osmo_talloc_replace_string(g_cfg, _cfg->net_ports.bind_addr_v4, 
argv[0]);
return CMD_SUCCESS;
@@ -513,11 +516,12 @@
 "rtp net-bind-ip A.B.C.D",
 RTP_STR "Bind endpoints facing the Network\n" "Address to bind 
to\n")

-DEFUN(cfg_mgcp_rtp_no_bind_ip,
-  cfg_mgcp_rtp_no_bind_ip_cmd,
-  "no rtp bind-ip",
-  NO_STR RTP_STR "Bind endpoints facing the Network\n"
-  "Address to bind to\n")
+DEFUN_USRATTR(cfg_mgcp_rtp_no_bind_ip,
+ cfg_mgcp_rtp_no_bind_ip_cmd,
+ X(MGW_CMD_ATTR_NEWCONN),
+ "no rtp bind-ip",
+ NO_STR RTP_STR "Bind endpoints facing the Network\n"
+ "Address to bind to\n")
 {
talloc_free(g_cfg->net_ports.bind_addr_v4);
g_cfg->net_ports.bind_addr_v4 = NULL;
@@ -529,50 +533,55 @@
 NO_STR RTP_STR "Bind endpoints facing the Network\n"
 "Address to bind to\n")

-DEFUN(cfg_mgcp_rtp_bind_ip_v6,
-  cfg_mgcp_rtp_bind_ip_v6_cmd,
-  "rtp bind-ip-v6 " VTY_IPV6_CMD,
-  RTP_STR "Bind endpoints facing the Network\n"
-  "IPv6 Address to bind to\n")
+DEFUN_USRATTR(cfg_mgcp_rtp_bind_ip_v6,
+ cfg_mgcp_rtp_bind_ip_v6_cmd,
+ X(MGW_CMD_ATTR_NEWCONN),
+ "rtp bind-ip-v6 " VTY_IPV6_CMD,
+ RTP_STR "Bind endpoints facing the Network\n"
+ "IPv6 Address to bind to\n")
 {
osmo_talloc_replace_string(g_cfg, _cfg->net_ports.bind_addr_v6, 
argv[0]);
return CMD_SUCCESS;
 }

-DEFUN(cfg_mgcp_rtp_no_bind_ip_v6,
-cfg_mgcp_rtp_no_bind_ip_v6_cmd,
-"no rtp bind-ip-v6",
-NO_STR RTP_STR "Bind endpoints facing the Network\n"
-"Address to bind to\n")
+DEFUN_USRATTR(cfg_mgcp_rtp_no_bind_ip_v6,
+ cfg_mgcp_rtp_no_bind_ip_v6_cmd,
+ X(MGW_CMD_ATTR_NEWCONN),
+ "no rtp bind-ip-v6",
+ NO_STR RTP_STR "Bind endpoints facing the Network\n"
+ "Address to bind to\n")
 {
talloc_free(g_cfg->net_ports.bind_addr_v6);
g_cfg->net_ports.bind_addr_v6 = NULL;
return CMD_SUCCESS;
 }

-DEFUN(cfg_mgcp_rtp_net_bind_ip_probing,
-  cfg_mgcp_rtp_net_bind_ip_probing_cmd,
-  "rtp ip-probing",
-  RTP_STR "automatic rtp 

Change in osmo-mgw[master]: mgcp_vty: add user attributes to configuration commands

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/20250 )

Change subject: mgcp_vty: add user attributes to configuration commands
..


Patch Set 7: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20250
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I2d9487801b3b78f94577264b56d217c926ef76a9
Gerrit-Change-Number: 20250
Gerrit-PatchSet: 7
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 21:01:38 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-mgw[master]: mgcp_vty: add user attributes to configuration commands

[dexter]

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/20250 )

Change subject: mgcp_vty: add user attributes to configuration commands
..


Patch Set 7:

(2 comments)

(ensuring all comments are sent)

https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c@406
PS6, Line 406: CMD_ATTR_IMMEDIATE
> It's not a configuration command, but a navigation command. […]
Ack


https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c@930
PS6, Line 930: CMD_ATTR_IMMEDIATE
> Here I agree, because this command may allocate a new trunk.
I think I remove the attribute here as well. The trunks are allocated 
immediately, but with 0 endpoints, the endpoint allocation happens at the next 
restart.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20250
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I2d9487801b3b78f94577264b56d217c926ef76a9
Gerrit-Change-Number: 20250
Gerrit-PatchSet: 7
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 21:00:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Yanitskiy 
Gerrit-MessageType: comment

Change in osmo-bts[master]: oml: fix handling of NSVC local port in oml_ipa_mo_set_attr_nsvc()

[lynxis lazus]

lynxis lazus has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20495 )

Change subject: oml: fix handling of NSVC local port in 
oml_ipa_mo_set_attr_nsvc()
..

oml: fix handling of NSVC local port in oml_ipa_mo_set_attr_nsvc()

This is another regresion introduced by [1].  Both local and remote
port numbers recived in the network order, and must be stored as-is.

Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450
Fixes: I310699fabbfec4255f0474f31717f215c1201eca
Related: SYS#4915
---
M src/common/oml.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/oml.c b/src/common/oml.c
index 5394e8a..2a87b03 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1272,7 +1272,7 @@
nsvc->remote.u.sin.sin_addr.s_addr = _cur_l;
cur += 4;
memcpy(&_cur_s, cur, 2);
-   nsvc->local.u.sin.sin_port = ntohs(_cur_s);
+   nsvc->local.u.sin.sin_port = _cur_s;
}

if (TLVP_PRES_LEN(tp, NM_ATT_OSMO_NS_LINK_CFG, 10)) {

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20495
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450
Gerrit-Change-Number: 20495
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: oml: fix handling of NSVC local port in oml_ipa_mo_set_attr_nsvc()

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20495 )

Change subject: oml: fix handling of NSVC local port in 
oml_ipa_mo_set_attr_nsvc()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20495
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450
Gerrit-Change-Number: 20495
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 20:50:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: use llist_for_each_entry() in pcu_sock_close()

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20493 )

Change subject: pcu_sock: use llist_for_each_entry() in pcu_sock_close()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20493
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 20:32:26 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20494 )

Change subject: pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too
..

pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too

Change-Id: Ib0efa6e1e2a68ac9675a18487b79d9b14bdb22c5
Fixes: OS#4785
---
M src/common/pcu_sock.c
1 file changed, 9 insertions(+), 8 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index d54e385..6040de5 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -882,7 +882,6 @@
struct osmo_fd *bfd = >conn_bfd;
struct gsm_bts *bts;
struct gsm_bts_trx *trx;
-   struct gsm_bts_trx_ts *ts;
unsigned int tn;

/* FIXME: allow multiple BTS */
@@ -913,13 +912,15 @@
/* Deactivate all active PDCH timeslots */
llist_for_each_entry(trx, >trx_list, list) {
for (tn = 0; tn < 8; tn++) {
-   ts = >ts[tn];
-   if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED
-&& ts->pchan == GSM_PCHAN_PDCH) {
-   ts->lchan[0].rel_act_kind = LCHAN_REL_ACT_PCU;
-   l1sap_chan_rel(trx,
-   gsm_lchan2chan_nr(>lchan[0]));
-   }
+   struct gsm_bts_trx_ts *ts = >ts[tn];
+
+   if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED)
+   continue;
+   if (!ts_should_be_pdch(ts))
+   continue;
+
+   ts->lchan[0].rel_act_kind = LCHAN_REL_ACT_PCU;
+   l1sap_chan_rel(trx, gsm_lchan2chan_nr(>lchan[0]));
}
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20494
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib0efa6e1e2a68ac9675a18487b79d9b14bdb22c5
Gerrit-Change-Number: 20494
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: pcu_sock: use llist_for_each_entry() in pcu_sock_close()

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20493 )

Change subject: pcu_sock: use llist_for_each_entry() in pcu_sock_close()
..

pcu_sock: use llist_for_each_entry() in pcu_sock_close()

Using gsm_bts_trx_num() involves redundant iterations over the
list of transceivers - we definitely don't want them.

Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
---
M src/common/pcu_sock.c
1 file changed, 5 insertions(+), 8 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 7f7f7cf..d54e385 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -883,7 +883,7 @@
struct gsm_bts *bts;
struct gsm_bts_trx *trx;
struct gsm_bts_trx_ts *ts;
-   int i, j;
+   unsigned int tn;

/* FIXME: allow multiple BTS */
bts = llist_entry(state->net->bts_list.next, struct gsm_bts, list);
@@ -910,13 +910,10 @@
osmo_signal_dispatch(SS_GLOBAL, S_NEW_SYSINFO, bts);
 #endif

-   /* release PDCH */
-   for (i = 0; i < 8; i++) {
-   trx = gsm_bts_trx_num(bts, i);
-   if (!trx)
-   break;
-   for (j = 0; j < 8; j++) {
-   ts = >ts[j];
+   /* Deactivate all active PDCH timeslots */
+   llist_for_each_entry(trx, >trx_list, list) {
+   for (tn = 0; tn < 8; tn++) {
+   ts = >ts[tn];
if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED
 && ts->pchan == GSM_PCHAN_PDCH) {
ts->lchan[0].rel_act_kind = LCHAN_REL_ACT_PCU;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20493
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bsc[master]: remove unused osmo_bsc_reset.h

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20497 )

Change subject: remove unused osmo_bsc_reset.h
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20497
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib315da03d1731a0e79d09ac886e363890ac815b4
Gerrit-Change-Number: 20497
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 08 Oct 2020 20:32:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: LCS: implement the bulk of Location Services

[neels]

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20357

to look at the new patch set (#8).

Change subject: LCS: implement the bulk of Location Services
..

LCS: implement the bulk of Location Services

Depends: I4d7302a4853518916b6b425e710c10568eb2ffe5 (libosmocore)
Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872
---
M TODO-RELEASE
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/bsc_msc_data.h
M include/osmocom/bsc/bsc_subscr_conn_fsm.h
M include/osmocom/bsc/debug.h
M include/osmocom/bsc/gsm_data.h
A include/osmocom/bsc/lb.h
A include/osmocom/bsc/lcs_loc_req.h
A include/osmocom/bsc/lcs_ta_req.h
M include/osmocom/bsc/paging.h
M include/osmocom/bsc/vty.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/bsc_init.c
M src/osmo-bsc/bsc_sccp.c
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/gsm_08_08.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/handover_fsm.c
A src/osmo-bsc/lb.c
A src/osmo-bsc/lcs_loc_req.c
A src/osmo-bsc/lcs_ta_req.c
M src/osmo-bsc/net_init.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/osmo_bsc_main.c
M src/osmo-bsc/osmo_bsc_msc.c
M src/osmo-bsc/paging.c
M tests/bsc/bsc_test.c
M tests/handover/Makefile.am
M tests/timer.vty
30 files changed, 1,861 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/20357/8
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872
Gerrit-Change-Number: 20357
Gerrit-PatchSet: 8
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: remove unused osmo_bsc_reset.h

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20497 )


Change subject: remove unused osmo_bsc_reset.h
..

remove unused osmo_bsc_reset.h

Change-Id: Ib315da03d1731a0e79d09ac886e363890ac815b4
---
D include/osmocom/bsc/osmo_bsc_reset.h
1 file changed, 0 insertions(+), 34 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/20497/1

diff --git a/include/osmocom/bsc/osmo_bsc_reset.h 
b/include/osmocom/bsc/osmo_bsc_reset.h
deleted file mode 100644
index fb66df0..000
--- a/include/osmocom/bsc/osmo_bsc_reset.h
+++ /dev/null
@@ -1,34 +0,0 @@
-/* (C) 2017 by sysmocom s.f.m.c. GmbH
- * All Rights Reserved
- *
- * Author: Philipp Maier
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see .
- *
- */
-
-/* Create and start state machine which handles the reset/reset-ack procedure 
*/
-void start_reset_fsm(struct bsc_msc_data *msc);
-
-/* Confirm that we successfully received a reset acknowledge message */
-void reset_ack_confirm(struct bsc_msc_data *msc);
-
-/* Report a failed connection */
-void report_conn_fail(struct bsc_msc_data *msc);
-
-/* Report a successful connection */
-void report_conn_success(struct bsc_msc_data *msc);
-
-/* Check if we have a connection to a specified msc */
-bool sccp_conn_ready(struct bsc_msc_data *msc);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20497
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib315da03d1731a0e79d09ac886e363890ac815b4
Gerrit-Change-Number: 20497
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: pcu_sock: use llist_for_each_entry() in pcu_sock_close()

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20493 )

Change subject: pcu_sock: use llist_for_each_entry() in pcu_sock_close()
..


Patch Set 1:

Ok, this is not really related and can be done in a separate change.
Is there anything preventing us from merging this one?


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20493
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 20:11:36 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in libosmocore[master]: command: add library command attribute for libosmo-abis

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/20481 )

Change subject: command: add library command attribute for libosmo-abis
..

command: add library command attribute for libosmo-abis

Change-Id: I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Related: SYS#4937, OS#1601
---
M include/osmocom/vty/command.h
M src/vty/command.c
M tests/vty/vty_transcript_test.vty
3 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved



diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h
index 232da2c..2cb45dd 100644
--- a/include/osmocom/vty/command.h
+++ b/include/osmocom/vty/command.h
@@ -153,6 +153,8 @@
 * 3. Values are not flags but indexes, unlike CMD_ATTR_*.
 * 4. Ordering: new entries added before _OSMO_CORE_LIB_ATTR_COUNT. */
OSMO_SCCP_LIB_ATTR_RSTRT_ASP,
+   OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK,
+   OSMO_ABIS_LIB_ATTR_LINE_UPD,

/* Keep this floating entry last, it's needed for count check. */
_OSMO_CORE_LIB_ATTR_COUNT
diff --git a/src/vty/command.c b/src/vty/command.c
index 4952567..fae925e 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -654,6 +654,10 @@
 *  "Brief but meaningful description", */
[OSMO_SCCP_LIB_ATTR_RSTRT_ASP] = \
"This command applies on ASP restart",
+   [OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK] = \
+   "This command applies on IPA link establishment",
+   [OSMO_ABIS_LIB_ATTR_LINE_UPD] = \
+   "This command applies on E1 line update",
 };

 /* Flag letters of attributes shared between the lib commands.
@@ -661,6 +665,8 @@
 static const char cmd_lib_attr_letters[32] = {
/* [OSMO_LIBNAME_LIB_ATTR_ATTRNAME] =   'X', */
[OSMO_SCCP_LIB_ATTR_RSTRT_ASP] ='A',
+   [OSMO_ABIS_LIB_ATTR_IPA_NEW_LNK] =  'I',
+   [OSMO_ABIS_LIB_ATTR_LINE_UPD] = 'L',
 };

 /*
diff --git a/tests/vty/vty_transcript_test.vty 
b/tests/vty/vty_transcript_test.vty
index b626f3d..2c618d8 100644
--- a/tests/vty/vty_transcript_test.vty
+++ b/tests/vty/vty_transcript_test.vty
@@ -91,6 +91,8 @@
 @  This command applies on VTY node exit
   Library specific attributes:
 A  This command applies on ASP restart
+I  This command applies on IPA link establishment
+L  This command applies on E1 line update
   Application specific attributes:
 u  Unbelievable: not able to be believed; unlikely to be true
 m  Magnificent: impressively beautiful, elaborate, or extravagant

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20481
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Gerrit-Change-Number: 20481
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-mgw[master]: mgcp_vty: add user attributes to configuration commands

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/20250 )

Change subject: mgcp_vty: add user attributes to configuration commands
..


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c@930
PS6, Line 930: CMD_ATTR_IMMEDIATE
> Here I agree, because this command may allocate a new trunk.
Hm? Vadim agreed that it shoudl be DEFUN_ATTR but you still changed it back to 
DEFUN?



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20250
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I2d9487801b3b78f94577264b56d217c926ef76a9
Gerrit-Change-Number: 20250
Gerrit-PatchSet: 7
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:58:00 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Yanitskiy 
Gerrit-MessageType: comment

Change in libosmo-abis[master]: vty: add attributes to VTY commands indicating when they apply

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/20487 )

Change subject: vty: add attributes to VTY commands indicating when they apply
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/20487
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ie0182351bd8a10085563c403dfab04c4d1b4305c
Gerrit-Change-Number: 20487
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:59:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: gsm_08_08: fix unreachable code in parse_powercap()

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20496 )

Change subject: gsm_08_08: fix unreachable code in parse_powercap()
..

gsm_08_08: fix unreachable code in parse_powercap()

The function parse_powercap() contains a nested switch case statement
that is used to populate the variables lu and pwr_lev. Those variables
are used at the bottom of the function later. Unfortunately the (outer)
switch case that consumes the pdisc variable does not put a break; at
the end of its only case "GSM48_PDISC_MM", which eventually causes a
fall through to the default case, which simply returns. Since this can
not be intended, lets add a break to make the bottom code reachable in
case lu and pwr_lev are successfully populated.

Change-Id: I48331cca784d8fa3a5904f2c4cf1555622b319e8
Fixes: CID#214886
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index f3214c7..b7c7448 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -343,6 +343,7 @@
/* No power cap in other messages */
return;
}
+   break;
/* FIXME: pwr_lev in Paging Response? */
default:
/* No power cap in other messages */

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20496
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I48331cca784d8fa3a5904f2c4cf1555622b319e8
Gerrit-Change-Number: 20496
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bsc[master]: gsm_08_08: fix unreachable code in parse_powercap()

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20496 )

Change subject: gsm_08_08: fix unreachable code in parse_powercap()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20496
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I48331cca784d8fa3a5904f2c4cf1555622b319e8
Gerrit-Change-Number: 20496
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:57:07 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-trx[master]: vty: add attributes to VTY commands indicating when they apply

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/20319 )

Change subject: vty: add attributes to VTY commands indicating when they apply
..

vty: add attributes to VTY commands indicating when they apply

Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43
Related: SYS#4937, OS#1601
---
M CommonLibs/trx_vty.c
1 file changed, 14 insertions(+), 12 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index 3fcf888..cf36547 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -415,12 +415,13 @@
INTV_STR_VAL(per-hour) \
INTV_STR_VAL(per-day)

-DEFUN(cfg_ctr_error_threshold, cfg_ctr_error_threshold_cmd,
-   "ctr-error-threshold " THRESHOLD_ARGS " <0-65535> " INTV_ARGS,
-   "Threshold rate for error counter\n"
-   THRESHOLD_STRS
-   "Value to set for threshold\n"
-   INTV_STRS)
+DEFUN_ATTR(cfg_ctr_error_threshold, cfg_ctr_error_threshold_cmd,
+  "ctr-error-threshold " THRESHOLD_ARGS " <0-65535> " INTV_ARGS,
+  "Threshold rate for error counter\n"
+  THRESHOLD_STRS
+  "Value to set for threshold\n"
+  INTV_STRS,
+  CMD_ATTR_IMMEDIATE)
 {
int rc;
struct ctr_threshold ctr;
@@ -446,12 +447,13 @@
return CMD_SUCCESS;
 }

-DEFUN(cfg_no_ctr_error_threshold, cfg_no_ctr_error_threshold_cmd,
-   "no ctr-error-threshold " THRESHOLD_ARGS " <0-65535> " INTV_ARGS,
-   NO_STR "Threshold rate for error counter\n"
-   THRESHOLD_STRS
-   "Value to set for threshold\n"
-   INTV_STRS)
+DEFUN_ATTR(cfg_no_ctr_error_threshold, cfg_no_ctr_error_threshold_cmd,
+  "no ctr-error-threshold " THRESHOLD_ARGS " <0-65535> " INTV_ARGS,
+  NO_STR "Threshold rate for error counter\n"
+  THRESHOLD_STRS
+  "Value to set for threshold\n"
+  INTV_STRS,
+  CMD_ATTR_IMMEDIATE)
 {
int rc;
struct ctr_threshold ctr;

--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43
Gerrit-Change-Number: 20319
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-trx[master]: vty: add attributes to VTY commands indicating when they apply

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/20319 )

Change subject: vty: add attributes to VTY commands indicating when they apply
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43
Gerrit-Change-Number: 20319
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:56:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: sched_lchan_tchh: initialize meas_avg with zeros

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20282 )

Change subject: sched_lchan_tchh: initialize meas_avg with zeros
..

sched_lchan_tchh: initialize meas_avg with zeros

in function rx_tchh_fn() the variable meas_avg is not initalized. This
is not always a problem, since most of the time trx_sched_meas_avg() is
populating the variable properly. In cases where a FACCH is transmitted
(chan_state->ul_ongoing_facch = true) the variable is left unpopulated.
In order to have at least stable values for those cases, initalize the
variable with zeros for the ongoing facch phase.

Change-Id: I5c3c1c41d22f9edaaf6bd4478dd04f090dca12a9
Fixes: CID#214480
---
M src/osmo-bts-trx/sched_lchan_tchh.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c 
b/src/osmo-bts-trx/sched_lchan_tchh.c
index c400542..18d90bb 100644
--- a/src/osmo-bts-trx/sched_lchan_tchh.c
+++ b/src/osmo-bts-trx/sched_lchan_tchh.c
@@ -125,6 +125,7 @@
memcpy(*bursts_p, *bursts_p + 232, 232);
memcpy(*bursts_p + 232, *bursts_p + 464, 232);
ber10k = 0;
+   memset(_avg, 0, sizeof(meas_avg));
goto bfi;
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20282
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5c3c1c41d22f9edaaf6bd4478dd04f090dca12a9
Gerrit-Change-Number: 20282
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-MessageType: merged

Change in osmo-bsc[master]: OML: Stay compatible with older osmo-bts versions

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20405 )

Change subject: OML: Stay compatible with older osmo-bts versions
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20405
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iaa036a2936f609b9b9721b2b4ad8d6deaf023f42
Gerrit-Change-Number: 20405
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:54:44 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: sched_lchan_tchh: initialize meas_avg with zeros

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20282 )

Change subject: sched_lchan_tchh: initialize meas_avg with zeros
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20282
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5c3c1c41d22f9edaaf6bd4478dd04f090dca12a9
Gerrit-Change-Number: 20282
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:55:17 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: Introduce Radio Channel FSM

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20404 )

Change subject: Introduce Radio Channel FSM
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20404
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iddc008c5737afb2fddd32c628bc5278056a64d89
Gerrit-Change-Number: 20404
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:54:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: Introduce NM RadioCarrier FSM

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20403 )

Change subject: Introduce NM RadioCarrier FSM
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20403
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ieed61d1fb1e896db42545c2c3421b20cb41ad549
Gerrit-Change-Number: 20403
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:53:49 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: Introduce NM BaseBand Transceiver FSM

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20402 )

Change subject: Introduce NM BaseBand Transceiver FSM
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20402
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib4d35316c52eb4c71ea0d352a1e06fd5e600fe08
Gerrit-Change-Number: 20402
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:53:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: Introduce NM BTS FSM

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20401 )

Change subject: Introduce NM BTS FSM
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20401
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7756a8ce90b6cc8a502b5665889a7987d7f749cb
Gerrit-Change-Number: 20401
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:52:03 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: Introduce NM BTS Site Manager FSM

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20400 )

Change subject: Introduce NM BTS Site Manager FSM
..


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/20400/5/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20400/5/src/osmo-bsc/abis_nm.c@832
PS5, Line 832:  DEB
shouldnt a NACK be ERROR or at least NOTICE ins tead of DEBUG?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20400
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic001ce6ebeff6f51470ef58140b0235f4a30265e
Gerrit-Change-Number: 20400
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:49:15 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: Set all NM OML objects to Locked by default

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20399 )

Change subject: Set all NM OML objects to Locked by default
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20399
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I68ae0bc51a565f903b47cf72f3e3dd6f1a2d2651
Gerrit-Change-Number: 20399
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:45:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: use llist_for_each_entry() in pcu_sock_close()

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20493 )

Change subject: pcu_sock: use llist_for_each_entry() in pcu_sock_close()
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/20493/1/src/common/pcu_sock.c
File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20493/1/src/common/pcu_sock.c@915
PS1, Line 915:  for (tn = 0; tn < 8; tn++) {
> iirc there was a define for that 8.
The "#define" is "ARRAY_SIZE(trx->ts)" ;)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20493
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:43:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20494 )

Change subject: pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20494
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib0efa6e1e2a68ac9675a18487b79d9b14bdb22c5
Gerrit-Change-Number: 20494
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:44:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: vty: add 'show gprs' command to show GPRS related info

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20484 )

Change subject: vty: add 'show gprs' command to show GPRS related info
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/20484/2/src/common/vty.c
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20484/2/src/common/vty.c@1030
PS2, Line 1030: DEFUN(show_gprs, show_gprs_cmd, "show gprs [<0-255>]"
I would think it makes more sense to use "show bts <0-0> gprs" here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20484
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I149eea0b1c109020406eb67c9082c335a77aab06
Gerrit-Change-Number: 20484
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:42:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: cosmetic: use ARRAY_SIZE() in pcu_tx_info_ind()

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20485 )

Change subject: pcu_sock: cosmetic: use ARRAY_SIZE() in pcu_tx_info_ind()
..

pcu_sock: cosmetic: use ARRAY_SIZE() in pcu_tx_info_ind()

Change-Id: I272ceb09a3e8cac0082dbec3a034776da71d9366
---
M src/common/pcu_sock.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 68cd039..ff788bf 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -327,7 +327,7 @@
info_ind->initial_mcs = rlcc->initial_mcs;

/* NSVC */
-   for (i = 0; i < 2; i++) {
+   for (i = 0; i < ARRAY_SIZE(bts->gprs.nsvc); i++) {
nsvc = >gprs.nsvc[i];
info_ind->nsvci[i] = nsvc->nsvci;
info_ind->local_port[i] = nsvc->local.u.sin.sin_port;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20485
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I272ceb09a3e8cac0082dbec3a034776da71d9366
Gerrit-Change-Number: 20485
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: pcu_sock: cosmetic: make *nsvc a scoped and const variable

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20486 )

Change subject: pcu_sock: cosmetic: make *nsvc a scoped and const variable
..

pcu_sock: cosmetic: make *nsvc a scoped and const variable

Change-Id: I707bb75f15ccaee5c67fa4a7e87dc70c9b982973
---
M src/common/pcu_sock.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index ff788bf..7f7f7cf 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -241,7 +241,6 @@
struct gsm_pcu_if_info_ind *info_ind;
struct gsm_bts *bts;
struct gprs_rlc_cfg *rlcc;
-   struct gsm_bts_gprs_nsvc *nsvc;
struct gsm_bts_trx *trx;
int i;

@@ -328,7 +327,7 @@
 
/* NSVC */
for (i = 0; i < ARRAY_SIZE(bts->gprs.nsvc); i++) {
-   nsvc = >gprs.nsvc[i];
+   const struct gsm_bts_gprs_nsvc *nsvc = >gprs.nsvc[i];
info_ind->nsvci[i] = nsvc->nsvci;
info_ind->local_port[i] = nsvc->local.u.sin.sin_port;
info_ind->remote_port[i] = nsvc->remote.u.sin.sin_port;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20486
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I707bb75f15ccaee5c67fa4a7e87dc70c9b982973
Gerrit-Change-Number: 20486
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: oml: fix handling of NSVC local port in oml_ipa_mo_set_attr_nsvc()

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20495 )

Change subject: oml: fix handling of NSVC local port in 
oml_ipa_mo_set_attr_nsvc()
..


Patch Set 1: Code-Review+2

We need to merge this one ASAP.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20495
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450
Gerrit-Change-Number: 20495
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:42:46 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: cosmetic: use ARRAY_SIZE() in pcu_tx_info_ind()

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20485 )

Change subject: pcu_sock: cosmetic: use ARRAY_SIZE() in pcu_tx_info_ind()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20485
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I272ceb09a3e8cac0082dbec3a034776da71d9366
Gerrit-Change-Number: 20485
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:41:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: cosmetic: make *nsvc a scoped and const variable

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20486 )

Change subject: pcu_sock: cosmetic: make *nsvc a scoped and const variable
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20486
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I707bb75f15ccaee5c67fa4a7e87dc70c9b982973
Gerrit-Change-Number: 20486
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:41:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: sched_lchan_tchh: initialize meas_avg with zeros

[dexter]

Hello Jenkins Builder, Vadim Yanitskiy,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/20282

to look at the new patch set (#3).

Change subject: sched_lchan_tchh: initialize meas_avg with zeros
..

sched_lchan_tchh: initialize meas_avg with zeros

in function rx_tchh_fn() the variable meas_avg is not initalized. This
is not always a problem, since most of the time trx_sched_meas_avg() is
populating the variable properly. In cases where a FACCH is transmitted
(chan_state->ul_ongoing_facch = true) the variable is left unpopulated.
In order to have at least stable values for those cases, initalize the
variable with zeros for the ongoing facch phase.

Change-Id: I5c3c1c41d22f9edaaf6bd4478dd04f090dca12a9
Fixes: CID#214480
---
M src/osmo-bts-trx/sched_lchan_tchh.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/82/20282/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20282
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5c3c1c41d22f9edaaf6bd4478dd04f090dca12a9
Gerrit-Change-Number: 20282
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: sched_lchan_tchh: initialize meas_avg with zeros

[dexter]

Hello Jenkins Builder, Vadim Yanitskiy,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/20282

to look at the new patch set (#2).

Change subject: sched_lchan_tchh: initialize meas_avg with zeros
..

sched_lchan_tchh: initialize meas_avg with zeros

in function rx_tchh_fn() the variable meas_avg is not initalized. This
is not always a problem, since most of the time trx_sched_meas_avg() is
populating the variable properly. In cases where a FACCH is transmitted
(chan_state->ul_ongoing_facch = true) the variable is left unpopulated.
In order to have at least stable values for those cases, make sure that
meas_avg contains zeros in the beginning.

Change-Id: I5c3c1c41d22f9edaaf6bd4478dd04f090dca12a9
Fixes: CID#214480
---
M src/osmo-bts-trx/sched_lchan_tchh.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/82/20282/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20282
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5c3c1c41d22f9edaaf6bd4478dd04f090dca12a9
Gerrit-Change-Number: 20282
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: gsm_08_08: fix unreachable code in parse_powercap()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20496 )

Change subject: gsm_08_08: fix unreachable code in parse_powercap()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20496
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I48331cca784d8fa3a5904f2c4cf1555622b319e8
Gerrit-Change-Number: 20496
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:22:33 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: gsm_08_08: fix unreachable code in parse_powercap()

[dexter]

dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20496 )


Change subject: gsm_08_08: fix unreachable code in parse_powercap()
..

gsm_08_08: fix unreachable code in parse_powercap()

The function parse_powercap() contains a nested switch case statement
that is used to populate the variables lu and pwr_lev. Those variables
are used at the bottom of the function later. Unfortunately the (outer)
switch case that consumes the pdisc variable does not put a break; at
the end of its only case "GSM48_PDISC_MM", which eventually causes a
fall through to the default case, which simply returns. Since this can
not be intended, lets add a break to make the bottom code reachable in
case lu and pwr_lev are successfully populated.

Change-Id: I48331cca784d8fa3a5904f2c4cf1555622b319e8
Fixes: CID#214886
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/20496/1

diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index f3214c7..b7c7448 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -343,6 +343,7 @@
/* No power cap in other messages */
return;
}
+   break;
/* FIXME: pwr_lev in Paging Response? */
default:
/* No power cap in other messages */

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20496
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I48331cca784d8fa3a5904f2c4cf1555622b319e8
Gerrit-Change-Number: 20496
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20494 )

Change subject: pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20494
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib0efa6e1e2a68ac9675a18487b79d9b14bdb22c5
Gerrit-Change-Number: 20494
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:19:38 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: use llist_for_each_entry() in pcu_sock_close()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20493 )

Change subject: pcu_sock: use llist_for_each_entry() in pcu_sock_close()
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/20493/1/src/common/pcu_sock.c
File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20493/1/src/common/pcu_sock.c@915
PS1, Line 915:  for (tn = 0; tn < 8; tn++) {
iirc there was a define for that 8.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20493
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:17:17 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: Set all NM OML objects to Locked by default

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/20399 )

Change subject: Set all NM OML objects to Locked by default
..


Patch Set 5: Code-Review-1

This new patch series contains all the refactoring we talked about. I didn't 
run-test this new version, so don't merge yet, but at least we can start 
reviewing the big part of it after the refactor I did, in case someone sees 
major issues or parts to change.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20399
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I68ae0bc51a565f903b47cf72f3e3dd6f1a2d2651
Gerrit-Change-Number: 20399
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:15:49 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: OML: Stay compatible with older osmo-bts versions

[pespin]

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20405

to look at the new patch set (#5).

Change subject: OML: Stay compatible with older osmo-bts versions
..

OML: Stay compatible with older osmo-bts versions

Older osmo-bts versions (before FSMs) tended to mimic broken behavior
from nanoBTS. As so, we detect it because SiteMGr becomes Enabled by
default as in nanoBTS, and hence we can manage them also by expecting no
Offline state and sending Opstart (and hence finally transitting to
Enabled) during Dependency state.

Change-Id: Iaa036a2936f609b9b9721b2b4ad8d6deaf023f42
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/nm_bb_transc_fsm.c
M src/osmo-bsc/nm_bts_fsm.c
M src/osmo-bsc/nm_bts_sm_fsm.c
M src/osmo-bsc/nm_channel_fsm.c
M src/osmo-bsc/nm_rcarrier_fsm.c
6 files changed, 22 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/05/20405/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20405
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iaa036a2936f609b9b9721b2b4ad8d6deaf023f42
Gerrit-Change-Number: 20405
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Introduce Radio Channel FSM

[pespin]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20404

to look at the new patch set (#5).

Change subject: Introduce Radio Channel FSM
..

Introduce Radio Channel FSM

Change-Id: Iddc008c5737afb2fddd32c628bc5278056a64d89
---
M include/osmocom/bsc/nm_common_fsm.h
M include/osmocom/bsc/signal.h
M src/ipaccess/Makefile.am
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/abis_nm.c
M src/osmo-bsc/bts_ipaccess_nanobts.c
M src/osmo-bsc/bts_trx.c
A src/osmo-bsc/nm_channel_fsm.c
M src/utils/Makefile.am
M tests/abis/Makefile.am
M tests/acc/Makefile.am
M tests/acc/acc_test.ok
M tests/bsc/Makefile.am
M tests/gsm0408/Makefile.am
M tests/handover/Makefile.am
M tests/nanobts_omlattr/Makefile.am
16 files changed, 905 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/04/20404/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20404
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iddc008c5737afb2fddd32c628bc5278056a64d89
Gerrit-Change-Number: 20404
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Introduce NM RadioCarrier FSM

[pespin]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20403

to look at the new patch set (#5).

Change subject: Introduce NM RadioCarrier FSM
..

Introduce NM RadioCarrier FSM

Change-Id: Ieed61d1fb1e896db42545c2c3421b20cb41ad549
---
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/nm_common_fsm.h
M src/ipaccess/Makefile.am
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/bts_ipaccess_nanobts.c
M src/osmo-bsc/bts_trx.c
M src/osmo-bsc/nm_common_fsm.c
A src/osmo-bsc/nm_rcarrier_fsm.c
M src/utils/Makefile.am
M tests/abis/Makefile.am
M tests/acc/Makefile.am
M tests/acc/acc_test.ok
M tests/bsc/Makefile.am
M tests/ctrl_test_runner.py
M tests/gsm0408/Makefile.am
M tests/handover/Makefile.am
M tests/nanobts_omlattr/Makefile.am
18 files changed, 466 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/20403/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20403
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ieed61d1fb1e896db42545c2c3421b20cb41ad549
Gerrit-Change-Number: 20403
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Introduce NM BaseBand Transceiver FSM

[pespin]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20402

to look at the new patch set (#5).

Change subject: Introduce NM BaseBand Transceiver FSM
..

Introduce NM BaseBand Transceiver FSM

Change-Id: Ib4d35316c52eb4c71ea0d352a1e06fd5e600fe08
---
M include/osmocom/bsc/bts_trx.h
M include/osmocom/bsc/nm_common_fsm.h
M src/ipaccess/Makefile.am
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/bts_ipaccess_nanobts.c
M src/osmo-bsc/bts_trx.c
A src/osmo-bsc/nm_bb_transc_fsm.c
M src/utils/Makefile.am
M tests/abis/Makefile.am
M tests/acc/Makefile.am
M tests/acc/acc_test.ok
M tests/bsc/Makefile.am
M tests/gsm0408/Makefile.am
M tests/handover/Makefile.am
M tests/nanobts_omlattr/Makefile.am
15 files changed, 466 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/02/20402/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20402
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib4d35316c52eb4c71ea0d352a1e06fd5e600fe08
Gerrit-Change-Number: 20402
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Introduce NM BTS Site Manager FSM

[pespin]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20400

to look at the new patch set (#5).

Change subject: Introduce NM BTS Site Manager FSM
..

Introduce NM BTS Site Manager FSM

Change-Id: Ic001ce6ebeff6f51470ef58140b0235f4a30265e
---
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/bts.h
M include/osmocom/bsc/gsm_data.h
A include/osmocom/bsc/nm_common_fsm.h
M include/osmocom/bsc/signal.h
M src/ipaccess/Makefile.am
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/abis_nm.c
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_ipaccess_nanobts.c
A src/osmo-bsc/nm_bts_sm_fsm.c
A src/osmo-bsc/nm_common_fsm.c
M src/utils/Makefile.am
M tests/abis/Makefile.am
M tests/acc/Makefile.am
M tests/acc/acc_test.c
M tests/acc/acc_test.ok
M tests/bsc/Makefile.am
M tests/gsm0408/Makefile.am
M tests/handover/Makefile.am
M tests/nanobts_omlattr/Makefile.am
21 files changed, 518 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/00/20400/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20400
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic001ce6ebeff6f51470ef58140b0235f4a30265e
Gerrit-Change-Number: 20400
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Introduce NM BTS FSM

[pespin]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20401

to look at the new patch set (#5).

Change subject: Introduce NM BTS FSM
..

Introduce NM BTS FSM

Change-Id: I7756a8ce90b6cc8a502b5665889a7987d7f749cb
---
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/nm_common_fsm.h
M include/osmocom/bsc/signal.h
M src/ipaccess/Makefile.am
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/abis_nm.c
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_ipaccess_nanobts.c
A src/osmo-bsc/nm_bts_fsm.c
M src/osmo-bsc/nm_common_fsm.c
M src/utils/Makefile.am
M tests/abis/Makefile.am
M tests/acc/Makefile.am
M tests/acc/acc_test.ok
M tests/bsc/Makefile.am
M tests/gsm0408/Makefile.am
M tests/handover/Makefile.am
M tests/nanobts_omlattr/Makefile.am
18 files changed, 489 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/20401/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20401
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7756a8ce90b6cc8a502b5665889a7987d7f749cb
Gerrit-Change-Number: 20401
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Set all NM OML objects to Locked by default

[pespin]

Hello Jenkins Builder, laforge, Vadim Yanitskiy,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/20399

to look at the new patch set (#5).

Change subject: Set all NM OML objects to Locked by default
..

Set all NM OML objects to Locked by default

Before they were set with a value of 0, which had no related enum field,
but since in general all comparsions are done against NM_STATE_UNLOCKED
they also hold valid.

The major change in behavior with this patch is upon OML link down,
where gsm_bts_mo_reset() is called on all objects. This way, upon OML
re-establishment we have again all objects as Locked again, which is the
expected default value as per TS 12.21.

Change-Id: I68ae0bc51a565f903b47cf72f3e3dd6f1a2d2651
---
M src/osmo-bsc/bts_trx.c
M src/osmo-bsc/gsm_data.c
M tests/ctrl_test_runner.py
3 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/20399/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20399
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I68ae0bc51a565f903b47cf72f3e3dd6f1a2d2651
Gerrit-Change-Number: 20399
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-trx[master]: vty: add attributes to VTY commands indicating when they apply

[dexter]

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/20319 )

Change subject: vty: add attributes to VTY commands indicating when they apply
..


Patch Set 3:

(2 comments)

> Patch Set 3: Code-Review+1
>
> I don't have CR+2 capabilities, would do that otherwise.

I also do not have them, maybe this is due to the recent gerrit update?

https://gerrit.osmocom.org/c/osmo-trx/+/20319/1/CommonLibs/trx_vty.c
File CommonLibs/trx_vty.c:

https://gerrit.osmocom.org/c/osmo-trx/+/20319/1/CommonLibs/trx_vty.c@101
PS1, Line 101: trx
> It's a regular node selection, it does not change any parameters => we don't 
> need any attributes her […]
Ack


https://gerrit.osmocom.org/c/osmo-trx/+/20319/1/CommonLibs/trx_vty.c@487
PS1, Line 487: chan <0-100>
> This one applies on full program restart => we don't need any attributes here.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43
Gerrit-Change-Number: 20319
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 18:38:22 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Yanitskiy 
Gerrit-MessageType: comment

Change in osmo-bts[master]: oml: fix handling of NSVC local port in oml_ipa_mo_set_attr_nsvc()

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20495 )


Change subject: oml: fix handling of NSVC local port in 
oml_ipa_mo_set_attr_nsvc()
..

oml: fix handling of NSVC local port in oml_ipa_mo_set_attr_nsvc()

This is another regresion introduced by [1].  Both local and remote
port numbers recived in the network order, and must be stored as-is.

Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450
Fixes: I310699fabbfec4255f0474f31717f215c1201eca
Related: SYS#4915
---
M src/common/oml.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/95/20495/1

diff --git a/src/common/oml.c b/src/common/oml.c
index 5394e8a..2a87b03 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1272,7 +1272,7 @@
nsvc->remote.u.sin.sin_addr.s_addr = _cur_l;
cur += 4;
memcpy(&_cur_s, cur, 2);
-   nsvc->local.u.sin.sin_port = ntohs(_cur_s);
+   nsvc->local.u.sin.sin_port = _cur_s;
}

if (TLVP_PRES_LEN(tp, NM_ATT_OSMO_NS_LINK_CFG, 10)) {

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20495
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3c21a2c27dcbf6de728ce2c7ccbae9e2f517c450
Gerrit-Change-Number: 20495
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-MessageType: newchange

Change in osmo-trx[master]: vty: add attributes to VTY commands indicating when they apply

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/20319 )

Change subject: vty: add attributes to VTY commands indicating when they apply
..


Patch Set 3: Code-Review+1

I don't have CR+2 capabilities, would do that otherwise.


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43
Gerrit-Change-Number: 20319
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 18:06:49 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: use llist_for_each_entry() in pcu_sock_close()

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20493 )


Change subject: pcu_sock: use llist_for_each_entry() in pcu_sock_close()
..

pcu_sock: use llist_for_each_entry() in pcu_sock_close()

Using gsm_bts_trx_num() involves redundant iterations over the
list of transceivers - we definitely don't want them.

Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
---
M src/common/pcu_sock.c
1 file changed, 5 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/93/20493/1

diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 7f7f7cf..d54e385 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -883,7 +883,7 @@
struct gsm_bts *bts;
struct gsm_bts_trx *trx;
struct gsm_bts_trx_ts *ts;
-   int i, j;
+   unsigned int tn;

/* FIXME: allow multiple BTS */
bts = llist_entry(state->net->bts_list.next, struct gsm_bts, list);
@@ -910,13 +910,10 @@
osmo_signal_dispatch(SS_GLOBAL, S_NEW_SYSINFO, bts);
 #endif

-   /* release PDCH */
-   for (i = 0; i < 8; i++) {
-   trx = gsm_bts_trx_num(bts, i);
-   if (!trx)
-   break;
-   for (j = 0; j < 8; j++) {
-   ts = >ts[j];
+   /* Deactivate all active PDCH timeslots */
+   llist_for_each_entry(trx, >trx_list, list) {
+   for (tn = 0; tn < 8; tn++) {
+   ts = >ts[tn];
if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED
 && ts->pchan == GSM_PCHAN_PDCH) {
ts->lchan[0].rel_act_kind = LCHAN_REL_ACT_PCU;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20493
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4bd40ffcc1e925412a21b0a934bbfdeddbc6ad1f
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20494 )


Change subject: pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too
..

pcu_sock: fix pcu_sock_close(): deactivate dynamic timeslots too

Change-Id: Ib0efa6e1e2a68ac9675a18487b79d9b14bdb22c5
Fixes: OS#4785
---
M src/common/pcu_sock.c
1 file changed, 9 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/94/20494/1

diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index d54e385..6040de5 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -882,7 +882,6 @@
struct osmo_fd *bfd = >conn_bfd;
struct gsm_bts *bts;
struct gsm_bts_trx *trx;
-   struct gsm_bts_trx_ts *ts;
unsigned int tn;

/* FIXME: allow multiple BTS */
@@ -913,13 +912,15 @@
/* Deactivate all active PDCH timeslots */
llist_for_each_entry(trx, >trx_list, list) {
for (tn = 0; tn < 8; tn++) {
-   ts = >ts[tn];
-   if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED
-&& ts->pchan == GSM_PCHAN_PDCH) {
-   ts->lchan[0].rel_act_kind = LCHAN_REL_ACT_PCU;
-   l1sap_chan_rel(trx,
-   gsm_lchan2chan_nr(>lchan[0]));
-   }
+   struct gsm_bts_trx_ts *ts = >ts[tn];
+
+   if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED)
+   continue;
+   if (!ts_should_be_pdch(ts))
+   continue;
+
+   ts->lchan[0].rel_act_kind = LCHAN_REL_ACT_PCU;
+   l1sap_chan_rel(trx, gsm_lchan2chan_nr(>lchan[0]));
}
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20494
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib0efa6e1e2a68ac9675a18487b79d9b14bdb22c5
Gerrit-Change-Number: 20494
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-MessageType: newchange

Change in osmo-trx[master]: vty: add attributes to VTY commands indicating when they apply

[dexter]

Hello Jenkins Builder, laforge, pespin, Vadim Yanitskiy,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-trx/+/20319

to look at the new patch set (#3).

Change subject: vty: add attributes to VTY commands indicating when they apply
..

vty: add attributes to VTY commands indicating when they apply

Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43
Related: SYS#4937, OS#1601
---
M CommonLibs/trx_vty.c
1 file changed, 14 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/19/20319/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43
Gerrit-Change-Number: 20319
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-mgw[master]: mgcp_vty: add user attributes to configuration commands

[dexter]

Hello Jenkins Builder, laforge, Vadim Yanitskiy,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-mgw/+/20250

to look at the new patch set (#7).

Change subject: mgcp_vty: add user attributes to configuration commands
..

mgcp_vty: add user attributes to configuration commands

To make clear which configuration changes (configure terminal)
apply when, add appropriate user attributes to VTY commands.

Change-Id: I2d9487801b3b78f94577264b56d217c926ef76a9
Related: SYS#4937, OS#1601
---
M include/osmocom/mgcp/vty.h
M src/libosmo-mgcp/mgcp_vty.c
M src/osmo-mgw/mgw_main.c
3 files changed, 248 insertions(+), 180 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/50/20250/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20250
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I2d9487801b3b78f94577264b56d217c926ef76a9
Gerrit-Change-Number: 20250
Gerrit-PatchSet: 7
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: command: add library command attribute for libosmo-abis

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/20481 )

Change subject: command: add library command attribute for libosmo-abis
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20481
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Gerrit-Change-Number: 20481
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 08 Oct 2020 17:21:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: pcu_sock: fix {local, remote}_port byte ordering in pcu_tx_info_ind()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20492 )

Change subject: pcu_sock: fix {local,remote}_port byte ordering in 
pcu_tx_info_ind()
..


Patch Set 1: Code-Review+1

Please also describe so in the header describing the structures.
Also ,this probably needs to be fixed in osmo-bsc.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20492
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I383cab0b58b62734090023298da8c5a341c670d5
Gerrit-Change-Number: 20492
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 08 Oct 2020 17:11:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: command: add library command attribute for libosmo-abis

[dexter]

Hello Jenkins Builder, Vadim Yanitskiy,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/20481

to look at the new patch set (#4).

Change subject: command: add library command attribute for libosmo-abis
..

command: add library command attribute for libosmo-abis

Change-Id: I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Related: SYS#4937, OS#1601
---
M include/osmocom/vty/command.h
M src/vty/command.c
M tests/vty/vty_transcript_test.vty
3 files changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/20481/4
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20481
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Gerrit-Change-Number: 20481
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: logging: Attempt a synchronous, non-blocking write first (file, stderr)

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/20317 )

Change subject: logging: Attempt a synchronous, non-blocking write first (file, 
stderr)
..


Patch Set 5: Code-Review-1

putting a -1 here as this change makes many osmo-msc and some osmo-bsc unit 
tests fail, as they (erroneosly!) make assumptions on how many talloc objects 
libosmocore may internally allocate.


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20317
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I08469a7e4be9bc5bbd39140457bb582f4a0b1703
Gerrit-Change-Number: 20317
Gerrit-PatchSet: 5
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 17:06:00 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: vty: fix 'show bts' command: print proper BTS variant

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20482 )

Change subject: vty: fix 'show bts' command: print proper BTS variant
..

vty: fix 'show bts' command: print proper BTS variant

Change-Id: I24fc66175f79fe64400371e27b23556054c48dfe
---
M src/common/vty.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/vty.c b/src/common/vty.c
index a21b1ec..f9bccee 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -898,9 +898,10 @@
 {
const struct gsm_bts_trx *trx;

-   vty_out(vty, "BTS %u is of %s type in band %s, has CI %u LAC %u, "
+   vty_out(vty, "BTS %u is of type '%s', in band %s, has CI %u LAC %u, "
"BSIC %u and %u TRX%s",
-   bts->nr, "FIXME", gsm_band_name(bts->band),
+   bts->nr, btsvariant2str(bts->variant),
+   gsm_band_name(bts->band),
bts->cell_identity,
bts->location_area_code, bts->bsic,
bts->num_trx, VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20482
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I24fc66175f79fe64400371e27b23556054c48dfe
Gerrit-Change-Number: 20482
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: vty: fix 'show bts' command: BTS number is optional

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20483 )

Change subject: vty: fix 'show bts' command: BTS number is optional
..

vty: fix 'show bts' command: BTS number is optional

Change-Id: If53fb07ec38f6bbc368ce84d14e59fa8167691d3
---
M src/common/vty.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/vty.c b/src/common/vty.c
index f9bccee..534b632 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -965,9 +965,9 @@
 }


-DEFUN(show_bts, show_bts_cmd, "show bts <0-255>",
-   SHOW_STR "Display information about a BTS\n"
-   BTS_NR_STR)
+DEFUN(show_bts, show_bts_cmd, "show bts [<0-255>]",
+  SHOW_STR "Display information about a BTS\n"
+  BTS_NR_STR)
 {
const struct gsm_network *net = gsmnet_from_vty(vty);
int bts_nr;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20483
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If53fb07ec38f6bbc368ce84d14e59fa8167691d3
Gerrit-Change-Number: 20483
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: pcu_sock: fix {local, remote}_port byte ordering in pcu_tx_info_ind()

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/20492 )


Change subject: pcu_sock: fix {local,remote}_port byte ordering in 
pcu_tx_info_ind()
..

pcu_sock: fix {local,remote}_port byte ordering in pcu_tx_info_ind()

The PCUIF is a 'brilliant' protocol: some fields are expected to
be in the network byte order, some in the host order.  The NSVC
remote address and local/remote ports is a good example:

  - byte order of the address must be the network order, and
  - byte order of the ports must be the host order.

Change-Id: I383cab0b58b62734090023298da8c5a341c670d5
Fixes: I310699fabbfec4255f0474f31717f215c1201eca
Related: SYS#4915
---
M src/common/pcu_sock.c
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/20492/1

diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 68cd039..7bb1f7b 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -330,8 +330,10 @@
for (i = 0; i < 2; i++) {
nsvc = >gprs.nsvc[i];
info_ind->nsvci[i] = nsvc->nsvci;
-   info_ind->local_port[i] = nsvc->local.u.sin.sin_port;
-   info_ind->remote_port[i] = nsvc->remote.u.sin.sin_port;
+   /* PCUIF beauty: the NSVC addresses are sent in the network 
byte order,
+* while the port numbers need to be send in the host order.  
Sigh. */
+   info_ind->local_port[i] = ntohs(nsvc->local.u.sin.sin_port);
+   info_ind->remote_port[i] = ntohs(nsvc->remote.u.sin.sin_port);
switch (nsvc->remote.u.sas.ss_family) {
case AF_INET:
info_ind->address_type[i] = PCU_IF_ADDR_TYPE_IPV4;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20492
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I383cab0b58b62734090023298da8c5a341c670d5
Gerrit-Change-Number: 20492
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix f_mo_l3_transceive(): relax DLCI matching

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20490 )

Change subject: BSC_Tests: fix f_mo_l3_transceive(): relax DLCI matching
..


Patch Set 1: Code-Review+2

Urgent fix.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20490
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida659d53e0d31f9aa0ea2efc94d8c659eb76
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: neels 
Gerrit-Comment-Date: Thu, 08 Oct 2020 16:54:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: command: add library command attribute for libosmo-abis

[dexter]

Hello Jenkins Builder, Vadim Yanitskiy,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/20481

to look at the new patch set (#3).

Change subject: command: add library command attribute for libosmo-abis
..

command: add library command attribute for libosmo-abis

Change-Id: I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Related: SYS#4937, OS#1601
---
M include/osmocom/vty/command.h
M src/vty/command.c
2 files changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/20481/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20481
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0efc57f2cb54798ba207ae6fef9af4771d96bfa9
Gerrit-Change-Number: 20481
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix f_mo_l3_transceive(): relax DLCI matching

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20490 )

Change subject: BSC_Tests: fix f_mo_l3_transceive(): relax DLCI matching
..

BSC_Tests: fix f_mo_l3_transceive(): relax DLCI matching

Since If4d479a54cad467f53b49065c1c435a4471ac7d2, osmo-bsc started
to send more concrete DLCI values on the A/BSSAP interface.  In
particular, the control channel identification bits now indicate
whether it's SDCCH/FACCH or SACCH channel.

Let's use '?' as the default DLCI template that we expect to get
from the IUT, so those test cases, for which DLCI is not a part
of the testing scenario, would not fail.

Change-Id: Ida659d53e0d31f9aa0ea2efc94d8c659eb76
---
M bsc/BSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  neels: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 20fcf36..b141a0a 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -4521,7 +4521,7 @@
 }

 private function f_mo_l3_transceive(template (value) RslLinkId link_id := 
ts_RslLinkID_DCCH(0),
-   template (present) OCT1 dlci := '00'O,
+   template (present) OCT1 dlci := ?,
octetstring l3 := '0123456789'O)
 runs on MSC_ConnHdlr {
/* The old lchan and conn should still be active. See that arbitrary L3

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20490
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida659d53e0d31f9aa0ea2efc94d8c659eb76
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: neels 
Gerrit-MessageType: merged

Change in libosmocore[master]: logging: Change stderr + file target to use non-blocking write

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/20296 )

Change subject: logging: Change stderr + file target to use non-blocking write
..


Patch Set 11: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20296
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia58fd78535c41b3da3aeb7733aadc785ace610da
Gerrit-Change-Number: 20296
Gerrit-PatchSet: 11
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 08 Oct 2020 16:48:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment