Change in libosmocore[master]: bts_features: add missing description for BTS_FEAT_ACCH_REP
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21257 )
Change subject: bts_features: add missing description for BTS_FEAT_ACCH_REP
..
bts_features: add missing description for BTS_FEAT_ACCH_REP
Change-Id: Ie1d7f00b1bed43c41274bba4ce767a61cd71bb61
Fixes: Ib4d1d8d8a1a1d58bc320a1c0eff2d52100267f09
---
M src/gsm/bts_features.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, approved
diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c
index 9a5188b..93703aa 100644
--- a/src/gsm/bts_features.c
+++ b/src/gsm/bts_features.c
@@ -41,6 +41,7 @@
{ BTS_FEAT_ETWS_PN, "ETWS Primary Notification via PCH" },
{ BTS_FEAT_PAGING_COORDINATION, "BSS Paging Coordination" },
{ BTS_FEAT_IPV6_NSVC, "NSVC IPv6" },
+ { BTS_FEAT_ACCH_REP,"FACCH/SACCH Repeation" },
{ 0, NULL }
};
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21257
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie1d7f00b1bed43c41274bba4ce767a61cd71bb61
Gerrit-Change-Number: 21257
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-MessageType: merged
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 163s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 163s] [COMPILING libboard/qmod/source/card_pres.c] [ 163s] [COMPILING libboard/qmod/source/wwan_led.c] [ 163s] [COMPILING libboard/qmod/source/i2c.c] [ 163s] [COMPILING libboard/qmod/source/board_qmod.c] [ 163s] [COMPILING apps/dfu/main.c] [ 163s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 164s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 164s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 164s] Memory region Used Size Region Size %age Used [ 164s] rom: 16588 B16 KB101.25% [ 164s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 164s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 164s] collect2: error: ld returned 1 exit status [ 164s] % [ 164s] make[2]: *** [Makefile:234: flash] Error 1 [ 164s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 164s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 164s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 164s] dh_auto_build: error: make -j1 returned exit code 2 [ 164s] make: *** [debian/rules:16: build] Error 25 [ 164s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 164s] ### VM INTERACTION START ### [ 167s] [ 155.300099] sysrq: Power Off [ 167s] [ 155.307246] reboot: Power down [ 167s] ### VM INTERACTION END ### [ 167s] [ 167s] lamb11 failed "build simtrace2_0.7.0.69.aadd.dsc" at Fri Nov 20 01:54:46 UTC 2020. [ 167s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 103s] [COMPILING apps/dfu/main.c] [ 103s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 103s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 103s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 103s] Memory region Used Size Region Size %age Used [ 103s] rom: 16580 B16 KB101.20% [ 103s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 103s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 103s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 103s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 103s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 103s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 103s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 196 bytes [ 103s] collect2: error: ld returned 1 exit status [ 103s] % [ 103s] make[2]: *** [Makefile:234: flash] Error 1 [ 103s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 103s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 103s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 103s] dh_auto_build: error: make -j1 returned exit code 2 [ 103s] make: *** [debian/rules:16: build] Error 25 [ 103s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 103s] ### VM INTERACTION START ### [ 106s] [ 96.606114] sysrq: Power Off [ 106s] [ 96.608052] reboot: Power down [ 106s] ### VM INTERACTION END ### [ 106s] [ 106s] hci-cnode2-m1 failed "build simtrace2_0.7.0.69.aadd.dsc" at Fri Nov 20 01:53:37 UTC 2020. [ 106s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: bts_features: add missing description for BTS_FEAT_ACCH_REP
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21257 ) Change subject: bts_features: add missing description for BTS_FEAT_ACCH_REP .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie1d7f00b1bed43c41274bba4ce767a61cd71bb61 Gerrit-Change-Number: 21257 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Comment-Date: Thu, 19 Nov 2020 19:36:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21179 ) Change subject: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9af23e175435fe9ae7b0e4119ad52fcd4707b9ca Gerrit-Change-Number: 21179 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 19 Nov 2020 18:55:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS
Hello Jenkins Builder, neels, laforge, fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/21179 to look at the new patch set (#5). Change subject: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS .. Implement downgrade to DL MCS1-4 when USF for GPRS_only MS In previous status, if USF for GPRS-only MS was selected, then EGPRS TBFs were skipped and either a GPRS TBF was selected or a Dummy Block was sent. That means the behavior was unfair towards EGPRS TBFs, because sometimes they were skipped in favor of GPRS ones. This patch imporves the situation in the above mentioned USF scenario, by first, under specific conditions, allowing selection of an EGPRS TBF and then forcing it to transmit in EGPRS-GMSK (MCS1-4) so that the USF-targeted MS can still decode the USF, while at the same time providing more fairness by allowing the EGPRS TBF to transmit data. The specific conditions mentioned above are, mainly, related to the fact that once a DL data block has been sent, and hence a BSN was assigned to it, it cannot be retransmitted later using another MCS, since lower MCS1-4 wouldn't be able to contain higher MCS RLC payload. The set of conditions could be expanded in the future by also selecting the EGPRS TBF if retransmition is required and the block to be retransmitted was originally transmitted as MCS1-4. Related: OS#4544 Change-Id: I9af23e175435fe9ae7b0e4119ad52fcd4707b9ca --- M src/bts.cpp M src/bts.h M src/gprs_rlcmac_sched.cpp M src/tbf_dl.cpp M src/tbf_dl.h M tests/tbf/TbfTest.err 6 files changed, 463 insertions(+), 431 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/79/21179/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9af23e175435fe9ae7b0e4119ad52fcd4707b9ca Gerrit-Change-Number: 21179 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset
Change in libosmocore[master]: bts_features: add missing description for BTS_FEAT_ACCH_REP
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/21257 )
Change subject: bts_features: add missing description for BTS_FEAT_ACCH_REP
..
bts_features: add missing description for BTS_FEAT_ACCH_REP
Change-Id: Ie1d7f00b1bed43c41274bba4ce767a61cd71bb61
Fixes: Ib4d1d8d8a1a1d58bc320a1c0eff2d52100267f09
---
M src/gsm/bts_features.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/21257/1
diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c
index 9a5188b..93703aa 100644
--- a/src/gsm/bts_features.c
+++ b/src/gsm/bts_features.c
@@ -41,6 +41,7 @@
{ BTS_FEAT_ETWS_PN, "ETWS Primary Notification via PCH" },
{ BTS_FEAT_PAGING_COORDINATION, "BSS Paging Coordination" },
{ BTS_FEAT_IPV6_NSVC, "NSVC IPv6" },
+ { BTS_FEAT_ACCH_REP,"FACCH/SACCH Repeation" },
{ 0, NULL }
};
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21257
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie1d7f00b1bed43c41274bba4ce767a61cd71bb61
Gerrit-Change-Number: 21257
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21179 ) Change subject: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/21179/4/src/gprs_rlcmac_sched.cpp File src/gprs_rlcmac_sched.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21179/4/src/gprs_rlcmac_sched.cpp@322 PS4, Line 322: spacing -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9af23e175435fe9ae7b0e4119ad52fcd4707b9ca Gerrit-Change-Number: 21179 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 19 Nov 2020 18:00:05 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21179 ) Change subject: Implement downgrade to DL MCS1-4 when USF for GPRS_only MS .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9af23e175435fe9ae7b0e4119ad52fcd4707b9ca Gerrit-Change-Number: 21179 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 19 Nov 2020 17:54:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: gprs_bssgp_pcu: follow ns2 library changes
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21249 ) Change subject: gprs_bssgp_pcu: follow ns2 library changes .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I056fe624160f2fe01d405690eba5cc0032780837 Gerrit-Change-Number: 21249 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 19 Nov 2020 17:53:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: ansible: add role for 'podman'
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/21241 )
Change subject: ansible: add role for 'podman'
..
ansible: add role for 'podman'
podman has one particularly interesting feature which docker
rejected years ago: The ability to run a container in a pre-existing
namespace. This is quite useful for some of our test setups,
particularly those that involve hdlc net-devices
Change-Id: I4b14599f39c07ec83fa4222f9d040d443caae3e6
---
A ansible/roles/podman/tasks/debian.yml
A ansible/roles/podman/tasks/main.yml
2 files changed, 40 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved; Verified
diff --git a/ansible/roles/podman/tasks/debian.yml
b/ansible/roles/podman/tasks/debian.yml
new file mode 100644
index 000..907d75c
--- /dev/null
+++ b/ansible/roles/podman/tasks/debian.yml
@@ -0,0 +1,33 @@
+---
+
+- name: add apt https support
+ apt:
+cache_valid_time: 3600
+update_cache: yes
+pkg:
+ - apt-transport-https
+ - gnupg
+ - cron
+ - ca-certificates
+ when: ansible_distribution_major_version < 11
+
+- name: add docker gpg key to apt keyring
+ apt_key:
+id: 2472D6D0D2F66AF87ABA8DA34D64390375060AA4
+url:
https://ftp.uni-stuttgart.de/opensuse/repositories/devel:/kubic:/libcontainers:/stable/Debian_{{
ansible_distribution_version }}/Release.key
+ when: ansible_distribution_major_version < 11
+
+- apt_repository:
+repo: "deb
https://ftp.uni-stuttgart.de/opensuse/repositories/devel:/kubic:/libcontainers:/stable/Debian_{{
ansible_distribution_version }}/ /"
+state: present
+update_cache: yes
+ when: ansible_distribution_major_version < 11
+
+- name: install podman
+ apt:
+pkg:
+ - podman
+ - runc
+ - buildah
+ - skopeo
+ - dnsmasq
diff --git a/ansible/roles/podman/tasks/main.yml
b/ansible/roles/podman/tasks/main.yml
new file mode 100644
index 000..049f5c2
--- /dev/null
+++ b/ansible/roles/podman/tasks/main.yml
@@ -0,0 +1,7 @@
+---
+
+- name: Include tasks for Debian
+ include_tasks: debian.yml
+ when: (ansible_distribution in ['Debian', 'Raspbian'])
+
+# TODO: add other distributions below
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/21241
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I4b14599f39c07ec83fa4222f9d040d443caae3e6
Gerrit-Change-Number: 21241
Gerrit-PatchSet: 3
Gerrit-Owner: laforge
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ci[master]: ansible: add role for 'podman'
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/21241 ) Change subject: ansible: add role for 'podman' .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/21241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4b14599f39c07ec83fa4222f9d040d443caae3e6 Gerrit-Change-Number: 21241 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:53:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Add test for BSSGP resume procedure
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21255 ) Change subject: gbproxy: Add test for BSSGP resume procedure .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7e724b97ebfde4ed5824515065fbedca8bcf4c64 Gerrit-Change-Number: 21255 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 19 Nov 2020 17:52:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Add test for the suspend procedure
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21254 ) Change subject: gbproxy: Add test for the suspend procedure .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib64c1711f7983940aa41e1b570c90015fe236e5b Gerrit-Change-Number: 21254 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 19 Nov 2020 17:52:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Use a different IMSI suffix per TC
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21253 ) Change subject: gbproxy: Use a different IMSI suffix per TC .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a234cd6e61cfed8c9502708314c478f9a561d58 Gerrit-Change-Number: 21253 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 19 Nov 2020 17:51:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Add test for Radio Status procedure
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21252 ) Change subject: gbproxy: Add test for Radio Status procedure .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I277ba3dace936400a78670925c7c8bdf401f90f6 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:51:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: Add templates for BSSGP Radio Status procedure
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21251 )
Change subject: Add templates for BSSGP Radio Status procedure
..
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21251/1/library/Osmocom_Gb_Types.ttcn
File library/Osmocom_Gb_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21251/1/library/Osmocom_Gb_Types.ttcn@1770
PS1, Line 1770: function tr_BSSGP_RADIO_CAUSE(template BssgpRadioCause cause)
return template Radio_Cause {
return template (present) ... - but not critical.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21251
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6d49eb4907c4568d88da5d6fd7962e388a3607fb
Gerrit-Change-Number: 21251
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Thu, 19 Nov 2020 17:51:14 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Reset nsvc to SGSN before each test
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21233 ) Change subject: gbproxy: Reset nsvc to SGSN before each test .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf9c75b4066b1aad5fbbe2f35087a3f9f1a39743 Gerrit-Change-Number: 21233 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:50:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: remove obsolete type GPRS_NS2_LL_E1
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21248 ) Change subject: ns2: remove obsolete type GPRS_NS2_LL_E1 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb4608d91ccb32a07cad67519166dabfba76612 Gerrit-Change-Number: 21248 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:49:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: move link layer type into NSE
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21247 ) Change subject: ns2: move link layer type into NSE .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I18dfd40a2429cd61b7c4a3dad5f226c64296f7d8 Gerrit-Change-Number: 21247 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:49:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: move LL into public api
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21246 ) Change subject: ns2: move LL into public api .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21246/1/include/osmocom/gprs/gprs_ns2.h File include/osmocom/gprs/gprs_ns2.h: https://gerrit.osmocom.org/c/libosmocore/+/21246/1/include/osmocom/gprs/gprs_ns2.h@38 PS1, Line 38: GPRS that one is somehwat strange, could be removed in a further follow-up patch. I'm not sure what NS over E1 would be, if there's no FR in between. Probably dates back to a time where the understanding of the specs was not as clear. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3b5e0d51ce69b095095e5160ca0cf0d4534db1b8 Gerrit-Change-Number: 21246 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:48:42 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: add repeated downlink FACCH
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 ) Change subject: l1sap: add repeated downlink FACCH .. Patch Set 9: (4 comments) Mostly cosmetic warnings, looks good in general. https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@973 PS9, Line 973: uint8_t const https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@974 PS9, Line 974: int size_t or unsigned int, it cannot be negative https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@976 PS9, Line 976: meas_res const https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/rsl.c@832 PS9, Line 832: memset Is memset() really needed here? For just two pointers, setting to NULL makes more sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75 Gerrit-Change-Number: 21014 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 19 Nov 2020 17:47:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: permit multiple nsvci in one nse in VTY
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21245 ) Change subject: ns2: permit multiple nsvci in one nse in VTY .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21245/1/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/21245/1/src/gb/gprs_ns2_vty.c@170 PS1, Line 170: > extra line not needed does it hurt? is it worth commenting on it? I don't mind an extra empty line here or there, as long as we don't end up scrolling over half an empty page... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4ad454320d0a03e81b399f55e8bd0ee57402dad0 Gerrit-Change-Number: 21245 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:46:58 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: implement link sharing selector
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21244 ) Change subject: ns2: implement link sharing selector .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c@400 PS1, Line 400: nsvc = llist_first_entry(>nsvc, struct gprs_ns2_vc, list); > could it be this is NULL? see the llist_empty() check above. If it is empty, we wouldn't get here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I212fa1a65e8c16cf1e525d1962d5689446c7e49e Gerrit-Change-Number: 21244 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:45:56 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: add support for frame relay
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21243 ) Change subject: ns2: add support for frame relay .. Patch Set 1: (9 comments) https://gerrit.osmocom.org/c/libosmocore/+/21243/1/include/osmocom/gprs/frame_relay.h File include/osmocom/gprs/frame_relay.h: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/include/osmocom/gprs/frame_relay.h@1 PS1, Line 1: /*! \file frame_relay.h */ missing copyright / license statement (yes, my fault in the initial code, but I don't want to mess with your patchset now) https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c File src/gb/frame_relay.c: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@14 PS1, Line 14: missing copyright / license statement (yes, my fault in the initial code, but I don't want to mess with your patchset now) https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@106 PS1, Line 106: /* RX Message: 14 [ 00 01 03 08 00 75 95 01 01 00 03 02 01 00 ] */ > this can be dropped right? what's bad about some examples of the messages in a comment? https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@222 PS1, Line 222: ie[2] |= 0x02; > what are these 0x02 0x04 0x08? Please add defines for those. They are the bits we need to use for the "active" "add" and "del" situations. I find the existing code sufficiently clear, as the name of the function is visible from every "if" statement above. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@366 PS1, Line 366: link->succeed = link->succeed << 1; > link->succeed <<= 1; works either way, there is no rule that your version is superior or preferred, IMHO. Matter of taste. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@461 PS1, Line 461: LOGPFRL(link, LOGL_ERROR, "Could not create DLC %d\n", dlci); > return, or directly OSMO_ASERT. why? all the other DLCs in the message might just as well have been created? This function is executed in response to data received from the peer. I don't think we should assert here. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@468 PS1, Line 468: dlc->add = pvc->new; > not sure if this "new" here will cause problems when compiling with c++. we do not anticipate the compilation of the frame relay code in C++ programs. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c File src/gb/gprs_ns2_fr.c: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c@86 PS1, Line 86: struct iphdr > Don't we have this defined somewhere else? We should move this to some > osmocom compat header IMHO, s […] We don't really support FreeBSD, Apple or Cygwin platforms, so best to remove it altogether. Nobody ever even does compile testing on these. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c@301 PS1, Line 301: /* FIXME half writes */ > IIUC this should put stuff into a wqueue? yes, indeed. An osmo_wqueue is probably the best approach. I also think that for datagram oriented sockets you either can write a full packet or you cannot write, so you don't have to care about partial writes. A partial write would make no sense, as every write is one packet on the network (unless you play with CORK options). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id3b49f93d33c271f77cd9c9db03cde6b727a4d30 Gerrit-Change-Number: 21243 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 19 Nov 2020 17:44:56 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: add repeated uplink SACCH
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21185 ) Change subject: l1sap: add repeated uplink SACCH .. Patch Set 3: Code-Review-1 (6 comments) https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c File src/osmo-bts-trx/sched_lchan_xcch.c: https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@63 PS3, Line 63: repeated_ul_sacch_active_decision Not sure if this file (which is more about mapping, interleaving, and convolutional coding) is the right place for such logic. Maybe l1sap is a better place? Not a merge blocker though. If you decide to keep it here, make it 'static', as it's a performance critical place. https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@101 PS3, Line 101: talloc_zero_size Not really related, but I think we should move memory allocations out of the burst handlers. This needs to be done once during the channel activation, not on receipt of *every Uplink burst*. https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@111 PS3, Line 111: *chan_state->ul_bursts_prev This is wrong, and may lead to NULL-pointer dereference if talloc returns NULL. CR-1. https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@178 PS3, Line 178: LOGL_NOTICE Not sure if this event actually deserves NOTICE. I would drop this logging statement. https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@179 PS3, Line 179: also yields good data ... and this reads really weird. Do we get good data block twice? https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@192 PS3, Line 192: L1SAP_IS_LINK_SACCH(trx_chan_desc[chan].link_id) && lchan->repeated_ul_sacch_active I think it makes sense to pre-calculate this condition into a boolean variable, given that you're using this combination three times. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac Gerrit-Change-Number: 21185 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 19 Nov 2020 17:38:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: check if ns_vc_alloc() fails in bind_connect()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21242 ) Change subject: ns2: check if ns_vc_alloc() fails in bind_connect() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82c984b9808451a72a62ff03b0495a1d09473e1c Gerrit-Change-Number: 21242 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:34:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: Add a VTY command to reset NSVC FSM
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21232 ) Change subject: ns2: Add a VTY command to reset NSVC FSM .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21232/4/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/21232/4/src/gb/gprs_ns2_vty.c@365 PS4, Line 365: nsvc nsei <0-65535> force-unconfigure wondering if it may ever make sense to only do that for a single ns-vc. At that point a "nsvc all nsei <0-65535 force-unconfigured" would make more sense as the "all" could later be replaced by "(all|<0-65535>)". But to be honest, I currently cannot come up with _why_ one would reset only one of them, so probbly simply forget about it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I83b9cd7381c25da0e8aa847038a2d422c8dd63cf Gerrit-Change-Number: 21232 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:34:26 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: Add a function to set the NSVC FSM back to unconfigured
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21231 ) Change subject: ns2: Add a function to set the NSVC FSM back to unconfigured .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If96d56b19959372af4eba009661be19e985b4d51 Gerrit-Change-Number: 21231 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:32:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: Split initiater into init_reset and init_block
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21240 ) Change subject: ns2: Split initiater into init_reset and init_block .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21240/1/src/gb/gprs_ns2_vc_fsm.c File src/gb/gprs_ns2_vc_fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/21240/1/src/gb/gprs_ns2_vc_fsm.c@60 PS1, Line 60: bool init_block; : bool init_reset; it's nice that the comment above now describes an 'initiator' variable that doesn't exist anymore. Either change the comment or rename the variables. I would say initiate_resest / initiate_block mgiht also do a good job? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iff5aff0cf8d19d9c718dd11c4e731ced2aeb16ba Gerrit-Change-Number: 21240 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: lynxis lazus Gerrit-Comment-Date: Thu, 19 Nov 2020 17:31:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: rsl.adoc: update documentation for RSL_IE_OSMO_REP_ACCH_CAP
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21184 ) Change subject: rsl.adoc: update documentation for RSL_IE_OSMO_REP_ACCH_CAP .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3d95da588e863185bb62e92898c285d52bce9af4 Gerrit-Change-Number: 21184 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 19 Nov 2020 17:25:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: add repeated downlink FACCH
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 ) Change subject: l1sap: add repeated downlink FACCH .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75 Gerrit-Change-Number: 21014 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 19 Nov 2020 17:25:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: add repeated downlink FACCH
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 ) Change subject: l1sap: add repeated downlink FACCH .. Patch Set 9: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@968 PS9, Line 968: define DL_FACCH_REPETITION_THRESHOLD_UPPER 4 : #define DL_FACCH_REPETITION_THRESHOLD_LOWER 3 doesn't it make sense to have those vty/user configurable? Or is there a specific rationale to decide on this at compile time? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75 Gerrit-Change-Number: 21014 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 19 Nov 2020 17:24:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: pre-initalize pointer with NULL to avoid gcc warning
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21256 ) Change subject: l1sap: pre-initalize pointer with NULL to avoid gcc warning .. l1sap: pre-initalize pointer with NULL to avoid gcc warning Change-Id: Ibfd18ed5268740cc73fffdb950b96c7f0fad3164 --- M src/common/l1sap.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/common/l1sap.c b/src/common/l1sap.c index c9ec9bf..cfe7ebb 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -918,7 +918,8 @@ uint8_t chan_nr, link_id; uint8_t tn; uint32_t fn; - uint8_t *p, *si; + uint8_t *p = NULL; + uint8_t *si; struct lapdm_entity *le; struct osmo_phsap_prim pp; bool dtxd_facch = false; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibfd18ed5268740cc73fffdb950b96c7f0fad3164 Gerrit-Change-Number: 21256 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-bts[master]: l1sap: pre-initalize pointer with NULL to avoid gcc warning
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21256 ) Change subject: l1sap: pre-initalize pointer with NULL to avoid gcc warning .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/21256/1/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21256/1/src/common/l1sap.c@993 PS1, Line 993: f (lchan->ts->trx->bts->dtxd) : dtxd_facch = true; : le = >lapdm_ch.lapdm_dcch; what if we take this path? then "p" is still pointing to random mmeory (or NULL with your patch) and (tbc) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibfd18ed5268740cc73fffdb950b96c7f0fad3164 Gerrit-Change-Number: 21256 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 19 Nov 2020 17:20:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: add repeated downlink SACCH
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21105 ) Change subject: l1sap: add repeated downlink SACCH .. Patch Set 5: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/include/osmo-bts/gsm_data.h File include/osmo-bts/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/include/osmo-bts/gsm_data.h@267 PS5, Line 267: rep_sacch Why do you add it to lchan->tch? Is 'Repeated SACCH' a TCH specific feature? https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/src/common/l1sap.c@1007 PS5, Line 1007: ws... https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/src/common/rsl.c@833 PS5, Line 833: if( coding style -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00806f936b15fbaf6a4e7bbd61f3bec262cdbb28 Gerrit-Change-Number: 21105 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 17:12:00 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: pre-initalize pointer with NULL to avoid gcc warning
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/21256 ) Change subject: l1sap: pre-initalize pointer with NULL to avoid gcc warning .. l1sap: pre-initalize pointer with NULL to avoid gcc warning Change-Id: Ibfd18ed5268740cc73fffdb950b96c7f0fad3164 --- M src/common/l1sap.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/56/21256/1 diff --git a/src/common/l1sap.c b/src/common/l1sap.c index c9ec9bf..cfe7ebb 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -918,7 +918,8 @@ uint8_t chan_nr, link_id; uint8_t tn; uint32_t fn; - uint8_t *p, *si; + uint8_t *p = NULL; + uint8_t *si; struct lapdm_entity *le; struct osmo_phsap_prim pp; bool dtxd_facch = false; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibfd18ed5268740cc73fffdb950b96c7f0fad3164 Gerrit-Change-Number: 21256 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
Change in osmo-bts[master]: l1sap: add repeated downlink FACCH
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 ) Change subject: l1sap: add repeated downlink FACCH .. Patch Set 8: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75 Gerrit-Change-Number: 21014 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 19 Nov 2020 15:01:02 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Add test for the suspend procedure
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21254 )
Change subject: gbproxy: Add test for the suspend procedure
..
gbproxy: Add test for the suspend procedure
Change-Id: Ib64c1711f7983940aa41e1b570c90015fe236e5b
Related: SYS#5210
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/54/21254/1
diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index 8bc8731..61bc212 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -781,7 +781,45 @@
f_cleanup();
}
+private function f_TC_suspend(charstring id) runs on BSSGP_ConnHdlr {
+ var integer i;
+ /* TODO: Generate RA ID for each ConnHdlr */
+ var RoutingAreaIdentification ra_id :=
g_pars.pcu[0].cfg.bvc[0].cell_id.ra_id;
+ for (i := 0; i < 10; i := i+1) {
+
+ var template (value) PDU_BSSGP pdu_tx :=
ts_BSSGP_SUSPEND(g_pars.tlli, ra_id);
+ /* we cannot use pdu_tx as there are some subtle differences in
the length field :/ */
+ var template (present) PDU_BSSGP pdu_rx :=
tr_BSSGP_SUSPEND(g_pars.tlli, ra_id);
+
+ f_pcu2sgsn(pdu_tx, pdu_rx);
+
+ pdu_tx := ts_BSSGP_SUSPEND_ACK(g_pars.tlli, ra_id, int2oct(i,
1));
+ /* we cannot use pdu_tx as there are some subtle differences in
the length field :/ */
+ pdu_rx := tr_BSSGP_SUSPEND_ACK(g_pars.tlli, ra_id, int2oct(i,
1));
+
+ f_sgsn2pcu(pdu_tx, pdu_rx);
+
+ /* These messages are simple passed through so just also test
sending NACK */
+ pdu_tx := ts_BSSGP_SUSPEND_NACK(g_pars.tlli, ra_id,
BSSGP_CAUSE_UNKNOWN_MS);
+ /* we cannot use pdu_tx as there are some subtle differences in
the length field :/ */
+ pdu_rx := tr_BSSGP_SUSPEND_NACK(g_pars.tlli, ra_id,
BSSGP_CAUSE_UNKNOWN_MS);
+
+ f_sgsn2pcu(pdu_tx, pdu_rx);
+ }
+ setverdict(pass);
+}
+testcase TC_suspend() runs on test_CT
+{
+ var BSSGP_ConnHdlr vc_conn;
+ f_init();
+
+ vc_conn := f_start_handler(refers(f_TC_suspend), testcasename(), g_pcu,
g_sgsn, 6);
+ vc_conn.done;
+ /* TODO: start multiple handlers (UEs) on various cells on same and
other NSEs */
+
+ f_cleanup();
+}
control {
@@ -791,6 +829,7 @@
execute( TC_ra_capability() );
execute( TC_ra_capability_upd() );
execute( TC_radio_status() );
+ execute( TC_suspend() );
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21254
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib64c1711f7983940aa41e1b570c90015fe236e5b
Gerrit-Change-Number: 21254
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: gbproxy: Add test for BSSGP resume procedure
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21255 )
Change subject: gbproxy: Add test for BSSGP resume procedure
..
gbproxy: Add test for BSSGP resume procedure
Change-Id: I7e724b97ebfde4ed5824515065fbedca8bcf4c64
Related: SYS#5210
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 41 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/55/21255/1
diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index 61bc212..bf777cc 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -821,6 +821,46 @@
f_cleanup();
}
+private function f_TC_resume(charstring id) runs on BSSGP_ConnHdlr {
+ var integer i;
+
+ /* TODO: Generate RA ID for each ConnHdlr */
+ var RoutingAreaIdentification ra_id :=
g_pars.pcu[0].cfg.bvc[0].cell_id.ra_id;
+ for (i := 0; i < 10; i := i+1) {
+
+ var template (value) PDU_BSSGP pdu_tx :=
ts_BSSGP_RESUME(g_pars.tlli, ra_id, int2oct(i, 1));
+ /* we cannot use pdu_tx as there are some subtle differences in
the length field :/ */
+ var template (present) PDU_BSSGP pdu_rx :=
tr_BSSGP_RESUME(g_pars.tlli, ra_id, int2oct(i, 1));
+
+ f_pcu2sgsn(pdu_tx, pdu_rx);
+
+ pdu_tx := ts_BSSGP_RESUME_ACK(g_pars.tlli, ra_id);
+ /* we cannot use pdu_tx as there are some subtle differences in
the length field :/ */
+ pdu_rx := tr_BSSGP_RESUME_ACK(g_pars.tlli, ra_id);
+
+ f_sgsn2pcu(pdu_tx, pdu_rx);
+
+ /* These messages are simple passed through so just also test
sending NACK */
+ pdu_tx := ts_BSSGP_RESUME_NACK(g_pars.tlli, ra_id,
BSSGP_CAUSE_UNKNOWN_MS);
+ /* we cannot use pdu_tx as there are some subtle differences in
the length field :/ */
+ pdu_rx := tr_BSSGP_RESUME_NACK(g_pars.tlli, ra_id,
BSSGP_CAUSE_UNKNOWN_MS);
+
+ f_sgsn2pcu(pdu_tx, pdu_rx);
+ }
+ setverdict(pass);
+}
+testcase TC_resume() runs on test_CT
+{
+ var BSSGP_ConnHdlr vc_conn;
+ f_init();
+
+ vc_conn := f_start_handler(refers(f_TC_resume), testcasename(), g_pcu,
g_sgsn, 6);
+ vc_conn.done;
+ /* TODO: start multiple handlers (UEs) on various cells on same and
other NSEs */
+
+ f_cleanup();
+}
+
control {
execute( TC_BVC_bringup() );
@@ -830,6 +870,7 @@
execute( TC_ra_capability_upd() );
execute( TC_radio_status() );
execute( TC_suspend() );
+ execute( TC_resume() );
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21255
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7e724b97ebfde4ed5824515065fbedca8bcf4c64
Gerrit-Change-Number: 21255
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in osmo-bts[master]: l1sap: also include SRR bit in RSL l1 info field.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21088 ) Change subject: l1sap: also include SRR bit in RSL l1 info field. .. Patch Set 6: (1 comment) (thanks for reviewing!) https://gerrit.osmocom.org/c/osmo-bts/+/21088/2/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21088/2/src/common/l1sap.c@a1413 PS2, Line 1413: brilliant engineer > Why are you changing this comment? The only thing I would change is the spec > references (old vs new […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I987c61608b737521ba36756dabf2f6215b34c2d6 Gerrit-Change-Number: 21088 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 19 Nov 2020 15:00:20 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Use a different IMSI suffix per TC
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21253 )
Change subject: gbproxy: Use a different IMSI suffix per TC
..
gbproxy: Use a different IMSI suffix per TC
Change-Id: I9a234cd6e61cfed8c9502708314c478f9a561d58
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/53/21253/1
diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index a1d3793..8bc8731 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -750,14 +750,13 @@
var BSSGP_ConnHdlr vc_conn;
f_init();
- vc_conn := f_start_handler(refers(f_TC_ra_capability_upd),
testcasename(), g_pcu, g_sgsn, 3);
+ vc_conn := f_start_handler(refers(f_TC_ra_capability_upd),
testcasename(), g_pcu, g_sgsn, 4);
vc_conn.done;
/* TODO: start multiple handlers (UEs) on various cells on same and
other NSEs */
f_cleanup();
}
-
private function f_TC_radio_status(charstring id) runs on BSSGP_ConnHdlr {
var integer i;
var BssgpRadioCause cause := BSSGP_RADIO_CAUSE_CONTACT_LOST;
@@ -775,7 +774,7 @@
var BSSGP_ConnHdlr vc_conn;
f_init();
- vc_conn := f_start_handler(refers(f_TC_radio_status), testcasename(),
g_pcu, g_sgsn, 3);
+ vc_conn := f_start_handler(refers(f_TC_radio_status), testcasename(),
g_pcu, g_sgsn, 5);
vc_conn.done;
/* TODO: start multiple handlers (UEs) on various cells on same and
other NSEs */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21253
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9a234cd6e61cfed8c9502708314c478f9a561d58
Gerrit-Change-Number: 21253
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in osmo-bts[master]: l1sap: add repeated uplink SACCH
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21185 ) Change subject: l1sap: add repeated uplink SACCH .. Patch Set 2: (3 comments) This change is ready for review. https://gerrit.osmocom.org/c/osmo-bts/+/21185/1/src/osmo-bts-trx/sched_lchan_xcch.c File src/osmo-bts-trx/sched_lchan_xcch.c: https://gerrit.osmocom.org/c/osmo-bts/+/21185/1/src/osmo-bts-trx/sched_lchan_xcch.c@73 PS1, Line 73: if (chan == TRXC_SACCHTF || chan == TRXC_SACCHTH_0 || chan ==TRXC_SACCHTH_1) > This is not going to work for SDCCH, only for TCH. Here is a more universal > approach: […] Done https://gerrit.osmocom.org/c/osmo-bts/+/21185/1/src/osmo-bts-trx/sched_lchan_xcch.c@91 PS1, Line 91: UL-SACCH requires additional memory > ... but only if repeation is enabled, right? Not unconditionally. Done https://gerrit.osmocom.org/c/osmo-bts/+/21185/1/src/osmo-bts-trx/sched_lchan_xcch.c@161 PS1, Line 161: l2_len = 0 > It's already set to 0 above. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac Gerrit-Change-Number: 21185 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 19 Nov 2020 14:58:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: add repeated downlink SACCH
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/21105 to look at the new patch set (#4). Change subject: l1sap: add repeated downlink SACCH .. l1sap: add repeated downlink SACCH 3GPP TS 44.006, section 11 describes a method how the downlink SACCH transmission can be repeated to increase transmission reliability. Depends: libosmocore I61ea6bf54ea90bd69b73ea0f0f3dc19a4214207b Change-Id: I00806f936b15fbaf6a4e7bbd61f3bec262cdbb28 Related: OS#4794, SYS#5114 --- M include/osmo-bts/gsm_data.h M src/common/l1sap.c M src/common/rsl.c 3 files changed, 48 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/21105/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00806f936b15fbaf6a4e7bbd61f3bec262cdbb28 Gerrit-Change-Number: 21105 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: gbproxy: Add test for Radio Status procedure
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21252 ) Change subject: gbproxy: Add test for Radio Status procedure .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I277ba3dace936400a78670925c7c8bdf401f90f6 Gerrit-Change-Number: 21252 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 14:53:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: Add templates for BSSGP Radio Status procedure
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21251 ) Change subject: Add templates for BSSGP Radio Status procedure .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d49eb4907c4568d88da5d6fd7962e388a3607fb Gerrit-Change-Number: 21251 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 14:53:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: gbproxy: Reset nsvc to SGSN before each test
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21233 ) Change subject: gbproxy: Reset nsvc to SGSN before each test .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf9c75b4066b1aad5fbbe2f35087a3f9f1a39743 Gerrit-Change-Number: 21233 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 14:52:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: bts: add repeated acch mode flags + vty config
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21164 ) Change subject: bts: add repeated acch mode flags + vty config .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190 Gerrit-Change-Number: 21164 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Thu, 19 Nov 2020 14:51:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: bts: add repeated acch mode flags + vty config
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164 to look at the new patch set (#6). Change subject: bts: add repeated acch mode flags + vty config .. bts: add repeated acch mode flags + vty config To be able to control the FACCH/SACCH repetition behavior inside the BTS a one byte flag is sent to the BTS together with the RSL_IE_OSMO_REP_ACCH_CAP IE. This patch adds the necessary VTY commands. The sending of the flag is implemented in a follow-up patch. See also: I39ae439d05562b35b2e47774dc92f8789fea1a57 Related: SYS#5114, OS#4796, OS#4794, OS#4795 Depends: libosmocore I326e66dae25acfab0b3fddc7278b39a8cbf7d385 Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bsc_vty.c 2 files changed, 125 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/21164/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190 Gerrit-Change-Number: 21164 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Build failure of network:osmocom:nightly/osmo-pcap in Debian_Unstable/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_Unstable/x86_64
Package network:osmocom:nightly/osmo-pcap failed to build in
Debian_Unstable/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-pcap
Last lines of build log:
[ 147s]
[ 147s] ## --- ##
[ 147s] ## confdefs.h. ##
[ 147s] ## --- ##
[ 147s]
[ 147s] /* confdefs.h */
[ 147s] #define PACKAGE_NAME "osmo-pcap"
[ 147s] #define PACKAGE_TARNAME "osmo-pcap"
[ 147s] #define PACKAGE_VERSION "0.1.2.6-5899"
[ 147s] #define PACKAGE_STRING "osmo-pcap 0.1.2.6-5899"
[ 147s] #define PACKAGE_BUGREPORT "openbsc-de...@lists.openbsc.org"
[ 147s] #define PACKAGE_URL ""
[ 147s] #define PACKAGE "osmo-pcap"
[ 147s] #define VERSION "0.1.2.6-5899"
[ 147s] #define STDC_HEADERS 1
[ 147s]
[ 147s] configure: exit 1
[ 147s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu
--prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-option-checking --disable-silent-rules
--libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system
--with-pcap-config=/bin/false PCAP_CFLAGS=-I/usr/include PCAP_LIBS=-lpcap
returned exit code 1
[ 147s] make[1]: *** [debian/rules:18: override_dh_auto_configure] Error 25
[ 147s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 147s] make: *** [debian/rules:15: build] Error 2
[ 147s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 147s] ### VM INTERACTION START ###
[ 150s] [ 134.403980] sysrq: Power Off
[ 150s] [ 134.409457] reboot: Power down
[ 150s] ### VM INTERACTION END ###
[ 150s]
[ 150s] lamb09 failed "build osmo-pcap_0.1.2.6.5899.dsc" at Thu Nov 19
14:27:33 UTC 2020.
[ 150s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-ttcn3-hacks[master]: Add templates for BSSGP Radio Status procedure
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21251 )
Change subject: Add templates for BSSGP Radio Status procedure
..
Add templates for BSSGP Radio Status procedure
Change-Id: I6d49eb4907c4568d88da5d6fd7962e388a3607fb
Related: SYS#5210
---
M library/Osmocom_Gb_Types.ttcn
1 file changed, 54 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/51/21251/1
diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn
index 3ba3fca..420b6b7 100644
--- a/library/Osmocom_Gb_Types.ttcn
+++ b/library/Osmocom_Gb_Types.ttcn
@@ -1746,8 +1746,62 @@
}
}
+type enumerated BssgpRadioCause {
+ BSSGP_RADIO_CAUSE_CONTACT_LOST ('00'H),
+ BSSGP_RADIO_CAUSE_LINK_QUAL_INSUFF ('01'H),
+ BSSGP_RADIO_CAUSE_CELL_RESEL_ORDERED('02'H),
+ BSSGP_RADIO_CAUSE_CELL_RESEL_PREPARE('03'H),
+ BSSGP_RADIO_CAUSE_CELL_RESEL_FAILURE('04'H)
+} with { variant "FIELDLENGTH(8)" };
+function ts_BSSGP_RADIO_CAUSE(template (omit) BssgpRadioCause cause) return
template (omit) Radio_Cause {
+ var template (omit) Radio_Cause ret;
+ if (istemplatekind(cause, "omit")) {
+ ret := omit;
+ } else {
+ ret.iEI := '19'O;
+ ret.ext := '1'B;
+ ret.lengthIndicator := { length1 := 1 };
+ ret.radio_Cause_Value := int2oct(enum2int(valueof(cause)), 1);
+ }
+ return ret;
+}
+function tr_BSSGP_RADIO_CAUSE(template BssgpRadioCause cause) return template
Radio_Cause {
+ var template Radio_Cause ret;
+ ret.iEI := '19'O;
+ ret.ext := '1'B;
+ ret.lengthIndicator := { length1 := 1 };
+ if (isvalue(cause)) {
+ ret.radio_Cause_Value := int2oct(enum2int(valueof(cause)), 1);
+ } else {
+ ret.radio_Cause_Value := ?
+ }
+ return ret;
+}
+
+/* 10.3.5 */
+template (value) PDU_BSSGP
+ts_BSSGP_RADIO_STATUS(GprsTlli tlli, template (value) BssgpRadioCause cause)
:= {
+ pDU_BSSGP_RADIO_STATUS := {
+ bssgpPduType := '0a'O,
+ tLLI := ts_BSSGP_TLLI(tlli),
+ tMSI := omit,
+ iMSI := omit,
+ radio_Cause := ts_BSSGP_RADIO_CAUSE(cause)
+ }
+}
+template (present) PDU_BSSGP
+tr_BSSGP_RADIO_STATUS(template (present) GprsTlli tlli, template (present)
BssgpRadioCause cause) := {
+ pDU_BSSGP_RADIO_STATUS := {
+ bssgpPduType := '0a'O,
+ tLLI := ts_BSSGP_TLLI(tlli),
+ tMSI := omit,
+ iMSI := omit,
+ radio_Cause := tr_BSSGP_RADIO_CAUSE(cause)
+ }
+}
+
/* PDU permitted on PTP BVC only (TS 48.018 Section 5.4.1) */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21251
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6d49eb4907c4568d88da5d6fd7962e388a3607fb
Gerrit-Change-Number: 21251
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: gbproxy: Reset nsvc to SGSN before each test
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21233 to look at the new patch set (#4). Change subject: gbproxy: Reset nsvc to SGSN before each test .. gbproxy: Reset nsvc to SGSN before each test Change-Id: Ibf9c75b4066b1aad5fbbe2f35087a3f9f1a39743 Related: SYS#5002 Depends: I83b9cd7381c25da0e8aa847038a2d422c8dd63cf (libosmocore) --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/21233/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf9c75b4066b1aad5fbbe2f35087a3f9f1a39743 Gerrit-Change-Number: 21233 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: gbproxy: Add test for Radio Status procedure
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21252 )
Change subject: gbproxy: Add test for Radio Status procedure
..
gbproxy: Add test for Radio Status procedure
This message is only passed through by gbproxy
Change-Id: I277ba3dace936400a78670925c7c8bdf401f90f6
Related: SYS#5210
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/52/21252/1
diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index 69c18cd..a1d3793 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -758,6 +758,31 @@
}
+private function f_TC_radio_status(charstring id) runs on BSSGP_ConnHdlr {
+ var integer i;
+ var BssgpRadioCause cause := BSSGP_RADIO_CAUSE_CONTACT_LOST;
+ for (i := 0; i < 10; i := i+1) {
+ var template (value) PDU_BSSGP pdu_tx :=
ts_BSSGP_RADIO_STATUS(g_pars.tlli, cause);
+ /* we cannot use pdu_tx as there are some subtle differences in
the length field :/ */
+ var template (present) PDU_BSSGP pdu_rx :=
tr_BSSGP_RADIO_STATUS(g_pars.tlli, cause)
+
+ f_pcu2sgsn(pdu_tx, pdu_rx);
+ }
+ setverdict(pass);
+}
+testcase TC_radio_status() runs on test_CT
+{
+ var BSSGP_ConnHdlr vc_conn;
+ f_init();
+
+ vc_conn := f_start_handler(refers(f_TC_radio_status), testcasename(),
g_pcu, g_sgsn, 3);
+ vc_conn.done;
+ /* TODO: start multiple handlers (UEs) on various cells on same and
other NSEs */
+
+ f_cleanup();
+}
+
+
control {
@@ -766,6 +791,7 @@
execute( TC_dl_unitdata() );
execute( TC_ra_capability() );
execute( TC_ra_capability_upd() );
+ execute( TC_radio_status() );
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21252
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I277ba3dace936400a78670925c7c8bdf401f90f6
Gerrit-Change-Number: 21252
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Build failure of network:osmocom:nightly/orcania in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/orcania/Debian_Unstable/x86_64 Package network:osmocom:nightly/orcania failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly orcania Last lines of build log: [ 49s] [152/245] installing libsystemd0-246.6-3 [ 49s] Processing triggers for libc-bin (2.31-4) ... [ 49s] [153/245] keeping dpkg-1.20.5 [ 49s] [154/245] installing libsemanage1-3.1-1+b1 [ 49s] Processing triggers for libc-bin (2.31-4) ... [ 49s] [155/245] installing e2fsprogs-1.45.6-1 [ 50s] [156/245] installing libgnutls30-3.6.15-4 [ 50s] Processing triggers for libc-bin (2.31-4) ... [ 50s] [157/245] installing python3-minimal-3.9.0-3 [ 50s] dpkg: regarding .../python3-minimal.deb containing python3-minimal, pre-dependency problem: [ 50s] python3-minimal pre-depends on python3.9-minimal (>= 3.9.0-1~) [ 50s] python3.9-minimal is not installed. [ 50s] dpkg: warning: ignoring pre-dependency problem! [ 50s] dpkg: python3-minimal: dependency problems, but configuring anyway as you requested: [ 50s] python3-minimal depends on python3.9-minimal (>= 3.9.0-1~); however: [ 50s] Package python3.9-minimal is not installed. [ 50s] /var/lib/dpkg/info/python3-minimal.postinst: 5: py3compile: not found [ 50s] dpkg: error processing package python3-minimal (--install): [ 50s] installed python3-minimal package post-installation script subprocess returned error exit status 127 [ 50s] Errors were encountered while processing: [ 50s] python3-minimal [ 50s] exit ... [ 50s] ### VM INTERACTION START ### [ 53s] [ 36.391756] sysrq: Power Off [ 53s] [ 36.399134] reboot: Power down [ 53s] ### VM INTERACTION END ### [ 53s] [ 53s] lamb05 failed "build orcania_1.2.9-5.dsc" at Thu Nov 19 12:31:22 UTC 2020. [ 53s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bsc[master]: bts: add repeated acch mode flags + vty config
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21164 ) Change subject: bts: add repeated acch mode flags + vty config .. Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21164/5/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21164/5/src/osmo-bsc/bsc_vty.c@1121 PS5, Line 1121: vty_out(vty, " repeat dl-facch cmd%s", VTY_NEWLINE); typo: cmd -> command https://gerrit.osmocom.org/c/osmo-bsc/+/21164/5/src/osmo-bsc/bsc_vty.c@2652 PS5, Line 2652: bts->repeated_acch_capability_bts.dl_facch_cmd = 1; All these are basically booleans, so better use true/false. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190 Gerrit-Change-Number: 21164 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 11:59:53 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21084 ) Change subject: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS .. Patch Set 8: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21084/8/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21084/8/src/osmo-bsc/abis_rsl.c@475 PS8, Line 475: msgb_tlv_put(msg, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(*cap), > AFAIU you can directly do cap = msgb_tlb_put(... here. No, msgb_tlv_put() returns pointer past the added TLV. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I39ae439d05562b35b2e47774dc92f8789fea1a57 Gerrit-Change-Number: 21084 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 19 Nov 2020 11:59:14 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21084 ) Change subject: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS .. Patch Set 8: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21084/8/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21084/8/src/osmo-bsc/abis_rsl.c@475 PS8, Line 475: msgb_tlv_put(msg, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(*cap), AFAIU you can directly do cap = msgb_tlb_put(... here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I39ae439d05562b35b2e47774dc92f8789fea1a57 Gerrit-Change-Number: 21084 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 19 Nov 2020 11:57:05 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21084 ) Change subject: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS .. Patch Set 8: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/abis_rsl.c@476 PS4, Line 476: if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS > What happens if we have a different BTS vendor that also has > BTS_FEAT_ACCH_REP, but implemented diff […] How can this ever happen if this is osmocom specific? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I39ae439d05562b35b2e47774dc92f8789fea1a57 Gerrit-Change-Number: 21084 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 11:52:41 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment
Change in osmo-bsc[master]: bsc_vty: print bts number in VTY error message.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21250 ) Change subject: bsc_vty: print bts number in VTY error message. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic4213b257cb149634529e62782e4d98b3de9868b Gerrit-Change-Number: 21250 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 19 Nov 2020 11:51:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: bts: add repeated acch mode flags + vty config
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21164 )
Change subject: bts: add repeated acch mode flags + vty config
..
Patch Set 5:
(4 comments)
thanks for your review
https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3//COMMIT_MSG@10
PS3, Line 10: a one byte flag is sent
> this patch does not send anything, all i can see is an unused vty config
> option. […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/include/osmocom/bsc/bts.h
File include/osmocom/bsc/bts.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/include/osmocom/bsc/bts.h@485
PS3, Line 485: struct abis_rsl_osmo_rep_acch_cap repeated_acch_capability_bts;
> (this is a member of struct gsm_bts, redundant to also name the member *_bts)
I have given this member the _bts suffix because I want to express that this
are the flag that the BTS supports. There will be also a struct member in
gsm_subscriber_connection with the name repeated_acch_capability that tells
what the MS supports.
https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/src/osmo-bsc/bsc_vty.c@2646
PS3, Line 2646: vty_out(vty, "%% repeated ACCH not supported by
this BTS%s",
> would be good to add the BTS number: during program startup, you'd read a
> lone "this BTS" and wouldn […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/src/osmo-bsc/bsc_vty.c@2651
PS3, Line 2651: if (argv[0][0] == 'c') {
> i also did it like this some years back and got the code review that i should
> rather use a strcmp() […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190
Gerrit-Change-Number: 21164
Gerrit-PatchSet: 5
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 19 Nov 2020 11:45:54 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21084 ) Change subject: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS .. Patch Set 8: (6 comments) thanks for your review! https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/abis_rsl.c@476 PS4, Line 476: if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS > Remove BTS type and simply check for the feature. What happens if we have a different BTS vendor that also has BTS_FEAT_ACCH_REP, but implemented differently? https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c@462 PS7, Line 462: static void put_rsl_ie_osmo_rep_acch_cap(struct gsm_lchan *lchan, > (function name reads like it always puts an RSL IE in a msgb, but it first > decides on whether that s […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c@468 PS7, Line 468: if (!lchan->conn) : return; : : bts = conn_get_bts(lchan->conn); : OSMO_ASSERT(bts); > instead of all this, just say […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c@494 PS7, Line 494: msgb_tlv_put(msg, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(cap), > I think it should be possible to avoid allocating this structure on stack and > then copying it over t […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c@495 PS7, Line 495: (uint8_t *) & cap); > (unusual spaces) Done https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/gsm_08_08.c File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/gsm_08_08.c@613 PS4, Line 613: conn->repeated_acch_capability = true; > As stated I'd put the "struct gsm48_classmark3" cm3 field inside conn struct > and simply pass it to g […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I39ae439d05562b35b2e47774dc92f8789fea1a57 Gerrit-Change-Number: 21084 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 11:45:28 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-bsc[master]: bsc_vty: print bts number in VTY error message.
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21250 )
Change subject: bsc_vty: print bts number in VTY error message.
..
bsc_vty: print bts number in VTY error message.
Change-Id: Ic4213b257cb149634529e62782e4d98b3de9868b
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/21250/1
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 4f34baf..728890d 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -3104,7 +3104,7 @@
struct gsm_bts *bts = vty->index;
if (bts->type != GSM_BTS_TYPE_OSMOBTS) {
- vty_out(vty, "%% infinite radio link timeout not supported by
this BTS%s", VTY_NEWLINE);
+ vty_out(vty, "%% infinite radio link timeout not supported by
BTS %u%s", bts->nr, VTY_NEWLINE);
return CMD_WARNING;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21250
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic4213b257cb149634529e62782e4d98b3de9868b
Gerrit-Change-Number: 21250
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS
Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21084 to look at the new patch set (#8). Change subject: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS .. abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS In order to activate FACCH/SACCH repetition on the BTS, the classmark 3 IE in the CLASSMARK CHANGE message must be parsed and depending on the Repeated ACCH Capability bit the RSL_IE_OSMO_REP_ACCH_CAP is added to the RSL CHAN ACT und RSL CHAN MODE MODIFY. Since RSL_IE_OSMO_REP_ACCH_CAP is a propritary IE, it may only be added for BTS type osmo-bts. Change-Id: I39ae439d05562b35b2e47774dc92f8789fea1a57 Related: OS#4796 SYS#5114 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/gsm_08_08.c 3 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/21084/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I39ae439d05562b35b2e47774dc92f8789fea1a57 Gerrit-Change-Number: 21084 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: bts: add repeated acch mode flags + vty config
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164 to look at the new patch set (#5). Change subject: bts: add repeated acch mode flags + vty config .. bts: add repeated acch mode flags + vty config To be able to control the FACCH/SACCH repetition behavior inside the BTS a one byte flag is sent to the BTS together with the RSL_IE_OSMO_REP_ACCH_CAP IE. This patch adds the necessary VTY commands. The sending of the flag is implemented in a follow-up patch. See also: I39ae439d05562b35b2e47774dc92f8789fea1a57 Related: SYS#5114, OS#4796, OS#4794, OS#4795 Depends: libosmocore I326e66dae25acfab0b3fddc7278b39a8cbf7d385 Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bsc_vty.c 2 files changed, 125 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/21164/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190 Gerrit-Change-Number: 21164 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: ns2: Add a function to set the NSVC FSM back to unconfigured
Hello Jenkins Builder, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21231 to look at the new patch set (#3). Change subject: ns2: Add a function to set the NSVC FSM back to unconfigured .. ns2: Add a function to set the NSVC FSM back to unconfigured The function gprs_ns2_vs_force_unconfigured() resets the NSVC state back to the initial value when it was first started. This can be useful for testing. Related: SYS#5002 Change-Id: If96d56b19959372af4eba009661be19e985b4d51 --- M src/gb/gprs_ns2_internal.h M src/gb/gprs_ns2_vc_fsm.c 2 files changed, 40 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/21231/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If96d56b19959372af4eba009661be19e985b4d51 Gerrit-Change-Number: 21231 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Build failure of network:osmocom:latest/osmo-pcap in Debian_Unstable/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcap/Debian_Unstable/x86_64
Package network:osmocom:latest/osmo-pcap failed to build in
Debian_Unstable/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest osmo-pcap
Last lines of build log:
[ 189s]
[ 189s] ## --- ##
[ 189s] ## confdefs.h. ##
[ 189s] ## --- ##
[ 189s]
[ 189s] /* confdefs.h */
[ 189s] #define PACKAGE_NAME "osmo-pcap"
[ 189s] #define PACKAGE_TARNAME "osmo-pcap"
[ 189s] #define PACKAGE_VERSION "0.1.2"
[ 189s] #define PACKAGE_STRING "osmo-pcap 0.1.2"
[ 189s] #define PACKAGE_BUGREPORT "openbsc-de...@lists.openbsc.org"
[ 189s] #define PACKAGE_URL ""
[ 189s] #define PACKAGE "osmo-pcap"
[ 189s] #define VERSION "0.1.2"
[ 189s] #define STDC_HEADERS 1
[ 189s]
[ 189s] configure: exit 1
[ 189s] dh_auto_configure: error: ./configure --build=x86_64-linux-gnu
--prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-option-checking --disable-silent-rules
--libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system
--with-pcap-config=/bin/false PCAP_CFLAGS=-I/usr/include PCAP_LIBS=-lpcap
returned exit code 1
[ 189s] make[1]: *** [debian/rules:18: override_dh_auto_configure] Error 25
[ 189s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 189s] make: *** [debian/rules:15: build] Error 2
[ 189s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 189s] ### VM INTERACTION START ###
[ 192s] [ 172.907328] sysrq: Power Off
[ 192s] [ 172.911348] reboot: Power down
[ 192s] ### VM INTERACTION END ###
[ 192s]
[ 192s] lamb18 failed "build osmo-pcap_0.1.2.dsc" at Thu Nov 19 11:28:18 UTC
2020.
[ 192s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 439s] [COMPILING apps/dfu/main.c] [ 439s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 439s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 440s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 440s] Memory region Used Size Region Size %age Used [ 440s] rom: 16580 B16 KB101.20% [ 440s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 440s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 440s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 440s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 440s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 440s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 440s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 196 bytes [ 440s] collect2: error: ld returned 1 exit status [ 440s] % [ 440s] make[2]: *** [Makefile:234: flash] Error 1 [ 440s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 440s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 440s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 440s] dh_auto_build: error: make -j1 returned exit code 2 [ 440s] make: *** [debian/rules:16: build] Error 25 [ 440s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 441s] ### VM INTERACTION START ### [ 444s] [ 429.942760] sysrq: Power Off [ 444s] [ 429.983305] reboot: Power down [ 444s] ### VM INTERACTION END ### [ 444s] [ 444s] lamb12 failed "build simtrace2_0.7.0.69.aadd.dsc" at Thu Nov 19 11:27:05 UTC 2020. [ 444s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 124s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 124s] [COMPILING libboard/qmod/source/card_pres.c] [ 124s] [COMPILING libboard/qmod/source/wwan_led.c] [ 124s] [COMPILING libboard/qmod/source/i2c.c] [ 124s] [COMPILING libboard/qmod/source/board_qmod.c] [ 124s] [COMPILING apps/dfu/main.c] [ 124s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 124s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 124s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 125s] Memory region Used Size Region Size %age Used [ 125s] rom: 16588 B16 KB101.25% [ 125s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 125s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 125s] collect2: error: ld returned 1 exit status [ 125s] % [ 125s] make[2]: *** [Makefile:234: flash] Error 1 [ 125s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 125s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 125s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 125s] dh_auto_build: error: make -j1 returned exit code 2 [ 125s] make: *** [debian/rules:16: build] Error 25 [ 125s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 125s] ### VM INTERACTION START ### [ 128s] [ 117.684029] sysrq: Power Off [ 128s] [ 117.693608] reboot: Power down [ 128s] ### VM INTERACTION END ### [ 128s] [ 128s] sheep82 failed "build simtrace2_0.7.0.69.aadd.dsc" at Thu Nov 19 11:13:21 UTC 2020. [ 128s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: ns2: Split initiater into init_reset and init_block
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21240 ) Change subject: ns2: Split initiater into init_reset and init_block .. Patch Set 1: > Patch Set 1: > > Why do we need it? Because blocking/unblocking from the SGSN could change initiator from true to false. Then the BSS side would not (re)send RESETs and both sides will wait for a RESET forever. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iff5aff0cf8d19d9c718dd11c4e731ced2aeb16ba Gerrit-Change-Number: 21240 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: lynxis lazus Gerrit-Comment-Date: Thu, 19 Nov 2020 11:06:33 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Build failure of network:osmocom:latest/open5gs in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/open5gs/Debian_Unstable/x86_64 Package network:osmocom:latest/open5gs failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest open5gs Last lines of build log: [ 62s] Processing triggers for libc-bin (2.31-4) ... [ 62s] [161/266] keeping dpkg-1.20.5 [ 62s] [162/266] installing libsemanage1-3.1-1+b1 [ 62s] Processing triggers for libc-bin (2.31-4) ... [ 62s] [163/266] installing e2fsprogs-1.45.6-1 [ 63s] [164/266] installing libgnutls30-3.6.15-4 [ 63s] Processing triggers for libc-bin (2.31-4) ... [ 63s] [165/266] installing libsnappy-dev-1.1.8-1 [ 63s] [166/266] installing python3-minimal-3.9.0-3 [ 63s] dpkg: regarding .../python3-minimal.deb containing python3-minimal, pre-dependency problem: [ 63s] python3-minimal pre-depends on python3.9-minimal (>= 3.9.0-1~) [ 63s] python3.9-minimal is not installed. [ 63s] dpkg: warning: ignoring pre-dependency problem! [ 63s] dpkg: python3-minimal: dependency problems, but configuring anyway as you requested: [ 63s] python3-minimal depends on python3.9-minimal (>= 3.9.0-1~); however: [ 63s] Package python3.9-minimal is not installed. [ 63s] /var/lib/dpkg/info/python3-minimal.postinst: 5: py3compile: not found [ 63s] dpkg: error processing package python3-minimal (--install): [ 63s] installed python3-minimal package post-installation script subprocess returned error exit status 127 [ 63s] Errors were encountered while processing: [ 63s] python3-minimal [ 63s] exit ... [ 63s] ### VM INTERACTION START ### [ 66s] [ 33.550081] sysrq: Power Off [ 66s] [ 33.566732] reboot: Power down [ 66s] ### VM INTERACTION END ### [ 66s] [ 66s] cloud107 failed "build open5gs_2.0.21~focal.dsc" at Thu Nov 19 10:55:24 UTC 2020. [ 66s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-ttcn3-hacks[master]: pcu: Fix counter expectancies in TC_bssgp_dl_unitdata_with_valid_imsi
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21209 ) Change subject: pcu: Fix counter expectancies in TC_bssgp_dl_unitdata_with_valid_imsi .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7112a96f5f2ca9c5bbd224b6270f55a338d101a Gerrit-Change-Number: 21209 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Thu, 19 Nov 2020 10:55:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 91s] [243/468] installing libsystemd0-246.6-3 [ 91s] Processing triggers for libc-bin (2.31-4) ... [ 91s] [244/468] keeping dpkg-1.20.5 [ 91s] [245/468] installing libsemanage1-3.1-1+b1 [ 91s] Processing triggers for libc-bin (2.31-4) ... [ 91s] [246/468] installing e2fsprogs-1.45.6-1 [ 92s] [247/468] installing libgnutls30-3.6.15-4 [ 92s] Processing triggers for libc-bin (2.31-4) ... [ 92s] [248/468] installing python3-minimal-3.9.0-3 [ 92s] dpkg: regarding .../python3-minimal.deb containing python3-minimal, pre-dependency problem: [ 92s] python3-minimal pre-depends on python3.9-minimal (>= 3.9.0-1~) [ 92s] python3.9-minimal is not installed. [ 92s] dpkg: warning: ignoring pre-dependency problem! [ 92s] dpkg: python3-minimal: dependency problems, but configuring anyway as you requested: [ 92s] python3-minimal depends on python3.9-minimal (>= 3.9.0-1~); however: [ 92s] Package python3.9-minimal is not installed. [ 92s] /var/lib/dpkg/info/python3-minimal.postinst: 5: py3compile: not found [ 92s] dpkg: error processing package python3-minimal (--install): [ 92s] installed python3-minimal package post-installation script subprocess returned error exit status 127 [ 92s] Errors were encountered while processing: [ 92s] python3-minimal [ 92s] exit ... [ 92s] ### VM INTERACTION START ### [ 95s] [ 61.814218] sysrq: Power Off [ 95s] [ 61.821095] reboot: Power down [ 95s] ### VM INTERACTION END ### [ 95s] [ 95s] lamb03 failed "build osmo-gsm-manuals-dev_0.3.0.dsc" at Thu Nov 19 10:39:28 UTC 2020. [ 95s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: ns2: remove obsolete type GPRS_NS2_LL_E1
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21248 ) Change subject: ns2: remove obsolete type GPRS_NS2_LL_E1 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iabb4608d91ccb32a07cad67519166dabfba76612 Gerrit-Change-Number: 21248 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 10:15:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: move link layer type into NSE
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21247 ) Change subject: ns2: move link layer type into NSE .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I18dfd40a2429cd61b7c4a3dad5f226c64296f7d8 Gerrit-Change-Number: 21247 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 10:15:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: move LL into public api
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21246 ) Change subject: ns2: move LL into public api .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3b5e0d51ce69b095095e5160ca0cf0d4534db1b8 Gerrit-Change-Number: 21246 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 10:12:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: permit multiple nsvci in one nse in VTY
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21245 ) Change subject: ns2: permit multiple nsvci in one nse in VTY .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21245/1/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/21245/1/src/gb/gprs_ns2_vty.c@170 PS1, Line 170: extra line not needed -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4ad454320d0a03e81b399f55e8bd0ee57402dad0 Gerrit-Change-Number: 21245 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 10:11:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: implement link sharing selector
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21244 ) Change subject: ns2: implement link sharing selector .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c@a62 PS1, Line 62: * - Only UDP is supported as of now, no frame relay support This line should actually be dropped in previous patch right? https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c@309 PS1, Line 309: struct gprs_ns2_nse *nse) this looks weird, move it to same line better. https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c@400 PS1, Line 400: nsvc = llist_first_entry(>nsvc, struct gprs_ns2_vc, list); could it be this is NULL? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I212fa1a65e8c16cf1e525d1962d5689446c7e49e Gerrit-Change-Number: 21244 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 10:10:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: ns2: add support for frame relay
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21243 ) Change subject: ns2: add support for frame relay .. Patch Set 1: Code-Review-1 (19 comments) https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c File src/gb/frame_relay.c: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@106 PS1, Line 106: /* RX Message: 14 [ 00 01 03 08 00 75 95 01 01 00 03 02 01 00 ] */ this can be dropped right? https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@119 PS1, Line 119: // .default_val = 10, ? https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@222 PS1, Line 222: ie[2] |= 0x02; what are these 0x02 0x04 0x08? Please add defines for those. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@276 PS1, Line 276: line can be dropped. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@310 PS1, Line 310: LOGPFRL(link, LOGL_ERROR, "STATUS-ENQ aren't support for role user\n"); "are not supported" https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@343 PS1, Line 343: /* TODO: implement FRNET free */ sounds like leaking memory? https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@366 PS1, Line 366: link->succeed = link->succeed << 1; link->succeed <<= 1; https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@370 PS1, Line 370: /* count the bits */ It would be great to explain a bit better what exactly are you doing here or provide some spec reference. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@461 PS1, Line 461: LOGPFRL(link, LOGL_ERROR, "Could not create DLC %d\n", dlci); return, or directly OSMO_ASERT. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@468 PS1, Line 468: dlc->add = pvc->new; not sure if this "new" here will cause problems when compiling with c++. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@657 PS1, Line 657: tlv_parse2(tp, MAX_SUPPORTED_PVC + 1, _att_tlvdef, msgb_l3(msg) + sizeof(*qh), msgb_l3len(msg) - sizeof(*qh), 0, 0); check return code. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@889 PS1, Line 889: /* TODO: osmo_fr_dlc_alloc with deregistering it from the link in fr-net */ you probably mean _free here? https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2.c@262 PS1, Line 262: snprintf(buf, buf_len, "fr)netif: %s dlci: %s", "hdlcX", "unsupported"); this needs work to print correct variables right? https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c File src/gb/gprs_ns2_fr.c: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c@86 PS1, Line 86: struct iphdr Don't we have this defined somewhere else? We should move this to some osmocom compat header IMHO, similar to what we do with timespecs, etc. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c@119 PS1, Line 119: char netif[IF_NAMESIZE + 1]; IFNAMSIZ. That's the maximum size including the null char. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c@263 PS1, Line 263: /* FIXME */ this should be added now right? https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c@301 PS1, Line 301: /* FIXME half writes */ IIUC this should put stuff into a wqueue? https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_vty.c@86 PS1, Line 86: char netif[IF_NAMESIZE + 1]; remove +1 https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_vty.c@484 PS1, Line 484: uint16_t dlci = atoi(argv[2]); This looks wrong, I only see 2 arguments in this vty cmd. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id3b49f93d33c271f77cd9c9db03cde6b727a4d30 Gerrit-Change-Number: 21243 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 10:05:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/open5gs in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_Unstable/x86_64 Package network:osmocom:nightly/open5gs failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 107s] Processing triggers for libc-bin (2.31-4) ... [ 107s] [161/266] keeping dpkg-1.20.5 [ 107s] [162/266] installing libsemanage1-3.1-1+b1 [ 107s] Processing triggers for libc-bin (2.31-4) ... [ 107s] [163/266] installing e2fsprogs-1.45.6-1 [ 108s] [164/266] installing libgnutls30-3.6.15-4 [ 109s] Processing triggers for libc-bin (2.31-4) ... [ 109s] [165/266] installing libsnappy-dev-1.1.8-1 [ 109s] [166/266] installing python3-minimal-3.9.0-3 [ 109s] dpkg: regarding .../python3-minimal.deb containing python3-minimal, pre-dependency problem: [ 109s] python3-minimal pre-depends on python3.9-minimal (>= 3.9.0-1~) [ 109s] python3.9-minimal is not installed. [ 109s] dpkg: warning: ignoring pre-dependency problem! [ 109s] dpkg: python3-minimal: dependency problems, but configuring anyway as you requested: [ 109s] python3-minimal depends on python3.9-minimal (>= 3.9.0-1~); however: [ 109s] Package python3.9-minimal is not installed. [ 109s] /var/lib/dpkg/info/python3-minimal.postinst: 5: py3compile: not found [ 109s] dpkg: error processing package python3-minimal (--install): [ 109s] installed python3-minimal package post-installation script subprocess returned error exit status 127 [ 109s] Errors were encountered while processing: [ 109s] python3-minimal [ 109s] exit ... [ 109s] ### VM INTERACTION START ### [ 112s] [ 75.327898] sysrq: Power Off [ 112s] [ 75.398530] reboot: Power down [ 113s] ### VM INTERACTION END ### [ 113s] [ 113s] lamb59 failed "build open5gs_2.0.21.20201119.dsc" at Thu Nov 19 10:03:57 UTC 2020. [ 113s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 46s] [142/227] installing libsystemd0-246.6-3 [ 47s] Processing triggers for libc-bin (2.31-4) ... [ 47s] [143/227] keeping dpkg-1.20.5 [ 47s] [144/227] installing libsemanage1-3.1-1+b1 [ 47s] Processing triggers for libc-bin (2.31-4) ... [ 47s] [145/227] installing e2fsprogs-1.45.6-1 [ 47s] [146/227] installing libgnutls30-3.6.15-4 [ 47s] Processing triggers for libc-bin (2.31-4) ... [ 47s] [147/227] installing python3-minimal-3.9.0-3 [ 47s] dpkg: regarding .../python3-minimal.deb containing python3-minimal, pre-dependency problem: [ 47s] python3-minimal pre-depends on python3.9-minimal (>= 3.9.0-1~) [ 47s] python3.9-minimal is not installed. [ 47s] dpkg: warning: ignoring pre-dependency problem! [ 47s] dpkg: python3-minimal: dependency problems, but configuring anyway as you requested: [ 47s] python3-minimal depends on python3.9-minimal (>= 3.9.0-1~); however: [ 47s] Package python3.9-minimal is not installed. [ 47s] /var/lib/dpkg/info/python3-minimal.postinst: 5: py3compile: not found [ 47s] dpkg: error processing package python3-minimal (--install): [ 47s] installed python3-minimal package post-installation script subprocess returned error exit status 127 [ 47s] Errors were encountered while processing: [ 47s] python3-minimal [ 48s] exit ... [ 48s] ### VM INTERACTION START ### [ 51s] [ 32.293280] sysrq: Power Off [ 51s] [ 32.315613] reboot: Power down [ 51s] ### VM INTERACTION END ### [ 51s] [ 51s] lamb08 failed "build osmo-python-tests_0.0.9.20201119.dsc" at Thu Nov 19 09:42:31 UTC 2020. [ 51s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: ns2: check if ns_vc_alloc() fails in bind_connect()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21242 ) Change subject: ns2: check if ns_vc_alloc() fails in bind_connect() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82c984b9808451a72a62ff03b0495a1d09473e1c Gerrit-Change-Number: 21242 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 09:22:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: ansible: add role for 'podman'
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/21241 ) Change subject: ansible: add role for 'podman' .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/21241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4b14599f39c07ec83fa4222f9d040d443caae3e6 Gerrit-Change-Number: 21241 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Nov 2020 09:22:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 143s] [243/468] installing libsystemd0-246.6-3 [ 144s] Processing triggers for libc-bin (2.31-4) ... [ 144s] [244/468] keeping dpkg-1.20.5 [ 144s] [245/468] installing libsemanage1-3.1-1+b1 [ 144s] Processing triggers for libc-bin (2.31-4) ... [ 144s] [246/468] installing e2fsprogs-1.45.6-1 [ 145s] [247/468] installing libgnutls30-3.6.15-4 [ 146s] Processing triggers for libc-bin (2.31-4) ... [ 146s] [248/468] installing python3-minimal-3.9.0-3 [ 146s] dpkg: regarding .../python3-minimal.deb containing python3-minimal, pre-dependency problem: [ 146s] python3-minimal pre-depends on python3.9-minimal (>= 3.9.0-1~) [ 146s] python3.9-minimal is not installed. [ 146s] dpkg: warning: ignoring pre-dependency problem! [ 146s] dpkg: python3-minimal: dependency problems, but configuring anyway as you requested: [ 146s] python3-minimal depends on python3.9-minimal (>= 3.9.0-1~); however: [ 146s] Package python3.9-minimal is not installed. [ 146s] /var/lib/dpkg/info/python3-minimal.postinst: 5: py3compile: not found [ 146s] dpkg: error processing package python3-minimal (--install): [ 146s] installed python3-minimal package post-installation script subprocess returned error exit status 127 [ 146s] Errors were encountered while processing: [ 146s] python3-minimal [ 146s] exit ... [ 146s] ### VM INTERACTION START ### [ 150s] [ 112.361970] sysrq: Power Off [ 150s] [ 112.416809] reboot: Power down [ 150s] ### VM INTERACTION END ### [ 150s] [ 150s] lamb54 failed "build osmo-gsm-manuals-dev_0.3.0.32.ff86.dsc" at Thu Nov 19 09:13:41 UTC 2020. [ 150s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Unstable/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 52s] [199/405] installing libsemanage1-3.1-1+b1 [ 52s] Processing triggers for libc-bin (2.31-4) ... [ 52s] [200/405] installing e2fsprogs-1.45.6-1 [ 53s] [201/405] installing libboost-iostreams1.71.0-1.71.0-7+b1 [ 53s] Processing triggers for libc-bin (2.31-4) ... [ 53s] [202/405] installing libgnutls30-3.6.15-4 [ 53s] Processing triggers for libc-bin (2.31-4) ... [ 53s] [203/405] installing libboost-tools-dev-1.71.0.3 [ 53s] [204/405] installing python3-minimal-3.9.0-3 [ 53s] dpkg: regarding .../python3-minimal.deb containing python3-minimal, pre-dependency problem: [ 53s] python3-minimal pre-depends on python3.9-minimal (>= 3.9.0-1~) [ 53s] python3.9-minimal is not installed. [ 53s] dpkg: warning: ignoring pre-dependency problem! [ 53s] dpkg: python3-minimal: dependency problems, but configuring anyway as you requested: [ 53s] python3-minimal depends on python3.9-minimal (>= 3.9.0-1~); however: [ 53s] Package python3.9-minimal is not installed. [ 53s] /var/lib/dpkg/info/python3-minimal.postinst: 5: py3compile: not found [ 53s] dpkg: error processing package python3-minimal (--install): [ 53s] installed python3-minimal package post-installation script subprocess returned error exit status 127 [ 53s] Errors were encountered while processing: [ 53s] python3-minimal [ 53s] exit ... [ 53s] ### VM INTERACTION START ### [ 57s] [ 39.152713] sysrq: Power Off [ 57s] [ 39.164971] reboot: Power down [ 57s] ### VM INTERACTION END ### [ 57s] [ 57s] lamb17 failed "build libusrp_3.4.5.dsc" at Thu Nov 19 09:01:47 UTC 2020. [ 57s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 70s] [199/405] installing libsemanage1-3.1-1+b1 [ 71s] Processing triggers for libc-bin (2.31-4) ... [ 71s] [200/405] installing e2fsprogs-1.45.6-1 [ 72s] [201/405] installing libboost-iostreams1.71.0-1.71.0-7+b1 [ 72s] Processing triggers for libc-bin (2.31-4) ... [ 72s] [202/405] installing libgnutls30-3.6.15-4 [ 73s] Processing triggers for libc-bin (2.31-4) ... [ 73s] [203/405] installing libboost-tools-dev-1.71.0.3 [ 73s] [204/405] installing python3-minimal-3.9.0-3 [ 73s] dpkg: regarding .../python3-minimal.deb containing python3-minimal, pre-dependency problem: [ 73s] python3-minimal pre-depends on python3.9-minimal (>= 3.9.0-1~) [ 73s] python3.9-minimal is not installed. [ 73s] dpkg: warning: ignoring pre-dependency problem! [ 73s] dpkg: python3-minimal: dependency problems, but configuring anyway as you requested: [ 73s] python3-minimal depends on python3.9-minimal (>= 3.9.0-1~); however: [ 73s] Package python3.9-minimal is not installed. [ 73s] /var/lib/dpkg/info/python3-minimal.postinst: 5: py3compile: not found [ 73s] dpkg: error processing package python3-minimal (--install): [ 73s] installed python3-minimal package post-installation script subprocess returned error exit status 127 [ 73s] Errors were encountered while processing: [ 73s] python3-minimal [ 73s] exit ... [ 73s] ### VM INTERACTION START ### [ 76s] [ 55.298323] sysrq: Power Off [ 77s] [ 55.329912] reboot: Power down [ 77s] ### VM INTERACTION END ### [ 77s] [ 77s] lamb52 failed "build libusrp_3.4.5.dsc" at Thu Nov 19 09:00:53 UTC 2020. [ 77s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/orcania in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/Debian_Unstable/x86_64 Package network:osmocom:latest/orcania failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 38s] [152/245] installing libsystemd0-246.6-3 [ 38s] Processing triggers for libc-bin (2.31-4) ... [ 39s] [153/245] keeping dpkg-1.20.5 [ 39s] [154/245] installing libsemanage1-3.1-1+b1 [ 39s] Processing triggers for libc-bin (2.31-4) ... [ 39s] [155/245] installing e2fsprogs-1.45.6-1 [ 39s] [156/245] installing libgnutls30-3.6.15-4 [ 39s] Processing triggers for libc-bin (2.31-4) ... [ 39s] [157/245] installing python3-minimal-3.9.0-3 [ 39s] dpkg: regarding .../python3-minimal.deb containing python3-minimal, pre-dependency problem: [ 39s] python3-minimal pre-depends on python3.9-minimal (>= 3.9.0-1~) [ 39s] python3.9-minimal is not installed. [ 39s] dpkg: warning: ignoring pre-dependency problem! [ 39s] dpkg: python3-minimal: dependency problems, but configuring anyway as you requested: [ 39s] python3-minimal depends on python3.9-minimal (>= 3.9.0-1~); however: [ 39s] Package python3.9-minimal is not installed. [ 39s] /var/lib/dpkg/info/python3-minimal.postinst: 5: py3compile: not found [ 39s] dpkg: error processing package python3-minimal (--install): [ 39s] installed python3-minimal package post-installation script subprocess returned error exit status 127 [ 39s] Errors were encountered while processing: [ 39s] python3-minimal [ 39s] exit ... [ 39s] ### VM INTERACTION START ### [ 42s] [ 28.759141] sysrq: Power Off [ 42s] [ 28.764917] reboot: Power down [ 42s] ### VM INTERACTION END ### [ 43s] [ 43s] sheep86 failed "build orcania_1.2.9-5.dsc" at Thu Nov 19 08:59:12 UTC 2020. [ 43s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
