Change in osmo-gsm-tester[master]: 4g: add checks for received PRACHs for ping tests
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22043 ) Change subject: 4g: add checks for received PRACHs for ping tests .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ib23056b1ad4b18a7dde6cd0c997f5114ac2acb61 Gerrit-Change-Number: 22043 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:22:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb: add stdout counter helper to eNB objects
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042 ) Change subject: enb: add stdout counter helper to eNB objects .. Patch Set 1: Code-Review-1 (3 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/enb.py File src/osmo_gsm_tester/obj/enb.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/enb.py@349 PS1, Line 349: def get_counter(self, counter_name): I'd rather leave it as @abstractmethod here and make sure all implementations either implement it correctly or simply implement them by raising an exception like yo did here. This way it's easier to find out when implementing a subclass what's missing before running into it (thanks to ABCMeta) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/enb_srs.py File src/osmo_gsm_tester/obj/enb_srs.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/enb_srs.py@89 PS1, Line 89: # Make sure we give time to tear down Not related to this commit, submit in a separate commit please. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/srslte_common.py File src/osmo_gsm_tester/obj/srslte_common.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/srslte_common.py@102 PS1, Line 102: def _get_counter_stdout(self, keyword): What about moving this function to Process class? as in process.count_lines(match=keyword, stream=stdout) or something alike. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I434f072b8aa6f4dce9f90889c6b40832f6798ff8 Gerrit-Change-Number: 22042 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:21:03 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srsenb.conf.tmpl: set nof_of_prach_threds to 0 for ZMQ
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22041 ) Change subject: srsenb.conf.tmpl: set nof_of_prach_threds to 0 for ZMQ .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I97eddb5f9ca682251ded1f73093c2d0a49462bd6 Gerrit-Change-Number: 22041 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:15:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srsepc.conf.tmpl: increase default value of T3413 (paging timer)
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22040 ) Change subject: srsepc.conf.tmpl: increase default value of T3413 (paging timer) .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22040 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Icc75ee048c2cc605ab26c4c87a039519998f7e57 Gerrit-Change-Number: 22040 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:14:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb_srs: adopt throughput thresholds for QAM256
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22039 ) Change subject: enb_srs: adopt throughput thresholds for QAM256 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I0e38fe28002fd68c768cc8dcffcf74f4f190df02 Gerrit-Change-Number: 22039 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:14:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb_srs: only use QAM64 tables if both UE and eNB are configured for ...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22038 ) Change subject: enb_srs: only use QAM64 tables if both UE and eNB are configured for QAM64 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22038 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I599df92d69eeb56a5d44327de08f004222cff073 Gerrit-Change-Number: 22038 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:13:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: iperf3: return 0 if iperf results can't be read back
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037 ) Change subject: iperf3: return 0 if iperf results can't be read back .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485 Gerrit-Change-Number: 22037 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:11:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srsue.conf.tmpl: disable TTI stats for ZMQ
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22036 ) Change subject: srsue.conf.tmpl: disable TTI stats for ZMQ .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I5c2cb0abcfce0ee67806f6611356f4d5d180541d Gerrit-Change-Number: 22036 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:10:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: intraenb-intrafreq-ho.conf: add eNB to cell config
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22035 ) Change subject: intraenb-intrafreq-ho.conf: add eNB to cell config .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Id494ac1984846e78a6456bb6a17e72d63c9dacf5 Gerrit-Change-Number: 22035 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:09:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srsue.conf.tmpl: reorder conditions for setting RRC release
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034 ) Change subject: srsue.conf.tmpl: reorder conditions for setting RRC release .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7 Gerrit-Change-Number: 22034 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:09:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: enb: include name label and run_addr in enb remote path
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22033 ) Change subject: enb: include name label and run_addr in enb remote path .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I9c979de852a23041e43692e97ebcbfb389b52fdb Gerrit-Change-Number: 22033 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:07:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srsenb_drb.conf.tmpl: add QCI1 DRB config
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22032 ) Change subject: srsenb_drb.conf.tmpl: add QCI1 DRB config .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I43f408b1a3c172a5eb8327f03df49801e063e5cd Gerrit-Change-Number: 22032 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:07:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: jenkins-build-srslte.sh: allow custom binaries
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22031 ) Change subject: jenkins-build-srslte.sh: allow custom binaries .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I63f5799328435ce32b5bfd6dae6fd0b37e1e5397 Gerrit-Change-Number: 22031 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 17:07:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: 4g: add checks for received PRACHs for ping tests
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22043 )
Change subject: 4g: add checks for received PRACHs for ping tests
..
4g: add checks for received PRACHs for ping tests
the tests already check for sent PRACHs, this will
also check for received PRACHs on the eNB to make
sure we don't detect any fake PRACHs during the tests.
Change-Id: Ib23056b1ad4b18a7dde6cd0c997f5114ac2acb61
---
M sysmocom/suites/4g/rrc_idle_mo_ping.py
M sysmocom/suites/4g/rrc_idle_mt_ping.py
2 files changed, 19 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/43/22043/1
diff --git a/sysmocom/suites/4g/rrc_idle_mo_ping.py
b/sysmocom/suites/4g/rrc_idle_mo_ping.py
index ced798d..389e5a2 100755
--- a/sysmocom/suites/4g/rrc_idle_mo_ping.py
+++ b/sysmocom/suites/4g/rrc_idle_mo_ping.py
@@ -31,9 +31,16 @@
output = proc.get_stdout()
# Check PRACH transmissions
+num_prachs = 2
num_prach_sent = ue.get_counter('prach_sent')
-if num_prach_sent != 2:
-raise Exception("Expected to have sent exactly 2 PRACHs, but in fact sent
{}".format(num_prach_sent))
+if num_prach_sent != num_prachs:
+raise Exception("Expected to have sent exactly {} PRACHs, but in fact sent
{}".format(num_prachs, num_prach_sent))
+# Check PRACH receptions
+num_prach_received = enb.get_counter('prach_received')
+if num_prach_sent != num_prachs:
+raise Exception("Expected to have received exactly {} PRACHs, but in fact
received {}".format(num_prachs, num_prach_received))
+
+output +=
"\nnum_prach_sent={}\nnum_prach_received={}\n".format(num_prach_sent,
num_prach_received)
print(output)
test.set_report_stdout(output)
diff --git a/sysmocom/suites/4g/rrc_idle_mt_ping.py
b/sysmocom/suites/4g/rrc_idle_mt_ping.py
index dcabe21..bdebb26 100755
--- a/sysmocom/suites/4g/rrc_idle_mt_ping.py
+++ b/sysmocom/suites/4g/rrc_idle_mt_ping.py
@@ -26,7 +26,7 @@
# Wait a bit
sleep(5)
-# Generate MO traffic, send single ping
+# Generate MT traffic, send single ping
proc = epc.prepare_process('ping', ('ping', '-c', '1', ue.get_assigned_addr()))
proc.launch_sync()
output = proc.get_stdout()
@@ -37,9 +37,16 @@
raise Exception("Expected to receive exactly 1 paging message, but in fact
received {}".format(num_paging_received))
# Check PRACH transmissions
+num_prachs = 2
num_prach_sent = ue.get_counter('prach_sent')
-if num_prach_sent != 2:
-raise Exception("Expected to have sent exactly 2 PRACHs, but in fact sent
{}".format(num_prach_sent))
+if num_prach_sent != num_prachs:
+raise Exception("Expected to have sent exactly {} PRACHs, but in fact sent
{}".format(num_prachs, num_prach_sent))
+# Check PRACH receptions
+num_prach_received = enb.get_counter('prach_received')
+if num_prach_sent != num_prachs:
+raise Exception("Expected to have received exactly {} PRACHs, but in fact
received {}".format(num_prachs, num_prach_received))
+
+output +=
"\nnum_prach_sent={}\nnum_prach_received={}\n".format(num_prach_sent,
num_prach_received)
print(output)
test.set_report_stdout(output)
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22043
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib23056b1ad4b18a7dde6cd0c997f5114ac2acb61
Gerrit-Change-Number: 22043
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: enb: add stdout counter helper to eNB objects
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042 )
Change subject: enb: add stdout counter helper to eNB objects
..
enb: add stdout counter helper to eNB objects
this patch adds the stdout counter to count events happening
on the stdout (known from the UE already) to the common
srslte class so they can also be used from the eNB.
In addition, we add a PRACH counter to be used for tests.
Change-Id: I434f072b8aa6f4dce9f90889c6b40832f6798ff8
---
M src/osmo_gsm_tester/obj/enb.py
M src/osmo_gsm_tester/obj/enb_amarisoft.py
M src/osmo_gsm_tester/obj/enb_srs.py
M src/osmo_gsm_tester/obj/ms_srs.py
M src/osmo_gsm_tester/obj/srslte_common.py
5 files changed, 33 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/42/22042/1
diff --git a/src/osmo_gsm_tester/obj/enb.py b/src/osmo_gsm_tester/obj/enb.py
index 3944459..2eac0fe 100644
--- a/src/osmo_gsm_tester/obj/enb.py
+++ b/src/osmo_gsm_tester/obj/enb.py
@@ -346,4 +346,7 @@
def addr(self):
return self._run_node.run_addr()
+def get_counter(self, counter_name):
+raise log.Error('get_counter() not implemented!')
+
# vim: expandtab tabstop=4 shiftwidth=4
diff --git a/src/osmo_gsm_tester/obj/enb_amarisoft.py
b/src/osmo_gsm_tester/obj/enb_amarisoft.py
index ef28100..62c5b8a 100644
--- a/src/osmo_gsm_tester/obj/enb_amarisoft.py
+++ b/src/osmo_gsm_tester/obj/enb_amarisoft.py
@@ -247,6 +247,20 @@
def running(self):
return not self.process.terminated()
+def get_counter(self, counter_name):
+if counter_name == 'prach_received':
+return self._get_counter_stdout('PRACH:')
+raise log.Error('counter %s not implemented!' % counter_name)
+
+def _get_counter_stdout(self, keyword):
+# Match stdout against keyword
+n = 0
+stdout_lines = (self.process.get_stdout() or '').splitlines()
+for l in stdout_lines:
+if keyword in l:
+n += 1
+return n
+
def get_rfemu(self, cell=0, dl=True):
cell_list = self.gen_conf['enb'].get('cell_list', None)
if cell_list is None or len(cell_list) < cell + 1:
diff --git a/src/osmo_gsm_tester/obj/enb_srs.py
b/src/osmo_gsm_tester/obj/enb_srs.py
index 6afc873..221259a 100644
--- a/src/osmo_gsm_tester/obj/enb_srs.py
+++ b/src/osmo_gsm_tester/obj/enb_srs.py
@@ -86,7 +86,7 @@
if self._run_node.is_local():
return
-# Make sure we give the UE time to tear down
+# Make sure we give time to tear down
self.sleep_after_stop()
# copy back files (may not exist, for instance if there was an early
error of process):
@@ -258,6 +258,11 @@
def running(self):
return not self.process.terminated()
+def get_counter(self, counter_name):
+if counter_name == 'prach_received':
+return self._get_counter_stdout('RACH:')
+raise log.Error('counter %s not implemented!' % counter_name)
+
def get_rfemu(self, cell=0, dl=True):
cell_list = self.gen_conf['enb'].get('cell_list', None)
if cell_list is None or len(cell_list) < cell + 1:
diff --git a/src/osmo_gsm_tester/obj/ms_srs.py
b/src/osmo_gsm_tester/obj/ms_srs.py
index 610d3e6..a89ba1b 100644
--- a/src/osmo_gsm_tester/obj/ms_srs.py
+++ b/src/osmo_gsm_tester/obj/ms_srs.py
@@ -382,15 +382,6 @@
proc.launch_sync()
return proc
-def _get_counter_stdout(self, keyword):
-# Match stdout against keyword
-n = 0
-stdout_lines = (self.process.get_stdout() or '').splitlines()
-for l in stdout_lines:
-if keyword in l:
-n += 1
-return n
-
def get_counter(self, counter_name):
if counter_name == 'handover_success':
return self._get_counter_stdout('HO successful')
diff --git a/src/osmo_gsm_tester/obj/srslte_common.py
b/src/osmo_gsm_tester/obj/srslte_common.py
index e221940..3acad9e 100644
--- a/src/osmo_gsm_tester/obj/srslte_common.py
+++ b/src/osmo_gsm_tester/obj/srslte_common.py
@@ -97,4 +97,13 @@
return analyzer.get_num_phy_errors(kpi)
except ImportError:
self.log("Can't load KPI analyzer module.")
-return 0
\ No newline at end of file
+return 0
+
+def _get_counter_stdout(self, keyword):
+# Match stdout against keyword
+n = 0
+stdout_lines = (self.process.get_stdout() or '').splitlines()
+for l in stdout_lines:
+if keyword in l:
+n += 1
+return n
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I434f072b8aa6f4dce9f90889c6b40832f6798ff8
Gerrit-Change-Number:
Change in osmo-gsm-tester[master]: srsenb.conf.tmpl: set nof_of_prach_threds to 0 for ZMQ
srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22041 ) Change subject: srsenb.conf.tmpl: set nof_of_prach_threds to 0 for ZMQ .. srsenb.conf.tmpl: set nof_of_prach_threds to 0 for ZMQ this executed the PRACH search in the main thread so PHY workers and PRACH processing don't diverge in loaded scenarios Change-Id: I97eddb5f9ca682251ded1f73093c2d0a49462bd6 --- M src/osmo_gsm_tester/templates/srsenb.conf.tmpl 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/41/22041/1 diff --git a/src/osmo_gsm_tester/templates/srsenb.conf.tmpl b/src/osmo_gsm_tester/templates/srsenb.conf.tmpl index 5df432b..7ac75bb 100644 --- a/src/osmo_gsm_tester/templates/srsenb.conf.tmpl +++ b/src/osmo_gsm_tester/templates/srsenb.conf.tmpl @@ -271,6 +271,9 @@ # # [expert] +% if enb.rf_dev_type == 'zmq': +nof_prach_threads = 0 +% endif #pusch_max_its= 8 # These are half iterations #pusch_8bit_decoder = false #nof_phy_threads = 3 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I97eddb5f9ca682251ded1f73093c2d0a49462bd6 Gerrit-Change-Number: 22041 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: enb_srs: adopt throughput thresholds for QAM256
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22039 )
Change subject: enb_srs: adopt throughput thresholds for QAM256
..
enb_srs: adopt throughput thresholds for QAM256
it turned out that we have to reduce the MCS when using QAM256,
especially for 6 PRB as subframe 0 and 5 contains PBCH and PSS
signals, so the available REs are reduced.
The eNB scheduler now has this limitation in mind and lowers the MCS.
Change-Id: I0e38fe28002fd68c768cc8dcffcf74f4f190df02
---
M src/osmo_gsm_tester/obj/enb_srs.py
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/39/22039/1
diff --git a/src/osmo_gsm_tester/obj/enb_srs.py
b/src/osmo_gsm_tester/obj/enb_srs.py
index 1b17c3c..6afc873 100644
--- a/src/osmo_gsm_tester/obj/enb_srs.py
+++ b/src/osmo_gsm_tester/obj/enb_srs.py
@@ -276,14 +276,14 @@
def ue_max_rate(self, downlink=True, num_carriers=1):
# The max rate for a single UE per PRB configuration in TM1 with MCS 28
if 'dl_qam256' in self.ue.features():
-max_phy_rate_tm1_dl = {6: 5.9e6,
- 15: 14.6e6,
- 25: 24.5e6,
- 50: 48.9e6,
- 75: 75.3e6,
- 100: 97.8e6}
+max_phy_rate_tm1_dl = {6: 4.4e6,
+ 15: 14e6,
+ 25: 24e6,
+ 50: 49e6,
+ 75: 75e6,
+ 100: 98e6}
else:
-max_phy_rate_tm1_dl = {6: 3.5e6,
+max_phy_rate_tm1_dl = {6: 3.3e6,
15: 11e6,
25: 18e6,
50: 36e6,
@@ -296,7 +296,7 @@
25 : 14e6,
50 : 32e6,
75 : 34e6,
-100 : 70e6 }
+100 : 71e6 }
else:
max_phy_rate_tm1_ul = { 6 : 1.7e6,
15 : 4.7e6,
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22039
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I0e38fe28002fd68c768cc8dcffcf74f4f190df02
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: srsepc.conf.tmpl: increase default value of T3413 (paging timer)
srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22040 ) Change subject: srsepc.conf.tmpl: increase default value of T3413 (paging timer) .. srsepc.conf.tmpl: increase default value of T3413 (paging timer) we've seen that the default value of 2s might be a bit tight. the value is network dependent so no real default value exists. however, 6s seems to be a good compromise. Change-Id: Icc75ee048c2cc605ab26c4c87a039519998f7e57 --- M src/osmo_gsm_tester/templates/srsepc.conf.tmpl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/40/22040/1 diff --git a/src/osmo_gsm_tester/templates/srsepc.conf.tmpl b/src/osmo_gsm_tester/templates/srsepc.conf.tmpl index 830cd32..62f9977 100644 --- a/src/osmo_gsm_tester/templates/srsepc.conf.tmpl +++ b/src/osmo_gsm_tester/templates/srsepc.conf.tmpl @@ -31,7 +31,7 @@ dns_addr = 8.8.8.8 encryption_algo = EEA0 integrity_algo = EIA1 -paging_timer = 2 +paging_timer = 6 # # HSS configuration -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22040 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Icc75ee048c2cc605ab26c4c87a039519998f7e57 Gerrit-Change-Number: 22040 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: enb_srs: only use QAM64 tables if both UE and eNB are configured for ...
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22038 )
Change subject: enb_srs: only use QAM64 tables if both UE and eNB are
configured for QAM64
..
enb_srs: only use QAM64 tables if both UE and eNB are configured for QAM64
this was causing failed tests because to achieve QAM64 rates both
eNB and UE need to support it and have it activated.
Change-Id: I599df92d69eeb56a5d44327de08f004222cff073
---
M src/osmo_gsm_tester/obj/enb_srs.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/38/22038/1
diff --git a/src/osmo_gsm_tester/obj/enb_srs.py
b/src/osmo_gsm_tester/obj/enb_srs.py
index 7fde719..1b17c3c 100644
--- a/src/osmo_gsm_tester/obj/enb_srs.py
+++ b/src/osmo_gsm_tester/obj/enb_srs.py
@@ -72,6 +72,7 @@
self.remote_log_file = None
self.remote_pcap_file = None
self.enable_pcap = False
+self.enable_ul_qam64 = False
self.metrics_file = None
self.stop_sleep_time = 6 # We require at most 5s to stop
self.testenv = testenv
@@ -192,7 +193,9 @@
self.enable_pcap = util.str2bool(values['enb'].get('enable_pcap',
'false'))
config.overlay(values, dict(enb={'enable_pcap': self.enable_pcap}))
-config.overlay(values, dict(enb={'enable_ul_qam64':
util.str2bool(values['enb'].get('enable_ul_qam64', 'false'))}))
+self.enable_ul_qam64 =
util.str2bool(values['enb'].get('enable_ul_qam64', 'false'))
+config.overlay(values, dict(enb={'enable_ul_qam64':
self.enable_ul_qam64}))
+
config.overlay(values, dict(enb={'enable_dl_awgn':
util.str2bool(values['enb'].get('enable_dl_awgn', 'false'))}))
config.overlay(values, dict(enb={'rf_dev_sync':
values['enb'].get('rf_dev_sync', None)}))
@@ -287,7 +290,7 @@
75: 55e6,
100: 75e6}
-if 'ul_qam64' in self.ue.features():
+if self.enable_ul_qam64 and 'ul_qam64' in self.ue.features():
max_phy_rate_tm1_ul = { 6 : 2.7e6,
15 : 6.5e6,
25 : 14e6,
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22038
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I599df92d69eeb56a5d44327de08f004222cff073
Gerrit-Change-Number: 22038
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: iperf3: return 0 if iperf results can't be read back
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037 )
Change subject: iperf3: return 0 if iperf results can't be read back
..
iperf3: return 0 if iperf results can't be read back
usually the calling code, i.e. the test, will use the result
of the iperf run to check against a threshold. for that to
work the return value can't be None.
Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485
---
M src/osmo_gsm_tester/obj/iperf3.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/37/22037/1
diff --git a/src/osmo_gsm_tester/obj/iperf3.py
b/src/osmo_gsm_tester/obj/iperf3.py
index 4785f78..6571491 100644
--- a/src/osmo_gsm_tester/obj/iperf3.py
+++ b/src/osmo_gsm_tester/obj/iperf3.py
@@ -76,7 +76,7 @@
return recv['bits_per_second']/1e6
except Exception as e:
print("Exception while using iperf3 results: %r" % (repr(result)))
-pass
+return 0
class IPerf3Server(log.Origin):
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485
Gerrit-Change-Number: 22037
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: srsue.conf.tmpl: disable TTI stats for ZMQ
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22036 )
Change subject: srsue.conf.tmpl: disable TTI stats for ZMQ
..
srsue.conf.tmpl: disable TTI stats for ZMQ
since ZMQ runs are not using wall clock anyway, measuring
TTI execution isn't useful, disable it therefore to avoid
misleading warnings.
Change-Id: I5c2cb0abcfce0ee67806f6611356f4d5d180541d
---
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/36/22036/1
diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
index a57857b..a50f91e 100644
--- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
@@ -381,3 +381,8 @@
metrics_csv_enable = true
#metrics_period_secs = 1
metrics_csv_filename = ${ue.metrics_filename}
+
+% if ue.rf_dev_type == 'zmq':
+[stack]
+have_tti_time_stats = false
+% endif
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22036
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5c2cb0abcfce0ee67806f6611356f4d5d180541d
Gerrit-Change-Number: 22036
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: intraenb-intrafreq-ho.conf: add eNB to cell config
srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22035 ) Change subject: intraenb-intrafreq-ho.conf: add eNB to cell config .. intraenb-intrafreq-ho.conf: add eNB to cell config make sure to have the right eNB that matches the cells neighbor ECIDs, otherwise the eNB may trigger a S1 HO if the eNB ID is set elsewhere Change-Id: Id494ac1984846e78a6456bb6a17e72d63c9dacf5 --- M sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/35/22035/1 diff --git a/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf b/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf index 8b6f569..f4223a5 100644 --- a/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf +++ b/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf @@ -1,7 +1,9 @@ # Cell config for Intra eNB HO, two cells on same frequencey (same EARFCN) on different RF ports (srsENB) modifiers: enb: - - cell_list: + - id: 0x19B +enable_measurements: true +cell_list: - cell_id: 0x01 pci: 0x01 tac: 0x0007 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Id494ac1984846e78a6456bb6a17e72d63c9dacf5 Gerrit-Change-Number: 22035 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: srsue.conf.tmpl: reorder conditions for setting RRC release
srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034 ) Change subject: srsue.conf.tmpl: reorder conditions for setting RRC release .. srsue.conf.tmpl: reorder conditions for setting RRC release the order of checks needs to go from high to low, i.e. the higher release feature (e.g. qam256) needs to be checked and set first. in theory it should also be possible to have a CA-capable UE that does not support QAM256, but for srsUE we announce both anyway. Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7 --- M src/osmo_gsm_tester/templates/srsue.conf.tmpl 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/34/22034/1 diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl b/src/osmo_gsm_tester/templates/srsue.conf.tmpl index 120b938..a57857b 100644 --- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl +++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl @@ -147,14 +147,14 @@ # mbms_service_port: Port of the MBMS service # [rrc] -% if int(ue.num_carriers) > 1: -ue_category = 7 -release = 10 -% elif "dl_qam256" in ue.features or "ul_qam64" in ue.features: +% if "dl_qam256" in ue.features or "ul_qam64" in ue.features: ue_category = 8 release = 13 ue_category_dl= 14 ue_category_ul= 5 +% elif int(ue.num_carriers) > 1: +ue_category = 7 +release = 10 % else: #ue_category = 4 #release = 8 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7 Gerrit-Change-Number: 22034 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: srsenb_drb.conf.tmpl: add QCI1 DRB config
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22032 )
Change subject: srsenb_drb.conf.tmpl: add QCI1 DRB config
..
srsenb_drb.conf.tmpl: add QCI1 DRB config
use default QCI1 config for real-time voice traffic
Change-Id: I43f408b1a3c172a5eb8327f03df49801e063e5cd
---
M src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl
1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/32/22032/1
diff --git a/src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl
b/src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl
index 5167dab..b10ef31 100644
--- a/src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl
@@ -1,7 +1,29 @@
// All times are in ms. Use -1 for infinity, where available
qci_config = (
-
+// UM - real time (RTP for VOIP)
+{
+ qci=1;
+ pdcp_config = {
+discard_timer = 100;
+pdcp_sn_size = 12;
+ }
+ rlc_config = {
+ul_um = {
+ sn_field_length = 5;
+};
+dl_um = {
+ sn_field_length = 5;
+ t_reordering= 45;
+};
+ };
+ logical_channel_config = {
+priority = 4;
+prioritized_bit_rate = 256;
+bucket_size_duration = 1000;
+log_chan_group = 1;
+ };
+},
{
qci=7;
pdcp_config = {
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22032
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I43f408b1a3c172a5eb8327f03df49801e063e5cd
Gerrit-Change-Number: 22032
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: enb: include name label and run_addr in enb remote path
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22033 )
Change subject: enb: include name label and run_addr in enb remote path
..
enb: include name label and run_addr in enb remote path
this allows to quickly identify the enb host in the logs
Change-Id: I9c979de852a23041e43692e97ebcbfb389b52fdb
---
M src/osmo_gsm_tester/obj/enb.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/33/22033/1
diff --git a/src/osmo_gsm_tester/obj/enb.py b/src/osmo_gsm_tester/obj/enb.py
index cdf9505..3944459 100644
--- a/src/osmo_gsm_tester/obj/enb.py
+++ b/src/osmo_gsm_tester/obj/enb.py
@@ -89,7 +89,10 @@
if self._gtp_bind_addr is None:
self._gtp_bind_addr = self._run_node.run_addr()
label = conf.get('label', None)
-self.set_name('%s_%s' % (name, label if label is not None else
self._run_node.run_addr()))
+if label is not None:
+self.set_name('%s_%s_%s' % (name, label,
self._run_node.run_addr()))
+else:
+self.set_name('%s_%s' % (name, self._run_node.run_addr()))
self._txmode = 0
self._id = None
self._duplex = None
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22033
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I9c979de852a23041e43692e97ebcbfb389b52fdb
Gerrit-Change-Number: 22033
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: jenkins-build-srslte.sh: allow custom binaries
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22031 )
Change subject: jenkins-build-srslte.sh: allow custom binaries
..
jenkins-build-srslte.sh: allow custom binaries
this allows to specify the environmental var
wanted_binaries_bin that will be included in the
trial package. if the variable isn't set, all three
main srsLTE binaries are included
Change-Id: I63f5799328435ce32b5bfd6dae6fd0b37e1e5397
---
M contrib/jenkins-build-srslte.sh
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/31/22031/1
diff --git a/contrib/jenkins-build-srslte.sh b/contrib/jenkins-build-srslte.sh
index 80e4ffc..365c3e4 100755
--- a/contrib/jenkins-build-srslte.sh
+++ b/contrib/jenkins-build-srslte.sh
@@ -1,6 +1,10 @@
#!/bin/sh
set -e -x
+if [ -z "$trial_binaries" ]; then
+ trial_binaries="srsue srsenb srsepc"
+fi
+
base="$PWD"
name="srslte"
git_url="${git_url:-https://github.com/srsLTE};
@@ -10,4 +14,4 @@
#TODO: make sure libconfig, zeroMQ is installed
build_repo $project_name $configure_opts
-create_bin_tgz "srsue srsenb srsepc"
+create_bin_tgz "$trial_binaries"
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22031
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I63f5799328435ce32b5bfd6dae6fd0b37e1e5397
Gerrit-Change-Number: 22031
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 184s] [COMPILING apps/dfu/main.c] [ 185s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 185s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 185s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 185s] Memory region Used Size Region Size %age Used [ 185s] rom: 16580 B16 KB101.20% [ 185s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 185s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 185s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 185s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 185s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 185s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 185s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 196 bytes [ 185s] collect2: error: ld returned 1 exit status [ 185s] % [ 185s] make[2]: *** [Makefile:234: flash] Error 1 [ 185s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 185s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 185s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 185s] dh_auto_build: error: make -j1 returned exit code 2 [ 185s] make: *** [debian/rules:16: build] Error 25 [ 185s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 185s] ### VM INTERACTION START ### [ 188s] [ 175.687654] sysrq: Power Off [ 188s] [ 175.698840] reboot: Power down [ 188s] ### VM INTERACTION END ### [ 188s] [ 188s] lamb24 failed "build simtrace2_0.7.0.69.aadd.dsc" at Thu Jan 7 15:43:25 UTC 2021. [ 188s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 118s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 119s] [COMPILING libboard/qmod/source/card_pres.c] [ 119s] [COMPILING libboard/qmod/source/wwan_led.c] [ 119s] [COMPILING libboard/qmod/source/i2c.c] [ 119s] [COMPILING libboard/qmod/source/board_qmod.c] [ 119s] [COMPILING apps/dfu/main.c] [ 119s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 119s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 119s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 120s] Memory region Used Size Region Size %age Used [ 120s] rom: 16588 B16 KB101.25% [ 120s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 120s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 120s] collect2: error: ld returned 1 exit status [ 120s] % [ 120s] make[2]: *** [Makefile:234: flash] Error 1 [ 120s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 120s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 120s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 120s] dh_auto_build: error: make -j1 returned exit code 2 [ 120s] make: *** [debian/rules:16: build] Error 25 [ 120s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 120s] ### VM INTERACTION START ### [ 123s] [ 114.582452] sysrq: Power Off [ 123s] [ 114.589445] reboot: Power down [ 123s] ### VM INTERACTION END ### [ 123s] [ 123s] goat01 failed "build simtrace2_0.7.0.69.aadd.dsc" at Thu Jan 7 15:33:53 UTC 2021. [ 123s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: WIP: Intoduce Packet Switch CGI
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21849 ) Change subject: WIP: Intoduce Packet Switch CGI .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I87016d1c23f893cbb7dad2e6ff74566ad8a06b5c Gerrit-Change-Number: 21849 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in meta-telephony[laforge/nightly]: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
laforge has submitted this change. (
https://gerrit.osmocom.org/c/meta-telephony/+/22030 )
Change subject: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf
check
..
osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
oe-core is currently (pyro and current master) forcing non-availability
of netinet/sctp.h header file through autoconf's export CONFIG_SITE
pointing to files in meta/site/, which contain:
ac_cv_header_netinet_sctp_h=${ac_cv_header_netinet_sctp_h=no}
As a result, netinet/sctp.h is not found despite DEPENDS="lksctp-tools"
and the file being available correctly under recipe-sysroot/ and finally
configure fails with AC_MSG_ERROR().
It was confirmed by OE devs that those lines should not be there, and a
patch has been submitted:
https://patchwork.openembedded.org/patch/168892/
Since it's not available in pyro nor latest release, let's workaround it
in our recipe to make sure it works with older versions of OE.
Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05
---
M recipes-osmocom/osmo-iuh/osmo-iuh.inc
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
index ab412ad..92b4633 100644
--- a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
+++ b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
@@ -3,9 +3,13 @@
LICENSE = "AGPLv3"
LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"
-DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c"
+DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c lksctp-tools"
-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"
+
+# Workaround to oe-core meta/site/* CONFIG_SITE files passed to autoconf
forcing unavailability of netinet/sctp.h.
+# Patch fixing issue upstream: https://patchwork.openembedded.org/patch/168892/
+CACHED_CONFIGUREVARS += "ac_cv_header_netinet_sctp_h=yes"
inherit autotools pkgconfig systemd
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22030
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05
Gerrit-Change-Number: 22030
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in meta-telephony[laforge/nightly]: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/22030 ) Change subject: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05 Gerrit-Change-Number: 22030 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 07 Jan 2021 14:32:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in meta-telephony[laforge/nightly]: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/meta-telephony/+/22030 )
Change subject: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf
check
..
osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
oe-core is currently (pyro and current master) forcing non-availability
of netinet/sctp.h header file through autoconf's export CONFIG_SITE
pointing to files in meta/site/, which contain:
ac_cv_header_netinet_sctp_h=${ac_cv_header_netinet_sctp_h=no}
As a result, netinet/sctp.h is not found despite DEPENDS="lksctp-tools"
and the file being available correctly under recipe-sysroot/ and finally
configure fails with AC_MSG_ERROR().
It was confirmed by OE devs that those lines should not be there, and a
patch has been submitted:
https://patchwork.openembedded.org/patch/168892/
Since it's not available in pyro nor latest release, let's workaround it
in our recipe to make sure it works with older versions of OE.
Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05
---
M recipes-osmocom/osmo-iuh/osmo-iuh.inc
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/30/22030/1
diff --git a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
index ab412ad..92b4633 100644
--- a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
+++ b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
@@ -3,9 +3,13 @@
LICENSE = "AGPLv3"
LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"
-DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c"
+DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c lksctp-tools"
-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"
+
+# Workaround to oe-core meta/site/* CONFIG_SITE files passed to autoconf
forcing unavailability of netinet/sctp.h.
+# Patch fixing issue upstream: https://patchwork.openembedded.org/patch/168892/
+CACHED_CONFIGUREVARS += "ac_cv_header_netinet_sctp_h=yes"
inherit autotools pkgconfig systemd
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22030
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05
Gerrit-Change-Number: 22030
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in libosmocore[master]: pkgconfig: link to mnl if available
Hoernchen has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/22026 )
Change subject: pkgconfig: link to mnl if available
..
pkgconfig: link to mnl if available
The dependency on mnl breaks builds of osmo-pcu et al if mnl is used for
libosmogb, but not linked in for lib users
Change-Id: Ib4df95d5c922f8edfa33e68645652fd30d321ff8
---
M libosmogb.pc.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Hoernchen: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/libosmogb.pc.in b/libosmogb.pc.in
index a163cc4..4eebe42 100644
--- a/libosmogb.pc.in
+++ b/libosmogb.pc.in
@@ -6,6 +6,6 @@
Name: Osmocom GPRS Gb Library
Description: Osmocom GPRS Gb Interface (NS/BSSGP) Library
Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore
+Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore @LIBMNL_LIBS@
Cflags: -I${includedir}/ -fno-strict-aliasing
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22026
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib4df95d5c922f8edfa33e68645652fd30d321ff8
Gerrit-Change-Number: 22026
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: pkgconfig: link to mnl if available
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22026 ) Change subject: pkgconfig: link to mnl if available .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib4df95d5c922f8edfa33e68645652fd30d321ff8 Gerrit-Change-Number: 22026 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 14:28:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21862 )
Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers
..
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h
File include/osmocom/gprs/gprs_bssgp_rim.h:
https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@7
PS6, Line 7:struct {
You could reuse "struct osmo_cell_global_id_ps" from
https://gerrit.osmocom.org/c/libosmocore/+/22013 here.
In any case, you ruse this struct in at least 2 places, so better move its
definition outside and reuse it.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352
Gerrit-Change-Number: 21862
Gerrit-PatchSet: 6
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 07 Jan 2021 14:19:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in libosmocore[master]: pkgconfig: link to mnl if available
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22026 ) Change subject: pkgconfig: link to mnl if available .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib4df95d5c922f8edfa33e68645652fd30d321ff8 Gerrit-Change-Number: 22026 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 14:20:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Intoduce Packet Switch CGI
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22013 ) Change subject: Intoduce Packet Switch CGI .. Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22013 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374 Gerrit-Change-Number: 22013 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 14:18:05 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: CTRL: Introduce support to run osmocom CTRL server
Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 to look at the new patch set (#2). Change subject: CTRL: Introduce support to run osmocom CTRL server .. CTRL: Introduce support to run osmocom CTRL server Change-Id: I37db9962f51baf2c63bd58ec47ec89f773d7a255 --- M bsc-nat/BSCNAT_Tests.ttcn M bsc/BSC_Tests.ttcn M bts/BTS_Tests.ttcn M hlr/HLR_Tests.ttcn M library/Osmocom_CTRL_Adapter.ttcn M library/Osmocom_CTRL_Functions.ttcn M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn M sip/SIP_Tests.ttcn 9 files changed, 60 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/22012/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37db9962f51baf2c63bd58ec47ec89f773d7a255 Gerrit-Change-Number: 22012 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: CTRL: Fix tr_CtrlMsgGet containing invalid value in val field
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22011 ) Change subject: CTRL: Fix tr_CtrlMsgGet containing invalid value in val field .. CTRL: Fix tr_CtrlMsgGet containing invalid value in val field "val" field is not used in GET commands and is hence set to omit by TTCN3 decoder. Change-Id: If1a273a2be71040eaea2189a0aeaf737adf848e5 --- M library/Osmocom_CTRL_Types.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/library/Osmocom_CTRL_Types.ttcn b/library/Osmocom_CTRL_Types.ttcn index 52be956..36e6762 100644 --- a/library/Osmocom_CTRL_Types.ttcn +++ b/library/Osmocom_CTRL_Types.ttcn @@ -124,7 +124,7 @@ verb := "GET", id := id, variable := variable, - val := ? + val := omit } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If1a273a2be71040eaea2189a0aeaf737adf848e5 Gerrit-Change-Number: 22011 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in libosmocore[master]: bssgp_bvc_fsm: Handle block request from application correctly
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22029 ) Change subject: bssgp_bvc_fsm: Handle block request from application correctly .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e384b71d57e939efc1596ac1d92380ed5eb916d Gerrit-Change-Number: 22029 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 14:02:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: pkgconfig: link to mnl if available
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22026 ) Change subject: pkgconfig: link to mnl if available .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib4df95d5c922f8edfa33e68645652fd30d321ff8 Gerrit-Change-Number: 22026 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 14:00:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: logging: Remove duplicate color for DLSMS
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22027 ) Change subject: logging: Remove duplicate color for DLSMS .. Patch Set 1: Code-Review+1 Would maybe make sense remove the non-defined string. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia797efce36e0afff74de54374d568521ecedf486 Gerrit-Change-Number: 22027 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 14:01:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: ns2_frgre: Fix missing break statement for recv from IPV6
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22028 ) Change subject: ns2_frgre: Fix missing break statement for recv from IPV6 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I549277483fee55f390e0b5ae1dafec6f2d68eae7 Gerrit-Change-Number: 22028 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 13:59:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bssgp_bvc_fsm: Handle block request from application correctly
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/22029 )
Change subject: bssgp_bvc_fsm: Handle block request from application correctly
..
bssgp_bvc_fsm: Handle block request from application correctly
This is no event from an incoming message so rx is NULL, and we can't send a
status PDU. Also blocking the signalling BVC is not allowed (unblocking it is
already
forbidden).
Change-Id: I3e384b71d57e939efc1596ac1d92380ed5eb916d
Fixes: CID#215716
---
M src/gb/bssgp_bvc_fsm.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/29/22029/1
diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c
index cc634a5..6de0028 100644
--- a/src/gb/bssgp_bvc_fsm.c
+++ b/src/gb/bssgp_bvc_fsm.c
@@ -456,7 +456,10 @@
case BSSGP_BVCFSM_E_REQ_BLOCK:
if (bfp->role_sgsn) {
LOGPFSML(fi, LOGL_ERROR, "SGSN may not initiate
BVC-BLOCK\n");
- _tx_status(fi, BSSGP_CAUSE_SEM_INCORR_PDU, rx);
+ break;
+ }
+ if (bfp->bvci == 0) {
+ LOGPFSML(fi, LOGL_ERROR, "BVCI 0 cannot be blocked\n");
break;
}
bfp->locally_blocked = true;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22029
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3e384b71d57e939efc1596ac1d92380ed5eb916d
Gerrit-Change-Number: 22029
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in libosmocore[master]: logging: Remove duplicate color for DLSMS
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/22027 )
Change subject: logging: Remove duplicate color for DLSMS
..
logging: Remove duplicate color for DLSMS
Change-Id: Ia797efce36e0afff74de54374d568521ecedf486
---
M src/logging.c
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/27/22027/1
diff --git a/src/logging.c b/src/logging.c
index 01a00da..60dba64 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -177,7 +177,6 @@
.name = "DLSMS",
.description = "Layer3 Short Message Service (SMS)",
.enabled = 1, .loglevel = LOGL_NOTICE,
- .color = OSMO_LOGCOLOR_BRIGHTWHITE,
.color = "\033[38;5;31m",
},
[INT2IDX(DLCTRL)] = {
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22027
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia797efce36e0afff74de54374d568521ecedf486
Gerrit-Change-Number: 22027
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in libosmocore[master]: ns2_frgre: Fix missing break statement for recv from IPV6
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22028 ) Change subject: ns2_frgre: Fix missing break statement for recv from IPV6 .. ns2_frgre: Fix missing break statement for recv from IPV6 Change-Id: I549277483fee55f390e0b5ae1dafec6f2d68eae7 Fixes: CID#215836 --- M src/gb/gprs_ns2_frgre.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/28/22028/1 diff --git a/src/gb/gprs_ns2_frgre.c b/src/gb/gprs_ns2_frgre.c index 625d05c..86f0921 100644 --- a/src/gb/gprs_ns2_frgre.c +++ b/src/gb/gprs_ns2_frgre.c @@ -314,6 +314,7 @@ break; case AF_INET6: ip46hdr = sizeof(struct ip6_hdr); + break; default: *error = -EIO; goto out_err; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I549277483fee55f390e0b5ae1dafec6f2d68eae7 Gerrit-Change-Number: 22028 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange
Change in libosmocore[master]: pkgconfig: link to mnl if available
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/22026 )
Change subject: pkgconfig: link to mnl if available
..
pkgconfig: link to mnl if available
The dependency on mnl breaks builds of osmo-pcu et al if mnl is used for
libosmogb, but not linked in for lib users
Change-Id: Ib4df95d5c922f8edfa33e68645652fd30d321ff8
---
M libosmogb.pc.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/26/22026/1
diff --git a/libosmogb.pc.in b/libosmogb.pc.in
index a163cc4..4eebe42 100644
--- a/libosmogb.pc.in
+++ b/libosmogb.pc.in
@@ -6,6 +6,6 @@
Name: Osmocom GPRS Gb Library
Description: Osmocom GPRS Gb Interface (NS/BSSGP) Library
Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore
+Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore @LIBMNL_LIBS@
Cflags: -I${includedir}/ -fno-strict-aliasing
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22026
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib4df95d5c922f8edfa33e68645652fd30d321ff8
Gerrit-Change-Number: 22026
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen
Gerrit-MessageType: newchange
Change in meta-telephony[201705]: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/22024 ) Change subject: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05 Gerrit-Change-Number: 22024 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:49:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bts_features: s/Repeation/Repetition/ in osmo_bts_features_descs[]
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/22021 )
Change subject: bts_features: s/Repeation/Repetition/ in
osmo_bts_features_descs[]
..
bts_features: s/Repeation/Repetition/ in osmo_bts_features_descs[]
Change-Id: Ia8c77766842ce80eae969774959cbf46e86f97b9
---
M src/gsm/bts_features.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c
index 93703aa..d8c27d8 100644
--- a/src/gsm/bts_features.c
+++ b/src/gsm/bts_features.c
@@ -41,7 +41,7 @@
{ BTS_FEAT_ETWS_PN, "ETWS Primary Notification via PCH" },
{ BTS_FEAT_PAGING_COORDINATION, "BSS Paging Coordination" },
{ BTS_FEAT_IPV6_NSVC, "NSVC IPv6" },
- { BTS_FEAT_ACCH_REP,"FACCH/SACCH Repeation" },
+ { BTS_FEAT_ACCH_REP,"FACCH/SACCH Repetition" },
{ 0, NULL }
};
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22021
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia8c77766842ce80eae969774959cbf46e86f97b9
Gerrit-Change-Number: 22021
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in meta-telephony[201705]: update all of osmocom to "latest" tags
laforge has submitted this change. (
https://gerrit.osmocom.org/c/meta-telephony/+/22025 )
Change subject: update all of osmocom to "latest" tags
..
update all of osmocom to "latest" tags
We have to use some arcane construct to make the bitbake fetcher
actualyl fetch tags that are not on any branch (like those patch
releases that themselves branch off master, but which aren't on
master). Otherwise we get errors like:
WARNING: osmo-sgsn-1.6.2+gitrAUTOINC+065500a347-r1.18.0 do_fetch: Failed to
fetch URL git://git.osmocom.org/osmo-sgsn.git;protocol=git, attempting MIRRORS
if available
ERROR: osmo-sgsn-1.6.2+gitrAUTOINC+065500a347-r1.18.0 do_fetch: Fetcher
failure: Unable to find revision 065500a3471dd43b65dc87b95854c3015c551f0f in
branch master even from upstream
Change-Id: I743173f8a3385686ffb11550aabc0fbc665cf043
---
M recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
M recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
M recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
M recipes-osmocom/libosmocore/libosmocore_git.bb
M recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
M recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
M recipes-osmocom/osmo-iuh/osmo-iuh_git.bb
M recipes-osmocom/osmo-msc/osmo-msc_git.bb
M recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb
M recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb
M recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb
12 files changed, 30 insertions(+), 30 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
index 0582599..446a590 100644
--- a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
+++ b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "c313d44272f04b24dad38f4caea17180f9cbc509"
-SRC_URI = "git://git.osmocom.org/libosmo-abis.git;protocol=git"
-PV = "0.8.0+gitr${SRCPV}"
+SRCREV = "1.0.1"
+SRC_URI =
"git://git.osmocom.org/libosmo-abis.git;protocol=git;tag=${SRCREV};nobranch=1"
+PV = "1.0.1+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
index c52c7e9..0f2856e 100644
--- a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
+++ b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "b8121e79ef53b30df535fb38987b3a48853ebbe9"
+SRCREV = "f3ccbecb6f802ccd98d154dc7ba7d552e298b2ea"
SRC_URI = "git://git.osmocom.org/libosmo-netif.git;protocol=git"
-PV = "0.7.0+gitr${SRCPV}"
+PV = "1.0.0+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
index 31fa234..c78477c 100644
--- a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
+++ b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "5e4643f4bc76a1437621348550b5b2a603e2179b"
+SRCREV = "37880b696ee90dead7e3b1292b109cc041a44e52"
SRC_URI = "git://git.osmocom.org/libosmo-sccp.git;protocol=git"
-PV = "1.2.0+gitr${SRCPV}"
+PV = "1.3.0+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmocore/libosmocore_git.bb
b/recipes-osmocom/libosmocore/libosmocore_git.bb
index d5eab3a..1acf6ac 100644
--- a/recipes-osmocom/libosmocore/libosmocore_git.bb
+++ b/recipes-osmocom/libosmocore/libosmocore_git.bb
@@ -1,9 +1,9 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "2862f9082ed4f16383a134e1112610d76ad91bf0"
+SRCREV = "5681a3254c1727d4926ac6d36800fd63d87ad7a2"
SRC_URI = "git://git.osmocom.org/libosmocore.git;protocol=git;nobranch=1"
-PV = "1.3.0+gitr${SRCPV}"
+PV = "1.4.1+gitr${SRCPV}"
PR = "${INC_PR}.0"
PACKAGES =+ "libosmoctrl libosmocodec libosmogb libosmogsm libosmovty
osmo-arfcn osmo-auc-gen osmo-config-merge"
diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
index fdb389b..dce2ef1 100644
--- a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
+++ b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "a1362ce8c20b2fa60e3da67936ea69d406e23aff"
-SRC_URI = "git://git.osmocom.org/osmo-bsc.git;protocol=git"
-PV = "1.6.0+gitr${SRCPV}"
+SRCREV = "1.6.1"
+SRC_URI =
"git://git.osmocom.org/osmo-bsc.git;protocol=git;tag=${SRCREV};nobranch=1"
+PV = "1.6.1+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
index b1b2298..a854384 100644
--- a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
+++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
@@ -1,9 +1,9 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "e71e0f2af84d8b26f4c09a8c859f86cf701b3357"
+SRCREV = "2154607fb06c9e4d1a286f40c756cdb4f792efdf"
SRC_URI =
Change in meta-telephony[201705]: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
laforge has submitted this change. (
https://gerrit.osmocom.org/c/meta-telephony/+/22024 )
Change subject: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf
check
..
osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
oe-core is currently (pyro and current master) forcing non-availability
of netinet/sctp.h header file through autoconf's export CONFIG_SITE
pointing to files in meta/site/, which contain:
ac_cv_header_netinet_sctp_h=${ac_cv_header_netinet_sctp_h=no}
As a result, netinet/sctp.h is not found despite DEPENDS="lksctp-tools"
and the file being available correctly under recipe-sysroot/ and finally
configure fails with AC_MSG_ERROR().
It was confirmed by OE devs that those lines should not be there, and a
patch has been submitted:
https://patchwork.openembedded.org/patch/168892/
Since it's not available in pyro nor latest release, let's workaround it
in our recipe to make sure it works with older versions of OE.
Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05
---
M recipes-osmocom/osmo-iuh/osmo-iuh.inc
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
index ab412ad..92b4633 100644
--- a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
+++ b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
@@ -3,9 +3,13 @@
LICENSE = "AGPLv3"
LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"
-DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c"
+DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c lksctp-tools"
-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"
+
+# Workaround to oe-core meta/site/* CONFIG_SITE files passed to autoconf
forcing unavailability of netinet/sctp.h.
+# Patch fixing issue upstream: https://patchwork.openembedded.org/patch/168892/
+CACHED_CONFIGUREVARS += "ac_cv_header_netinet_sctp_h=yes"
inherit autotools pkgconfig systemd
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22024
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05
Gerrit-Change-Number: 22024
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in meta-telephony[201705]: libosmo-netif: Add explicit dependency lksctp-tools
laforge has submitted this change. (
https://gerrit.osmocom.org/c/meta-telephony/+/22022 )
Change subject: libosmo-netif: Add explicit dependency lksctp-tools
..
libosmo-netif: Add explicit dependency lksctp-tools
Since libosmo-netif.git d1b1ff77a6bc2f70366c5d2f5079c70f5eae52a0, use of
libsctp is enabled by default and explicitly required.
Change-Id: Ib53557f21cad86300738f43b247df1e17166c46f
---
M recipes-osmocom/libosmo-netif/libosmo-netif.inc
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif.inc
b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
index a353be6..0a51dfc 100644
--- a/recipes-osmocom/libosmo-netif/libosmo-netif.inc
+++ b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
@@ -1,10 +1,15 @@
DESCRIPTION = "Osmocom network interface library"
-DEPENDS = "libosmo-abis libtalloc lksctp-tools"
HOMEPAGE = "http://git.osmocom.org;
LICENSE = "GPLv2+"
-
-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
-
LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+
+DEPENDS = "libosmo-abis libtalloc"
+
+PACKAGECONFIG ??= "\
+libsctp \
+"
+PACKAGECONFIG[libsctp] = "--enable-libsctp,--disable-libsctp,lksctp-tools,"
+
inherit autotools pkgconfig
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22022
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: Ib53557f21cad86300738f43b247df1e17166c46f
Gerrit-Change-Number: 22022
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in meta-telephony[201705]: libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check
laforge has submitted this change. (
https://gerrit.osmocom.org/c/meta-telephony/+/22023 )
Change subject: libosmo-netif: workaround oe-core forcing fail of sctp.h
autoconf check
..
libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check
oe-core is currently (pyro and current master) forcing non-availability
of netinet/sctp.h header file through autoconf's export CONFIG_SITE
pointing to files in meta/site/, which contain:
ac_cv_header_netinet_sctp_h=${ac_cv_header_netinet_sctp_h=no}
As a result, netinet/sctp.h is not found despite DEPENDS="lksctp-tools"
and the file being available correctly under recipe-sysroot/ and finally
configure fails with AC_MSG_ERROR().
It was confirmed by OE devs that those lines should not be there, and a
patch has been submitted:
https://patchwork.openembedded.org/patch/168892/
Since it's not available in pyro nor latest release, let's workaround it
in our recipe to make sure it works with older versions of OE.
Change-Id: Ide91e96648881a0c6d415d727a14c2ef913fb180
---
M recipes-osmocom/libosmo-netif/libosmo-netif.inc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif.inc
b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
index 0a51dfc..7098c42 100644
--- a/recipes-osmocom/libosmo-netif/libosmo-netif.inc
+++ b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
@@ -12,4 +12,8 @@
"
PACKAGECONFIG[libsctp] = "--enable-libsctp,--disable-libsctp,lksctp-tools,"
+# Workaround to oe-core meta/site/* CONFIG_SITE files passed to autoconf
forcing unavailability of netinet/sctp.h.
+# Patch fixing issue upstream: https://patchwork.openembedded.org/patch/168892/
+CACHED_CONFIGUREVARS += "${@bb.utils.contains('PACKAGECONFIG', 'libsctp',
'ac_cv_header_netinet_sctp_h=yes', '',d)}"
+
inherit autotools pkgconfig
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22023
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: Ide91e96648881a0c6d415d727a14c2ef913fb180
Gerrit-Change-Number: 22023
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in meta-telephony[201705]: update all of osmocom to "latest" tags
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/22025 ) Change subject: update all of osmocom to "latest" tags .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I743173f8a3385686ffb11550aabc0fbc665cf043 Gerrit-Change-Number: 22025 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:46:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in meta-telephony[201705]: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/22024 ) Change subject: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05 Gerrit-Change-Number: 22024 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:45:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in meta-telephony[201705]: libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/22023 ) Change subject: libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Ide91e96648881a0c6d415d727a14c2ef913fb180 Gerrit-Change-Number: 22023 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:45:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in meta-telephony[201705]: libosmo-netif: Add explicit dependency lksctp-tools
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/22022 ) Change subject: libosmo-netif: Add explicit dependency lksctp-tools .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Ib53557f21cad86300738f43b247df1e17166c46f Gerrit-Change-Number: 22022 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:45:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21949 ) Change subject: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 Gerrit-Change-Number: 21949 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 07 Jan 2021 13:42:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: bts_features: s/Repeation/Repetition/ in osmo_bts_features_descs[]
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22021 ) Change subject: bts_features: s/Repeation/Repetition/ in osmo_bts_features_descs[] .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8c77766842ce80eae969774959cbf46e86f97b9 Gerrit-Change-Number: 22021 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:42:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/open5gs in Debian_10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/i586 Package network:osmocom:nightly/open5gs failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 346s] [2541/2541] cc -o tests/handover/handover 'tests/handover/63da1a3@@handover@exe/abts-main.c.o' 'tests/handover/63da1a3@@handover@exe/epc-x2-test.c.o' 'tests/handover/63da1a3@@handover@exe/epc-s1-test.c.o' 'tests/handover/63da1a3@@handover@exe/5gc-xn-test.c.o' -Wl,--no-undefined -Wl,--as-needed -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -Wl,--start-group tests/app/libtestapp.a tests/common/libtestcomon.a lib/core/libogscore.so.2.1.1 lib/app/libogsapp.so.2.1.1 lib/dbi/libogsdbi.so.2.1.1 lib/crypt/libogscrypt.so.2.1.1 lib/sctp/libogssctp.so.2.1.1 lib/gtp/libogsgtp.so.2.1.1 lib/s1ap/libogss1ap.so.2.1.1 lib/asn1c/s1ap/libogsasn1c-s1ap.so.2.1.1 lib/asn1c/common/libogsasn1c-common.so.2.1.1 lib/asn1c/util/libogsasn1c-util.so.2.1.1 lib/ngap/libogsngap.so.2.1.1 lib/asn1c/ngap/libogsasn1c-ngap.so.2.1.1 lib/nas/eps/libogsnas-eps.so.2.1.1 lib/nas/common/libogsnas-common.so.2.1.1 lib/nas/5gs/libogsnas-5gs.so.2.1.1 lib/diameter/rx/libogsdiameter-rx.so.2.1.1 lib/diameter/common/libogsdiameter-common.so.2.1.1 subprojects/freeDiameter/libfdcore/libfdcore.so.1.3.2 subprojects/freeDiameter/libfdproto/libfdproto.so.1.3.2 /usr/lib/i386-linux-gnu/libyaml.so /usr/lib/gcc/i686-linux-gnu/8/../../../i386-linux-gnu/libmongoc-1.0.so /usr/lib/gcc/i686-linux-gnu/8/../../../i386-linux-gnu/libbson-1.0.so -lsctp -lidn -ldl -lsctp -lgcrypt -lgnutls -lsctp -lidn -ldl -lsctp -lgcrypt -lgnutls -lsctp -lidn -ldl -lsctp -lgcrypt -lgnutls -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/../app:$ORIGIN/../common:$ORIGIN/../../lib/core:$ORIGIN/../../lib/app:$ORIGIN/../../lib/dbi:$ORIGIN/../../lib/crypt:$ORIGIN/../../lib/sctp:$ORIGIN/../../lib/gtp:$ORIGIN/../../lib/s1ap:$ORIGIN/../../lib/asn1c/s1ap:$ORIGIN/../../lib/asn1c/common:$ORIGIN/../../lib/asn1c/util:$ORIGIN/../../lib/ngap:$ORIGIN/../../lib/asn1c/ngap:$ORIGIN/../../lib/nas/eps:$ORIGIN/../../lib/nas/common:$ORIGIN/../../lib/nas/5gs:$ORIGIN/../../lib/diameter/rx:$ORIGIN/../../lib/diameter/common:$ORIGIN/../../subprojects/freeDiameter/libfdcore:$ORIGIN/../../subprojects/freeDiameter/libfdproto' -Wl,-rpath-link,/usr/src/packages/BUILD/obj-i686-linux-gnu/tests/app:/usr/src/packages/BUILD/obj-i686-linux-gnu/tests/common:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/core:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/app:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/dbi:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/crypt:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/sctp:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/gtp:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/s1ap:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/asn1c/s1ap:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/asn1c/common:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/asn1c/util:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/ngap:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/asn1c/ngap:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/nas/eps:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/nas/common:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/nas/5gs:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/diameter/rx:/usr/src/packages/BUILD/obj-i686-linux-gnu/lib/diameter/common:/usr/src/packages/BUILD/obj-i686-linux-gnu/subprojects/freeDiameter/libfdcore:/usr/src/packages/BUILD/obj-i686-linux-gnu/subprojects/freeDiameter/libfdproto [ 346s]debian/rules override_dh_auto_test [ 346s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 346s] cd obj-i686-linux-gnu && meson test --suite unit [ 348s] ninja: Entering directory `/usr/src/packages/BUILD/obj-i686-linux-gnu' [ 348s] ninja: no work to do. [ 355s] 1/3 open5gs:unit / core OK 7.17 s [ 355s] 2/3 open5gs:unit / cryptOK 0.15 s [ 355s] 3/3 open5gs:unit / unit FAIL 0.07 s (exit status 1) [ 355s] [ 355s] Ok:2 [ 355s] Expected Fail: 0 [ 355s] Fail: 1 [ 355s] Unexpected Pass: 0 [ 355s] Skipped: 0 [ 355s] Timeout: 0 [ 355s] [ 355s] Full log written to /usr/src/packages/BUILD/obj-i686-linux-gnu/meson-logs/testlog.txt [ 355s] make[1]: *** [debian/rules:17: override_dh_auto_test] Error 1 [ 355s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 355s] make: *** [debian/rules:11: binary] Error 2 [ 355s] dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 [ 355s] ### VM INTERACTION START ### [ 358s] [ 341.883899] sysrq: Power Off [ 358s] [ 341.902447] reboot: Power down [ 358s] ### VM INTERACTION END ### [ 358s] [ 358s] cloud111 failed "build
Change in meta-telephony[201705]: libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/22023 ) Change subject: libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Ide91e96648881a0c6d415d727a14c2ef913fb180 Gerrit-Change-Number: 22023 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:40:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in meta-telephony[201705]: libosmo-netif: Add explicit dependency lksctp-tools
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/22022 ) Change subject: libosmo-netif: Add explicit dependency lksctp-tools .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Ib53557f21cad86300738f43b247df1e17166c46f Gerrit-Change-Number: 22022 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:40:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in meta-telephony[201705]: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/22024 ) Change subject: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check .. Patch Set 1: Basically every user of netinet/sctp.h will need that workaround, that's why it would be better to actually fix the poky we use, or if we can somehow add CACHED_CONFIGUREVARS to all our recipes via some config? -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05 Gerrit-Change-Number: 22024 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:39:02 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in meta-telephony[201705]: update all of osmocom to "latest" tags
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/meta-telephony/+/22025 )
Change subject: update all of osmocom to "latest" tags
..
update all of osmocom to "latest" tags
We have to use some arcane construct to make the bitbake fetcher
actualyl fetch tags that are not on any branch (like those patch
releases that themselves branch off master, but which aren't on
master). Otherwise we get errors like:
WARNING: osmo-sgsn-1.6.2+gitrAUTOINC+065500a347-r1.18.0 do_fetch: Failed to
fetch URL git://git.osmocom.org/osmo-sgsn.git;protocol=git, attempting MIRRORS
if available
ERROR: osmo-sgsn-1.6.2+gitrAUTOINC+065500a347-r1.18.0 do_fetch: Fetcher
failure: Unable to find revision 065500a3471dd43b65dc87b95854c3015c551f0f in
branch master even from upstream
Change-Id: I743173f8a3385686ffb11550aabc0fbc665cf043
---
M recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
M recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
M recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
M recipes-osmocom/libosmocore/libosmocore_git.bb
M recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
M recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
M recipes-osmocom/osmo-iuh/osmo-iuh_git.bb
M recipes-osmocom/osmo-msc/osmo-msc_git.bb
M recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb
M recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb
M recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb
12 files changed, 30 insertions(+), 30 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/25/22025/1
diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
index 0582599..446a590 100644
--- a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
+++ b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "c313d44272f04b24dad38f4caea17180f9cbc509"
-SRC_URI = "git://git.osmocom.org/libosmo-abis.git;protocol=git"
-PV = "0.8.0+gitr${SRCPV}"
+SRCREV = "1.0.1"
+SRC_URI =
"git://git.osmocom.org/libosmo-abis.git;protocol=git;tag=${SRCREV};nobranch=1"
+PV = "1.0.1+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
index c52c7e9..0f2856e 100644
--- a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
+++ b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "b8121e79ef53b30df535fb38987b3a48853ebbe9"
+SRCREV = "f3ccbecb6f802ccd98d154dc7ba7d552e298b2ea"
SRC_URI = "git://git.osmocom.org/libosmo-netif.git;protocol=git"
-PV = "0.7.0+gitr${SRCPV}"
+PV = "1.0.0+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
index 31fa234..c78477c 100644
--- a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
+++ b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "5e4643f4bc76a1437621348550b5b2a603e2179b"
+SRCREV = "37880b696ee90dead7e3b1292b109cc041a44e52"
SRC_URI = "git://git.osmocom.org/libosmo-sccp.git;protocol=git"
-PV = "1.2.0+gitr${SRCPV}"
+PV = "1.3.0+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmocore/libosmocore_git.bb
b/recipes-osmocom/libosmocore/libosmocore_git.bb
index d5eab3a..1acf6ac 100644
--- a/recipes-osmocom/libosmocore/libosmocore_git.bb
+++ b/recipes-osmocom/libosmocore/libosmocore_git.bb
@@ -1,9 +1,9 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "2862f9082ed4f16383a134e1112610d76ad91bf0"
+SRCREV = "5681a3254c1727d4926ac6d36800fd63d87ad7a2"
SRC_URI = "git://git.osmocom.org/libosmocore.git;protocol=git;nobranch=1"
-PV = "1.3.0+gitr${SRCPV}"
+PV = "1.4.1+gitr${SRCPV}"
PR = "${INC_PR}.0"
PACKAGES =+ "libosmoctrl libosmocodec libosmogb libosmogsm libosmovty
osmo-arfcn osmo-auc-gen osmo-config-merge"
diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
index fdb389b..dce2ef1 100644
--- a/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
+++ b/recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "a1362ce8c20b2fa60e3da67936ea69d406e23aff"
-SRC_URI = "git://git.osmocom.org/osmo-bsc.git;protocol=git"
-PV = "1.6.0+gitr${SRCPV}"
+SRCREV = "1.6.1"
+SRC_URI =
"git://git.osmocom.org/osmo-bsc.git;protocol=git;tag=${SRCREV};nobranch=1"
+PV = "1.6.1+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
index b1b2298..a854384 100644
--- a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
+++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
@@ -1,9 +1,9 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "e71e0f2af84d8b26f4c09a8c859f86cf701b3357"
+SRCREV =
Change in meta-telephony[201705]: libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check
Hello pespin,
I'd like you to do a code review. Please visit
https://gerrit.osmocom.org/c/meta-telephony/+/22023
to review the following change.
Change subject: libosmo-netif: workaround oe-core forcing fail of sctp.h
autoconf check
..
libosmo-netif: workaround oe-core forcing fail of sctp.h autoconf check
oe-core is currently (pyro and current master) forcing non-availability
of netinet/sctp.h header file through autoconf's export CONFIG_SITE
pointing to files in meta/site/, which contain:
ac_cv_header_netinet_sctp_h=${ac_cv_header_netinet_sctp_h=no}
As a result, netinet/sctp.h is not found despite DEPENDS="lksctp-tools"
and the file being available correctly under recipe-sysroot/ and finally
configure fails with AC_MSG_ERROR().
It was confirmed by OE devs that those lines should not be there, and a
patch has been submitted:
https://patchwork.openembedded.org/patch/168892/
Since it's not available in pyro nor latest release, let's workaround it
in our recipe to make sure it works with older versions of OE.
Change-Id: Ide91e96648881a0c6d415d727a14c2ef913fb180
---
M recipes-osmocom/libosmo-netif/libosmo-netif.inc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/23/22023/1
diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif.inc
b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
index 0a51dfc..7098c42 100644
--- a/recipes-osmocom/libosmo-netif/libosmo-netif.inc
+++ b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
@@ -12,4 +12,8 @@
"
PACKAGECONFIG[libsctp] = "--enable-libsctp,--disable-libsctp,lksctp-tools,"
+# Workaround to oe-core meta/site/* CONFIG_SITE files passed to autoconf
forcing unavailability of netinet/sctp.h.
+# Patch fixing issue upstream: https://patchwork.openembedded.org/patch/168892/
+CACHED_CONFIGUREVARS += "${@bb.utils.contains('PACKAGECONFIG', 'libsctp',
'ac_cv_header_netinet_sctp_h=yes', '',d)}"
+
inherit autotools pkgconfig
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22023
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: Ide91e96648881a0c6d415d727a14c2ef913fb180
Gerrit-Change-Number: 22023
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: newchange
Change in meta-telephony[201705]: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/meta-telephony/+/22024 )
Change subject: osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf
check
..
osmo-iuh: workaround oe-core forcing fail of sctp.h autoconf check
oe-core is currently (pyro and current master) forcing non-availability
of netinet/sctp.h header file through autoconf's export CONFIG_SITE
pointing to files in meta/site/, which contain:
ac_cv_header_netinet_sctp_h=${ac_cv_header_netinet_sctp_h=no}
As a result, netinet/sctp.h is not found despite DEPENDS="lksctp-tools"
and the file being available correctly under recipe-sysroot/ and finally
configure fails with AC_MSG_ERROR().
It was confirmed by OE devs that those lines should not be there, and a
patch has been submitted:
https://patchwork.openembedded.org/patch/168892/
Since it's not available in pyro nor latest release, let's workaround it
in our recipe to make sure it works with older versions of OE.
Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05
---
M recipes-osmocom/osmo-iuh/osmo-iuh.inc
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/24/22024/1
diff --git a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
index ab412ad..92b4633 100644
--- a/recipes-osmocom/osmo-iuh/osmo-iuh.inc
+++ b/recipes-osmocom/osmo-iuh/osmo-iuh.inc
@@ -3,9 +3,13 @@
LICENSE = "AGPLv3"
LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"
-DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c"
+DEPENDS = "libosmocore libosmo-netif libosmo-sccp libasn1c lksctp-tools"
-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"
+
+# Workaround to oe-core meta/site/* CONFIG_SITE files passed to autoconf
forcing unavailability of netinet/sctp.h.
+# Patch fixing issue upstream: https://patchwork.openembedded.org/patch/168892/
+CACHED_CONFIGUREVARS += "ac_cv_header_netinet_sctp_h=yes"
inherit autotools pkgconfig systemd
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22024
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: Ic54c50300bcf2cd278db95550d14eef044caea05
Gerrit-Change-Number: 22024
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in meta-telephony[201705]: libosmo-netif: Add explicit dependency lksctp-tools
Hello pespin,
I'd like you to do a code review. Please visit
https://gerrit.osmocom.org/c/meta-telephony/+/22022
to review the following change.
Change subject: libosmo-netif: Add explicit dependency lksctp-tools
..
libosmo-netif: Add explicit dependency lksctp-tools
Since libosmo-netif.git d1b1ff77a6bc2f70366c5d2f5079c70f5eae52a0, use of
libsctp is enabled by default and explicitly required.
Change-Id: Ib53557f21cad86300738f43b247df1e17166c46f
---
M recipes-osmocom/libosmo-netif/libosmo-netif.inc
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/22/22022/1
diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif.inc
b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
index a353be6..0a51dfc 100644
--- a/recipes-osmocom/libosmo-netif/libosmo-netif.inc
+++ b/recipes-osmocom/libosmo-netif/libosmo-netif.inc
@@ -1,10 +1,15 @@
DESCRIPTION = "Osmocom network interface library"
-DEPENDS = "libosmo-abis libtalloc lksctp-tools"
HOMEPAGE = "http://git.osmocom.org;
LICENSE = "GPLv2+"
-
-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
-
LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+
+DEPENDS = "libosmo-abis libtalloc"
+
+PACKAGECONFIG ??= "\
+libsctp \
+"
+PACKAGECONFIG[libsctp] = "--enable-libsctp,--disable-libsctp,lksctp-tools,"
+
inherit autotools pkgconfig
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/22022
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: Ib53557f21cad86300738f43b247df1e17166c46f
Gerrit-Change-Number: 22022
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: CTRL: Introduce support to run osmocom CTRL server
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 ) Change subject: CTRL: Introduce support to run osmocom CTRL server .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012/1/library/Osmocom_CTRL_Adapter.ttcn File library/Osmocom_CTRL_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012/1/library/Osmocom_CTRL_Adapter.ttcn@62 PS1, Line 62: v > it might make sense to differentiate based on server/client in the ID. […] Ack. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37db9962f51baf2c63bd58ec47ec89f773d7a255 Gerrit-Change-Number: 22012 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 07 Jan 2021 13:30:20 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-bts[master]: vty: add a command to show GPRS related info
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/20484 )
Change subject: vty: add a command to show GPRS related info
..
vty: add a command to show GPRS related info
Here is a sample output:
OsmoBTS# show bts 0 gprs
BTS 0, RAC 0, NSEI 101, BVCI 2
Cell NM state: Oper 'Enabled', Admin 'Unlocked', Avail 'OK'
NSE NM state: Oper 'Enabled', Admin 'Unlocked', Avail 'OK'
NSVC0 (NSVCI 101) NM state: Oper 'Enabled', Admin 'Unlocked', Avail 'OK'
Address: r=127.0.0.1:23010<->l=0.0.0.0:55385
NSVC1 (NSVCI 0) NM state: Oper 'Disabled', Admin 'Locked', Avail 'Off line'
This command is useful for debugging NS connection problems.
Change-Id: I149eea0b1c109020406eb67c9082c335a77aab06
---
M src/common/vty.c
1 file changed, 70 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/src/common/vty.c b/src/common/vty.c
index 326e332..1c3b496 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -39,6 +39,7 @@
#include
#include
#include
+#include
#include
@@ -1104,6 +1105,73 @@
return CMD_SUCCESS;
}
+static void gprs_dump_vty(struct vty *vty, const struct gsm_bts *bts)
+{
+ unsigned int i;
+
+ /* GPRS parameters received from the BSC */
+ vty_out(vty, "BTS %u, RAC %u, NSEI %u, BVCI %u%s",
+ bts->nr, bts->gprs.rac,
+ bts->gprs.nse.nsei,
+ bts->gprs.cell.bvci,
+ VTY_NEWLINE);
+
+ vty_out(vty, " Cell NM state: ");
+ net_dump_nmstate(vty, >gprs.cell.mo.nm_state);
+ vty_out(vty, " NSE NM state: ");
+ net_dump_nmstate(vty, >gprs.nse.mo.nm_state);
+
+ for (i = 0; i < ARRAY_SIZE(bts->gprs.nsvc); i++) {
+ const struct gsm_bts_gprs_nsvc *nsvc = >gprs.nsvc[i];
+
+ vty_out(vty, " NSVC%u (NSVCI %u) NM state: ", i, nsvc->nsvci);
+ net_dump_nmstate(vty, >mo.nm_state);
+
+ if (nsvc->mo.nm_state.operational == NM_OPSTATE_ENABLED) {
+ struct osmo_sockaddr_str remote;
+ struct osmo_sockaddr_str local;
+
+ if (osmo_sockaddr_str_from_sockaddr(,
>remote.u.sas) != 0)
+ remote = (struct osmo_sockaddr_str) { .ip =
"" };
+ if (osmo_sockaddr_str_from_sockaddr(,
>local.u.sas) != 0)
+ local = (struct osmo_sockaddr_str) { .ip =
"" };
+
+ /* Work around for over-defensiveness of
OSMO_SOCKADDR_STR_FMT_ARGS():
+* error: the address of ‘remote’ will always evaluate
as ‘true’
+* error: the address of ‘local’ will always evaluate
as ‘true’ */
+ const struct osmo_sockaddr_str *r =
+ const struct osmo_sockaddr_str *l =
+
+ /* Getting remote/local address info has never been so
easy, right? */
+ vty_out(vty, "Address: r=" OSMO_SOCKADDR_STR_FMT
+ "<->l=" OSMO_SOCKADDR_STR_FMT
"%s",
+ OSMO_SOCKADDR_STR_FMT_ARGS(r),
+ OSMO_SOCKADDR_STR_FMT_ARGS(l),
+ VTY_NEWLINE);
+ }
+ }
+}
+
+DEFUN(show_bts_gprs, show_bts_gprs_cmd,
+ "show bts <0-255> gprs",
+ SHOW_STR "Display information about a BTS\n"
+ BTS_NR_STR "GPRS/EGPRS configuration\n")
+{
+ const struct gsm_network *net = gsmnet_from_vty(vty);
+ const struct gsm_bts *bts;
+
+ bts = gsm_bts_num(net, atoi(argv[0]));
+ if (bts == NULL) {
+ vty_out(vty, "%% can't find BTS '%s'%s",
+ argv[0], VTY_NEWLINE);
+ return CMD_WARNING;
+ }
+
+ /* TODO: also print info about PCUIF connection */
+ gprs_dump_vty(vty, bts);
+ return CMD_SUCCESS;
+}
+
DEFUN(test_send_failure_event_report, test_send_failure_event_report_cmd,
"test send-failure-event-report <0-255>",
"Various testing commands\n"
"Send a test OML failure event report to the BSC\n" BTS_NR_STR)
@@ -2032,6 +2100,8 @@
install_element_ve(_ts_cmd);
install_element_ve(_lchan_cmd);
install_element_ve(_lchan_summary_cmd);
+ install_element_ve(_bts_gprs_cmd);
+
install_element_ve(_fltr_l1_sapi_cmd);
install_element_ve(_logging_fltr_l1_sapi_cmd);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20484
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I149eea0b1c109020406eb67c9082c335a77aab06
Gerrit-Change-Number: 20484
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Change in libosmocore[master]: bts_features: s/Repeation/Repetition/ in osmo_bts_features_descs[]
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/22021 )
Change subject: bts_features: s/Repeation/Repetition/ in
osmo_bts_features_descs[]
..
bts_features: s/Repeation/Repetition/ in osmo_bts_features_descs[]
Change-Id: Ia8c77766842ce80eae969774959cbf46e86f97b9
---
M src/gsm/bts_features.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/21/22021/1
diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c
index 93703aa..d8c27d8 100644
--- a/src/gsm/bts_features.c
+++ b/src/gsm/bts_features.c
@@ -41,7 +41,7 @@
{ BTS_FEAT_ETWS_PN, "ETWS Primary Notification via PCH" },
{ BTS_FEAT_PAGING_COORDINATION, "BSS Paging Coordination" },
{ BTS_FEAT_IPV6_NSVC, "NSVC IPv6" },
- { BTS_FEAT_ACCH_REP,"FACCH/SACCH Repeation" },
+ { BTS_FEAT_ACCH_REP,"FACCH/SACCH Repetition" },
{ 0, NULL }
};
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22021
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia8c77766842ce80eae969774959cbf46e86f97b9
Gerrit-Change-Number: 22021
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21949 to look at the new patch set (#3). Change subject: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC .. gprs_bssgp: abuse gsm48_encode_ra() to encode TAC Both LAC and TAC take 2 octets and follow MCC/MNC fields on the wire. We abuse gsm48_encode_ra() for encoding of MCC/MNC, but it can also be abused to encode TAC in bssgp_create_rim_ri(). There is no need to encode ''O and then override it with osmo_store16be(). Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 --- M src/gb/gprs_bssgp.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/21949/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 Gerrit-Change-Number: 21949 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: vty: add a command to show GPRS related info
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20484 ) Change subject: vty: add a command to show GPRS related info .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I149eea0b1c109020406eb67c9082c335a77aab06 Gerrit-Change-Number: 20484 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:22:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21949 ) Change subject: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21949/2/src/gb/gprs_bssgp.c File src/gb/gprs_bssgp.c: https://gerrit.osmocom.org/c/libosmocore/+/21949/2/src/gb/gprs_bssgp.c@405 PS2, Line 405: .lac = ri->eutran.tai.tac, /* intentional */ so probably worth it adding "intentional, TAI uses same format as RAI" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 Gerrit-Change-Number: 21949 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:21:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: CTRL: Fix tr_CtrlMsgGet containing invalid value in val field
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22011 ) Change subject: CTRL: Fix tr_CtrlMsgGet containing invalid value in val field .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If1a273a2be71040eaea2189a0aeaf737adf848e5 Gerrit-Change-Number: 22011 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 07 Jan 2021 13:17:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/21949 to look at the new patch set (#2). Change subject: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC .. gprs_bssgp: abuse gsm48_encode_ra() to encode TAC Both LAC and TAC take 2 octets and follow MCC/MNC fields on the wire. We abuse gsm48_encode_ra() for encoding of MCC/MNC, but it can also be abused to encode TAC in bssgp_create_rim_ri(). There is no need to encode ''O and then override it with osmo_store16be(). Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 --- M src/gb/gprs_bssgp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/21949/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 Gerrit-Change-Number: 21949 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: vty: add a command to show GPRS related info
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20484 ) Change subject: vty: add a command to show GPRS related info .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I149eea0b1c109020406eb67c9082c335a77aab06 Gerrit-Change-Number: 20484 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:14:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: manual: Fix typo OsmTRX -> OsmoTRX
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22020 ) Change subject: manual: Fix typo OsmTRX -> OsmoTRX .. manual: Fix typo OsmTRX -> OsmoTRX Change-Id: I4b3a76e41d4abbb08046a241ae9b7c079ce990ae --- M doc/manuals/chapters/configuration.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, approved; Verified diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index a194537..e1323ef 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -1,4 +1,4 @@ -== Configuring OsmTRX +== Configuring OsmoTRX OsmoTRX will read the configuration at startup time and configure the transceiver accordingly after validating the configuration. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4b3a76e41d4abbb08046a241ae9b7c079ce990ae Gerrit-Change-Number: 22020 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-MessageType: merged
Change in osmo-trx[master]: manual: Fix typo OsmTRX -> OsmoTRX
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22020 ) Change subject: manual: Fix typo OsmTRX -> OsmoTRX .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4b3a76e41d4abbb08046a241ae9b7c079ce990ae Gerrit-Change-Number: 22020 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 13:13:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-iuh[for-1.0]: Bump version: 0.6.0.24-da79 → 1.0.0
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22017 ) Change subject: Bump version: 0.6.0.24-da79 → 1.0.0 .. Bump version: 0.6.0.24-da79 → 1.0.0 Change-Id: I4c26bf6c129d15833c4fc5f395465efe88826c44 --- M debian/changelog 1 file changed, 44 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index f59c49e..aae3463 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,47 @@ +osmo-iuh (1.0.0) unstable; urgency=medium + + [ Martin Hauke ] + * tests: Missing return statement + + [ Pau Espin Pedrol ] + * tests/hnb-test-ranap.c: Fix wrong printf format + * tests/test-ranap.c: Fix wrong printf format + * Fix compiler warning on signedness of char ptr using OCTET_STRING_fromBuf() + * hnbgw_vty.c: Drop unusued variables + * tests: Fix trailing whitespace + * Fix OneDefinitionRule Asan violation in tests and osmo-hnbgw + * Change default SCTP conn NULL->127.0.0.1 to localhost->localhost + * hnbgw: Mark SCTP conn as NODELAY + + [ Neels Hofmeyr ] + * manual: add "Configuring Primary Links" and "Multiple instances" + * manual: link to new common cs7-config.adoc + + [ Vadim Yanitskiy ] + * tests/test-helpers: fix some -Wpointer-sign warnings reported by GCC + * tests/test-helpers: fix endianness: do not print uint32_t as raw bytes + * tests/test-ranap: cosmetic: remove unused variable 'rc' + * debian/control: change maintainer to the Osmocom team / mailing list + + [ Eric ] + * configure.ac: fix libtool issue with clang and sanitizer + + [ Philipp Maier ] + * hnbgw: do not use LOGL_DEBUG as default loglevel + + [ Harald Welte ] + * Fix compilation with gcc-10 + * Provide more context when logging "Error in ANY_fromType_aper" + * debian: Actually build manuals; add osmo-hnbgw-doc package + * configure.ac: Ensure netinet/sctp.h is present + + [ Oliver Smith ] + * contrib: import RPM spec + * contrib: integrate RPM spec + * Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in + + -- Harald Welte Thu, 07 Jan 2021 13:55:19 +0100 + osmo-iuh (0.6.0) unstable; urgency=medium [ Vadim Yanitskiy ] -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: for-1.0 Gerrit-Change-Id: I4c26bf6c129d15833c4fc5f395465efe88826c44 Gerrit-Change-Number: 22017 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-trx[master]: manual: Fix typo OsmTRX -> OsmoTRX
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/22020 ) Change subject: manual: Fix typo OsmTRX -> OsmoTRX .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4b3a76e41d4abbb08046a241ae9b7c079ce990ae Gerrit-Change-Number: 22020 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 13:09:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: manual: Fix typo OsmTRX -> OsmoTRX
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/22020 ) Change subject: manual: Fix typo OsmTRX -> OsmoTRX .. manual: Fix typo OsmTRX -> OsmoTRX Change-Id: I4b3a76e41d4abbb08046a241ae9b7c079ce990ae --- M doc/manuals/chapters/configuration.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/20/22020/1 diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index a194537..e1323ef 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -1,4 +1,4 @@ -== Configuring OsmTRX +== Configuring OsmoTRX OsmoTRX will read the configuration at startup time and configure the transceiver accordingly after validating the configuration. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4b3a76e41d4abbb08046a241ae9b7c079ce990ae Gerrit-Change-Number: 22020 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in osmo-iuh[master]: configure.ac: Ensure netinet/sctp.h is present
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-iuh/+/22019 )
Change subject: configure.ac: Ensure netinet/sctp.h is present
..
configure.ac: Ensure netinet/sctp.h is present
we unconditionally depend on this header file, yet nothing
in configure.ac ensures its presence. Building on a clean
Debian 10 with all existing dependencies installed passes
configure but fails at compilation time.
Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0
---
M configure.ac
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/configure.ac b/configure.ac
index 692db57..c186855 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,6 +31,8 @@
[AS_CASE(["${host_os}"],
[*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs
$compiler_flags $wl-soname $wl$soname -o $lib'])])
+AC_CHECK_HEADERS(netinet/sctp.h,,AC_MSG_ERROR(netinet/sctp.h not found))
+
dnl check for pkg-config (explained in detail in libosmocore/configure.ac)
AC_PATH_PROG(PKG_CONFIG_INSTALLED, pkg-config, no)
if test "x$PKG_CONFIG_INSTALLED" = "xno"; then
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22019
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-iuh[master]: debian: Actually build manuals; add osmo-hnbgw-doc package
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-iuh/+/22018 )
Change subject: debian: Actually build manuals; add osmo-hnbgw-doc package
..
debian: Actually build manuals; add osmo-hnbgw-doc package
for some strange reason we didn't yet build the manual in the debian
package build.
Change-Id: Id53956494144b46e78fc25a176a9b8917788d86e
---
M TODO-RELEASE
M debian/control
M debian/rules
3 files changed, 16 insertions(+), 3 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/TODO-RELEASE b/TODO-RELEASE
index dde4b72..d0852fc 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,4 +7,3 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public
release: c:r:0.
#library whatdescription / commit summary line
-manual needs common chapter cs7-config.adoc from
osmo-gsm-manuals > 0.3.0
diff --git a/debian/control b/debian/control
index 416b9d7..d1805de 100644
--- a/debian/control
+++ b/debian/control
@@ -14,6 +14,7 @@
libosmocore-dev (>= 0.12.0),
libosmo-netif-dev (>= 0.3.0),
libosmo-sigtran-dev (>= 0.10.0),
+ osmo-gsm-manuals-dev (>= 1.0.0),
python3
Standards-Version: 3.9.8
Vcs-Git: git://git.osmocom.org/osmo-iuh.git
@@ -36,6 +37,14 @@
Depends: osmo-hnbgw (= ${binary:Version}), ${misc:Depends}
Description: osmocom Home Node B Gateway
+Package: osmo-hnbgw-doc
+Section: doc
+Architecture: all
+Depends: ${misc:Depends}
+Description: ${misc:Package} PDF documentation
+ Various manuals: user manual, VTY reference manual and/or
+ protocol/interface manuals.
+
Package: libosmo-ranap3
Section: libs
Architecture: any
diff --git a/debian/rules b/debian/rules
index c3bdf50..e1f6124 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,6 +8,10 @@
%:
dh $@ --with autoreconf
+CONFIGURE_FLAGS += --with-systemdsystemunitdir=/lib/systemd/system
--enable-manuals
+override_dh_auto_configure:
+ dh_auto_configure -- $(CONFIGURE_FLAGS)
+
# See
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-dbg
override_dh_strip:
dh_strip -plibosmo-ranap3 --dbg-package=libosmo-ranap-dbg
@@ -18,5 +22,6 @@
override_dh_auto_test:
dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)
-override_dh_auto_configure:
- dh_auto_configure -- --with-systemdsystemunitdir=/lib/systemd/system
+# Don't create .pdf.gz files (barely saves space and they can't be opened
directly by most pdf readers)
+override_dh_compress:
+ dh_compress -X.pdf
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22018
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Id53956494144b46e78fc25a176a9b8917788d86e
Gerrit-Change-Number: 22018
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-iuh[for-1.0]: configure.ac: Ensure netinet/sctp.h is present
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-iuh/+/22014 )
Change subject: configure.ac: Ensure netinet/sctp.h is present
..
configure.ac: Ensure netinet/sctp.h is present
we unconditionally depend on this header file, yet nothing
in configure.ac ensures its presence. Building on a clean
Debian 10 with all existing dependencies installed passes
configure but fails at compilation time.
Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0
---
M configure.ac
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/configure.ac b/configure.ac
index 692db57..c186855 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,6 +31,8 @@
[AS_CASE(["${host_os}"],
[*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs
$compiler_flags $wl-soname $wl$soname -o $lib'])])
+AC_CHECK_HEADERS(netinet/sctp.h,,AC_MSG_ERROR(netinet/sctp.h not found))
+
dnl check for pkg-config (explained in detail in libosmocore/configure.ac)
AC_PATH_PROG(PKG_CONFIG_INSTALLED, pkg-config, no)
if test "x$PKG_CONFIG_INSTALLED" = "xno"; then
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22014
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: for-1.0
Gerrit-Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0
Gerrit-Change-Number: 22014
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-iuh[for-1.0]: debian: Actually build manuals; add osmo-hnbgw-doc package
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-iuh/+/22010 )
Change subject: debian: Actually build manuals; add osmo-hnbgw-doc package
..
debian: Actually build manuals; add osmo-hnbgw-doc package
for some strange reason we didn't yet build the manual in the debian
package build.
Change-Id: Id53956494144b46e78fc25a176a9b8917788d86e
---
M TODO-RELEASE
M debian/control
M debian/rules
3 files changed, 16 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/TODO-RELEASE b/TODO-RELEASE
index dde4b72..d0852fc 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,4 +7,3 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public
release: c:r:0.
#library whatdescription / commit summary line
-manual needs common chapter cs7-config.adoc from
osmo-gsm-manuals > 0.3.0
diff --git a/debian/control b/debian/control
index 416b9d7..d1805de 100644
--- a/debian/control
+++ b/debian/control
@@ -14,6 +14,7 @@
libosmocore-dev (>= 0.12.0),
libosmo-netif-dev (>= 0.3.0),
libosmo-sigtran-dev (>= 0.10.0),
+ osmo-gsm-manuals-dev (>= 1.0.0),
python3
Standards-Version: 3.9.8
Vcs-Git: git://git.osmocom.org/osmo-iuh.git
@@ -36,6 +37,14 @@
Depends: osmo-hnbgw (= ${binary:Version}), ${misc:Depends}
Description: osmocom Home Node B Gateway
+Package: osmo-hnbgw-doc
+Section: doc
+Architecture: all
+Depends: ${misc:Depends}
+Description: ${misc:Package} PDF documentation
+ Various manuals: user manual, VTY reference manual and/or
+ protocol/interface manuals.
+
Package: libosmo-ranap3
Section: libs
Architecture: any
diff --git a/debian/rules b/debian/rules
index c3bdf50..e1f6124 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,6 +8,10 @@
%:
dh $@ --with autoreconf
+CONFIGURE_FLAGS += --with-systemdsystemunitdir=/lib/systemd/system
--enable-manuals
+override_dh_auto_configure:
+ dh_auto_configure -- $(CONFIGURE_FLAGS)
+
# See
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-dbg
override_dh_strip:
dh_strip -plibosmo-ranap3 --dbg-package=libosmo-ranap-dbg
@@ -18,5 +22,6 @@
override_dh_auto_test:
dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)
-override_dh_auto_configure:
- dh_auto_configure -- --with-systemdsystemunitdir=/lib/systemd/system
+# Don't create .pdf.gz files (barely saves space and they can't be opened
directly by most pdf readers)
+override_dh_compress:
+ dh_compress -X.pdf
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22010
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: for-1.0
Gerrit-Change-Id: Id53956494144b46e78fc25a176a9b8917788d86e
Gerrit-Change-Number: 22010
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-iuh[master]: debian: Actually build manuals; add osmo-hnbgw-doc package
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22018 ) Change subject: debian: Actually build manuals; add osmo-hnbgw-doc package .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Id53956494144b46e78fc25a176a9b8917788d86e Gerrit-Change-Number: 22018 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 13:03:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-iuh[master]: configure.ac: Ensure netinet/sctp.h is present
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22019 ) Change subject: configure.ac: Ensure netinet/sctp.h is present .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22019 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0 Gerrit-Change-Number: 22019 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 07 Jan 2021 13:03:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-iuh[for-1.0]: Bump version: 0.6.0.24-da79 → 1.0.0
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22017 ) Change subject: Bump version: 0.6.0.24-da79 → 1.0.0 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: for-1.0 Gerrit-Change-Id: I4c26bf6c129d15833c4fc5f395465efe88826c44 Gerrit-Change-Number: 22017 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 13:03:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: vty: add a command to show GPRS related info
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/20484 to look at the new patch set (#4). Change subject: vty: add a command to show GPRS related info .. vty: add a command to show GPRS related info Here is a sample output: OsmoBTS# show bts 0 gprs BTS 0, RAC 0, NSEI 101, BVCI 2 Cell NM state: Oper 'Enabled', Admin 'Unlocked', Avail 'OK' NSE NM state: Oper 'Enabled', Admin 'Unlocked', Avail 'OK' NSVC0 (NSVCI 101) NM state: Oper 'Enabled', Admin 'Unlocked', Avail 'OK' Address: r=127.0.0.1:23010<->l=0.0.0.0:55385 NSVC1 (NSVCI 0) NM state: Oper 'Disabled', Admin 'Locked', Avail 'Off line' This command is useful for debugging NS connection problems. Change-Id: I149eea0b1c109020406eb67c9082c335a77aab06 --- M src/common/vty.c 1 file changed, 70 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/20484/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I149eea0b1c109020406eb67c9082c335a77aab06 Gerrit-Change-Number: 20484 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-iuh[for-1.0]: Bump version: 0.6.0.24-da79 → 1.0.0
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22017 ) Change subject: Bump version: 0.6.0.24-da79 → 1.0.0 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: for-1.0 Gerrit-Change-Id: I4c26bf6c129d15833c4fc5f395465efe88826c44 Gerrit-Change-Number: 22017 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 13:00:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-iuh[master]: configure.ac: Ensure netinet/sctp.h is present
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22019 ) Change subject: configure.ac: Ensure netinet/sctp.h is present .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22019 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0 Gerrit-Change-Number: 22019 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 13:00:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-iuh[master]: debian: Actually build manuals; add osmo-hnbgw-doc package
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22018 ) Change subject: debian: Actually build manuals; add osmo-hnbgw-doc package .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Id53956494144b46e78fc25a176a9b8917788d86e Gerrit-Change-Number: 22018 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 12:59:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: CTRL: Introduce support to run osmocom CTRL server
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 ) Change subject: CTRL: Introduce support to run osmocom CTRL server .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012/1/library/Osmocom_CTRL_Adapter.ttcn File library/Osmocom_CTRL_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012/1/library/Osmocom_CTRL_Adapter.ttcn@62 PS1, Line 62: v it might make sense to differentiate based on server/client in the ID. Othertwise you start both client and server "adapter" and their components have identical names. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37db9962f51baf2c63bd58ec47ec89f773d7a255 Gerrit-Change-Number: 22012 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 07 Jan 2021 12:59:42 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: CTRL: Fix tr_CtrlMsgGet containing invalid value in val field
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22011 ) Change subject: CTRL: Fix tr_CtrlMsgGet containing invalid value in val field .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If1a273a2be71040eaea2189a0aeaf737adf848e5 Gerrit-Change-Number: 22011 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 07 Jan 2021 12:58:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-iuh[for-1.0]: Bump version: 0.6.0.24-da79 → 1.0.0
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22017 ) Change subject: Bump version: 0.6.0.24-da79 → 1.0.0 .. Patch Set 1: I've teste that this acutally builds against a current "latest" feed in a clean debian 10 container. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: for-1.0 Gerrit-Change-Id: I4c26bf6c129d15833c4fc5f395465efe88826c44 Gerrit-Change-Number: 22017 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 12:57:58 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-iuh[master]: configure.ac: Ensure netinet/sctp.h is present
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-iuh/+/22019 )
Change subject: configure.ac: Ensure netinet/sctp.h is present
..
configure.ac: Ensure netinet/sctp.h is present
we unconditionally depend on this header file, yet nothing
in configure.ac ensures its presence. Building on a clean
Debian 10 with all existing dependencies installed passes
configure but fails at compilation time.
Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0
---
M configure.ac
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/19/22019/1
diff --git a/configure.ac b/configure.ac
index 692db57..c186855 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,6 +31,8 @@
[AS_CASE(["${host_os}"],
[*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs
$compiler_flags $wl-soname $wl$soname -o $lib'])])
+AC_CHECK_HEADERS(netinet/sctp.h,,AC_MSG_ERROR(netinet/sctp.h not found))
+
dnl check for pkg-config (explained in detail in libosmocore/configure.ac)
AC_PATH_PROG(PKG_CONFIG_INSTALLED, pkg-config, no)
if test "x$PKG_CONFIG_INSTALLED" = "xno"; then
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22019
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0
Gerrit-Change-Number: 22019
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in osmo-iuh[master]: debian: Actually build manuals; add osmo-hnbgw-doc package
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-iuh/+/22018 )
Change subject: debian: Actually build manuals; add osmo-hnbgw-doc package
..
debian: Actually build manuals; add osmo-hnbgw-doc package
for some strange reason we didn't yet build the manual in the debian
package build.
Change-Id: Id53956494144b46e78fc25a176a9b8917788d86e
---
M TODO-RELEASE
M debian/control
M debian/rules
3 files changed, 16 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/18/22018/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
index dde4b72..d0852fc 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,4 +7,3 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public
release: c:r:0.
#library whatdescription / commit summary line
-manual needs common chapter cs7-config.adoc from
osmo-gsm-manuals > 0.3.0
diff --git a/debian/control b/debian/control
index 416b9d7..d1805de 100644
--- a/debian/control
+++ b/debian/control
@@ -14,6 +14,7 @@
libosmocore-dev (>= 0.12.0),
libosmo-netif-dev (>= 0.3.0),
libosmo-sigtran-dev (>= 0.10.0),
+ osmo-gsm-manuals-dev (>= 1.0.0),
python3
Standards-Version: 3.9.8
Vcs-Git: git://git.osmocom.org/osmo-iuh.git
@@ -36,6 +37,14 @@
Depends: osmo-hnbgw (= ${binary:Version}), ${misc:Depends}
Description: osmocom Home Node B Gateway
+Package: osmo-hnbgw-doc
+Section: doc
+Architecture: all
+Depends: ${misc:Depends}
+Description: ${misc:Package} PDF documentation
+ Various manuals: user manual, VTY reference manual and/or
+ protocol/interface manuals.
+
Package: libosmo-ranap3
Section: libs
Architecture: any
diff --git a/debian/rules b/debian/rules
index c3bdf50..e1f6124 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,6 +8,10 @@
%:
dh $@ --with autoreconf
+CONFIGURE_FLAGS += --with-systemdsystemunitdir=/lib/systemd/system
--enable-manuals
+override_dh_auto_configure:
+ dh_auto_configure -- $(CONFIGURE_FLAGS)
+
# See
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-dbg
override_dh_strip:
dh_strip -plibosmo-ranap3 --dbg-package=libosmo-ranap-dbg
@@ -18,5 +22,6 @@
override_dh_auto_test:
dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)
-override_dh_auto_configure:
- dh_auto_configure -- --with-systemdsystemunitdir=/lib/systemd/system
+# Don't create .pdf.gz files (barely saves space and they can't be opened
directly by most pdf readers)
+override_dh_compress:
+ dh_compress -X.pdf
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22018
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Id53956494144b46e78fc25a176a9b8917788d86e
Gerrit-Change-Number: 22018
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in osmo-iuh[for-1.0]: configure.ac: Ensure netinet/sctp.h is present
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22014 ) Change subject: configure.ac: Ensure netinet/sctp.h is present .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: for-1.0 Gerrit-Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 07 Jan 2021 12:55:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-iuh[for-1.0]: Bump version: 0.6.0.24-da79 → 1.0.0
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22017 ) Change subject: Bump version: 0.6.0.24-da79 → 1.0.0 .. Bump version: 0.6.0.24-da79 → 1.0.0 Change-Id: I4c26bf6c129d15833c4fc5f395465efe88826c44 --- M debian/changelog 1 file changed, 44 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/17/22017/1 diff --git a/debian/changelog b/debian/changelog index f59c49e..aae3463 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,47 @@ +osmo-iuh (1.0.0) unstable; urgency=medium + + [ Martin Hauke ] + * tests: Missing return statement + + [ Pau Espin Pedrol ] + * tests/hnb-test-ranap.c: Fix wrong printf format + * tests/test-ranap.c: Fix wrong printf format + * Fix compiler warning on signedness of char ptr using OCTET_STRING_fromBuf() + * hnbgw_vty.c: Drop unusued variables + * tests: Fix trailing whitespace + * Fix OneDefinitionRule Asan violation in tests and osmo-hnbgw + * Change default SCTP conn NULL->127.0.0.1 to localhost->localhost + * hnbgw: Mark SCTP conn as NODELAY + + [ Neels Hofmeyr ] + * manual: add "Configuring Primary Links" and "Multiple instances" + * manual: link to new common cs7-config.adoc + + [ Vadim Yanitskiy ] + * tests/test-helpers: fix some -Wpointer-sign warnings reported by GCC + * tests/test-helpers: fix endianness: do not print uint32_t as raw bytes + * tests/test-ranap: cosmetic: remove unused variable 'rc' + * debian/control: change maintainer to the Osmocom team / mailing list + + [ Eric ] + * configure.ac: fix libtool issue with clang and sanitizer + + [ Philipp Maier ] + * hnbgw: do not use LOGL_DEBUG as default loglevel + + [ Harald Welte ] + * Fix compilation with gcc-10 + * Provide more context when logging "Error in ANY_fromType_aper" + * debian: Actually build manuals; add osmo-hnbgw-doc package + * configure.ac: Ensure netinet/sctp.h is present + + [ Oliver Smith ] + * contrib: import RPM spec + * contrib: integrate RPM spec + * Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in + + -- Harald Welte Thu, 07 Jan 2021 13:55:19 +0100 + osmo-iuh (0.6.0) unstable; urgency=medium [ Vadim Yanitskiy ] -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: for-1.0 Gerrit-Change-Id: I4c26bf6c129d15833c4fc5f395465efe88826c44 Gerrit-Change-Number: 22017 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
Change in osmo-iuh[for-1.0]: Bump version: 0.6.0.24-da79 → 1.0.0
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22016 ) Change subject: Bump version: 0.6.0.24-da79 → 1.0.0 .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: for-1.0 Gerrit-Change-Id: I17cb89a085689e15840f4c5812eb5ff75f961d33 Gerrit-Change-Number: 22016 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon
