[S] Change in docker-playground[master]: asterisk: Enable capabilities required to set up ipsec
Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36775?usp=email ) Change subject: asterisk: Enable capabilities required to set up ipsec .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36775?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2dc040cf87169c9a59dc7e9f1af0e1c17bde6683 Gerrit-Change-Number: 36775 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 13 May 2024 09:07:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in docker-playground[master]: asterisk: pjsip.conf: Mark templates accordingly
Attention is currently required from: dexter, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36650?usp=email ) Change subject: asterisk: pjsip.conf: Mark templates accordingly .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia132c2e90cf6ee44145ca2e2555cf2dc6c1cfd51 Gerrit-Change-Number: 36650 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Attention: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 10 May 2024 13:02:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in docker-playground[master]: asterisk: manager.conf: Give more permissions to AMI user
Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36651?usp=email ) Change subject: asterisk: manager.conf: Give more permissions to AMI user .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia77a9d88758f648a5539dbc7511b75c20fe7dd6b Gerrit-Change-Number: 36651 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Fri, 10 May 2024 13:01:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-e1-hardware[master]: icE1usb fw: Implement E1 line monitor task
Attention is currently required from: roox, tnt. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36684?usp=email ) Change subject: icE1usb fw: Implement E1 line monitor task .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id310b65b7cd83c3bbae90ecd4a82b09a3989d91f Gerrit-Change-Number: 36684 Gerrit-PatchSet: 3 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: manawyrm Gerrit-Reviewer: roox Gerrit-Attention: roox Gerrit-Attention: tnt Gerrit-Comment-Date: Wed, 08 May 2024 18:35:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: asterisk/AMI_Functions: improvements to implement PJSIPRegister
Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36652?usp=email ) Change subject: asterisk/AMI_Functions: improvements to implement PJSIPRegister .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc4ff6eaad84f67d33c1211dc5e39294ce1c8fac Gerrit-Change-Number: 36652 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 08 May 2024 07:41:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-e1d[master]: iCE1usb: Transmit AIS events to clients
Attention is currently required from: tnt. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36690?usp=email ) Change subject: iCE1usb: Transmit AIS events to clients .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a35a2ab2537cbc9ecec381ab5078c1b08067925 Gerrit-Change-Number: 36690 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Attention: tnt Gerrit-Comment-Date: Sat, 04 May 2024 10:15:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-e1d[master]: iCE1usb: Add support to configure CRC4 mode for TX/RX
Attention is currently required from: laforge, tnt. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email ) Change subject: iCE1usb: Add support to configure CRC4 mode for TX/RX .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I9b627a9617af4ae9ed98214d672c7d0391f801eb Gerrit-Change-Number: 36653 Gerrit-PatchSet: 3 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Attention: tnt Gerrit-Comment-Date: Sat, 04 May 2024 10:14:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-e1d[master]: Update ice1usb_proto.h
Attention is currently required from: tnt. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36688?usp=email ) Change subject: Update ice1usb_proto.h .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8e041b3d94723eba9d3d30b9f03815d46dacf995 Gerrit-Change-Number: 36688 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Attention: tnt Gerrit-Comment-Date: Sat, 04 May 2024 10:13:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-e1d[master]: ctl: When setting Sa bits, other bits must remain set to '1'
Attention is currently required from: tnt. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36691?usp=email ) Change subject: ctl: When setting Sa bits, other bits must remain set to '1' .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id482c6a114e7bf051d157e81038f015e9d26fa99 Gerrit-Change-Number: 36691 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Attention: tnt Gerrit-Comment-Date: Sat, 04 May 2024 10:13:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-e1d[master]: iCE1usb: Transmit LOS events to clients
Attention is currently required from: tnt. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36689?usp=email ) Change subject: iCE1usb: Transmit LOS events to clients .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8822d24c25f8ba0bb70e9f717ca04dbf0e656e71 Gerrit-Change-Number: 36689 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Attention: tnt Gerrit-Comment-Date: Sat, 04 May 2024 10:12:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in docker-playground[master]: asterisk-master: Use pjproject from external git repo
Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36649?usp=email ) Change subject: asterisk-master: Use pjproject from external git repo .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I73f3323db1b6897fc43215578b0a011fdb6909c5 Gerrit-Change-Number: 36649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 29 Apr 2024 07:39:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: Do not reconnect when receiving SCTP notification
jolly has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email ) Change subject: Do not reconnect when receiving SCTP notification .. Abandoned Improved patches are provided by pespin and merged. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic588e6d8a3eecde701778f7d6ff5599ab81eff2b Gerrit-Change-Number: 36568 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: abandon
[M] Change in libosmo-sccp[master]: ss7_asp: Update osmo_stream read_cb2 functions to accommodate for new...
Attention is currently required from: fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36575?usp=email ) Change subject: ss7_asp: Update osmo_stream read_cb2 functions to accommodate for new API param .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I579f4101a9e2874e310ff78e4571f38cfe8dfab0 Gerrit-Change-Number: 36575 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Thu, 18 Apr 2024 13:39:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in libosmo-netif[master]: stream_{cli,srv}: Add 'res' param to read_cb2
Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36574?usp=email )
Change subject: stream_{cli,srv}: Add 'res' param to read_cb2
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36574?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I395c75ff1e9904757ce1d767a9ac2f779593c4c8
Gerrit-Change-Number: 36574
Gerrit-PatchSet: 5
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: jolly
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-Attention: laforge
Gerrit-Attention: pespin
Gerrit-Comment-Date: Thu, 18 Apr 2024 13:35:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[L] Change in osmo-ttcn3-hacks[master]: Asterisk: Initial AMI support
Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36594?usp=email ) Change subject: Asterisk: Initial AMI support .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c570e4d04e7ab8c44962cf484e4bbc946209aee Gerrit-Change-Number: 36594 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Thu, 18 Apr 2024 13:33:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: Do not reconnect when receiving SCTP notification
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email )
Change subject: Do not reconnect when receiving SCTP notification
..
Do not reconnect when receiving SCTP notification
If a notification is detected by stream_sctp_recvmsg_trailer(), it
returns -EAGAIN. This is not an error that should cause the stream
client to trigger a reconnect. It must drop that message, as it is
done at the stream server.
In both cases the unhandled msg must be freed.
Change-Id: Ic588e6d8a3eecde701778f7d6ff5599ab81eff2b
---
M src/stream_cli.c
M src/stream_srv.c
2 files changed, 23 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/68/36568/1
diff --git a/src/stream_cli.c b/src/stream_cli.c
index 11c88ae..aeac78e 100644
--- a/src/stream_cli.c
+++ b/src/stream_cli.c
@@ -497,6 +497,10 @@
struct osmo_stream_cli *cli = osmo_iofd_get_data(iofd);
res = stream_iofd_sctp_recvmsg_trailer(iofd, msg, res, msgh);
+ if (res == -EAGAIN) {
+ msgb_free(msg);
+ return;
+ }
switch (cli->state) {
case STREAM_CLI_STATE_CONNECTING:
diff --git a/src/stream_srv.c b/src/stream_srv.c
index a02c1c2..994015b 100644
--- a/src/stream_srv.c
+++ b/src/stream_srv.c
@@ -658,8 +658,10 @@
LOGSSRV(conn, LOGL_DEBUG, "message received (res=%d)\n", res);
res = stream_iofd_sctp_recvmsg_trailer(iofd, msg, res, msgh);
- if (res == -EAGAIN)
+ if (res == -EAGAIN) {
+ msgb_free(msg);
return;
+ }
if (OSMO_UNLIKELY(res <= 0)) {
/* This connection is dead, destroy it. */
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ic588e6d8a3eecde701778f7d6ff5599ab81eff2b
Gerrit-Change-Number: 36568
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[S] Change in docker-playground[master]: ttcn3-asterisk: Configure AMI
Attention is currently required from: osmith, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36561?usp=email ) Change subject: ttcn3-asterisk: Configure AMI .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I590d89e9173b0372611790d4178747e28a1215d1 Gerrit-Change-Number: 36561 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 16 Apr 2024 11:12:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmo-ttcn3-hacks[master]: asterisk: Implement and test SIP Digest Authorization
Attention is currently required from: fixeria, laforge, osmith, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36532?usp=email ) Change subject: asterisk: Implement and test SIP Digest Authorization .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib469f1906927a3f246876040086ff115fbf4c032 Gerrit-Change-Number: 36532 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 08 Apr 2024 15:44:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: asterisk: Add missing 0-digit prefix in user
Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36531?usp=email ) Change subject: asterisk: Add missing 0-digit prefix in user .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia12552cf70c4c0f2c71cd9d5b70c608c883fb170 Gerrit-Change-Number: 36531 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 08 Apr 2024 15:34:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmo-mgw[master]: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io
Attention is currently required from: dexter, fixeria, laforge, neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email ) Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8471960d5d8088a70cf105f2f40dfa5d5458169a Gerrit-Change-Number: 36363 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: dexter Gerrit-Comment-Date: Tue, 02 Apr 2024 13:39:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-mgw[master]: Change msgb ownership in processing of received msgb
Attention is currently required from: dexter, laforge, neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email ) Change subject: Change msgb ownership in processing of received msgb .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6a331f3c6b2eb51ea312ac6ef8c357185ddb79cf Gerrit-Change-Number: 36361 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: laforge Gerrit-Attention: dexter Gerrit-Comment-Date: Wed, 20 Mar 2024 12:51:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli.c: Handle read / recvfrom error and close connection
Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email ) Change subject: stream_cli.c: Handle read / recvfrom error and close connection .. Patch Set 1: (2 comments) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36354/comment/adbcef04_2249e1dd PS1, Line 453: LOGSCLI(cli, LOGL_INFO, "received result %d in response to read\n", res); > LOGL_NOTICE or ERROR Done https://gerrit.osmocom.org/c/libosmo-netif/+/36354/comment/7c7948df_aebba322 PS1, Line 508: LOGSCLI(cli, LOGL_INFO, "received result %d in response to recvmsg\n", res); > LOGL_NOTICE or ERROR Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I55426de6b49cb4cb0797e50dfeae11f2efc29b15 Gerrit-Change-Number: 36354 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 20 Mar 2024 11:49:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli.c: Handle read / recvfrom error and close connection
Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: stream_cli.c: Handle read / recvfrom error and close connection .. stream_cli.c: Handle read / recvfrom error and close connection If read or recvfrom fails or returns 0, the connection must be closed. This is already done when a write / send fails. In both cases the disconnect callback is called to notify the user's client. Not handling the error may cause an infinite loop of read or recvfrom failures. Related: OS#6405 Change-Id: I55426de6b49cb4cb0797e50dfeae11f2efc29b15 --- M src/stream_cli.c 1 file changed, 28 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/54/36354/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I55426de6b49cb4cb0797e50dfeae11f2efc29b15 Gerrit-Change-Number: 36354 Gerrit-PatchSet: 2 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[S] Change in libosmocore[master]: osmo_io_uring: Run check of tests/osmo_io with io_uring also
Attention is currently required from: daniel, jolly, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: osmo_io_uring: Run check of tests/osmo_io with io_uring also .. osmo_io_uring: Run check of tests/osmo_io with io_uring also Related: OS#5751 Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 --- M configure.ac M debian/rules M tests/Makefile.am M tests/testsuite.at 4 files changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/35984/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 Gerrit-Change-Number: 35984 Gerrit-PatchSet: 10 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: osmith Gerrit-CC: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: stream_cli.c: Handle read / recvfrom error and close connection
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email )
Change subject: stream_cli.c: Handle read / recvfrom error and close connection
..
stream_cli.c: Handle read / recvfrom error and close connection
If read or recvfrom fails or returns 0, the connection must be closed.
This is already done when a write / send fails. In both cases the
disconnect callback is called to notify the user's client.
Not handling the error may cause an infinite loop of read or recvfrom
failures.
Related: OS#6405
Change-Id: I55426de6b49cb4cb0797e50dfeae11f2efc29b15
---
M src/stream_cli.c
1 file changed, 28 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/54/36354/1
diff --git a/src/stream_cli.c b/src/stream_cli.c
index fa43a22..4fbde07 100644
--- a/src/stream_cli.c
+++ b/src/stream_cli.c
@@ -449,9 +449,13 @@
stream_cli_handle_connecting(cli, res);
break;
case STREAM_CLI_STATE_CONNECTED:
- if (res == 0)
+ if (res <= 0) {
+ LOGSCLI(cli, LOGL_INFO, "received result %d in response
to read\n", res);
osmo_stream_cli_reconnect(cli);
- else if (cli->iofd_read_cb)
+ msgb_free(msg);
+ break;
+ }
+ if (cli->iofd_read_cb)
cli->iofd_read_cb(cli, msg);
else
msgb_free(msg);
@@ -500,8 +504,12 @@
stream_cli_handle_connecting(cli, res);
break;
case STREAM_CLI_STATE_CONNECTED:
- if (res == 0)
+ if (res <= 0) {
+ LOGSCLI(cli, LOGL_INFO, "received result %d in response
to recvmsg\n", res);
osmo_stream_cli_reconnect(cli);
+ msgb_free(msg);
+ break;
+ }
/* Forward message to read callback, also if the connection
failed. */
if (cli->iofd_read_cb)
cli->iofd_read_cb(cli, msg);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I55426de6b49cb4cb0797e50dfeae11f2efc29b15
Gerrit-Change-Number: 36354
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[M] Change in osmo-bts[master]: osmo-bts-virtual: Port over to osmo_io
Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email ) Change subject: osmo-bts-virtual: Port over to osmo_io .. Patch Set 2: (2 comments) File src/osmo-bts-virtual/scheduler_virtbts.c: https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/25c52194_5fba2e99 PS2, Line 105: else if (rc == 0) > This is not `read()`, but `send()` code path. […] Ok, I commented the wrong file. File src/osmo-bts-virtual/virtual_um.c: https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/bef71d62_ac23a7ae PS2, Line 53: (rc == 0) I meant this file when I said: If the socket dies, not handling of rc <= 0 will result in an infinite loop of read events. This is UDP socket can it die? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icfe42da00fd446c38090055e2baa5d5e0ae5b70c Gerrit-Change-Number: 36317 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: jolly Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 19 Mar 2024 12:56:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-bts[master]: osmo-bts-virtual: Port over to osmo_io
Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email ) Change subject: osmo-bts-virtual: Port over to osmo_io .. Patch Set 2: (1 comment) File src/osmo-bts-virtual/scheduler_virtbts.c: https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/c281e135_fbfb82c1 PS2, Line 105: else if (rc == 0) > why is this removed? because it cannot happen anymore right? If the socket dies, not handling of rc <= 0 will result in an infinite loop of read events. This is UDP socket can it die?a -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icfe42da00fd446c38090055e2baa5d5e0ae5b70c Gerrit-Change-Number: 36317 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: jolly Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 19 Mar 2024 11:39:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: bts: also test TCH/A[FH]S in TC_speech_no_rtp_tch[fh]
Attention is currently required from: fixeria, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36257?usp=email ) Change subject: bts: also test TCH/A[FH]S in TC_speech_no_rtp_tch[fh] .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c7f91034079169c40c4f20966d9f5fb7c855b27 Gerrit-Change-Number: 36257 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 18 Mar 2024 08:52:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: Make {write,sendto,sendmsg} completion callback optional
Attention is currently required from: laforge.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/36316?usp=email )
Change subject: osmo_io: Make {write,sendto,sendmsg} completion callback
optional
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0c071a29e508884bac331ada5e510bbfcf440bbf
Gerrit-Change-Number: 36316
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: jolly
Gerrit-Attention: laforge
Gerrit-Comment-Date: Mon, 18 Mar 2024 08:44:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[L] Change in libosmocore[master]: osmo_io: Massive improvement of API documentation
Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email ) Change subject: osmo_io: Massive improvement of API documentation .. Patch Set 4: (1 comment) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/c83f356c_0119a178 PS4, Line 73: differnent typo: different -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c Gerrit-Change-Number: 36288 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 18 Mar 2024 08:42:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[M] Change in mncc-python[master]: Update MNCC with LLC+HLC support
Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/36321?usp=email ) Change subject: Update MNCC with LLC+HLC support .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/36321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: Ic318656b778ed1ce115d8e60b0dce4ef75ed0a2c Gerrit-Change-Number: 36321 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: fixeria Gerrit-Reviewer: jolly Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 18 Mar 2024 08:13:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: ttcn3: add ttcn3-stp-test-io_uring
Attention is currently required from: osmith. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36271?usp=email ) Change subject: ttcn3: add ttcn3-stp-test-io_uring .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36271?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I996dee2f9ce27fcdd8771fa22379aa606192824d Gerrit-Change-Number: 36271 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Attention: osmith Gerrit-Comment-Date: Thu, 14 Mar 2024 12:24:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: Fix file descriptor that is passed to io_uring_register_eventfd()
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/36270?usp=email )
Change subject: Fix file descriptor that is passed to
io_uring_register_eventfd()
..
Fix file descriptor that is passed to io_uring_register_eventfd()
Fix Change-Id I03752c0114cc6fad0c31fff6fff43072f36a50a7
Change-Id: Ie085c7cb3eb57e0da10485be8f90208cb41b0073
---
M src/core/osmo_io_uring.c
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/36270/1
diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c
index e163ee0..569f150 100644
--- a/src/core/osmo_io_uring.c
+++ b/src/core/osmo_io_uring.c
@@ -108,7 +108,7 @@
io_uring_queue_exit(_ring.ring);
osmo_panic("failure registering io_uring-eventfd as osmo_fd:
%d\n", rc);
}
- rc = io_uring_register_eventfd(_ring.ring, rc);
+ rc = io_uring_register_eventfd(_ring.ring, evfd);
if (rc < 0) {
osmo_fd_unregister(_ring.event_ofd);
close(evfd);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36270?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie085c7cb3eb57e0da10485be8f90208cb41b0073
Gerrit-Change-Number: 36270
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode
Attention is currently required from: laforge.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/36259?usp=email )
Change subject: xua + ipa: Add support for I/O in OSMO_IO mode
..
Patch Set 1:
(1 comment)
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/36259/comment/7219876e_17621aa6
PS1, Line 645: switch (asp->cfg.proto) {
> it was my intention to re-submit the original patch. […]
I wonder why the patchset 9 was missing when merged:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/8..9
My tests yesterday were all made with that.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36259?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ia1910f3b99d918ec2a34d5304c3f40ba015c25c9
Gerrit-Change-Number: 36259
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly
Gerrit-Reviewer: pespin
Gerrit-Attention: laforge
Gerrit-Comment-Date: Wed, 13 Mar 2024 14:34:11 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly
Comment-In-Reply-To: laforge
Gerrit-MessageType: comment
[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode
Attention is currently required from: laforge.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/36259?usp=email )
Change subject: xua + ipa: Add support for I/O in OSMO_IO mode
..
Patch Set 1:
(1 comment)
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/36259/comment/cca37761_91b0a873
PS1, Line 645: switch (asp->cfg.proto) {
In the previous patch (before reverting it) the disconnect callback was
registered:
osmo_stream_cli_set_disconnect_cb(asp->client, xua_cli_close_and_reconnect);
Is this not required anymore?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36259?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ia1910f3b99d918ec2a34d5304c3f40ba015c25c9
Gerrit-Change-Number: 36259
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly
Gerrit-Reviewer: pespin
Gerrit-Attention: laforge
Gerrit-Comment-Date: Wed, 13 Mar 2024 12:14:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: jobs/ttcn3: add testsuites with io_uring
Attention is currently required from: osmith. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36258?usp=email ) Change subject: jobs/ttcn3: add testsuites with io_uring .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8eb3f4fdfe54268d3b623d88c8746f5395ba509d Gerrit-Change-Number: 36258 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Attention: osmith Gerrit-Comment-Date: Wed, 13 Mar 2024 10:48:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-mgw[master]: migrate mgcp_client from osmo_wqueue to osmo_io
Attention is currently required from: dexter, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36142?usp=email ) Change subject: migrate mgcp_client from osmo_wqueue to osmo_io .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I766224da4691695c023d4d08d042a4bbeba05e47 Gerrit-Change-Number: 36142 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: jolly Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 08 Mar 2024 08:37:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Do not try to send msg, if socket is disconnected
jolly has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email ) Change subject: stream_cli: Do not try to send msg, if socket is disconnected .. Abandoned This patch is not required, as it is allowed to send a message before connection is estabished. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8 Gerrit-Change-Number: 36123 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: daniel Gerrit-CC: pespin Gerrit-MessageType: abandon
[S] Change in libosmocore[master]: osmo_io: Log error message in case call-backs incompatible with mode
Attention is currently required from: daniel, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36190?usp=email ) Change subject: osmo_io: Log error message in case call-backs incompatible with mode .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I50ba6a76c0144f249d67488874a6c4edf01ec6f2 Gerrit-Change-Number: 36190 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 07 Mar 2024 15:12:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: Guard osmo_iofd_register() with invalid file descriptor
Attention is currently required from: daniel, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36188?usp=email ) Change subject: osmo_io: Guard osmo_iofd_register() with invalid file descriptor .. Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/36188/comment/14c9c6e6_1371b69e PS1, Line 9: Let's return an error if both osmo_iofd_setup() and osmo_iofd_register() : are called with an invalid file descriptor like -1. > at osmo_iofd_setup() time it is legal to pass -1. […] Ah ok. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie4561cefad82e1bf5d37dd1a4815f4bc805343e6 Gerrit-Change-Number: 36188 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 07 Mar 2024 15:11:09 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly Comment-In-Reply-To: laforge Gerrit-MessageType: comment
[M] Change in osmo-mgw[master]: migrate mgcp_client from osmo_wqueue to osmo_io
Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36142?usp=email ) Change subject: migrate mgcp_client from osmo_wqueue to osmo_io .. Patch Set 1: (3 comments) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36142/comment/43061d55_93e5b21f PS1, Line 731: mgcp_do_read mgcp_read_cb https://gerrit.osmocom.org/c/osmo-mgw/+/36142/comment/cf062976_225b8977 PS1, Line 790: errno uring IO does not set errno. "res" is used instead and carries -errno. This also applies to poll based osmo_io. https://gerrit.osmocom.org/c/osmo-mgw/+/36142/comment/3f3d2175_2883a617 PS1, Line 826: errno dito. see also https://gerrit.osmocom.org/c/libosmocore/+/35984 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I766224da4691695c023d4d08d042a4bbeba05e47 Gerrit-Change-Number: 36142 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: jolly Gerrit-Attention: laforge Gerrit-Comment-Date: Thu, 07 Mar 2024 15:05:38 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on write error
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/36200?usp=email )
Change subject: osmo_io_poll: Use -errno as result on write error
..
osmo_io_poll: Use -errno as result on write error
This was done for read error in a previous patch. This is required
because osmo_io_uring does not support errno, instead it uses the
result code. To have a unified API, set the result code equally.
Related: OS#5751
Change-Id: I405094449a6644db37534757f2fbccbcff982f23
---
M src/core/osmo_io_poll.c
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/00/36200/1
diff --git a/src/core/osmo_io_poll.c b/src/core/osmo_io_poll.c
index 2e726d9..fae552c 100644
--- a/src/core/osmo_io_poll.c
+++ b/src/core/osmo_io_poll.c
@@ -84,7 +84,7 @@
struct iofd_msghdr *msghdr = iofd_txqueue_dequeue(iofd);
if (msghdr) {
rc = sendmsg(ofd->fd, >hdr, msghdr->flags);
- iofd_handle_send_completion(iofd, rc, msghdr);
+ iofd_handle_send_completion(iofd, (rc < 0 && errno > 0)
? -errno : rc, msghdr);
} else {
/* Socket is writable, but we have no data to send. A
non-blocking/async
connect() is signalled this way. */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36200?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I405094449a6644db37534757f2fbccbcff982f23
Gerrit-Change-Number: 36200
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[S] Change in libosmocore[master]: osmo_io: Guard osmo_iofd_register() with invalid file descriptor
Attention is currently required from: daniel, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36188?usp=email ) Change subject: osmo_io: Guard osmo_iofd_register() with invalid file descriptor .. Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/36188/comment/98d7b5a3_bcad24fa PS1, Line 9: Let's return an error if both osmo_iofd_setup() and osmo_iofd_register() : are called with an invalid file descriptor like -1. I see the check for osmo_iofd_register(), but not for osmo_iofd_setup() in this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie4561cefad82e1bf5d37dd1a4815f4bc805343e6 Gerrit-Change-Number: 36188 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 07 Mar 2024 14:15:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: Log error message in case call-backs incompatible with mode
Attention is currently required from: daniel, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36190?usp=email ) Change subject: osmo_io: Log error message in case call-backs incompatible with mode .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I50ba6a76c0144f249d67488874a6c4edf01ec6f2 Gerrit-Change-Number: 36190 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 07 Mar 2024 14:09:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: Don't pretend to support backends without close_cb
Attention is currently required from: daniel, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36191?usp=email ) Change subject: osmo_io: Don't pretend to support backends without close_cb .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id285f1d7b73ae5805aa618897016ae8b73bf892d Gerrit-Change-Number: 36191 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 07 Mar 2024 14:07:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: avoid OSMO_ASSERT one each API call
Attention is currently required from: daniel, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36192?usp=email ) Change subject: osmo_io: avoid OSMO_ASSERT one each API call .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9005ac6bb260236c88670373816bf7ee6a627f1 Gerrit-Change-Number: 36192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 07 Mar 2024 14:06:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: Avoid implementing non-existant situations
Attention is currently required from: daniel, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36193?usp=email ) Change subject: osmo_io: Avoid implementing non-existant situations .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0077151eb676f61320b3fa2124448852aa8fd4a9 Gerrit-Change-Number: 36193 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 07 Mar 2024 14:03:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance
Attention is currently required from: daniel, dexter, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email ) Change subject: stream_cli: Correctly setup and free osmo_io client instance .. Patch Set 8: (1 comment) Patchset: PS7: > but why must the iofd be freed? the entire API design is done to facilitate > the re-use of an iofd. […] osmo_iofd_setup() creates a new osmi_io instance. In order to support re-use of iofd, it must be split into osmo_iofd_alloc() and osmo_iofd_setup(). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Attention: dexter Gerrit-Comment-Date: Thu, 07 Mar 2024 13:21:54 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly Comment-In-Reply-To: laforge Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email )
Change subject: xua + ipa: Add support for I/O in OSMO_IO mode
..
Patch Set 9:
(1 comment)
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/64c6fa71_42b7d877
PS9, Line 867: if (rc < 0) {
> How is this supposed to happen now with osmo_io? It's still not clear to me.
> […]
Yes, it is done automatically. See stream_srv_iofd_read_cb() at stream_srv.c at
libosmo-netif. It calls osmo_stream_srv_destroy(). Because the callback
function is set, ss7_asp_xua_srv_conn_closed_cb will be closed in this case.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369
Gerrit-Change-Number: 35070
Gerrit-PatchSet: 9
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-CC: jolly
Gerrit-Comment-Date: Thu, 07 Mar 2024 09:59:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance
Attention is currently required from: daniel, dexter, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email ) Change subject: stream_cli: Correctly setup and free osmo_io client instance .. Patch Set 8: (1 comment) Patchset: PS7: > First, the iofd must be freed and cannot be reused, otherwise it will not > function correctly. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Attention: dexter Gerrit-Comment-Date: Thu, 07 Mar 2024 09:30:34 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly Comment-In-Reply-To: laforge Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance
Attention is currently required from: daniel, dexter, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email ) Change subject: stream_cli: Correctly setup and free osmo_io client instance .. Patch Set 7: (1 comment) Patchset: PS7: > I think the question daniel is racing:In the old code (pre > 7e6d2e0f99ff095f4714f03b1ed991d6c9cb9c61) […] First, the iofd must be freed and cannot be reused, otherwise it will not function correctly. And yes, if osmo_stream_cli_open() is called again without closing, it runs into a memory leak. To guard against that, I added osmo_stream_cli_close_iofd() before calling osmo_iofd_setup(). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Attention: dexter Gerrit-Comment-Date: Thu, 07 Mar 2024 09:30:18 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly Comment-In-Reply-To: laforge Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance
Attention is currently required from: daniel, dexter, jolly, laforge, pespin. Hello Jenkins Builder, daniel, dexter, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+1 by dexter, Code-Review+1 by laforge, Code-Review+1 by pespin, Code-Review-1 by daniel, Verified+1 by Jenkins Builder Change subject: stream_cli: Correctly setup and free osmo_io client instance .. stream_cli: Correctly setup and free osmo_io client instance Free osmo_io instance when calling osmo_stream_cli_close(). Also free osmo_io instance when calling osmo_stream_cli_open() if not freed, to prevent memory leaks. osmo_iofd_notify_connected() must be called before any registration of read or write, because osmo_io_iouring does not allow this. Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 --- M src/stream_cli.c 1 file changed, 22 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/79/35979/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit
Attention is currently required from: jolly, pespin.
Hello Jenkins Builder, daniel, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: stream_{client,server} example: Cleanup on exit
..
stream_{client,server} example: Cleanup on exit
In order to detect memory leaks while debugging, stream server/client
and keyboard is closed on exit.
Related: OS#5753
Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
---
M examples/stream-client.c
M examples/stream-server.c
2 files changed, 34 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/24/36124/8
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 8
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-CC: pespin
Gerrit-Attention: jolly
Gerrit-Attention: pespin
Gerrit-MessageType: newpatchset
[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode
Attention is currently required from: daniel, fixeria, laforge, pespin.
jolly has uploaded a new patch set (#9) to the change originally created by
laforge. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email )
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: xua + ipa: Add support for I/O in OSMO_IO mode
..
xua + ipa: Add support for I/O in OSMO_IO mode
This switches osmo_stream_{cli,srv} over to using the OSMO_IO
mode instead of the classic OSMO_FD mode. The difference is that
we no longer read/write directly to a file descriptor, but we pass
message buffers to/from the library.
This in turn allows the library to use more efficient I/O mechanisms
as osmo_io backend, for example the Linux kernel io_uring.
Change-Id: I7d02037990f4af405839309510dc6c04e36c3369
Depends: libosmo-netif.git I6cf5bad5f618e71c80017960c38009b089dbd6a1
Depends: libosmocore.git I89eb519b22d21011d61a7855b2364bc3c295df82
Closes: OS#5752
---
M TODO-RELEASE
M src/osmo_ss7_asp.c
M src/osmo_ss7_xua_srv.c
M src/ss7_internal.h
4 files changed, 92 insertions(+), 232 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/70/35070/9
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369
Gerrit-Change-Number: 35070
Gerrit-PatchSet: 9
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: pespin
Gerrit-CC: fixeria
Gerrit-CC: jolly
Gerrit-Attention: laforge
Gerrit-Attention: pespin
Gerrit-Attention: fixeria
Gerrit-Attention: daniel
Gerrit-MessageType: newpatchset
[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode
Attention is currently required from: daniel, fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email ) Change subject: xua + ipa: Add support for I/O in OSMO_IO mode .. Patch Set 8: (4 comments) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/8c8d4adb_e50d58dc PS3, Line 904: xua_cli_close_and_reconnect(conn); > yeah, I think the problem is that we are not using the disconnect_cb offered > by libosmo-netif here. […] This is solved in my patchset. The disconnect_cb will be registred. This was tested and is working. File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/818ee53d_2ecfd562 PS8, Line 657: osmo_stream_cli_set_segmentation_cb(asp->client, xua_segmentation_cb); > I'm happy to rename it to xua_tcp_segemntation_cb, which is more in line with > m3ua_tcp_* names in ot […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/9940b836_238cac69 PS8, Line 663: osmo_stream_cli_set_read_cb2(asp->client, xua_cli_read_cb); > good catch. I didn't think of restart/reconfigure. Done https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/39aeab0f_9ca1ee85 PS8, Line 833: } > "@jolly is working on that" means a new patch version solving this regression > will be submitted and […] This is solved in my patchset. The disconnect_cb will be registred. This was tested and is working. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369 Gerrit-Change-Number: 35070 Gerrit-PatchSet: 8 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: jolly Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 06 Mar 2024 15:14:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Call read callback even if connection failed
jolly has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email ) Change subject: stream_cli: Call read callback even if connection failed .. Abandoned Not required anymore. User must register disconnect_cb. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f Gerrit-Change-Number: 36020 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: abandon
[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance
Attention is currently required from: daniel, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email ) Change subject: stream_cli: Correctly setup and free osmo_io client instance .. Patch Set 7: (1 comment) Patchset: PS7: > today I also saw some io_fd memory leak when running the STP_Tests against > osmo-stp. […] The memory leak does happen, if all of my patches in gerrit (libosmo-netif) are applied. The iofd must be freed -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 06 Mar 2024 14:59:30 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: osmo_stream_cli_write(): fix double-free of msgb
Attention is currently required from: daniel, fixeria, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email ) Change subject: osmo_stream_cli_write(): fix double-free of msgb .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I954678acd90593e5311d22a10033c7741f280be3 Gerrit-Change-Number: 36159 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Tue, 05 Mar 2024 10:16:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Do not try to send msg, if socket is disconnected
Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: stream_cli: Do not try to send msg, if socket is disconnected .. stream_cli: Do not try to send msg, if socket is disconnected It is ok to send messages before or after client connection has been established using osmo_fd or osmo_io. Both implementations use a TX queue. In case of a connection failure, the socket is closed and messages will be dropped until the socket is created again. Related: OS#5753 Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8 --- M src/stream_cli.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/23/36123/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8 Gerrit-Change-Number: 36123 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: stream_cli: Do not try to send msg, if socket is disconnected
Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email )
Change subject: stream_cli: Do not try to send msg, if socket is disconnected
..
Patch Set 6:
(1 comment)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36123/comment/c40118a4_37d961d4
PS4, Line 998: if (cli->state != STREAM_CLI_STATE_CONNECTED) {
> There is a TX queue (iofd->tx_queue). Maybe we can use that one and don't
> need this patch. […]
Yes, it is possible to send messages before the socket is connected.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8
Gerrit-Change-Number: 36123
Gerrit-PatchSet: 6
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-CC: pespin
Gerrit-Attention: laforge
Gerrit-Attention: pespin
Gerrit-Comment-Date: Mon, 04 Mar 2024 12:56:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly
Comment-In-Reply-To: laforge
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Do not try to send msg, if not connected
Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email )
Change subject: stream_cli: Do not try to send msg, if not connected
..
Patch Set 5:
(1 comment)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36123/comment/ddd3ef4a_bc783b61
PS4, Line 998: if (cli->state != STREAM_CLI_STATE_CONNECTED) {
> But this is really breaking the behavior of the API, and it may have
> undesired consequences. […]
There is a TX queue (iofd->tx_queue). Maybe we can use that one and don't need
this patch.
I had a crash when the example client is unconnected and I typed something. I
need to check why this happens.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8
Gerrit-Change-Number: 36123
Gerrit-PatchSet: 5
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-CC: pespin
Gerrit-Attention: laforge
Gerrit-Attention: pespin
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:56:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit
Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email )
Change subject: stream_{client,server} example: Cleanup on exit
..
Patch Set 5:
(1 comment)
File examples/stream-client.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/bfb207c4_97cd35a1
PS4, Line 176: signal(SIGINT, SIG_DFL);
> you probably want to do this inside the sig_handler, to kill the program
> quickly if CTRL+C is presse […]
General a good idea! If exit hangs for some reason, a second CTRL+C will end
the application.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 5
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Attention: pespin
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:45:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance
Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email ) Change subject: stream_cli: Correctly setup and free osmo_io client instance .. Patch Set 7: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/35979/comment/e88338a7_7dafd830 PS6, Line 960: osmo_iofd_notify_connected(cli->iofd); > is this triggering any callback which could do undersired stuff to due > segmentation not yet set belo […] It does not perform any notification at this point. It only enables notification. The callback is called later, when the socket is connected or failed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 04 Mar 2024 10:45:18 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_cli: Call read callback even if connection failed
Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email ) Change subject: stream_cli: Call read callback even if connection failed .. Patch Set 6: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36020/comment/dc2c6213_4d7c5f2a PS5, Line 447: /* Forward message to read callback, also if the connection failed. */ > I already though on the previous patch: Shouldn't this callback happen > *before* reconnecting? Or it' […] Yes, it is called at the end to prevent a use-after-free bug. The user may decide to destroy the cli instance. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f Gerrit-Change-Number: 36020 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 04 Mar 2024 10:45:14 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit
Attention is currently required from: jolly.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: stream_{client,server} example: Cleanup on exit
..
stream_{client,server} example: Cleanup on exit
In order to detect memory leaks while debugging, stream server/client
and keyboard is closed on exit.
Related: OS#5753
Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
---
M examples/stream-client.c
M examples/stream-server.c
2 files changed, 34 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/24/36124/5
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 5
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Attention: jolly
Gerrit-MessageType: newpatchset
[S] Change in libosmocore[master]: osmo_io_uring: Check if osmo_fd_register fails at iofd_uring_notify_c...
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/36132?usp=email )
Change subject: osmo_io_uring: Check if osmo_fd_register fails at
iofd_uring_notify_connected()
..
osmo_io_uring: Check if osmo_fd_register fails at iofd_uring_notify_connected()
If it fails, do not set the IOFD_FLAG_NOTIFY_CONNECTED flag and log an
error message.
Closes: Coverity CID#349579
Change-Id: I34e8cc9a2b9df0c624841e5f9268a15c32418da1
---
M src/core/osmo_io_uring.c
1 file changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/36132/1
diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c
index cb636da..b174b22 100644
--- a/src/core/osmo_io_uring.c
+++ b/src/core/osmo_io_uring.c
@@ -496,8 +496,10 @@
if (!IOFD_FLAG_ISSET(iofd, IOFD_FLAG_NOTIFY_CONNECTED)) {
osmo_fd_setup(>u.uring.connect_ofd, iofd->fd,
OSMO_FD_WRITE,
iofd_uring_connected_cb, iofd, 0);
- osmo_fd_register(>u.uring.connect_ofd);
- IOFD_FLAG_SET(iofd, IOFD_FLAG_NOTIFY_CONNECTED);
+ if (osmo_fd_register(>u.uring.connect_ofd) < 0)
+ LOGPIO(iofd, LOGL_ERROR, "Failed to register FD
for connect event.\n");
+ else
+ IOFD_FLAG_SET(iofd, IOFD_FLAG_NOTIFY_CONNECTED);
}
} else
iofd_uring_write_enable(iofd);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36132?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I34e8cc9a2b9df0c624841e5f9268a15c32418da1
Gerrit-Change-Number: 36132
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[S] Change in libosmocore[master]: osmo_io: do check_mode_callback_compat() only if ioops is set at osmo...
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/36131?usp=email ) Change subject: osmo_io: do check_mode_callback_compat() only if ioops is set at osmo_iofd_setup() .. osmo_io: do check_mode_callback_compat() only if ioops is set at osmo_iofd_setup() Setting ioops is optional when calling osmo_iofd_setup(). If it is not set, do not call check_mode_callback_compat() to check for compatibility. Closes: Coverity CID#349578 Change-Id: I1e25f3e420f25a44cbf73a4da9a498b7561e9ddd --- M src/core/osmo_io.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/36131/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 33466e5..5a5e05c 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -619,7 +619,7 @@ return NULL; } - if (!check_mode_callback_compat(mode, ioops)) + if (ioops && !check_mode_callback_compat(mode, ioops)) return NULL; iofd = talloc_zero(ctx, struct osmo_io_fd); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1e25f3e420f25a44cbf73a4da9a498b7561e9ddd Gerrit-Change-Number: 36131 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-MessageType: newchange
[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit
Attention is currently required from: jolly.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: stream_{client,server} example: Cleanup on exit
..
stream_{client,server} example: Cleanup on exit
In order to detect memory leaks while debugging, stream server/client
and keyboard is closed on exit.
Related: OS#5753
Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
---
M examples/stream-client.c
M examples/stream-server.c
2 files changed, 36 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/24/36124/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 4
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: jolly
Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: stream_cli: Do not try to send msg, if not connected
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: stream_cli: Do not try to send msg, if not connected .. stream_cli: Do not try to send msg, if not connected Related: OS#5753 Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8 --- M src/stream_cli.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/23/36123/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8 Gerrit-Change-Number: 36123 Gerrit-PatchSet: 4 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: stream_cli: Do not try to send msg, if not connected
Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email ) Change subject: stream_cli: Do not try to send msg, if not connected .. Patch Set 3: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36123/comment/37356515_8f5c4ada PS3, Line 999: LOGSCLI(cli, LOGL_ERROR, "Not connected with srv.\n"); > I think this message is not really telling the user anything useful. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8 Gerrit-Change-Number: 36123 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Attention: laforge Gerrit-Comment-Date: Fri, 01 Mar 2024 09:37:23 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream: Initialize outmsg in stream_iofd_sctp_send_msgb()
jolly has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36122?usp=email ) Change subject: stream: Initialize outmsg in stream_iofd_sctp_send_msgb() .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If4c8239c17deceeb56f64ebaff435df1e9d782cd Gerrit-Change-Number: 36122 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-MessageType: abandon
[S] Change in libosmocore[master]: Make osmo-io compile without libsctp support (--disable-libsctp)
jolly has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36056?usp=email ) Change subject: Make osmo-io compile without libsctp support (--disable-libsctp) .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ief8ca40c0e85efe340eaecb866a10f76ac2bfc98 Gerrit-Change-Number: 36056 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: abandon
[S] Change in libosmocore[master]: osmo_io: Assign const name when stealing TX msg from iofd ctx
Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36121?usp=email ) Change subject: osmo_io: Assign const name when stealing TX msg from iofd ctx .. Patch Set 1: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/36121/comment/198ef5cd_4ead9ffd PS1, Line 339: talloc_set_name(msg, "osmo_io_rx_msgb"); > Yeah, just set it to some const string. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib8dae924fa2d94a7f636136ba7279b965a18cf5b Gerrit-Change-Number: 36121 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Thu, 29 Feb 2024 15:34:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io: Assign const name when stealing TX msg from iofd ctx
Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36121?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: osmo_io: Assign const name when stealing TX msg from iofd ctx .. osmo_io: Assign const name when stealing TX msg from iofd ctx All TX messages are moved from iofd instance to the user's context. iofd may be destroyed, but the message is still available to the user. To prevent a use-after-free bug, the context name must be changed from iofd->name to a constant that does not belong to iofd. Change-Id: Ib8dae924fa2d94a7f636136ba7279b965a18cf5b --- M src/core/osmo_io.c 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/21/36121/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib8dae924fa2d94a7f636136ba7279b965a18cf5b Gerrit-Change-Number: 36121 Gerrit-PatchSet: 2 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: osmo_io: make use of osmo_iofd_get_ioops()
Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36077?usp=email ) Change subject: osmo_io: make use of osmo_iofd_get_ioops() .. Patch Set 4: (1 comment) Patchset: PS4: reverting back to patch set #1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id3cb11bc299faa79d980de8abc1980916d70 Gerrit-Change-Number: 36077 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly Gerrit-Attention: laforge Gerrit-Comment-Date: Thu, 29 Feb 2024 12:58:52 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: osmo_io: make use of osmo_iofd_get_ioops()
Attention is currently required from: jolly, laforge. jolly has uploaded a new patch set (#4) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36077?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: osmo_io: make use of osmo_iofd_get_ioops() .. osmo_io: make use of osmo_iofd_get_ioops() This avoids resetting the callbacks with the wrong ones in the SCTP case. Change-Id: Id3cb11bc299faa79d980de8abc1980916d70 --- M TODO-RELEASE M src/stream_cli.c M src/stream_srv.c 3 files changed, 15 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/77/36077/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id3cb11bc299faa79d980de8abc1980916d70 Gerrit-Change-Number: 36077 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance
Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: stream_cli: Correctly setup and free osmo_io client instance .. stream_cli: Correctly setup and free osmo_io client instance Completely free and setup osmo_io again when reconnecting. osmo_iofd_notify_connected() must be called before any registration of read or write, because osmo_io_iouring does not allow this. Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 --- M src/stream_cli.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/79/35979/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: osmo_io: make use of osmo_iofd_get_ioops()
Attention is currently required from: jolly, laforge. jolly has uploaded a new patch set (#3) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36077?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: osmo_io: make use of osmo_iofd_get_ioops() .. osmo_io: make use of osmo_iofd_get_ioops() This avoids resetting the callbacks with the wrong ones in the SCTP case. Change-Id: Id3cb11bc299faa79d980de8abc1980916d70 --- M src/stream_cli.c M src/stream_srv.c 2 files changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/77/36077/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id3cb11bc299faa79d980de8abc1980916d70 Gerrit-Change-Number: 36077 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance
Attention is currently required from: jolly, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email ) Change subject: stream_cli: Correctly setup and free osmo_io client instance .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 5 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Comment-Date: Thu, 29 Feb 2024 08:28:44 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_{cli,srv}: Fix memory leak, if sending a message fails
Attention is currently required from: jolly, laforge.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/35926?usp=email )
Change subject: stream_{cli,srv}: Fix memory leak, if sending a message fails
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35926?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I627a71b4f0183cd83835c328a5cdd67a413ae614
Gerrit-Change-Number: 35926
Gerrit-PatchSet: 5
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Attention: jolly
Gerrit-Attention: laforge
Gerrit-Comment-Date: Thu, 29 Feb 2024 08:28:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_{cli,srv}: Free received messages when not forwarded
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36125?usp=email )
Change subject: stream_{cli,srv}: Free received messages when not forwarded
..
stream_{cli,srv}: Free received messages when not forwarded
If a message is not forwarded (to a read callback function, it must be
freed, to prevent memory leaks.
The message musst be freed before calling osmo_stream_srv_destroy() or
stream_cli_handle_connecting(), because within the function calls the
client/server instance may get destroyed and the message is 'owned' by
it. Calling msgb_free(msg) afterwards may result in double free bug.
Related: OS#5753
Change-Id: Ic043f11cdba0df9e0b78cac8db7206800098e0ba
---
M src/stream_cli.c
M src/stream_srv.c
2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/25/36125/1
diff --git a/src/stream_cli.c b/src/stream_cli.c
index f9e52a0..61fb4b7 100644
--- a/src/stream_cli.c
+++ b/src/stream_cli.c
@@ -439,6 +439,7 @@
switch (cli->state) {
case STREAM_CLI_STATE_CONNECTING:
+ msgb_free(msg);
stream_cli_handle_connecting(cli, res);
break;
case STREAM_CLI_STATE_CONNECTED:
@@ -447,6 +448,8 @@
/* Forward message to read callback, also if the connection
failed. */
if (cli->iofd_read_cb)
cli->iofd_read_cb(cli, msg);
+ else
+ msgb_free(msg);
break;
default:
osmo_panic("%s() called with unexpected state %d\n", __func__,
cli->state);
@@ -488,6 +491,7 @@
switch (cli->state) {
case STREAM_CLI_STATE_CONNECTING:
+ msgb_free(msg);
stream_cli_handle_connecting(cli, res);
break;
case STREAM_CLI_STATE_CONNECTED:
@@ -496,6 +500,8 @@
/* Forward message to read callback, also if the connection
failed. */
if (cli->iofd_read_cb)
cli->iofd_read_cb(cli, msg);
+ else
+ msgb_free(msg);
break;
default:
osmo_panic("%s() called with unexpected state %d\n", __func__,
cli->state);
diff --git a/src/stream_srv.c b/src/stream_srv.c
index f82a9a0..852154a 100644
--- a/src/stream_srv.c
+++ b/src/stream_srv.c
@@ -562,6 +562,7 @@
if (OSMO_UNLIKELY(res <= 0)) {
/* This connection is dead, destroy it. */
+ msgb_free(msg);
osmo_stream_srv_destroy(conn);
} else {
if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) {
@@ -609,6 +610,7 @@
if (OSMO_UNLIKELY(res <= 0)) {
/* This connection is dead, destroy it. */
+ msgb_free(msg);
osmo_stream_srv_destroy(conn);
} else {
if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) {
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36125?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ic043f11cdba0df9e0b78cac8db7206800098e0ba
Gerrit-Change-Number: 36125
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[S] Change in libosmo-netif[master]: osmo_io: make use of osmo_iofd_get_ioops()
Attention is currently required from: laforge. jolly has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36077?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: osmo_io: make use of osmo_iofd_get_ioops() .. osmo_io: make use of osmo_iofd_get_ioops() This avoids resetting the callbacks with the wrong ones in the SCTP case. Change-Id: Id3cb11bc299faa79d980de8abc1980916d70 Depends: libosmocore.git Change-Id I03398c811b9534f50c6644b21eea89a04be29fb0 --- M src/stream_cli.c M src/stream_srv.c 2 files changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/77/36077/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id3cb11bc299faa79d980de8abc1980916d70 Gerrit-Change-Number: 36077 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[S] Change in libosmo-netif[master]: stream_cli: Do not try to send msg, if not connected
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email )
Change subject: stream_cli: Do not try to send msg, if not connected
..
stream_cli: Do not try to send msg, if not connected
Related: OS#5753
Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8
---
M src/stream_cli.c
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/23/36123/1
diff --git a/src/stream_cli.c b/src/stream_cli.c
index 3544e14..f9e52a0 100644
--- a/src/stream_cli.c
+++ b/src/stream_cli.c
@@ -995,6 +995,12 @@
OSMO_ASSERT(cli);
OSMO_ASSERT(msg);
+ if (cli->state != STREAM_CLI_STATE_CONNECTED) {
+ LOGSCLI(cli, LOGL_ERROR, "Not connected with srv.\n");
+ msgb_free(msg);
+ return;
+ }
+
switch (cli->mode) {
case OSMO_STREAM_MODE_OSMO_FD:
msgb_enqueue(>tx_queue, msg);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8
Gerrit-Change-Number: 36123
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email )
Change subject: stream_{client,server} example: Cleanup on exit
..
stream_{client,server} example: Cleanup on exit
In order to detect memory leaks while debugging, stream server/client
and keyboard is closed on exit.
Related: OS#5753
Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
---
M examples/stream-client.c
M examples/stream-server.c
2 files changed, 36 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/24/36124/1
diff --git a/examples/stream-client.c b/examples/stream-client.c
index 97aaa1c..d57dc12 100644
--- a/examples/stream-client.c
+++ b/examples/stream-client.c
@@ -32,9 +32,12 @@
static struct osmo_stream_cli *conn;
+static bool quit = false;
+
void sighandler(int foo)
{
LOGP(DSTREAMTEST, LOGL_NOTICE, "closing stream.\n");
+ quit = true;
exit(EXIT_SUCCESS);
}
@@ -162,9 +165,17 @@
exit(EXIT_FAILURE);
}
+ signal(SIGINT, sighandler);
+
LOGP(DSTREAMTEST, LOGL_NOTICE, "Entering main loop\n");
- while(1) {
+ while(!quit) {
osmo_select_main(0);
}
+
+ signal(SIGINT, SIG_DFL);
+
+ osmo_fd_unregister(kbd_ofd);
+
+ osmo_stream_cli_destroy(conn);
}
diff --git a/examples/stream-server.c b/examples/stream-server.c
index d0647b7..49d52a7 100644
--- a/examples/stream-server.c
+++ b/examples/stream-server.c
@@ -35,11 +35,12 @@
static struct osmo_stream_srv_link *srv;
static struct osmo_stream_srv *conn;
+bool quit = false;
void sighandler(int foo)
{
LOGP(DSTREAMTEST, LOGL_NOTICE, "closing STREAMSERVER.\n");
- exit(EXIT_SUCCESS);
+ quit = true;
}
int read_cb(struct osmo_stream_srv *conn, struct msgb *msg)
@@ -181,9 +182,17 @@
osmo_fd_setup(kbd_ofd, STDIN_FILENO, OSMO_FD_READ, kbd_cb, srv, 0);
osmo_fd_register(kbd_ofd);
+ signal(SIGINT, sighandler);
+
LOGP(DSTREAMTEST, LOGL_NOTICE, "Entering main loop on %s\n",
osmo_stream_srv_link_get_sockname(srv));
- while(1) {
+ while(!quit) {
osmo_select_main(0);
}
+
+ signal(SIGINT, SIG_DFL);
+
+ osmo_fd_unregister(kbd_ofd);
+
+ osmo_stream_srv_link_destroy(srv);
}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[S] Change in libosmo-netif[master]: stream: Initialize outmsg in stream_iofd_sctp_send_msgb()
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36122?usp=email )
Change subject: stream: Initialize outmsg in stream_iofd_sctp_send_msgb()
..
stream: Initialize outmsg in stream_iofd_sctp_send_msgb()
Uninitialized fields ont outmsg may cause undefined behaviour inside
subsequent function calls.
Related: OS#5753
Change-Id: If4c8239c17deceeb56f64ebaff435df1e9d782cd
---
M src/stream.c
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/22/36122/1
diff --git a/src/stream.c b/src/stream.c
index 409e3fe..f4755e0 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -326,7 +326,7 @@
*/
int stream_iofd_sctp_send_msgb(struct osmo_io_fd *iofd, struct msgb *msg, int
sendmsg_flags)
{
- struct msghdr outmsg;
+ struct msghdr outmsg = {};
char outcmsg[CMSG_SPACE(sizeof(struct sctp_sndrcvinfo))];
struct sctp_sndrcvinfo *sinfo;
struct cmsghdr *cmsg;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36122?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: If4c8239c17deceeb56f64ebaff435df1e9d782cd
Gerrit-Change-Number: 36122
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[S] Change in libosmocore[master]: osmo_io_uring: Run check of tests/osmo_io with io_uring also
Attention is currently required from: daniel, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email ) Change subject: osmo_io_uring: Run check of tests/osmo_io with io_uring also .. Patch Set 6: (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmocore/+/35984/comment/18ee800e_c556ea96 PS6, Line 535: AT_SKIP_IF([ test "$ENABLE_URING" != "yes" ]) > shouldn't this be = "yes"? […] AT_SKIP_IF will run the test, if the condition is false. if ENABLE_URING is "yes" this condition is false. i tested that with --disable-uring -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 Gerrit-Change-Number: 35984 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 29 Feb 2024 08:17:54 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: examples/stream-*: Add options, to set local/remote peer
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35927?usp=email ) Change subject: examples/stream-*: Add options, to set local/remote peer .. Patch Set 5: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/35927/comment/a8e3dc3d_429161df PS2, Line 12: remove > remote Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie6da55ef248436e521c5d8f21f8053356c46a114 Gerrit-Change-Number: 35927 Gerrit-PatchSet: 5 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 29 Feb 2024 08:17:43 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io_uring: Detach msghdr from iofd before calling iofd_handle_sen...
Attention is currently required from: daniel, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email ) Change subject: osmo_io_uring: Detach msghdr from iofd before calling iofd_handle_send_completion() .. Patch Set 9: (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/35982/comment/239e58ef_242b6b4b PS6, Line 200: * iofd_handle_send_completion() will free msghdr at the end. the previous callback function may destroy iofd. > Still waiting for this to be clarified. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia349f73de2145fa360b20dd40deb73a8ffc71f07 Gerrit-Change-Number: 35982 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Comment-Date: Thu, 29 Feb 2024 08:17:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in libosmocore[master]: osmo_io_poll: Declare local functions "static"
Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35983?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: osmo_io_poll: Declare local functions "static" .. osmo_io_poll: Declare local functions "static" Change-Id: I6ba88cd7bbd5b5ef42eb460679696f105c9158cb --- M src/core/osmo_io_poll.c 1 file changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/83/35983/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ba88cd7bbd5b5ef42eb460679696f105c9158cb Gerrit-Change-Number: 35983 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[S] Change in libosmocore[master]: osmo_io: Assign const name when stealing TX msg from iofd ctx
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/36121?usp=email )
Change subject: osmo_io: Assign const name when stealing TX msg from iofd ctx
..
osmo_io: Assign const name when stealing TX msg from iofd ctx
All TX messages are moved from iofd instance to the user's context.
iofd may be destroyed, but the message is still available to the user.
To prevent a use-after-free, the context name must be changed from
iofd->name to a constant that does not belong to iofd.
Change-Id: Ib8dae924fa2d94a7f636136ba7279b965a18cf5b
---
M src/core/osmo_io.c
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/21/36121/1
diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c
index 7ea959b..89690ae 100644
--- a/src/core/osmo_io.c
+++ b/src/core/osmo_io.c
@@ -334,7 +334,9 @@
* \param[in] hdr serialized msghdr containing state of completed I/O */
void iofd_handle_recv(struct osmo_io_fd *iofd, struct msgb *msg, int rc,
struct iofd_msghdr *hdr)
{
+ /* Steal the msg from iofd. Also assign const name, because iofd->name
will be freed when iofd is destroyed. */
talloc_steal(iofd->msgb_alloc.ctx, msg);
+ talloc_set_name(msg, "osmo_io_rx_msgb");
switch (iofd->mode) {
case OSMO_IO_FD_MODE_READ_WRITE:
iofd_handle_segmented_read(iofd, msg, rc);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36121?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib8dae924fa2d94a7f636136ba7279b965a18cf5b
Gerrit-Change-Number: 36121
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
[S] Change in libosmocore[master]: osmo_io: Reject writing messages with length of 0
Attention is currently required from: daniel, jolly, laforge. Hello Jenkins Builder, daniel, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35912?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: osmo_io: Reject writing messages with length of 0 .. osmo_io: Reject writing messages with length of 0 io_uring will reject to transmit messages with length of 0. Change-Id: I94be5ec7344d92157f7853c6c0ddf7007513ba8e Related: OS#5751 --- M src/core/osmo_io.c 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/12/35912/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I94be5ec7344d92157f7853c6c0ddf7007513ba8e Gerrit-Change-Number: 35912 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[S] Change in libosmocore[master]: osmo_io_uring: Detach msghdr from iofd before calling iofd_handle_sen...
Attention is currently required from: daniel, jolly, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+1 by daniel, Verified+1 by Jenkins Builder Change subject: osmo_io_uring: Detach msghdr from iofd before calling iofd_handle_send_completion() .. osmo_io_uring: Detach msghdr from iofd before calling iofd_handle_send_completion() msghdr must be detached, because subsequent callback at iofd_handle_send_completion() may destroy the iofd (which in turn frees this msghdr, if still attached) and frees the msghdr, causing a double free. Related: OS#5751 Change-Id: Ia349f73de2145fa360b20dd40deb73a8ffc71f07 --- M src/core/osmo_io_uring.c 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/35982/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia349f73de2145fa360b20dd40deb73a8ffc71f07 Gerrit-Change-Number: 35982 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[S] Change in libosmocore[master]: osmo_io_uring: Cancel pending request, free msghdr on completion
Attention is currently required from: jolly. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35981?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: osmo_io_uring: Cancel pending request, free msghdr on completion .. osmo_io_uring: Cancel pending request, free msghdr on completion There is always a completion after cancelling a uring request. Because uring requests use msghdr pointer as user data, we cannot just free the msghdr after cancelling. Upon completion (received after cancelling), the user data still points to the msghdr. To prevent a use-after-free bug, msghdr is not freed, but detached from iofd instance. Then upon completion, the msghdr (if it was detached from iofd) is freed. Additionally it is not required to keep IOFD_FLAG_IN_CALLBACK set anymore, if there is a msghdr attached to iofd. As described above, all msghdr get detached, if iofd is freed (uring request get cancelled) during callback. Related: OS#5751 Change-Id: Ic253f085dd6362db85f029f46350951472210a02 --- M src/core/osmo_io_uring.c 1 file changed, 43 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/35981/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic253f085dd6362db85f029f46350951472210a02 Gerrit-Change-Number: 35981 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error
Attention is currently required from: jolly, laforge. Hello Jenkins Builder, daniel, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: osmo_io_poll: Use -errno as result on read error .. osmo_io_poll: Use -errno as result on read error Related: OS#5751 Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06 --- M src/core/osmo_io.c M src/core/osmo_io_poll.c 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/35980/8 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06 Gerrit-Change-Number: 35980 Gerrit-PatchSet: 8 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[M] Change in libosmocore[master]: osmo_io: Move notify_connected function to backend
Attention is currently required from: daniel, laforge. Hello Jenkins Builder, daniel, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: osmo_io: Move notify_connected function to backend .. osmo_io: Move notify_connected function to backend This relocation is necessary as the backend (osmo_io_fd or osmo_io_uring) requires a different approach in handling connect notifications. As a result, a function call has been introduced to struct iofd_backend_ops. In a subsequent patch, the process for the osmo_io_uring backend will be modified to handle SCTP connect notifications using poll/select. If connect notification is requested using poll/select, the file descriptior must be registered to osmo_fd, using osmo_fd_register. If read / write notification is requested by application, the file descriptior must be registered also. A flag is used prevent calling osmo_fd_register / osmo_fd_unregister multiple times, which would cause a crash. Change-Id: I905ec85210570aff8addadfc9603335d04eb057a Related: OS#5751 --- M src/core/osmo_io.c M src/core/osmo_io_internal.h M src/core/osmo_io_poll.c M src/core/osmo_io_uring.c 4 files changed, 54 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/35909/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I905ec85210570aff8addadfc9603335d04eb057a Gerrit-Change-Number: 35909 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[M] Change in libosmocore[master]: osmo_io: Use poll/select to notify socket connection at osmo_io_uring.c
Attention is currently required from: daniel, jolly, pespin. Hello Jenkins Builder, daniel, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35910?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: osmo_io: Use poll/select to notify socket connection at osmo_io_uring.c .. osmo_io: Use poll/select to notify socket connection at osmo_io_uring.c In order to receive a connect notification from SCTP socket, poll/select event must be used instead of a write notification via io_uring completion event. Once the connect notification has been received, subsequent write notifications via io_uring are used. Change-Id: I4eca9ea72beb0d6ea4d44cce81ed620033f07270 Related: OS#5751 --- M src/core/osmo_io_internal.h M src/core/osmo_io_uring.c 2 files changed, 93 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/10/35910/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4eca9ea72beb0d6ea4d44cce81ed620033f07270 Gerrit-Change-Number: 35910 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-MessageType: newpatchset
[M] Change in libosmocore[master]: osmo_io: Move notify_connected function to backend
Attention is currently required from: daniel, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email ) Change subject: osmo_io: Move notify_connected function to backend .. Patch Set 5: (1 comment) File src/core/osmo_io_poll.c: https://gerrit.osmocom.org/c/libosmocore/+/35909/comment/214f5e38_39197e3a PS4, Line 116: if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED)) > is this something we silently want to accept? or something which should be > debugged and hence at lea […] If the user enables notification when the socket is connects (osmo_iofd_notify_connected) and also wants to register the file descriptor (osmo_iofd_register) at the same time, this function is called twice. The user does not need to wait until the socket is connected before calling osmo_iofd_register() this way. This means that no error should be logged here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I905ec85210570aff8addadfc9603335d04eb057a Gerrit-Change-Number: 35909 Gerrit-PatchSet: 5 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 28 Feb 2024 15:45:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: examples/stream-*: Add options, to set local/remote peer
jolly has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/35927?usp=email )
Change subject: examples/stream-*: Add options, to set local/remote peer
..
examples/stream-*: Add options, to set local/remote peer
This helps to test connections via a network and failing connections.
The client may add "-r " to the command line, to set the address
of the remote peer.
The server may add "-l " to the command line, to select address
of local peer.
By default "127.0.0.1" is used.
Change-Id: Ie6da55ef248436e521c5d8f21f8053356c46a114
---
M examples/stream-client.c
M examples/stream-server.c
2 files changed, 33 insertions(+), 7 deletions(-)
Approvals:
pespin: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/examples/stream-client.c b/examples/stream-client.c
index e42748f..535804e 100644
--- a/examples/stream-client.c
+++ b/examples/stream-client.c
@@ -94,15 +94,19 @@
{
struct osmo_fd *kbd_ofd;
bool use_sctp = false;
+ const char *use_remote_addr = "127.0.0.1";
int opt, rc;
- while ((opt = getopt(argc, argv, "s")) != -1) {
+ while ((opt = getopt(argc, argv, "sr:")) != -1) {
switch (opt) {
case 's':
use_sctp = true;
break;
- default:
+ case 'r':
+ use_remote_addr = optarg;
break;
+ default:
+ exit(0);
}
}
@@ -121,11 +125,10 @@
exit(EXIT_FAILURE);
}
osmo_stream_cli_set_name(conn, "stream_client");
- osmo_stream_cli_set_addr(conn, "127.0.0.1");
+ osmo_stream_cli_set_addr(conn, use_remote_addr);
osmo_stream_cli_set_port(conn, 1);
if (use_sctp)
osmo_stream_cli_set_proto(conn, IPPROTO_SCTP);
-
osmo_stream_cli_set_connect_cb(conn, connect_cb);
osmo_stream_cli_set_disconnect_cb(conn, disconnect_cb);
osmo_stream_cli_set_read_cb2(conn, read_cb);
diff --git a/examples/stream-server.c b/examples/stream-server.c
index 9faf307..bfbde6d 100644
--- a/examples/stream-server.c
+++ b/examples/stream-server.c
@@ -121,15 +121,19 @@
{
struct osmo_fd *kbd_ofd;
bool use_sctp = false;
+ const char *use_local_addr = "127.0.0.1";
int opt;
- while ((opt = getopt(argc, argv, "s")) != -1) {
+ while ((opt = getopt(argc, argv, "sl:")) != -1) {
switch (opt) {
case 's':
use_sctp = true;
break;
- default:
+ case 'l':
+ use_local_addr = optarg;
break;
+ default:
+ exit(0);
}
}
@@ -147,7 +151,7 @@
fprintf(stderr, "cannot create server link\n");
exit(EXIT_FAILURE);
}
- osmo_stream_srv_link_set_addr(srv, "127.0.0.1");
+ osmo_stream_srv_link_set_addr(srv, use_local_addr);
osmo_stream_srv_link_set_port(srv, 1);
if (use_sctp)
osmo_stream_srv_link_set_proto(srv, IPPROTO_SCTP);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35927?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie6da55ef248436e521c5d8f21f8053356c46a114
Gerrit-Change-Number: 35927
Gerrit-PatchSet: 5
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in libosmo-netif[master]: examples/stream-{server,client}: Generate talloc report on SIGUSR1
jolly has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36078?usp=email )
Change subject: examples/stream-{server,client}: Generate talloc report on
SIGUSR1
..
examples/stream-{server,client}: Generate talloc report on SIGUSR1
This can help with memleak debugging.
Change-Id: Ia16632602b937db88e2da2b053192887bdb8a986
---
M examples/stream-client.c
M examples/stream-server.c
2 files changed, 33 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
jolly: Looks good to me, approved
diff --git a/examples/stream-client.c b/examples/stream-client.c
index 535804e..da90e8c 100644
--- a/examples/stream-client.c
+++ b/examples/stream-client.c
@@ -90,6 +90,15 @@
return 0;
}
+static void signal_handler(int signum)
+{
+ switch (signum) {
+ case SIGUSR1:
+ talloc_report_full(tall_test, stdout);
+ break;
+ }
+}
+
int main(int argc, char **argv)
{
struct osmo_fd *kbd_ofd;
@@ -110,6 +119,8 @@
}
}
+ signal(SIGUSR1, _handler);
+
tall_test = talloc_named_const(NULL, 1, "osmo_stream_cli_test");
msgb_talloc_ctx_init(tall_test, 0);
osmo_init_logging2(tall_test, _stream_cli_test_log_info);
diff --git a/examples/stream-server.c b/examples/stream-server.c
index bfbde6d..1cd3517 100644
--- a/examples/stream-server.c
+++ b/examples/stream-server.c
@@ -117,6 +117,15 @@
return 0;
}
+static void signal_handler(int signum)
+{
+ switch (signum) {
+ case SIGUSR1:
+ talloc_report(tall_test, stderr);
+ break;
+ }
+}
+
int main(int argc, char **argv)
{
struct osmo_fd *kbd_ofd;
@@ -137,6 +146,8 @@
}
}
+ signal(SIGUSR1, _handler);
+
tall_test = talloc_named_const(NULL, 1, "osmo_stream_srv_test");
msgb_talloc_ctx_init(tall_test, 0);
osmo_init_logging2(tall_test, _stream_srv_test_log_info);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36078?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia16632602b937db88e2da2b053192887bdb8a986
Gerrit-Change-Number: 36078
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: jolly
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in libosmo-netif[master]: examples/stream-*: Support SCTP when called with "-s" argument
jolly has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/35234?usp=email )
Change subject: examples/stream-*: Support SCTP when called with "-s" argument
..
examples/stream-*: Support SCTP when called with "-s" argument
Change-Id: I4137cdf1e21cb669b632fe5c126ec27475d98400
---
M examples/stream-client.c
M examples/stream-server.c
2 files changed, 44 insertions(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/examples/stream-client.c b/examples/stream-client.c
index 6781c72..e42748f 100644
--- a/examples/stream-client.c
+++ b/examples/stream-client.c
@@ -3,6 +3,7 @@
#include
#include
#include
+#include
#include
#include
@@ -89,10 +90,21 @@
return 0;
}
-int main(void)
+int main(int argc, char **argv)
{
struct osmo_fd *kbd_ofd;
- int rc;
+ bool use_sctp = false;
+ int opt, rc;
+
+ while ((opt = getopt(argc, argv, "s")) != -1) {
+ switch (opt) {
+ case 's':
+ use_sctp = true;
+ break;
+ default:
+ break;
+ }
+ }
tall_test = talloc_named_const(NULL, 1, "osmo_stream_cli_test");
msgb_talloc_ctx_init(tall_test, 0);
@@ -111,12 +123,16 @@
osmo_stream_cli_set_name(conn, "stream_client");
osmo_stream_cli_set_addr(conn, "127.0.0.1");
osmo_stream_cli_set_port(conn, 1);
+ if (use_sctp)
+ osmo_stream_cli_set_proto(conn, IPPROTO_SCTP);
+
osmo_stream_cli_set_connect_cb(conn, connect_cb);
osmo_stream_cli_set_disconnect_cb(conn, disconnect_cb);
osmo_stream_cli_set_read_cb2(conn, read_cb);
- if (osmo_stream_cli_open(conn) < 0) {
- fprintf(stderr, "cannot open cli\n");
+ rc = osmo_stream_cli_open(conn);
+ if (rc < 0) {
+ fprintf(stderr, "cannot open cli: %d\n", rc);
exit(EXIT_FAILURE);
}
diff --git a/examples/stream-server.c b/examples/stream-server.c
index 8aa8b9b..9faf307 100644
--- a/examples/stream-server.c
+++ b/examples/stream-server.c
@@ -117,9 +117,21 @@
return 0;
}
-int main(void)
+int main(int argc, char **argv)
{
struct osmo_fd *kbd_ofd;
+ bool use_sctp = false;
+ int opt;
+
+ while ((opt = getopt(argc, argv, "s")) != -1) {
+ switch (opt) {
+ case 's':
+ use_sctp = true;
+ break;
+ default:
+ break;
+ }
+ }
tall_test = talloc_named_const(NULL, 1, "osmo_stream_srv_test");
msgb_talloc_ctx_init(tall_test, 0);
@@ -137,6 +149,8 @@
}
osmo_stream_srv_link_set_addr(srv, "127.0.0.1");
osmo_stream_srv_link_set_port(srv, 1);
+ if (use_sctp)
+ osmo_stream_srv_link_set_proto(srv, IPPROTO_SCTP);
osmo_stream_srv_link_set_accept_cb(srv, accept_cb);
if (osmo_stream_srv_link_open(srv) < 0) {
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35234?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I4137cdf1e21cb669b632fe5c126ec27475d98400
Gerrit-Change-Number: 35234
Gerrit-PatchSet: 5
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
