Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 ) Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. iu_client: sccp_sap_up: don't decode empty disconnect indications Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 --- M src/iu_client.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/iu_client.c b/src/iu_client.c index 8da9a43..ce06f8a 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -799,7 +799,9 @@ if (!ue) break; - rc = ranap_cn_rx_co(cn_ranap_handle_co, ue, msgb_l2(oph->msg), msgb_l2len(oph->msg)); + rc = 0; + if (msgb_l2len(oph->msg) > 0) + rc = ranap_cn_rx_co(cn_ranap_handle_co, ue, msgb_l2(oph->msg), msgb_l2len(oph->msg)); break; case OSMO_PRIM(OSMO_SCU_PRIM_N_DATA, PRIM_OP_INDICATION): /* connection-oriented data received */ -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 ) Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c@802 PS5, Line 802: rc = 0; > I hope at some point this "rc = 0" is moved up in order to set rc if !ue > condition is hit, otherwise […] rc is initilized with -1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 18:08:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 ) Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. Patch Set 5: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c@802 PS5, Line 802: rc = 0; I hope at some point this "rc = 0" is moved up in order to set rc if !ue condition is hit, otherwise it looks like rc will be returned uninitialized. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 17:43:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 to look at the new patch set (#5). Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. iu_client: sccp_sap_up: don't decode empty disconnect indications Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 --- M src/iu_client.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/80/15180/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 ) Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 17 Aug 2019 01:18:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 ) Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 16 Aug 2019 10:21:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 to look at the new patch set (#2). Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. iu_client: sccp_sap_up: don't decode empty disconnect indications Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 --- M src/iu_client.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/80/15180/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 ) Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 13 Aug 2019 16:44:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. iu_client: sccp_sap_up: don't decode empty disconnect indications Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 --- M src/iu_client.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/80/15180/1 diff --git a/src/iu_client.c b/src/iu_client.c index f8333af..ecadc9a 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -800,7 +800,9 @@ if (!ue) break; - rc = ranap_cn_rx_co(cn_ranap_handle_co, ue, msgb_l2(oph->msg), msgb_l2len(oph->msg)); + rc = 0; + if (msgb_l2len(oph->msg)) + rc = ranap_cn_rx_co(cn_ranap_handle_co, ue, msgb_l2(oph->msg), msgb_l2len(oph->msg)); break; case OSMO_PRIM(OSMO_SCU_PRIM_N_DATA, PRIM_OP_INDICATION): /* connection-oriented data received */ -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange
