Change in osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 ) Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. sgsn: Gb: implementing PS Paging when MS is MM_STANDBY When the MS is in MM_STANDBY, the Routing Area is known, but not the exact cell. Start the paging procedure. (Even this is only supported for the last known cell, not the Routing Area. Routing Area paging is not yet supported.) Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c --- M src/sgsn/sgsn_libgtp.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c index a39687f..c45431a 100644 --- a/src/sgsn/sgsn_libgtp.c +++ b/src/sgsn/sgsn_libgtp.c @@ -54,6 +54,7 @@ #include #include #include +#include #include #include @@ -664,6 +665,11 @@ /* FIXME: queue the packet we received from GTP */ break; case ST_GMM_REGISTERED_NORMAL: + OSMO_ASSERT(mm->gb.mm_state_fsm->state != ST_MM_IDLE); + if (mm->gb.mm_state_fsm->state == ST_MM_STANDBY) + gprs_gb_page_ps_ra(mm); + + /* FIXME: queue the packet we received from GTP */ break; default: LOGP(DGPRS, LOGL_ERROR, "GTP DATA IND for TLLI %08X in state " -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 ) Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 08 Oct 2019 20:43:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 ) Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 08 Oct 2019 17:12:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 )
Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
..
Patch Set 5:
(1 comment)
mind the !
https://gerrit.osmocom.org/#/c/15705/5/src/sgsn/sgsn_libgtp.c
File src/sgsn/sgsn_libgtp.c:
https://gerrit.osmocom.org/#/c/15705/5/src/sgsn/sgsn_libgtp.c@668
PS5, Line 668: !=
this gremlin here is well known.
it looked to me quite ugly to have
if (state == ..) {}
else { OSMO_ASSERT() }
ST_MM_IDLE should never get through this.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Tue, 08 Oct 2019 17:04:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 ) Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. Patch Set 5: Code-Review-2 Again that OSMO_ASSERT. One day I'll figure out which kind of gremlin you have in your computer running git push. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 08 Oct 2019 16:58:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 ) Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 08 Oct 2019 16:58:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 ) Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/15705/3/src/sgsn/sgsn_libgtp.c File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/#/c/15705/3/src/sgsn/sgsn_libgtp.c@670 PS3, Line 670: > You are missing here the following: " FIXME: queue the packet we received > from GTP */" Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 08 Oct 2019 16:15:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 to look at the new patch set (#5). Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. sgsn: Gb: implementing PS Paging when MS is MM_STANDBY When the MS is in MM_STANDBY, the Routing Area is known, but not the exact cell. Start the paging procedure. (Even this is only supported for the last known cell, not the Routing Area. Routing Area paging is not yet supported.) Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c --- M src/sgsn/sgsn_libgtp.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/05/15705/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 to look at the new patch set (#4). Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. sgsn: Gb: implementing PS Paging when MS is MM_STANDBY When the MS is in MM_STANDBY, the Routing Area is known, but not the exact cell. Start the paging procedure. (Even this is only supported for the last known cell, not the Routing Area. Routing Area paging is not yet supported.) Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c --- M src/sgsn/sgsn_libgtp.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/05/15705/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 ) Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/15705/2/src/sgsn/sgsn_libgtp.c File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/#/c/15705/2/src/sgsn/sgsn_libgtp.c@668 PS2, Line 668: OSMO_ASSERT(mm->gb.mm_state_fsm->state == ST_MM_IDLE); so first you assert on state, then you check in a condition for another? that's wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 08 Oct 2019 15:50:44 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY
lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 ) Change subject: sgsn: Gb: implementing PS Paging when MS is MM_STANDBY .. sgsn: Gb: implementing PS Paging when MS is MM_STANDBY When the MS is in MM_STANDBY, the Routing Area is known, but not the exact cell. Start the paging procedure. (Even this is only supported for the last known cell, not the Routing Area. Routing Area paging is not yet supported.) Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c --- M src/sgsn/sgsn_libgtp.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/05/15705/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
