Change in osmo-trx[master]: Initial XTRX support

2022-08-09 Thread lynxis lazus 
Attention is currently required from: rauf.gyulal...@fairwaves.co, ipse, 
pespin, lynxis lazus.
lynxis lazus has uploaded a new patch set (#5) to the change originally created 
by rauf.gyulal...@fairwaves.co. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 
)

Change subject: Initial XTRX support
..

Initial XTRX support

Add dummy functions for
RxGain/TxGain/getPowerAttenuation/PowerAttenuation/TxPower

Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
---
M Transceiver52M/Makefile.am
M Transceiver52M/device/Makefile.am
A Transceiver52M/device/xtrx/Makefile.am
A Transceiver52M/device/xtrx/XTRXDevice.cpp
A Transceiver52M/device/xtrx/XTRXDevice.h
M configure.ac
M contrib/systemd/Makefile.am
A contrib/systemd/osmo-trx-xtrx.service
M debian/control
A debian/osmo-trx-xtrx.install
M doc/examples/Makefile.am
A doc/examples/osmo-trx-xtrx/osmo-trx-xtrx.cfg
12 files changed, 757 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/15685/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: rauf.gyulal...@fairwaves.co
Gerrit-Attention: ipse 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

Change in osmo-trx[master]: Initial XTRX support

2022-08-08 Thread lynxis lazus 
Attention is currently required from: rauf.gyulal...@fairwaves.co, ipse, pespin.
lynxis lazus has uploaded a new patch set (#4) to the change originally created 
by rauf.gyulal...@fairwaves.co. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 
)

Change subject: Initial XTRX support
..

Initial XTRX support

Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
---
M Transceiver52M/Makefile.am
M Transceiver52M/device/Makefile.am
A Transceiver52M/device/xtrx/Makefile.am
A Transceiver52M/device/xtrx/XTRXDevice.cpp
A Transceiver52M/device/xtrx/XTRXDevice.h
M configure.ac
M contrib/systemd/Makefile.am
A contrib/systemd/osmo-trx-xtrx.service
M debian/control
A debian/osmo-trx-xtrx.install
M doc/examples/Makefile.am
A doc/examples/osmo-trx-xtrx/osmo-trx-xtrx.cfg
12 files changed, 737 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/15685/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 4
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: rauf.gyulal...@fairwaves.co
Gerrit-Attention: ipse 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-trx[master]: Initial XTRX support

2022-08-08 Thread lynxis lazus 
Attention is currently required from: rauf.gyulal...@fairwaves.co, ipse, pespin.
lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
..


Patch Set 3:

(3 comments)

File Transceiver52M/device/xtrx/XTRXDevice.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/15685/comment/c6de38f7_ef0b9e67
PS1, Line 177:  return false;
> Other device implementations. For instance UHDDevice does: […]
Done


File Transceiver52M/device/xtrx/XTRXDevice.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/15685/comment/47debce2_5df9dcd8
PS3, Line 459:
> Remove extra whitespace at the end.
Done


File contrib/systemd/Makefile.am:

https://gerrit.osmocom.org/c/osmo-trx/+/15685/comment/0c9e9017_1ccf18fe
PS3, Line 4:   osmo-trx-usrp1.service
> You miss adding osmo-trx-xtrx.service here.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: rauf.gyulal...@fairwaves.co
Gerrit-Attention: ipse 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 08 Aug 2022 18:27:13 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ipse 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-trx[master]: Initial XTRX support

2022-04-04 Thread laforge 
Attention is currently required from: rauf.gyulal...@fairwaves.co, ipse.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
..


Patch Set 3:

(1 comment)

Patchset:

PS3:
related PR on the read-only github mirror at 
https://github.com/osmocom/osmo-trx/pull/4 - I pointed the developer to gerrit.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: rauf.gyulal...@fairwaves.co
Gerrit-Attention: ipse 
Gerrit-Comment-Date: Mon, 04 Apr 2022 10:34:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-trx[master]: Initial XTRX support

2021-03-18 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
..


Patch Set 3:

years later and nobody seems to be able to invest some time to ever get this 
merged.  It's really sad to see :/


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 18 Mar 2021 13:38:53 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-trx[master]: Initial XTRX support

2019-11-23 Thread ipse 
ipse has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
..


Patch Set 3:

> @ipse, @sergey, @mold, can we please get some feedback to move this ahead?  
> It shold be in your own best interest to get xtrx support merged anytime 
> soon.  We want that, too, but waiting 6 weeks for input isn't helping :/

Hi, Harald, I've fixed the comments above in the updated branch but when 
testing `osmo-trx` in the loopback mode I found that it can't decode the signal 
it transmits. I can resubmit the patches but I thought it would be better to 
wait until we understand the issue - if it's something wrong with the recent 
`osmo-trx` or with the XTRX adapter code. We haven't had time to do that yet, 
unfortunately.


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Sat, 23 Nov 2019 19:25:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-trx[master]: Initial XTRX support

2019-11-23 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
..


Patch Set 3:

@ipse, @sergey, @mold, can we please get some feedback to move this ahead?  It 
shold be in your own best interest to get xtrx support merged anytime soon.  We 
want that, too, but waiting 6 weeks for input isn't helping :/


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Sat, 23 Nov 2019 08:09:23 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-trx[master]: Initial XTRX support

2019-10-09 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
..


Patch Set 3:

(3 comments)

Overall looks fine, please clean up small things I pointed out in this version 
and in first version of the patch,

https://gerrit.osmocom.org/#/c/15685/3/Transceiver52M/device/xtrx/XTRXDevice.cpp
File Transceiver52M/device/xtrx/XTRXDevice.cpp:

https://gerrit.osmocom.org/#/c/15685/3/Transceiver52M/device/xtrx/XTRXDevice.cpp@38
PS3, Line 38: // Rx/Tx timestamp difference in samples.
Probably cleaner using /* */


https://gerrit.osmocom.org/#/c/15685/3/Transceiver52M/device/xtrx/XTRXDevice.cpp@459
PS3, Line 459:
Remove extra whitespace at the end.


https://gerrit.osmocom.org/#/c/15685/3/contrib/systemd/Makefile.am
File contrib/systemd/Makefile.am:

https://gerrit.osmocom.org/#/c/15685/3/contrib/systemd/Makefile.am@4
PS3, Line 4:   osmo-trx-usrp1.service
You miss adding osmo-trx-xtrx.service here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 11:51:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-trx[master]: Initial XTRX support

2019-10-09 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
..


Patch Set 3:

(5 comments)

https://gerrit.osmocom.org/#/c/15685/1/Transceiver52M/device/xtrx/XTRXDevice.cpp
File Transceiver52M/device/xtrx/XTRXDevice.cpp:

https://gerrit.osmocom.org/#/c/15685/1/Transceiver52M/device/xtrx/XTRXDevice.cpp@49
PS1, Line 49: << " rx_path(0): " << (rx_paths.size() ? 
rx_paths[0] : "<>")
> Looks like it can be 0 if we don't specify rx/tx-path in the config file. […]
in trx_start() (osmo-trx.cpp):

/* Generate vector of rx/tx_path: */
for (i = 0; i < trx->cfg.num_chans; i++) {
rx_paths.push_back(charp2str(trx->cfg.chans[i].rx_path));
tx_paths.push_back(charp2str(trx->cfg.chans[i].tx_path));
}

So it cannot be size()==0 unless there's cnum_chans=0, which shouldn't happen.

IMHO having this check here is unnecesary and confusing for people reading the 
code.


https://gerrit.osmocom.org/#/c/15685/1/Transceiver52M/device/xtrx/XTRXDevice.cpp@52
PS1, Line 52:   txsps = tx_sps;
> Yes, but it looks cleaner here and doesn't affect performance.
I disagree, but it's bike-shed talking anyway, so keep it this way if you 
prefer, np.


https://gerrit.osmocom.org/#/c/15685/1/Transceiver52M/device/xtrx/XTRXDevice.cpp@177
PS1, Line 177:  return false;
> What do you mean by "other devices" here?
Other device implementations. For instance UHDDevice does:

if (started) {
LOGC(DDEV, ERROR) << "Device already started";
return false;
}

So fine here :) Maybe wanna add a LOGC like UHDDevice.


https://gerrit.osmocom.org/#/c/15685/1/Transceiver52M/device/xtrx/XTRXDevice.cpp@280
PS1, Line 280:  int res = xtrx_set_gain(device, XTRX_CH_AB, XTRX_TX_PAD_GAIN, 
dB - 30, );
> I'll ask Sergey why is it done this way but I'm sure there is a reason for 
> that.
Then please document so.


https://gerrit.osmocom.org/#/c/15685/1/Transceiver52M/device/xtrx/XTRXDevice.cpp@345
PS1, Line 345:  if (!started)
> Does it hurt to check, just to be sure?
It adds confusing about how the system is expected to work, and makes it 
difficult to refactor later (because looks like different devices expect the 
generic framework to work in different ways). For instance UHDDevice doesn't do 
this kind of check.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 11:43:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: ipse 
Gerrit-MessageType: comment

Change in ...osmo-trx[master]: Initial XTRX support

2019-10-09 Thread ipse 
ipse has uploaded a new patch set (#3) to the change originally created by 
rauf.gyulal...@fairwaves.co. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
..

Initial XTRX support

Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
---
M Transceiver52M/Makefile.am
M Transceiver52M/device/Makefile.am
A Transceiver52M/device/xtrx/Makefile.am
A Transceiver52M/device/xtrx/XTRXDevice.cpp
A Transceiver52M/device/xtrx/XTRXDevice.h
M configure.ac
M contrib/systemd/Makefile.am
A contrib/systemd/osmo-trx-xtrx.service
M debian/control
A debian/osmo-trx-xtrx.install
M doc/examples/Makefile.am
A doc/examples/osmo-trx-xtrx/osmo-trx-xtrx.cfg
12 files changed, 736 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/15685/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in ...osmo-trx[master]: Initial XTRX support

2019-10-08 Thread ipse 
ipse has uploaded a new patch set (#2) to the change originally created by 
rauf.gyulal...@fairwaves.co. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
..

Initial XTRX support

Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
---
M Transceiver52M/Makefile.am
M Transceiver52M/device/Makefile.am
A Transceiver52M/device/xtrx/Makefile.am
A Transceiver52M/device/xtrx/XTRXDevice.cpp
A Transceiver52M/device/xtrx/XTRXDevice.h
M configure.ac
M contrib/systemd/Makefile.am
A contrib/systemd/osmo-trx-xtrx.service
M debian/control
A debian/osmo-trx-xtrx.install
M doc/examples/Makefile.am
A doc/examples/osmo-trx-xtrx/osmo-trx-xtrx.cfg
12 files changed, 733 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/15685/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 2
Gerrit-Owner: rauf.gyulal...@fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset