Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
lynxis lazus has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 )
Change subject: sgsn: add TC_geran_attach_iu_rau
..
sgsn: add TC_geran_attach_iu_rau
MS <-> SGSN: Successful Attach over Geran
MS <-> SGSN: Routing Area Update over Iu
The test case will crash the SGSN and is not included
in the default run.
Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef
---
M sgsn/SGSN_Tests_Iu.ttcn
1 file changed, 26 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn
index c0a6729..64d829d 100644
--- a/sgsn/SGSN_Tests_Iu.ttcn
+++ b/sgsn/SGSN_Tests_Iu.ttcn
@@ -59,10 +59,35 @@
f_cleanup();
}
+private function f_TC_geran_attach_iu_rau(charstring id) runs on
BSSGP_ConnHdlr {
+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));
+
+ /* first perform regular attach */
+ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false,
gb_idx := 0);
+
+ /* do a routing area update */
+ f_routing_area_update(g_pars.ra, bssgp := 3);
+ setverdict(pass);
+}
+
+testcase TC_geran_attach_iu_rau() runs on test_CT {
+ /* MS <-> SGSN: Successful Attach over Geran
+* MS <-> SGSN: Routing Area Update over Iu
+*/
+ var BSSGP_ConnHdlr vc_conn;
+ g_ranap_enable := true;
+ f_init();
+ f_sleep(1.0);
+ vc_conn := f_start_handler(refers(f_TC_geran_attach_iu_rau),
testcasename(), g_gb, 1003);
+ vc_conn.done;
+ f_cleanup();
+}
+
control {
execute( TC_iu_attach() );
/* FIXME: will crash the sgsn
-* execute( TC_iu_attach_geran_rau() ); */
+* execute( TC_iu_attach_geran_rau() );
+* execute( TC_geran_attach_iu_rau() ); */
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef
Gerrit-Change-Number: 15397
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 ) Change subject: sgsn: add TC_geran_attach_iu_rau .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef Gerrit-Change-Number: 15397 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 12 Sep 2019 20:25:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 ) Change subject: sgsn: add TC_geran_attach_iu_rau .. Patch Set 9: (1 comment) https://gerrit.osmocom.org/#/c/15397/8//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15397/8//COMMIT_MSG@12 PS8, Line 12: The tess case will crash the SGSN and is not included > test Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef Gerrit-Change-Number: 15397 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 12 Sep 2019 16:48:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 to look at the new patch set (#9). Change subject: sgsn: add TC_geran_attach_iu_rau .. sgsn: add TC_geran_attach_iu_rau MS <-> SGSN: Successful Attach over Geran MS <-> SGSN: Routing Area Update over Iu The test case will crash the SGSN and is not included in the default run. Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/15397/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef Gerrit-Change-Number: 15397 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 ) Change subject: sgsn: add TC_geran_attach_iu_rau .. Patch Set 8: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/15397/8//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15397/8//COMMIT_MSG@12 PS8, Line 12: The tess case will crash the SGSN and is not included test -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef Gerrit-Change-Number: 15397 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 12 Sep 2019 11:28:35 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 to look at the new patch set (#7). Change subject: sgsn: add TC_geran_attach_iu_rau .. sgsn: add TC_geran_attach_iu_rau MS <-> SGSN: Successful Attach over Geran MS <-> SGSN: Routing Area Update over Iu The tess case will crash the SGSN and is not included in the default run. Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/15397/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef Gerrit-Change-Number: 15397 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 to look at the new patch set (#3). Change subject: sgsn: add TC_geran_attach_iu_rau .. sgsn: add TC_geran_attach_iu_rau MS <-> SGSN: Successful Attach over Geran MS <-> SGSN: Routing Area Update over Iu The tess case will crash the SGSN and is not included in the default run. Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/15397/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef Gerrit-Change-Number: 15397 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 ) Change subject: sgsn: add TC_geran_attach_iu_rau .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef Gerrit-Change-Number: 15397 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 05 Sep 2019 09:05:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 to look at the new patch set (#2). Change subject: sgsn: add TC_geran_attach_iu_rau .. sgsn: add TC_geran_attach_iu_rau MS <-> SGSN: Successful Attach over Geran MS <-> SGSN: Routing Area Update over Iu The tess case will crash the SGSN and is not included in the default run. Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/15397/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef Gerrit-Change-Number: 15397 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 )
Change subject: sgsn: add TC_geran_attach_iu_rau
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/15397/1/sgsn/SGSN_Tests_Iu.ttcn
File sgsn/SGSN_Tests_Iu.ttcn:
https://gerrit.osmocom.org/#/c/15397/1/sgsn/SGSN_Tests_Iu.ttcn@57
PS1, Line 57: private function f_TC_geran_attach_iu_rau(charstring id) runs on
BSSGP_ConnHdlr {
Again, write a description on top of function about what does the test check
please.
https://gerrit.osmocom.org/#/c/15397/1/sgsn/SGSN_Tests_Iu.ttcn@74
PS1, Line 74: vc_conn.done;
Missing f_cleanup();
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef
Gerrit-Change-Number: 15397
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:42:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397
Change subject: sgsn: add TC_geran_attach_iu_rau
..
sgsn: add TC_geran_attach_iu_rau
Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef
---
M sgsn/SGSN_Tests_Iu.ttcn
1 file changed, 22 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/97/15397/1
diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn
index d6007b3..50118c7 100644
--- a/sgsn/SGSN_Tests_Iu.ttcn
+++ b/sgsn/SGSN_Tests_Iu.ttcn
@@ -54,10 +54,31 @@
vc_conn.done;
}
+private function f_TC_geran_attach_iu_rau(charstring id) runs on
BSSGP_ConnHdlr {
+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));
+
+ /* first perform regular attach */
+ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false,
gb_idx := 0);
+
+ /* do a routing area update */
+ f_routing_area_update(g_pars.ra, bssgp := 3, send_ptmsi := true);
+ setverdict(pass);
+}
+
+testcase TC_geran_attach_iu_rau() runs on test_CT {
+ var BSSGP_ConnHdlr vc_conn;
+ g_ranap_enable := true;
+ f_init();
+ f_sleep(1.0);
+ vc_conn := f_start_handler(refers(f_TC_geran_attach_iu_rau),
testcasename(), g_gb, 1003);
+ vc_conn.done;
+}
+
control {
execute( TC_iu_attach() );
/* FIXME: will crash the sgsn
-* execute( TC_iu_attach_geran_rau() ); */
+* execute( TC_iu_attach_geran_rau() );
+* execute( TC_geran_attach_iu_rau() ); */
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef
Gerrit-Change-Number: 15397
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
