Change in libosmocore[master]: LCLS: use proper types for value_string wrappers

2019-01-09 Thread Max 
Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12367 )

Change subject: LCLS: use proper types for value_string wrappers
..

LCLS: use proper types for value_string wrappers

Change-Id: I0f47a610e06ac99bd60a5aad6f50f3658480165e
---
M include/osmocom/gsm/gsm0808.h
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index ac88748..782f3ec 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -219,13 +219,13 @@
 extern const struct value_string gsm0808_lcls_control_names[];
 extern const struct value_string gsm0808_lcls_status_names[];

-static inline const char *gsm0808_lcls_config_name(uint8_t val) {
+static inline const char *gsm0808_lcls_config_name(enum gsm0808_lcls_config 
val) {
return get_value_string(gsm0808_lcls_config_names, val);
 }
-static inline const char *gsm0808_lcls_control_name(uint8_t val) {
+static inline const char *gsm0808_lcls_control_name(enum gsm0808_lcls_control 
val) {
return get_value_string(gsm0808_lcls_control_names, val);
 }
-static inline const char *gsm0808_lcls_status_name(uint8_t val) {
+static inline const char *gsm0808_lcls_status_name(enum gsm0808_lcls_status 
val) {
return get_value_string(gsm0808_lcls_status_names, val);
 }


--
To view, visit https://gerrit.osmocom.org/12367
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f47a610e06ac99bd60a5aad6f50f3658480165e
Gerrit-Change-Number: 12367
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling

Change in libosmocore[master]: LCLS: use proper types for value_string wrappers

2019-01-09 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12367 )

Change subject: LCLS: use proper types for value_string wrappers
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12367
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f47a610e06ac99bd60a5aad6f50f3658480165e
Gerrit-Change-Number: 12367
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 09 Jan 2019 16:16:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: LCLS: use proper types for value_string wrappers

2018-12-20 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12367 )

Change subject: LCLS: use proper types for value_string wrappers
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12367
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f47a610e06ac99bd60a5aad6f50f3658480165e
Gerrit-Change-Number: 12367
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Thu, 20 Dec 2018 11:21:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: LCLS: use proper types for value_string wrappers

2018-12-20 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12367 )

Change subject: LCLS: use proper types for value_string wrappers
..


Patch Set 2:

When changing APIs, please provide information on when where they added and if 
a release was already done with previous version of the API.

Also, did you make sure all users of this API in all osmocom repositories build 
fine with this file applied to libosmocore? I can image the compiler 
warning/erroring because you pass a uint8_t to an enum param.


-- 
To view, visit https://gerrit.osmocom.org/12367
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f47a610e06ac99bd60a5aad6f50f3658480165e
Gerrit-Change-Number: 12367
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 20 Dec 2018 11:16:48 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmocore[master]: LCLS: use proper types for value_string wrappers

2018-12-19 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12367


Change subject: LCLS: use proper types for value_string wrappers
..

LCLS: use proper types for value_string wrappers

Change-Id: I0f47a610e06ac99bd60a5aad6f50f3658480165e
---
M include/osmocom/gsm/gsm0808.h
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/12367/1

diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 79d89e5..76b77b6 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -219,13 +219,13 @@
 extern const struct value_string gsm0808_lcls_control_names[];
 extern const struct value_string gsm0808_lcls_status_names[];

-static inline const char *gsm0808_lcls_config_name(uint8_t val) {
+static inline const char *gsm0808_lcls_config_name(enum gsm0808_lcls_config 
val) {
return get_value_string(gsm0808_lcls_config_names, val);
 }
-static inline const char *gsm0808_lcls_control_name(uint8_t val) {
+static inline const char *gsm0808_lcls_control_name(enum gsm0808_lcls_control 
val) {
return get_value_string(gsm0808_lcls_control_names, val);
 }
-static inline const char *gsm0808_lcls_status_name(uint8_t val) {
+static inline const char *gsm0808_lcls_status_name(enum gsm0808_lcls_status 
val) {
return get_value_string(gsm0808_lcls_status_names, val);
 }


--
To view, visit https://gerrit.osmocom.org/12367
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f47a610e06ac99bd60a5aad6f50f3658480165e
Gerrit-Change-Number: 12367
Gerrit-PatchSet: 1
Gerrit-Owner: Max