Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. abis_nm: Introduce new signal S_NM_GET_ATTR_REP This signal can be used for tools willing to request and parse Attribute Response and do something with the information. ipaccess-config tool will use this signal in later patch Change-Id Ida416a969a3309868d6f4e50f34b34f224c32dd6. Related: OS#3624 Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 --- M include/osmocom/bsc/signal.h M src/osmo-bsc/abis_nm.c 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Neels Hofmeyr: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/signal.h b/include/osmocom/bsc/signal.h index 1b351aa..62a3d2c 100644 --- a/include/osmocom/bsc/signal.h +++ b/include/osmocom/bsc/signal.h @@ -72,6 +72,7 @@ S_NM_STATECHG_ADM, /* Administrative State changed */ S_NM_OM2K_CONF_RES, /* OM2K Configuration Result */ S_NM_OPSTART_ACK, /* Received OPSTART ACK, arg is struct msgb *oml_msg */ + S_NM_GET_ATTR_REP, /* Received Get Attributes Response, arg is struct msgb *oml_msg */ }; /* SS_LCHAN signals */ diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index c1a26ac..f1306fc 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -616,6 +616,7 @@ struct e1inp_sign_link *sign_link = mb->dst; struct gsm_bts *bts = trx ? trx->bts : sign_link->trx->bts; struct tlv_parsed tp; + int rc; DEBUGPFOH(DNM, foh, "Get Attributes Response for BTS%u\n", bts->nr); @@ -623,9 +624,13 @@ /* nanoBTS doesn't send Get Attribute Response Info, uses its own format */ if (bts->type != GSM_BTS_TYPE_NANOBTS) - return parse_attr_resp_info(bts, trx, foh, ); + rc = parse_attr_resp_info(bts, trx, foh, ); else - return parse_attr_resp_info_attr(bts, trx, foh, ); + rc = parse_attr_resp_info_attr(bts, trx, foh, ); + + osmo_signal_dispatch(SS_NM, S_NM_GET_ATTR_REP, mb); + + return rc; } /* 3GPP TS 52.021 ยง6.2.5 */ -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 6 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 5 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 21 Nov 2018 13:07:51 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11684 to look at the new patch set (#5). Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. abis_nm: Introduce new signal S_NM_GET_ATTR_REP This signal can be used for tools willing to request and parse Attribute Response and do something with the information. ipaccess-config tool will use this signal in later patch Change-Id Ida416a969a3309868d6f4e50f34b34f224c32dd6. Related: OS#3624 Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 --- M include/osmocom/bsc/signal.h M src/osmo-bsc/abis_nm.c 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/11684/5 -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 5 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11684/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11684/4//COMMIT_MSG@11 PS4, Line 11: this signal in later patch Change-Id 3f3281bf45a22020225ba15610de4003bc506601. > that's still not a change-id (i.e. it's a git commit hash that doesn't exist anymore) -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 4 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Tue, 20 Nov 2018 18:34:25 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11684/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11684/4//COMMIT_MSG@11 PS4, Line 11: this signal in later patch Change-Id 3f3281bf45a22020225ba15610de4003bc506601. that's still not a change-id -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 4 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Tue, 20 Nov 2018 18:33:39 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 4 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Sat, 10 Nov 2018 06:52:11 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11684 to look at the new patch set (#4). Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. abis_nm: Introduce new signal S_NM_GET_ATTR_REP This signal can be used for tools willing to request and parse Attribute Response and do something with the information. ipaccess-config tool will use this signal in later patch Change-Id 3f3281bf45a22020225ba15610de4003bc506601. Related: OS#3624 Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 --- M include/osmocom/bsc/signal.h M src/osmo-bsc/abis_nm.c 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/11684/4 -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 4 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11684/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11684/3//COMMIT_MSG@11 PS3, Line 11: this signal in later patches. > Why do you really need a Change-id of a later patch? just look 1-2 patches > later, that's it. because when future readers go through the log, they want to know what is going on. Actually, if it is in the same repos, why not squash those two commits to begin with? Then the user of the signal is right there. -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 09 Nov 2018 13:48:16 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11684/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11684/3//COMMIT_MSG@11 PS3, Line 11: this signal in later patches. > I still see no change-id? Why do you really need a Change-id of a later patch? just look 1-2 patches later, that's it. -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 09 Nov 2018 13:29:56 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11684/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11684/3//COMMIT_MSG@11 PS3, Line 11: this signal in later patches. I still see no change-id? -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Fri, 09 Nov 2018 13:27:59 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11684 to look at the new patch set (#3). Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. abis_nm: Introduce new signal S_NM_GET_ATTR_REP This signal can be used for tools willing to request and parse Attribute Response and do something with the information. ipaccess-config tool will use this signal in later patches. Related: OS#3624 Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 --- M include/osmocom/bsc/signal.h M src/osmo-bsc/abis_nm.c 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/11684/3 -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11684 ) Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11684/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11684/2//COMMIT_MSG@10 PS2, Line 10: and do something with the information. with no-one using it, this patch adds dead code. Either squash the user in here, or refer to a change-id that will add a user. https://gerrit.osmocom.org/#/c/11684/2/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/11684/2/src/osmo-bsc/abis_nm.c@605 PS2, Line 605: osmo_signal_dispatch(SS_NM, S_NM_GET_ATTR_REP, mb); (would it make sense to instead pass the already parsed attributes somehow? Maybe even in a form of msgb->foo pointer ... just thinking) -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Thu, 08 Nov 2018 17:09:07 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11684 to look at the new patch set (#2). Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. abis_nm: Introduce new signal S_NM_GET_ATTR_REP This signal can be used for tools willing to request and parse Attribute Response and do something with the information. Related: OS#3624 Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 --- M include/osmocom/bsc/signal.h M src/osmo-bsc/abis_nm.c 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/11684/2 -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-bsc[master]: abis_nm: Introduce new signal S_NM_GET_ATTR_REP
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11684 Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP .. abis_nm: Introduce new signal S_NM_GET_ATTR_REP This signal can be used for tools willing to request and parse Attribute Response and do something with the information. Related: OS#3624 Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 --- M include/osmocom/bsc/signal.h M src/osmo-bsc/abis_nm.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/11684/1 diff --git a/include/osmocom/bsc/signal.h b/include/osmocom/bsc/signal.h index 1b351aa..62a3d2c 100644 --- a/include/osmocom/bsc/signal.h +++ b/include/osmocom/bsc/signal.h @@ -72,6 +72,7 @@ S_NM_STATECHG_ADM, /* Administrative State changed */ S_NM_OM2K_CONF_RES, /* OM2K Configuration Result */ S_NM_OPSTART_ACK, /* Received OPSTART ACK, arg is struct msgb *oml_msg */ + S_NM_GET_ATTR_REP, /* Received Get Attributes Response, arg is struct msgb *oml_msg */ }; /* SS_LCHAN signals */ diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index ba3801d..94c014c 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -602,6 +602,7 @@ else parse_attr_resp_info_attr(bts, trx, foh, ); + osmo_signal_dispatch(SS_NM, S_NM_GET_ATTR_REP, mb); return 0; } -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol
