Change in osmo-msc[master]: Move enum definition to header file

2019-04-20 Thread Keith Whyte 
Keith Whyte has posted comments on this change. ( 
https://gerrit.osmocom.org/12598 )

Change subject: Move enum definition to header file
..


Patch Set 1: Code-Review-2

This is not needed as it turned out we don't want to check
the value of the bind flags in alert_all_esme()
but only IF we are bound at all.


--
To view, visit https://gerrit.osmocom.org/12598
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte 
Gerrit-CC: Daniel Willmann 
Gerrit-Comment-Date: Sat, 20 Apr 2019 16:56:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Move enum definition to header file

2019-04-20 Thread Keith Whyte 
Keith Whyte has abandoned this change. ( https://gerrit.osmocom.org/12598 )

Change subject: Move enum definition to header file
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/12598
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte 
Gerrit-CC: Daniel Willmann

Change in osmo-msc[master]: Move enum definition to header file

2019-02-05 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12598 )

Change subject: Move enum definition to header file
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h
File src/libmsc/smpp_smsc.h:

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h@22
PS1, Line 22: enum esme_bind {
> I'd sort of like the osmo_* prefix here, but then it's missing in 
> esme_read_state as well... […]
we never put osmo_ prefixes into any symbols/type-names unless they're part of 
an installed library.  libmsc.a is never installed and as such an internal part 
of osmo-msc.  Therefore an osmo* prefix would actually be wrong.



--
To view, visit https://gerrit.osmocom.org/12598
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:24:29 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Move enum definition to header file

2019-02-05 Thread daniel 
daniel has posted comments on this change. ( https://gerrit.osmocom.org/12598 )

Change subject: Move enum definition to header file
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h
File src/libmsc/smpp_smsc.h:

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h@22
PS1, Line 22: enum esme_bind {
I'd sort of like the osmo_* prefix here, but then it's missing in 
esme_read_state as well...and it's not part of libosmo*



--
To view, visit https://gerrit.osmocom.org/12598
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:25:56 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: Move enum definition to header file

2019-01-16 Thread Keith Whyte 
Keith Whyte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12598


Change subject: Move enum definition to header file
..

Move enum definition to header file

Move the definition for the esme bind flags to the header file.
Also corrects a typo in the name of the enum.

Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9
---
M src/libmsc/smpp_smsc.c
M src/libmsc/smpp_smsc.h
2 files changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/98/12598/1

diff --git a/src/libmsc/smpp_smsc.c b/src/libmsc/smpp_smsc.c
index 2350d84..5e27644 100644
--- a/src/libmsc/smpp_smsc.c
+++ b/src/libmsc/smpp_smsc.c
@@ -49,11 +49,6 @@
memset(str, 0, sizeof(*str));   \
rc = smpp34_unpack(type, str, data, len)

-enum emse_bind {
-   ESME_BIND_RX = 0x01,
-   ESME_BIND_TX = 0x02,
-};
-
 const struct value_string smpp_status_strs[] = {
{ ESME_ROK, "No Error" },
{ ESME_RINVMSGLEN,  "Message Length is invalid" },
diff --git a/src/libmsc/smpp_smsc.h b/src/libmsc/smpp_smsc.h
index dc7b7c1..d7a51c1 100644
--- a/src/libmsc/smpp_smsc.h
+++ b/src/libmsc/smpp_smsc.h
@@ -19,6 +19,11 @@
 #define MODE_7BIT  7
 #define MODE_8BIT  8

+enum esme_bind {
+   ESME_BIND_RX = 0x01,
+   ESME_BIND_TX = 0x02,
+};
+
 enum esme_read_state {
READ_ST_IN_LEN = 0,
READ_ST_IN_MSG = 1,

--
To view, visit https://gerrit.osmocom.org/12598
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte