Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/12343 ) Change subject: msc_vty: also show IMEI and IMEISV .. msc_vty: also show IMEI and IMEISV When the VLR subscriber information is shown on the VTY it shows IMSI and TMSI, but not IMEI and IMEISV. Since in some cases this information might be helpful, lets display it as well. Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 --- M src/libmsc/msc_vty.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Pau Espin Pedrol: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 3079bc3..c5d2832 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -641,6 +641,10 @@ if (vsub->tmsi_new != GSM_RESERVED_TMSI) vty_out(vty, "new TMSI: %08X%s", vsub->tmsi_new, VTY_NEWLINE); + if (vsub->imei[0] != '\0') + vty_out(vty, "IMEI: %s%s", vsub->imei, VTY_NEWLINE); + if (vsub->imeisv[0] != '\0') + vty_out(vty, "IMEISV: %s%s", vsub->imeisv, VTY_NEWLINE); vty_out(vty, "Flags: %s", VTY_NEWLINE); vty_out(vty, " IMSI detached: %s%s", -- To view, visit https://gerrit.osmocom.org/12343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 Gerrit-Change-Number: 12343 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: dexter
Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12343 ) Change subject: msc_vty: also show IMEI and IMEISV .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 Gerrit-Change-Number: 12343 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: dexter Gerrit-Comment-Date: Wed, 19 Dec 2018 12:06:48 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV
Hello Stefan Sperling, Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12343 to look at the new patch set (#3). Change subject: msc_vty: also show IMEI and IMEISV .. msc_vty: also show IMEI and IMEISV When the VLR subscriber information is shown on the VTY it shows IMSI and TMSI, but not IMEI and IMEISV. Since in some cases this information might be helpful, lets display it as well. Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 --- M src/libmsc/msc_vty.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/43/12343/3 -- To view, visit https://gerrit.osmocom.org/12343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 Gerrit-Change-Number: 12343 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling
Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV
dexter has posted comments on this change. ( https://gerrit.osmocom.org/12343 ) Change subject: msc_vty: also show IMEI and IMEISV .. Patch Set 2: (2 comments) > Build Started https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc/1076/ https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c@642 PS2, Line 642: if (strlen(vsub->imei)) > Not critical but better for performance reasons, and it only requires one > line change, so I think it […] Done https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c@642 PS2, Line 642: if (strlen(vsub->imei)) > Yeah that would be a better idiom but not critical from my point of view. Done -- To view, visit https://gerrit.osmocom.org/12343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 Gerrit-Change-Number: 12343 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: dexter Gerrit-Comment-Date: Wed, 19 Dec 2018 09:19:30 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12343 ) Change subject: msc_vty: also show IMEI and IMEISV .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c@642 PS2, Line 642: if (strlen(vsub->imei)) > Yeah that would be a better idiom but not critical from my point of view. Not critical but better for performance reasons, and it only requires one line change, so I think it's fair I ask for it :) -- To view, visit https://gerrit.osmocom.org/12343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 Gerrit-Change-Number: 12343 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 17:42:34 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12343 ) Change subject: msc_vty: also show IMEI and IMEISV .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c@642 PS2, Line 642: if (strlen(vsub->imei)) > Simply check like this: […] Yeah that would be a better idiom but not critical from my point of view. -- To view, visit https://gerrit.osmocom.org/12343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 Gerrit-Change-Number: 12343 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 17:35:39 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12343 ) Change subject: msc_vty: also show IMEI and IMEISV .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c@642 PS2, Line 642: if (strlen(vsub->imei)) Simply check like this: if (vsub->imei[0] != '\0') -- To view, visit https://gerrit.osmocom.org/12343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 Gerrit-Change-Number: 12343 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Tue, 18 Dec 2018 11:16:44 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12343 Change subject: msc_vty: also show IMEI and IMEISV .. msc_vty: also show IMEI and IMEISV When the VLR subscriber information is shown on the VTY it shows IMSI and TMSI, but not IMEI and IMEISV. Since in some cases this information might be helpful, lets display it as well. Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 --- M src/libmsc/msc_vty.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/43/12343/1 diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 87adc82..adcf1b1 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -639,6 +639,10 @@ if (vsub->tmsi_new != GSM_RESERVED_TMSI) vty_out(vty, "new TMSI: %08X%s", vsub->tmsi_new, VTY_NEWLINE); + if (strlen(vsub->imei)) + vty_out(vty, "IMEI: %s%s", vsub->imei, VTY_NEWLINE); + if (strlen(vsub->imeisv)) + vty_out(vty, "IMEISV: %s%s", vsub->imeisv, VTY_NEWLINE); #if 0 /* TODO: add this to vlr_subscr? */ -- To view, visit https://gerrit.osmocom.org/12343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 Gerrit-Change-Number: 12343 Gerrit-PatchSet: 1 Gerrit-Owner: dexter
