Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Keith Whyte has submitted this change and it was merged. (
https://gerrit.osmocom.org/11716 )
Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
..
Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Allows dialing of numbers with GSM340_PLAN_UNKNOWN,
for example a number beginning with '*'
Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
---
M src/mncc.c
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
Vadim Yanitskiy: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
diff --git a/src/mncc.c b/src/mncc.c
index 976a671..ea6a9fc 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -397,14 +397,16 @@
static int continue_setup(struct mncc_connection *conn, const struct gsm_mncc
*mncc)
{
- if (mncc->called.plan != GSM340_PLAN_ISDN) {
+ switch (mncc->called.plan) {
+ case GSM340_PLAN_UNKNOWN:
+ case GSM340_PLAN_ISDN:
+ return 1;
+ default:
LOGP(DMNCC, LOGL_ERROR,
- "leg(%u) has non(%d) ISDN dial plan. not supported.\n",
+ "leg(%u) has unsupported(%d) dial plan.\n",
mncc->callref, mncc->called.plan);
return 0;
}
-
- return 1;
}
/* Check + Process MNCC_SETUP_IND (MO call) */
--
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Whyte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Vadim Yanitskiy
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979 Gerrit-Change-Number: 11716 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 12 Nov 2018 16:37:42 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979 Gerrit-Change-Number: 11716 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Mon, 12 Nov 2018 16:12:38 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11716 to look at the new patch set (#3). Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. Allows dialing of numbers with GSM340_PLAN_UNKNOWN, for example a number beginning with '*' Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979 --- M src/mncc.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/16/11716/3 -- To view, visit https://gerrit.osmocom.org/11716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979 Gerrit-Change-Number: 11716 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Vadim Yanitskiy
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/11716 )
Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
..
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c@401
PS2, Line 401: case
The 'case' statements are usually not shifted from 'switch', i.e.:
switch (var) {
case VAL_FOO:
tuwat_foo;
break;
case VAL_ZOO:
tuwat_zoo;
break;
// ...
}
https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c@406
PS2, Line 406: "leg(%u) has unsupported(%d) dial plan.\n",
> We usually indent next lines to content, not to the "(" character, so it
> looks like a space is missi […]
Actually, in this file a single tab is used for that.
I personally prefer exactly this way, instead of mixing
tabs and spaces in order to make it aligned...
--
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-CC: Vadim Yanitskiy
Gerrit-Comment-Date: Mon, 12 Nov 2018 13:43:29 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/11716 )
Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
..
Patch Set 2: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c@400
PS2, Line 400: switch(mncc->called.plan) {
I think we usually use a space between keyword (not functions) and ():
switch ()
I probably did it wrong to in my example in previous patch version, it's one of
my usual typos ;)
https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c@406
PS2, Line 406: "leg(%u) has unsupported(%d) dial plan.\n",
We usually indent next lines to content, not to the "(" character, so it looks
like a space is missing here and in line below.
--
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-CC: Vadim Yanitskiy
Gerrit-Comment-Date: Mon, 12 Nov 2018 13:36:19 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11716 to look at the new patch set (#2). Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. Allows dialing of numbers with GSM340_PLAN_UNKNOWN, for example a number beginning with '*' Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979 --- M src/mncc.c 1 file changed, 9 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/16/11716/2 -- To view, visit https://gerrit.osmocom.org/11716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979 Gerrit-Change-Number: 11716 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Keith Whyte Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Vadim Yanitskiy
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/11716 )
Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c@400
PS1, Line 400: if (mncc->called.plan != GSM340_PLAN_UNKNOWN &&
mncc->called.plan != GSM340_PLAN_ISDN) {
> It could also be a > greater than (1==GSM340_PLAN_ISDN) test. […]
switch case seems a good option for me.
switch(mncc->called.plan) {
case GSM340_PLAN_UNKNOWN:
case GSM340_PLAN_ISDN:
return 1;
default:
LOGP()
return 0;
}
--
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte
Gerrit-CC: Pau Espin Pedrol
Gerrit-CC: Vadim Yanitskiy
Gerrit-Comment-Date: Mon, 12 Nov 2018 09:28:10 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Keith Whyte has posted comments on this change. (
https://gerrit.osmocom.org/11716 )
Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c@400
PS1, Line 400: if (mncc->called.plan != GSM340_PLAN_UNKNOWN &&
mncc->called.plan != GSM340_PLAN_ISDN) {
> Maybe, using a switch statement would be better here?
It could also be a > greater than (1==GSM340_PLAN_ISDN) test.
I don't know. - I don't anticipate ever handling other cases.
--
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte
Gerrit-CC: Vadim Yanitskiy
Gerrit-Comment-Date: Sun, 11 Nov 2018 23:21:47 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/11716 )
Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c@400
PS1, Line 400: if (mncc->called.plan != GSM340_PLAN_UNKNOWN &&
mncc->called.plan != GSM340_PLAN_ISDN) {
Maybe, using a switch statement would be better here?
--
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy
Gerrit-Comment-Date: Sun, 11 Nov 2018 14:04:29 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Keith Whyte has uploaded this change for review. (
https://gerrit.osmocom.org/11716
Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
..
Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
Allows dialing of numbers with GSM340_PLAN_UNKNOWN,
for example a number beginning with '*'
Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
---
M src/mncc.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector
refs/changes/16/11716/1
diff --git a/src/mncc.c b/src/mncc.c
index 976a671..174dda6 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -397,9 +397,9 @@
static int continue_setup(struct mncc_connection *conn, const struct gsm_mncc
*mncc)
{
- if (mncc->called.plan != GSM340_PLAN_ISDN) {
+ if (mncc->called.plan != GSM340_PLAN_UNKNOWN && mncc->called.plan !=
GSM340_PLAN_ISDN) {
LOGP(DMNCC, LOGL_ERROR,
- "leg(%u) has non(%d) ISDN dial plan. not supported.\n",
+ "leg(%u) has non(%d) UNKNOWN/ISDN dial plan. not
supported.\n",
mncc->callref, mncc->called.plan);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte
