Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Vadim Yanitskiy 
Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12259 )

Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments
..

trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

There is no need to (re)define the arguments of UDPLink's constructor.
Let's use non-keyworded variable length argument list (*args).

Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
---
M src/target/trx_toolkit/ctrl_if_bb.py
M src/target/trx_toolkit/ctrl_if_bts.py
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/target/trx_toolkit/ctrl_if_bb.py 
b/src/target/trx_toolkit/ctrl_if_bb.py
index 785636b..fe7f3e8 100644
--- a/src/target/trx_toolkit/ctrl_if_bb.py
+++ b/src/target/trx_toolkit/ctrl_if_bb.py
@@ -34,8 +34,8 @@
tx_freq = None
pm = None

-   def __init__(self, remote_addr, remote_port, bind_addr, bind_port):
-   CTRLInterface.__init__(self, remote_addr, remote_port, 
bind_addr, bind_port)
+   def __init__(self, *udp_link_args):
+   CTRLInterface.__init__(self, *udp_link_args)
log.info("Init CTRL interface for BB (%s)" % self.desc_link())

def parse_cmd(self, request):
diff --git a/src/target/trx_toolkit/ctrl_if_bts.py 
b/src/target/trx_toolkit/ctrl_if_bts.py
index 2dde3e3..cb38b67 100644
--- a/src/target/trx_toolkit/ctrl_if_bts.py
+++ b/src/target/trx_toolkit/ctrl_if_bts.py
@@ -35,8 +35,8 @@
tx_freq = None
pm = None

-   def __init__(self, remote_addr, remote_port, bind_addr, bind_port):
-   CTRLInterface.__init__(self, remote_addr, remote_port, 
bind_addr, bind_port)
+   def __init__(self, *udp_link_args):
+   CTRLInterface.__init__(self, *udp_link_args)
log.info("Init CTRL interface for BTS (%s)" % self.desc_link())

def parse_cmd(self, request):

--
To view, visit https://gerrit.osmocom.org/12259
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
Gerrit-Change-Number: 12259
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12259 )

Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12259
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
Gerrit-Change-Number: 12259
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 11 Dec 2018 18:19:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12259 )

Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12259/1/src/target/trx_toolkit/ctrl_if_bb.py
File src/target/trx_toolkit/ctrl_if_bb.py:

https://gerrit.osmocom.org/#/c/12259/1/src/target/trx_toolkit/ctrl_if_bb.py@37
PS1, Line 37:   def __init__(self, *udp_link_args):
> what about calling it superclass_args or ctrliface_args?
CTRLInterface has no additional arguments, so actually
we only deal with UDPLink arguments. This looks cleaner.



--
To view, visit https://gerrit.osmocom.org/12259
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
Gerrit-Change-Number: 12259
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 11 Dec 2018 18:18:09 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12259 )

Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12259
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
Gerrit-Change-Number: 12259
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 11 Dec 2018 18:15:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12259 )

Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12259/1/src/target/trx_toolkit/ctrl_if_bb.py
File src/target/trx_toolkit/ctrl_if_bb.py:

https://gerrit.osmocom.org/#/c/12259/1/src/target/trx_toolkit/ctrl_if_bb.py@37
PS1, Line 37:   def __init__(self, *udp_link_args):
what about calling it superclass_args or ctrliface_args?



--
To view, visit https://gerrit.osmocom.org/12259
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
Gerrit-Change-Number: 12259
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 11 Dec 2018 18:14:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Vadim Yanitskiy 
Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12259


Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments
..

trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

There is no need to (re)define the arguments of UDPLink's constructor.
Let's use non-keyworded variable length argument list (*args).

Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
---
M src/target/trx_toolkit/ctrl_if_bb.py
M src/target/trx_toolkit/ctrl_if_bts.py
2 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/12259/1

diff --git a/src/target/trx_toolkit/ctrl_if_bb.py 
b/src/target/trx_toolkit/ctrl_if_bb.py
index 785636b..fe7f3e8 100644
--- a/src/target/trx_toolkit/ctrl_if_bb.py
+++ b/src/target/trx_toolkit/ctrl_if_bb.py
@@ -34,8 +34,8 @@
tx_freq = None
pm = None

-   def __init__(self, remote_addr, remote_port, bind_addr, bind_port):
-   CTRLInterface.__init__(self, remote_addr, remote_port, 
bind_addr, bind_port)
+   def __init__(self, *udp_link_args):
+   CTRLInterface.__init__(self, *udp_link_args)
log.info("Init CTRL interface for BB (%s)" % self.desc_link())

def parse_cmd(self, request):
diff --git a/src/target/trx_toolkit/ctrl_if_bts.py 
b/src/target/trx_toolkit/ctrl_if_bts.py
index 2dde3e3..cb38b67 100644
--- a/src/target/trx_toolkit/ctrl_if_bts.py
+++ b/src/target/trx_toolkit/ctrl_if_bts.py
@@ -35,8 +35,8 @@
tx_freq = None
pm = None

-   def __init__(self, remote_addr, remote_port, bind_addr, bind_port):
-   CTRLInterface.__init__(self, remote_addr, remote_port, 
bind_addr, bind_port)
+   def __init__(self, *udp_link_args):
+   CTRLInterface.__init__(self, *udp_link_args)
log.info("Init CTRL interface for BTS (%s)" % self.desc_link())

def parse_cmd(self, request):

--
To view, visit https://gerrit.osmocom.org/12259
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
Gerrit-Change-Number: 12259
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy