osmo-trx[master]: jenkins.sh: enable the cleanup workspace after building

[lynxis lazus]

Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/6911/1/contrib/jenkins.sh
File contrib/jenkins.sh:

Line 86: if [ -z "${INSIDE_CHROOT}" ]; then
> I think this should always be executed, with no condition. Otherwise in the
oh yes. you're right. I just looked at the warning (shellcheck).


-- 
To view, visit https://gerrit.osmocom.org/6911
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib228ff247a72b21b12e8dd4cbe3afe3e858c89d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: Yes

osmo-trx[master]: jenkins.sh: enable the cleanup workspace after building

[Pau Espin Pedrol]

Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/6911/1/contrib/jenkins.sh
File contrib/jenkins.sh:

Line 86: if [ -z "${INSIDE_CHROOT}" ]; then
I think this should always be executed, with no condition. Otherwise in the 
case in which we call us recursively, the workspace won't be cleaned after 
finishing (since this condition won't be true and exit 0 is called after the 
recursive call in line 59.


-- 
To view, visit https://gerrit.osmocom.org/6911
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib228ff247a72b21b12e8dd4cbe3afe3e858c89d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: Yes

[PATCH] osmo-trx[master]: jenkins.sh: enable the cleanup workspace after building

[lynxis lazus]

Review at  https://gerrit.osmocom.org/6911

jenkins.sh: enable the cleanup workspace after building

Emptyness with a literal string will never be zero.

Change-Id: Ib228ff247a72b21b12e8dd4cbe3afe3e858c89d3
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/6911/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index a063b2e..50ad6fd 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -83,6 +83,6 @@
 $MAKE check \
   || cat-testlogs.sh
 
-if [ -z "x${INSIDE_CHROOT}" ]; then
+if [ -z "${INSIDE_CHROOT}" ]; then
 osmo-clean-workspace.sh
 fi

-- 
To view, visit https://gerrit.osmocom.org/6911
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib228ff247a72b21b12e8dd4cbe3afe3e858c89d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus