[S] Change in libosmocore[master]: vty: fix 'write file FILE' breaking 'show startup-config'
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36617?usp=email ) Change subject: vty: fix 'write file FILE' breaking 'show startup-config' .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36617?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I224ae41096c12f544dfe35a2c3f381b3bb3ba75e Gerrit-Change-Number: 36617 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 09:11:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )
Change subject: HTTP_Adapter: allow API users to specifiy custom header
..
Patch Set 3: Code-Review+1
(3 comments)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/f40c2f29_ea003c39
PS3, Line 73: var HeaderLines hdr := { };
You can turn this into a "var template (value) Headerlines hdr := {};"
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/80373014_71280887
PS3, Line 77: hdr := hdr & {valueof(ts_HeaderLine("Host",
valueof(host)))};
...so you don't need to do valueof() each time.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/5c68e4df_b21f5cd1
PS3, Line 84: return f_overlay_HTTP_Header(hdr, custom_hdr);
then f_overlay_HTTP_Header could receive a "template (value)", or do valueof()
once here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57
Gerrit-Change-Number: 36504
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: dexter
Gerrit-Comment-Date: Mon, 22 Apr 2024 09:23:30 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[S] Change in libosmocore[master]: vty: fix memleak in host_config_set()
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36616?usp=email ) Change subject: vty: fix memleak in host_config_set() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I356818aae3addab6db39de9a625453b7435b7cc1 Gerrit-Change-Number: 36616 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 09:10:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. Patch Set 6: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/1d9fed5d_9cb59d3b PS6, Line 3748: f_pdp_ctx_act(apars); > sounds a bit we'd need multiple test cases: one where the assigned address == > the requested address, […] @vyanits...@sysmocom.de I'd got for testing dynamic addr (empty buffer) in CreatePDPContext, that's the way we usually set up the network (osmo-ggsn doesn't even support static addresses afair). If you want to still test the static address case, then add a second test. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 09:18:42 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in libosmocore[master]: tests: do not copy *.cfg files to the build directory
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36614?usp=email ) Change subject: tests: do not copy *.cfg files to the build directory .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I74e428f0548418fdecada3d25049d6e110e790fe Gerrit-Change-Number: 36614 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 09:03:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email )
Change subject: HTTP_Adapter: allow body to be "omit"
..
Patch Set 3:
(2 comments)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/c9fd2153_aac7be89
PS1, Line 85: msg.request := {
> Thanks for the hint, I didn't see this option. I have now done it this way.
> […]
Ack I see. the template you changed indeed looks better now though
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/56fe5e3b_8b707392
PS3, Line 106: header := valueof(f_ts_HTTP_Header(body, host,
custom_hdr)),
You don't need to call valueof() here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff
Gerrit-Change-Number: 36505
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: dexter
Gerrit-Comment-Date: Mon, 22 Apr 2024 09:26:06 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 22 Apr 2024 06:01:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: fixup: sgsn: fix unused param in f_routing_area_update()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email ) Change subject: fixup: sgsn: fix unused param in f_routing_area_update() .. Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging myself to fix ttcn3-sgsn-test on Jenkins. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f Gerrit-Change-Number: 36613 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Apr 2024 09:52:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: fixup: sgsn: fix unused param in f_routing_area_update()
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email )
Change subject: fixup: sgsn: fix unused param in f_routing_area_update()
..
fixup: sgsn: fix unused param in f_routing_area_update()
In 1ee1edd2 I changed f_routing_area_update() to actually use the
given RAI as Old RAI in the Routing Area Update Request. Not only
this broke the testcase scenario (Old RAI shall remain unchanged!),
but also started triggering a use-after-free bug in osmo-sgsn.
Passing 'ran_index := 1' is enough for the second Routing Area Update
Request to show up with a different RAI (at BSSGP level), however the
Old RAI IE shall obviously indicate the *old* RAI, not the new one.
A follow-up commit will add a separate testcase to reproduce the
use-after-free problem in osmo-sgsn.
Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f
Fixes: 1ee1edd2 "sgsn: fix unused param in f_routing_area_update()"
Related: OS#6439
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 24 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 67e815b..0371e29 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2734,7 +2734,7 @@
f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]);
log("sending second RAU via different RA");
- f_routing_area_update(f_cellid_to_RAI(g_pars.bssgp_cell_id[1]),
ran_index := 1);
+ f_routing_area_update(old_ra := g_pars.ra, ran_index := 1);
f_detach_mo(c_GMM_DTT_MO_GPRS, true, true, 1);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f
Gerrit-Change-Number: 36613
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-ttcn3-hacks[master]: fixup: sgsn: fix unused param in f_routing_area_update()
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email ) Change subject: fixup: sgsn: fix unused param in f_routing_area_update() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f Gerrit-Change-Number: 36613 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 09:13:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in meta-telephony[201705]: Remove User= and Group= from systemd service files
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email )
Change subject: Remove User= and Group= from systemd service files
..
Remove User= and Group= from systemd service files
Service files of Osmocom programs will have User= and Group= in the
future, so these don't run as root. It was decided that for OE-based
systems, we will still run them as root for now.
Related: OS#5684, OS#4107
Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c
---
M recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
M recipes-osmocom/osmo-bsc/osmo-bsc.inc
M recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc
M recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
M recipes-osmocom/osmo-hlr/osmo-hlr.inc
M recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc
M recipes-osmocom/osmo-mgw/osmo-mgw.inc
M recipes-osmocom/osmo-msc/osmo-msc.inc
M recipes-osmocom/osmo-pcap/osmo-pcap.inc
M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
M recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc
11 files changed, 81 insertions(+), 18 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/18/36618/1
diff --git a/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
b/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
index 0f1f28d..34454b1 100644
--- a/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
+++ b/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
@@ -3,7 +3,7 @@
HOMEPAGE = "https://osmocom.org/projects/libosmo-sccp;
LICENSE = "AGPLv3"
-INC_PR="r2.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r3.${META_TELEPHONY_OSMO_INC}"
LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
@@ -18,10 +18,14 @@
# access symbols not starting with osmo_*
EXTRA_OECONF_remove = "--disable-static"
-# StateDirectory requires systemd >= v235, but poky pyro ships with v232
(SYS#6340):
do_install_append() {
+ # StateDirectory requires systemd >= v235, but poky pyro ships with
v232 (SYS#6340):
sed -i '/^StateDirectory=/d'
"${D}${systemd_system_unitdir}/osmo-stp.service"
sed -i '/^WorkingDirectory=/d'
"${D}${systemd_system_unitdir}/osmo-stp.service"
+
+ # Run as root (OS#5684):
+ sed -i '/^User=/d' "${D}${systemd_system_unitdir}/osmo-stp.service"
+ sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/osmo-stp.service"
}
PACKAGES =+ "osmo-stp"
diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc.inc
b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
index 50e8f9b..1c56123 100644
--- a/recipes-osmocom/osmo-bsc/osmo-bsc.inc
+++ b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
@@ -5,7 +5,7 @@
DEPENDS = "sqlite3 libpcap libosmocore libosmo-abis libosmo-sccp libosmo-netif
osmo-mgw"
-INC_PR="r2.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r3.${META_TELEPHONY_OSMO_INC}"
inherit autotools pkgconfig systemd
@@ -14,10 +14,14 @@
"
PACKAGECONFIG[systemd] =
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
-# StateDirectory requires systemd >= v235, but poky pyro ships with v232
(SYS#6340):
do_install_append() {
+ # StateDirectory requires systemd >= v235, but poky pyro ships with
v232 (SYS#6340):
sed -i '/^StateDirectory=/d'
"${D}${systemd_system_unitdir}/${PN}.service"
sed -i '/^WorkingDirectory=/d'
"${D}${systemd_system_unitdir}/${PN}.service"
+
+ # Run as root (OS#5684):
+ sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service"
+ sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service"
}
PACKAGES =+ "meas-utils ipaccess-utils bs11-utils abisip-find"
diff --git a/recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc
b/recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc
index aff20fa..6c87dda 100644
--- a/recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc
+++ b/recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc
@@ -5,7 +5,7 @@
DEPENDS = "libosmocore"
-INC_PR="r1.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r2.${META_TELEPHONY_OSMO_INC}"
inherit autotools pkgconfig systemd
@@ -14,10 +14,14 @@
"
PACKAGECONFIG[systemd] =
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"
-# StateDirectory requires systemd >= v235, but poky pyro ships with v232
(SYS#6340):
do_install_append() {
+ # StateDirectory requires systemd >= v235, but poky pyro ships with
v232 (SYS#6340):
sed -i '/^StateDirectory=/d'
"${D}${systemd_system_unitdir}/${PN}.service"
sed -i '/^WorkingDirectory=/d'
"${D}${systemd_system_unitdir}/${PN}.service"
+
+ # Run as root (OS#5684):
+ sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service"
+ sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service"
}
SYSTEMD_SERVICE_osmo-gbproxy = "osmo-gbproxy.service"
diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
index 58b93f0..276ac47 100644
--- a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
+++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc
@@ -5,7 +5,7 @@
DEPENDS
[S] Change in libosmocore[master]: tests: rename logging_test_gsmtap -> logging_gsmtap_test
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email ) Change subject: tests: rename logging_test_gsmtap -> logging_gsmtap_test .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 09:09:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: vty: fix 'write file FILE' breaking 'show startup-config'
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36617?usp=email ) Change subject: vty: fix 'write file FILE' breaking 'show startup-config' .. Patch Set 1: -Code-Review (1 comment) Patchset: PS1: I think the commit is lacking rationale on why it isn't updating host.config anymore. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36617?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I224ae41096c12f544dfe35a2c3f381b3bb3ba75e Gerrit-Change-Number: 36617 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 09:12:59 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in meta-telephony[201705]: Remove User= and Group= from systemd service files
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email ) Change subject: Remove User= and Group= from systemd service files .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c Gerrit-Change-Number: 36618 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 22 Apr 2024 09:20:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )
Change subject: HTTP_Adapter: allow API users to specifiy custom header
..
Patch Set 3:
(1 comment)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/e0dfdaf4_aeb63212
PS2, Line 72: hdr := hdr & {{ header_name := "Host", header_value :=
valueof(host) }};
> hint: I usually find it way more readable to use templates instead of filling
> records, eg: […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57
Gerrit-Change-Number: 36504
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: pespin
Gerrit-Comment-Date: Mon, 22 Apr 2024 09:20:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: allow body to be "omit" .. HTTP_Adapter: allow body to be "omit" In HTTP not all requests have a body. At the moment we describe a missing body with body := "". This is not 100% correct since the rest of the code interprets this as a present body with zero length and will put a content_length = 0 header line into the HTTP header, even in the GET request. This will most likely be ignored by any HTTP server, but it is still not 100% spec compliant. Related: SYS#6824 Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff --- M library/HTTP_Adapter.ttcn 1 file changed, 28 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/36505/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: allow API users to specifiy custom header .. HTTP_Adapter: allow API users to specifiy custom header At the moment HTTP_Adapter can only make requests with a fixed pre-defined HTTP header. However, some application may require additional custom header lines or different values than the ones specified in the pre-defined HTTP header. Related: SYS#6824 Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 --- M library/HTTP_Adapter.ttcn 1 file changed, 68 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/36504/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 Gerrit-Change-Number: 36504 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email )
Change subject: HTTP_Adapter: allow body to be "omit"
..
Patch Set 3:
(2 comments)
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/76dfe2ed_b6e9b35d
PS1, Line 85: msg.request := {
> why can't you just do something like: […]
Thanks for the hint, I didn't see this option. I have now done it this way.
The body field is a mandatory field in type record HTTPRequest. When I set it
to omit I also get an error. The body field must be present but it can be empty
(""). I have the feeling that the API is a bit miss-designed here, but we have
to live with that.
File library/HTTP_Adapter.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/710f732f_4dbdfdc5
PS2, Line 100: if (ispresent(body)) {
> I'm not that sure this ispresent(body) directly on a variable is what you are
> actually want. […]
yes, I have tested it, but I also think that istemplatekind() is the better
option.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff
Gerrit-Change-Number: 36505
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: pespin
Gerrit-Comment-Date: Mon, 22 Apr 2024 09:20:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: put HTTP config options into a record
Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: HTTP_Adapter: put HTTP config options into a record .. HTTP_Adapter: put HTTP config options into a record The function f_http_init currently takes only two config options. For the moment this is not a problem, but the amount of additional options may grow in the future. So let's put the options in a record to have them separate. Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Related: SYS#6824 --- M cbc/CBC_Tests.ttcn M library/HTTP_Adapter.ttcn M remsim/RemsimServer_Tests.ttcn 3 files changed, 34 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/36603/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Gerrit-Change-Number: 36603 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[M] Change in meta-telephony[201705]: Remove User= and Group= from systemd service files
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email ) Change subject: Remove User= and Group= from systemd service files .. Remove User= and Group= from systemd service files Service files of Osmocom programs will have User= and Group= in the future, so these don't run as root. It was decided that for OE-based systems, we will still run them as root for now. Related: OS#5684, OS#4107 Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c --- M recipes-osmocom/libosmo-sccp/libosmo-sccp.inc M recipes-osmocom/osmo-bsc/osmo-bsc.inc M recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc M recipes-osmocom/osmo-ggsn/osmo-ggsn.inc M recipes-osmocom/osmo-hlr/osmo-hlr.inc M recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc M recipes-osmocom/osmo-mgw/osmo-mgw.inc M recipes-osmocom/osmo-msc/osmo-msc.inc M recipes-osmocom/osmo-pcap/osmo-pcap.inc M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc M recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc 11 files changed, 83 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/18/36618/2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c Gerrit-Change-Number: 36618 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-MessageType: newpatchset
[M] Change in meta-telephony[201705]: Remove User= and Group= from systemd service files
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email ) Change subject: Remove User= and Group= from systemd service files .. Patch Set 2: Verified+1 (1 comment) Patchset: PS2: did a test build on deb8-oe-userbuilds -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c Gerrit-Change-Number: 36618 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 22 Apr 2024 08:48:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" .. Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" This reverts commit e9c6c7b97ee5b870212c54a08064acbde5670d5d which breaks all of the test cases reliably. I'm surprised how it got submitted in the first place, as it can never have worked. It uses 127.0.0.1:2905 on both the STP and the HNBGW side. Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 --- M hnbgw/osmo-hnbgw.cfg 1 file changed, 18 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/36619/1 diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg index 2ed6905..8a9774b 100644 --- a/hnbgw/osmo-hnbgw.cfg +++ b/hnbgw/osmo-hnbgw.cfg @@ -2,26 +2,18 @@ ! OsmoHNBGW (1.1.0) configuration saved from vty !! ! -log gsmtap 127.0.0.1 - logging level set-all debug - logging filter all 1 -! log stderr logging filter all 1 - logging color 0 - logging print category-hex 0 + logging color 1 + logging print category-hex 1 logging print category 1 - logging print level 1 logging print thread-id 0 logging print extended-timestamp 1 - logging print file basename last + logging print file 1 logging level set-all debug ! line vty no login - bind 0.0.0.0 -ctrl - bind 0.0.0.0 ! stats interval 0 @@ -35,42 +27,30 @@ enable cs7 instance 0 - asp asp-clnt-msc-0 2905 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.2 - role asp - sctp-role client point-code 0.23.5 + sccp-address msc-naught - routing-indicator PC point-code 0.23.4 sccp-address msc-one - routing-indicator PC point-code 0.0.2 sccp-address msc-two - routing-indicator PC point-code 0.0.3 sccp-address msc-three - routing-indicator PC point-code 0.0.4 sccp-address sgsn-naught - routing-indicator PC point-code 0.23.1 sccp-address sgsn-one - routing-indicator PC point-code 0.1.2 sccp-address sgsn-two - routing-indicator PC point-code 0.1.3 sccp-address sgsn-three - routing-indicator PC point-code 0.1.4 hnbgw @@ -79,9 +59,6 @@ local-ip 127.0.0.1 local-port 29169 hnbap-allow-tmsi 1 - mgw 0 - mgw local-ip 127.0.0.1 - mgw remote-ip 127.0.0.1 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 # reduce default X31 from 15 seconds -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
[M] Change in osmo-ttcn3-hacks[master]: RUA_Emulation: Support decode of L3/DTAP inside RANAP
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36620?usp=email )
Change subject: RUA_Emulation: Support decode of L3/DTAP inside RANAP
..
RUA_Emulation: Support decode of L3/DTAP inside RANAP
... similar to what we support in the RAN_Emulation module.
Change-Id: Id934e73ace7d0a0eb7242a8fa926b7eabe0c7770
---
M hnbgw/HNBGW_Tests.ttcn
M library/RAN_Emulation.ttcnpp
M library/rua/RUA_Emulation.ttcn
3 files changed, 127 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/20/36620/1
diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index 3369e37..a53187a 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -499,7 +499,9 @@
/* RUA/RANAP emulation on top of lower-layer Iuh */
var RuaOps rua_ops := {
create_cb := refers(IuhRanapCreateCallback),
- unitdata_cb := refers(IuhRanapUnitdataCallback)
+ unitdata_cb := refers(IuhRanapUnitdataCallback),
+ decode_dtap := false,
+ role_ms := true
};
for (var integer i := 0; i < g_num_hnbs; i := i+1) {
g_hnb_cfg[i] := {
diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp
index fbe921d..25c6a49 100644
--- a/library/RAN_Emulation.ttcnpp
+++ b/library/RAN_Emulation.ttcnpp
@@ -62,6 +62,8 @@
import from RANAP_Templates all;
#endif
+friend module RUA_Emulation;
+
/* General "base class" component definition, of which specific implementations
* derive themselves by means of the "extends" feature */
type component RAN_ConnHdlr {
@@ -580,7 +582,7 @@
ranap := ranap
};
-private function fake_dlci_from_sapi(template (omit) SAPI sapi) return
template (omit) OCT1
+friend function fake_dlci_from_sapi(template (omit) SAPI sapi) return template
(omit) OCT1
{
if (istemplatekind(sapi, "omit")) {
return omit;
diff --git a/library/rua/RUA_Emulation.ttcn b/library/rua/RUA_Emulation.ttcn
index a9c445e..4560ad2 100644
--- a/library/rua/RUA_Emulation.ttcn
+++ b/library/rua/RUA_Emulation.ttcn
@@ -17,7 +17,7 @@
* If a pre-existing component wants to register to handle future inbound
connection,
* it can do so by registering an "expect" with the expected RANAP payload.
- * (C) 2022 by Harald Welte
+ * (C) 2022-2024 by Harald Welte
* All rights reserved.
*
* Released under the terms of GNU General Public License, Version 2 or
@@ -26,8 +26,10 @@
import from General_Types all;
import from Osmocom_Types all;
+import from MobileL3_Types all;
import from Iuh_Emulation all;
+import from RAN_Emulation all; // for PDU_DTAP_MO / PDU_DTAP_MT
import from RUA_Templates all;
//import from RUA_Constants all;
@@ -54,6 +56,8 @@
/* port between individual per-connection components and this dispatcher */
type port RUA_Conn_PT message {
inout RANAP_PDU,
+ PDU_DTAP_MO, PDU_DTAP_MT,
+ PDU_DTAP_PS_MO, PDU_DTAP_PS_MT,
RUA_Conn_Req,
RUA_Disc_Req,
RUA_Disc_Ind;
@@ -113,9 +117,9 @@
type record RuaOps {
RanapCreateCallback create_cb optional,
- RanapUnitdataCallback unitdata_cb optional
- //boolean deode_dtap
- //boolean role_ms
+ RanapUnitdataCallback unitdata_cb optional,
+ boolean decode_dtap,
+ boolean role_ms
};
private function f_context_id_known(ContextId context_id)
@@ -240,10 +244,56 @@
return g_rua_ops.unitdata_cb.apply(ranap);
}
-private function f_handle_userData_RANAP(RUA_ConnHdlr client, RANAP_PDU ranap)
+private function f_handle_userData_RANAP(RUA_ConnHdlr client,
RUA_IEs.CN_DomainIndicator domain_ind, RANAP_PDU ranap)
runs on RUA_Emulation_CT {
- /* TODO: L3 decoding, if requested */
- CLIENT.send(ranap) to client;
+ var template (omit) octetstring l3 := f_ranap_extract_l3(ranap);
+ if (istemplatekind(l3, "omit") or not g_rua_ops.decode_dtap) {
+ CLIENT.send(ranap) to client;
+ } else {
+ var template (omit) SAPI sapi := f_ranap_extract_sapi(ranap);
+ var template (omit) OCT1 dlci := fake_dlci_from_sapi(sapi);
+ if (g_rua_ops.role_ms) {
+ if (domain_ind == ps_domain) {
+ var PDU_DTAP_PS_MT mt := {
+ dlci := omit,
+ dtap := dec_PDU_L3_SGSN_MS(valueof(l3))
+ };
+ if (isvalue(dlci)) {
+ mt.dlci := valueof(dlci);
+ }
+ CLIENT.send(mt) to client;
+ } else {
+ var PDU_DTAP_MT mt := {
+ dlci := omit,
+
[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" .. Patch Set 1: (1 comment) File hnbgw/osmo-hnbgw.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/9758ec6f_36b71792 PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua > That was my fault, I wrongly assumed the osmo-stp was listneing on 127.0.0.2 > only. […] I tried for >= 10 minutes in several iterations to adjust osmo-stp config to get it to work with your change here, but failed to. I'm not arguing against the goal of this patch. I'm arguing for reverting what seems an untested patch that causes regressions. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 22 Apr 2024 10:59:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. Patch Set 6: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/be34a9b2_441b8d55 PS6, Line 3748: f_pdp_ctx_act(apars); > @vyanitskiy@sysmocom. […] I don't think it really matters for this specific test scenario whether the requested IP address matches the assigned one. Likewise, I don't think it matters here whether we allocate IP address statically or dynamically. Just to clarify: I was not the one implementing `f_pdp_ctx_act()`, so I am simply trying to use the existing code base. What you suggest makes sense for those testcases specifically testing the PDP Context Activation procedure. And AFAICS, the existing testcases do not cover these scenarios, unfortunately. Here I just want to make sure that osmo-sgsn provides the `PDP Context IE` in `SGSN Context Response`. The IP address assignment approach is a less significant detail preceding the "core" phase of the test scenario. I have two options with the existing code base: * a) leave `apars.addr.addressInfo` empty (`omit`) - this is the default, and this results in a PDP Context activated with no address at all. The testcase is failing because osmo-sgsn does not include the `PDP Context IE`. * b) assign a valid address to `apars.addr.addressInfo` - this is what I did in the last patch revision and got the testcase passing. Regarding a), @dwillm...@sysmocom.de told me that it's impossible to encode a `PDP Context IE` in `SGSN Context Response` without an IP address. I just checked 3GPP TS 29.060, section 7.7.29 myself, and AFAICS it **is** possible: we can simply set `PDP Address Length` to 0. So all in all, I can: * stick to b) merging the current patch revision; * fix osmo-sgsn to handle PCP contexts with empty IP address correctly (is this even a valid scenario on practice?) and revert back to the previous patch revision a); * spend more hours on improving the testsuite, implementing additional testcases for static vs dynamic + requested != assigned scenarios (this goes beyond the scope of OS#6294). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Comment-Date: Mon, 22 Apr 2024 12:02:33 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[M] Change in docker-playground[master]: ttcn3-sgsn-test: add config files for running SNS testcases
Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email ) Change subject: ttcn3-sgsn-test: add config files for running SNS testcases .. Patch Set 2: (1 comment) File ttcn3-sgsn-test/sns/SGSN_Tests.cfg: https://gerrit.osmocom.org/c/docker-playground/+/36623/comment/9ca594dc_c91bdb18 PS2, Line 46: SGSN_Tests_NS.control See, you are assing it here, why adding it to the other already exiting SGSN_Tests.cfg in the previous commit? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I767ec223585002d6420eda27ed338722f764c902 Gerrit-Change-Number: 36623 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 12:49:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-sgsn-test-sns[-latest]
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36624?usp=email ) Change subject: jobs/ttcn3: add ttcn3-sgsn-test-sns[-latest] .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36624?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iefd81a081fa29af35fc7d575ea23e464c165dbc7 Gerrit-Change-Number: 36624 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 12:49:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: IPAd_Tests: add testsuite for an IPAd .. IPAd_Tests: add testsuite for an IPAd With this patch we add a testsuite that can be used to test an IPAd implementation. The testsuite emulates the ESipa and the ES10x (pcsc cardreader) interface and is capable of testing a direct profile download and other ESipa features like the execution of an eIM package (eCO, PSMO). Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Related: SYS#6564 --- M Makefile A ipad/IPAd_Tests.cfg A ipad/IPAd_Tests.default A ipad/IPAd_Tests.ttcn A ipad/example_ca/easyrsa A ipad/example_ca/openssl-easyrsa.cnf A ipad/example_ca/pki/.rnd A ipad/example_ca/pki/ca.crt A ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem A ipad/example_ca/pki/extensions.temp A ipad/example_ca/pki/index.txt A ipad/example_ca/pki/index.txt.attr A ipad/example_ca/pki/index.txt.old A ipad/example_ca/pki/issued/alttest.cabundle A ipad/example_ca/pki/issued/alttest.crt A ipad/example_ca/pki/issued/alttest.notes A ipad/example_ca/pki/openssl-easyrsa.cnf A ipad/example_ca/pki/openssl-easyrsa.temp A ipad/example_ca/pki/private/alttest.key A ipad/example_ca/pki/private/ca.key A ipad/example_ca/pki/reqs/alttest.req A ipad/example_ca/pki/safessl-easyrsa.cnf A ipad/example_ca/pki/serial A ipad/example_ca/pki/serial.old A ipad/example_ca/vars A ipad/example_ca/x509-types A ipad/gen_links.sh A ipad/regen_makefile.sh M regen-makefile.sh 29 files changed, 1,942 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/36229/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 5: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/5a161917_a58bb9d5 PS5, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9025cf30_b1249639 PS5, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/75cc4002_38733a7b PS5, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/24e0a23a_b199fa47 PS5, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/26cc0cb4_a63970e1 PS5, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9044f961_d610206d PS5, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/7dfaf612_3391979f PS5, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/2e3fee0b_ce09d594 PS5, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/aae267dd_75eaed38 PS5, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a672ad5e_d9af6bb8 PS5, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f3b87cae_8d35d19e PS5, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/44fb7ab7_ba30aa5b PS5, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/343257f2_ab7ed785 PS5, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 22 Apr 2024 11:49:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[L] Change in osmo-ttcn3-hacks[master]: ipad: add an extra certificate+bundle for host "testsuite"
Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email ) Change subject: ipad: add an extra certificate+bundle for host "testsuite" .. Patch Set 2: (12 comments) File ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/82a43e78_badafbcd PS2, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/78fe499a_f1ae02fd PS2, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/30dd9d90_779f6a56 PS2, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/d8a1ecf5_46651129 PS2, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/f999520c_fbe73190 PS2, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/180f1117_52903eb7 PS2, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/testsuite.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/4dcfbb61_922a0173 PS2, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/3b2592ca_840bef84 PS2, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/f27cc486_84f0ef37 PS2, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/c05fccf5_35169050 PS2, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/ba71fe30_fc1b49e4 PS2, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/39b51160_ad3243a2 PS2, Line 49: X509v3 Subject Alternative Name: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2d4ba8b710b9cf518b90c7f7acc8982350705531 Gerrit-Change-Number: 36621 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 22 Apr 2024 11:49:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in docker-playground[master]: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email ) Change subject: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control .. Patch Set 2: (1 comment) Patchset: PS2: I'm a bit lost here. If they need another set of config files + jenkins.sh, why adding this .control here? It should be only on the other .cfg file running those? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7 Gerrit-Change-Number: 36622 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 12:49:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[M] Change in meta-telephony[201705]: Remove User= and Group= from systemd service files
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email ) Change subject: Remove User= and Group= from systemd service files .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c Gerrit-Change-Number: 36618 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 22 Apr 2024 13:07:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in docker-playground[master]: ttcn3-sgsn-test: add config files for running SNS testcases
Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email ) Change subject: ttcn3-sgsn-test: add config files for running SNS testcases .. Patch Set 2: Verified+1 (1 comment) Patchset: PS2: I tested this by running `./jenkins-sns.sh` locally, all testcases passed. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I767ec223585002d6420eda27ed338722f764c902 Gerrit-Change-Number: 36623 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 22 Apr 2024 12:31:29 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in docker-playground[master]: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email ) Change subject: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control .. Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: > ``` […] AH! NS vs SNS, got it -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7 Gerrit-Change-Number: 36622 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 12:52:41 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai
Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email )
Change subject: sgsn: add TC_attach_rau_invalid_old_rai
..
Patch Set 2:
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625/comment/f731f277_9dda5043
PS2, Line 2758: private function f_TC_attach_rau_invalid_old_rai(charstring id)
runs on BSSGP_ConnHdlr {
Probably a short comment explaining here what the test specific aim is may be
good for other readers, also probably with a ref to the OS# ticket.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Gerrit-Change-Number: 36625
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Mon, 22 Apr 2024 14:03:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" .. Patch Set 1: (1 comment) File hnbgw/osmo-hnbgw.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/6089fd75_f6dcffc0 PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua That was my fault, I wrongly assumed the osmo-stp was listneing on 127.0.0.2 only. Still I think it makes sense to simply fix the local port in here to 0 or alike, since the other config changes are useful and updating from old setups where syntax was deprecated or expected to provide explicit config. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 22 Apr 2024 10:35:25 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: remove unrelated template parameter
Attention is currently required from: dexter. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SGP32Definitions_Templates: remove unrelated template parameter .. SGP32Definitions_Templates: remove unrelated template parameter The template parameter eimFqdn is not relevant for this kind of template. Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b Related: SYS#6563 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/36605/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b Gerrit-Change-Number: 36605 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[S] Change in osmo-ci[master]: jobs/ttcn3: run io_uring testsuites on all nodes
osmith has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email )
Change subject: jobs/ttcn3: run io_uring testsuites on all nodes
..
jobs/ttcn3: run io_uring testsuites on all nodes
After most recent patches from Pau were merged, the io_uring testsuites
run on all jenkins nodes with the ttcn3 label again!
host2-deb11build-ansible has an older host kernel and needs ulimit
memlock increased to 1 GB. I've tried out e.g. 500 MB and it isn't
enough.
Closes: OS#6405
Change-Id: I59b9a7c3928281a0557c17629029adcbc5ae7410
---
M jobs/ttcn3-testsuites.yml
1 file changed, 19 insertions(+), 8 deletions(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index a60c2a6..2e01645 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -219,25 +219,18 @@
# With LIBOSMO_IO_BACKEND=IO_URING (OS#6357)
- ttcn3-bsc-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-msc-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-hnbgw-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-gbproxy-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-sgsn-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-stp-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- ttcn3-mgw-test-io_uring:
timer: H 11 * * *
- node: io_uring # OS#6405
- job-template:
name: '{job-name}'
@@ -308,7 +301,8 @@
;;
*-io_uring)
DIR="$(echo "{job-name}" | sed s/\-io_uring$//)"
- export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING"
+ # OS#6405: set memlock to 1 GB for older kernels
+ export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING --ulimit
memlock=100"
;;
*-latest)
DIR="$(echo "{job-name}" | sed s/\-latest$//)"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I59b9a7c3928281a0557c17629029adcbc5ae7410
Gerrit-Change-Number: 36602
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in docker-playground[master]: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email ) Change subject: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control .. ttcn3-sgsn-test: add missing SGSN_Tests_NS.control Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7 Related: osmo-ttcn3-hacks.git Ib2bffbb110961474928f35d212cb492d4b6fdee0 --- M ttcn3-sgsn-test/SGSN_Tests.cfg 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/22/36622/1 diff --git a/ttcn3-sgsn-test/SGSN_Tests.cfg b/ttcn3-sgsn-test/SGSN_Tests.cfg index 6fd2ae8..d3d1ee7 100644 --- a/ttcn3-sgsn-test/SGSN_Tests.cfg +++ b/ttcn3-sgsn-test/SGSN_Tests.cfg @@ -74,3 +74,4 @@ [EXECUTE] SGSN_Tests.control SGSN_Tests_Iu.control +SGSN_Tests_NS.control -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7 Gerrit-Change-Number: 36622 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" .. Patch Set 1: (1 comment) File hnbgw/osmo-hnbgw.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/347713cd_c845d648 PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua > To make it clear: This patch slowed me down significantly in working on tests > for new customer-relev […] I'm sorry for that. Next time I'll better leave it as WIP for somebody using the osmo-ttcn3-hacks setup directly to give it a try to avoid unexpected breakage. Maybe simply drop the "asp" node in here for now but leave the other stuff not revertd, afaict that should be fine. Feel free to merge this patch if it's still causing hassle. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 22 Apr 2024 11:53:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-sgsn-test-sns[-latest]
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36624?usp=email ) Change subject: jobs/ttcn3: add ttcn3-sgsn-test-sns[-latest] .. jobs/ttcn3: add ttcn3-sgsn-test-sns[-latest] Change-Id: Iefd81a081fa29af35fc7d575ea23e464c165dbc7 Depends: docker-playground.git I767ec223585002d6420eda27ed338722f764c902 --- M jobs/ttcn3-testsuites.yml 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/24/36624/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index a60c2a6..830b549 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -75,6 +75,8 @@ timer: H 05 * * * - ttcn3-sgsn-test: timer: H 05 * * * + - ttcn3-sgsn-test-sns: + timer: H 05 * * * - ttcn3-bsc-test: timer: H 05 * * * - ttcn3-mgw-test: @@ -166,6 +168,8 @@ timer: H 08 * * * - ttcn3-sgsn-test-latest: timer: H 08 * * * + - ttcn3-sgsn-test-sns-latest: + timer: H 08 * * * - ttcn3-bsc-test-latest: timer: H 08 * * * - ttcn3-mgw-test-latest: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36624?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iefd81a081fa29af35fc7d575ea23e464c165dbc7 Gerrit-Change-Number: 36624 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
[M] Change in docker-playground[master]: ttcn3-sgsn-test: add config files for running SNS testcases
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email ) Change subject: ttcn3-sgsn-test: add config files for running SNS testcases .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I767ec223585002d6420eda27ed338722f764c902 Gerrit-Change-Number: 36623 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 22 Apr 2024 12:30:04 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sgsn: add TC_attach_rau_invalid_old_rai .. sgsn: add TC_attach_rau_invalid_old_rai This testcase currently crashes osmo-sgsn. Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147 Related: OS#6441 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 57 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/36625/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147 Gerrit-Change-Number: 36625 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: put HTTP config options into a record
Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: put HTTP config options into a record .. HTTP_Adapter: put HTTP config options into a record The function f_http_init currently takes only two config options. For the moment this is not a problem, but the amount of additional options may grow in the future. So let's put the options in a record to have them separate. Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Related: SYS#6824 --- M cbc/CBC_Tests.ttcn M library/HTTP_Adapter.ttcn M remsim/RemsimServer_Tests.ttcn 3 files changed, 36 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/36603/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Gerrit-Change-Number: 36603 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[S] Change in docker-playground[master]: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control
Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email )
Change subject: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control
..
Patch Set 2:
(1 comment)
Patchset:
PS2:
> SNS testcases need another set; NS testcases do not.
```
106 control {
107
108 if (mp_nsconfig[0].handle_sns) {
109 execute( TC_SNS_size() );
110 execute( TC_SNS_size_too_big() );
111 execute( TC_SNS_config_bss() );
112 execute( TC_SNS_config_sgsn() );
113 execute( TC_SNS_and_alive() );
114 } else {
115 execute( TC_NS_connect_alive() );
116 execute( TC_NS_connect_reset() );
117 }
118 }
```
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7
Gerrit-Change-Number: 36622
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Attention: pespin
Gerrit-Comment-Date: Mon, 22 Apr 2024 12:51:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Allow API users to enable/disable SSL
Attention is currently required from: dexter, laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: Allow API users to enable/disable SSL .. HTTP_Adapter: Allow API users to enable/disable SSL At the moment HTTP_Adapter has no option to enable SSL Related: SYS#6824 Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319 --- M library/HTTP_Adapter.ttcn 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/36506/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319 Gerrit-Change-Number: 36506 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Attention: laforge Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" .. Patch Set 1: (1 comment) File hnbgw/osmo-hnbgw.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/e7de9d1c_79f0e0f3 PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua > I tried for >= 10 minutes in several iterations to adjust osmo-stp config to > get it to work with you […] To make it clear: This patch slowed me down significantly in working on tests for new customer-relevant features. I introduced significant changes in the HNBGW test suite, and everything broke. Of course I was assuming that my test suite changes have broken things. and after lng debugging, I discovered that an untested config change was merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 22 Apr 2024 11:01:05 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add new set of templates to support rollback
Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email ) Change subject: SGP32Definitions_Templates: add new set of templates to support rollback .. Patch Set 2: (1 comment) Patchset: PS1: > I wonder why do we need one encoding function for each message. […] I think this is due to the way the ASN.1 spec is designed. There are a lot of loose ends, in particular in the ES10x (communication between eUICC and host). The two messages I add here are ES10x messages. Für ESipa they did it properly. There we have one EsipaMessageFromIpaToEim and one EsipaMessageFromEimToIpa that acts as a CHOICE/union for all messages below. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6db76afb102bf011655b7dbca9cff07b8116eb8d Gerrit-Change-Number: 36609 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 22 Apr 2024 11:44:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[L] Change in osmo-ttcn3-hacks[master]: ipad: add an extra certificate+bundle for host "testsuite"
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email ) Change subject: ipad: add an extra certificate+bundle for host "testsuite" .. ipad: add an extra certificate+bundle for host "testsuite" Change-Id: I2d4ba8b710b9cf518b90c7f7acc8982350705531 --- M ipad/example_ca/pki/.rnd A ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem M ipad/example_ca/pki/extensions.temp M ipad/example_ca/pki/index.txt A ipad/example_ca/pki/index.txt.attr.old M ipad/example_ca/pki/index.txt.old A ipad/example_ca/pki/issued/testsuite.cabundle A ipad/example_ca/pki/issued/testsuite.crt A ipad/example_ca/pki/issued/testsuite.notes M ipad/example_ca/pki/openssl-easyrsa.temp A ipad/example_ca/pki/private/testsuite.key A ipad/example_ca/pki/reqs/testsuite.req M ipad/example_ca/pki/safessl-easyrsa.cnf M ipad/example_ca/pki/serial M ipad/example_ca/pki/serial.old 15 files changed, 298 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/36621/1 diff --git a/ipad/example_ca/pki/.rnd b/ipad/example_ca/pki/.rnd index 1334945..4bcee5a 100644 --- a/ipad/example_ca/pki/.rnd +++ b/ipad/example_ca/pki/.rnd Binary files differ diff --git a/ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem b/ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem new file mode 100644 index 000..2395451 --- /dev/null +++ b/ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem @@ -0,0 +1,87 @@ +Certificate: +Data: +Version: 3 (0x2) +Serial Number: +1d:1b:58:0c:1b:23:51:25:a8:7b:e0:6c:70:12:19:13 +Signature Algorithm: sha256WithRSAEncryption +Issuer: CN=Easy-RSA CA +Validity +Not Before: Apr 3 12:54:27 2024 GMT +Not After : Mar 19 12:54:27 2027 GMT +Subject: CN=testsuite +Subject Public Key Info: +Public Key Algorithm: rsaEncryption +RSA Public-Key: (2048 bit) +Modulus: +00:cd:59:25:9d:ed:cf:96:f5:11:27:fe:53:28:be: +9a:34:7d:52:8b:ba:67:17:d6:b9:01:c6:a5:a3:e3: +f9:13:76:4a:f6:98:0a:d7:75:49:8c:b5:aa:3e:d4: +24:0f:8a:f4:4e:b2:63:b1:6e:04:20:79:27:94:6e: +35:9b:94:26:d7:bf:25:f2:98:48:e8:8a:87:54:7c: +b9:c5:83:59:42:9d:11:aa:3b:a3:35:b2:e9:c6:9f: +ba:65:30:1d:ac:92:da:1a:63:b7:7c:73:84:1d:7a: +73:d1:8e:c4:f3:84:9a:c3:2a:b3:00:e1:5e:b3:0c: +6b:5d:c9:a2:db:15:53:31:bb:24:6a:e5:26:80:32: +7e:9a:0f:5f:a6:10:ac:76:4f:9e:17:13:6c:92:51: +39:08:ba:89:ec:ae:16:33:eb:48:48:a6:24:a7:4c: +0e:ba:20:e9:b8:bb:ef:c8:f6:6f:25:f2:27:c1:25: +34:cd:7a:52:bc:99:ce:e1:d3:f7:96:7e:ea:19:cc: +0b:f6:03:11:c0:2e:63:61:90:88:81:2e:d1:f2:5c: +3e:65:ff:1e:9a:57:16:d8:b3:97:35:18:0e:cc:37: +d4:52:cd:1c:81:ba:69:9a:15:85:13:99:7a:2d:36: +e5:77:62:2b:70:4a:78:57:ff:30:71:6d:41:27:cc: +10:93 +Exponent: 65537 (0x10001) +X509v3 extensions: +X509v3 Basic Constraints: +CA:FALSE +X509v3 Subject Key Identifier: +7E:68:CE:CF:F2:02:43:81:28:66:84:80:BC:16:F2:56:D6:9E:3D:AE +X509v3 Authority Key Identifier: + keyid:C3:81:B8:A8:1B:DE:BF:A6:69:00:20:FF:C5:CF:C5:08:37:9D:EE:76 +DirName:/CN=Easy-RSA CA + serial:60:40:F9:60:0A:22:43:66:68:46:32:52:8B:73:FF:57:5B:78:F5:9E + +X509v3 Extended Key Usage: +TLS Web Server Authentication +X509v3 Key Usage: +Digital Signature, Key Encipherment +X509v3 Subject Alternative Name: +DNS:testsuite +Signature Algorithm: sha256WithRSAEncryption + 2d:d4:04:33:c9:2b:c1:1e:ed:f3:b6:81:3d:24:03:9e:dc:fa: + 94:38:d3:ee:7c:50:7c:e8:c2:9c:f0:c9:f8:6b:36:c2:ca:73: + f7:f2:8d:61:92:3f:4d:a9:19:de:a4:46:13:ac:8f:ca:18:de: + 2d:2f:e2:d6:8a:f4:b9:2c:9a:89:33:1f:b8:52:9e:9f:e2:28: + ec:9b:c5:88:50:05:81:b3:68:eb:3a:19:d1:44:ab:31:32:ef: + a5:f0:aa:4c:c0:e6:08:77:40:b8:33:69:b1:f3:ab:a3:53:c1: + 7a:73:78:ab:88:18:01:6c:23:23:ed:f8:09:2d:f8:6b:c3:c2: + 66:7d:b5:fa:2e:a5:ed:9d:0d:8b:c3:7f:cc:7e:69:e7:ff:83: + ba:df:2c:ad:7e:d2:8c:a3:82:fd:4f:cb:25:9c:d2:56:6f:2d: + 72:09:ab:7b:f9:3e:86:58:41:0e:d6:b7:fa:49:ce:21:8a:85: + 96:d6:33:a6:7f:c1:68:b5:78:ac:e3:33:6d:ed:f7:40:57:8d: + d5:c1:20:21:b3:be:be:ea:7e:37:d5:27:92:a7:a4:8d:8d:e9: + 90:35:8d:36:77:b3:ee:c8:94:6d:07:f9:7c:2a:1b:45:5c:ca: +
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add missing new line at the end of file
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: SGP32Definitions_Templates: add missing new line at the end of file .. SGP32Definitions_Templates: add missing new line at the end of file Related: SYS#6563 Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/36604/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c Gerrit-Change-Number: 36604 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add missing new line at the end of file
Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email ) Change subject: SGP32Definitions_Templates: add missing new line at the end of file .. Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604/comment/dbe1d12f_f2d7b2b0 PS1, Line 7: SGP32Definitions_Templates: add missing new line at the endo of file > endo of Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c Gerrit-Change-Number: 36604 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 22 Apr 2024 11:44:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in docker-playground[master]: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email to look at the new patch set (#2). Change subject: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control .. ttcn3-sgsn-test: add missing SGSN_Tests_NS.control This does not enable the SNS testcases though. We need a separate job with its own configuration files for running the SNS testcases. Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7 Related: osmo-ttcn3-hacks.git Ib2bffbb110961474928f35d212cb492d4b6fdee0 --- M ttcn3-sgsn-test/SGSN_Tests.cfg 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/22/36622/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7 Gerrit-Change-Number: 36622 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
[M] Change in docker-playground[master]: ttcn3-sgsn-test: add config files for running SNS testcases
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email )
Change subject: ttcn3-sgsn-test: add config files for running SNS testcases
..
ttcn3-sgsn-test: add config files for running SNS testcases
Change-Id: I767ec223585002d6420eda27ed338722f764c902
---
A ttcn3-sgsn-test/jenkins-sns.sh
A ttcn3-sgsn-test/sns/SGSN_Tests.cfg
A ttcn3-sgsn-test/sns/osmo-sgsn.cfg
3 files changed, 217 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground
refs/changes/23/36623/1
diff --git a/ttcn3-sgsn-test/jenkins-sns.sh b/ttcn3-sgsn-test/jenkins-sns.sh
new file mode 100755
index 000..027244d
--- /dev/null
+++ b/ttcn3-sgsn-test/jenkins-sns.sh
@@ -0,0 +1,57 @@
+#!/bin/sh
+
+. ../jenkins-common.sh
+IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}"
+docker_images_require \
+ "osmo-stp-$IMAGE_SUFFIX" \
+ "osmo-sgsn-$IMAGE_SUFFIX" \
+ "ttcn3-sgsn-test"
+
+set_clean_up_trap
+set -e
+
+mkdir $VOL_BASE_DIR/sgsn-tester
+cp sns/SGSN_Tests.cfg $VOL_BASE_DIR/sgsn-tester/
+write_mp_osmo_repo "$VOL_BASE_DIR/sgsn-tester/SGSN_Tests.cfg"
+
+mkdir $VOL_BASE_DIR/sgsn
+cp sns/osmo-sgsn.cfg $VOL_BASE_DIR/sgsn/
+
+mkdir $VOL_BASE_DIR/stp
+cp osmo-stp.cfg $VOL_BASE_DIR/stp/
+
+mkdir $VOL_BASE_DIR/unix
+
+network_create
+network_replace_subnet_in_configs
+
+echo Starting container with STP
+docker run --rm \
+ $(docker_network_params $SUBNET 200) \
+ --ulimit core=-1 \
+ -v $VOL_BASE_DIR/stp:/data \
+ --name ${BUILD_TAG}-stp -d \
+ $DOCKER_ARGS \
+ $REPO_USER/osmo-stp-$IMAGE_SUFFIX
+
+echo Starting container with SGSN
+docker run --rm \
+ $(docker_network_params $SUBNET 10) \
+ --ulimit core=-1 \
+ -v $VOL_BASE_DIR/sgsn:/data \
+ --name ${BUILD_TAG}-sgsn-sns -d \
+ $DOCKER_ARGS \
+ $REPO_USER/osmo-sgsn-$IMAGE_SUFFIX \
+ /bin/sh -c "osmo-sgsn -c /data/osmo-sgsn.cfg
>/data/osmo-sgsn.log 2>&1"
+
+echo Starting container with SGSN testsuite
+docker run --rm \
+ $(docker_network_params $SUBNET 103) \
+ --ulimit core=-1 \
+ -e "TTCN3_PCAP_PATH=/data" \
+ -e "OSMO_SUT_HOST=172.18.$SUBNET.10" \
+ -e "OSMO_SUT_PORT=4245" \
+ -v $VOL_BASE_DIR/sgsn-tester:/data \
+ --name ${BUILD_TAG}-ttcn3-sgsn-test-sns \
+ $DOCKER_ARGS \
+ $REPO_USER/ttcn3-sgsn-test
diff --git a/ttcn3-sgsn-test/sns/SGSN_Tests.cfg
b/ttcn3-sgsn-test/sns/SGSN_Tests.cfg
new file mode 100644
index 000..e3ee59f
--- /dev/null
+++ b/ttcn3-sgsn-test/sns/SGSN_Tests.cfg
@@ -0,0 +1,46 @@
+[ORDERED_INCLUDE]
+# Common configuration, shared between test suites
+"/osmo-ttcn3-hacks/Common.cfg"
+# testsuite specific configuration, not expected to change
+"/osmo-ttcn3-hacks/sgsn/SGSN_Tests.default"
+
+# Local configuration below
+
+[LOGGING]
+
+[TESTPORT_PARAMETERS]
+*.SGSNVTY.CTRL_HOSTNAME := "172.18.8.10"
+
+[MODULE_PARAMETERS]
+SGSN_Tests.mp_nsconfig := {
+ {
+ handle_sns := true,
+ nsvc := {
+ {
+ provider := {
+ ip := {
+ address_family := AF_INET,
+ local_ip := "172.18.8.103",
+ remote_ip := "172.18.8.10",
+ data_weight := 1,
+ signalling_weight := 1
+ }
+ }
+ }
+ }
+ }
+}
+SGSN_Tests.mp_ranap_cfg := {
+ {
+ sctp_addr := { 23908, "172.18.8.103", 2905, "172.18.8.200" }
+ }
+}
+SGSN_Tests.mp_hlr_ip := "172.18.8.103"
+SGSN_Tests.mp_ggsn_ip := "172.18.8.103"
+SGSN_Tests.mp_sgsn_gtp_ip := "172.18.8.10"
+
+
+[MAIN_CONTROLLER]
+
+[EXECUTE]
+SGSN_Tests_NS.control
diff --git a/ttcn3-sgsn-test/sns/osmo-sgsn.cfg
b/ttcn3-sgsn-test/sns/osmo-sgsn.cfg
new file mode 100644
index 000..f2a4def
--- /dev/null
+++ b/ttcn3-sgsn-test/sns/osmo-sgsn.cfg
@@ -0,0 +1,105 @@
+!
+! OsmoSGSN (1.2.0.46-e77e-dirty) configuration saved from vty
+!!
+!
+log gsmtap 172.18.8.103
+ logging level set-all debug
+ logging filter all 1
+!
+log stderr
+ logging filter all 1
+ logging color 1
+ logging print category 1
+ logging timestamp 1
+ logging print extended-timestamp 1
+ logging print file 1
+ logging level mm debug
+ logging level pag notice
+ logging level meas notice
+ logging level ref notice
+ logging level gprs debug
+ logging level llc debug
+ logging level sndcp debug
+ logging level slhc notice
+ logging level ranap info
+ logging level sua info
+
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Allow API users to enable/disable SSL
Attention is currently required from: dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email ) Change subject: HTTP_Adapter: Allow API users to enable/disable SSL .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319 Gerrit-Change-Number: 36506 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Attention: laforge Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 22 Apr 2024 12:43:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add missing new line at the end of file
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email ) Change subject: SGP32Definitions_Templates: add missing new line at the end of file .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c Gerrit-Change-Number: 36604 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 22 Apr 2024 12:51:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in docker-playground[master]: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email ) Change subject: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control .. Patch Set 2: (1 comment) Patchset: PS2: > I'm a bit lost here. If they need another set of config files + jenkins.sh, > why adding this . […] SNS testcases need another set; NS testcases do not. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7 Gerrit-Change-Number: 36622 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 22 Apr 2024 12:50:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add new set of templates to support rollback
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email ) Change subject: SGP32Definitions_Templates: add new set of templates to support rollback .. Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > I think this is due to the way the ASN.1 spec is designed. […] I see, thanks for explaining / looking into this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6db76afb102bf011655b7dbca9cff07b8116eb8d Gerrit-Change-Number: 36609 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 22 Apr 2024 12:50:54 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. Patch Set 6: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/68b78d5c_0321edd4 PS6, Line 3748: f_pdp_ctx_act(apars); > @axilirator@gmail. […] I believe PCAPs would do a better job explaining what's going on. https://osmocom.org/attachments/download/8165/SGSN_Tests.TC_sgsn_context_req_in.pcapng.gz -- here is a PCAP file recorded with the previous patch revision (5). * [packet 456] MS sends GMM `Activate PDP Context Request` with the `Requested PDP Address` IE being empty (wireshark displays `Dynamic addressing`); * [packet 476] SGSN sends GTPC `Create PDP Context Request` with the `End user address` IE being empty (expecting GGSN to assign it?); * [packet 478] GGSN (the testsuite) responds with `Create PDP Context Response`, but **not including** the `End user address` IE; * [packet 487] SGSN responds with GMM `Activate PDP Context Accept` with the `PDP Address` IE being empty (wireshark displays `Dynamic addressing`); * [packet 489] the testsuite sends `SGSN Context Request`; * [packet 492] SGSN responds with `SGSN Context Response` containing no `PDP Context` IE -- this makes the testcase fail. This is basically a), `apars.addr.addressInfo := omit` by default. This is also the case for the other (existing) testcases in SGSN_Tests.ttcn, see https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-sgsn-test/2318/artifact/logs/sgsn-tester/SGSN_Tests.TC_attach_pdp_act.pcap.gz for instance. Or any other `SGSN_Tests.TC_attach_pdp_act_...` testcase. The testsuite (virtual GGSN) assigns no IP address, and osmo-sgsn happily accepts that. I don't know if this is right or wrong, you're saying it's not right? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: daniel Gerrit-Comment-Date: Mon, 22 Apr 2024 13:04:38 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email )
Change subject: sgsn: add TC_attach_rau_invalid_old_rai
..
sgsn: add TC_attach_rau_invalid_old_rai
This testcase currently crashes osmo-sgsn.
Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 56 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/25/36625/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 0371e29..d55a264 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2755,6 +2755,49 @@
f_cleanup();
}
+private function f_TC_attach_rau_invalid_old_rai(charstring id) runs on
BSSGP_ConnHdlr {
+ timer T;
+
+ /* perform regular attach */
+ f_TC_attach(id);
+
+ /* perform RAU via cell A */
+ f_routing_area_update(g_pars.ra);
+
+ f_bssgp_client_unregister(g_pars.imsi);
+ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]);
+
+ /* perform RAU via cell B, but indicating the new RAI as the old RAI */
+ var RoutingAreaIdentificationV old_ra :=
f_cellid_to_RAI(g_pars.bssgp_cell_id[1]);
+ f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, old_ra), 1);
+
+ T.start(2.0);
+ alt {
+ [] BSSGP[1].receive(tr_GMM_RAU_REJECT) {
+ setverdict(pass);
+ T.stop;
+ }
+ [] BSSGP[1].receive(tr_LLC_XID_MT_CMD(?, ?)) { repeat; }
+ [] T.timeout {
+ setverdict(fail, "Timeout waiting for RAU Reject");
+ mtc.stop;
+ }
+ }
+
+ /* perform RAU via cell B, this time with proper old RAI of cell A */
+ f_routing_area_update(old_ra := g_pars.ra, ran_index := 1);
+
+ f_detach_mo(c_GMM_DTT_MO_GPRS, true, true, 1);
+}
+testcase TC_attach_rau_invalid_old_rai() runs on test_CT {
+ var BSSGP_ConnHdlr vc_conn;
+ f_init();
+ f_sleep(1.0);
+ vc_conn := f_start_handler(refers(f_TC_attach_rau_invalid_old_rai),
testcasename(), g_gb, 138);
+ vc_conn.done;
+ f_cleanup();
+}
+
private function f_TC_attach_gmm_attach_req_while_gmm_attach(charstring id)
runs on BSSGP_ConnHdlr {
var integer count_req := 0;
var MobileIdentityLV mi;
@@ -3984,6 +4027,8 @@
/* At the end, may crash osmo-sgsn, see OS#3957, OS#4245 */
execute( TC_attach_req_id_req_ra_update() );
+ /* At the end, may crash osmo-sgsn */
+ execute( TC_attach_rau_invalid_old_rai() );
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147
Gerrit-Change-Number: 36625
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: daniel, fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. Patch Set 6: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/6ebdc670_7f77edfc PS6, Line 3748: f_pdp_ctx_act(apars); > [packet 478] GGSN (the testsuite) responds with Create PDP Context Response, > but not including the End user address IE; This looks wrong to me. The EUA should be there. I see no reason why the GGSN would not assign the EUA. > The testsuite (virtual GGSN) assigns no IP address, and osmo-sgsn happily > accepts that. I don't know if this is right or wrong, you're saying it's not > right? Ack. One would need to closely read the specs to see if that's allowed, but for sure it's not what we want in these test cases. It's possibly simply some missing code in the ttcn3 code emulating the ggsn. Go fix that :) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Mon, 22 Apr 2024 14:02:04 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_rau_invalid_old_rai
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email ) Change subject: sgsn: add TC_attach_rau_invalid_old_rai .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I006adabdad26c0c48e1ebe99421bcab7295dc147 Gerrit-Change-Number: 36625 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 14:02:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: put HTTP config options into a record
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email ) Change subject: HTTP_Adapter: put HTTP config options into a record .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Gerrit-Change-Number: 36603 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 22 Apr 2024 14:07:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 4: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a1d62da6_d35b4741 PS4, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/4f8fb4b1_c4ac3746 PS4, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/4c59fe19_6f75bc1a PS4, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e4207886_caa80bfd PS4, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9d02d153_0c5273ff PS4, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/d0a83ad2_2ee2f6cd PS4, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a27780f8_06c7fafd PS4, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/cb75132f_57d051b5 PS4, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e1b3411b_6aa3ee1d PS4, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/dfb8e8cc_35b98e36 PS4, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/41fa99c8_03890521 PS4, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/5659d7a2_a7efea2e PS4, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ccdbee97_166b7e3a PS4, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 22 Apr 2024 11:46:14 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[L] Change in osmo-ttcn3-hacks[master]: ipad: add an extra certificate+bundle for host "testsuite"
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email ) Change subject: ipad: add an extra certificate+bundle for host "testsuite" .. Patch Set 1: (12 comments) File ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/65afb5ac_64be4f11 PS1, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/2cbcb8dd_2ee74ee2 PS1, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/2d172c36_30af8b28 PS1, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/b5a7618f_1821d6c5 PS1, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/d70a1323_623b5811 PS1, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9c52b731_795dd96d PS1, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/testsuite.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/5ef8fce9_b6e6cfe3 PS1, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/12176ab5_596e98aa PS1, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/592d290a_d7879a1c PS1, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/12092587_5c1289a2 PS1, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/0cba66c0_2039b756 PS1, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/f206cb65_6ecbb19f PS1, Line 49: X509v3 Subject Alternative Name: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2d4ba8b710b9cf518b90c7f7acc8982350705531 Gerrit-Change-Number: 36621 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 22 Apr 2024 11:46:00 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: remove unrelated template parameter
dexter has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
)Change subject: SGP32Definitions_Templates: remove unrelated template
parameter
..
SGP32Definitions_Templates: remove unrelated template parameter
The template parameter eimFqdn is not relevant for this kind of
template.
Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b
Related: SYS#6563
---
M library/euicc/SGP32Definitions_Templates.ttcn
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/library/euicc/SGP32Definitions_Templates.ttcn
b/library/euicc/SGP32Definitions_Templates.ttcn
index f22778c..9964628 100644
--- a/library/euicc/SGP32Definitions_Templates.ttcn
+++ b/library/euicc/SGP32Definitions_Templates.ttcn
@@ -422,7 +422,7 @@
addInitialEimOk := ?
}
template (value) AddInitialEimResponse
-ts_addInitialEimResponse(template (value) charstring eimFqdn := "127.0.0.1")
:= {
+ts_addInitialEimResponse := {
addInitialEimOk := {
{
addOk := NULL
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b
Gerrit-Change-Number: 36605
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-ci[master]: jobs/ttcn3: run io_uring testsuites on all nodes
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email ) Change subject: jobs/ttcn3: run io_uring testsuites on all nodes .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I59b9a7c3928281a0557c17629029adcbc5ae7410 Gerrit-Change-Number: 36602 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 22 Apr 2024 11:46:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
Attention is currently required from: daniel, fixeria, fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE .. Patch Set 6: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/a2cf2328_a5c8b135 PS6, Line 3748: f_pdp_ctx_act(apars); > I don't think it really matters for this specific test scenario whether the > requested IP address mat […] @axilira...@gmail.com I think it makes sense to validate the whole scenario as closely as it will usually run. That means MS requesting dynamic address. This may affect the code logic inside osmo-sgsn, turning it into a specific state where the IP address passed later on in the newly added messages may affect. A) To me that looks like a bug in osmo-sgsn, because afaiu the MS got an IP address assigned from GGSN previously right? Why is it not proividing the IP address to the MME then? Something seems really odd here and we need to agree on what's going first. Please avoid merging this patch until we are all on the same track, I agree it makes no sense to encode an empty PDP Address in SGSN Context Response. After all, a properly established pdp context should have a valid address (assigned by GGSN). If there's no valid IP address (it shouldn't happen in first place? maybe because pdp ctx creation is ongoing with GGSN?), then the SGSN should refrain from sending that PDP Context in the list, as I think is explained somewhere in the specs iirc. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-CC: fixeria Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 12:35:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in docker-playground[master]: ttcn3-sgsn-test: add config files for running SNS testcases
Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email ) Change subject: ttcn3-sgsn-test: add config files for running SNS testcases .. Patch Set 2: (1 comment) File ttcn3-sgsn-test/sns/SGSN_Tests.cfg: https://gerrit.osmocom.org/c/docker-playground/+/36623/comment/ee0bf1b5_1159b91d PS2, Line 46: SGSN_Tests_NS.control > See, you are assing it here, why adding it to the other already exiting > SGSN_Tests. […] "you are assing" -- lol, what?!? See my comment in previous commit. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I767ec223585002d6420eda27ed338722f764c902 Gerrit-Change-Number: 36623 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 22 Apr 2024 12:53:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[M] Change in docker-playground[master]: ttcn3-sgsn-test: add config files for running SNS testcases
Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email ) Change subject: ttcn3-sgsn-test: add config files for running SNS testcases .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I767ec223585002d6420eda27ed338722f764c902 Gerrit-Change-Number: 36623 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 13:59:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in docker-playground[master]: ttcn3-sgsn-test: add config files for running SNS testcases
Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email ) Change subject: ttcn3-sgsn-test: add config files for running SNS testcases .. Patch Set 2: (1 comment) File ttcn3-sgsn-test/sns/SGSN_Tests.cfg: https://gerrit.osmocom.org/c/docker-playground/+/36623/comment/916a140e_35a728eb PS2, Line 46: SGSN_Tests_NS.control > "you are assing" -- lol, what?!? […] Yeah yeah, I found out NS vs SNS :) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I767ec223585002d6420eda27ed338722f764c902 Gerrit-Change-Number: 36623 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 13:59:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
