Re: [Gimp-developer] Optimized Despeckle plug-in

[Sven Neumann]

On Tue, 2010-07-13 at 22:19 +0200, g...@catking.net wrote:

> I agree. I had to clean up some photos recently and ended up doing most 
> of it by hand.
> 
> If you code produces the same kind of results with that much of a speed 
> increase a patch would be worth providing. Kudos for achieving that 
> level of speed up.

The quality of results also very much depends on how the parameters are
chosen. A speedup of the algorithm will make it easier to experiment
with the parameters as it should also speed up the preview
significantly.

So yes, we should try to get that patch into GIMP as soon as possible.


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Re: [Gimp-developer] Optimized Despeckle plug-in

[gg]

On 07/13/10 19:52, Sven Neumann wrote:
> On Tue, 2010-07-13 at 10:49 +0200, Martin Nordholts wrote:
>> On 07/13/2010 10:28 AM, Przemysław Zych wrote:
>>> Hi,
>>>
>>> As a part of my student project for "Optimizing Open-Source
>>> Applications" at Warsaw University I have speed up despeckle plug-in for
>>> gimp.
>>>
>>> Original version of the plugin run 56seconds for 1024x768 image with
>>> despeckle radius 30 and adaptive flag turned off (on my Intel Macbook
>>> 2.1GHz). My optimized version with the same settings completes the task
>>> in 3.5 seconds with the same image quality :-)
>>>
>>> Sources for this optimized plug-in can be downloaded from here:
>>> http://students.mimuw.edu.pl/~pz248275/despeckle.c
>>> 
>>>
>>> What should I do to get this to the gimp repository?
>>> Should I change the copyright header?
>>
>> Hi!
>>
>> That sounds great.
>>
>> To maximize chances of getting this into GIMP:
>>
>> 1. Create a regression test for the despecle plug-in that is run
>>  with 'make check'. This is a great way to convince us that
>>  your optimization in fact does not change the output, only
>>  improves performance.
>
> Well, as far as I can see the current implementation of the despeckle
> plug-in does not match the expectations. IMO it is buggy. Thus we should
> not absolutely require that the result does not change. But it would be
> desirable to get fixes to the algorithm submitted separately from
> optimizations.
>
> It would also help a lot if the patch followed the GIMP coding style.
> Please see the file HACKING in the GIMP source tree.
>
>
> Sven
>

hi,

I agree. I had to clean up some photos recently and ended up doing most 
of it by hand.

If you code produces the same kind of results with that much of a speed 
increase a patch would be worth providing. Kudos for achieving that 
level of speed up.

I guess by now you must have got a good feel for the way that part of 
the code base works so if you can write a despeckle routing that does 
despeckle that would be a worthwhile contribution as well.

Thanks for you efforts.

/gg
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Re: [Gimp-developer] Optimized Despeckle plug-in

[Sven Neumann]

On Tue, 2010-07-13 at 10:49 +0200, Martin Nordholts wrote:
> On 07/13/2010 10:28 AM, Przemysław Zych wrote:
> > Hi,
> >
> > As a part of my student project for "Optimizing Open-Source
> > Applications" at Warsaw University I have speed up despeckle plug-in for
> > gimp.
> >
> > Original version of the plugin run 56seconds for 1024x768 image with
> > despeckle radius 30 and adaptive flag turned off (on my Intel Macbook
> > 2.1GHz). My optimized version with the same settings completes the task
> > in 3.5 seconds with the same image quality :-)
> >
> > Sources for this optimized plug-in can be downloaded from here:
> > http://students.mimuw.edu.pl/~pz248275/despeckle.c
> > 
> >
> > What should I do to get this to the gimp repository?
> > Should I change the copyright header?
> 
> Hi!
> 
> That sounds great.
> 
> To maximize chances of getting this into GIMP:
> 
> 1. Create a regression test for the despecle plug-in that is run
> with 'make check'. This is a great way to convince us that
> your optimization in fact does not change the output, only
> improves performance.

Well, as far as I can see the current implementation of the despeckle
plug-in does not match the expectations. IMO it is buggy. Thus we should
not absolutely require that the result does not change. But it would be
desirable to get fixes to the algorithm submitted separately from
optimizations.

It would also help a lot if the patch followed the GIMP coding style.
Please see the file HACKING in the GIMP source tree.


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Gimp-developer] About Gimp Icons license

[jEsuSdA 8)]

Hello!

Yesterday I suggest  Pinta developers (http://pinta-project.com/) improve this 
nice software using the Art Libre Set 
icons.

There are a problem: Art Libre Set is under GPL License and it appears to be 
incompatible with MIT License (The one 
Pinta uses).

I asked to the Tango mailing list and someone tell me the Gimp Icons are under 
LGPL, then they could be used.

But I can not find any reference where appears that Gimp icons are LGPL.

¿Are the Gimp tools and menu Icons under the GPL or LGPL license?
¿Could be the icons used for Pinta?

The Art Libre set allow graphical applications to be easy to use for people 
(same tools work similar way) and I think 
Pinta could be improved using it.

Salu2 de jEsuSdA 8)
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Re: [Gimp-developer] Optimized Despeckle plug-in

[Martin Nordholts]

On 07/13/2010 10:28 AM, Przemysław Zych wrote:
> Hi,
>
> As a part of my student project for "Optimizing Open-Source
> Applications" at Warsaw University I have speed up despeckle plug-in for
> gimp.
>
> Original version of the plugin run 56seconds for 1024x768 image with
> despeckle radius 30 and adaptive flag turned off (on my Intel Macbook
> 2.1GHz). My optimized version with the same settings completes the task
> in 3.5 seconds with the same image quality :-)
>
> Sources for this optimized plug-in can be downloaded from here:
> http://students.mimuw.edu.pl/~pz248275/despeckle.c
> 
>
> What should I do to get this to the gimp repository?
> Should I change the copyright header?

Hi!

That sounds great.

To maximize chances of getting this into GIMP:

1. Create a regression test for the despecle plug-in that is run
with 'make check'. This is a great way to convince us that
your optimization in fact does not change the output, only
improves performance.
2. Create a patch, following the instructions here:
http://www.gimp.org/bugs/howtos/submit-patch.html

Since your change is significant, feel free to add yourself to the 
copyright header.

Regards,
Martin



-- 

My GIMP Blog:
http://www.chromecode.com/
"Automatic tab style and removed tab title bar"
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Gimp-developer] Optimized Despeckle plug-in

[Przemysław Zych]

Hi,

As a part of my student project for "Optimizing Open-Source Applications" at
Warsaw University I have speed up despeckle plug-in for gimp.

Original version of the plugin run 56seconds for 1024x768 image with
despeckle radius 30 and adaptive flag turned off (on my Intel Macbook
2.1GHz). My optimized version with the same settings completes the task in
3.5 seconds with the same image quality :-)

Sources for this optimized plug-in can be downloaded from here:
http://students.mimuw.edu.pl/~pz248275/despeckle.c

What should I do to get this to the gimp repository?
Should I change the copyright header?

Thanks,
Przemyslaw Zych
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Re: [Gimp-developer] PatchMatch

[Torsten Neuer]

Am Dienstag, 13. Juli 2010, um 08:12:32 schrieb Alexia Death:
> > http://www.youtube.com/watch?v=dgKjs8ZjQNg and a paper at
> > http://www.cs.princeton.edu/gfx/pubs/Barnes_2009_PAR/index.php with
> > sample
> 
> Theres a resyntheziser plugin that does pretty much the same stuff as
> the CS5 content ware fill.

Also, the liquid-rescale plug-in can be used for some of those effects (as the 
demonstrated "re-targeting" in the video).


  Torsten


signature.asc
Description: This is a digitally signed message part.
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer