[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

2011-11-21 Thread Shaunak Kashyap (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154279#comment-13154279
 ] 

Shaunak Kashyap commented on GIRAPH-84:
---

Thanks, Claudio and Jakob. I will make the suggested changes and attach a patch 
to the JIRA.

> Simplify boolean expressions in BspRecordReader
> ---
>
> Key: GIRAPH-84
> URL: https://issues.apache.org/jira/browse/GIRAPH-84
> Project: Giraph
>  Issue Type: Improvement
>Reporter: Jakob Homan
>Assignee: Shaunak Kashyap
>  Labels: newbie
>
> Twice in BspRecordReader boolean expressions are evaluated with == and can be 
> simplified to just one liners or variable evaluation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

2011-11-17 Thread Shaunak Kashyap (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152469#comment-13152469
 ] 

Shaunak Kashyap commented on GIRAPH-84:
---

I believe that style goes against the coding conventions for this project (see 
http://svn.apache.org/repos/asf/incubator/giraph/trunk/CODE_CONVENTIONS).

I wonder if using the ternary operator like so is acceptable:

{code}
return (seenRecord ? 1f : 0f);
{code}

> Simplify boolean expressions in BspRecordReader
> ---
>
> Key: GIRAPH-84
> URL: https://issues.apache.org/jira/browse/GIRAPH-84
> Project: Giraph
>  Issue Type: Improvement
>Reporter: Jakob Homan
>Assignee: Attila Csordas
>  Labels: newbie
>
> Twice in BspRecordReader boolean expressions are evaluated with == and can be 
> simplified to just one liners or variable evaluation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-63) Typo in PageRankBenchmark

2011-11-11 Thread Shaunak Kashyap (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/GIRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148579#comment-13148579
 ] 

Shaunak Kashyap commented on GIRAPH-63:
---

Also found the same typo in 
{{org/apache/giraph/benchmark/RandomMessageBenchmark.java}}:

{code:title=RandomMessageBenchmark.java|borderStyle=solid}
if (!cmd.hasOption('s')) {
  System.out.println("Need to set the number of supesteps (-s)");
  return -1;
}
{code}


> Typo in PageRankBenchmark
> -
>
> Key: GIRAPH-63
> URL: https://issues.apache.org/jira/browse/GIRAPH-63
> Project: Giraph
>  Issue Type: Bug
>Reporter: Jakob Homan
>Priority: Trivial
>  Labels: newbie
>
> {code:title=PageRankBenchmark.java|borderStyle=solid}
> if (!cmd.hasOption('s')) {
>   System.out.println("Need to set the number of supesteps (-s)");
>   return -1;
> }{code}
> supesteps -> supersteps

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira