[jira] [Commented] (GIRAPH-119) VertexCombiner should work on IterableM instead of ListM
[ https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181522#comment-13181522 ] Jakob Homan commented on GIRAPH-119: +1. The change log isn't usually modified as part of the patch, but as part of the commit, although I don't see a reason it would hurt, except perhaps conflicts in the file? VertexCombiner should work on IterableM instead of ListM Key: GIRAPH-119 URL: https://issues.apache.org/jira/browse/GIRAPH-119 Project: Giraph Issue Type: Improvement Components: graph Affects Versions: 0.70.0 Reporter: Claudio Martella Assignee: Claudio Martella Attachments: GIRAPH-119.diff Currently VertexCombiner expects a ListM. It should be refactored to IterableM to sync with Iterable-based BasicVertex messages logics. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (GIRAPH-119) VertexCombiner should work on IterableM instead of ListM
Ok, I didn't know. I usually do it as it requires 0-knowledge by a second hand. Btw, why would it conflict? On Fri, Jan 6, 2012 at 8:05 PM, Jakob Homan (Commented) (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181522#comment-13181522 ] Jakob Homan commented on GIRAPH-119: +1. The change log isn't usually modified as part of the patch, but as part of the commit, although I don't see a reason it would hurt, except perhaps conflicts in the file? VertexCombiner should work on IterableM instead of ListM Key: GIRAPH-119 URL: https://issues.apache.org/jira/browse/GIRAPH-119 Project: Giraph Issue Type: Improvement Components: graph Affects Versions: 0.70.0 Reporter: Claudio Martella Assignee: Claudio Martella Attachments: GIRAPH-119.diff Currently VertexCombiner expects a ListM. It should be refactored to IterableM to sync with Iterable-based BasicVertex messages logics. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira -- Claudio Martella claudio.marte...@gmail.com
Re: [jira] [Commented] (GIRAPH-119) VertexCombiner should work on IterableM instead of ListM
Maybe if changelog got modified (unlikely, I know). Doesn't hurt anything. Also, for non-committer contributors, they shouldn't modify the log since they don't know who may commit their code (ie bob via joe) On Fri, Jan 6, 2012 at 11:07 AM, Claudio Martella claudio.marte...@gmail.com wrote: Ok, I didn't know. I usually do it as it requires 0-knowledge by a second hand. Btw, why would it conflict? On Fri, Jan 6, 2012 at 8:05 PM, Jakob Homan (Commented) (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181522#comment-13181522 ] Jakob Homan commented on GIRAPH-119: +1. The change log isn't usually modified as part of the patch, but as part of the commit, although I don't see a reason it would hurt, except perhaps conflicts in the file? VertexCombiner should work on IterableM instead of ListM Key: GIRAPH-119 URL: https://issues.apache.org/jira/browse/GIRAPH-119 Project: Giraph Issue Type: Improvement Components: graph Affects Versions: 0.70.0 Reporter: Claudio Martella Assignee: Claudio Martella Attachments: GIRAPH-119.diff Currently VertexCombiner expects a ListM. It should be refactored to IterableM to sync with Iterable-based BasicVertex messages logics. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira -- Claudio Martella claudio.marte...@gmail.com
[jira] [Commented] (GIRAPH-119) VertexCombiner should work on IterableM instead of ListM
[ https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181541#comment-13181541 ] Hudson commented on GIRAPH-119: --- Integrated in Giraph-trunk-Commit #61 (See [https://builds.apache.org/job/Giraph-trunk-Commit/61/]) GIRAPH-119: VertexCombiner should work on IterableM instead of ListM claudio : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1228356 Files : * /incubator/giraph/trunk/CHANGELOG * /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java * /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java * /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexCombiner.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexTypes.java VertexCombiner should work on IterableM instead of ListM Key: GIRAPH-119 URL: https://issues.apache.org/jira/browse/GIRAPH-119 Project: Giraph Issue Type: Improvement Components: graph Affects Versions: 0.70.0 Reporter: Claudio Martella Assignee: Claudio Martella Attachments: GIRAPH-119.diff Currently VertexCombiner expects a ListM. It should be refactored to IterableM to sync with Iterable-based BasicVertex messages logics. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-119) VertexCombiner should work on IterableM instead of ListM
[
https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181566#comment-13181566
]
Avery Ching commented on GIRAPH-119:
Minor nit
@Override
public FloatWritable combine(LongWritable vertexIndex,
- ListFloatWritable msgList)
+ IterableFloatWritable msgList)
throws IOException {
return null;
}
@@ -97,7 +97,7 @@ public class TestVertexTypes
@Override
public DoubleWritable combine(LongWritable vertexIndex,
- ListDoubleWritable msgList)
+ IterableDoubleWritable msgList)
throws IOException {
return null;
}
probably should have changed msgList to messages or something like that. Not a
big deal. =)
VertexCombiner should work on IterableM instead of ListM
Key: GIRAPH-119
URL: https://issues.apache.org/jira/browse/GIRAPH-119
Project: Giraph
Issue Type: Improvement
Components: graph
Affects Versions: 0.70.0
Reporter: Claudio Martella
Assignee: Claudio Martella
Attachments: GIRAPH-119.diff
Currently VertexCombiner expects a ListM. It should be refactored to
IterableM to sync with Iterable-based BasicVertex messages logics.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
