Re: [PATCH v4] gitk: Add a Copy commit summary command
On Sat, Jul 18, 2015 at 01:15:39PM +0200, Beat Bolli wrote: When referring to earlier commits in commit messages or other text, one of the established formats is abbrev-sha (summary, author-date) Add a Copy commit summary command to the context menu that puts this text for the currently selected commit on the clipboard. This makes it easy for our users to create well-formatted commit references. The abbrev-sha is produced with the %h format specifier to make it unique. Its length can be controlled with the gitk preference Auto-select SHA1 (length), or, if this preference is set to its default value (40), with the Git config setting core.abbrev. Signed-off-by: Beat Bolli dev+...@drbeat.li Thanks, applied. Paul. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] gitk: Add a Copy commit summary command
On 13.08.15 09:37, Paul Mackerras wrote: On Sat, Jul 18, 2015 at 01:15:39PM +0200, Beat Bolli wrote: When referring to earlier commits in commit messages or other text, one of the established formats is abbrev-sha (summary, author-date) Add a Copy commit summary command to the context menu that puts this text for the currently selected commit on the clipboard. This makes it easy for our users to create well-formatted commit references. The abbrev-sha is produced with the %h format specifier to make it unique. Its length can be controlled with the gitk preference Auto-select SHA1 (length), or, if this preference is set to its default value (40), with the Git config setting core.abbrev. Signed-off-by: Beat Bolli dev+...@drbeat.li Thanks, applied. Please also apply the follow-up patch in this thread [1]. It fixes menu entry numbers that were changed by this patch. Thanks, Beat [1] http://article.gmane.org/gmane.comp.version-control.git/275729 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] gitk: Add a Copy commit summary command
On 21.07.15 12:28, Paul Mackerras wrote: On Tue, Jul 21, 2015 at 12:19:23PM +0200, Beat Bolli wrote: Guys, can I get a Yea or Nay for this patch? Does it go in via Paul's gitk repo or directly through Junio? I'll put it in. It goes into my repo and from there into Junio's. I'm on vacation and travelling this week, so please be patient. No problem, enjoy your vacation! Beat -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] gitk: Add a Copy commit summary command
Guys,
can I get a Yea or Nay for this patch?
Does it go in via Paul's gitk repo or directly through Junio?
Thanks,
Beat
On 18.07.15 13:15, Beat Bolli wrote:
When referring to earlier commits in commit messages or other text, one
of the established formats is
abbrev-sha (summary, author-date)
Add a Copy commit summary command to the context menu that puts this
text for the currently selected commit on the clipboard. This makes it
easy for our users to create well-formatted commit references.
The abbrev-sha is produced with the %h format specifier to make it
unique. Its length can be controlled with the gitk preference
Auto-select SHA1 (length), or, if this preference is set to its
default value (40), with the Git config setting core.abbrev.
Signed-off-by: Beat Bolli dev+...@drbeat.li
Cc: Paul Mackerras pau...@samba.org
---
Changes since v3:
- consider $autosellen for the --abbrev value
Changes since v2:
- call git show to produce a unique abbrev-sha
- use the short date format
Changes since v1:
- drop the commit literal in front of the abbrev-sha
Signed-off-by: Beat Bolli dev+...@drbeat.li
---
gitk-git/gitk | 15 +++
1 file changed, 15 insertions(+)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 9a2daf3..d05169a 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2617,6 +2617,7 @@ proc makewindow {} {
{mc Diff selected - this command {diffvssel 1}}
{mc Make patch command mkpatch}
{mc Create tag command mktag}
+ {mc Copy commit summary command copysummary}
{mc Write commit to file command writecommit}
{mc Create new branch command mkbranch}
{mc Cherry-pick this commit command cherrypick}
@@ -9341,6 +9342,20 @@ proc mktaggo {} {
mktagcan
}
+proc copysummary {} {
+global rowmenuid autosellen
+
+set format %h (\%s\, %ad)
+set cmd [list git show -s --pretty=format:$format --date=short]
+if {$autosellen 40} {
+lappend cmd --abbrev=$autosellen
+}
+set summary [eval exec $cmd $rowmenuid]
+
+clipboard clear
+clipboard append $summary
+}
+
proc writecommit {} {
global rowmenuid wrcomtop commitinfo wrcomcmd NS
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] gitk: Add a Copy commit summary command
On Tue, Jul 21, 2015 at 12:19:23PM +0200, Beat Bolli wrote: Guys, can I get a Yea or Nay for this patch? Does it go in via Paul's gitk repo or directly through Junio? I'll put it in. It goes into my repo and from there into Junio's. I'm on vacation and travelling this week, so please be patient. Regards, Paul. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
