Re: [msysGit] Re: Topic sk/mingw-unicode-spawn-args breaks tests
Hi Stepan, On Sat, 12 Jul 2014, Stepan Kasal wrote: Am 10.07.2014 22:05, schrieb Johannes Sixt: It looks like I totally missed the topic sk/mingw-unicode-spawn-args. ... Am I doing something wrong? Does the topic depend on a particular version of MSYS (or DLL)? unfortunately, I paused my submissions at random point. ;-) I'm sorry for breaking your setup. I was not aware there is any working Windows setup beyond msysGit. There is one other, very notable development environment relevant to Git for Windows: https://github.com/sschuberth/mingwGitDevEnv. It is slated to be the development environment to produce Git for Windows starting with version 2.0.0. I have pretty concrete plans to work on that switch, which will most likely also affect Hannes (who has so far successfully resisted to develop Git using the msysGit environment). Those plans to step up my efforts regarding Git for Windows imply my spending more time on the project again, subject to a couple of things that are still being hashed out. Stay tuned, Dscho -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Topic sk/mingw-unicode-spawn-args breaks tests
Hello Hannes, Am 10.07.2014 22:05, schrieb Johannes Sixt: It looks like I totally missed the topic sk/mingw-unicode-spawn-args. ... Am I doing something wrong? Does the topic depend on a particular version of MSYS (or DLL)? unfortunately, I paused my submissions at random point. I'm sorry for breaking your setup. I was not aware there is any working Windows setup beyond msysGit. Thus I did not object when the half-done work was going to be moved ot master. I'll try to submit the patches needed so that your setup works again. Karsten writes: At first glance, t0050 seems to fail because the unicode file name patches are still missing. Indeed, this is a pair of patches on the tip of my queue. t4041 tries to pass ISO-8859-1 encoded bytes on the command line, which simply doesn't work on Windows (all OS APIs 'talk' UTF-16). We have a fix for this in the msysgit fork [1] (but unfortunately in another branch, so Stepan couldn't know the patch is related). There is a whole branch named win-tests or some such. I remember I was hunting for not-yet resolved instances of this bug. This convinced me that the test suite of vanilla git cannot work on Windows. I was not aware about the fact that this problem was masked in the versions before Karsten's unicode patches. Hannes, I'd like to submit the patches mentioned here during the following week and I'd be glad to hear from you. Stepan -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Topic sk/mingw-unicode-spawn-args breaks tests
Am 10.07.2014 22:05, schrieb Johannes Sixt: It looks like I totally missed the topic sk/mingw-unicode-spawn-args. Now it's in master, and it breaks lots of test cases for me: t0050-filesystem t0110-urlmatch-normalization t4014-format-patch t4041-diff-submodule-option t4120-apply-popt t4201-shortlog t4205-log-pretty-formats t4209-log-pickaxe t4210-log-i18n (I killed the test run here) Am I doing something wrong? Does the topic depend on a particular version of MSYS (or DLL)? -- Hannes After commenting out fchmod in config.c, I get similar results. At first glance, t0050 seems to fail because the unicode file name patches are still missing. t4041 tries to pass ISO-8859-1 encoded bytes on the command line, which simply doesn't work on Windows (all OS APIs 'talk' UTF-16). We have a fix for this in the msysgit fork [1] (but unfortunately in another branch, so Stepan couldn't know the patch is related). I suspect the other failures also fall in these two categories. [1] https://github.com/msysgit/git/commit/ef4a733c -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Topic sk/mingw-unicode-spawn-args breaks tests
It looks like I totally missed the topic sk/mingw-unicode-spawn-args. Now it's in master, and it breaks lots of test cases for me: t0050-filesystem t0110-urlmatch-normalization t4014-format-patch t4041-diff-submodule-option t4120-apply-popt t4201-shortlog t4205-log-pretty-formats t4209-log-pickaxe t4210-log-i18n (I killed the test run here) Am I doing something wrong? Does the topic depend on a particular version of MSYS (or DLL)? -- Hannes -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
