[GitHub] [hive] jcamachor closed pull request #751: HIVE-22105 Update ORC to 1.5.6.
jcamachor closed pull request #751: HIVE-22105 Update ORC to 1.5.6. URL: https://github.com/apache/hive/pull/751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor closed pull request #746: HIVE-22074: Slow compilation due to IN to OR transformation
jcamachor closed pull request #746: HIVE-22074: Slow compilation due to IN to OR transformation URL: https://github.com/apache/hive/pull/746 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor closed pull request #753: Hive 22120
jcamachor closed pull request #753: Hive 22120 URL: https://github.com/apache/hive/pull/753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor closed pull request #755: HIVE-22107 Correlated subquery producing wrong schema
jcamachor closed pull request #755: HIVE-22107 Correlated subquery producing wrong schema URL: https://github.com/apache/hive/pull/755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor closed pull request #791: HIVE-21924
jcamachor closed pull request #791: HIVE-21924 URL: https://github.com/apache/hive/pull/791 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor closed pull request #762: Hive 22164
jcamachor closed pull request #762: Hive 22164 URL: https://github.com/apache/hive/pull/762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor closed pull request #771: HIVE-20983
jcamachor closed pull request #771: HIVE-20983 URL: https://github.com/apache/hive/pull/771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] asfgit closed pull request #816: HIVE-22338: Shade dependent jars into the kudu-handler
asfgit closed pull request #816: HIVE-22338: Shade dependent jars into the kudu-handler URL: https://github.com/apache/hive/pull/816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #813: HIVE-22323 Fix Desc Table bugs
miklosgergely commented on a change in pull request #813: HIVE-22323 Fix Desc Table bugs URL: https://github.com/apache/hive/pull/813#discussion_r334367697 ## File path: ql/src/test/results/clientpositive/alterColumnStats.q.out ## @@ -144,15 +144,35 @@ PREHOOK: Input: default@p_n0 POSTHOOK: query: desc formatted p_n0 c1 POSTHOOK: type: DESCTABLE POSTHOOK: Input: default@p_n0 -# col_name data_type comment Review comment: Yes, it was intentional. I think it is much better to have a consistent output format for `desc formatted ` like commands, showing the same table all the time, explicitly showing that we don't have statistics for the column, instead of showing the smaller table as if a `desc ` command would have been executed. The previous form is only implicitly showing that there are no statistics, which can be misleading. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #809: HIVE-22274: upgrade Calcite to 1.21
jcamachor commented on a change in pull request #809: HIVE-22274: upgrade Calcite to 1.21 URL: https://github.com/apache/hive/pull/809#discussion_r334651939 ## File path: ql/src/test/results/clientpositive/llap/limit_pushdown.q.out ## @@ -816,12 +816,54 @@ POSTHOOK: type: QUERY POSTHOOK: Input: default@src A masked pattern was here STAGE DEPENDENCIES: - Stage-0 is a root stage + Stage-1 is a root stage + Stage-0 depends on stages: Stage-1 STAGE PLANS: + Stage: Stage-1 +Tez + A masked pattern was here + Edges: +Reducer 2 <- Map 1 (SIMPLE_EDGE) + A masked pattern was here + Vertices: +Map 1 +Map Operator Tree: +TableScan + alias: src + Statistics: Num rows: 500 Data size: 89000 Basic stats: COMPLETE Column stats: COMPLETE + Select Operator +expressions: key (type: string), value (type: string) +outputColumnNames: _col0, _col1 +Statistics: Num rows: 500 Data size: 89000 Basic stats: COMPLETE Column stats: COMPLETE +Reduce Output Operator + key expressions: _col0 (type: string) + sort order: + + Statistics: Num rows: 500 Data size: 89000 Basic stats: COMPLETE Column stats: COMPLETE + value expressions: _col1 (type: string) +Execution mode: vectorized, llap +LLAP IO: no inputs +Reducer 2 +Execution mode: vectorized, llap +Reduce Operator Tree: + Select Operator +expressions: KEY.reducesinkkey0 (type: string), VALUE._col0 (type: string) +outputColumnNames: _col0, _col1 +Statistics: Num rows: 500 Data size: 89000 Basic stats: COMPLETE Column stats: COMPLETE +Filter Operator + predicate: false (type: boolean) + Statistics: Num rows: 1 Data size: 178 Basic stats: COMPLETE Column stats: COMPLETE + File Output Operator +compressed: false +Statistics: Num rows: 1 Data size: 178 Basic stats: COMPLETE Column stats: COMPLETE +table: +input format: org.apache.hadoop.mapred.SequenceFileInputFormat +output format: org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat +serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe + Stage: Stage-0 Fetch Operator - limit: 0 + limit: -1 Review comment: It seems the initial assessment that filter with false condition was going to be less disruptive does not hold... Which ones were the regressions with limit 0? It seems it may be worth to move to original logic again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #809: HIVE-22274: upgrade Calcite to 1.21
jcamachor commented on a change in pull request #809: HIVE-22274: upgrade
Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334651216
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
##
@@ -109,7 +109,7 @@ public HiveJdbcImplementor(SqlDialect dialect,
JavaTypeFactory typeFactory) {
SqlNode sqlCondition = null;
SqlLiteral condType = JoinConditionType.ON.symbol(POS);
JoinType joinType = joinType(e.getJoinType());
-if (e.getJoinType() == JoinRelType.INNER &&
e.getCondition().isAlwaysTrue()) {
+if ((e.getJoinType() == JoinRelType.INNER || e.isSemiJoin()) &&
e.getCondition().isAlwaysTrue()) {
Review comment:
`ql/src/test/queries/clientpositive/external_jdbc_table*` files contain
tests for jdbc storage handler. We should add a test over there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] vineetgarg02 commented on a change in pull request #809: HIVE-22274: upgrade Calcite to 1.21
vineetgarg02 commented on a change in pull request #809: HIVE-22274: upgrade
Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334602095
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java
##
@@ -225,7 +225,7 @@ public JoinPredicateInfo getJoinPredicateInfo() {
private boolean containsOuter() {
for (JoinRelType joinType : joinTypes) {
- if (joinType != JoinRelType.INNER) {
+ if (joinType != JoinRelType.INNER && joinType != JoinRelType.SEMI) {
Review comment:
It would be better to whitelist this for outer types (FULL, LEFT, RIGHT).
@scarlin-cloudera Either we can create separate jira or we can make the
change with this patch..upto you.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] vineetgarg02 commented on a change in pull request #809: HIVE-22274: upgrade Calcite to 1.21
vineetgarg02 commented on a change in pull request #809: HIVE-22274: upgrade
Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334609909
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
##
@@ -109,7 +109,7 @@ public HiveJdbcImplementor(SqlDialect dialect,
JavaTypeFactory typeFactory) {
SqlNode sqlCondition = null;
SqlLiteral condType = JoinConditionType.ON.symbol(POS);
JoinType joinType = joinType(e.getJoinType());
-if (e.getJoinType() == JoinRelType.INNER &&
e.getCondition().isAlwaysTrue()) {
+if ((e.getJoinType() == JoinRelType.INNER || e.isSemiJoin()) &&
e.getCondition().isAlwaysTrue()) {
Review comment:
Existing logic looks wrong. Even for SEMI JOIN `JoinType.COMMA` with
condition `NONE` is created (in case condition is always true).
@jcamachor Are there JDBC tests where I can test this logic for SEMI JOIN
type?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] vineetgarg02 commented on a change in pull request #809: HIVE-22274: upgrade Calcite to 1.21
vineetgarg02 commented on a change in pull request #809: HIVE-22274: upgrade
Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r333775973
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelBuilder.java
##
@@ -113,9 +113,8 @@ public RelBuilder filter(Iterable
predicates) {
@Override
public RelBuilder empty() {
final RelNode input = build();
-final RelNode sort = HiveRelFactories.HIVE_SORT_FACTORY.createSort(
-input, RelCollations.of(), null, literal(0));
-return this.push(sort);
+final RelNode filter =
HiveRelFactories.HIVE_FILTER_FACTORY.createFilter(input, literal(false));
Review comment:
Method's comment is outdated (referring to Limit 0)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #813: HIVE-22323 Fix Desc Table bugs
jcamachor commented on a change in pull request #813: HIVE-22323 Fix Desc Table bugs URL: https://github.com/apache/hive/pull/813#discussion_r334611107 ## File path: ql/src/test/results/clientpositive/beeline/escape_comments.q.out ## @@ -78,7 +78,6 @@ PREHOOK: Input: escape_comments_db@escape_comments_tbl1 POSTHOOK: query: describe formatted escape_comments_tbl1 POSTHOOK: type: DESCTABLE POSTHOOK: Input: escape_comments_db@escape_comments_tbl1 -# col_name data_type comment Review comment: Yeah, I wonder what may be different between the test env of the driver and the real one... Anyway, good to know, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #800: HIVE-22276 Break up DDLSemanticAnalyzer - extract View related analyzers
jcamachor commented on a change in pull request #800: HIVE-22276 Break up DDLSemanticAnalyzer - extract View related analyzers URL: https://github.com/apache/hive/pull/800#discussion_r334600636 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLSemanticAnalyzerFactory.java ## @@ -29,10 +29,13 @@ import org.apache.hadoop.hive.ql.metadata.Hive; import org.apache.hadoop.hive.ql.parse.ASTNode; import org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer; +import org.apache.hadoop.hive.ql.parse.CalcitePlanner; import org.reflections.Reflections; import com.google.common.annotations.VisibleForTesting; +import avro.shaded.com.google.common.collect.Sets; Review comment: We should not use the shaded version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] granthenke opened a new pull request #816: HIVE-22338: Shade dependent jars into the kudu-handler
granthenke opened a new pull request #816: HIVE-22338: Shade dependent jars into the kudu-handler URL: https://github.com/apache/hive/pull/816 This patch shades the Kudu client and it’s async dependency into the kudu-handler jar to simplify add jar style usage and ensure the addDependencyJars method adds all the required classes. It also adjusts the master address property to fallback to the default instead of looking it up first. This allows the default to be unset when the table property exists. I ran into this when using the handler via `add jar`. Change-Id: Ie900abe21b685c9591e6147efe5c3b4b96791f5e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] belugabehr opened a new pull request #815: HIVE-22337: Improve and Expand Text-Based SerDes
belugabehr opened a new pull request #815: HIVE-22337: Improve and Expand Text-Based SerDes URL: https://github.com/apache/hive/pull/815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #800: HIVE-22276 Break up DDLSemanticAnalyzer - extract View related analyzers
miklosgergely commented on a change in pull request #800: HIVE-22276 Break up
DDLSemanticAnalyzer - extract View related analyzers
URL: https://github.com/apache/hive/pull/800#discussion_r334498615
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLSemanticAnalyzerFactory.java
##
@@ -52,8 +55,11 @@ private DDLSemanticAnalyzerFactory() {
private static final Map>
TYPE_TO_ANALYZER = new HashMap<>();
static {
-Set> analyzerClasses =
+Set> analyzerClasses1 =
new
Reflections("org.apache.hadoop.hive.ql.ddl").getSubTypesOf(BaseSemanticAnalyzer.class);
Review comment:
Fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #800: HIVE-22276 Break up DDLSemanticAnalyzer - extract View related analyzers
miklosgergely commented on a change in pull request #800: HIVE-22276 Break up
DDLSemanticAnalyzer - extract View related analyzers
URL: https://github.com/apache/hive/pull/800#discussion_r334498535
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteDesc.java
##
@@ -27,17 +27,17 @@
*/
@Explain(displayName = "Alter Materialized View Rewrite", explainLevels = {
Level.USER, Level.DEFAULT, Level.EXTENDED })
public class AlterMaterializedViewRewriteDesc implements DDLDescWithWriteId {
- private final String fqMaterializedViewName;
+ private final String materializedViewName;
private final boolean rewriteEnable;
- public AlterMaterializedViewRewriteDesc(String fqMaterializedViewName,
boolean rewriteEnable) {
-this.fqMaterializedViewName = fqMaterializedViewName;
+ public AlterMaterializedViewRewriteDesc(String materializedViewName, boolean
rewriteEnable) {
+this.materializedViewName = materializedViewName;
Review comment:
Put back the fq prefix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #800: HIVE-22276 Break up DDLSemanticAnalyzer - extract View related analyzers
miklosgergely commented on a change in pull request #800: HIVE-22276 Break up DDLSemanticAnalyzer - extract View related analyzers URL: https://github.com/apache/hive/pull/800#discussion_r334498447 ## File path: ql/src/test/results/clientnegative/materialized_view_no_transactional_rewrite_2.q.out ## @@ -27,4 +27,4 @@ POSTHOOK: type: CREATE_MATERIALIZED_VIEW POSTHOOK: Input: default@cmv_basetable POSTHOOK: Output: database:default POSTHOOK: Output: default@cmv_mat_view -FAILED: SemanticException Automatic rewriting for materialized view cannot be enabled if the materialized view uses non-transactional tables +FAILED: SemanticException Automatic rewriting for materialized view cannot be enabled if the materialized view uses non-transactional tables Review comment: Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] miklosgergely closed pull request #811: HIVE-22328 Min value for column in stats is not set correctly for some data types in partitioned tables
miklosgergely closed pull request #811: HIVE-22328 Min value for column in stats is not set correctly for some data types in partitioned tables URL: https://github.com/apache/hive/pull/811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] sreekesh93 opened a new pull request #814: Nagaraj & Sreekesh | Examples for hive metastore operations.
sreekesh93 opened a new pull request #814: Nagaraj & Sreekesh | Examples for hive metastore operations. URL: https://github.com/apache/hive/pull/814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #813: HIVE-22323 Fix Desc Table bugs
miklosgergely commented on a change in pull request #813: HIVE-22323 Fix Desc Table bugs URL: https://github.com/apache/hive/pull/813#discussion_r334366238 ## File path: ql/src/test/results/clientpositive/beeline/escape_comments.q.out ## @@ -78,7 +78,6 @@ PREHOOK: Input: escape_comments_db@escape_comments_tbl1 POSTHOOK: query: describe formatted escape_comments_tbl1 POSTHOOK: type: DESCTABLE POSTHOOK: Input: escape_comments_db@escape_comments_tbl1 -# col_name data_type comment Review comment: In case of the beeline outputs we don't need the header here in the output. So for some reason the output here doesn't contain it, still it will be there in the actual real BeeLine output. When it was present here too, the tables had 2 headers, by removing this row they will only have one. Which is not shown in the test output :) Kind of confusing, we should have a jira for making the TestBeeLineDriver writing characters to the output files exactly as a real BeeLine would. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #813: HIVE-22323 Fix Desc Table bugs
miklosgergely commented on a change in pull request #813: HIVE-22323 Fix Desc
Table bugs
URL: https://github.com/apache/hive/pull/813#discussion_r334364791
##
File path: ql/src/test/results/clientpositive/beeline/colstats_all_nulls.q.out
##
@@ -43,38 +43,38 @@ PREHOOK: Input: default@all_nulls
POSTHOOK: query: describe formatted all_nulls a
POSTHOOK: type: DESCTABLE
POSTHOOK: Input: default@all_nulls
-col_name a NULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
-data_type bigint NULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
-min0 NULLNULLNULLNULLNULLNULLNULLNULL
NULLNULL
-max0 NULLNULLNULLNULLNULLNULLNULLNULL
NULLNULL
-num_nulls 5 NULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
-distinct_count 1 NULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
-avg_col_lenNULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
-max_col_lenNULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
-num_trues NULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
-num_falses NULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
-bitVector HL NULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
-commentfrom deserializer NULLNULLNULLNULLNULL
NULLNULLNULLNULLNULL
-COLUMN_STATS_ACCURATE
{\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\",\"b\":\"true\",\"c\":\"true\"}}
NULLNULLNULLNULLNULLNULLNULLNULLNULL
NULL
+col_name a
+data_type bigint
+min0
+max0
+num_nulls 5
+distinct_count 1
+avg_col_len
+max_col_len
+num_trues
+num_falses
+bit_vector HL
+commentfrom deserializer
+COLUMN_STATS_ACCURATE
{\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\",\"b\":\"true\",\"c\":\"true\"}}
PREHOOK: query: describe formatted all_nulls b
PREHOOK: type: DESCTABLE
PREHOOK: Input: default@all_nulls
POSTHOOK: query: describe formatted all_nulls b
POSTHOOK: type: DESCTABLE
POSTHOOK: Input: default@all_nulls
-col_name b NULLNULLNULLNULLNULLNULLNULL
NULLNULLNULL
Review comment:
Yes. It was because the program has applied the long, detailed header for
formatted desc for column data. These tables have 12 data, but they are
transposed, so at the end they have only 2 columns. Still they were given the
schema containing the 12 columns at the fetch task, which led to these tables
with many empty columns. It was fixed in this patch.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
