Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]
sonarcloud[bot] commented on PR #4998: URL: https://github.com/apache/hive/pull/4998#issuecomment-2060436111 ## [](https://sonarcloud.io/dashboard?id=apache_hive=4998) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_hive=4998=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=4998=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4998=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=4998) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121: Use direct SQL for transactional altering table parameter (#5129) [hive]
sonarcloud[bot] commented on PR #5197: URL: https://github.com/apache/hive/pull/5197#issuecomment-2060344057 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5197) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5197=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5197=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5197=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5197) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]
ryukobayashi commented on PR #4998: URL: https://github.com/apache/hive/pull/4998#issuecomment-2060332537 @deniskuzZ Thanks for review. I fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28196: Preserve column stats when applying UDF upper/lower [hive]
sonarcloud[bot] commented on PR #5191: URL: https://github.com/apache/hive/pull/5191#issuecomment-2060305300 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5191) **Quality Gate passed** Issues  [5 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5191=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5191=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5191=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5191) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]
ryukobayashi commented on code in PR #4998:
URL: https://github.com/apache/hive/pull/4998#discussion_r1568140501
##
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLike.java:
##
@@ -45,11 +45,12 @@ public class UDFLike extends UDF {
// Doing characters comparison directly instead of regular expression
// matching for simple patterns like "%abc%".
- private enum PatternType {
+ public enum PatternType {
Review Comment:
Got it. I will fix each.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]
sonarcloud[bot] commented on PR #5123: URL: https://github.com/apache/hive/pull/5123#issuecomment-2060176311 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5123) **Quality Gate passed** Issues  [10 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5123=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5123=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5123=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5123) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28199: Fix docker issues with Hive 3.1.3 on Mac. [hive]
dengzhhu653 merged PR #5178: URL: https://github.com/apache/hive/pull/5178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28190: Fix heartbeatLockMaterializationRebuild [hive]
sonarcloud[bot] commented on PR #5186: URL: https://github.com/apache/hive/pull/5186#issuecomment-2060079605 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5186) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive=5186=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5186=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5186=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5186) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]
sonarcloud[bot] commented on PR #5123: URL: https://github.com/apache/hive/pull/5123#issuecomment-2060015039 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5123) **Quality Gate passed** Issues  [10 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5123=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5123=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5123=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5123) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] [WIP] Calcite upgrade 1.33 [hive]
sonarcloud[bot] commented on PR #5196: URL: https://github.com/apache/hive/pull/5196#issuecomment-2059867342 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5196) **Quality Gate passed** Issues  [38 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5196=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5196=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5196=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5196) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] Draft: ORC projected size fix for ACID [hive]
sonarcloud[bot] commented on PR #5195: URL: https://github.com/apache/hive/pull/5195#issuecomment-2059811247 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5195) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5195=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5195=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5195=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5195) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]
sonarcloud[bot] commented on PR #5198: URL: https://github.com/apache/hive/pull/5198#issuecomment-2059736714 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5198) **Quality Gate passed** Issues  [11 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5198=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5198=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5198=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5198) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]
deniskuzZ commented on code in PR #4998:
URL: https://github.com/apache/hive/pull/4998#discussion_r1567796368
##
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLike.java:
##
@@ -45,11 +45,12 @@ public class UDFLike extends UDF {
// Doing characters comparison directly instead of regular expression
// matching for simple patterns like "%abc%".
- private enum PatternType {
+ public enum PatternType {
Review Comment:
please revert changes in that class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]
deniskuzZ commented on PR #4998:
URL: https://github.com/apache/hive/pull/4998#issuecomment-2059693201
> @deniskuzZ This is original and I don't know why multiple matcher
factories are needed. As you opinion, one factory should be no problem. So, I
fixed.
nice,
1 last thing, I forgot to post it, could we please override `format` method
per enum
private enum UDFLikePattern {
BEGIN(BeginChecker.class) {
@Override
String format(String pattern) {
return pattern.substring(0, pattern.length() - 1);
}
},
END(EndChecker.class) {
@Override
String format(String pattern) {
return pattern.substring(1);
}
},
MIDDLE(MiddleChecker.class) {
@Override
String format(String pattern) {
return pattern.substring(1, pattern.length() - 1);
}
},
COMPLEX(ComplexChecker.class) {
@Override
String format(String pattern) {
return "^" + UDFLike.likePatternToRegExp(pattern) + "$";
}
},
CHAINED(ChainedChecker.class),
NONE(NoneChecker.class);
Class checker;
UDFLikePattern(Class checker) {
this.checker = checker;
}
String format(String pattern) {
return pattern;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]
sonarcloud[bot] commented on PR #5123: URL: https://github.com/apache/hive/pull/5123#issuecomment-2059679977 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5123) **Quality Gate passed** Issues  [10 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5123=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5123=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5123=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5123) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]
wecharyu commented on code in PR #5198:
URL: https://github.com/apache/hive/pull/5198#discussion_r1567738443
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##
@@ -1052,7 +1052,7 @@ public enum ConfVars {
"get_partitions_by_names, \n" +
"get_partitions_with_auth, \n" +
"get_partitions_by_filter, \n" +
-"get_partitions_spec_by_filter, \n" +
Review Comment:
Minor typo fix.
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##
@@ -3466,11 +3467,49 @@ protected List getJdoResult(
}.run(true);
}
- private List getPartitionNamesViaOrm(Table table, ExpressionTree
tree, String order,
Review Comment:
Refactor this method because it's used in partition level, and do not needs
the cd field of table, but the original parameter `Table table` retrieved via
ORM must include cd information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
[PR] HIVE-28200: Improve get_partitions_by_filter/expr when partition limit enabled [hive]
wecharyu opened a new pull request, #5198: URL: https://github.com/apache/hive/pull/5198 ### What changes were proposed in this pull request? When `hive.metastore.limit.partition.request` is configured, HMS would get the matched partition counts before getting the real partition objects. The count operation could be a slow query if the input filter or expr is too complex, and such slow filter will be executed twice. We can make an improvement by the new steps: 1. get matched partition names firstly, 2. then check limit through the size of partition names, 3. finally get the partitions by the partition names. ### Why are the changes needed? To reduce the slow filter execute times. ### Does this PR introduce _any_ user-facing change? No. ### Is the change a dependency upgrade? No. ### How was this patch tested? Add unit test and benchmark test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28059: Iceberg REST Catalog [hive]
sonarcloud[bot] commented on PR #5145: URL: https://github.com/apache/hive/pull/5145#issuecomment-2059554620 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5145) **Quality Gate passed** Issues  [60 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5145=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5145=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5145=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive=5145=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5145) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]
difin commented on code in PR #5123:
URL: https://github.com/apache/hive/pull/5123#discussion_r1567652570
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##
@@ -569,14 +575,25 @@ private void commitWrite(Table table, String branchName,
Long snapshotId, long s
* @param rewritePolicy The rewrite policy to use for the insert overwrite
commit
*/
private void commitOverwrite(Table table, String branchName, long startTime,
FilesForCommit results,
- RewritePolicy rewritePolicy) {
+ RewritePolicy rewritePolicy, String partitionSpec) {
Preconditions.checkArgument(results.deleteFiles().isEmpty(), "Can not
handle deletes with overwrite");
if (!results.dataFiles().isEmpty()) {
Transaction transaction = table.newTransaction();
if (rewritePolicy == RewritePolicy.ALL_PARTITIONS) {
DeleteFiles delete = transaction.newDelete();
delete.deleteFromRowFilter(Expressions.alwaysTrue());
delete.commit();
+LOG.info("Overwrite commit: truncated all partitions for table: {}
with {} file(s)",
+table, results.dataFiles().size());
+ } else if (!partitionSpec.isEmpty()) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28077: Iceberg: Major QB Compaction on partition level [hive]
difin commented on code in PR #5123:
URL: https://github.com/apache/hive/pull/5123#discussion_r1567652089
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java:
##
@@ -44,22 +52,68 @@ public boolean run(CompactorContext context) throws
IOException, HiveException,
Map tblProperties = context.getTable().getParameters();
LOG.debug("Initiating compaction for the {} table", compactTableName);
-String compactionQuery = String.format("insert overwrite table %s select *
from % tblProperties = context.getTable().getParameters();
LOG.debug("Initiating compaction for the {} table", compactTableName);
-String compactionQuery = String.format("insert overwrite table %s select *
from % partSpecMap = Warehouse.makeSpecFromName(partSpec);
+ StringBuilder sb = new StringBuilder();
+
+ for (int i = 0; i < partitionData.size(); ++i) {
+if (i > 0) {
+ sb.append(delimiter);
+}
+
+String quoteOpt = "";
+if (partitionData.getType(i).typeId() == Type.TypeID.STRING ||
+partitionData.getType(i).typeId() == Type.TypeID.DATE ||
+partitionData.getType(i).typeId() == Type.TypeID.TIME ||
+partitionData.getType(i).typeId() == Type.TypeID.TIMESTAMP ||
+partitionData.getType(i).typeId() == Type.TypeID.BINARY) {
+ quoteOpt = "'";
+}
+
+sb.append(partitionData.getSchema().getFields().get(i).name())
+.append("=")
+.append(quoteOpt)
+
.append(partSpecMap.get(partitionData.getPartitionType().fields().get(i).name()))
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]
sonarcloud[bot] commented on PR #4998: URL: https://github.com/apache/hive/pull/4998#issuecomment-2058875417 ## [](https://sonarcloud.io/dashboard?id=apache_hive=4998) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_hive=4998=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=4998=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4998=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=4998) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-26926: SHOW PARTITIONS for a non partitioned table should just throw execution error instead of full stack trace. [hive]
sonarcloud[bot] commented on PR #5164: URL: https://github.com/apache/hive/pull/5164#issuecomment-2058833692 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5164) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive=5164=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5164=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5164=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5164) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28121: Use direct SQL for transactional altering table parameter (#5129) [hive]
sonarcloud[bot] commented on PR #5197: URL: https://github.com/apache/hive/pull/5197#issuecomment-205871 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5197) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5197=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5197=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5197=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5197) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[PR] HIVE-28121: Use direct SQL for transactional altering table parameter (#5129) [hive]
lirui-apache opened a new pull request, #5197: URL: https://github.com/apache/hive/pull/5197 Cherry-pick #5129 to branch-4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]
ryukobayashi commented on PR #4998: URL: https://github.com/apache/hive/pull/4998#issuecomment-2058574736 @deniskuzZ This is original and I don't know why multiple matcher factories are needed. As you opinion, one factory should be no problem. So, I fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]
deniskuzZ commented on PR #4998:
URL: https://github.com/apache/hive/pull/4998#issuecomment-2058437503
> @deniskuzZ I have fixed it as per your suggestion. But, we did not
integrate it with UDFLike because it would require major fixes to the logic.
Please let me know if you think it should be fixed.
hi @ryukobayashi, since we directly identify the pattern, why do we need
multiple matcher factories, can we have just 1 factory?
public class FilterStringColLikeStringScalar extends
AbstractFilterStringColLikeStringScalar {
private static final long serialVersionUID = 1L;
private transient final static List checkerFactories =
ImmutableList.of(
pattern -> {
UDFLikePattern udfLike = UDFLikePattern.matcher(pattern);
try {
return udfLike.checker.getConstructor(String.class).newInstance(
udfLike.format(pattern));
} catch (Exception e) {
throw new IllegalArgumentException("unable to initialize Checker");
}
});
public FilterStringColLikeStringScalar() {
super();
}
public FilterStringColLikeStringScalar(int colNum, byte[] likePattern) {
super(colNum, null);
super.setPattern(new String(likePattern, StandardCharsets.UTF_8));
}
@Override
protected List getCheckerFactories() {
return checkerFactories;
}
private enum UDFLikePattern {
BEGIN(BeginChecker.class),
END(EndChecker.class),
MIDDLE(MiddleChecker.class),
NONE(NoneChecker.class),
CHAINED(ChainedChecker.class),
COMPLEX(ComplexChecker.class);
Class checker;
UDFLikePattern(Class checker) {
this.checker = checker;
}
private static UDFLikePattern matcher(String pattern) {
UDFLikePattern lastType = NONE;
int length = pattern.length();
char lastChar = 0;
for (int i = 0; i < length; i++) {
char n = pattern.charAt(i);
if (n == '_' && lastChar != '\\') { // such as "a_bc"
return COMPLEX;
} else if (n == '%') {
if (i == 0) { // such as "%abc"
lastType = END;
} else if (i < length - 1) {
if (lastChar != '\\') { // such as "a%bc"
lastType = CHAINED;
}
} else {
if (lastChar != '\\') {
if (lastType == END) { // such as "%abc%"
lastType = MIDDLE;
} else if (lastType != CHAINED) {
lastType = BEGIN; // such as "abc%"
}
}
}
}
lastChar = n;
}
return lastType;
}
private String format(String pattern) {
int startIndex = 0;
int endIndex = pattern.length();
switch (this) {
case BEGIN:
endIndex--;
break;
case END:
startIndex++;
break;
case MIDDLE:
startIndex++;
endIndex--;
break;
case COMPLEX:
return "^" + UDFLike.likePatternToRegExp(pattern) + "$";
}
return pattern.substring(startIndex, endIndex);
}
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28127: Exception when rebuilding materialized view with calculated columns on iceberg sources [hive]
kasakrisz merged PR #5143: URL: https://github.com/apache/hive/pull/5143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-26339: HIVE-26047 Related LIKE pattern issues [hive]
sonarcloud[bot] commented on PR #4998: URL: https://github.com/apache/hive/pull/4998#issuecomment-2058320446 ## [](https://sonarcloud.io/dashboard?id=apache_hive=4998) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_hive=4998=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=4998=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4998=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=4998) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
