Re: [PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]
wecharyu commented on PR #5223: URL: https://github.com/apache/hive/pull/5223#issuecomment-2112226376 > This change looks like a variant of dropPartitions based on one current implementation, it's not a good choice to declare it as a first class API. It's more like a function complement, before this PR, hive client can only drop partitions by exprs, but actually the server side supports drop partitions by names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]
dengzhhu653 commented on PR #5223: URL: https://github.com/apache/hive/pull/5223#issuecomment-2107608744 > Does `drop partitions by names` have any advantages over `drop partitions by expressions`? > > My concern is that we already have lots of redundant api and other components(Spark/Trino/Impala) may not need the new added api. > > But if the new added api has some advantages over old api, i think we can move on. > > I also want to listen to other folks's opinions. :) +1 This change looks like a variant of `dropPartitions` based on one current implementation, it's not a good choice to declare it as a first class API. If we really need to add it in the future, I would prefer making it an util method instead in `MetaStoreUtils` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]
wecharyu commented on PR #5223: URL: https://github.com/apache/hive/pull/5223#issuecomment-2102112701 > Does drop partitions by names have any advantages over drop partitions by expressions? drop partitions by names is not aimed to replace drop by expressions, they each serve distinct purpose. And it's more easy to use and do not need deserialization in server side compared with expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]
zhangbutao commented on PR #5223: URL: https://github.com/apache/hive/pull/5223#issuecomment-2101823659 Does `drop partitions by names` have any advantages over `drop partitions by expressions`? My concern is that we already have lots of redundant api and other components(Spark/Trino/Impala) may not need the new added api. But if the new added api has some advantages over old api, i think we can move on. I also want to listen to other folks's opinions. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]
sonarcloud[bot] commented on PR #5223: URL: https://github.com/apache/hive/pull/5223#issuecomment-2100972803 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5223) **Quality Gate passed** Issues  [20 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5223=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5223=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5223=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5223) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]
wecharyu commented on PR #5223: URL: https://github.com/apache/hive/pull/5223#issuecomment-2100889524 This PR is followed https://github.com/apache/hive/pull/4905#discussion_r1464194112, @zhangbutao @dengzhhu653 @deniskuzZ pls take a look in your convenience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]
sonarcloud[bot] commented on PR #5223: URL: https://github.com/apache/hive/pull/5223#issuecomment-2082407335 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5223) **Quality Gate passed** Issues  [20 New issues](https://sonarcloud.io/project/issues?id=apache_hive=5223=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5223=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5223=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5223) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
[PR] HIVE-28219: Support drop partitions by names in IMetaStoreClient [hive]
wecharyu opened a new pull request, #5223: URL: https://github.com/apache/hive/pull/5223 ### What changes were proposed in this pull request? In thrift api definition, HMS support to drop partitions by both partition names and expressions. But current api in `IMetaStoreClient` only support drop partitions by expressions, we should add new api to support drop partitions by names. ```java // IMetaStoreClient.java List dropPartitions(String catName, String dbName, String tblName, RequestPartsSpec partsSpec, PartitionDropOptions options) throws NoSuchObjectException, MetaException, TException; ``` ### Why are the changes needed? To improve the `dropPartitions` function. ### Does this PR introduce _any_ user-facing change? Yes, user can use the new api to drop partitions by names. ### Is the change a dependency upgrade? No. ### How was this patch tested? Add unit test: ```bash mvn test -Dtest=org.apache.hadoop.hive.ql.metadata.TestHive -pl :hive-exec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
