Re: [PR] HIVE-28192 Iceberg: Fix thread safety issue with PositionDeleteInfo i… [hive]
deniskuzZ closed pull request #5188: HIVE-28192 Iceberg: Fix thread safety issue with PositionDeleteInfo i… URL: https://github.com/apache/hive/pull/5188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28192 Iceberg: Fix thread safety issue with PositionDeleteInfo i… [hive]
simhadri-g commented on PR #5188: URL: https://github.com/apache/hive/pull/5188#issuecomment-2063870107 Lets close it, still investigating the shared IOContext . So far I haven't been able to recreate this in a cluster , so i think this is a bug with Junit. Once i have more details, i will open a new one or reopen this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28192 Iceberg: Fix thread safety issue with PositionDeleteInfo i… [hive]
deniskuzZ commented on PR #5188: URL: https://github.com/apache/hive/pull/5188#issuecomment-2063843425 @simhadri-g, should we close this or do you plan to continue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28192 Iceberg: Fix thread safety issue with PositionDeleteInfo i… [hive]
zratkai commented on code in PR #5188:
URL: https://github.com/apache/hive/pull/5188#discussion_r1559244336
##
ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java:
##
@@ -51,7 +51,7 @@ public class IOContext {
*/
private RecordIdentifier ri;
private boolean isDeletedRecord;
- private PositionDeleteInfo pdi;
+ private ThreadLocal pdi = new ThreadLocal<>();
Review Comment:
Should not be the whole IOContext class immutable? It contains many fields
which can be modified asynchronously and it can cause concurrency issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28192 Iceberg: Fix thread safety issue with PositionDeleteInfo i… [hive]
sonarcloud[bot] commented on PR #5188: URL: https://github.com/apache/hive/pull/5188#issuecomment-2047128617 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5188) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive=5188=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5188=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5188=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5188) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28192 Iceberg: Fix thread safety issue with PositionDeleteInfo i… [hive]
deniskuzZ commented on code in PR #5188:
URL: https://github.com/apache/hive/pull/5188#discussion_r1559056770
##
ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java:
##
@@ -51,7 +51,7 @@ public class IOContext {
*/
private RecordIdentifier ri;
private boolean isDeletedRecord;
- private PositionDeleteInfo pdi;
+ private ThreadLocal pdi = new ThreadLocal<>();
Review Comment:
shouldn't the whole `IOContext` be thread local or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28192 Iceberg: Fix thread safety issue with PositionDeleteInfo i… [hive]
sonarcloud[bot] commented on PR #5188: URL: https://github.com/apache/hive/pull/5188#issuecomment-2046607105 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5188) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive=5188=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5188=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5188=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5188) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
Re: [PR] HIVE-28192 Iceberg: Fix thread safety issue with PositionDeleteInfo i… [hive]
sonarcloud[bot] commented on PR #5188: URL: https://github.com/apache/hive/pull/5188#issuecomment-2046340287 ## [](https://sonarcloud.io/dashboard?id=apache_hive=5188) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive=5188=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_hive=5188=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=5188=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive=5188) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
