[GitHub] [beam] iemejia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB

2020-06-25 Thread GitBox 


iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445546038



##
File path: 
sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBPublisher.java
##
@@ -19,14 +19,16 @@
 
 import static java.nio.charset.StandardCharsets.UTF_8;
 import static java.util.Objects.requireNonNull;
-import static 
org.apache.beam.repackaged.core.org.apache.commons.lang3.StringUtils.isNoneBlank;
 
 import java.io.IOException;
 import java.util.Collection;
+import java.util.Map;
+import org.apache.beam.repackaged.core.org.apache.commons.lang3.StringUtils;

Review comment:
   argh this commons import escaped here too. Can you use the non 
repackaged version please.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] iemejia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB

2020-06-25 Thread GitBox 


iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445543215



##
File path: 
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
 saveSummary(null, configurations, actual, baseline, start, options);
   }
 
-  if (options.getExportSummaryToBigQuery()) {
-ImmutableMap schema =
-ImmutableMap.builder()
-.put("timestamp", "timestamp")
-.put("runtimeSec", "float")
-.put("eventsPerSec", "float")
-.put("numResults", "integer")
-.build();
+  final ImmutableMap schema =
+  ImmutableMap.builder()
+  .put("timestamp", "timestamp")
+  .put("runtimeSec", "float")
+  .put("eventsPerSec", "float")
+  .put("numResults", "integer")
+  .build();
 
+  if (options.getExportSummaryToBigQuery()) {
 savePerfsToBigQuery(
 BigQueryResultsPublisher.create(options.getBigQueryDataset(), 
schema),
 options,
 actual,
 start);
   }
+
+  if (options.getExportSummaryToInfluxDB()) {
+final long timestamp = start.getMillis() / 1000; // seconds

Review comment:
   Yes you guys are right seconds is ok for the execution timestamp and ms 
is good for the benchmark run time





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] iemejia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB

2020-06-25 Thread GitBox 


iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445543215



##
File path: 
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
 saveSummary(null, configurations, actual, baseline, start, options);
   }
 
-  if (options.getExportSummaryToBigQuery()) {
-ImmutableMap schema =
-ImmutableMap.builder()
-.put("timestamp", "timestamp")
-.put("runtimeSec", "float")
-.put("eventsPerSec", "float")
-.put("numResults", "integer")
-.build();
+  final ImmutableMap schema =
+  ImmutableMap.builder()
+  .put("timestamp", "timestamp")
+  .put("runtimeSec", "float")
+  .put("eventsPerSec", "float")
+  .put("numResults", "integer")
+  .build();
 
+  if (options.getExportSummaryToBigQuery()) {
 savePerfsToBigQuery(
 BigQueryResultsPublisher.create(options.getBigQueryDataset(), 
schema),
 options,
 actual,
 start);
   }
+
+  if (options.getExportSummaryToInfluxDB()) {
+final long timestamp = start.getMillis() / 1000; // seconds

Review comment:
   Yes you guys are right seconds is ok for the timestamps but ms are good 
for the benchmark results





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] iemejia commented on a change in pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB

2020-06-25 Thread GitBox 


iemejia commented on a change in pull request #11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445542488



##
File path: 
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
 saveSummary(null, configurations, actual, baseline, start, options);
   }
 
-  if (options.getExportSummaryToBigQuery()) {
-ImmutableMap schema =
-ImmutableMap.builder()
-.put("timestamp", "timestamp")
-.put("runtimeSec", "float")
-.put("eventsPerSec", "float")
-.put("numResults", "integer")
-.build();
+  final ImmutableMap schema =
+  ImmutableMap.builder()
+  .put("timestamp", "timestamp")
+  .put("runtimeSec", "float")

Review comment:
   Yes good idea





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org