Re: [Github-comments] [geany/geany-plugins] GeanyLua/GTK3: g_object_get_data: assertion 'G_IS_OBJECT (object)' failed (#1027)

2021-10-11 Thread Skif-off
Not reproduced with 1.38.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1027#issuecomment-940582642

Re: [Github-comments] [geany/geany-plugins] GeanyLua/GTK3: g_object_get_data: assertion 'G_IS_OBJECT (object)' failed (#1027)

2021-10-11 Thread Skif-off
Closed #1027.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1027#event-5446428663

Re: [Github-comments] [geany/geany] Make scrollbar thicker (#2933)

2021-10-11 Thread DUO Labs
Thank you, and yes, I checked it and it works fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2933#issuecomment-940527514

Re: [Github-comments] [geany/geany] Make scrollbae thicker (#2933)

2021-10-11 Thread elextr
Also there was an overview plugin, not sure it still works.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2933#issuecomment-940526296

Re: [Github-comments] [geany/geany] Make scrollbae thicker (#2933)

2021-10-11 Thread elextr
Scrollbars are controlled by GTK theme not Geany.  Options are:

1. change the GTK theme on your system to one with wider scrollbars
2. edit the GTK tweak CSS ~/.config/gtk-3.0/gtk.css as below (don't do this 
unless you want it to apply to all apps)
3. edit geany.css (`Menu->Tools->Configuration Files->geany.css`) as below

Add below to CSS (changing the numbers to suit your screen and eyes, those are 
probably too big but make it visible it worked) and restart Geany.

```
scrollbar slider {
/* Size of the slider */
min-width: 20px;
min-height: 20px;
border-radius: 22px;

/* Padding around the slider */
border: 5px solid transparent;
}
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2933#issuecomment-940525763

Re: [Github-comments] [geany/geany] Make scrollbae thicker (#2933)

2021-10-11 Thread elextr
Closed #2933.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2933#event-5446104184

[Github-comments] [geany/geany] Make scrollbae thicker (#2933)

2021-10-11 Thread DUO Labs
Whenever I'm trying to drag the scrollbar, It takes 2-3 times to hit it. So, it 
would be nice if it was thicker (or at least, adjustable). Or, there could be 
some sort of scrollable "Preview" feature like in Kate or Sublime?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2933

Re: [Github-comments] [geany/geany] Update to Scintilla 5.1.3 and Lexilla 5.1.2 (#2930)

2021-10-11 Thread elextr
I get a segfault on closing Geany with this applied, but not on master at 
dda15b47 bt:

```
Thread 1 "geany" received signal SIGSEGV, Segmentation fault.
0x77583500 in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
(gdb) bt
#0  0x77583500 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#1  0x7745283e in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#2  0x77435f60 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#3  0x77436a4d in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#4  0x77599703 in gtk_style_context_get_property ()
at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#5  0x775998c5 in gtk_style_context_get_valist ()
at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#6  0x77599b7e in gtk_style_context_get ()
at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#7  0x77643a02 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#8  0x77643fb3 in gtk_widget_create_pango_context ()
at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#9  0x77644080 in gtk_widget_get_pango_context ()
at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#10 0x776440ee in gtk_widget_create_pango_layout ()
at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#11 0x7745fd33 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#12 0x77460f87 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#13 0x7746163a in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#14 0x76d9bf03 in g_cclosure_marshal_VOID__OBJECTv ()
at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#15 0x76d98a56 in  ()
at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#16 0x76db7b48 in g_signal_emit_valist ()
at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#17 0x76db80f3 in g_signal_emit ()
at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#18 0x776358d4 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#19 0x77635908 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#20 0x775e6500 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#21 0x77635908 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#22 0x773d2670 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#23 0x77635908 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#24 0x77638b24 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#25 0x77647463 in gtk_widget_unparent ()
at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
--Type  for more, q to quit, c to continue without paging--c
#26 0x773ccb48 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#27 0x76d9bf03 in g_cclosure_marshal_VOID__OBJECTv () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#28 0x76d98a56 in  () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#29 0x76db7b48 in g_signal_emit_valist () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#30 0x76db80f3 in g_signal_emit () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#31 0x7741d0ec in gtk_container_remove () at 
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#32 0x7763d798 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#33 0x76d9f4d1 in g_object_run_dispose () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#34 0x77649ce9 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#35 0x7741ebca in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#36 0x76d98802 in g_closure_invoke () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#37 0x76dacb05 in  () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#38 0x76db7bbe in g_signal_emit_valist () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#39 0x76db80f3 in g_signal_emit () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#40 0x7763d870 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#41 0x776514ec in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#42 0x76d9f4d1 in g_object_run_dispose () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#43 0x77cefc3d in do_main_quit () at libmain.c:1339
#44 do_main_quit () at libmain.c:1255
#45 0x77cf18ac in main_quit () at libmain.c:1397
#46 0x77cc15bd in on_window_delete_event (widget=, 
event=, gdata=) at callbacks.c:84
#47 0x776895ef in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#48 0x76d98a56 in  () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#49 0x76db6df1 in g_signal_emit_valist () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#50 0x76db80f3 in g_signal_emit () at 
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#51 0x77633c23 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#52 0x774f138d in gtk_main_do_event () at 
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#53 0x771d9f79 in  () at /usr/lib/x86_64-linux-gnu/libgdk-3.so.0
#54 0x7720d106 in  () at /usr/lib/x86_64-linux-gnu/libgdk-3.so.0
#55 0x76ca517d in g_main_context_dispatch () at 

[Github-comments] [geany/geany-osx] Geany 1.38 does not start on MacOS (#28)

2021-10-11 Thread alexFRD77
After the latest update (universal builds) Geany doesn't launch at all, 
"Service exited with abnormal code: 1 " in system.log.  I've found no issues 
when forcing Rosetta though.
Im using a Macbook Air with arm chip.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/28

Re: [Github-comments] [geany/geany] Geany 1.38 does not start on MacOS (#2929)

2021-10-11 Thread poorlymac
Might be

% /Applications/Geany.app/Contents/MacOS/geany ; exit;
2021-10-12 09:32:46.364 geany[50041:1834806] dlopen() failed (possibly unsigned 
libgeany.0.dylib)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2929#issuecomment-940496755

Re: [Github-comments] [geany/geany] Feature request: Please provide an AppImage for Geany (#1303)

2021-10-11 Thread Enrico Tröger
We also have https://github.com/geany/geany/discussions/2926 now. Where to 
continue the discussion?
Until decided, I will add my remarks here.

For me, https://github.com/geany/geany/issues/1303#issuecomment-260706578 and 
https://github.com/geany/geany/issues/1303#issuecomment-260731920 are still 
valid (even five years later).

We already have more to do than we are able manage and putting even more work 
on us won't improve the situation.
I still think we (the Geany developers) should focus on creating software and 
not on packaging. And as @b4n said before, if volunteers like @fusion809, 
@ecmu, @probonopd and whoever else might want to step in and provide AppImages, 
Flatpaks, Snaps, ZeroInstalls, ... that's completely fine.
However, I don't see that those packaging efforts should happen within the 
Geany project itself.

We could easily add the AppImage to https://www.geany.org/download/third-party/ 
so that it gets more visible. Than we are done with five minutes of work.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1303#issuecomment-940491149

Re: [Github-comments] [geany/geany] Content of new not yet saved files is lost on crash (#2931)

2021-10-11 Thread elextr
Duplicate of #905 and #2717

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2931#issuecomment-940474301

Re: [Github-comments] [geany/geany] Content of new not yet saved files is lost on crash (#2931)

2021-10-11 Thread elextr
Closed #2931.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2931#event-5445794336

Re: [Github-comments] [geany/geany] Fixable startup speed regression opening large numbers of files in 1.36+ (#2883)

2021-10-11 Thread elextr
Scintilla 5.1.1 is merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2883#issuecomment-940471852

Re: [Github-comments] [geany/geany] Switch to Python 3 for GTK doc header generation (#2903)

2021-10-11 Thread Enrico Tröger
> python3 should always be present, python may not.

True but as said, in this case it doesn't matter. Autotools detect the Python 
interpreter to use and then uses this to start the script, i.e. the shebang is 
not evaluated at all (it executes something like `/usr/bin/python3 
scripts/gen-api-gtkdoc.py`).

I guess we agree on the change anyway.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2903#issuecomment-940467214

Re: [Github-comments] [geany/geany] Update to Scintilla5 (#2867)

2021-10-11 Thread Enrico Tröger
Thanks @kugel-!

The GeanyLua problem is already reported and linked.

For the primary clipboard problem I opened 
https://sourceforge.net/p/scintilla/bugs/2287/. Surprisingly, it's the same for 
Scite and there was no open/closed issue for it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#issuecomment-940465421

[Github-comments] [geany/geany] restricting the horizontal fold line to the visible span of the header text line (Discussion #2932)

2021-10-11 Thread Vic
Anyone else finds those fold lines too long ? 
I know that the fold lines are done by Scintilla, so I submitted a feature 
request there: https://sourceforge.net/p/scintilla/feature-requests/1419/ 
With attached pictures to see the proposal at a glance.
If you like it, maybe you can comment/support it there :) .

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/2932

Re: [Github-comments] [geany/geany] Switch to Python 3 for GTK doc header generation (#2903)

2021-10-11 Thread Thomas Martitz
python3 should always be present, python may not.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2903#issuecomment-940456637

Re: [Github-comments] [geany/geany] Switch to Python 3 for GTK doc header generation (#2903)

2021-10-11 Thread Enrico Tröger
@elextr do we want to use "python3" in the shebang of the script?
```
diff --git a/scripts/gen-api-gtkdoc.py b/scripts/gen-api-gtkdoc.py
index 75beb86c..7423257c 100755
--- a/scripts/gen-api-gtkdoc.py
+++ b/scripts/gen-api-gtkdoc.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 #
 #  Copyright 2015 The Geany contributors
 #
```

Technically it is not necessary as the script is called by Autotools with the 
detected Python interpreter but it would document that the script is meant to 
be run with Python3.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2903#issuecomment-940454201

Re: [Github-comments] [geany/geany-plugins] PGP key (#1119)

2021-10-11 Thread Enrico Tröger
AFAIU the key itself is fine and it *has* multiple user IDs.

However, it seems when retrieving the key from `keys.openpgp.org` the user IDs 
are missing.
Possibly related:
https://superuser.com/a/1485255
https://keys.openpgp.org/about/faq#older-gnupg

@xyproto to double check: if you download and import the key from 
https://download.geany.org/frlan-pubkey.txt, you will see the user ids and the 
signature verification should work. Of course, this does not solve the reported 
problem but should confirm that the key is OK.

@frlan did you verify your email address(es) at keys.openpgp.org?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1119#issuecomment-940433801

Re: [Github-comments] [geany/geany-plugins] GeanyVC:(Git) Fallback to `git rev-parse` for getting the repo/worktree's top directory (#1028)

2021-10-11 Thread nomadbyte
For some reason this fix did not make it into the 1.38. Is there any more 
details needed for this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1028#issuecomment-940405095

Re: [Github-comments] [geany/geany] Feature request: Please provide an AppImage for Geany (#1303)

2021-10-11 Thread probonopd
I'd encourage you to have both. The two formats are for completely different 
use cases. Here is a 
[comparison](https://github.com/AppImage/AppImageKit/wiki/Similar-projects).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1303#issuecomment-940309391

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread George Katevenis
Updated the manual.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2927#issuecomment-940231288

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread George Katevenis
@gkatev pushed 2 commits.

6c52d3ebe6383d96c8a6f6b524c69b6f0007deb8  Add UI option to hide the fold 
margin, while keeping code folding
243388414938773e9cd38f48aeb237ca041f50e0  Automatically unfold all code when 
folding is switched off in preferences


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2927/files/3ff536201efb74307c837f7585e0869be59d88fe..243388414938773e9cd38f48aeb237ca041f50e0


Re: [Github-comments] [geany/geany] Fixable startup speed regression opening large numbers of files in 1.36+ (#2883)

2021-10-11 Thread Justin Blanchard
> @UncombedCoconut one month later, but thanks a lot for trying some numbers 
> (in addition to fixing the issue in the first place)! I'll see if I can find 
> the time to measure it a tiny bit more consistently (inserting a timer around 
> the relevant parts), but your numbers suggest that #2747 isn't useful anymore 
> (which, despite the effort I put into, I'd be happy to get rid of). Anyway, 
> it doesn't seem like having it in slows anything down measurably, so there's 
> no hurry -- but not remembering what it was all about.

IMO, procrastination was a wise choice: A tested, known-good version 1.38 got 
released, and the Scintilla version on master is about to be 5.1.x. Once that's 
merged, I think it makes sense to re-test whether a backout of #2747 has any 
effect on performance.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2883#issuecomment-94017

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread Vic
> When configuring the editor, it's useful to have everything "in reach", 
> instead of looking around in menus (you can't even click on menus while the 
> preferences are opened).
...
> For example, with the 'hide fold margin' option, if you wanted to quickly 
> enable/disable it

Good points. So then that's another criterion to decide on whether it goes into 
"View" menu, vs in "Preferences" and/or configuration files. (My motivation is 
just to reduce unnecessary duplication/visual noise in various settings' 
location )
Like, is 'hide fold margin' something you would want to change often ? 
Personally, I'd decide early on whether I want to hide it or not, set it so, 
and very rarely need to change it again. 

Anyway, it's a relatively minor point, thanks again for implementing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2927#issuecomment-940221917

[Github-comments] [geany/geany] Content of new not yet saved files is lost on crash (#2931)

2021-10-11 Thread warren
If one creates a new file, but doesn't save it (giving it a name and a path), 
then it's content is lost on crash.

Would be nice if Geany would periodically save content of these new "untitled" 
tabs in case of crash/power loss.
At least in some ~/.config/geany file, so the user can restore it later.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2931

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread George Katevenis
So I don't have an opinion on whether folding should be allowed to be disabled 
or not, but currently it is, so I've implemented the new feature for all 
cases.. But, if you wanted to go ahead and remove the option to disable folding 
in the future, being able to hide the margin would satisfy those that do not 
use/want it.

On personal opinion level, since it's been mentioned here, I think the 
duplication of some items in the menu and the preferences dialog is ok. For 
example, with the 'hide fold margin' option, if you wanted to quickly 
enable/disable it, you would have to go through the not-necessarily-too-quick 
preferences dialog (if it was there only). When configuring the editor, it's 
useful to have everything "in reach", instead of looking around in menus (you 
can't even click on menus while the preferences are opened).

I will look into updating the manual.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2927#issuecomment-940183703

Re: [Github-comments] [geany/geany] Switch to Python 3 for GTK doc header generation (#2903)

2021-10-11 Thread Thomas Martitz
@kugel- approved this pull request.

So if you squash and add a little bit more information to the commit message 
(even if it's just the statement "We migrating away from python2") I'm fine



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2903#pullrequestreview-776158004

Re: [Github-comments] [geany/geany] Feature request: Please provide an AppImage for Geany (#1303)

2021-10-11 Thread Thomas Martitz
I pondered over creating a flatpak for Geany. I'm not sure about the pros and 
cons of AppImage vs flatpak, though. What would be better, or can you usefully 
have both?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1303#issuecomment-939969918

Re: [Github-comments] [geany/geany] Update to Scintilla 5.1.3 and Lexilla 5.1.2 (#2930)

2021-10-11 Thread Thomas Martitz
@kugel- commented on this pull request.



> @@ -388,7 +388,12 @@ static const HLStyle highlighting_styles_CSS[] =
{ SCE_CSS_EXTENDED_IDENTIFIER,  "extended_identifier",  
FALSE },
{ SCE_CSS_EXTENDED_PSEUDOCLASS, "extended_pseudoclass", 
FALSE },
{ SCE_CSS_EXTENDED_PSEUDOELEMENT,   "extended_pseudoelement",   
FALSE },
-   { SCE_CSS_MEDIA,"media",
FALSE }
+   { SCE_CSS_GROUP_RULE,   "group_rule",   
FALSE },
+   /* In Geany 1.38 and earlier shipped filetypes.css with "media" 
identifier,
+* Scintilla/Lexilla 5.1.2 has renamed this style and extended its 
meaning.
+* We still recognize media for compatibility.
+*/
+   { SCE_CSS_GROUP_RULE,   "media",
FALSE }

@b4n @eht16 is the compatibility fix I did here even valid?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2930#pullrequestreview-776147666

[Github-comments] [geany/geany] Update to Scintilla 5.1.3 and Lexilla 5.1.2 (#2930)

2021-10-11 Thread Thomas Martitz
Notable changes:
Scintilla:
- Add SC_ELEMENT_FOLD_LINE to set the colour of fold lines. Add 
SC_ELEMENT_HIDDEN_LINE to show where lines are hidden.
- On GTK, fix the line spacing so that underscores and accents are visible for 
some fonts such as DejaVu Sans Mono 10.

Lexilla
- Implement conditional group rules in CSS. Issue #25, Pull request #28.
- Check PHP numeric literals, showing invalid values with default style instead 
of numeric. Issue #20.

The CSS change causes compatiblity trouble. We exposed the changed style
in filetypes.css. We still do for compatiblity reasons but we still
want to align the style name to lexilla so we default to group_rule
now.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2930

-- Commit Summary --

  * https://github.com/geany/geany/pull/2930/commits/56416311291ea0e0ffeca4e244bf43b0544d8fac;>Update
 to Scintilla 5.1.3 and Lexilla 5.1.2

-- File Changes --

M data/filedefs/filetypes.css (2)
M scintilla/gtk/PlatGTK.cxx (4)
M scintilla/gtk/ScintillaGTK.cxx (50)
M scintilla/gtk/ScintillaGTK.h (3)
M scintilla/gtk/ScintillaGTKAccessible.cxx (1)
M scintilla/include/Scintilla.h (6)
M scintilla/include/Scintilla.iface (14)
M scintilla/include/ScintillaCall.h (4)
M scintilla/include/ScintillaMessages.h (4)
M scintilla/include/ScintillaTypes.h (2)
M scintilla/lexilla/include/SciLexer.h (2)
M scintilla/lexilla/lexers/LexCSS.cxx (8)
M scintilla/lexilla/lexers/LexHTML.cxx (140)
M scintilla/lexilla/lexers/LexMarkdown.cxx (9)
M scintilla/lexilla/lexlib/WordList.cxx (85)
M scintilla/lexilla/lexlib/WordList.h (9)
M scintilla/lexilla/version.txt (2)
M scintilla/src/AutoComplete.cxx (4)
M scintilla/src/AutoComplete.h (7)
M scintilla/src/CallTip.cxx (4)
M scintilla/src/CallTip.h (2)
M scintilla/src/CaseConvert.cxx (10)
M scintilla/src/CaseFolder.cxx (3)
M scintilla/src/CaseFolder.h (1)
M scintilla/src/CellBuffer.cxx (2)
M scintilla/src/ContractionState.cxx (2)
M scintilla/src/Decoration.cxx (12)
M scintilla/src/Document.cxx (23)
M scintilla/src/Document.h (38)
M scintilla/src/EditModel.cxx (1)
M scintilla/src/EditModel.h (1)
M scintilla/src/EditView.cxx (95)
M scintilla/src/Editor.cxx (48)
M scintilla/src/Editor.h (7)
M scintilla/src/Geometry.cxx (24)
M scintilla/src/Geometry.h (28)
M scintilla/src/Indicator.cxx (4)
M scintilla/src/KeyMap.cxx (4)
M scintilla/src/KeyMap.h (1)
M scintilla/src/LineMarker.cxx (2)
M scintilla/src/MarginView.cxx (528)
M scintilla/src/MarginView.h (2)
M scintilla/src/PositionCache.cxx (98)
M scintilla/src/PositionCache.h (21)
M scintilla/src/RESearch.cxx (4)
M scintilla/src/RESearch.h (1)
M scintilla/src/ScintillaBase.cxx (34)
M scintilla/src/Selection.cxx (3)
M scintilla/src/Selection.h (1)
M scintilla/src/Style.cxx (116)
M scintilla/src/Style.h (50)
M scintilla/src/UniConversion.h (2)
M scintilla/src/UniqueString.cxx (6)
M scintilla/src/UniqueString.h (4)
M scintilla/src/ViewStyle.cxx (316)
M scintilla/src/ViewStyle.h (30)
M scintilla/version.txt (2)
M src/highlightingmappings.h (7)

-- Patch Links --

https://github.com/geany/geany/pull/2930.patch
https://github.com/geany/geany/pull/2930.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2930


[Github-comments] [geany/geany] Geany 1.38 does not start on MacOS (#2929)

2021-10-11 Thread alexFRD77
After the latest update (universal builds) Geany doesn't launch at all, 
"Service exited with abnormal code: 1 " in system.log.  I've found no issues 
when forcing Rosetta though.
Im using a Macbook Air with arm chip.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2929

Re: [Github-comments] [geany/geany] Update to Scintilla5 (#2867)

2021-10-11 Thread Thomas Martitz
SciLexer.h fixed. Other problems are better tracked in distinct issues.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#issuecomment-939929530

[Github-comments] [geany/geany-plugins] PGP key (#1119)

2021-10-11 Thread Alexander F . Rødseth
Hi,

I'm in the process of upgrading the `geany-plugins` package for Arch Linux.

However, `makepkg` complains about the 01380DF54FD09D02 key that is mentioned 
on the [download page](https://plugins.geany.org/downloads.html):

```
==> Making package: geany-plugins 1.38-1 (Mon Oct 11 11:21:33 2021)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found geany-plugins-1.38.tar.bz2
  -> Found geany-plugins-1.38.tar.bz2.sig
==> Validating source files with b2sums...
geany-plugins-1.38.tar.bz2 ... Passed
geany-plugins-1.38.tar.bz2.sig ... Skipped
==> Verifying source file signatures with gpg...
geany-plugins-1.38.tar.bz2 ... FAILED (unknown public key 01380DF54FD09D02)
```

I also get `gpg: key 01380DF54FD09D02: no user ID` when importing it with `gpg`:

```
% gpg --keyserver hkps://keys.openpgp.org --search-keys 01380DF54FD09D02
gpg: data source: https://keys.openpgp.org:443
(1)   256 bit EDDSA key 01380DF54FD09D02, created: 2021-10-09
Keys 1-1 of 1 for "01380DF54FD09D02".  Enter number(s), N)ext, or Q)uit > 1
gpg: key 01380DF54FD09D02: no user ID
gpg: Total number processed: 1
```

Is everything in order with the current PGP/GPG key?

I would prefer not to skip the key validation. For many packages, a signature 
and key are not available, and I appreciate that it is available for 
`geany-plugins`.

Cheers!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1119

Re: [Github-comments] [geany/geany] cannot install on windows 7, 32bit (#2923)

2021-10-11 Thread elextr
Mint has an XFCE version.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2923#issuecomment-939805152

Re: [Github-comments] [geany/geany] cannot install on windows 7, 32bit (#2923)

2021-10-11 Thread Vic
@elextr  thanks for the recommendation! LOL, I'm rather on the minimalistic 
side (just not bare CLI), even Mint sounds fancy to me (in the past I tried 
Lubuntu and Xfce)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2923#issuecomment-939795789

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread Vic
Re: View: That sounds sensible to me. And if the setting is good for "View" 
menu, it shouldn't need to go into "Preferences" as well.

> To be clear the comment that it is a bad idea was a general one, not 
> specifically aimed at this PR.

Oh, I see now; my bad.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2927#issuecomment-939786966

Re: [Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread Dim-Tim-1963
...Though, the css itself needs tweaking.  For example, option ticks are 
invisible now (red squares).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928#issuecomment-939752513

Re: [Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread Dim-Tim-1963
Closed #2928.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928#event-5441172131

Re: [Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread Dim-Tim-1963
Yesss, it works! :)  I placed the file **gtk.css** in 
C:\Users\\_username_\AppData\Local\gtk-3.0 (created the missing dir "gtk-3.0"), 
and Geany applied the css to its UI.  Thanks, **elextr**!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928#issuecomment-939746571

Re: [Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread Dim-Tim-1963
I will try it, thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928#issuecomment-939732727

Re: [Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread elextr
have a look at 
https://stackoverflow.com/questions/36464010/change-gtk3-look-on-windows

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928#issuecomment-939731828

Re: [Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread Dim-Tim-1963
Here https://github.com/vinceliuice/stylish-gtk-theme there's a theme both for 
GTK2 and GTK3.  The question is how to apply it. :)  BTW, it would be nice to 
have at least a switch in the settings: light/dark UI theme.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928#issuecomment-939728303

Re: [Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread elextr
> Now I have to figure out, how to apply it to GTK3... :)

I suspect it doesn't, IIUC the gtkrc file is no longer used, GTK3 theme will be 
a `.css` file(s) IIUC, like the `geany.css` file that is available for tweaking 
things (but I doubt it can change a whole theme).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928#issuecomment-939724754

Re: [Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread Dim-Tim-1963
I found a solution for GTK2 (Geany 1.37).  
https://github.com/geany/geany/issues/1344#issuecomment-597588645  Now I have 
to figure out, how to apply it to GTK3... :)

P.S.: Thanks, **elextr**.  You always try to help.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928#issuecomment-939720806

Re: [Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread elextr
Thats set by the GTK theme, but I don't know how to set it on Windows, maybe 
google or one of the other windows users can help you.  Google will also help 
to find a dark theme to download if its not included.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928#issuecomment-939717538

Re: [Github-comments] [geany/geany] cannot install on windows 7, 32bit (#2923)

2021-10-11 Thread elextr
@VictorelPetrovich Thanks for the market data, makes it feel better to drop 32 
bit, but as you said, anybody who needs to can continue to use 1.37.1 and fork 
it if they want to backport later changes to Geany..

As for which Linux, thats likely to start a :bike: :house: (bikeshed) but IMHO 
if you want to use the distro to do stuff, and not be on the bleeding edge 
(well you did still have Windows 7 :-) then look at Mint.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2923#issuecomment-939713596

[Github-comments] [geany/geany] Geany 1.38 (GTK3) UI dark theme for Windows? (#2928)

2021-10-11 Thread Dim-Tim-1963
Is it possible?  I set up my favorite color scheme for the editor, but the rest 
of UI is very bright "black-on-white".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2928

Re: [Github-comments] [geany/geany] Folding code: more advanced commands (#2920)

2021-10-11 Thread Vic
I'll have to leave others to take it from here, as I found out windows32 bit OS 
(which unfortunately I have) won't be supported any more. 
Maybe I'll come back to this after I install Linux. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2920#issuecomment-939704008

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread elextr
> Is it a good idea to place these additions both in the Preferences and View 
> menu ? From what I can tell, many (or most) of the settings in View are 
> duplicates of those in Preferences. Maybe would be better to have in 
> Preferences only those that are not directly about Viewing the already-opened 
> files.

As I said I havn't looked at the changes, but the general principle is that 
`View` should change the UI layout immediately and the current state be saved 
and restored, like the checkbox on `Show Message window` etc.

> Unless I'm misunderstanding you: code folding enable/disable option is 
> already present in Preferences

To be clear the comment that it is a bad idea was a general one, not 
specifically aimed at this PR.  

But it was meant to indicate that therefore the operations in the PR that 
depend on turning it off are less useful since it should only very rarely be 
turned off.

> I for one would prefer the docs to open in all-folded state (given that it's 
> not possible/ too hard to implement remembering of folding state)

IIUC fold state saving has been folded into (see what I did there ;-) both 
numbered bookmarks and workbench plugins.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2927#issuecomment-939703551

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread Vic
If you don't mind a simple user's opinion: I think these are all good changes; 
here's some questions and feedback:

> UI Additions: 

Why do choose to place these additions both in the Preferences and View menu ? 
From what I can tell, many (or most) of the settings in View are duplicates of 
those in Preferences. Maybe would be better to have in Preferences only those 
that are not directly about Viewing?

> I've added some logic to automatically unfold all code when switching off 
> folding

Nice, I noticed this little omission too. 
While you are at it, do you think it would be too hard to also add an option to 
choose the default folding state when opening a document? I for one would 
prefer the docs to open in all-folded state (given that it's not possible/ too 
hard to implement remembering of folding state). I heard at least one other 
[person](https://sourceforge.net/p/geany/feature-requests/727/) wishing this 
too. 

@elextr:
> I am not sure that being able to turn off folding is a good idea 

Unless I'm misunderstanding you: code folding enable/disable option is already 
present in Preferences; **gkatev** is only implementing option to hide the fold 
margin.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2927#issuecomment-939679393

Re: [Github-comments] [geany/geany] cannot install on windows 7, 32bit (#2923)

2021-10-11 Thread Vic
@eht16 Thanks for the reply. 

I just did some research on the market share of 32bit Windows and to date, it's 
 it's less than 1% according to 
https://www.pcbenchmarks.net/os-marketshare.html 
(Some older surveys , of 3-5 years ago put it at max 3..4% 
https://www.extremetech.com/computing/267180-nvidia-ends-support-for-32-bit-operating-systems
 , https://www.backblaze.com/blog/64-bit-os-vs-32-bit-os/ )

Based on this, I'm surprised developers still ship Windows 32bit 
applications... 

And it's only today I discovered (thanks to this issue :) ) that in fact only 
my Windows is 32bit, while my processor is 64bit 
(it can be confusing b/c in System Information / System Type it says "X86-based 
PC", and I thought that means 32bit cpu, b/c when people mention "x86 windows" 
they usually mean "32bit windows" ). 

I should install a Linux (64bit)... (If anyone has tips on which distro to 
choose, shout out!)





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2923#issuecomment-939645314

Re: [Github-comments] [geany/geany] cannot install on windows 7, 32bit (#2923)

2021-10-11 Thread Vic
Closed #2923.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2923#event-5440474212