[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)
@b4n the only one that I would question is the one that @eht16 had questioned, so I was waiting until that was decided. :-P "Data contains NULs" is referring to the result of the conversion, but the user doesn't know that, they only have the input file and it may not contain NULs, eg it might have an overlong encoding of a nul. So "Result of conversion to UTF-8 buffer contains NULs" might be better. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3716#issuecomment-2068425388 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)
@elextr requested changes on this pull request. LGBI except the ABI thing. > @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs gbooleanuse_current_file_dir; /* find in files directory to use on showing dialog */ gbooleanhide_find_dialog; /* hide the find dialog on next or previous */ gbooleanreplace_and_find_by_default;/* enter in replace window performs Replace & Find instead of Replace */ + gbooleanskip_confirmation_for_replace_in_session; /* do *not* ask for confirmation Not last == ABI break as well as API And if its moved to the end its technically not an API break either since it isn't documented for plugin use. > **``search`` group** -find_selection_type See `Find selection`_. 0 immediately -replace_and_find_by_default Set ``Replace & Find`` button as default so trueimmediately - it will be activated when the Enter key is - pressed while one of the text fields has - focus. +find_selection_type See `Find selection`_. 0immediately +replace_and_find_by_default Set ``Replace & Find`` button as default so true immediately + it will be activated when the Enter key is + pressed while one of the text fields has + focus. +skip_confirmation_for_replace_in_session If set, do *not* show the falseimmediately If it was lazy me I would have chosen a more cryptic but shorter name to avoid indenting the whole table, but since its done might as well leave it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3851#pullrequestreview-2013691773 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Well, Ubuntu LTS 20.04 has a year of support left (April 2025) and it has Meson 0.54, maybe it has to be `#ifdef`ed (or whatever the meson equivalent is) to change what it uses at 0.56 to get rid of the message. Kind of annoying that a Windows only feature causes a message on Linux, maybe the targeted version can be changed just for Windows? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068394877 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] BUG during tab-browsing with the keyboard in the sidebar when a new tab is in the sidebar (Issue #1318)
I can't reproduce the issue in Geany 2.0 in Lubuntu 23.10. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1318#issuecomment-2068219856 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] BUG during tab-browsing with the keyboard in the sidebar when a new tab is in the sidebar (Issue #1318)
Closed #1318 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1318#event-12552123490 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
didn't you have a fresh install before already? Not sure, but maybe your hardware (hard drive maybe) is faulty? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2068206133 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
Closed #3843 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#event-12552031399 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
Thank you. I have decided to take an easy way out and do fresh install. All works now. Cheers. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2068202888 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Indentation on pasting of a multiline text (Issue #3845)
> it probably also cannot be the default Agree > What if the clipboard already has indentation for the subsequent lines? > ... Good point, nice dissection of the problem. I would go with a rather simplistic algo, that IMO covers a lot of cases without trying to be too smart: ``` During pasting, if text before cursor is only whitespace then: - If every clipboard line has non-zero indentation, then strip it until any line becomes "unindented"; ignore empty lines - unless "preserve_source_indentation" is set to "yes" - then don't strip anything - Prefix every clipboard line with the current_line's indenation level ``` In pseudo code: ``` IF current_line.text_before_cursor IS whitespace THEN IF EVERY clipboard.lines STARTS_WITH whitespace THEN IF preferences.preserve_source_indentation == false THEN strip_indentation(clipboard) END IF FOREACH line IN clipboard.lines line = current_line.text_before_cursor + line END FOREACH END IF END IF ``` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3845#issuecomment-2068200842 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Fix handling of locals (PR #1294)
I did not yet plan any – maybe a point-release of Geany would be useful, too – but we should do it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1294#issuecomment-2068199943 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Fix handling of locals (PR #1294)
@frlan do you plan on making a point-release, given the above-mentioned reasons? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1294#issuecomment-2068187873 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
@b4n requested changes on this pull request.
```console
../meson.build:887: WARNING: Project targets '>= 0.53' but uses feature
introduced in '0.56.0': win_subsystem arg in executable.
[…]
WARNING: Project specifies a minimum meson_version '>= 0.53' but uses features
which were added in newer versions:
* 0.56.0: {'win_subsystem arg in executable'}
NOTICE: Future-deprecated features used:
* 0.56.0: {'meson.build_root', 'meson.source_root'}
```
So there are two ways to go I think:
* Depend on 0.56.0 (and possibly fix the deprecation warnings)
* Use
[`gui_app`](https://mesonbuild.com/Reference-manual_functions.html#executable_gui_app)
instead for a 0.53-compatible alternative (but that is deprecated in 0.56)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#pullrequestreview-2013511509
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
@eht16 This doesn't seem to have any impact on Linux, so looks fine on that end. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068186588 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
>From looking at the backtrace and the relevant GTK source code, this seems >entirely unrelated to Geany itself (apart for Geany using GTK3, that is). It >looks like either there is a bug in your `XVisualIDFromVisual()` (which could >come from a driver bug maybe?), or a bug in GTK on how it uses this API (one >interesting thing could be whether the parameter to `XVisualIDFromVisual()` is >`NULL` or invalid memory -- you could probably figure this out with debugging >information for those libraries). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2068179321 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)
@elextr Tell me if there are still strings to be updated or better error to report, I can make another follow-up :wink: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3716#issuecomment-2068175821 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Encodings UI improvements (PR #3720)
Merged #3720 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3720#event-12551819882 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)
Merged #3716 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3716#event-12551817780 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)
Merged #3163 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3163#event-12551564071 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)
@b4n commented on this pull request.
> geany_debug("Couldn't convert from %s to UTF-8.",
> charset);
+ g_set_error(error, G_CONVERT_ERROR,
G_CONVERT_ERROR_ILLEGAL_SEQUENCE,
+ _("Data contains NULs"));
Yes, if the conversion didn't fail (`conv_error == NULL`), it means the
conversion was OK, but `g_utf8_validate()` failed, which can only happen on
NULs if the data is otherwise UTF-8 (which it ought to be, unless there's a
glaring bug in `g_convert()` yielding invalid data without reporting an error).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3716#discussion_r1573864000
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)
I tested this last week and forgot to comment :). It works fine and parses the random Ocaml code I found on the net properly. Though I don't know the language at all :D. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3163#issuecomment-2068120694 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)
@masla84 if this still persists, please check Help->Debug Messages in Geany, at the beginning loading of plugins is logged and also if there any errors occurred. Alternatively, uninstall all of your Geanys, remove the config folder (or at least clean the plugin paths manually) and try again. Re-open if it still does not work. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1292#issuecomment-2068116724 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)
Closed #1292 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1292#event-12551239724 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)
A new various pref to disable the confirmation dialog is added in #3851. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3702#issuecomment-2068108109 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)
Reopened #3702. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3702#event-12551227374 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Add various pref replace in session (PR #3851)
Allow brave users to disable the confirmation dialog when replacing text in the whole session. While modifying the docs, I noticed a missing various pref in the table and added it. Because of the long names of the other and the new setting, the table grew and needed reformatting. I put this into a separate commit for easier review but we can probably squash them together afterwards. Closes #3702. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3851 -- Commit Summary -- * Add a various pref to skip replace in session confirmation dialog * Add missing various pref docs * Reformat various prefs table in docs -- File Changes -- M doc/geany.txt (264) M src/keyfile.c (2) M src/plugindata.h (2) M src/search.c (3) M src/search.h (2) -- Patch Links -- https://github.com/geany/geany/pull/3851.patch https://github.com/geany/geany/pull/3851.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3851 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)
@frlan pushed 1 commit. 6728529322b028c0e0791ba8ecec968042ac8c6d LaTeX: Switch handling of insert (list) environments over to snippets workflow -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1330/files/9313b8e02071157454e1dc7c3e816d3124cb7293..6728529322b028c0e0791ba8ecec968042ac8c6d You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)
@frlan commented on this pull request.
> if (utils_str_equal(environment, "block") == TRUE)
{
- g_string_append(tmpstring, "}{}");
+ tmpstring =
g_strdup_printf("\\begin{%s}{}\n%%cursor%%\n\\end{%s}", environment,
environment);
True. Should be better now (even though not sure about the line breaks inside
the call as it's a very long string …"
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#discussion_r1573834932
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)
Merged #3656 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#event-12551171089 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fortran function random_init not highlighted (Issue #3362)
Closed #3362 as completed via #3656. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3362#event-12551171193 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)
Closed #2088. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2088#event-12551166960 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)
@eht16 commented on this pull request.
> if (utils_str_equal(environment, "block") == TRUE)
{
- g_string_append(tmpstring, "}{}");
+ tmpstring =
g_strdup_printf("\\begin{%s}{}\n%%cursor%%\n\\end{%s}", environment,
environment);
It might be more readable using "g_strconcat" like above in
https://github.com/geany/geany-plugins/pull/1330/files#diff-44b2e13e0c1bd7750fc7aa3324ce230dd2ed0192c37d03208846a549509206bbR82?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2013463978
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)
@eht16 commented on this pull request.
Looks good.
As you know I'm not LaTeX expert and so I'm wondering if it is on purpose that
different environments produce quite different stylings:
```
\begin{block}{}
_
\end{block}
\begin{itemize}
\item _
\end{itemize}
\begin{table}
_
\end{table}
```
For "table" and "itemize" there is a trailing space after the cursor marker. Is
this intended?
"block" uses no indentation at all, "itemize" uses a tab resp. spaces and
"table" uses a single space only.
> @@ -103,6 +114,7 @@ glatex_insert_string(const gchar *string, gboolean
> reset_position)
doc = document_get_current();
+
Was this on purpose?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2013452584
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)
@techee pushed 1 commit. 1931fcc2f4d5de46871c85a782903d8c4d41e699 Export some types/functions so plugins have access to Geany symbol icons -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/6db24b8a5f6eb56d3b883ea7c1ae2f78401e4692..1931fcc2f4d5de46871c85a782903d8c4d41e699 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Complete plugin extensions patches (PR #3850)
This is the complete counterpart of #3849, including the sidebar symbol patches and also https://github.com/geany/geany/pull/3707 and https://github.com/geany/geany/pull/3572. These are all the diffs against Geany itself from https://github.com/techee/geany-lsp. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3850 -- Commit Summary -- * Add interface used by plugins to replace some Geany functionality with their own implementation * Add Geany code delegating autocompletion to plugins * Add Geany code delegating calltips to plugins * Add Geany code delegating symbol goto to plugins * Add Geany code delegating keyword highlighting to plugins * Export some types/functions so plugins have access to Geany symbol icons * Add symbols_reload_tag_list() which plugins can call to reload sidebar symbols * Replace filetype_has_tags() with document_has_tags() * Add some extra fields to TMTag * Export tm_tag_new(), tm_tag_ref() and tm_tag_unref() to plugins * Add Geany code delegating symbol tree generation to plugins * Add session-opening signal emitted when session opening starts/stops * Add document-before-save-as signal -- File Changes -- M doc/pluginsignals.c (23) M meson.build (3) M plugins/geanyplugin.h (1) M src/Makefile.am (2) M src/document.c (21) M src/document.h (2) M src/editor.c (34) M src/filetypes.c (10) M src/filetypes.h (2) M src/geanyobject.c (14) M src/geanyobject.h (2) M src/keybindings.c (13) M src/keyfile.c (4) M src/libmain.c (16) M src/main.h (2) A src/pluginextension.c (141) A src/pluginextension.h (81) M src/sidebar.c (2) M src/symbols.c (131) M src/symbols.h (5) M src/tagmanager/tm_parser.h (34) M src/tagmanager/tm_tag.c (23) M src/tagmanager/tm_tag.h (17) -- Patch Links -- https://github.com/geany/geany/pull/3850.patch https://github.com/geany/geany/pull/3850.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3850 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] [geany/geany] Plugin extensions (aka LSP API) (PR #3849)
This is my second attempt on the LSP API as originally proposed by #3571. I changed several things: 1. I renamed the struct `Lsp` to `PluginExtension` - theres nothing LSP-specific in this interface and it could be used by other plugins too (or possibly extended in the future if some plugins wanted to provide another functionality, we could extend this API). 2. I reduced the number of functions in the API to the absolute minimum and tried to do as much as possible in the plugin itself. 3. For this PR I removed the API related to the sidebar symbol tree - this one requires most changes on the Geany side and possibly more discussion and I dont want to block this PR by it. One possible alternative is also just keep using TM for the symbol tree, ignoring the symbols provided by LSP (the symbol tree is the least problematic part of TM IMO and could stay the way it is). Ill post the extra patches to allow sidebar symbols in a separate PR. I also updated the combined Geany+LSP plugin at https://github.com/techee/geany-lsp to use the new API and also to work even when compiled against unmodified Geany. This is quite clumsy, however - to avoid conflicts between Geanys TM implementation and the plugin, it requires disabling TM by adding ``` [settings] tag_parser= ``` to the filetype config file of the affected filetypes, basically disabling all TM features. It also requires separate keybindings for e.g. tag goto or autocompletion instead of re-using the Geany ones. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3849 -- Commit Summary -- * Add interface used by plugins to replace some Geany functionality with their own implementation * Add Geany code delegating autocompletion to plugins * Add Geany code delegating calltips to plugins * Add Geany code delegating symbol goto to plugins * Add Geany code delegating keyword highlighting to plugins -- File Changes -- M meson.build (3) M plugins/geanyplugin.h (1) M src/Makefile.am (2) M src/document.c (4) M src/editor.c (34) M src/keybindings.c (13) A src/pluginextension.c (141) A src/pluginextension.h (76) M src/symbols.c (11) M src/symbols.h (2) -- Patch Links -- https://github.com/geany/geany/pull/3849.patch https://github.com/geany/geany/pull/3849.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3849 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)
This MR migrates the feature to insert any environment over to Geanys snippets workflow. Hence we dont need to bother about indention, like breaks etc. this much anymore. Also due to the cursor-feature it ensures to position the cursor at the right place , independent from the line break, indention etc. Due to this rework it makes the code also a little more readable and fixes #1071 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1330 -- Commit Summary -- * LaTeX: Switch handling of insert (list) envioronment over to snippets workflow -- File Changes -- M latex/src/latexenvironments.c (58) M latex/src/latexutils.c (12) M latex/src/latexutils.h (1) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1330.patch https://github.com/geany/geany-plugins/pull/1330.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1330 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)
@eht16 sure, doesn't break anything if nobody wants to fix it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#issuecomment-2068044244 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)
I no longer use Geany so if nobody else is interested you're welcome to close. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2088#issuecomment-2068043452 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)
@StephenWassell is this still relevant or can we close this? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2088#issuecomment-2068040167 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix search entry after editing the toolbar (PR #3838)
It seems to work without the guard as well. The connect_proxy function is called four times here, but it's the same on Linux and Windows and in either way, the search toolbar item still works after re-ordering. Since we cannot reproduce this anymore and the "fix" is so long ago, maybe it was really related to some Windows-GTK2 bugginess. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3838#issuecomment-2068038479 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Help command should check browser tool's return value (Issue #3468)
Closed #3468 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3468#event-12550837837 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Encodings UI improvements (PR #3720)
Looks and works great, tested on Linux and Windows! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3720#issuecomment-2068035433 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)
@eht16 commented on this pull request.
> geany_debug("Couldn't convert from %s to UTF-8.",
> charset);
+ g_set_error(error, G_CONVERT_ERROR,
G_CONVERT_ERROR_ILLEGAL_SEQUENCE,
+ _("Data contains NULs"));
Do we always know for sure the error here is exclusively NUL bytes?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3716#pullrequestreview-2013391366
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)
There are actually some encodings which seem not support on Windows: ``` 15:31:32.356445: Geany INFO : Encoding ISO-8859-10 is not supported by the system 15:31:32.356445: Geany INFO : Encoding ISO-8859-14 is not supported by the system 15:31:32.356445: Geany INFO : Encoding ISO-8859-16 is not supported by the system 15:31:32.356445: Geany INFO : Encoding UTF-7 is not supported by the system 15:31:32.356445: Geany INFO : Encoding ARMSCII-8 is not supported by the system 15:31:32.356445: Geany INFO : Encoding EUC-TW is not supported by the system 15:31:32.356445: Geany INFO : Encoding GEORGIAN-ACADEMY is not supported by the system 15:31:32.356445: Geany INFO : Encoding HZ is not supported by the system 15:31:32.356445: Geany INFO : Encoding ISO-IR-111 is not supported by the system 15:31:32.356445: Geany INFO : Encoding TCVN is not supported by the system 15:31:32.356445: Geany INFO : Encoding TIS-620 is not supported by the system 15:31:32.356445: Geany INFO : Encoding VISCII is not supported by the syste ``` For the rest, I did some basic testing on Linux and works as expected and by inspection it looks (almost) fine. Even if there might be subtile bugs on edge cases, I would merge this in master already to get broader testing of the changes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3716#issuecomment-2068028879 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] lineoperations: Removed debug code (fixes #1322) (PR #1323)
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1323#issuecomment-2068027676 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Line Operations plugin outputs "Value: 0" to terminal when Geany launches (Issue #1322)
Closed #1322 as completed via #1323. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1322#event-12550784189 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] lineoperations: Removed debug code (fixes #1322) (PR #1323)
Merged #1323 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1323#event-12550784154 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)
Don't we want to merge this anyway? Maybe the performance impact is tolerable and then it is still an improvement for Fortran users. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#issuecomment-2068027071 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] in document.c symbols_find_typenames_as_string returns always empty string, if tag_parser=Pascal (Issue #3848)
The problem with loading all external tags into the wordlists is that the lexers only recognise syntactic elements, in this case "identifier" and not the semantics that it is a typename or a function name. Also they have no knowledge of scope and no way to pass that information to them. The lexers will select the style of an identifier as the first list it finds the name in, so in C++ for example if the standard library `set` type was loaded from global tags then the lexers would style all `set()` functions as types. And `set(...)` is a pretty common function and they would all show as types. Because of the lack of scoping this happens even if the `set` type is not visible at the point of the `set()` function call. If extra lists for function names were added the fact that the lexers do not have semantics or scope will mean identifiers (eg local variables) that happen to have the same name as a function in any loaded file or tags will be styled as a function name. Similar clashes will happen in any language with separate namespaces. There is no simple solution to this issue. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3848#issuecomment-2067960749 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] in document.c symbols_find_typenames_as_string returns always empty string, if tag_parser=Pascal (Issue #3848)
Ok, thats the cause of current behavior. But from my point of view, it should not be so. Then at least for every file type an own TM_GLOBAL_TYPE_MASK should be definable. tm_workspace.c seems to be written for C/C++ language only. I see also in other parts of source code to much focus on C and C-like languages. This should not be for a general IDE like geany wants to be. Close this issue, I'll search for a solution for my needs. As a first workaround adding of `tm_tag_function_t` to TM_GLOBAL_TYPE_MASK should work. Something else constructive: How about not to use `typedef`, but something like `tagsdef`, which holds the list of `TMParserMapGroup`s per language, which on its part holds the tags for that MapGroup-item (whatever it is defined in tm_parser.c for certain language: typedef, class, members, structs, articles, indexes, ..). Then the lexer could hold an own wordlist (and styling) for each of this MapGroup. Another attempt could be to make external tag files available for Lexers Sytax Highlighting. Prefer loading tag-file per filetype and/or tag-file per project. Then after each save of source file an external tagger could update the tag-file, which geany could recognize to update internal key lists. Ragards -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3848#issuecomment-2067949450 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] in document.c symbols_find_typenames_as_string returns always empty string, if tag_parser=Pascal (Issue #3848)
Closed #3848 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3848#event-12550086680 You are receiving this because you are subscribed to this thread. Message ID:
