date:20240428

Fine, both you and frlan prefer it so no problem, the source is only read by 
the developers, not the users.

IIRC rEsT (never remember the caPitaLization ;-) spaces list items independent 
of blank lines in the source, so should not matter.

The plugin pages in `plugins.geany.org` are made from the READMEs of the 
individual plugins.  So these get CSS and surrounding content from the process 
that generates the pages.  

So long as the ResT is valid and it looks ok in https://plugins.geany.org is 
all that matters.  But as I said, I don't know how to check that.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#issuecomment-2081845225
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

> which assumes ReST markup

I added the new lines because it was easier for me to read the text version.  I 
ran it through pandoc to preview, and saw no difference.  But with a different 
parser or added stylesheet, there could be extra space between the items.  Like 
the difference between:

```html
...

...
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#issuecomment-2081828282
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] Add ability to build with meson (PR #1345)

@xiota pushed 1 commit.

442647c436a1188e07d8c9a56264436e1c989d34  meson: fix workflow

-- 
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1345/files/a7d524b70dda93657149b90a378ce91813b1d2ac..442647c436a1188e07d8c9a56264436e1c989d34
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] Add ability to build with meson (PR #1345)

@xiota pushed 1 commit.

a7d524b70dda93657149b90a378ce91813b1d2ac  meson: fixes, update, workflow

-- 
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1345/files/6efe0f6a6c798684b90ac8b2c287f4c9803ab0c9..a7d524b70dda93657149b90a378ce91813b1d2ac
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

@xiota exact formatting for READMEs doesn't matter so long as they render ok on 
`plugins.geany.org` which assumes ReST markup IIRC but I don't know how to see 
what the new version of the page looks like.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#issuecomment-2081811919
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

@xiota commented on this pull request.



> +* Wizard to create new LaTeX documents in a fast and easy way
+  with a bunch of templates available
+
+* A front end for add labels ``\label{}`` and references ``\ref{}`` and 
+  ``\pageref{}`` with getting suggestion from aux file of document
+
+* Inserting special characters through menu
+
+* Help entering the right fields for BibTeX entries by
+  providing templates
+
+* Easy inserting format patterns like ``\texttt{}`` through menu
+
+* Support on inserting environments by offering an dialog and
+  recognising selections
+
+* Shortcuts for inserting ``\item`` and ``\newline``
+
+* Toolbar with often used format options

It was merged before I even saw this... so guess the newlines stay for now.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#discussion_r1582496945
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

Also I presume the native dialogs are themed by the platform, not by GTK 
themes, so they may look totally different to the rest of Geany.  @techee for 
Macos and whoever tests on Windows 11 need to try.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2081787625
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

@elextr approved this pull request.





-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3851#pullrequestreview-2027483976
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

Somebody who has Windows 11 and can build Geany with this needs to test as well.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2081771567
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] Wrong filename in titlebar after launch (Issue #3684)

I've bisected this to https://github.com/geany/geany/pull/3267. The original 
code contained the `switch_to_session_page()` function which emitted the 
`switch-page` signal even in the case when the right tab was already selected 
(so no real switch happened) which then lead to correct "document-activate" 
emission from `on_notebook1_switch_page_after()`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3684#issuecomment-2081667888
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-28 Thread Enrico Tröger via Github-comments

I'm curious though as I only use Linux, it won't change anything for me :D.
But I'll give it a try on Windows, this will take a few days though.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2081658681
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Enrico Tröger via Github-comments

@eht16 commented on this pull request.



> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
 GP_ARG_DISABLE([GeniusPaste], [auto])
 
 GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16

No. It breaks also the nightly builds and so I merged #1310 today to unhide 
this problem.
Unfortunately, now it is not hidden any longer.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#discussion_r1582394729
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments

@b4n pushed 1 commit.

d336856411f9b8897b62c705da5944c29205647b  Update CI for libsoup3

-- 
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1342/files/0e025a780b403c083c1d3dcfede8c42a3c26d865..d336856411f9b8897b62c705da5944c29205647b
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments

@b4n commented on this pull request.



> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
 GP_ARG_DISABLE([GeniusPaste], [auto])
 
 GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16

@eht16 Seems to work, but that hit the cppcheck issue again, do you know 
anything about that?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#discussion_r1582356142
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments

@b4n pushed 4 commits.

125fe5376e806fb26612d6af1505b639efe8f0df  geniuspaste: Port to libsoup3
bb27723f0bea02016036573524570001f1b7a443  geniuspaste: Remove use of deprecated 
GTK API
1c3ca837f59d98f1b4d26ef69a102049fe6eb391  geniuspaste: Enable HTTPS for 
paste.debian.net
0e025a780b403c083c1d3dcfede8c42a3c26d865  Update CI for libsoup3

-- 
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1342/files/7758920773f9918f1a672064434122ea674e5a79..0e025a780b403c083c1d3dcfede8c42a3c26d865
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments

@b4n pushed 1 commit.

7758920773f9918f1a672064434122ea674e5a79  Update CI for libsoup3

-- 
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1342/files/ab31775cbaa1fc401d5c7c0aa8231726d0729f4e..7758920773f9918f1a672064434122ea674e5a79
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

Merged #1343 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#event-12635676877
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

@frlan commented on this pull request.



> +* Wizard to create new LaTeX documents in a fast and easy way
+  with a bunch of templates available
+
+* A front end for add labels ``\label{}`` and references ``\ref{}`` and 
+  ``\pageref{}`` with getting suggestion from aux file of document
+
+* Inserting special characters through menu
+
+* Help entering the right fields for BibTeX entries by
+  providing templates
+
+* Easy inserting format patterns like ``\texttt{}`` through menu
+
+* Support on inserting environments by offering an dialog and
+  recognising selections
+
+* Shortcuts for inserting ``\item`` and ``\newline``
+
+* Toolbar with often used format options

Somehow it feels better to read. I'd keep it. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#discussion_r1582327245
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments

@b4n commented on this pull request.



> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
 GP_ARG_DISABLE([GeniusPaste], [auto])
 
 GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16

Indeed, trying it now -- but that also requires bumping the Ubuntu version 
because 20.04 doesn't have it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#discussion_r1582327000
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments

@b4n pushed 2 commits.

bdd4db94934400b447c8a7d5de2a7c5cd3740bf0  geniuspaste: Enable HTTPS for 
paste.debian.net
ab31775cbaa1fc401d5c7c0aa8231726d0729f4e  Update CI for libsoup3

-- 
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1342/files/4ea2725da6e3a26e8ff6fb178f3b0125f04b24bd..ab31775cbaa1fc401d5c7c0aa8231726d0729f4e
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] LaTeX plugin: Keyboard shurtcuts for itemize and enumerate generate wrong result (#1071)

Closed #1071 as completed via #1330.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1071#event-12635626369
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

Merged #1330 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#event-12635626337
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

This is an experiment to use GtkFileChooserNative on Windows and macOS to 
address issues like

https://github.com/geany/geany-osx/issues/14

where the GTK dialogs dont offer the best user experience.

I kept using GtkFileChooser on Linux because it adds extra widgets to the 
dialog like file encoding and filetype selection and these arent supported 
when using native dialogs. To me at least this isnt the most important 
thing and using native dialogs under Windows and macOS is more important IMO.

This leads to a few ifdefs in the code but Id say the result isnt too 
bad (GtkFileChooser is a GtkWidget while GtkFileChooserNative isnt so some 
things have to differ). Before continuing with the save dialog and project open 
dialog, my question is whether something like that would be acceptable for 
Geany - @b4n @eht16 what do you think?

@eht16 Do the native dialogs work correctly on Windows with this patch? It 
seems to work alright on macOS.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3861

-- Commit Summary --

  * Use GtkFileChooserNative for opening files on Windows and macOS

-- File Changes --

M src/dialogs.c (75)

-- Patch Links --

https://github.com/geany/geany/pull/3861.patch
https://github.com/geany/geany/pull/3861.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861
You are receiving this because you are subscribed to this thread.

Message ID: geany/geany/pull/3...@github.com

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

2024-04-28 Thread Colomban Wendling via Github-comments

@b4n commented on this pull request.

LGTM, indeed the ABOUTs don't seem useful, and for numberedbookmarks it's an 
old version of README including typos that have been corrected.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#pullrequestreview-2027207516
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

2024-04-28 Thread Colomban Wendling via Github-comments

@b4n commented on this pull request.



> +* Wizard to create new LaTeX documents in a fast and easy way
+  with a bunch of templates available
+
+* A front end for add labels ``\label{}`` and references ``\ref{}`` and 
+  ``\pageref{}`` with getting suggestion from aux file of document
+
+* Inserting special characters through menu
+
+* Help entering the right fields for BibTeX entries by
+  providing templates
+
+* Easy inserting format patterns like ``\texttt{}`` through menu
+
+* Support on inserting environments by offering an dialog and
+  recognising selections
+
+* Shortcuts for inserting ``\item`` and ``\newline``
+
+* Toolbar with often used format options

I'd remove blank lines between the items (but it works like that)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#pullrequestreview-2027207317
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] Cannot install (Issue #3852)

2024-04-28 Thread ineuw via Github-comments

Thanks for taking the time out to explain. It's much appreciated.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3852#issuecomment-2081579749
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

> To confirm, the first is Windows? The second macOS? Both with GIO?

Only speaking for the macOS part - yes, the second message is on macOS with GIO.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081536322
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

> `GET request failed: WinHttp error: SECURE_CHANNEL_ERROR`
>
> `Unable to perform version check: Operation not supported`

To confirm, the first is Windows?  The second macOS?  Both with GIO?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081532306
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

So I get
```
17:47:11.712578: Updatechecker MESSAGE  : Checking for updates (querying URL 
"https://geany.org/service/version/;)
17:47:14.085164: Updatechecker WARNING  : Unable to perform version check: 
Operation not supported
```
in debug messages and also the corresponding popup error :-(.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081529198
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] [geany/geany-plugins] Add ability to build with meson (PR #1345)

This PR adds ability to build with meson.  It does not attempt to duplicate 
autotools-specific functionality, like testing the presence of specific headers 
or functionality of build-system components.

All plugins build successfully with meson.  They all appear to load and unload 
correctly.  Some plugins were not tested further because I have no idea how to 
use them.  Most plugins had minimal testing, where one prominent feature 
appears to do what its supposed to.

On Ubuntu 20.04, meson selects the correct install locations (eg, 
`/usr/lib/x86_64-linux-gnu/geany/` instead of `/usr/lib/geany`).
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1345

-- Commit Summary --

  * Add ability to build with meson

-- File Changes --

A addons/makefile (1)
A addons/meson.build (45)
A addons/meson_config/config.h.in (1)
A addons/meson_config/meson.build (1)
A addons/po (1)
A autoclose/makefile (1)
A autoclose/meson.build (34)
A autoclose/meson_config/config.h.in (1)
A autoclose/meson_config/meson.build (1)
A autoclose/po (1)
A automark/makefile (1)
A automark/meson.build (34)
A automark/meson_config/config.h.in (1)
A automark/meson_config/meson.build (1)
A automark/po (1)
A codenav/makefile (1)
A codenav/meson.build (37)
A codenav/meson_config/config.h.in (1)
A codenav/meson_config/meson.build (1)
A codenav/po (1)
A commander/makefile (1)
A commander/meson.build (34)
A commander/meson_config/config.h.in (1)
A commander/meson_config/meson.build (1)
A commander/po (1)
A debugger/makefile (1)
A debugger/meson.build (84)
A debugger/meson_config/config.h.in (1)
A debugger/meson_config/meson.build (1)
A debugger/po (1)
M debugger/src/gui.c (3)
A debugger/subprojects/utils (1)
A defineformat/makefile (1)
A defineformat/meson.build (34)
A defineformat/meson_config/config.h.in (1)
A defineformat/meson_config/meson.build (1)
A defineformat/po (1)
A geanyctags/makefile (1)
A geanyctags/meson.build (35)
A geanyctags/meson_config/config.h.in (1)
A geanyctags/meson_config/meson.build (1)
A geanyctags/po (1)
A geanydoc/makefile (1)
A geanydoc/meson.build (35)
A geanydoc/meson_config/config.h.in (1)
A geanydoc/meson_config/meson.build (1)
A geanydoc/po (1)
A geanyextrasel/makefile (1)
A geanyextrasel/meson.build (34)
A geanyextrasel/meson_config/config.h.in (1)
A geanyextrasel/meson_config/meson.build (1)
A geanyextrasel/po (1)
A geanygendoc/makefile (1)
A geanygendoc/meson.build (69)
A geanygendoc/meson_config/config.h.in (1)
A geanygendoc/meson_config/meson.build (1)
A geanygendoc/po (1)
A geanyinsertnum/makefile (1)
A geanyinsertnum/meson.build (34)
A geanyinsertnum/meson_config/config.h.in (1)
A geanyinsertnum/meson_config/meson.build (1)
A geanyinsertnum/po (1)
A geanylua/makefile (1)
A geanylua/meson.build (92)
A geanylua/meson_config/config.h.in (1)
A geanylua/meson_config/meson.build (1)
A geanylua/po (1)
A geanymacro/makefile (1)
A geanymacro/meson.build (34)
A geanymacro/meson_config/config.h.in (1)
A geanymacro/meson_config/meson.build (1)
A geanymacro/po (1)
A geanyminiscript/makefile (1)
A geanyminiscript/meson.build (35)
A geanyminiscript/meson_config/config.h.in (1)
A geanyminiscript/meson_config/meson.build (1)
A geanyminiscript/po (1)
A geanynumberedbookmarks/makefile (1)
A geanynumberedbookmarks/meson.build (41)
A geanynumberedbookmarks/meson_config/config.h.in (1)
A geanynumberedbookmarks/meson_config/meson.build (1)
A geanynumberedbookmarks/po (1)
A geanynumberedbookmarks/subprojects/utils (1)
A geanypg/makefile (1)
A geanypg/meson.build (51)
A geanypg/meson_config/config.h.in (1)
A geanypg/meson_config/meson.build (1)
A geanypg/po (1)
A geanyprj/makefile (1)
A geanyprj/meson.build (42)
A geanyprj/meson_config/config.h.in (1)
A geanyprj/meson_config/meson.build (1)
A geanyprj/po (1)
A geanyvc/makefile (1)
A geanyvc/meson.build (46)
A geanyvc/meson_config/config.h.in (1)
A geanyvc/meson_config/meson.build (1)
A geanyvc/po (1)
A geniuspaste/makefile (1)
A geniuspaste/meson.build (47)
A geniuspaste/meson_config/config.h.in (1)
A geniuspaste/meson_config/meson.build (1)
A geniuspaste/po (1)
A git-changebar/makefile (1)
A git-changebar/meson.build (42)
A git-changebar/meson_config/config.h.in (1)
A git-changebar/meson_config/meson.build (1)
A git-changebar/po (1)
A keyrecord/makefile (1)
A keyrecord/meson.build (34)
A keyrecord/meson_config/config.h.in (1)
A keyrecord/meson_config/meson.build (1)
A keyrecord/po (1)
M keyrecord/src/keyrecord.c (5)
A latex/makefile (1)
A latex/meson.build (67)

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

> What do you mean, with GIO, with libsoup, with anything? If it doesn't work 
> neither on macos not Windows, it starts to feel like nobody is gonna be using 
> it 

Yeah, it was with libsoup which, when using gtk-osx for building dependencies, 
depends on gnutls:

https://gitlab.gnome.org/GNOME/gtk-osx/-/blob/master/modulesets-stable/gtk-osx-network.modules?ref_type=heads#L240

But yeah, the situation may really be different with gio because the package 
has no such dependency - I'll try.

> @techee you don't want to be shipping TLS, that should be using a system 
> library, the last thing you need is to be constantly updating as CVEs are 
> fixed against it. If it doesn't use a system library then it shouldn't be 
> available.

Probably not, but in this case when it's used only for this plugin (and I 
believe geniuspaste too), it wouldn't be so horrible even if there were some 
security issues. Both plugins connect to trusted domains, don't transfer any 
secrets, and I don't expect there are many attackers eager to pretend there's a 
new Geany release ;-).


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081520824
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] Fix CPP CMake option capitalization (PR #1344)

2024-04-28 Thread Enrico Tröger via Github-comments

Merged #1344 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1344#event-12635099051
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] [geany/geany-plugins] Fix CPP CMake option capitalization (PR #1344)

2024-04-28 Thread Enrico Tröger via Github-comments


You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1344

-- Commit Summary --

  * Fix CPP CMake option capitalization

-- File Changes --

M .github/workflows/build.yml (2)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1344.patch
https://github.com/geany/geany-plugins/pull/1344.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1344
You are receiving this because you are subscribed to this thread.

Message ID: geany/geany-plugins/pull/1...@github.com

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

@techee you don't want to be shipping TLS, that should be using a system 
library, the last thing you need is to be constantly updating as CVEs are fixed 
against it.  If it doesn't use a system library then it shouldn't be available.

> nobody is gonna be using it 

Its wrong on Linux, doesn't work on Windows (except maybe on new versions that 
the team can't support), and doesn't work on Macos. Yay :tada: we can drop it 
:smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081503877
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Enrico Tröger via Github-comments

> > I "think" it will work.
> > In detail this is, when querying https://geany.org/ I get an error: `GET 
> > request failed: WinHttp error: SECURE_CHANNEL_ERROR`. […]
> > If I change the URL to query to https://httpbin.org/anything/version, the 
> > HTTP request works fine and I get the expected response.
> > So it probably works provided one uses an up to date operating system.
> 
> OK, might be either TLS versions or certificates not installed I guess. Does 
> the libsoup version work any better? (I doubt it, but who knows)

I cannot say for sure, with the libsoup version I get a different error 
message. Might be the same reason though.

Even if we are not sure whether it runs on Windows and we know it does not work 
on MacOS, there is still another use case for this plugin we tend to forget 
about:
Linux users who install Geany from sources and not via the distro package 
manager. I don't know if there are any and if so how many and I won't make any 
attempts to analyse any log files. But we should keep this in mind before 
dropping the plugin.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081503771
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

WFM.

> if the software draws the string colors AFTER scalar and identifier_1 color, 
> these colors are ovewritten by string color, and that seems to be the deep 
> problem.

No it doesn't work like that.  What version of Geany are you using?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081500923
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Sergio Abreu A. via Github-comments

if the software prints the **string colors** AFTER  **scalar and identifier_1** 
color, these colors are ovewritten by string color, and that seems to be the 
deep problem.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081494130
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Sergio Abreu A. via Github-comments

Have done that, opened via Tools, replaced all the file content with the 
configs you suggested and still not working.
I closed geany, reopened, and even think that **bash** is taken by geany as 
**sh** too ?


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081493138
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] CI: Download, compile and use latest cppcheck version (PR #1310)

2024-04-28 Thread Enrico Tröger via Github-comments

Merged #1310 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1310#event-12634889055
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-28 Thread Enrico Tröger via Github-comments

@eht16 approved this pull request.





-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2027099072
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Colomban Wendling via Github-comments

> The bad news is that it doesn't work too.
> I have added it, closed geany, reopen and all is the same.


WFM, looks like that:

Default:
![default](https://github.com/geany/geany/assets/793526/73d4a2cd-639d-46bf-8ff9-dd28c7e37a32)

Adding `lexer.bash.styling.inside.string=1`
![strings](https://github.com/geany/geany/assets/793526/4e5ffde0-6a55-43bf-9376-da839dc8f379)

Adding `lexer.bash.styling.inside.backticks=1`
![backticks](https://github.com/geany/geany/assets/793526/dbab43a5-d112-4659-86c4-49578805f835)

Adding `lexer.bash.styling.inside.heredoc=1`
![heredoc](https://github.com/geany/geany/assets/793526/7e0ffa47-bb6a-4447-bafa-35f5ab7af380)


> One question: what is the correct: altering via Geany Tools, ... or editing 
> directly in the file /usr/share/geany/file...
Because opening in Tools, all lines appear commented and is is different from 
the same file in /usr/share/geany/file...
What is actually used ?

Both are used together.  If something is not defined in the user's 
configuration, the value is looked up in the /usr/share one (or whatever the 
Geany installation path is).

All you need to do is go through Tools… and replace the whole content with 
literally what I mentioned above.  Or add it (uncommented) somewhere.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081489596
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Colomban Wendling via Github-comments

> I "think" it will work.
> In detail this is, when querying https://geany.org/ I get an error: `GET 
> request failed: WinHttp error: SECURE_CHANNEL_ERROR`. […]
>
> If I change the URL to query to https://httpbin.org/anything/version, the 
> HTTP request works fine and I get the expected response.
>
> So it probably works provided one uses an up to date operating system.

OK, might be either TLS versions or certificates not installed I guess.
Does the libsoup version work any better? (I doubt it, but who knows)

> The thing is that I didn't even manage to get tls running correctly (it 
> compiled but https didn't work afterwards, probably some configuration issue) 
> so the updatechecker plugin isn't part of the macOS release.

What do you mean, with GIO, with libsoup, with anything?  If it doesn't work 
neither on macos not Windows, it starts to feel like nobody is gonna be using 
it :laughing: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081484303
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Sergio Abreu A. via Github-comments

One question: what is the correct: altering via Geany Tools,  ... or editing 
directly in the file /usr/share/geany/file...
Because opening in Tools, **all lines appear commented** and is is different 
from the same file in /usr/share/geany/file...
What is actually used ? 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081483028
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Sergio Abreu A. via Github-comments

The bad news is that it doesn't work too.
I have added it, closed geany, reopen and all is the same.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081480908
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Colomban Wendling via Github-comments

Try adding this in *filetypes.sh* (you can open it from *Tools → Configuration 
files → Filetypes configuration files → Scripting languages*):
```ini
[lexer_properties]
lexer.bash.styling.inside.string=1
lexer.bash.styling.inside.backticks=1
lexer.bash.styling.inside.parameter=1
lexer.bash.styling.inside.heredoc=1
```

We probably should use all or some by default, we'd just need to check what 
defaults make more sense, and what the limitations might be.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081476762
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-04-28 Thread Enrico Tröger via Github-comments

@eht16 commented on this pull request.



> @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs
gbooleanuse_current_file_dir;   /* find in files directory to 
use on showing dialog */
gbooleanhide_find_dialog;   /* hide the find dialog 
on next or previous */
gbooleanreplace_and_find_by_default;/* enter in replace 
window performs Replace & Find instead of Replace */
+   gbooleanskip_confirmation_for_replace_in_session;   /* do 
*not* ask for confirmation

Ok, I reverted the API version bump.

I was referring to that the new field is technically part of the plugin API as 
I can access and use it from a plugin, no matter whether it is doxgened.
Anyway, using the documented API as source is also fine.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3851#discussion_r1582151054
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

In the end it's a little matter of taste, but compare it to HTML's
```html

  ...

```
and 
```html

…


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#issuecomment-2081475695
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-04-28 Thread Enrico Tröger via Github-comments

@eht16 pushed 1 commit.

bb15a702a9a0ae9eb4e2f805e391f30c6a9f06ad  fixup: do not increase plugin API 
version

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3851/files/c0cd092a49a3162f57691099f115fc2689515774..bb15a702a9a0ae9eb4e2f805e391f30c6a9f06ad
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-28 Thread Enrico Tröger via Github-comments

Looks good now.

As said before, I cannot judge whether the result of the snippets is as 
desired. To me it feels a little confusing that the element in the "itemize" 
environment is indented while for the other ones the cursor position is not 
indented.
Maybe it's ok.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#issuecomment-2081474610
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Enrico Tröger via Github-comments

@eht16 commented on this pull request.



> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
 GP_ARG_DISABLE([GeniusPaste], [auto])
 
 GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16

We also need to adjust the CI workflow config to install libsoup3. Currently 
the plugin will not be built in the CI due to the missing dependency.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#pullrequestreview-2027082303
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Sergio Abreu A. via Github-comments

PHP uses "preprocessor" color for the dollar variables, not identifier_1 ( that 
sh/bash uses )

**The question is:**  Why geany can draw php dollar variables interpolated in 
string correctly, but not for shellscript ?



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081471225
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Enrico Tröger via Github-comments

> Guys, be a bit patient :D. I'll test this on Windows/MSYS2 later or in the 
> next days.

I "think" it will work.
In detail this is, when querying https://geany.org I get an error: `GET request 
failed: WinHttp error: SECURE_CHANNEL_ERROR`. But I guess this is not related 
to the changes but rather to the combination of how GIO handles TLS, the 
outdated Windows 7 I'm using and the fact that geany.org offers only TLS 1.2 or 
newer. This doesn't seem to be too good for Windows 7.

If I change the URL to query to https://httpbin.org/anything/version, the HTTP 
request works fine and I get the expected response.

So it probably works provided one uses an up to date operating system.
If anyone has access to a Windows 10/11 system, the artifacts of the CI build 
https://github.com/geany/geany-plugins/actions/runs/8850165013 contain the 
Geany and G-P installers for easy testing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081471114
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

@b4n Thanks for having a look at it - I'll address the changes you suggested.

> Apart from that, I was kind of disappointed that the "goto file" only lists 
> Geany open documents rather than the project's documents -- maybe you'd like 
> to add that?

Definitely makes sense for projectorganizer which knows what files belong to 
the project. So yes, I should add that. This isn't possible in the LSP plugin 
from which this feature was taken because the plugin itself doesn't know what 
files belong to the project (this is only known to the server).

Maybe I could also re-introduce the fuzzy search you use in the Commander 
plugin so one doesn't have to type the searched query exactly. In the LSP 
plugin it didn't make sense for the workspace symbols where the server did 
something like that already but e.g. for file names or file's symbols it could 
be useful (still we probably shouldn't use it for workspace symbols because 
there's way too many of them and filtering them could take too long because of 
this).

> Also, I hoped to be able to go to a specific file's line, not only in the 
> current file -- but that's probably less useful in practice.

Probably not hard to add something like `filename.c:123`, I'm just sure I'd be 
too lazy to type something like that :-). But maybe e.g. the right arrow could 
complete the value in the search entry to the selected value in the list so one 
could then just type `:123`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1341#issuecomment-2081470646
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

> @techee any chance you could check whether gvfs works with HTTP(S) under 
> macos?

The thing is that I didn't even manage to get tls running correctly (it 
compiled but https didn't work afterwards, probably some configuration issue) 
so the updatechecker plugin isn't part of the macOS release.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081450638
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Sergio Abreu A. via Github-comments

An important observation:

For single quoted string 'Single quoted string kills $dollar $vars' it is OK as 
they kill dollar variables. In this case, the string color is used. 

But double quotes "Double quotation keeps the $dollar $variables" they should 
be colored as identifier_1 as geany does outside the string. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081436296
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Sergio Abreu A. via Github-comments

I thank the lexer.bash.styling.inside.string information. How to set it ?
If Geany color application followed a simple rule, it would NOT depend on
language neither of this config.
The algorithm now paits string after the identifier_1 color with is for dollar
variables.
If just the identifier_1 color were applyed ALWAYS to all dollar variables
wherever they are, and AFTER strings where colored, the result would be
correct, becase identifier_1 (dollar variables) are more important to have a
different color than a string.

In php vim does equal geany, treating all as **keyword** color, **not** uses
identifier_1 config. But in shell, it is different.

The problem in shell is that before a variable is "dollared" (identifier_1) it
was a simple identifier, without dollar.
And identifier color is default, but you can set identifier_1 to be magenta in
a green string as I do.

# Shell, bash, sh syntax:

variable="value"#here has no dollar, geany reads variable as a
simple **identifier** NOT **identifier_1**
echo $variable #after the value, it is **identifier_1**, magenta in
my case.

echo "a string with $variable"
# Geany do not priorize **identifier_1** that was correct in the 2nd
line above, painting green (string):

![ashel](https://github.com/geany/geany/assets/34313003/2918b314-5e7b-4f65-b964-02e8cb3f631b)
![aphp](https://github.com/geany/geany/assets/34313003/3b0b5aa6-f020-4cba-9ad6-ad0bfe427296)

See the sh correct syntax (identifier_1 priority) done by vim:
![ashell2](https://github.com/geany/geany/assets/34313003/b95d4565-2642-4995-a6fb-a95b4c5d3a37)

--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081411458
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Sergio Abreu A. via Github-comments

I use vim and it always color the identifier with a different color. It
does not matter if is shell script or php.
If geany draws identifier_1 nicely out of the string and do not when the
dollar variable is interpolated in a string it is geany weakness and I
could myself show how to fix it

Em dom, 28 de abr de 2024 04:47, Colomban Wendling ***@***.***>
escreveu:

> That's not how things work here, the identifier id either recognized as
> such anf given a separate style (which we might or might not draw the same
> as a string), or it's not recognized and thus is considered a string.
>
> Which language do you have issue with?
>
> —
> Reply to this email directly, view it on GitHub
> , or
> unsubscribe
> 
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3860#issuecomment-2081399940
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

> you never know what the future of the web holds

Yeah, its just a fad :grin:

> A new feature maybe, but well.

But the G* guys would never break API without a new major version 

Anyway as you say, there are prototypes for all four plugins available, so if 
we are not gonna kill any off then they can continue to limp along, just needs 
to decision about this one using soup or gio.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081388235
You are receiving this because you are subscribed to this thread.

Message ID:

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)