Re: [Gluster-devel] Change #18681 has broken build on master

2017-11-08 Thread Nigel Babu 
I can try to explain what happened. For instance, here's a git tree. Each
alphabet represents a commit.

A -> B -> C -> D -> E -> F (F is the HEAD of master. green builds)

Change X branched off at B
A -> B -> X (green builds)

Change Y branched off at D
A -> B -> C -> D -> Y (green builds)

Now if change X and Y do not work together, for instance, if change X
introduced a new parameter for a function. They also do not conflict with
each other. First change Y lands.

So history now looks like this:

A -> B -> C -> D -> E -> F -> Y (green builds)

Now change X lands:

A -> B -> C -> D -> E -> F -> Y -> Z (red builds)

Because change Z touched a function whose signature had changed in change
Y. If this doesn't make sense, please have a look at this:
https://docs.openstack.org/infra/zuul/user/gating.html

Using a gating system is the most likely solution to our problem. Right
now, adding a gating solution without reducing how much time our tests take
is pointless.


-- 
nigelb
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Change #18681 has broken build on master

2017-11-07 Thread Raghavendra G 
On Tue, Nov 7, 2017 at 5:32 PM, Nigel Babu  wrote:

> Landed:https://github.com/gluster/glusterfs/commit/
> c3d7974e2be68f0fac8f54c9557d0f868e6be6c8
>
> Please rebase your patches and re-trigger.
>

Thanks Nigel. I am wondering how did the build for #18681 succeed? Any
insights on this?


> On Tue, Nov 7, 2017 at 5:23 PM, Nigel Babu  wrote:
>
>> Rafi has a fix[1]. I'm going to make it skip regressions and land it
>> directly.
>>
>> https://review.gluster.org/#/c/18680/
>>
>> On Tue, Nov 7, 2017 at 4:42 PM, Raghavendra Gowdappa > > wrote:
>>
>>> Please check [1].
>>>
>>> Build on master branch on my laptop failed too:
>>>
>>> [raghu@unused server]$ make > /dev/null
>>> server.c: In function 'init':
>>> server.c:1205:9: error: too few arguments to function
>>> 'rpcsvc_program_register'
>>> In file included from server.h:17:0,
>>>  from server.c:16:
>>> ../../../../rpc/rpc-lib/src/rpcsvc.h:426:1: note: declared here
>>> make[1]: *** [server.lo] Error 1
>>> make: *** [all-recursive] Error 1
>>>
>>> The change was introduced by [2]. However, the puzzling thing is [2]
>>> itself was built successfully and has passed all tests. Wondering how did
>>> that happen.
>>>
>>> [1] https://build.gluster.org/job/centos6-regression/7281/console
>>> [2] review.gluster.org/18681
>>>
>>> regards,
>>> Raghavendra
>>>
>>
>>
>>
>> --
>> nigelb
>>
>
>
>
> --
> nigelb
>
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Raghavendra G
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Change #18681 has broken build on master

2017-11-07 Thread Raghavendra Gowdappa 
Please check [1].

Build on master branch on my laptop failed too:

[raghu@unused server]$ make > /dev/null
server.c: In function 'init':
server.c:1205:9: error: too few arguments to function 'rpcsvc_program_register'
In file included from server.h:17:0,
 from server.c:16:
../../../../rpc/rpc-lib/src/rpcsvc.h:426:1: note: declared here
make[1]: *** [server.lo] Error 1
make: *** [all-recursive] Error 1

The change was introduced by [2]. However, the puzzling thing is [2] itself was 
built successfully and has passed all tests. Wondering how did that happen.

[1] https://build.gluster.org/job/centos6-regression/7281/console
[2] review.gluster.org/18681

regards,
Raghavendra
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Change #18681 has broken build on master

2017-11-07 Thread Nigel Babu 
Landed:
https://github.com/gluster/glusterfs/commit/c3d7974e2be68f0fac8f54c9557d0f868e6be6c8

Please rebase your patches and re-trigger.

On Tue, Nov 7, 2017 at 5:23 PM, Nigel Babu  wrote:

> Rafi has a fix[1]. I'm going to make it skip regressions and land it
> directly.
>
> https://review.gluster.org/#/c/18680/
>
> On Tue, Nov 7, 2017 at 4:42 PM, Raghavendra Gowdappa 
> wrote:
>
>> Please check [1].
>>
>> Build on master branch on my laptop failed too:
>>
>> [raghu@unused server]$ make > /dev/null
>> server.c: In function 'init':
>> server.c:1205:9: error: too few arguments to function
>> 'rpcsvc_program_register'
>> In file included from server.h:17:0,
>>  from server.c:16:
>> ../../../../rpc/rpc-lib/src/rpcsvc.h:426:1: note: declared here
>> make[1]: *** [server.lo] Error 1
>> make: *** [all-recursive] Error 1
>>
>> The change was introduced by [2]. However, the puzzling thing is [2]
>> itself was built successfully and has passed all tests. Wondering how did
>> that happen.
>>
>> [1] https://build.gluster.org/job/centos6-regression/7281/console
>> [2] review.gluster.org/18681
>>
>> regards,
>> Raghavendra
>>
>
>
>
> --
> nigelb
>



-- 
nigelb
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Change #18681 has broken build on master

2017-11-07 Thread Nigel Babu 
Rafi has a fix[1]. I'm going to make it skip regressions and land it
directly.

https://review.gluster.org/#/c/18680/

On Tue, Nov 7, 2017 at 4:42 PM, Raghavendra Gowdappa 
wrote:

> Please check [1].
>
> Build on master branch on my laptop failed too:
>
> [raghu@unused server]$ make > /dev/null
> server.c: In function 'init':
> server.c:1205:9: error: too few arguments to function
> 'rpcsvc_program_register'
> In file included from server.h:17:0,
>  from server.c:16:
> ../../../../rpc/rpc-lib/src/rpcsvc.h:426:1: note: declared here
> make[1]: *** [server.lo] Error 1
> make: *** [all-recursive] Error 1
>
> The change was introduced by [2]. However, the puzzling thing is [2]
> itself was built successfully and has passed all tests. Wondering how did
> that happen.
>
> [1] https://build.gluster.org/job/centos6-regression/7281/console
> [2] review.gluster.org/18681
>
> regards,
> Raghavendra
>



-- 
nigelb
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel