Re: Super dev mode - sourcemap not working anymore
Hi Thomas, thanks for your answer. Yes of course I did ! Tried this on several PCs even. I didnt install any new plugins to chrome either or what ever... Basicaly I didnt change anything since last time when Source maps worked. Now if I run my SDM I dont see any sources (even with CTRL+O shurtcut ). My chrome is in 26.0.1410.64 m and GWT 2.5.1. Thanks for your help -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CSS
Hm a bit more details would be nice. What is complicated on using
ClientBundle? What code does it replicate?
Whats wrong with:
ExampleWidget.gwt.xml:
ui:with field=common type=my.app.client.resources.CommonClientBundle/
ui:style
/* specific rules for ExampleWidget, could also be externalized into a
separate css file */
.myWidget {
padding:5px;
}
.content {
background-color:grey;
margin-left:5px;
}
/ui:style
g:HTMLPanel addStyleNames={style.myWidget}
g:Image resource={common.addIcon}/g:Image
div class={style.content}
I am some a href=#content/a
/div
/g:HTMLPanel
If you tell your junior developers Put widget specific css into an inline
style (or widget specific css file) and take common things from the common
ClientBundle whats hard to explain then? Also overriding CSS style on
general HTML elements inside an UiBinder widget should pretty much always
happen in the context of that widget so you dont mess up anything else:
ui:style
/* bad as it can globally override existing a CSS rules */
a:link {
color:red;
}
/* better */
.myWidget a:link {
color:red;
}
/ui:style
-- J.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: CSS
Inline style in each UiBinder xml file will not be maintainable.
From a code maintenance perspective stylesheets should be used extensively.
The suggested solution for this is to include the css as part of the
ClientBundle as a resource.
This suggested solution is predicated on the following assumptions:
-- a single CSS file (yes you can have multiple files, but this is MX
nightmare. Which variable.
-- User does not have the ability to change/select alternate CSS files
-- Prevents the application from being re-labeled by an OEM SaaS unless you
also provide source code
-- Now you have to maintain and keep in sync three separate items. Class name
in CSS, Variable Names in CssResource file, declarations in UiBinder XML File
Now explain all the linkages to a junior developer who needs to change one
minor thing in a complex app.
Tim
On May 16, 2013, at 4:35 AM, Jens wrote:
Hm a bit more details would be nice. What is complicated on using
ClientBundle? What code does it replicate?
Whats wrong with:
ExampleWidget.gwt.xml:
ui:with field=common type=my.app.client.resources.CommonClientBundle/
ui:style
/* specific rules for ExampleWidget, could also be externalized into a
separate css file */
.myWidget {
padding:5px;
}
.content {
background-color:grey;
margin-left:5px;
}
/ui:style
g:HTMLPanel addStyleNames={style.myWidget}
g:Image resource={common.addIcon}/g:Image
div class={style.content}
I am some a href=#content/a
/div
/g:HTMLPanel
If you tell your junior developers Put widget specific css into an inline
style (or widget specific css file) and take common things from the common
ClientBundle whats hard to explain then? Also overriding CSS style on
general HTML elements inside an UiBinder widget should pretty much always
happen in the context of that widget so you dont mess up anything else:
ui:style
/* bad as it can globally override existing a CSS rules */
a:link {
color:red;
}
/* better */
.myWidget a:link {
color:red;
}
/ui:style
-- J.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an
email to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: How can I integrate things like the twitter 'tweet button'?
On Thursday, May 16, 2013 10:38:51 AM UTC+2, Mohammad Al-Quraian wrote: Well everything seems fine if I injected the script after the anchor is created. The problem now is that the tweets counts are always equal for different urls, and I believe that maybe due to the twitter doesn't consider example.com/#1 different than example.com/#2. Do you know how can I fix that? Ask Twitter :-) (or use pustState to have example.com/1 and example.com/2 as URLs, but you'll have to think about IE9- users then…) On Wed, May 15, 2013 at 3:26 PM, Thomas Broyer t.br...@gmail.comjavascript: wrote: On Wednesday, May 15, 2013 11:18:48 AM UTC+2, Mohammad Al-Quraian wrote: Hi Thomas, The ScriptInjector only works 1% of the times, however this: Document doc = Document.get(); ScriptElement script = doc.createScriptElement(); script.setSrc(http://**platform.twitter.com/widgets.**js http://platform.twitter.com/widgets.js); script.setType(text/**javascript); script.setLang(javascript); doc.getBody().appendChild(scri**pt); works 100%, do you have any idea why? You mean ```java ScriptInjector.fromUrl(http://platform.twitter.com/widgets.js;) .setWindow(ScriptInjector.TOP_WINDOW) .inject(); ``` ? or the one I gave earlier in this thread? -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/TjN9oGZlLag/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com javascript:. To post to this group, send email to google-we...@googlegroups.comjavascript: . Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CSS
On Thursday, May 16, 2013 10:44:33 AM UTC+2, Timothy Spear wrote: Inline style in each UiBinder xml file will not be maintainable. From a code maintenance perspective stylesheets should be used extensively. I find it much better for maintainability if the styles for a given widget is close to that widget, and there's nothing closer than in the same file. Let's just agree that we disagree on this point. The suggested solution for this is to include the css as part of the ClientBundle as a resource. This suggested solution is predicated on the following assumptions: -- a single CSS file (yes you can have multiple files, but this is MX nightmare. Which variable. -- User does not have the ability to change/select alternate CSS files -- Prevents the application from being re-labeled by an OEM SaaS unless you also provide source code -- Now you have to maintain and keep in sync three separate items. Class name in CSS, Variable Names in CssResource file, declarations in UiBinder XML File Now explain all the linkages to a junior developer who needs to change one minor thing in a complex app. Nothing prevents you from using plain old CSS: link to the stylesheet from your HTML host page (and use SASS/LESS/whatever if you like) and use your class names in your UiBinder. That's the only way to have swappable/updatable styles without handing out the source code; and it's not different than how you'd do it if you were using a pure-JS framework. GWT doesn't make anything more complicated here. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CSS
Inline style in each UiBinder xml file will not be maintainable. From a code maintenance perspective stylesheets should be used extensively. Its not maintainable by designers if they quickly want to see changes because they would need to recompile the application. Super Dev Mode helps here a bit but is definitely a different workflow for designers. But if your developers maintain the CSS itself it works pretty well because you dont have to search the CSS...its just there. -- User does not have the ability to change/select alternate CSS files -- Prevents the application from being re-labeled by an OEM SaaS unless you also provide source code These two points alone nearly rule out ClientBundle if you do not want to expose your source code and/or you dont develop the new re-labeled theme for a client in-house. For these two use cases its probably the a good solution to just put all CSS into your database, provide a suitable edit widget for your customers, and make your host html page a dynamic page (e.g. jsp) so you can embed the customers CSS dynamically. -- Now you have to maintain and keep in sync three separate items. Class name in CSS, Variable Names in CssResource file, declarations in UiBinder XML File In general GPE / IntelliJ tells you that something is not in sync. So for a SaaS that should support themes defined by customers I would not use ClientBundle, because ClientBundle means that a change inside the bundle needs a recompile of your app. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: hash fragment gets dropped when some special characters are present (period, slash...)
found the reason, the nocache.js script tag was before the history iframe.
regards,
Milan
On Wednesday, May 15, 2013 11:33:44 AM UTC+2, milan wrote:
I'm getting some weird behavior with ActivitiesPlaces (GWT 2.4.0 and
2.5.1), in FF 20/21/Chrome/Safari 6, both prod and dev mode.
Here's an example:
with @Prefix(!contact) these two urls work just fine ('contact' place,
token first empty then 'department'):
http://127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!contact:
http://127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!contact:department
but when I try to open:
http://127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!contact:department/1
the url gets rewritten to:
http://127.0.0.1:/!contact:department/1
and the app goes to the default place (historyToken is empty) and there's
a 404 because !contact doesn't exist. Debugging this I get to
c.g.g.user.client.impl.HistoryImpl.java#133 newItem() that is called with
an empty historyToken so this happens before any tokenizers get called.
The same happens when token contains period/dot (.) or question mark.
Anyone seen this before?
It's been known this can happen because of 3xx
redirectshttp://blogs.msdn.com/b/ieinternals/archive/2011/05/17/url-fragments-and-redirects-anchor-hash-missing.aspx,
but this is not the case here (then all fragments would be dropped). To be
sure this is not the case, I tried this with a redirect: a simple filter to
remove index.html so that
127.0.0.1:/index.html?gwt.codesvr=127.0.0.1:9997#!downloads: gets
redirected to 127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!downloads: and
it works correctly. Inspecting HTTP requests under the hood also doesn't
show any 3xx responses when hash gets dropped.
Could this be a bug?
regards,
Milan
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: hash fragment gets dropped when some special characters are present (period, slash...)
On Thursday, May 16, 2013 1:02:19 PM UTC+2, milan wrote:
found the reason, the nocache.js script tag was before the history iframe.
This is really strange!
…as the iframe is only used by IE6/7, and you were reporting issues in
Firefox, Chrome and Safari.
regards,
Milan
On Wednesday, May 15, 2013 11:33:44 AM UTC+2, milan wrote:
I'm getting some weird behavior with ActivitiesPlaces (GWT 2.4.0 and
2.5.1), in FF 20/21/Chrome/Safari 6, both prod and dev mode.
Here's an example:
with @Prefix(!contact) these two urls work just fine ('contact' place,
token first empty then 'department'):
http://127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!contact:
http://127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!contact:department
but when I try to open:
http://127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!contact:department/1
the url gets rewritten to:
http://127.0.0.1:/!contact:department/1
and the app goes to the default place (historyToken is empty) and there's
a 404 because !contact doesn't exist. Debugging this I get to
c.g.g.user.client.impl.HistoryImpl.java#133 newItem() that is called
with an empty historyToken so this happens before any tokenizers get
called. The same happens when token contains period/dot (.) or question
mark. Anyone seen this before?
It's been known this can happen because of 3xx
redirectshttp://blogs.msdn.com/b/ieinternals/archive/2011/05/17/url-fragments-and-redirects-anchor-hash-missing.aspx,
but this is not the case here (then all fragments would be dropped). To be
sure this is not the case, I tried this with a redirect: a simple filter to
remove index.html so that
127.0.0.1:/index.html?gwt.codesvr=127.0.0.1:9997#!downloads: gets
redirected to 127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!downloads: and
it works correctly. Inspecting HTTP requests under the hood also doesn't
show any 3xx responses when hash gets dropped.
Could this be a bug?
regards,
Milan
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: CSS
Thomas, If the style only applies to the one widget I would agree. But I have a very small mind and only have room in my head for things to look one way; even when on the user admin pages, group admin pages, work queue, work item :D I actually ended back there (I actually link the stylesheets to index.jsp; required for certificate based authentication, dynamic application name from a config file and a few other pieces) . It is not the recommended/suggested solution. My question is what am am I missing? Tim On May 16, 2013, at 5:00 AM, Thomas Broyer wrote: On Thursday, May 16, 2013 10:44:33 AM UTC+2, Timothy Spear wrote: Inline style in each UiBinder xml file will not be maintainable. From a code maintenance perspective stylesheets should be used extensively. I find it much better for maintainability if the styles for a given widget is close to that widget, and there's nothing closer than in the same file. Let's just agree that we disagree on this point. The suggested solution for this is to include the css as part of the ClientBundle as a resource. This suggested solution is predicated on the following assumptions: -- a single CSS file (yes you can have multiple files, but this is MX nightmare. Which variable. -- User does not have the ability to change/select alternate CSS files -- Prevents the application from being re-labeled by an OEM SaaS unless you also provide source code -- Now you have to maintain and keep in sync three separate items. Class name in CSS, Variable Names in CssResource file, declarations in UiBinder XML File Now explain all the linkages to a junior developer who needs to change one minor thing in a complex app. Nothing prevents you from using plain old CSS: link to the stylesheet from your HTML host page (and use SASS/LESS/whatever if you like) and use your class names in your UiBinder. That's the only way to have swappable/updatable styles without handing out the source code; and it's not different than how you'd do it if you were using a pure-JS framework. GWT doesn't make anything more complicated here. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CSS
On Thursday, May 16, 2013 1:55:25 PM UTC+2, Timothy Spear wrote: Thomas, If the style only applies to the one widget I would agree. But I have a very small mind and only have room in my head for things to look one way; even when on the user admin pages, group admin pages, work queue, work item :D I actually ended back there (I actually link the stylesheets to index.jsp; required for certificate based authentication, dynamic application name from a config file and a few other pieces) . It is not the recommended/suggested solution. How is it not the recommended/suggested solution? This is how themes work. It is true that new widgets are however moving away from themes and leverage ClientBundle, because more people are in a situation were they can get all the benefits of ClientBundle, than in your situation with switchable/customizable themes. The common case are apps that are themed/styled at dev time, not at runtime; you are in an exceptional case, so you have to think about it that way and ignore the things that don't fit your particular needs. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CSS
Hi,
You don;t need to use just one CssResource. I use one per widget type. This
makes it really easy to restyle and to manage.
I also make sure that my custom widgets allow for a CssResource or even a
ClientBundle as parameter so that you can define your own styles.
What I do not like right now about CssResources is that you need to
maintain the .css file separately. Why not use some similar trick as used
in JSNI code, allow us to inline the actual style. Also when I want to
share colors and other constants between widgets it is also a bit more
difficult and I end up exposing those internals to the CssResource since I
need to subclass a base css that contains the generics AND I must make sure
that I also point to the base.css file through annotations.
Inheritance is tricky as well, it would have made more sense to me that we
could override css attributes though CssResource inheritance and not
through the standards CSS cascade.
For example I could have a base button.css where I set something like
background-color:blue and then subclass and redeclare the
background-color:green. This does not work, so now I have to use yet
another css file where everything except the background-color is set and
then put the color specific in another css file and make sure that I put
both in the @Source annotation. I know it makes sense in CSS but in OO it
does not make sense - if you subclass a CssResource you expect the
inhertiance on styles to happen the same way.
David
On Thu, May 16, 2013 at 10:44 AM, Spear Timothy n61...@gmail.com wrote:
Inline style in each UiBinder xml file will not be maintainable.
From a code maintenance perspective stylesheets should be used extensively.
The suggested solution for this is to include the css as part of the
ClientBundle as a resource.
This suggested solution is predicated on the following assumptions:
-- a single CSS file (yes you can have multiple files, but this is MX
nightmare. Which variable.
-- User does not have the ability to change/select alternate CSS files
-- Prevents the application from being re-labeled by an OEM SaaS unless
you also provide source code
-- Now you have to maintain and keep in sync three separate items. Class
name in CSS, Variable Names in CssResource file, declarations in UiBinder
XML File
Now explain all the linkages to a junior developer who needs to change one
minor thing in a complex app.
Tim
On May 16, 2013, at 4:35 AM, Jens wrote:
Hm a bit more details would be nice. What is complicated on using
ClientBundle? What code does it replicate?
Whats wrong with:
ExampleWidget.gwt.xml:
ui:with field=common
type=my.app.client.resources.CommonClientBundle/
ui:style
/* specific rules for ExampleWidget, could also be externalized into a
separate css file */
.myWidget {
padding:5px;
}
.content {
background-color:grey;
margin-left:5px;
}
/ui:style
g:HTMLPanel addStyleNames={style.myWidget}
g:Image resource={common.addIcon}/g:Image
div class={style.content}
I am some a href=#content/a
/div
/g:HTMLPanel
If you tell your junior developers Put widget specific css into an
inline
style (or widget specific css file) and take common things from the
common
ClientBundle whats hard to explain then? Also overriding CSS style on
general HTML elements inside an UiBinder widget should pretty much always
happen in the context of that widget so you dont mess up anything else:
ui:style
/* bad as it can globally override existing a CSS rules */
a:link {
color:red;
}
/* better */
.myWidget a:link {
color:red;
}
/ui:style
-- J.
--
You received this message because you are subscribed to the Google
Groups Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send
an email to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com
.
Visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an
email to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at
Re: CSS
I agree with Timothy that GWT as a
framework makes almost impossible to create "runtime themeable"
application. While doing with plain js is pretty straight forward,
here is what we did:
in the index.html
link id="vt0" href="" rel="stylesheet"
type="text/css" title="STANDARD"/
link id="vt1" href="" rel="alternate
stylesheet" type="text/css" title="CUSTOM"/
then in code:
eventBus.addHandler(SelectViewTypeEvent.TYPE, new
SelectViewTypeEvent.Handler() {
@Override
public void onViewTypeChanged(SelectViewTypeEvent
event) {
final int viewTypeOrdinal =
event.getViewType().ordinal();
Scheduler.get().scheduleDeferred(new
ScheduledCommand() {
@Override
public void execute() {
Document doc = Document.get();
for(ViewType vt : ViewType.values()) {
LinkElement link =
doc.getElementById("vt" + vt.ordinal()).cast();
link.setDisabled(vt.ordinal() !=
viewTypeOrdinal);
}
}
});
}
});
to properly work on IE browsers, before render anything:
private void disableAllStylesheetsForIE() {
final Document doc = Document.get();
for(ViewType vt : ViewType.values()) {
LinkElement link = doc.getElementById("vt" +
vt.ordinal()).cast();
link.setDisabled(true);
}
LinkElement link = doc.getElementById("vt0").cast();
link.setDisabled(false);
}
My wish is that some day, I'll would be able to use all GWT-CSS
goodies like image bundles/sprites and css class hashing, etc for
this kind of apps.
IMHO css should be orthogonal to the actual html generated.
Although, in the current times of HTML5 apps, css is part of the
behavior of widgets, so in widgets based frameworks we have a
tension between how a widget should look (web designer job) and
its behavior that is some cases also partly implemented in css
(mostly because css is hardware accelerated, like css3
transformation or animations, and plain js doesn't).
Regards,
--
Bauna
On 05/16/2013 06:00 AM, Thomas Broyer wrote:
On Thursday, May 16, 2013 10:44:33 AM UTC+2, Timothy Spear wrote:
Inline
style in each UiBinder xml file will not be maintainable.
From a code maintenance perspective stylesheets should be used
extensively.
I find it much better for maintainability if the styles for a
given "widget" is close to that widget, and there's nothing
closer than "in the same file".
Let's just agree that we disagree on this point.
The
suggested solution for this is to include the css as part of the
ClientBundle as a resource.
This suggested solution is predicated on the following
assumptions:
-- a single CSS file (yes you can have multiple files, but this
is MX nightmare. Which variable.
-- User does not have the ability to change/select alternate CSS
files
-- Prevents the application from being re-labeled by an OEM SaaS
unless you also provide source code
-- Now you have to maintain and keep in sync three separate
items. Class name in CSS, Variable Names in CssResource file,
declarations in UiBinder XML File
Now explain all the linkages to a junior developer who needs to
change one minor thing in a complex app.
Nothing prevents you from using "plain old CSS": link to the
stylesheet from your HTML host page (and use SASS/LESS/whatever
if you like) and use your class names in your UiBinder.
That's the only way to have swappable/updatable styles
without handing out the source code; and it's not different than
how you'd do it if you were using a pure-JS framework. GWT
doesn't make anything "more complicated" here.
--
You received this message because you are subscribed to the Google
Groups "Google Web Toolkit" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to
google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email to
Re: CSS
David,
Take your idea a touch further. Ideally make it bi-directional between CSS and
generated Java classes. In the UiBinder you utilize the generated Java classes
for the references. At that point the GWT could tune the CSS and document
generation model very quick. It could also be tuned for the differences between
a table with limited CPU versus a desktop with more limited network aspects. By
making it bi-directional you can continue to let UI/Graphics people manipulate
it separate from the code.
Now, to make the CSS external for part of what I want to accomplish would be
difficult. Best solution I can think of off hand would be to have the ability
to select the source package for the CSS as part of the web.xml
At that point, I would just provide the raw CSS to customers and use just part
of the tool to generate Java classes into a new package/jar which the customer
can deploy.
Tim
On May 16, 2013, at 10:16 AM, David wrote:
Hi,
You don;t need to use just one CssResource. I use one per widget type. This
makes it really easy to restyle and to manage.
I also make sure that my custom widgets allow for a CssResource or even a
ClientBundle as parameter so that you can define your own styles.
What I do not like right now about CssResources is that you need to
maintain the .css file separately. Why not use some similar trick as used
in JSNI code, allow us to inline the actual style. Also when I want to
share colors and other constants between widgets it is also a bit more
difficult and I end up exposing those internals to the CssResource since I
need to subclass a base css that contains the generics AND I must make sure
that I also point to the base.css file through annotations.
Inheritance is tricky as well, it would have made more sense to me that we
could override css attributes though CssResource inheritance and not
through the standards CSS cascade.
For example I could have a base button.css where I set something like
background-color:blue and then subclass and redeclare the
background-color:green. This does not work, so now I have to use yet
another css file where everything except the background-color is set and
then put the color specific in another css file and make sure that I put
both in the @Source annotation. I know it makes sense in CSS but in OO it
does not make sense - if you subclass a CssResource you expect the
inhertiance on styles to happen the same way.
David
On Thu, May 16, 2013 at 10:44 AM, Spear Timothy n61...@gmail.com wrote:
Inline style in each UiBinder xml file will not be maintainable.
From a code maintenance perspective stylesheets should be used extensively.
The suggested solution for this is to include the css as part of the
ClientBundle as a resource.
This suggested solution is predicated on the following assumptions:
-- a single CSS file (yes you can have multiple files, but this is MX
nightmare. Which variable.
-- User does not have the ability to change/select alternate CSS files
-- Prevents the application from being re-labeled by an OEM SaaS unless
you also provide source code
-- Now you have to maintain and keep in sync three separate items. Class
name in CSS, Variable Names in CssResource file, declarations in UiBinder
XML File
Now explain all the linkages to a junior developer who needs to change one
minor thing in a complex app.
Tim
On May 16, 2013, at 4:35 AM, Jens wrote:
Hm a bit more details would be nice. What is complicated on using
ClientBundle? What code does it replicate?
Whats wrong with:
ExampleWidget.gwt.xml:
ui:with field=common
type=my.app.client.resources.CommonClientBundle/
ui:style
/* specific rules for ExampleWidget, could also be externalized into a
separate css file */
.myWidget {
padding:5px;
}
.content {
background-color:grey;
margin-left:5px;
}
/ui:style
g:HTMLPanel addStyleNames={style.myWidget}
g:Image resource={common.addIcon}/g:Image
div class={style.content}
I am some a href=#content/a
/div
/g:HTMLPanel
If you tell your junior developers Put widget specific css into an
inline
style (or widget specific css file) and take common things from the
common
ClientBundle whats hard to explain then? Also overriding CSS style on
general HTML elements inside an UiBinder widget should pretty much always
happen in the context of that widget so you dont mess up anything else:
ui:style
/* bad as it can globally override existing a CSS rules */
a:link {
color:red;
}
/* better */
.myWidget a:link {
color:red;
}
/ui:style
-- J.
--
You received this message because you are subscribed to the Google
Groups Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send
an email to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com
.
Visit this group at
Re: IE8 enormous memory consumption
We also noticed this behavior in IE. We found out that this was due to how the image sprites were being used. Make sure icons of the same size are in the same sprite. This helped in our system. We have 16 48 96 128 and finnaly one ImageResource that has all theother images. Op dinsdag 14 mei 2013 12:26:25 UTC+2 schreef Borys Zibrov het volgende: Hi! We've got an application on GWT 2.5.0 + GXT 3.0.4 with one main page, containing a big table (like Excel) and a couple of heavy popups (implemented using GXT Windows). It works reasonably good at Chrome, FF, and IE9 but is incredibly slow in IE8. Memory consumption on opening the main page and the most heavy popup is as follows: FF ~250Mb IE9 ~230 Mb IE8 ~600-700 Mb (!!) I don't think it's a memory leak, because memory stayed stable and didn't increase overnight. I'm at a loss where to start, and how to fix this problem. One idea was that rendering is fast in IE9 but not in IE8 because of a GPU acceleration, but that doesn't explain amount of memory needed for the IE8. We're currently profiling our application with dynatrace, but that doesn't help with memory usage. Any ideas greatly appreciated, thank you ! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Slotted - A Slot/Nesting Extension to Activities and Places
Fantastic. Thank you! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: I/O 2013 - GWT Sessions?
Doesn't look like either are being recorded. Oh well. On Tuesday, May 14, 2013 8:43:43 PM UTC-4, Craig Mitchell wrote: I'd have to agree with Rob on that one! :-) Looks like there are two sessions: GWT Roadmap for the Future: https://developers.google.com/events/io/sessions/327833110 Demystifying MVP and EventBus in GWT: https://developers.google.com/events/io/sessions/331474237 On Monday, March 11, 2013 8:41:38 AM UTC+11, Rob wrote: Hi, I think the obvious compromise location is Sydney. Cheers Rob -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: hash fragment gets dropped when some special characters are present (period, slash...)
my bad, turned out it's related to spiffyui, here's a small project to
demonstrate the bug: https://github.com/mbsimonovic/spiffyui-hash-bug. So
just excluding spiffiui.min.js fixes the bug. I'm gonna write to the
spiffyui developers...
ms
On Thursday, May 16, 2013 1:09:41 PM UTC+2, Thomas Broyer wrote:
On Thursday, May 16, 2013 1:02:19 PM UTC+2, milan wrote:
found the reason, the nocache.js script tag was before the history iframe.
This is really strange!
…as the iframe is only used by IE6/7, and you were reporting issues in
Firefox, Chrome and Safari.
regards,
Milan
On Wednesday, May 15, 2013 11:33:44 AM UTC+2, milan wrote:
I'm getting some weird behavior with ActivitiesPlaces (GWT 2.4.0 and
2.5.1), in FF 20/21/Chrome/Safari 6, both prod and dev mode.
Here's an example:
with @Prefix(!contact) these two urls work just fine ('contact' place,
token first empty then 'department'):
http://127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!contact:
http://127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!contact:department
but when I try to open:
http://127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!contact:department/1
the url gets rewritten to:
http://127.0.0.1:/!contact:department/1
and the app goes to the default place (historyToken is empty) and
there's a 404 because !contact doesn't exist. Debugging this I get to
c.g.g.user.client.impl.HistoryImpl.java#133 newItem() that is called
with an empty historyToken so this happens before any tokenizers get
called. The same happens when token contains period/dot (.) or question
mark. Anyone seen this before?
It's been known this can happen because of 3xx
redirectshttp://blogs.msdn.com/b/ieinternals/archive/2011/05/17/url-fragments-and-redirects-anchor-hash-missing.aspx,
but this is not the case here (then all fragments would be dropped). To be
sure this is not the case, I tried this with a redirect: a simple filter to
remove index.html so that
127.0.0.1:/index.html?gwt.codesvr=127.0.0.1:9997#!downloads: gets
redirected to 127.0.0.1:/?gwt.codesvr=127.0.0.1:9997#!downloads: and
it works correctly. Inspecting HTTP requests under the hood also doesn't
show any 3xx responses when hash gets dropped.
Could this be a bug?
regards,
Milan
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: I/O 2013 - GWT Sessions?
Doesn't look like either are being recorded. Oh well. They will be recorded. It just takes some time to put them online ;) Read comments in: https://plus.google.com/111085781306219684730/posts/42jN7J2i15G https://plus.google.com/u/0/112375874198651423592/posts/YduBRKv4Kba -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: I/O 2013 - GWT Sessions?
Good. I am looking forward to seeing them. On Thu, May 16, 2013 at 12:21 PM, Jens jens.nehlme...@gmail.com wrote: Doesn't look like either are being recorded. Oh well. They will be recorded. It just takes some time to put them online ;) Read comments in: https://plus.google.com/111085781306219684730/posts/42jN7J2i15G https://plus.google.com/u/0/112375874198651423592/posts/YduBRKv4Kba -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
drag and drop group
I have been using GWT native Dnd successfully. Now I have a need to create Dnd group. This means if Widget A and panel B are in the same group, I want to allow user to drag A into B. C and D forms another group. So, A can not be dropped onto D, only C can. and likewise, C can not be dropped into B. Anyone knows how to implement this? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Cell mouse in/out events fired multiple times
Sure, will check that one too... Thanks, Ranjith On Sunday, May 12, 2013 1:00:48 PM UTC+5:30, Ranjith Chungath wrote: I have a cell which is composed of multiple div, img eleemnts. When I register for mouse in/out events, onBrowserEvent gets called multiple times when the mouse is hovered over the cell because it fires for each contained div/img elements. I know that this is done so that there might be a requirement to want to know exactly which element was moused over. But, in my case , I don't need to know which contained element was moused over, I just want to know which cell was moused over. These multiple events are making my implementation complex since I have having to do a lot of book keeping. What is the best way to implement this? Also, it will be great if you can point me to some examples. Thanks, Ranjith -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CSS
In a well designed app, there are no widget-specific styles. None. Every margin / padding / color / size / border , etc., should be defined by a designer at the application level. I can't think of any style that developers should be allowed to set as they wish. It makes it much easier to build beautiful, professionally designed apps, that can be: * easily themed * adjust to various screen sizes gracefully * support multiple font sizes (CTRL +/- in every browser) and UI languages * look correctly in all browsers. In my GWT app users can change the theme of the app with a single click. The app does not reload, but it immediately looks very different - including the color of rows in every DataGrid! This implementation requires 1 line of code. Can you beat that with a ClientBundle? All the magic is done by a designer in an external CSS file. I can add custom themes for premium customers by injecting a different CSS file at run time, without touching any GWT code at all. This also means that I never have to recompile the app when I make style changes. I also develop faster: when I add a new widget, it always looks right and it aligns perfectly with the other widgets in the same view. I don't have to decide its size or margins - they are handled by CSS. The only exception are LayoutPanels, where I have to set positions explicitly. To achieve all this, I had to merge GWT's standard theme with my own CSS file and externalize all DataGrid styles. I eliminated over 1,000 lines of CSS in the process, and by doing so I eliminated the conflicts they have been causing and made it much easier to maintain the app going forward. CSS is built around inheritance. If you create separate resources for each widget, or inline styles in widgets, or obfuscate styles at a widget level, you inevitably write much more CSS then necessary. Redundant code is always bad, but in this case it also greatly increases the possibility of inconsistencies and rule conflicts. I don't know any professional web designer who advocates inlining of styles or using multiple CSS files. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
TabLayoutPanel not displaying properly after button push
Hi, I am trying to use a TabLayoutPanel and it seems to be working fine
when it is the first thing I put on the page, but when I do it after a
button push (for example) it is not displaying properly. For example, if I
do something like this it works fine:
TabLayoutPanel tlp = new TablLayoutPanel(2.5, Style.Unit.EM);
hp.add(btn);
tlp.add(new HTML(Tab1), Tab 1 title);
tlp.add(new HTML(Tab2), Tab 2 title);
tlp.add(new HTML(Tab3), Tab 3 title);
tlp.setPixelSize(500, 400);
RootLayoutPanel.get().add(tlp);
However, if I do something like the following, when I click the button all
I see displayed is Tab1, no other tabs, no Tab 1 title, etc.:
HorizontalPanel hp = new HorizontalPanel();
Button btn = new Button(push);
TabLayoutPanel tlp = new TablLayoutPanel(2.5, Style.Unit.EM);
hp.add(btn);
tlp.add(new HTML(Tab1), Tab 1 title);
tlp.add(new HTML(Tab2), Tab 2 title);
tlp.add(new HTML(Tab3), Tab 3 title);
tlp.setPixelSize(500, 400);
RootLayoutPanel.get().add(tlp);
btn.addClickHandler(new ClickHandler() {
public void onClick(ClickEvent event) {
RootLayoutPanel.get().remove(hz);
RootLayoutPanel.get().add(tlp);
}
};
Any ideas? I read somewhere that there are problems with TabLayoutPanel in
IE8, which I'm using, but since it displays okay in the first case I doubt
that's the issue. I wanted to see what would happen with Chrome and
Firefox, but spent a couple hours struggling to install the GWT Developer
Plugin on those browsers without any luck.
Thanks in advance for any help or suggestions...
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
replacing jquery with GWT features in demo:: for web Designers
[UI/UEX web designer question] Is there a way for a UI designer (myself) to still use clean HTML/CSS while pulling in GWT features/elements (that may use UIBINDER) instead of having to find/customize/use throw away jquery to demo functionality? Thanks all! -- This communication, along with any attachments, may include confidential TouchCommerce Inc. information. Any distribution or copying of this material is strictly prohibited. If you are not the intended recipient of this transmission, please contact the sender immediately -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: replacing jquery with GWT features in demo:: for web Designers
Hmm if I dont get the question right feel free to give some more information. In general you can add behavior to existing static HTML/CSS UI designs/mockups using GWT but you have to be aware that you probably slow down your workflow a bit compared to what you are used to as a Web/Ui Designer using JQuery. Thats because in GWT you program Java and you need either a browser plugin for live editing (which is a bit slower because the plugin needs to translate between Java - JavaScript) or you have to compile your GWT code into JavaScript before seeing changes in the browser. Using SuperDevMode this compilation can be quite fast but it will still be slower then just reloading the HTML in the browser like you would do it as web designer/UI designer. Beside that GWT can of course directly manipulate DOM elements and there is even a project called GWTQuery which mimics JQuery in the GWT land. But maybe you should look at AngularJS (as an alternative to JQuery) before considering GWT. AngularJS is really nice if you want to enhance a static HTML design/mockup with some interaction functionalities. Take a look at the AngularJS examples on their homepage and give this video a shot (from Google IO 2013): http://www.youtube.com/watch?v=HCR7i5F5L8c -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
RichTextArea HTML how to dynamically style anchor elements?
How can I dynamically change the color for links anywhere in RichTextArea HTML elements? That is, I need to be able to set the link color dynamically as the user is allowed to specify the UI colors. I can change the general foreground and background colors no problem but I'm having trouble figuring out how to change all the 'a' elements. -Dave -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Cannot change Label background colors on hover using css.
So I set the style name of my GWT Label:
currentDataNameDescriptionLabel.setStyleName(NFRFP-Label
NFRFP-ClickableLabel);
and I have this css:
.NFRFP-Label {
float: left;
font-size: 17px;
margin-right: 4px;
}
.NFRFP-ClickableLabel {
cursor: pointer;
}
.NFRFP-ClickableLabel: hover {
background-color: #EE;
}
And... no joy. When I use the Chrome Developer Plugin to edit the
NFRFP-ClickableLabel class to be NFRFP-ClickableLabel:hover in a running
page, well it works fine.
Any idea on how I can get the css hover selector to work with a GWT Label?
Cheers,
David
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Slider for GWT?
CSS hide the other scrollbar? On Tuesday, 7 May 2013 19:00:14 UTC+1, membersound wrote: This incubator works perfectly for me, as I just need a single scrollbar. Thanks! 2013/5/7 Honza Rames ram...@gmail.com javascript: There is an Slider implementation in GWT incubator ( https://code.google.com/p/google-web-toolkit-incubator/wiki/SliderBar) which is now deprecated but can be used as a how-to. I've used this codebase and created an updated implementation that added mobile support and more. But is still pixel based and kind of slow to render (if you have a lot of them). But if you want I'll be happy to share ;-). Honza On Sunday, May 5, 2013 7:57:16 PM UTC+2, membersound wrote: Hi, maybe I'm missing it, but so far I could not found a Slider Widget (or anything similar I could misuse therefore). Doesn't gwt provide a slider? -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/omXqNhZc_xU/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com javascript:. To post to this group, send email to google-we...@googlegroups.comjavascript: . Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Thomas Broyer has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 5: (2 comments) File tools/api-checker/config/gwt25_26userApi.conf Line 45: :com/google/gwt/resources/client/impl/**\ Good question :-) I have absolutely no idea how api_checker works (I already looked at it a couple times but forget everything about it as soon as I stop looking at it) From https://code.google.com/p/google-web-toolkit/wiki/ApiChecker_User_Guide (which we should really all check from time to time: it seems like we didn't follow the process when creating this file), I think we should actually simply list com.google.gwt.resources.client.impl in excludedPackages. excludedFiles are about excluding those files that are not translatable to JS by GWT, so it should exclude all rebind or server code, and those classes that have a super-sourced version. I'll make the change. File user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java Line 549: @DoNotRunWith(Platform.HtmlUnitUnknown) Here we're changing Image so that it'll use an UnclippedState when initialized with an ImageResource that isStandalone, whereas previously it would unconditionally use a ClippedState when initialized with an ImageResource (as opposed to a URL). Previously, with the ClippedState, the image would be rendered using innerHTML and its dimensions set within style= (from ClippedImageImpl); whereas the UnclippedState sets the ImageElement's width and height properties. I confirmed in a small test with ImageElement that getOffsetWidth returns 1256 there even though getWidth returns 56 (the value I had passed to setWidth). This is independent from the image being loaded. I also tried deferring the asserts with Scheduler#scheduleDeferred and it didn't change anything. Using getStyle().setWidth(56, Unit.PX) fixes getOffsetWidth, but now getWidth returns 24 (a hard-coded value). So, should we change UnclippedState to use getStyle().setWidth() or do we simply declare a bug in HTMLUnit and disable the tests? (i.e. what I've done here, but maybe change it Platform.HtmlUnitBug)) -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Hello Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2110 to look at the new patch set (#6). Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Adds isStandalone to ImageResource so Image can used an UnclippedState. isStandalone should be true for data: URLs and non-inlined images (preventInlining=true or repeatStyle=Both). In other words, it should actually rarely be false (IE6/7). Fixes issue 7403 Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 --- M tools/api-checker/config/gwt25_26userApi.conf M user/src/com/google/gwt/resources/client/ImageResource.java M user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java M user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java M user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java M user/src/com/google/gwt/user/client/ui/Image.java M user/src/com/google/gwt/user/client/ui/ImageResourceRenderer.java M user/test/com/google/gwt/cell/client/ImageResourceCellTest.java M user/test/com/google/gwt/resources/client/ImageResourceTest.java M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java M user/test/com/google/gwt/user/client/ui/ImageTest.java 11 files changed, 173 insertions(+), 17 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Hello Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a rebased change. Please visit https://gwt-review.googlesource.com/2110 to look at the new rebased patch set (#7). Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Adds isStandalone to ImageResource so Image can used an UnclippedState. isStandalone should be true for data: URLs and non-inlined images (preventInlining=true or repeatStyle=Both). In other words, it should actually rarely be false (IE6/7). Fixes issue 7403 Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 --- M tools/api-checker/config/gwt25_26userApi.conf M user/src/com/google/gwt/resources/client/ImageResource.java M user/src/com/google/gwt/resources/client/impl/ImageResourcePrototype.java M user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java M user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java M user/src/com/google/gwt/user/client/ui/Image.java M user/src/com/google/gwt/user/client/ui/ImageResourceRenderer.java M user/test/com/google/gwt/cell/client/ImageResourceCellTest.java M user/test/com/google/gwt/resources/client/ImageResourceTest.java M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java M user/test/com/google/gwt/user/client/ui/ImageTest.java 11 files changed, 173 insertions(+), 17 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
Matthew Dempsky has uploaded a new change for review.
https://gwt-review.googlesource.com/2771
Change subject: Don't call toString() on plain Java arrays
..
Don't call toString() on plain Java arrays
Error Prone will soon warn about calling toString() on plain Java
arrays, because the return value is rarely useful. In JsoTest, we
don't actually care about what it returns because the cast to
String[][] should throw an exception anyway, but presumably we want to
make sure the variable doesn't get discarded as dead and the cast
optimized away.
Instead of applying the Error Prone automated refactoring of calling
java.util.Arrays.toString(), we can just call getClass() instead.
Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9
---
M user/test/com/google/gwt/dev/jjs/test/JsoTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
b/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
index 059d1c9..9164f25 100644
--- a/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
+++ b/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
@@ -407,7 +407,7 @@
assertFalse(o instanceof String[][]);
try {
String[][] s = (String[][]) o;
- s.toString();
+ s.getClass();
fail(Expected ClassCastException);
} catch (ClassCastException expected) {
}
--
To view, visit https://gwt-review.googlesource.com/2771
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky mdemp...@google.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
Thomas Broyer has posted comments on this change. Change subject: Don't call toString() on plain Java arrays .. Patch Set 1: Code-Review+2 (1 comment) File user/test/com/google/gwt/dev/jjs/test/JsoTest.java Line 410: s.getClass(); I suppose this is call is only there so that the cast is not purely optimized out? -- To view, visit https://gwt-review.googlesource.com/2771 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
Matthew Dempsky has posted comments on this change. Change subject: Don't call toString() on plain Java arrays .. Patch Set 1: (1 comment) File user/test/com/google/gwt/dev/jjs/test/JsoTest.java Line 410: s.getClass(); That's my best guess as well. Maybe Roberto has some insight, but it's probably not very important either way. -- To view, visit https://gwt-review.googlesource.com/2771 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Matthew Dempsky has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 7: Verified+1 Code-Review+1 LGTM, tests all pass now. Goktug, I'll let you +2. :) -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 3:
(1 comment)
File build.xml
Line 36:
value=${gwt.tools}/api-checker-reference/2.5.1/gwt-dev.jar:${gwt.tools}/api-checker-reference/2.5.1/gwt-user.jar/
Oh, I added the jars to GWT_TOOLS as gwt-{dev,user}-modified.jar like they
were already. I'd like to keep the modified label for now just so it's
clearer that the files aren't the pristine release jar files.
--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
John A. Tamplin has posted comments on this change. Change subject: Don't call toString() on plain Java arrays .. Patch Set 1: Code-Review+2 (1 comment) File user/test/com/google/gwt/dev/jjs/test/JsoTest.java Line 410: s.getClass(); I'm kind of surprised that getClass wouldn't get optimized out anyway, since it gets replaced with a field reference, but I think this should be fine since the test would be failing if the cast/getClass call get optimized away. -- To view, visit https://gwt-review.googlesource.com/2771 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Don't call toString() on plain Java arrays
Matthew Dempsky has submitted this change and it was merged.
Change subject: Don't call toString() on plain Java arrays
..
Don't call toString() on plain Java arrays
Error Prone will soon warn about calling toString() on plain Java
arrays, because the return value is rarely useful. In JsoTest, we
don't actually care about what it returns because the cast to
String[][] should throw an exception anyway, but presumably we want to
make sure the variable doesn't get discarded as dead and the cast
optimized away.
Instead of applying the Error Prone automated refactoring of calling
java.util.Arrays.toString(), we can just call getClass() instead.
Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9
---
M user/test/com/google/gwt/dev/jjs/test/JsoTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
John A. Tamplin: Looks good to me, approved
Leeroy Jenkins: Verified
Thomas Broyer: Looks good to me, approved
diff --git a/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
b/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
index 059d1c9..9164f25 100644
--- a/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
+++ b/user/test/com/google/gwt/dev/jjs/test/JsoTest.java
@@ -407,7 +407,7 @@
assertFalse(o instanceof String[][]);
try {
String[][] s = (String[][]) o;
- s.toString();
+ s.getClass();
fail(Expected ClassCastException);
} catch (ClassCastException expected) {
}
--
To view, visit https://gwt-review.googlesource.com/2771
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e90cf1442d126efe8d7ec866204f20c5e4cf3e9
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
On 2012/09/16 02:36:41, Patrick Tucker wrote: Anybody? http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can review and merge it there? http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
On 2013/05/16 19:35:21, mdempsky wrote: Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can review and merge it there? Oops, sorry, the link is just https://gwt-review.googlesource.com http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add SafeUri overloads for setting properties used for naviga...
Goktug Gokdogan has posted comments on this change. Change subject: Add SafeUri overloads for setting properties used for navigation .. Patch Set 4: Matthew, can you do the change if Thomas doesn't have any other concerns? -- To view, visit https://gwt-review.googlesource.com/2663 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Guillaume Ryder gry...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Goktug Gokdogan has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 7: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add SafeUri overloads for setting properties used for naviga...
Matthew Dempsky has posted comments on this change. Change subject: Add SafeUri overloads for setting properties used for navigation .. Patch Set 4: My personal inclination is still to keep the setFoo(SafeUri) overloads instead of renaming them to setSafeFoo(SafeUri). In Google's internal code base, only about 1% of existing call sites to AnchorElement.setHref(String) were of the form anchor.setHref(null) and needed to be disambiguated. I think the minor inconvenience to those use cases is worthwhile if it makes using SafeUri easier / more visible. -- To view, visit https://gwt-review.googlesource.com/2663 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Guillaume Ryder gry...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...
Goktug Gokdogan has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 5: (2 comments) I hate gerrit when Add comment doesn't publish the draft comments :( File tools/api-checker/config/gwt25_26userApi.conf Line 45: :com/google/gwt/resources/client/impl/**\ He he, nobody in gwt-team knew about this document when I asked about it and created the file :) It could have saved me a lot of time. Thanks for looking into this. When you do the change, it would be good to put the documentation link to the readme file in the script directory. File user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java Line 549: @DoNotRunWith(Platform.HtmlUnitUnknown) I'm not sure which is the best way to follow here. Feel free to go with what makes sense to you. -- To view, visit https://gwt-review.googlesource.com/2110 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832fd71e17e447e642de134e7a556befa1a7f0f1 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add SafeUri overloads for setting properties used for naviga...
Goktug Gokdogan has posted comments on this change. Change subject: Add SafeUri overloads for setting properties used for navigation .. Patch Set 4: Yeah, making it more discoverable looks worthwhile. Perhaps, you would also want to make it consistent by changing Element#setInnerSafeHtml to setInnerHtml? -- To view, visit https://gwt-review.googlesource.com/2663 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Guillaume Ryder gry...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add SafeUri overloads for setting properties used for naviga...
Matthew Dempsky has posted comments on this change. Change subject: Add SafeUri overloads for setting properties used for navigation .. Patch Set 4: Yeah, renaming setInnerSafeHtml(SafeHtml) to just setInnerHTML(SafeHtml) would make things more consistent. Checking internally, I only see two calls to setInnerHTML(null), and one of them is in the open source Wave code. ;) So even less risk of breaking existing users there I think. I see a *lot* of calls to setInnerSafeHtml() though, so we'd probably need to keep the current method as a @Deprecated forwarding method for a few releases. -- To view, visit https://gwt-review.googlesource.com/2663 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Guillaume Ryder gry...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Goktug Gokdogan has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 1:
(2 comments)
Sending a new patch without TypedXYZ.
PTAL.
File user/src/com/google/gwt/user/client/ui/PanelComposite.java
Line 39: this.add(asWidgetOrNull(w));
I think I understand what you are trying to achieve. Done.
File user/src/com/google/gwt/user/client/ui/TypedComposite.java
Line 118: if (widget == null) {
I change how this is asserted in the new code. I took a less conservative
approach and handled cases where it is harder to understand what is going
on.
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2582 to look at the new patch set (#2). Change subject: Introduces generic Composite widgets. .. Introduces generic Composite widgets. Composite can now be 'safely' extended to add delegation to methods for more specific types. Adds FocusComposite and PanelComposite. Improves error messaging for incorrect use. Fixes issue 4665, issue 6997. Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Review-Link: https://gwt-review.googlesource.com/#/c/2582/ --- M user/src/com/google/gwt/user/client/ui/Composite.java A user/src/com/google/gwt/user/client/ui/FocusComposite.java A user/src/com/google/gwt/user/client/ui/PanelComposite.java M user/src/com/google/gwt/user/client/ui/ResizeComposite.java 4 files changed, 297 insertions(+), 20 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2500 to look at the new patch set (#4). Change subject: Removes api-checker reference JARs from the source tree. .. Removes api-checker reference JARs from the source tree. Now expects them in GWT_TOOLS. Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 --- M build.xml D tools/api-checker/reference/README D tools/api-checker/reference/createApiCheckerReferenceJars.sh D tools/api-checker/reference/gwt-dev-modified.jar D tools/api-checker/reference/gwt-user-modified.jar 5 files changed, 3 insertions(+), 46 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 3:
(1 comment)
File build.xml
Line 36:
value=${gwt.tools}/api-checker-reference/2.5.1/gwt-dev.jar:${gwt.tools}/api-checker-reference/2.5.1/gwt-user.jar/
Done
--
To view, visit https://gwt-review.googlesource.com/2500
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Thomas Broyer has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: Code-Review+1 That new 'delegate' concept is interesting. I don't think we discussed it earlier though, so I'll let someone else put the +2. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Goktug Gokdogan has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: Yes, we haven't discussed =) The idea behind is some composite scenarios you want you delegate to something different than your base widget. A good example is following: g:HtmlPanel div This is my header /div g:FlowPanel ui:field=content / div This is my footer /div g:SimplePanel ui:field=someOthercomponent / /g:HtmlPanel In this pretty common scenario, you want to add/remove children calls to be forwarded to content FlowPanel. Previously this was very painful but you can easily achieve that now. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Thomas Broyer has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: That's what I thought it was about; this is great! Just a note that the getDelegate could possibly break some people that defined a getDelegate method in their Composite subclass. I don't think it'll break many people in practice though, so I'm fine with this (same for the overloaded initWidget, with even less impact I guess). -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Brian Slesinsky has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: (2 comments) File user/src/com/google/gwt/user/client/ui/Composite.java Line 29: * methods. When added to a panel, a composite behaves exactly as if the widget This javadoc doesn't seem quite true anymore if widget != delegate. Line 37: * @param T type of the widget wrapped The way we're using T seems confusing. Widget getWidget(); T getDelegate(); void setWidget(T); So I'm wondering whether T is supposed to be the type of the widget, or the delegate, or both? We should clarify that. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Jens Nehlmeier has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 2:
(4 comments)
File user/src/com/google/gwt/user/client/ui/Composite.java
Line 127: public T getDelegate() {
protected final instead of public. I dont think a composite wants to leak
out T.
Line 148:*
Maybe add an example to illustrate the purpose (for new GWT users).
Line 151:*will be delegated (e.g. HasWidget#add)
I am not a native speaker but the child widget that higher level API calls
(if any) will be delegated (e.g. HasWidget#add) to sounds better to me.
File user/src/com/google/gwt/user/client/ui/FocusComposite.java
Line 52: HasAllMouseHandlers, HasAllGestureHandlers,
HasAllTouchHandlers {
What about the remaining interfaces that FocusWidget implements?
HasDoubleClickHandlers, HasAllDragAndDropHandlers?
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Thomas Broyer has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 2: (1 comment) File user/src/com/google/gwt/user/client/ui/Composite.java Line 37: * @param T type of the widget wrapped Well, setWidget() is a deprecated alias to initWidget, and initWidget(T) is an alias for initWidget(Widget,T) where the argument is passed as both the root widget and the delegate widget; so while it looks a bit weird (when you look at the signatures of setWidget vs. getWidget), it's actually consistent. I however agree the javadoc could be enhanced to talk about that new concept of 'delegate'. And maybe it's time to delete setWidget(), it's deprecated since the very first public commit more than 6 years ago! -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
