Re: JsFunction length is zero

2020-01-14 Thread Vassilis Virvilis 
I just did it.

Thanks for the help and the patience.

On Tue, Jan 14, 2020 at 11:11 AM Jens  wrote:

>
> I just got my first positive review and I noticed the 'Add Reviewer/ Add
>> CC' buttons and I am wondering if I should manually enter the names you
>> suggested previously in the thread?
>>
>
> Sure, you would use the Add Reviewer button. The person you add will then
> receive an email notification (if they haven't deactivated it).
>
>
> -- J.
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit/fe261053-1fbe-400d-9a8f-982249348e4a%40googlegroups.com
> 
> .
>


-- 
Vassilis Virvilis

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/CAKbOjExgrDR4M4wNDHGo6bcp01dfEWySvRKjT08LqG3-OLdbBA%40mail.gmail.com.

Re: JsFunction length is zero

2020-01-14 Thread Jens 


> I just got my first positive review and I noticed the 'Add Reviewer/ Add 
> CC' buttons and I am wondering if I should manually enter the names you 
> suggested previously in the thread?
>

Sure, you would use the Add Reviewer button. The person you add will then 
receive an email notification (if they haven't deactivated it).


-- J.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/fe261053-1fbe-400d-9a8f-982249348e4a%40googlegroups.com.

Re: JsFunction length is zero

2020-01-14 Thread Vassilis Virvilis 
Hi Jens,

Sorry for bothering you again but I am new to this.

I just got my first positive review and I noticed the 'Add Reviewer/ Add
CC' buttons and I am wondering if I should manually enter the names you
suggested previously in the thread?

Thanks

On Fri, Jan 10, 2020 at 4:21 PM Vassilis Virvilis  wrote:

> I actually added a pull/review request on gerrit at 3 Dec 2019
>
>
> https://gwt-review.googlesource.com/q/I7af77f4b5e05c29a275c5b4a3f5610288f11dba9
>
> but no signs of life so far. It certainly takes a lot of time to review...
>
> Vassilis
>
>
> On Mon, Dec 2, 2019 at 1:38 PM Vassilis Virvilis 
> wrote:
>
>> Here is the commit
>> https://github.com/vasvir/gwt/commit/decf6974a284b24042c072e47662554ed0613a60
>>
>> Unfortunately GWT does not accept pull request on GitHub.
>>
>>
>> On Thu, Nov 28, 2019 at 3:12 PM Vassilis Virvilis 
>> wrote:
>>
>>> ok then.
>>>
>>> Here is the submitted issue
>>> https://github.com/gwtproject/gwt/issues/9675
>>>
>>> I will try to come with a patch in the next few days.
>>>
>>> Thanks
>>>
>>>   Vassilis
>>>
>>> On Thu, Nov 28, 2019 at 9:38 AM Jens  wrote:
>>>

 Do you think a patch like that has any chance to be accepted? or this
> is not considered to be an issue?
>

 Seems like a valid behavior for JS libraries to check argument count,
 so I guess it should be accepted. Goktug or Roberto should probably review
 it.

 -- J.

 --
 You received this message because you are subscribed to the Google
 Groups "GWT Users" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to google-web-toolkit+unsubscr...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/google-web-toolkit/9232cdec-c84f-427a-a019-d0cef9262244%40googlegroups.com
 
 .

>>>
>>>
>>> --
>>> Vassilis Virvilis
>>>
>>
>>
>> --
>> Vassilis Virvilis
>>
>
>
> --
> Vassilis Virvilis
>


-- 
Vassilis Virvilis

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/CAKbOjEy5e1ETbVWL6L8Rts73BJbZaSAh5S1jU-QM8cKNT_AjHw%40mail.gmail.com.

Re: JsFunction length is zero

2020-01-10 Thread Vassilis Virvilis 
I actually added a pull/review request on gerrit at 3 Dec 2019

https://gwt-review.googlesource.com/q/I7af77f4b5e05c29a275c5b4a3f5610288f11dba9

but no signs of life so far. It certainly takes a lot of time to review...

Vassilis


On Mon, Dec 2, 2019 at 1:38 PM Vassilis Virvilis  wrote:

> Here is the commit
> https://github.com/vasvir/gwt/commit/decf6974a284b24042c072e47662554ed0613a60
>
> Unfortunately GWT does not accept pull request on GitHub.
>
>
> On Thu, Nov 28, 2019 at 3:12 PM Vassilis Virvilis 
> wrote:
>
>> ok then.
>>
>> Here is the submitted issue https://github.com/gwtproject/gwt/issues/9675
>>
>> I will try to come with a patch in the next few days.
>>
>> Thanks
>>
>>   Vassilis
>>
>> On Thu, Nov 28, 2019 at 9:38 AM Jens  wrote:
>>
>>>
>>> Do you think a patch like that has any chance to be accepted? or this is
 not considered to be an issue?

>>>
>>> Seems like a valid behavior for JS libraries to check argument count, so
>>> I guess it should be accepted. Goktug or Roberto should probably review it.
>>>
>>> -- J.
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "GWT Users" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to google-web-toolkit+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/google-web-toolkit/9232cdec-c84f-427a-a019-d0cef9262244%40googlegroups.com
>>> 
>>> .
>>>
>>
>>
>> --
>> Vassilis Virvilis
>>
>
>
> --
> Vassilis Virvilis
>


-- 
Vassilis Virvilis

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/CAKbOjEzgxL0%2BCBZbZ9a_NQi4Eub1ptujwzYy0tRwx8zf0yGGWg%40mail.gmail.com.

Re: JsFunction length is zero

2019-12-02 Thread Vassilis Virvilis 
Here is the commit
https://github.com/vasvir/gwt/commit/decf6974a284b24042c072e47662554ed0613a60

Unfortunately GWT does not accept pull request on GitHub.


On Thu, Nov 28, 2019 at 3:12 PM Vassilis Virvilis  wrote:

> ok then.
>
> Here is the submitted issue https://github.com/gwtproject/gwt/issues/9675
>
> I will try to come with a patch in the next few days.
>
> Thanks
>
>   Vassilis
>
> On Thu, Nov 28, 2019 at 9:38 AM Jens  wrote:
>
>>
>> Do you think a patch like that has any chance to be accepted? or this is
>>> not considered to be an issue?
>>>
>>
>> Seems like a valid behavior for JS libraries to check argument count, so
>> I guess it should be accepted. Goktug or Roberto should probably review it.
>>
>> -- J.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "GWT Users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/google-web-toolkit/9232cdec-c84f-427a-a019-d0cef9262244%40googlegroups.com
>> 
>> .
>>
>
>
> --
> Vassilis Virvilis
>


-- 
Vassilis Virvilis

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/CAKbOjExsX5nUnBnFsB4yLjMj8pK8x852oYF1_m-U_rhYBCACwQ%40mail.gmail.com.

Re: JsFunction length is zero

2019-11-28 Thread Vassilis Virvilis 
ok then.

Here is the submitted issue https://github.com/gwtproject/gwt/issues/9675

I will try to come with a patch in the next few days.

Thanks

  Vassilis

On Thu, Nov 28, 2019 at 9:38 AM Jens  wrote:

>
> Do you think a patch like that has any chance to be accepted? or this is
>> not considered to be an issue?
>>
>
> Seems like a valid behavior for JS libraries to check argument count, so I
> guess it should be accepted. Goktug or Roberto should probably review it.
>
> -- J.
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit/9232cdec-c84f-427a-a019-d0cef9262244%40googlegroups.com
> 
> .
>


-- 
Vassilis Virvilis

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/CAKbOjExjVWLLBO%3DJHgiudD6g%2BDtSc-PGnj%3DWdH%3DPWh43ugu8ww%40mail.gmail.com.

Re: JsFunction length is zero

2019-11-27 Thread Jens 


> Do you think a patch like that has any chance to be accepted? or this is 
> not considered to be an issue?
>

Seems like a valid behavior for JS libraries to check argument count, so I 
guess it should be accepted. Goktug or Roberto should probably review it.

-- J.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/9232cdec-c84f-427a-a019-d0cef9262244%40googlegroups.com.

Re: JsFunction length is zero

2019-11-27 Thread Vassilis Virvilis 
Hi Jens,

Thanks for the reply and the pointer. Your answers are spot on as always
but in this case I had managed to find the specific code fragment by my
self.

I was thinking a patch could look like the accepted answer in this Stack
Overflow question:
https://stackoverflow.com/questions/7316688/how-to-programmatically-set-the-length-of-a-function

assuming arguments and arguments.length carry the necessary information.

Do you think a patch like that has any chance to be accepted? or this is
not considered to be an issue?

Thanks



On Wed, Nov 27, 2019 at 1:57 PM Jens  wrote:

> You can see here how GWT compiler creates lambdas:
> https://github.com/gwtproject/gwt/blob/master/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Runtime.java#L162
>
> In case you also want to try to fix the issue ;-)
>
> -- J.
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit/e6e9e9ea-e921-41c7-9283-9734902e3d41%40googlegroups.com
> 
> .
>


-- 
Vassilis Virvilis

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/CAKbOjEzsNhqhPWbUQENie-mx-g-pMYWs-09vt5w8fqbf8qnUDQ%40mail.gmail.com.

Re: JsFunction length is zero

2019-11-27 Thread Jens 
You can see here how GWT compiler creates 
lambdas: 
https://github.com/gwtproject/gwt/blob/master/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Runtime.java#L162

In case you also want to try to fix the issue ;-)

-- J.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/e6e9e9ea-e921-41c7-9283-9734902e3d41%40googlegroups.com.

JsFunction length is zero

2019-11-26 Thread Vassilis Virvilis 
Hi,

Looks like that some javascript libraries are checking on the argument
length of the callbacks that are passed to them.

So for example D3 bisector can take a function with one or two arguments.
If it is one then it is an accessor if it is two then it is a comparator.

I searched on github issues. Should I report it?

The following snippet demonstrates the problem. The Function.length should
be 1 and not 0.

@JsFunction
public static interface SomeFunction {
public double call(double x);
}
/** * This is the entry point method. */
@Override
public void onModuleLoad() {
final SomeFunction y = new SomeFunction() {
@Override
public double call(double x) {
return 2 * x;
}
};
DomGlobal.console.log(y);
return;}

[image: image.png]

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/CAKbOjEzhR%3DGgF8S7SMmpq9WzjmqViKjZtcWLCKMp%3DaK0uZmHLQ%40mail.gmail.com.