[gwt-contrib] Re: Comment on DefaultLocaleBinding in google-web-toolkit
Comment by eplischke: ... or if you have multi-locales than you can do this way: extend-property name=locale values=en,de/ set-property-fallback name=locale value=en/ set-property name=locale value=en,de/ For more information: http://code.google.com/p/google-web-toolkit/wiki/DefaultLocaleBinding -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Some of the unit tests in CreateEventTest have listeners (issue1223801)
Reviewers: jlabanca, Description: Some of the unit tests in CreateEventTest have listeners that fire multiple times. This occasionally causes a failure in an unrelated test. Assuming that the extra firings are spurious, I've added an explicit 'cancel()' method to bypass the assertions if they fire after an individual test runs. Also took the opportunity to get rid of some deprecation warnings and lengthen timeouts in the DialogBoxTest and MenuBarTests which flaked out on me while smoke testing this patch. Please review this at http://gwt-code-reviews.appspot.com/1223801/show Affected files: M user/test/com/google/gwt/user/client/ui/CreateEventTest.java M user/test/com/google/gwt/user/client/ui/DialogBoxTest.java M user/test/com/google/gwt/user/client/ui/MenuBarTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Some of the unit tests in CreateEventTest have listeners (issue1223801)
LGTM http://gwt-code-reviews.appspot.com/1223801/diff/1/2 File user/test/com/google/gwt/user/client/ui/CreateEventTest.java (right): http://gwt-code-reviews.appspot.com/1223801/diff/1/2#newcode738 user/test/com/google/gwt/user/client/ui/CreateEventTest.java:738: listener.assertReceived(); Should you add listener.cancel() here too? http://gwt-code-reviews.appspot.com/1223801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add a warning in GWTTestCase to help users that accidentally run a GWT JUnit Test as a JUnit Test. (issue1224801)
Reviewers: jlabanca, rdayal,
Description:
Add a warning in GWTTestCase to help users that accidentally run a GWT
JUnit Test as a JUnit Test.
This mistake is easy to make (especially in Eclipse.) Therefore, we
display a helpful error suggesting the user run as a GWTJUnitTest if an
exception is thrown and the devjar property is not set.
Please review this at http://gwt-code-reviews.appspot.com/1224801/show
Affected files:
M user/src/com/google/gwt/junit/client/GWTTestCase.java
Index: user/src/com/google/gwt/junit/client/GWTTestCase.java
===
--- user/src/com/google/gwt/junit/client/GWTTestCase.java (revision 9436)
+++ user/src/com/google/gwt/junit/client/GWTTestCase.java (working copy)
@@ -428,17 +428,26 @@
*/
@Override
protected void runTest() throws Throwable {
-if (this.getName() == null) {
- throw new IllegalArgumentException(
- GWTTestCases require a name; \
- + this.toString()
- + \ has none. Perhaps you used TestSuite.addTest()
instead of addTestClass()?);
-}
-
-if (isPureJava()) {
- super.runTest();
-} else {
- JUnitShell.runTest(this, testResult);
+try {
+ if (this.getName() == null) {
+throw new IllegalArgumentException(
+GWTTestCases require a name; \
++ this.toString()
++ \ has none. Perhaps you used TestSuite.addTest()
instead of addTestClass()?);
+ }
+
+ if (isPureJava()) {
+super.runTest();
+ } else {
+JUnitShell.runTest(this, testResult);
+ }
+} catch (Throwable thowable) {
+ // Check to see if gwt.devjar is null. If so, notify the
+ // user that they may have run as a JUnitTest instead of a
GWTJUnitTest.
+ if (System.getProperty(gwt.devjar) == null) {
+testResult.addError(this, new Throwable(No GWT devjar property
found. Did you mean to run as a GWT JUnit Test instead of a JUnit Test?));
+ }
+ throw thowable;
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Some of the unit tests in CreateEventTest have listeners (issue1223801)
http://gwt-code-reviews.appspot.com/1223801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Some of the unit tests in CreateEventTest have listeners (issue1223801)
http://gwt-code-reviews.appspot.com/1223801/diff/1/2 File user/test/com/google/gwt/user/client/ui/CreateEventTest.java (right): http://gwt-code-reviews.appspot.com/1223801/diff/1/2#newcode738 user/test/com/google/gwt/user/client/ui/CreateEventTest.java:738: listener.assertReceived(); On 2010/12/16 15:35:19, jlabanca wrote: Should you add listener.cancel() here too? yes, I think so. I added them in the calling methods (seems it is in charge of knowing when the test is done using the listener.) http://gwt-code-reviews.appspot.com/1223801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Some of the unit tests in CreateEventTest have listeners (issue1223801)
LGTM http://gwt-code-reviews.appspot.com/1223801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add a warning in GWTTestCase to help users that accidentally run a GWT JUnit Test as a JUnit Test. (issue1224801)
LGTM http://gwt-code-reviews.appspot.com/1224801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fixing a bug in CellTable and CellList where we get an index out of bounds exception if we try t... (issue1225801)
Reviewers: pdr,
Description:
Fixing a bug in CellTable and CellList where we get an index out of
bounds exception if we try to access the keyboard selected element when
keyboard selection is disabled.
Please review this at http://gwt-code-reviews.appspot.com/1225801/show
Affected files:
M user/src/com/google/gwt/user/cellview/client/CellList.java
M user/src/com/google/gwt/user/cellview/client/CellTable.java
M
user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
Index: user/src/com/google/gwt/user/cellview/client/CellList.java
===
--- user/src/com/google/gwt/user/cellview/client/CellList.java (revision
9436)
+++ user/src/com/google/gwt/user/cellview/client/CellList.java (working
copy)
@@ -340,7 +340,7 @@
protected Element getKeyboardSelectedElement() {
// Do not use getRowElement() because that will flush the presenter.
int rowIndex = getKeyboardSelectedRow();
-if (childContainer.getChildCount() rowIndex) {
+if (rowIndex = 0 childContainer.getChildCount() rowIndex) {
return childContainer.getChild(rowIndex).cast();
}
return null;
Index: user/src/com/google/gwt/user/cellview/client/CellTable.java
===
--- user/src/com/google/gwt/user/cellview/client/CellTable.java (revision
9436)
+++ user/src/com/google/gwt/user/cellview/client/CellTable.java (working
copy)
@@ -988,7 +988,7 @@
// Do not use getRowElement() because that will flush the presenter.
int rowIndex = getKeyboardSelectedRow();
NodeListTableRowElement rows = tbody.getRows();
-if (rowIndex rows.getLength() columns.size() 0) {
+if (rowIndex = 0 rowIndex rows.getLength() columns.size()
0) {
TableRowElement tr = rows.getItem(rowIndex);
TableCellElement td = tr.getCells().getItem(keyboardSelectedColumn);
return getCellParent(td);
Index:
user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
===
---
user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
(revision 9436)
+++
user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
(working copy)
@@ -25,6 +25,7 @@
import com.google.gwt.regexp.shared.MatchResult;
import com.google.gwt.regexp.shared.RegExp;
import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
+import
com.google.gwt.user.cellview.client.HasKeyboardSelectionPolicy.KeyboardSelectionPolicy;
import com.google.gwt.user.client.Window;
import com.google.gwt.view.client.ListDataProvider;
import com.google.gwt.view.client.Range;
@@ -143,6 +144,21 @@
assertEquals(test 10, items.get(0));
assertEquals(test 11, items.get(1));
assertEquals(test 12, items.get(2));
+ }
+
+ /**
+ * Test that we don't get any errors when keyboard selection is disabled.
+ */
+ public void testKeyboardSelectionPolicyDisabled() {
+AbstractHasDataString display = createAbstractHasData(new
TextCell());
+display.setRowData(createData(0, 10));
+display.getPresenter().flush();
+display.setKeyboardSelectionPolicy(KeyboardSelectionPolicy.DISABLED);
+
+assertNull(display.getKeyboardSelectedElement());
+display.resetFocusOnCell();
+display.setAccessKey('a');
+display.setTabIndex(1);
}
public void testResetFocus() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixing a bug in CellTable and CellList where we get an index out of bounds exception if we try t... (issue1225801)
On 2010/12/16 16:51:04, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1225801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Initial version of HTML5 Audio and Video (issue1195801)
On Wed, Dec 15, 2010 at 5:40 PM, jlaba...@google.com wrote:
LGTM
Don't forget test cases.
By which I'm sure John meant before you submit this.
You guys are doing an awesome job with the HTML5 stuff! I can't wait to
see this stuff in action.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004
File user/src/com/google/gwt/dom/client/MediaElement.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004#newcode178
user/src/com/google/gwt/dom/client/MediaElement.java:178: return
this.error;
What does this return if there is no error? Is it null or undefined?
Might be better to do return this.error || null just in case.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004#newcode309
user/src/com/google/gwt/dom/client/MediaElement.java:309: * controls
(e.g., for controlling play./pause, seek position, and volume),
replace e.g with such as. We avoid abbreviations because some
international users don't recognize them.
Also, play./pause should be play/pause.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004#newcode410
user/src/com/google/gwt/dom/client/MediaElement.java:410: * Causes
playback of the resource to be (re)started.
Does it restart or resume if it is already started? How about Causes
playback of the resource to be started or resumed.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4004#newcode516
user/src/com/google/gwt/dom/client/MediaElement.java:516: public final
native void setSrc(String url) /*-{
instead of setAttribute(), can we use this.src = url
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4007
File user/src/com/google/gwt/media/client/Audio.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4007#newcode68
user/src/com/google/gwt/media/client/Audio.java:68: public AudioElement
getAudioElement() {
Can we just override the return value of getElement()?
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008
File user/src/com/google/gwt/media/client/Video.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008#newcode68
user/src/com/google/gwt/media/client/Video.java:68: public VideoElement
getVideoElement() {
I suggest overriding the return value of getElement() instead of
creating a new method.
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4010
File user/src/com/google/gwt/media/dom/DOM.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1195801/diff/3001/4010#newcode18
user/src/com/google/gwt/media/dom/DOM.gwt.xml:18: inherits
name=com.google.gwt.media.dom.DOM/
Should inherit com.google.gwt.dom.DOM, not com.google.gwt.media.dom.DOM
http://gwt-code-reviews.appspot.com/1195801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9450 committed - warning bootstrap is broken
Revision: 9450 Author: ncha...@google.com Date: Thu Dec 16 09:46:38 2010 Log: warning bootstrap is broken http://code.google.com/p/google-web-toolkit/source/detail?r=9450 Modified: /wiki/BeanValidation.wiki === --- /wiki/BeanValidation.wiki Wed Dec 15 22:17:01 2010 +++ /wiki/BeanValidation.wiki Thu Dec 16 09:46:38 2010 @@ -26,6 +26,9 @@ Validator validator = Validation.buildDefaultValidatorFactory().getValidator(); SetConstraintViolationPerson violations = validator.validate(person); }}} + + +*WARNING* this step is broken, and about to change. Follow this pattern to create a Validator for the objects you want to validate on the client. (see [http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java SampleValidator.java]) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9451 committed - escape wikilink
Revision: 9451 Author: ncha...@google.com Date: Thu Dec 16 09:47:49 2010 Log: escape wikilink http://code.google.com/p/google-web-toolkit/source/detail?r=9451 Modified: /wiki/BeanValidation.wiki === --- /wiki/BeanValidation.wiki Thu Dec 16 09:46:38 2010 +++ /wiki/BeanValidation.wiki Thu Dec 16 09:47:49 2010 @@ -65,7 +65,7 @@ = Best Practices = * Use Groups to specify what constraints to run on the client - * Super source Validator that are not GWT compatible using NotGwtCompatibleValidator (see [http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/FutureValidatorForCalendar.java FutureValidatorForCalendar.java]) + * Super source Validator that are not GWT compatible using !NotGwtCompatibleValidator (see [http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/FutureValidatorForCalendar.java FutureValidatorForCalendar.java]) * = What is not supported = * XML configuration -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9453 committed - Fixing a bug in CellTable and CellList where we get an index out of bo...
Revision: 9453
Author: jlaba...@google.com
Date: Thu Dec 16 06:19:53 2010
Log: Fixing a bug in CellTable and CellList where we get an index out of
bounds exception if we try to access the keyboard selected element when
keyboard selection is disabled.
Review at http://gwt-code-reviews.appspot.com/1225801
Review by: p...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9453
Modified:
/trunk/user/src/com/google/gwt/user/cellview/client/CellList.java
/trunk/user/src/com/google/gwt/user/cellview/client/CellTable.java
/trunk/user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
===
--- /trunk/user/src/com/google/gwt/user/cellview/client/CellList.java Wed
Dec 1 05:40:20 2010
+++ /trunk/user/src/com/google/gwt/user/cellview/client/CellList.java Thu
Dec 16 06:19:53 2010
@@ -340,7 +340,7 @@
protected Element getKeyboardSelectedElement() {
// Do not use getRowElement() because that will flush the presenter.
int rowIndex = getKeyboardSelectedRow();
-if (childContainer.getChildCount() rowIndex) {
+if (rowIndex = 0 childContainer.getChildCount() rowIndex) {
return childContainer.getChild(rowIndex).cast();
}
return null;
===
--- /trunk/user/src/com/google/gwt/user/cellview/client/CellTable.java Fri
Dec 10 06:42:34 2010
+++ /trunk/user/src/com/google/gwt/user/cellview/client/CellTable.java Thu
Dec 16 06:19:53 2010
@@ -988,7 +988,7 @@
// Do not use getRowElement() because that will flush the presenter.
int rowIndex = getKeyboardSelectedRow();
NodeListTableRowElement rows = tbody.getRows();
-if (rowIndex rows.getLength() columns.size() 0) {
+if (rowIndex = 0 rowIndex rows.getLength() columns.size()
0) {
TableRowElement tr = rows.getItem(rowIndex);
TableCellElement td = tr.getCells().getItem(keyboardSelectedColumn);
return getCellParent(td);
===
---
/trunk/user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
Wed Dec 1 05:40:20 2010
+++
/trunk/user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
Thu Dec 16 06:19:53 2010
@@ -25,6 +25,7 @@
import com.google.gwt.regexp.shared.MatchResult;
import com.google.gwt.regexp.shared.RegExp;
import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
+import
com.google.gwt.user.cellview.client.HasKeyboardSelectionPolicy.KeyboardSelectionPolicy;
import com.google.gwt.user.client.Window;
import com.google.gwt.view.client.ListDataProvider;
import com.google.gwt.view.client.Range;
@@ -144,6 +145,21 @@
assertEquals(test 11, items.get(1));
assertEquals(test 12, items.get(2));
}
+
+ /**
+ * Test that we don't get any errors when keyboard selection is disabled.
+ */
+ public void testKeyboardSelectionPolicyDisabled() {
+AbstractHasDataString display = createAbstractHasData(new
TextCell());
+display.setRowData(createData(0, 10));
+display.getPresenter().flush();
+display.setKeyboardSelectionPolicy(KeyboardSelectionPolicy.DISABLED);
+
+assertNull(display.getKeyboardSelectedElement());
+display.resetFocusOnCell();
+display.setAccessKey('a');
+display.setTabIndex(1);
+ }
public void testResetFocus() {
IndexCellString cell = new IndexCellString();
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixing a bug in CellTable and CellList where we get an index out of bounds exception if we try t... (issue1225801)
committed as r9453 http://gwt-code-reviews.appspot.com/1225801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9454 committed - Cherry picking r9453 into release branch.
Revision: 9454
Author: jlaba...@google.com
Date: Thu Dec 16 07:24:08 2010
Log: Cherry picking r9453 into release branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9454
Modified:
/releases/2.1/user/src/com/google/gwt/user/cellview/client/CellList.java
/releases/2.1/user/src/com/google/gwt/user/cellview/client/CellTable.java
/releases/2.1/user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
===
---
/releases/2.1/user/src/com/google/gwt/user/cellview/client/CellList.java
Wed Dec 1 07:51:56 2010
+++
/releases/2.1/user/src/com/google/gwt/user/cellview/client/CellList.java
Thu Dec 16 07:24:08 2010
@@ -340,7 +340,7 @@
protected Element getKeyboardSelectedElement() {
// Do not use getRowElement() because that will flush the presenter.
int rowIndex = getKeyboardSelectedRow();
-if (childContainer.getChildCount() rowIndex) {
+if (rowIndex = 0 childContainer.getChildCount() rowIndex) {
return childContainer.getChild(rowIndex).cast();
}
return null;
===
---
/releases/2.1/user/src/com/google/gwt/user/cellview/client/CellTable.java
Wed Dec 1 07:51:56 2010
+++
/releases/2.1/user/src/com/google/gwt/user/cellview/client/CellTable.java
Thu Dec 16 07:24:08 2010
@@ -869,7 +869,7 @@
// Do not use getRowElement() because that will flush the presenter.
int rowIndex = getKeyboardSelectedRow();
NodeListTableRowElement rows = tbody.getRows();
-if (rowIndex rows.getLength() columns.size() 0) {
+if (rowIndex = 0 rowIndex rows.getLength() columns.size()
0) {
TableRowElement tr = rows.getItem(rowIndex);
TableCellElement td = tr.getCells().getItem(keyboardSelectedColumn);
return getCellParent(td);
===
---
/releases/2.1/user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
Wed Dec 1 07:51:56 2010
+++
/releases/2.1/user/test/com/google/gwt/user/cellview/client/AbstractHasDataTestBase.java
Thu Dec 16 07:24:08 2010
@@ -25,6 +25,7 @@
import com.google.gwt.regexp.shared.MatchResult;
import com.google.gwt.regexp.shared.RegExp;
import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
+import
com.google.gwt.user.cellview.client.HasKeyboardSelectionPolicy.KeyboardSelectionPolicy;
import com.google.gwt.user.client.Window;
import com.google.gwt.view.client.ListDataProvider;
import com.google.gwt.view.client.Range;
@@ -144,6 +145,21 @@
assertEquals(test 11, items.get(1));
assertEquals(test 12, items.get(2));
}
+
+ /**
+ * Test that we don't get any errors when keyboard selection is disabled.
+ */
+ public void testKeyboardSelectionPolicyDisabled() {
+AbstractHasDataString display = createAbstractHasData(new
TextCell());
+display.setRowData(createData(0, 10));
+display.getPresenter().flush();
+display.setKeyboardSelectionPolicy(KeyboardSelectionPolicy.DISABLED);
+
+assertNull(display.getKeyboardSelectedElement());
+display.resetFocusOnCell();
+display.setAccessKey('a');
+display.setTabIndex(1);
+ }
public void testResetFocus() {
IndexCellString cell = new IndexCellString();
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add a warning in GWTTestCase to help users that accidentally run a GWT JUnit Test as a JUnit Test. (issue1224801)
Thanks for looking into this. A couple of questions/comments before I give the LGTM.. http://gwt-code-reviews.appspot.com/1224801/diff/1/2 File user/src/com/google/gwt/junit/client/GWTTestCase.java (right): http://gwt-code-reviews.appspot.com/1224801/diff/1/2#newcode445 user/src/com/google/gwt/junit/client/GWTTestCase.java:445: // Check to see if gwt.devjar is null. If so, notify the Is this system property required? http://gwt-code-reviews.appspot.com/1224801/diff/1/2#newcode448 user/src/com/google/gwt/junit/client/GWTTestCase.java:448: testResult.addError(this, new Throwable(No GWT devjar property found. Did you mean to run as a GWT JUnit Test instead of a JUnit Test?)); Suggestion: No GWT devjar property found. Did you mean to run as a GWT JUnit Test instead of a JUnit Test? -- The gwt.devjar property has not been set. If you are using the Google Plugin for Eclipse, you should be running this test as a 'GWT JUnit Test', not a plain 'JUnit Test'. http://gwt-code-reviews.appspot.com/1224801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9455 committed - Merge pt_PT fix for AD era name into 2.1 release branch.
Revision: 9455
Author: j...@google.com
Date: Thu Dec 16 09:38:49 2010
Log: Merge pt_PT fix for AD era name into 2.1 release branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9455
Modified:
/releases/2.1/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt_PT.properties
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
===
---
/releases/2.1/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt_PT.properties
Fri Feb 26 11:54:15 2010
+++
/releases/2.1/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt_PT.properties
Thu Dec 16 09:38:49 2010
@@ -8,7 +8,7 @@
# CLDR version 1.7.1 is used in this generation.
eras = a.C., d.C.
-eraNames = Antes de Cristo, Ano do Senhor
+eraNames = Antes de Cristo, Depois de Cristo
narrowMonths = J, F, M, A, M, J, J, A, S, O, N, D
months = Janeiro, Fevereiro, Março, Abril, Maio, Junho, Julho, Agosto,
Setembro, Outubro, Novembro, Dezembro
shortMonths = Jan, Fev, Mar, Abr, Mai, Jun, Jul, Ago, Set, Out, Nov, Dez
===
---
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Tue Dec 14 08:25:33 2010
+++
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Thu Dec 16 09:38:49 2010
@@ -34,14 +34,6 @@
public String dateFormatMedium() {
return d 'de' MMM 'de' ;
}
-
- @Override
- public String[] erasFull() {
-return new String[] {
-Antes de Cristo,
-Ano do Senhor
-};
- }
@Override
public int firstDayOfTheWeek() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9456 committed - Change era names in pt_PT to match pt (a Portuguese specialist replied...
Revision: 9456
Author: j...@google.com
Date: Thu Dec 16 09:22:20 2010
Log: Change era names in pt_PT to match pt (a Portuguese specialist replied
it should also
be changed).
Patch by: jat
Review by: pdr
http://code.google.com/p/google-web-toolkit/source/detail?r=9456
Modified:
/trunk/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt_PT.properties
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
===
---
/trunk/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt_PT.properties
Fri Feb 26 11:54:15 2010
+++
/trunk/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt_PT.properties
Thu Dec 16 09:22:20 2010
@@ -8,7 +8,7 @@
# CLDR version 1.7.1 is used in this generation.
eras = a.C., d.C.
-eraNames = Antes de Cristo, Ano do Senhor
+eraNames = Antes de Cristo, Depois de Cristo
narrowMonths = J, F, M, A, M, J, J, A, S, O, N, D
months = Janeiro, Fevereiro, Março, Abril, Maio, Junho, Julho, Agosto,
Setembro, Outubro, Novembro, Dezembro
shortMonths = Jan, Fev, Mar, Abr, Mai, Jun, Jul, Ago, Set, Out, Nov, Dez
===
---
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Tue Dec 14 07:49:52 2010
+++
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Thu Dec 16 09:22:20 2010
@@ -34,14 +34,6 @@
public String dateFormatMedium() {
return d 'de' MMM 'de' ;
}
-
- @Override
- public String[] erasFull() {
-return new String[] {
-Antes de Cristo,
-Ano do Senhor
-};
- }
@Override
public int firstDayOfTheWeek() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9457 committed - Removing the 2.1.1 tag.
Revision: 9457 Author: p...@google.com Date: Thu Dec 16 12:56:48 2010 Log: Removing the 2.1.1 tag. http://code.google.com/p/google-web-toolkit/source/detail?r=9457 Deleted: /tags/2.1.1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9458 committed - Adding the 2.1.1 tag.
Revision: 9458 Author: p...@google.com Date: Thu Dec 16 12:57:29 2010 Log: Adding the 2.1.1 tag. http://code.google.com/p/google-web-toolkit/source/detail?r=9458 Added: /tags/2.1.1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Experimental framework for generator result caching in dev mode. (issue1227801)
Reviewers: tobyr, zundel, robertvawter, Description: Experimental framework for generator result caching in dev mode. Please review this at http://gwt-code-reviews.appspot.com/1227801/show Affected files: A dev/core/src/com/google/gwt/core/ext/GeneratorContextExt.java A dev/core/src/com/google/gwt/core/ext/GeneratorExt.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/cfg/Rule.java M dev/core/src/com/google/gwt/dev/cfg/RuleFail.java M dev/core/src/com/google/gwt/dev/cfg/RuleGenerateWith.java M dev/core/src/com/google/gwt/dev/cfg/RuleReplaceWith.java M dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java A dev/core/src/com/google/gwt/dev/javac/rebind/CachedPropertyInformation.java A dev/core/src/com/google/gwt/dev/javac/rebind/CachedRebindResult.java A dev/core/src/com/google/gwt/dev/javac/rebind/RebindCache.java A dev/core/src/com/google/gwt/dev/javac/rebind/RebindResult.java A dev/core/src/com/google/gwt/dev/javac/rebind/RebindStatus.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/shell/ShellModuleSpaceHost.java M dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java A dev/core/src/com/google/gwt/dev/util/arg/OptionEnableGeneratorResultCaching.java M user/src/com/google/gwt/junit/JUnitShell.java M user/src/com/google/gwt/resources/ext/AbstractResourceGenerator.java M user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java A user/src/com/google/gwt/resources/ext/HasFindableResourceDependencies.java M user/src/com/google/gwt/resources/ext/ResourceContext.java M user/src/com/google/gwt/resources/ext/ResourceGenerator.java M user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java M user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java M user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java M user/src/com/google/gwt/resources/rebind/context/StaticResourceContext.java M user/src/com/google/gwt/resources/rg/CssResourceGenerator.java M user/src/com/google/gwt/resources/rg/DataResourceGenerator.java M user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java M user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java M user/src/com/google/gwt/resources/rg/TextResourceGenerator.java M user/src/com/google/gwt/rpc/rebind/RpcProxyCreator.java M user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java M user/src/com/google/gwt/user/rebind/rpc/ServiceInterfaceProxyGenerator.java M user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java M user/test/com/google/gwt/resources/rg/CssTestCase.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
http://gwt-code-reviews.appspot.com/1221801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re-enable a few style tests now that old linux hosted mode is gone (issue1228801)
Reviewers: zundel,
Description:
Re-enable a few style tests now that old linux hosted mode is gone
Please review this at http://gwt-code-reviews.appspot.com/1228801/show
Affected files:
M user/test/com/google/gwt/dom/client/StyleTest.java
Index: user/test/com/google/gwt/dom/client/StyleTest.java
===
--- user/test/com/google/gwt/dom/client/StyleTest.java (revision 9425)
+++ user/test/com/google/gwt/dom/client/StyleTest.java (working copy)
@@ -85,14 +85,13 @@
style.setCursor(Cursor.HELP);
assertEquals(Cursor.HELP, style.getCursor());
-// These aren't supported on old mozilla, so testing them will break.
-// TODO: re-enable these cases when we finally drop linux hosted mode.
-/*
+// Note, this test will fail on old mozilla due to unsupported style
style.setCursor(Cursor.COL_RESIZE);
assertEquals(Cursor.COL_RESIZE, style.getCursor());
+
+// Note, this test will fail on old mozilla due to unsupported style
style.setCursor(Cursor.ROW_RESIZE);
assertEquals(Cursor.ROW_RESIZE, style.getCursor());
-*/
}
public void testDisplay() {
@@ -106,12 +105,9 @@
style.setDisplay(Display.INLINE);
assertEquals(Display.INLINE, style.getDisplay());
-// Not supported on old mozilla, so testing it will break.
-// TODO: re-enable these cases when we finally drop linux hosted mode.
-/*
+// Note, this test will fail on old mozilla due to unsupported style
style.setDisplay(Display.INLINE_BLOCK);
assertEquals(Display.INLINE_BLOCK, style.getDisplay());
-*/
}
public void testFontStyle() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)
Reviewers: zundel,
Description:
Re-enable XML parse test, which was previously failing in one Safari
configuration in Production Mode in the 1.5 release branch
Please review this at http://gwt-code-reviews.appspot.com/1229801/show
Affected files:
M user/test/com/google/gwt/xml/client/XMLTest.java
Index: user/test/com/google/gwt/xml/client/XMLTest.java
===
--- user/test/com/google/gwt/xml/client/XMLTest.java(revision 9425)
+++ user/test/com/google/gwt/xml/client/XMLTest.java(working copy)
@@ -321,12 +321,10 @@
}
/**
- * This test is failing on one Safari configuration in web mode in the
1.5
- * release branch, but it passes in all other configurations and in the
trunk.
- * The files in the xml package are identical between the trunk and the
1.5
- * branch.
+ * At one point, this test was failing on one Safari configuration in
+ * Production Mode in the 1.5 release branch.
*/
- public void disabledTestParse() {
+ public void testParse() {
Document docA = XMLParser.parse(!--hello-- a spam=\ham\\n
?pi hello ?dfgdfg b/\t/a);
Document docB = XMLParser.createDocument();
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
Addressed feedback and moved StyleTest and XMLTest to separate issues:
Re-enable a few style tests now that old linux hosted mode is gone
http://gwt-code-reviews.appspot.com/1228801
Re-enable XML parse test, which was previously failing in one Safari
configuration in Production Mode in the 1.5 release branch
http://gwt-code-reviews.appspot.com/1229801
http://gwt-code-reviews.appspot.com/1221801/diff/1/35
File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/35#newcode195
user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:195: * In
hosted-mode, the field's declaring class is written to the stream to
On 2010/12/15 23:49:34, zundel wrote:
s/hosted-mode/Development Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/40
File
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode25
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:25:
* SafeHtml utilities whose implementation differs between hosted and
Production
On 2010/12/15 23:49:34, zundel wrote:
s/hosted/Development
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode29
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:29:
* This class has a super-source peer that provides the web-mode
implementation.
On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/41
File user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode71
user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:71: *
details). For performance reasons, this check is not performed in prod
mode
On 2010/12/15 23:49:34, zundel wrote:
s/prod/Production Mode ?
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode76
user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:76: * @throws
IllegalArgumentException if not running in prod mode and {...@code
On 2010/12/15 23:49:34, zundel wrote:
s/prod/Production Mode ?
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/52
File
user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/52#newcode207
user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java:207:
// hosted
On 2010/12/15 23:49:34, zundel wrote:
Development Mode... although this isn't a javadoc comment
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/54
File user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode60
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:60: //
Try something you can't do in web-mode (JRE code)
On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode63
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:63: //
Try something you can't do in web-mode (server code)
On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/59
File user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/59#newcode24
user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java:24: *
Development Mode due to browser inconsistencies; however it should run
in web
On 2010/12/15 23:49:34, zundel wrote:
s/web/Production
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/61
File user/test/com/google/gwt/dom/client/StyleTest.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/61#newcode110
user/test/com/google/gwt/dom/client/StyleTest.java:110: // TODO:
re-enable these cases when we finally drop linux Development Mode.
On 2010/12/15 23:49:34, zundel wrote:
Hey, we can probably re-enable these now!
I'll move this change to a separate patch
http://gwt-code-reviews.appspot.com/1221801/diff/1/76
File user/test/com/google/gwt/xml/client/XMLTest.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/76#newcode328
user/test/com/google/gwt/xml/client/XMLTest.java:328: */
On 2010/12/15 23:49:34, zundel wrote:
umm, maybe time to re-enable this test too?
I'll create a separate patch to re-enable this test
http://gwt-code-reviews.appspot.com/1221801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Replace most user/developer visible references to hosted/web mode with Development/Production Mode (issue1221801)
LGTM
thanks for looking into the tests as well
On 2010/12/16 21:59:57, fredsa wrote:
Addressed feedback and moved StyleTest and XMLTest to separate issues:
Re-enable a few style tests now that old linux hosted mode is gone
http://gwt-code-reviews.appspot.com/1228801
Re-enable XML parse test, which was previously failing in one Safari
configuration in Production Mode in the 1.5 release branch
http://gwt-code-reviews.appspot.com/1229801
http://gwt-code-reviews.appspot.com/1221801/diff/1/35
File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/35#newcode195
user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:195: *
In
hosted-mode, the field's declaring class is written to the stream to
On 2010/12/15 23:49:34, zundel wrote:
s/hosted-mode/Development Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/40
File
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode25
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:25:
*
SafeHtml utilities whose implementation differs between hosted and
Production
On 2010/12/15 23:49:34, zundel wrote:
s/hosted/Development
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/40#newcode29
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java:29:
* This
class has a super-source peer that provides the web-mode
implementation.
On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/41
File user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode71
user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:71: *
details). For
performance reasons, this check is not performed in prod mode
On 2010/12/15 23:49:34, zundel wrote:
s/prod/Production Mode ?
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/41#newcode76
user/src/com/google/gwt/safehtml/shared/SafeHtmlUtils.java:76: *
@throws
IllegalArgumentException if not running in prod mode and {...@code
On 2010/12/15 23:49:34, zundel wrote:
s/prod/Production Mode ?
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/52
File
user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/52#newcode207
user/test/com/google/gwt/core/ext/linker/impl/SelectionScriptLinkerUnitTest.java:207:
// hosted
On 2010/12/15 23:49:34, zundel wrote:
Development Mode... although this isn't a javadoc comment
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/54
File user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode60
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:60: //
Try
something you can't do in web-mode (JRE code)
On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/54#newcode63
user/test/com/google/gwt/dev/jjs/scriptonly/ScriptOnlyTest.java:63: //
Try
something you can't do in web-mode (server code)
On 2010/12/15 23:49:34, zundel wrote:
s/web-mode/Production Mode
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/59
File user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java
(right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/59#newcode24
user/test/com/google/gwt/dev/jjs/test/JsStaticEvalTest.java:24: *
Development
Mode due to browser inconsistencies; however it should run in web
On 2010/12/15 23:49:34, zundel wrote:
s/web/Production
Done.
http://gwt-code-reviews.appspot.com/1221801/diff/1/61
File user/test/com/google/gwt/dom/client/StyleTest.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/61#newcode110
user/test/com/google/gwt/dom/client/StyleTest.java:110: // TODO:
re-enable these
cases when we finally drop linux Development Mode.
On 2010/12/15 23:49:34, zundel wrote:
Hey, we can probably re-enable these now!
I'll move this change to a separate patch
http://gwt-code-reviews.appspot.com/1221801/diff/1/76
File user/test/com/google/gwt/xml/client/XMLTest.java (right):
http://gwt-code-reviews.appspot.com/1221801/diff/1/76#newcode328
user/test/com/google/gwt/xml/client/XMLTest.java:328: */
On 2010/12/15 23:49:34, zundel wrote:
umm, maybe time to re-enable this test too?
I'll create a separate patch to re-enable this test
http://gwt-code-reviews.appspot.com/1221801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Re-enable XML parse test, which was previously failing in one Safari configuration in Production... (issue1229801)
Did you try running this test on a Mac? On 2010/12/16 21:57:24, fredsa wrote: http://gwt-code-reviews.appspot.com/1229801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Re-enable a few style tests now that old linux hosted mode is gone (issue1228801)
So this patch just backs out r5374. Can we be more specific in the comment and say that the error was pre gecko 1.8? (Mozilla 1.7 was linux hosted mode) (checked with svn diff -c 5374 user/test/com/google/gwt/dom/client/StyleTest.java) here is the log r5374 | j...@google.com | 2009-05-14 11:07:35 -0400 (Thu, 14 May 2009) | 7 lines Un-breaks the build by: - removing a couple of tests from StyleTest that use property values unsupported by linux hosted mode. - fixing a subtle breakage introduced in DecoratedPopupPanel by the removal of a 'super.' prefix. Review: rice (DecoratedPopupPanel), jlabanca (TBR, for StyleTest) http://gwt-code-reviews.appspot.com/1228801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Make the logging framework provide a default uncaught exception handler. (issue1223802)
Reviewers: unnurg, burdon_google.com,
Description:
Make the logging framework provide a default uncaught exception handler.
Please review this at http://gwt-code-reviews.appspot.com/1223802/show
Affected files:
M user/src/com/google/gwt/logging/client/LogConfiguration.java
Index: user/src/com/google/gwt/logging/client/LogConfiguration.java
===
--- user/src/com/google/gwt/logging/client/LogConfiguration.java (revision
9459)
+++ user/src/com/google/gwt/logging/client/LogConfiguration.java (working
copy)
@@ -18,6 +18,7 @@
import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.core.client.GWT;
+import com.google.gwt.core.client.GWT.UncaughtExceptionHandler;
import com.google.gwt.user.client.Window.Location;
import com.google.gwt.user.client.ui.HasWidgets;
@@ -146,5 +147,16 @@
public void onModuleLoad() {
impl.configureClientSideLogging();
+
+if (impl.loggingIsEnabled()) {
+ if (GWT.getUncaughtExceptionHandler() == null) {
+final Logger log =
Logger.getLogger(LogConfiguration.class.getName());
+GWT.setUncaughtExceptionHandler(new UncaughtExceptionHandler() {
+ public void onUncaughtException(Throwable e) {
+log.log(Level.SEVERE, e.getMessage(), e);
+ }
+});
+ }
+}
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make the logging framework provide a default uncaught exception handler. (issue1223802)
Unnur, is there a test I can extend for this? http://gwt-code-reviews.appspot.com/1223802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Added the no-arg add() widget method to the HTMLPanel. (issue1226801)
LGTM http://gwt-code-reviews.appspot.com/1226801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: New Google Groups apparent with GWT ?
I second this request for info :) We are using TinyMCE right now and worked hard to get it to integrate; but we don't really like it and there are oddities that we still deal with sometimes. If someone has sample integration code that could be shared, we would appreciate being able to see it to jump start our efforts. I just looked at the closure editor and I like the demo and how it is wired together on the page - much better than the hoops we have to jump through for the tinyMCE. Chris On Dec 14, 6:33 pm, karthik reddy karthik.ele...@gmail.com wrote: Are there any code samples/documentation of integrating Closure Library widgets (like rich text editor etc) with GWT. if this integration can be done seamlessly with no performance hit this would help GWT developers get the best of both worlds(GWT and Closure Library) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Basic MessageIntrpolation. (issue1230801)
Reviewers: rchandia, Description: Basic MessageIntrpolation. Refactored the bootstrap to hook via ValidatorFactory [JSR 303 TCK Result] 44 of 258 (17.05%) Pass with 12 Failures and 12 Errors. Please review this at http://gwt-code-reviews.appspot.com/1230801/show Affected files: M samples/common.ant.xml A samples/validation/ValidationMesssges-i18n M samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml A samples/validation/src/com/google/gwt/sample/validation/client/CustomValidationMessagesResolver.java D samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java A samples/validation/src/com/google/gwt/sample/validation/client/SampleValidatorFactory.java A samples/validation/src/com/google/gwt/sample/validation/client/ValidationMessages.java A samples/validation/src/com/google/gwt/sample/validation/client/ValidationMessages.properties M samples/validation/src/com/google/gwt/sample/validation/shared/Person.java A samples/validation/src/log4j.properties A samples/validationtck/src/log4j.properties A samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/tests/messageinterpolation/MessageInterpolationTest.java M samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTest.gwt.xml D samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTestValidator.java A samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTestValidatorFactory.java M samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/groups/TckTest.gwt.xml D samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/groups/TckTestValidator.java A samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/groups/TckTestValidatorFactory.java M samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance/TckTest.gwt.xml D samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance/TckTestValidator.java A samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance/TckTestValidatorFactory.java A samples/validationtck/test/com/google/gwt/sample/validationtck/messageinterpolation/MessageInterpolationGwtSuite.java A samples/validationtck/test/com/google/gwt/sample/validationtck/messageinterpolation/MessageInterpolationTest.java A samples/validationtck/test/com/google/gwt/sample/validationtck/messageinterpolation/TckTest.gwt.xml A samples/validationtck/test/com/google/gwt/sample/validationtck/messageinterpolation/TckTestValidatorFactory.java A samples/validationtck/test/com/google/gwt/sample/validationtck/messageinterpolation/TckUserValidationMessageProvider.java A samples/validationtck/test/com/google/gwt/sample/validationtck/messageinterpolation/ValidationMessages.java A samples/validationtck/test/com/google/gwt/sample/validationtck/messageinterpolation/ValidationMessages.properties A samples/validationtck/test/com/google/gwt/sample/validationtck/messageinterpolation/ValidationMessages_de.properties M samples/validationtck/test/com/google/gwt/sample/validationtck/metadata/TckTest.gwt.xml D samples/validationtck/test/com/google/gwt/sample/validationtck/metadata/TckTestValidator.java A samples/validationtck/test/com/google/gwt/sample/validationtck/metadata/TckTestValidatorFactory.java M samples/validationtck/test/com/google/gwt/sample/validationtck/validation/TckTest.gwt.xml D samples/validationtck/test/com/google/gwt/sample/validationtck/validation/TckTestValidator.java A samples/validationtck/test/com/google/gwt/sample/validationtck/validation/TckTestValidatorFactory.java M samples/validationtck/test/com/google/gwt/sample/validationtck/validatorfactory/TckTest.gwt.xml D samples/validationtck/test/com/google/gwt/sample/validationtck/validatorfactory/TckTestValidator.java A samples/validationtck/test/com/google/gwt/sample/validationtck/validatorfactory/TckTestValidatorFactory.java M user/build.xml M user/src/com/google/gwt/validation/Validation.gwt.xml A user/src/com/google/gwt/validation/client/AbstractGwtValidatorFactory.java A user/src/com/google/gwt/validation/client/AbstractValidationMessageResolver.java D user/src/com/google/gwt/validation/client/AbstractValidator.java M user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java M user/src/com/google/gwt/validation/client/GwtValidatorContext.java D user/src/com/google/gwt/validation/client/GwtValidatorFactory.java A user/src/com/google/gwt/validation/client/NullUserValidationMessageResolver.java A user/src/com/google/gwt/validation/client/ProviderValidationMessageResolver.java A user/src/com/google/gwt/validation/client/UserValidationMessagesResolver.java A
[gwt-contrib] [google-web-toolkit] r9460 committed - Link to CL
Revision: 9460 Author: ncha...@google.com Date: Thu Dec 16 21:53:00 2010 Log: Link to CL http://code.google.com/p/google-web-toolkit/source/detail?r=9460 Modified: /wiki/BeanValidation.wiki === --- /wiki/BeanValidation.wiki Thu Dec 16 09:47:49 2010 +++ /wiki/BeanValidation.wiki Thu Dec 16 21:53:00 2010 @@ -28,8 +28,7 @@ }}} -*WARNING* this step is broken, and about to change. - +*WARNING* this step is broken, and about to change. (see [http://gwt-code-reviews.appspot.com/1230801 Code Review 1230801]) Follow this pattern to create a Validator for the objects you want to validate on the client. (see [http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java SampleValidator.java]) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Handle composite constraints. (issue1231801)
Reviewers: rchandia, Description: Handle composite constraints. [JSR 303 TCK Result] 36 of 258 (13.95%) Pass with 15 Failures and 16 Errors. Please review this at http://gwt-code-reviews.appspot.com/1231801/show Affected files: M samples/validation/src/com/google/gwt/sample/validation/shared/Address.java A samples/validation/src/com/google/gwt/sample/validation/shared/Zip.java A samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/constraintcomposition/ConstraintCompositionGwtSuite.java A samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/constraintcomposition/ConstraintCompositionTest.java A samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/constraintcomposition/TckTest.gwt.xml A samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/constraintcomposition/TckTestValidator.java M user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
