[gwt-contrib] Re: Comment on RpcAuth in google-web-toolkit
Comment by kujans...@googlemail.com: released in 2.3 http://code.google.com/webtoolkit/doc/latest/DevGuideSecurityRpcXsrf.html For more information: http://code.google.com/p/google-web-toolkit/wiki/RpcAuth -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Calculates result of getSourceName() one time, so reuse because of CU cache. (issue1438801)
http://gwt-code-reviews.appspot.com/1438801/diff/3001/dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java File dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java (right): http://gwt-code-reviews.appspot.com/1438801/diff/3001/dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java#newcode29 dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java:29: static final String DUMMY_NAME = com/example/DeadBeef; This should be no different than before, but could you add a test that makes sure that internalName is transformed to sourceName the way we expect? http://gwt-code-reviews.appspot.com/1438801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Calculates result of getSourceName() one time, so reuse because of CU cache. (issue1438801)
LGTM http://gwt-code-reviews.appspot.com/1438801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] rfc on 6068 fix
Bob V is the authority here, but he's on vacation this week. On Sun, May 8, 2011 at 7:08 AM, Patrick Julien pjul...@gmail.com wrote: Here is what I am planning to do to fix issue 6068 http://code.google.com/p/google-web-toolkit/issues/detail?id=6068 1. Add to BeanMethod.java (package com.google.web.bindery.autobean.vm.impl;) an TO_ARRAY value 2. Add to JBeanMethod.java (com.google.web.bindery.autobean.gwt.rebind.model;) an TO_ARRAY value 3. in AutoBeanFactoryGenerator#writeShim (package com.google.web.bindery.autobean.gwt.rebind;) handle the TO_ARRAY case by checking the: a. if the type is assignable to Collection? b. Determine if toArray has one of two supported method signatures in Collection? c. Generate code that assigns each element of the newly created array by wrapping it first 4. Add a unit test to check for unfrozen beans. a. Get a collection of AutoBeans b. assert they are frozen c. Initialize an ArrayList using this other collection d. Assert the objects stored the second ArrayList are unfrozen Open Questions: 1. Should I try to handle immutable collections, i.e., Collections.unmodifiable* or guava's Immutable*? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10162 committed - Calculates result of getSourceName() one time, so reuse because of CU ...
Revision: 10162
Author: scheg...@google.com
Date: Mon May 9 07:42:14 2011
Log: Calculates result of getSourceName() one time, so reuse because
of CU cache.
Prepares SAXParserFActory one time, so avoids expensive ClassLoader lookups.
Review at http://gwt-code-reviews.appspot.com/1438801
Review by: sco...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10162
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/CompiledClass.java
/trunk/dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/javac/CompiledClass.java Thu Apr
28 06:57:23 2011
+++ /trunk/dev/core/src/com/google/gwt/dev/javac/CompiledClass.java Mon
May 9 07:42:14 2011
@@ -38,6 +38,7 @@
private final CompiledClass enclosingClass;
private final String internalName;
+ private final String sourceName;
private final boolean isLocal;
private transient TypeData typeData;
private CompilationUnit unit;
@@ -65,6 +66,7 @@
String internalName) {
this.enclosingClass = enclosingClass;
this.internalName = StringInterner.get().intern(internalName);
+this.sourceName =
StringInterner.get().intern(InternalName.toSourceName(internalName));
this.cacheToken = diskCache.writeByteArray(classBytes);
this.isLocal = isLocal;
}
@@ -109,7 +111,7 @@
* Returns the qualified source name, e.g. {@code java.util.Map.Entry}.
*/
public String getSourceName() {
-return
StringInterner.get().intern(InternalName.toSourceName(internalName));
+return sourceName;
}
public TypeData getTypeData() {
===
--- /trunk/dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java
Mon Feb 7 11:36:28 2011
+++ /trunk/dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java
Mon May 9 07:42:14 2011
@@ -26,7 +26,15 @@
static byte[] dummyByteCode = {
(byte) 0xDE, (byte) 0xAD, (byte)0xBE, (byte)0xEF
};
- static final String DUMMY_NAME = com.example.DeadBeef;
+ static final String DUMMY_NAME = com/example/DeadBeef;
+
+ /**
+ * Test for {@link CompiledClass#getSourceName()}.
+ */
+ public void testSourceName() throws Exception {
+CompiledClass compiledClass = new CompiledClass(dummyByteCode, null,
false, DUMMY_NAME);
+assertEquals(com.example.DeadBeef, compiledClass.getSourceName());
+ }
public void testCompiledClassSerialization() throws Exception {
CompiledClass writeObject = new CompiledClass(dummyByteCode, null,
false, DUMMY_NAME);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Disabling test for null on getBrowserById for DOM elements without DTD when running on Chrome 12 (issue1443801)
Reviewers: jat, Frank,
Description:
Disabling test for null on getBrowserById for DOM elements without DTD
when running on Chrome 12
Please review this at http://gwt-code-reviews.appspot.com/1443801/
Affected files:
M user/test/com/google/gwt/xml/client/XMLTest.java
Index: user/test/com/google/gwt/xml/client/XMLTest.java
===
--- user/test/com/google/gwt/xml/client/XMLTest.java(revision 9869)
+++ user/test/com/google/gwt/xml/client/XMLTest.java(working copy)
@@ -217,8 +217,8 @@
// we didn't define a dtd, so no id for us
Element e1NodeDirect = d.getElementById(e1Id);
-// Chrome 11 fails to implement this behavior
-if (!Window.Navigator.getUserAgent().contains(Chrome/11.)) {
+// Chrome 11 and 12 fail to implement this behavior
+if (!Window.Navigator.getUserAgent().matches(.*Chrome/1[12]\\..*)) {
assertNull(e1NodeDirect);
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Minor refactoring of dashboard interfaces in GWT. I'd made these changes this week in another ... (issue1439801)
http://gwt-code-reviews.appspot.com/1439801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10164 committed - Edited wiki page BeanValidation through web user interface.
Revision: 10164 Author: ncha...@google.com Date: Mon May 9 12:10:10 2011 Log: Edited wiki page BeanValidation through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=10164 Modified: /wiki/BeanValidation.wiki === --- /wiki/BeanValidation.wiki Fri Mar 4 11:49:07 2011 +++ /wiki/BeanValidation.wiki Mon May 9 12:10:10 2011 @@ -2,7 +2,7 @@ #labels jsr303,beanvalidation =WARNING= -GWT validaiton is still half baked. The API will change. *MANY* things still just don't work. +EXPERIMENTAL. The API may change. *SOME* things still just don't work. = Introduction = -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10165 committed - Introduces read only task view with an edit button. Gets around...
Revision: 10165
Author: rj...@google.com
Date: Mon May 9 09:40:33 2011
Log: Introduces read only task view with an edit button. Gets around
problems when we try to edit a TaskProxyImpl, which is unpossible.
http://code.google.com/p/google-web-toolkit/source/detail?r=10165
Added:
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/activity/TaskReadView.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/tablet/TabletTaskReadView.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/tablet/TabletTaskReadView.ui.xml
Modified:
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImpl.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
===
--- /dev/null
+++
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/activity/TaskReadView.java
Mon May 9 09:40:33 2011
@@ -0,0 +1,46 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.sample.mobilewebapp.client.activity;
+
+import com.google.gwt.editor.client.Editor;
+import com.google.gwt.editor.client.SimpleBeanEditorDriver;
+import com.google.gwt.sample.mobilewebapp.shared.TaskProxy;
+import com.google.gwt.user.client.ui.IsWidget;
+
+public interface TaskReadView extends IsWidget, EditorTaskProxy {
+
+ /**
+ * The presenter for this view.
+ */
+ public static interface Presenter {
+/**
+ * Switch to an edit view of this task.
+ */
+void editTask();
+ }
+
+ /**
+ * Get the driver used to edit tasks in the view.
+ */
+ SimpleBeanEditorDriverTaskProxy, ? getEditorDriver();
+
+ /**
+ * Set the {@link Presenter} for this view.
+ *
+ * @param presenter the presenter
+ */
+ void setPresenter(Presenter presenter);
+}
===
--- /dev/null
+++
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/tablet/TabletTaskReadView.java
Mon May 9 09:40:33 2011
@@ -0,0 +1,99 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.sample.mobilewebapp.client.tablet;
+
+import com.google.gwt.core.client.GWT;
+import com.google.gwt.editor.client.SimpleBeanEditorDriver;
+import com.google.gwt.event.dom.client.ClickEvent;
+import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.sample.mobilewebapp.client.activity.TaskEditView;
+import com.google.gwt.sample.mobilewebapp.client.activity.TaskReadView;
+import com.google.gwt.sample.mobilewebapp.shared.TaskProxy;
+import com.google.gwt.uibinder.client.UiBinder;
+import com.google.gwt.uibinder.client.UiField;
+import com.google.gwt.user.client.ui.Button;
+import com.google.gwt.user.client.ui.Composite;
+import com.google.gwt.user.client.ui.DateLabel;
+import com.google.gwt.user.client.ui.Label;
+import com.google.gwt.user.client.ui.Widget;
+
+/**
+ * View used to edit a task.
+ */
+public class TabletTaskReadView extends Composite implements TaskReadView {
+
+ /**
+ * Editor driver for this view.
+ */
+ interface Driver extends SimpleBeanEditorDriverTaskProxy,
TabletTaskReadView {
+ }
+
+ /**
+ * The UiBinder interface.
+ */
+ interface TabletTaskReadViewUiBinder extends UiBinderWidget,
TabletTaskReadView {
+ }
+
+ /**
+ * The UiBinder used to generate the view.
+ */
+ private static TabletTaskReadViewUiBinder uiBinder =
GWT.create(TabletTaskReadViewUiBinder.class);
+
+ @UiField
+ DateLabel dueDateEditor;
+ @UiField
+ Label nameEditor;
+ @UiField
+ Label notesEditor;
+
+ /**
+ * The text box used to save changes or create a new task.
+ */
+ @UiField
+
[gwt-contrib] [google-web-toolkit] r10166 committed - Fix the transition direction between read and task views
Revision: 10166
Author: rj...@google.com
Date: Mon May 9 10:10:43 2011
Log: Fix the transition direction between read and task views
http://code.google.com/p/google-web-toolkit/source/detail?r=10166
Modified:
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImpl.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImplMobile.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileWebAppShellMobile.java
===
---
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImpl.java
Mon May 9 09:40:33 2011
+++
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImpl.java
Mon May 9 10:10:43 2011
@@ -154,7 +154,7 @@
*/
protected MobileWebAppShell createShell() {
return new MobileWebAppShellDesktop(eventBus, placeController,
getTaskListView(),
-getTaskEditView());
+getTaskEditView(), getTaskReadView());
}
/**
===
---
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImplMobile.java
Mon May 9 08:12:52 2011
+++
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImplMobile.java
Mon May 9 10:10:43 2011
@@ -32,7 +32,7 @@
@Override
protected MobileWebAppShell createShell() {
return new MobileWebAppShellMobile(orientationHelper,
getTaskListView(),
-getTaskEditView());
+getTaskEditView(), getTaskReadView());
}
@Override
===
---
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
Mon May 9 08:12:52 2011
+++
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
Mon May 9 10:10:43 2011
@@ -33,6 +33,7 @@
import com.google.gwt.sample.mobilewebapp.client.activity.TaskListActivity;
import
com.google.gwt.sample.mobilewebapp.client.activity.TaskListActivity.TaskListUpdateEvent;
import com.google.gwt.sample.mobilewebapp.client.activity.TaskListView;
+import com.google.gwt.sample.mobilewebapp.client.activity.TaskReadView;
import com.google.gwt.sample.mobilewebapp.client.place.TaskEditPlace;
import com.google.gwt.sample.mobilewebapp.client.place.TaskListPlace;
import com.google.gwt.sample.mobilewebapp.shared.TaskProxy;
@@ -205,7 +206,7 @@
* @param clientFactory the {@link ClientFactory} of shared resources
*/
public MobileWebAppShellDesktop(EventBus bus, final PlaceController
placeController,
- TaskListView taskListView, TaskEditView taskEditView) {
+ TaskListView taskListView, TaskEditView taskEditView, TaskReadView
taskReadView) {
// Initialize the main menu.
Resources resources = GWT.create(Resources.class);
@@ -283,13 +284,14 @@
setAddButtonHandler(null);
/*
- * Add both views to the DeckLayoutPanel so we can animate between
them.
- * Using a DeckLayoutPanel here works because we only have two views,
and we
- * always know that the edit view should animate in from the right
side of
+ * Add all views to the DeckLayoutPanel so we can animate between them.
+ * Using a DeckLayoutPanel here works because we only have a few
views, and we
+ * always know that the task views should animate in from the right
side of
* the screen. A more complex app will require more complex logic to
figure
* out which direction to animate.
*/
contentContainer.add(taskListView);
+contentContainer.add(taskReadView);
contentContainer.add(taskEditView);
contentContainer.setAnimationDuration(800);
===
---
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileWebAppShellMobile.java
Mon May 9 08:12:52 2011
+++
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileWebAppShellMobile.java
Mon May 9 10:10:43 2011
@@ -25,6 +25,7 @@
import com.google.gwt.sample.mobilewebapp.client.MobileWebAppShell;
import com.google.gwt.sample.mobilewebapp.client.activity.TaskEditView;
import com.google.gwt.sample.mobilewebapp.client.activity.TaskListView;
+import com.google.gwt.sample.mobilewebapp.client.activity.TaskReadView;
import com.google.gwt.sample.mobilewebapp.client.ui.OrientationHelper;
import com.google.gwt.uibinder.client.UiBinder;
import com.google.gwt.uibinder.client.UiField;
@@ -109,7 +110,7 @@
* @param clientFactory the {@link ClientFactory} of shared resources
*/
public MobileWebAppShellMobile(OrientationHelper orientationHelper,
[gwt-contrib] Better error reporting (issue1444801)
Reviewers: jlabanca, Description: Better error reporting Please review this at http://gwt-code-reviews.appspot.com/1444801/ Affected files: M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/App.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactory.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImpl.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImplMobile.java D samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/MobileWebAppRequestFactory.java D samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/TaskRequest.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileWebAppShellMobile.java A samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/shared/MobileWebAppRequestFactory.java A samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/shared/TaskRequest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10167 committed - Implementing custom TaskReadViews for tablet, desktop, and mobile.
Revision: 10167
Author: jlaba...@google.com
Date: Mon May 9 10:25:15 2011
Log: Implementing custom TaskReadViews for tablet, desktop, and mobile.
http://code.google.com/p/google-web-toolkit/source/detail?r=10167
Added:
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskReadView.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskReadView.ui.xml
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileTaskReadView.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileTaskReadView.ui.xml
Modified:
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImpl.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImplMobile.java
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImplTablet.java
===
--- /dev/null
+++
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskReadView.java
Mon May 9 10:25:15 2011
@@ -0,0 +1,106 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.sample.mobilewebapp.client.desktop;
+
+import com.google.gwt.core.client.GWT;
+import com.google.gwt.editor.client.SimpleBeanEditorDriver;
+import com.google.gwt.event.dom.client.ClickEvent;
+import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.sample.mobilewebapp.client.activity.TaskReadView;
+import com.google.gwt.sample.mobilewebapp.client.ui.DateButton;
+import com.google.gwt.sample.mobilewebapp.shared.TaskProxy;
+import com.google.gwt.uibinder.client.UiBinder;
+import com.google.gwt.uibinder.client.UiField;
+import com.google.gwt.user.client.ui.Button;
+import com.google.gwt.user.client.ui.Composite;
+import com.google.gwt.user.client.ui.DateLabel;
+import com.google.gwt.user.client.ui.DockLayoutPanel;
+import com.google.gwt.user.client.ui.HTMLPanel;
+import com.google.gwt.user.client.ui.Label;
+import com.google.gwt.user.client.ui.TextBoxBase;
+import com.google.gwt.user.client.ui.Widget;
+
+/**
+ * View used to edit a task.
+ */
+public class DesktopTaskReadView extends Composite implements TaskReadView
{
+
+ /**
+ * The UiBinder interface.
+ */
+ interface DesktopTaskReadViewUiBinder extends UiBinderWidget,
DesktopTaskReadView {
+ }
+
+
+ interface Driver extends SimpleBeanEditorDriverTaskProxy,
DesktopTaskReadView {
+ }
+
+ /**
+ * The UiBinder used to generate the view.
+ */
+ private static DesktopTaskReadViewUiBinder uiBinder = GWT
+ .create(DesktopTaskReadViewUiBinder.class);
+
+ @UiField
+ DockLayoutPanel dockLayoutPanel;
+
+ /**
+ * The panel that contains the edit form.
+ */
+ @UiField
+ HTMLPanel editForm;
+
+ @UiField
+ DateLabel dueDateEditor;
+ @UiField
+ Label nameEditor;
+ @UiField
+ Label notesEditor;
+ @UiField
+ Button saveButton;
+
+ private final Driver driver = GWT.create(Driver.class);
+
+ /**
+ * The {@link TaskReadView.Presenter} for this view.
+ */
+ private Presenter presenter;
+
+ /**
+ * Construct a new {@link DesktopTaskReadView}.
+ */
+ public DesktopTaskReadView() {
+initWidget(uiBinder.createAndBindUi(this));
+driver.initialize(this);
+
+// Create a new task or modify the current task when done is pressed.
+saveButton.addClickHandler(new ClickHandler() {
+ public void onClick(ClickEvent event) {
+if (presenter != null) {
+ presenter.editTask();
+}
+ }
+});
+ }
+
+ public SimpleBeanEditorDriverTaskProxy, ? getEditorDriver() {
+return driver;
+ }
+
+ public void setPresenter(Presenter presenter) {
+this.presenter = presenter;
+ }
+}
===
--- /dev/null
+++
/trunk/samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskReadView.ui.xml
Mon May 9 10:25:15 2011
@@ -0,0 +1,140 @@
+!DOCTYPE ui:UiBinder SYSTEM http://dl.google.com/gwt/DTD/xhtml.ent;
+ui:UiBinder
+ xmlns:ui=urn:ui:com.google.gwt.uibinder
+ xmlns:g=urn:import:com.google.gwt.user.client.ui
+ xmlns:c=urn:import:com.google.gwt.user.cellview.client
+ xmlns:app=urn:import:com.google.gwt.sample.mobilewebapp.client.ui
+
+ ui:style
+
[gwt-contrib] Re: Better error reporting (issue1444801)
Not quite ready for review http://gwt-code-reviews.appspot.com/1444801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Better error reporting (issue1444801)
http://gwt-code-reviews.appspot.com/1444801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)
I don't have the full context, but adding flakiness is not a good idea. According to the current code structure, if we want to make the variable non-static, we may need to pass the propertyOracle parameter to many methods, because shouldConsiderFieldsForSerialization method in SerializableTypeOracleBuilder is static and many methods call this utility method. The change will make the code very cumbersome. I investigated the code couple of times but cannot figure out a better way. Please give some advice. Thanks. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Disabling test for null on getBrowserById for DOM elements without DTD when running on Chrome 12 (issue1443801)
LGTM http://gwt-code-reviews.appspot.com/1443801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Better error reporting (issue1444801)
Verbal LGTM from John. r10167 On Mon, May 9, 2011 at 1:40 PM, rj...@google.com wrote: http://gwt-code-reviews.appspot.com/1444801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Remove JProgram.jsniMap in favor of local accounting. (issue1445801)
Reviewers: jbrosenberg, cromwellian,
Please review this at http://gwt-code-reviews.appspot.com/1445801/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
A dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniClassLiteral.java
M dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniMethodBody.java
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
M dev/core/src/com/google/gwt/dev/jjs/impl/Pruner.java
Index: dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
diff --git a/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
b/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
index
d0563b94091b55cb12c7354b196611a8f1759015..ca36e8564cdafcbeda229b08c799a5a36b4922e6
100644
--- a/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
@@ -311,8 +311,6 @@ public class JProgram extends JNode {
*/
public final ListListJMethod entryMethods = new
ArrayListListJMethod();
- public final MapString, JNode jsniMap = new HashMapString, JNode();
-
public final JTypeOracle typeOracle = new JTypeOracle(this);
/**
Index: dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniClassLiteral.java
diff --git
a/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniClassLiteral.java
b/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniClassLiteral.java
new file mode 100644
index
..c26a92d723ba6633b5d4b585da27afa93db5bf41
--- /dev/null
+++ b/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniClassLiteral.java
@@ -0,0 +1,37 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.dev.jjs.ast.js;
+
+import com.google.gwt.dev.jjs.SourceInfo;
+import com.google.gwt.dev.jjs.ast.JClassLiteral;
+import com.google.gwt.dev.jjs.ast.JType;
+
+/**
+ * JSNI reference to a Java class literal.
+ */
+public class JsniClassLiteral extends JClassLiteral {
+
+ private final String ident;
+
+ public JsniClassLiteral(SourceInfo info, String ident, JType type) {
+super(info, type);
+this.ident = ident;
+ }
+
+ public String getIdent() {
+return ident;
+ }
+}
Index: dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniMethodBody.java
diff --git a/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniMethodBody.java
b/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniMethodBody.java
index
a64b39407d50e1d3d308a50fc820fc5c79a20dd1..0c2fcc4c0e611ff3916dc44e870795dcb65f7707
100644
--- a/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniMethodBody.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/ast/js/JsniMethodBody.java
@@ -18,7 +18,6 @@ package com.google.gwt.dev.jjs.ast.js;
import com.google.gwt.dev.jjs.SourceInfo;
import com.google.gwt.dev.jjs.ast.Context;
import com.google.gwt.dev.jjs.ast.JAbstractMethodBody;
-import com.google.gwt.dev.jjs.ast.JClassLiteral;
import com.google.gwt.dev.jjs.ast.JVisitor;
import com.google.gwt.dev.js.ast.JsContext;
import com.google.gwt.dev.js.ast.JsFunction;
@@ -37,7 +36,7 @@ import java.util.Set;
*/
public class JsniMethodBody extends JAbstractMethodBody {
- private ListJClassLiteral classRefs = Collections.emptyList();
+ private ListJsniClassLiteral classRefs = Collections.emptyList();
private JsFunction jsFunction = null;
private ListJsniFieldRef jsniFieldRefs = Collections.emptyList();
private ListJsniMethodRef jsniMethodRefs = Collections.emptyList();
@@ -51,7 +50,7 @@ public class JsniMethodBody extends JAbstractMethodBody {
/**
* Adds a reference from this method to a Java class literal.
*/
- public void addClassRef(JClassLiteral ref) {
+ public void addClassRef(JsniClassLiteral ref) {
classRefs = Lists.add(classRefs, ref);
}
@@ -72,7 +71,7 @@ public class JsniMethodBody extends JAbstractMethodBody {
/**
* Return this method's references to Java class literals.
*/
- public ListJClassLiteral getClassRefs() {
+ public ListJsniClassLiteral getClassRefs() {
return classRefs;
}
Index: dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
b/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
index
75815f19ebb8b585fd011bee15a13ed64d587433..f732bc93897912cf60fada8ec9bc65b890c3c420
100644
---
