[gwt-contrib] Experimental attempt to add EventBus support to Widgets (issue1447804)
Reviewers: rjrjr, Description: Experimental attempt to add EventBus support to Widgets Modify the MobileWebApp sample to use the new feature Please review this at http://gwt-code-reviews.appspot.com/1447804/ Affected files: M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/App.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImpl.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/ClientFactoryImplTablet.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/Provider.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/activity/TaskListActivity.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskReadView.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/mobile/MobileTaskReadView.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/tablet/MobileWebAppShellTablet.java M samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp/client/tablet/TabletTaskReadView.java A user/src/com/google/gwt/event/logical/shared/ActivateEvent.java M user/src/com/google/gwt/user/client/ui/Widget.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10181 committed - Fix checkstyle 'info' warnings...
Revision: 10181
Author: gwt.mirror...@gmail.com
Date: Thu May 12 17:18:09 2011
Log: Fix checkstyle 'info' warnings
Review at http://gwt-code-reviews.appspot.com/1446803
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10181
Modified:
/trunk/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
/trunk/user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
/trunk/user/src/com/google/gwt/event/dom/client/EndedEvent.java
/trunk/user/src/com/google/gwt/event/dom/client/ProgressEvent.java
/trunk/user/src/com/google/gwt/event/logical/shared/HasAttachHandlers.java
/trunk/user/src/com/google/gwt/event/shared/EventBus.java
/trunk/user/src/com/google/gwt/event/shared/ResettableEventBus.java
/trunk/user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
/trunk/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
/trunk/user/src/com/google/web/bindery/autobean/shared/Splittable.java
/trunk/user/src/com/google/web/bindery/event/shared/ResettableEventBus.java
/trunk/user/src/com/google/web/bindery/requestfactory/shared/Receiver.java
/trunk/user/test/com/google/gwt/event/shared/SimpleEventBusTest.java
/trunk/user/test/com/google/gwt/i18n/rebind/LocaleUtilsTest.java
/trunk/user/test/com/google/gwt/user/tools/WebAppCreatorTest.java
/trunk/user/test/com/google/web/bindery/requestfactory/server/ServiceLocatorTest.java
===
---
/trunk/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
Fri May 6 09:30:06 2011
+++
/trunk/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
Thu May 12 17:18:09 2011
@@ -135,8 +135,7 @@
}
}
}
-
-
+
String[] cacheExtraFiles = getCacheExtraFiles();
for (int i = 0; i < cacheExtraFiles.length; i++) {
staticResoucesSb.append(cacheExtraFiles[i]);
===
---
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
Tue Apr 26 08:02:24 2011
+++
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
Thu May 12 17:18:09 2011
@@ -53,8 +53,6 @@
*
* @param logger logger for logging errors to the console
* @param missingType The qualified source name of the type to report
- * @param unitMap if available, pass
- * {@link CompilationState#getCompilationUnitMap()}.
*/
public static void logMissingTypeErrorWithHints(TreeLogger logger,
String missingType,
CompilationState compilationState) {
@@ -105,7 +103,7 @@
* originated.
* @param isError true if this is considered a fatal
compilation
* error.
- * @param supressErrors Controls the log level for logging errors. See
+ * @param suppressErrors Controls the log level for logging errors. See
* {@link #reportErrors(TreeLogger, CompilationUnit, boolean)}.
* @return a branch of the logger parameter for logging further problems.
*/
@@ -174,7 +172,7 @@
*
* @param logger logger for reporting errors to the console
* @param unit Compilation unit that may have errors
- * @param supressErrors Controls he log level for logging errors. If
+ * @param suppressErrors Controls he log level for logging errors. If
* false is passed, compilation errors are logged
at
* TreeLogger.ERROR and warnings logged at TreeLogger.WARN. If
* true is passed, compilation errors are logged at
===
---
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
Tue Apr 5 03:08:39 2011
+++
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
Thu May 12 17:18:09 2011
@@ -17,7 +17,6 @@
import com.google.gwt.core.ext.TreeLogger;
-
import java.util.Collection;
import java.util.HashSet;
import java.util.Iterator;
===
---
/trunk/user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
Wed Mar 23 13:32:42 2011
+++
/trunk/user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
Thu May 12 17:18:09 2011
@@ -55,7 +55,6 @@
public final Type getAssociatedType() {
return TYPE;
}
-
@Override
protected void dispatch(CanPlayThroughHandler handler) {
===
--- /trunk/user/src/com/google/gwt/event/dom/client/EndedEvent.java Wed Mar
23 13:32:42 2011
+++ /trunk/user/src/com/google/gwt/event/dom/client/EndedEvent.java Thu May
12 17:18:09 2011
@@ -54,7 +54,6 @@
public final Type getAssociatedType() {
return TYPE;
}
-
@Override
protected void dispatch(EndedHandler handler) {
===
--- /trunk/user/src/com/google/gwt/event/dom/client/ProgressEv
[gwt-contrib] Re: Fix checkstyle 'info' warnings (issue1446803)
LGTM
On Thu, May 12, 2011 at 4:25 PM, wrote:
> Reviewers: rjrjr,
>
> Description:
> Fix checkstyle 'info' warnings
>
>
> Please review this at http://gwt-code-reviews.appspot.com/1446803/
>
> Affected files:
> M dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
> M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
> M dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
> M user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
> M user/src/com/google/gwt/event/dom/client/EndedEvent.java
> M user/src/com/google/gwt/event/dom/client/ProgressEvent.java
> M user/src/com/google/gwt/event/logical/shared/HasAttachHandlers.java
> M user/src/com/google/gwt/event/shared/EventBus.java
> M user/src/com/google/gwt/event/shared/ResettableEventBus.java
> M user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
> M user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
> M user/src/com/google/web/bindery/autobean/shared/Splittable.java
> M user/src/com/google/web/bindery/event/shared/ResettableEventBus.java
> M user/src/com/google/web/bindery/requestfactory/shared/Receiver.java
> M user/test/com/google/gwt/event/shared/SimpleEventBusTest.java
> M user/test/com/google/gwt/i18n/rebind/LocaleUtilsTest.java
> M user/test/com/google/gwt/user/tools/WebAppCreatorTest.java
> M
> user/test/com/google/web/bindery/requestfactory/server/ServiceLocatorTest.java
>
>
> Index: dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
> ===
> --- dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
> (revision 10178)
> +++ dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
> (working copy)
> @@ -135,8 +135,7 @@
> }
> }
> }
> -
> -
> +
> String[] cacheExtraFiles = getCacheExtraFiles();
> for (int i = 0; i < cacheExtraFiles.length; i++) {
> staticResoucesSb.append(cacheExtraFiles[i]);
> Index:
> dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
> ===
> --- dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
> (revision 10178)
> +++ dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
> (working copy)
> @@ -53,8 +53,6 @@
>*
>* @param logger logger for logging errors to the console
>* @param missingType The qualified source name of the type to report
> - * @param unitMap if available, pass
> - * {@link CompilationState#getCompilationUnitMap()}.
>*/
> public static void logMissingTypeErrorWithHints(TreeLogger logger, String
> missingType,
> CompilationState compilationState) {
> @@ -105,7 +103,7 @@
>* originated.
>* @param isError true if this is considered a fatal
> compilation
>* error.
> - * @param supressErrors Controls the log level for logging errors. See
> + * @param suppressErrors Controls the log level for logging errors. See
>* {@link #reportErrors(TreeLogger, CompilationUnit, boolean)}.
>* @return a branch of the logger parameter for logging further problems.
>*/
> @@ -174,7 +172,7 @@
>*
>* @param logger logger for reporting errors to the console
>* @param unit Compilation unit that may have errors
> - * @param supressErrors Controls he log level for logging errors. If
> + * @param suppressErrors Controls he log level for logging errors. If
>* false is passed, compilation errors are logged
> at
>* TreeLogger.ERROR and warnings logged at TreeLogger.WARN. If
>* true is passed, compilation errors are logged at
> Index:
> dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
> ===
> --- dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
> (revision 10178)
> +++ dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
> (working copy)
> @@ -16,7 +16,6 @@
> package com.google.gwt.dev.javac;
>
> import com.google.gwt.core.ext.TreeLogger;
> -
>
> import java.util.Collection;
> import java.util.HashSet;
> Index: user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
> ===
> --- user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
> (revision 10178)
> +++ user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
> (working copy)
> @@ -56,7 +56,6 @@
> return TYPE;
> }
>
> -
> @Override
> protected void dispatch(CanPlayThroughHandler handler) {
> handler.onCanPlayThrough(this);
> Index: user/src/com/google/gwt/event/dom/client/EndedEvent.java
> ===
> --- user/src/com/google/gwt/event/dom/client/EndedEvent.java(revision
> 10178)
> +++ use
[gwt-contrib] Fix checkstyle 'info' warnings (issue1446803)
Reviewers: rjrjr,
Description:
Fix checkstyle 'info' warnings
Please review this at http://gwt-code-reviews.appspot.com/1446803/
Affected files:
M dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
M dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
M user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
M user/src/com/google/gwt/event/dom/client/EndedEvent.java
M user/src/com/google/gwt/event/dom/client/ProgressEvent.java
M user/src/com/google/gwt/event/logical/shared/HasAttachHandlers.java
M user/src/com/google/gwt/event/shared/EventBus.java
M user/src/com/google/gwt/event/shared/ResettableEventBus.java
M user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
M user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
M user/src/com/google/web/bindery/autobean/shared/Splittable.java
M user/src/com/google/web/bindery/event/shared/ResettableEventBus.java
M user/src/com/google/web/bindery/requestfactory/shared/Receiver.java
M user/test/com/google/gwt/event/shared/SimpleEventBusTest.java
M user/test/com/google/gwt/i18n/rebind/LocaleUtilsTest.java
M user/test/com/google/gwt/user/tools/WebAppCreatorTest.java
M
user/test/com/google/web/bindery/requestfactory/server/ServiceLocatorTest.java
Index: dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
===
--- dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
(revision 10178)
+++ dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
(working copy)
@@ -135,8 +135,7 @@
}
}
}
-
-
+
String[] cacheExtraFiles = getCacheExtraFiles();
for (int i = 0; i < cacheExtraFiles.length; i++) {
staticResoucesSb.append(cacheExtraFiles[i]);
Index: dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
===
--- dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
(revision 10178)
+++ dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
(working copy)
@@ -53,8 +53,6 @@
*
* @param logger logger for logging errors to the console
* @param missingType The qualified source name of the type to report
- * @param unitMap if available, pass
- * {@link CompilationState#getCompilationUnitMap()}.
*/
public static void logMissingTypeErrorWithHints(TreeLogger logger,
String missingType,
CompilationState compilationState) {
@@ -105,7 +103,7 @@
* originated.
* @param isError true if this is considered a fatal
compilation
* error.
- * @param supressErrors Controls the log level for logging errors. See
+ * @param suppressErrors Controls the log level for logging errors. See
* {@link #reportErrors(TreeLogger, CompilationUnit, boolean)}.
* @return a branch of the logger parameter for logging further problems.
*/
@@ -174,7 +172,7 @@
*
* @param logger logger for reporting errors to the console
* @param unit Compilation unit that may have errors
- * @param supressErrors Controls he log level for logging errors. If
+ * @param suppressErrors Controls he log level for logging errors. If
* false is passed, compilation errors are logged
at
* TreeLogger.ERROR and warnings logged at TreeLogger.WARN. If
* true is passed, compilation errors are logged at
Index: dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
===
--- dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
(revision 10178)
+++ dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java
(working copy)
@@ -16,7 +16,6 @@
package com.google.gwt.dev.javac;
import com.google.gwt.core.ext.TreeLogger;
-
import java.util.Collection;
import java.util.HashSet;
Index: user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
===
--- user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
(revision 10178)
+++ user/src/com/google/gwt/event/dom/client/CanPlayThroughEvent.java
(working copy)
@@ -56,7 +56,6 @@
return TYPE;
}
-
@Override
protected void dispatch(CanPlayThroughHandler handler) {
handler.onCanPlayThrough(this);
Index: user/src/com/google/gwt/event/dom/client/EndedEvent.java
===
--- user/src/com/google/gwt/event/dom/client/EndedEvent.java (revision
10178)
+++ user/src/com/google/gwt/event/dom/client/EndedEvent.java(working copy)
@@ -55,7 +55,6 @@
return TYPE;
}
-
@Override
protected void dispatch(EndedHandler handler) {
handler.onEnded(this);
I
[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)
SGTM. At some point I'll have to deal with versioning for the embedded GWT ASTs, but I can burn that bridge when I come to it. On Thu, May 12, 2011 at 6:48 PM, wrote: > I know the paint is still drying on the last patch I submitted for the > Persistent Unit Cache, but no real problems have been reported in... > weeks! I think its ready to be on by default. > > > http://gwt-code-reviews.appspot.com/1448801/ > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Adding additional testing for GWT RPC. Some custom serialized objects (issue1441804)
http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java File user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java (right): http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java#newcode84 user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java:84: */ On 2011/05/12 22:07:04, tobyr wrote: Stale comment? Done. http://gwt-code-reviews.appspot.com/1441804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)
I know the paint is still drying on the last patch I submitted for the Persistent Unit Cache, but no real problems have been reported in... weeks! I think its ready to be on by default. http://gwt-code-reviews.appspot.com/1448801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Enables on the persistent unit cache by default. (issue1448801)
Reviewers: tobyr, scottb, jbrosenberg,
Description:
Enables on the persistent unit cache by default.
Please review this at http://gwt-code-reviews.appspot.com/1448801/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java
Index: dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java
===
--- dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java (revision
10178)
+++ dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java (working
copy)
@@ -29,7 +29,7 @@
* The API must be enabled explicitly for persistent caching to be live.
*/
private static final String configPropertyValue =
System.getProperty("gwt.persistentunitcache",
- "false");
+ "true");
private static final boolean usePersistent =
configPropertyValue.length() == 0
|| Boolean.parseBoolean(configPropertyValue);
private static UnitCache instance = null;
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Adding additional testing for GWT RPC. Some custom serialized objects (issue1441804)
http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java File user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java (right): http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java#newcode84 user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java:84: */ Stale comment? http://gwt-code-reviews.appspot.com/1441804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Adding additional testing for GWT RPC. Some custom serialized objects (issue1441804)
Reviewers: unnurg, Description: Adding additional testing for GWT RPC. Some custom serialized objects were previously untested, at least explicitly. Testing put in place now provides coverage to test future changes. Please review this at http://gwt-code-reviews.appspot.com/1441804/ Affected files: A user/test/com/google/gwt/user/LoggingRPCSuite.gwt.xml A user/test/com/google/gwt/user/LoggingRPCSuite.java M user/test/com/google/gwt/user/RPCSuite.gwt.xml M user/test/com/google/gwt/user/RPCSuite.java A user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java A user/test/com/google/gwt/user/client/rpc/CoreJavaTestService.java A user/test/com/google/gwt/user/client/rpc/CoreJavaTestServiceAsync.java M user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTest.java A user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java A user/test/com/google/gwt/user/client/rpc/LoggingRPCTestService.java A user/test/com/google/gwt/user/client/rpc/LoggingRPCTestServiceAsync.java A user/test/com/google/gwt/user/server/rpc/CoreJavaTestServiceImpl.java A user/test/com/google/gwt/user/server/rpc/LoggingRPCTestServiceImpl.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10180 committed - Rescues cached entries from jar files that are the same, save for the ...
Revision: 10180
Author: zun...@google.com
Date: Thu May 12 10:40:46 2011
Log: Rescues cached entries from jar files that are the same, save for
the timestamp.
Also updates the key value used for the cache to include the prefix for
RerootedResource
instances.
Review at http://gwt-code-reviews.appspot.com/1441803
http://code.google.com/p/google-web-toolkit/source/detail?r=10180
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
/trunk/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
/trunk/dev/core/src/com/google/gwt/dev/javac/UnitCache.java
/trunk/dev/core/src/com/google/gwt/dev/resource/Resource.java
/trunk/dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
/trunk/dev/core/test/com/google/gwt/dev/javac/MockCompilationUnit.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
Wed May 11 10:50:46 2011
+++ /trunk/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
Thu May 12 10:40:46 2011
@@ -30,17 +30,46 @@
private final Collection compiledClasses;
private final ContentId contentId;
private final Dependencies dependencies;
- private final String resourceLocation;
- private final String resourcePath;
- private final List jsniMethods;
- private final long lastModified;
- private final MethodArgNamesLookup methodArgNamesLookup;
- private final String typeName;
private final boolean isError;
private final boolean isGenerated;
private final boolean isSuperSource;
+ private final List jsniMethods;
+ private final long lastModified;
+ private final MethodArgNamesLookup methodArgNamesLookup;
private final CategorizedProblem[] problems;
+ private final String resourceLocation;
+ private final String resourcePath;
private final DiskCacheToken sourceToken;
+ private final String typeName;
+
+ /**
+ * Shallow copy of a CachedCompiliationUnit, replacing some parameters
in the new copy.
+ *
+ * @param unit Unit to clone.
+ * @param lastModified last modified date to replace in the clone
+ * @param resourceLocation location to replace in the clone.
+ */
+ public CachedCompilationUnit(CachedCompilationUnit unit, long
lastModified,
+ String resourceLocation) {
+assert unit != null;
+this.compiledClasses = unit.getCompiledClasses();
+this.contentId = unit.getContentId();
+this.dependencies = unit.getDependencies();
+this.resourcePath = unit.getResourcePath();
+this.jsniMethods = unit.getJsniMethods();
+this.methodArgNamesLookup = unit.getMethodArgs();
+this.typeName = unit.getTypeName();
+this.isError = unit.isError();
+this.isGenerated = unit.isGenerated();
+this.isSuperSource = unit.isSuperSource();
+this.problems = unit.problems;
+this.astToken = unit.astToken;
+this.sourceToken = unit.sourceToken;
+
+// Override these fields
+this.lastModified = lastModified;
+this.resourceLocation = resourceLocation;
+ }
/**
* Create a compilation unit that can be serialized from another
@@ -79,6 +108,11 @@
this.astToken = new DiskCacheToken(astToken);
this.sourceToken = new DiskCacheToken(sourceToken);
}
+
+ @Override
+ public CachedCompilationUnit asCachedCompilationUnit() {
+return this;
+ }
@Override
public Collection getCompiledClasses() {
@@ -142,11 +176,6 @@
public boolean isSuperSource() {
return isSuperSource;
}
-
- @Override
- protected Object writeReplace() {
-return this;
- }
@Override
ContentId getContentId() {
===
---
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
Tue May 3 08:35:13 2011
+++
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
Thu May 12 10:40:46 2011
@@ -1,12 +1,12 @@
/*
* Copyright 2009 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the "License"); you may
not
* use this file except in compliance with the License. You may obtain a
copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -371,7 +371,7 @@
/**
* Build a new compilation state from a source oracle. Allow the caller
to
* specify a compiler delegate that will handle undefined names.
- *
+ *
* TODO: maybe use a finer brush than to synchronize the whole thing.
*/
public synchronized CompilationState doBuildFrom(TreeLogger logger,
Set resources,
@@ -
[gwt-contrib] [google-web-toolkit] r10179 committed - Misc gwtc cleanups....
Revision: 10179
Author: sco...@google.com
Date: Thu May 12 10:09:08 2011
Log: Misc gwtc cleanups.
http://gwt-code-reviews.appspot.com/1446802/
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10179
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JNewArray.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRebinds.java
===
---
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java
Mon Aug 30 04:31:11 2010
+++
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java
Thu May 12 10:09:08 2011
@@ -137,7 +137,7 @@
@Override
public String toString() {
-return methodSig != null ? methodSig : className;
+return isClass() ? className : getJsniIdent();
}
private void readObject(ObjectInputStream in) throws IOException,
===
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JNewArray.java Wed Apr
20 08:47:17 2011
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JNewArray.java Thu May
12 10:09:08 2011
@@ -16,8 +16,8 @@
package com.google.gwt.dev.jjs.ast;
import com.google.gwt.dev.jjs.SourceInfo;
-
-import java.util.ArrayList;
+import com.google.gwt.dev.util.collect.Lists;
+
import java.util.List;
/**
@@ -26,8 +26,6 @@
public class JNewArray extends JExpression {
public static JNewArray createDims(SourceInfo info, JArrayType
arrayType, List dims) {
-List classLiterals = new ArrayList();
-
// Produce all class literals that will eventually get generated.
int realDims = 0;
for (JExpression dim : dims) {
@@ -37,11 +35,12 @@
++realDims;
}
+List classLiterals = Lists.create();
JType cur = arrayType;
for (int i = 0; i < realDims; ++i) {
// Walk down each type from most dims to least.
JClassLiteral classLit = new JClassLiteral(info.makeChild(), cur);
- classLiterals.add(classLit);
+ classLiterals = Lists.add(classLiterals, classLit);
cur = ((JArrayType) cur).getElementType();
}
return new JNewArray(info, arrayType, dims, null, classLiterals);
@@ -49,8 +48,8 @@
public static JNewArray createInitializers(SourceInfo info, JArrayType
arrayType,
List initializers) {
-List classLiterals = new ArrayList();
-classLiterals.add(new JClassLiteral(info.makeChild(), arrayType));
+List classLiterals =
+Lists.create(new JClassLiteral(info.makeChild(), arrayType));
return new JNewArray(info, arrayType, null, initializers,
classLiterals);
}
@@ -75,7 +74,7 @@
}
public JArrayType getArrayType() {
-return (JArrayType) type.getUnderlyingType();
+return type;
}
/**
===
--- /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java Tue
May 10 05:59:20 2011
+++ /trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java Thu
May 12 10:09:08 2011
@@ -653,7 +653,7 @@
*/
if (!hasExplicitThis) {
ReferenceBinding declaringClass = (ReferenceBinding)
x.binding.declaringClass.erasure();
- if (declaringClass instanceof NestedTypeBinding) {
+ if (isNested(declaringClass)) {
NestedTypeBinding nestedBinding = (NestedTypeBinding)
declaringClass;
if (nestedBinding.enclosingInstances != null) {
for (SyntheticArgumentBinding arg :
nestedBinding.enclosingInstances) {
@@ -768,7 +768,7 @@
if (x.isSuperAccess()) {
JExpression qualifier = pop(x.qualification);
ReferenceBinding superClass = x.binding.declaringClass;
- boolean nestedSuper = superClass.isNestedType()
&& !superClass.isStatic();
+ boolean nestedSuper = isNested(superClass);
if (nestedSuper) {
processSuperCallThisArgs(superClass, call, qualifier,
x.qualification);
}
@@ -779,7 +779,7 @@
} else {
assert (x.qualification == null);
ReferenceBinding declaringClass = x.binding.declaringClass;
- boolean nested = declaringClass.isNestedType()
&& !declaringClass.isStatic();
+ boolean nested = isNested(declaringClass);
if (nested) {
processThisCallThisArgs(declaringClass, call);
}
@@ -1553,7 +1553,8 @@
// Map synthetic arguments for outer this.
ReferenceBinding declaringClass = (ReferenceBinding)
x.binding.declaringClass.erasure();
-if (declaringClass.isNestedType() && !declaringClass.isStatic()) {
+boolean isNested = isNested(declaringClass);
+if (isNested) {
NestedTypeBinding nestedBinding = (NestedTypeBinding)
declaringClass;
if (nestedBinding.enclosingInstances != null) {
[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)
LGTM w/nits, no need to re-review. http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java (right): http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java#newcode45 dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:45: public CachedCompilationUnit(CachedCompilationUnit unit, long lastModified, Javadoc. http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java#newcode66 dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:66: } You should just be able to just assign the field, the conversion would have happened already in the original unit. http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right): http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode3 dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:3: * whitespace http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode404 dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:404: unitCache.remove(cachedUnit); It looks like adding the new unit is supposed to bump out the old one. http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java File dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java (right): http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java#newcode52 dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java:52: } I think this can be reverted now http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Misc gwtc cleanups (issue1446802)
LGTM http://gwt-code-reviews.appspot.com/1446802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)
http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Removing the recently added RPC test for LogRecord, as it seems to (issue1447803)
Hmmm - that link doesn't work for me - did this issue get reverted?
On Wed, May 11, 2011 at 1:02 PM, wrote:
> Reviewers: unnurg,
>
> Description:
> Removing the recently added RPC test for LogRecord, as it seems to
> cause more problems than it is worth.
>
>
> Please review this at http://gwt-code-reviews.appspot.com/1447803/
>
> Affected files:
> M user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java
>
>
> Index: user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java
> ===
> --- user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java (revision
> 10174)
> +++ user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java (working
> copy)
> @@ -122,7 +122,13 @@
>
> private CoreJavaTestServiceAsync coreJavaTestService;
>
> - public void testLogRecord() {
> + /**
> + * This test is disabled because the creation of java.util.logging.Level
> + * objects fails in production mode with the standard logging behavior
> of
> + * tests. Given that we log things regularly, and hence get plenty of
> + * implicit testing, it is not worth fixing the flakiness.
> + */
> + public void disableTestLogRecord() {
> CoreJavaTestServiceAsync service = getServiceAsync();
> delayTestFinishForRpc();
> service.echoLogRecord(expectedLogRecord, new AsyncCallback()
> {
>
>
>
--
DO NOT FORWARD
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Autoformats user/super and user/test-super (issue1442805)
I had to drag Alex into this. I thought I'd move the process along by mass formatting from eclipse UI on the package or project level, but that also skips our GWT specific tweaks. On Thu, May 12, 2011 at 12:24 PM, wrote: > > http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java > File > user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java > (right): > > http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java#newcode28 > user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java:28: > }-*/; > On 2011/05/12 16:13:10, rjrjr wrote: >> >> Uh oh. The auto-formatter clobbers jsni. This seems pretty bad. > > Good Catch. I'll see if there's something I can do... > > http://gwt-code-reviews.appspot.com/1442805/ > -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Autoformats user/super and user/test-super (issue1442805)
http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java File user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java (right): http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java#newcode28 user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java:28: }-*/; On 2011/05/12 16:13:10, rjrjr wrote: Uh oh. The auto-formatter clobbers jsni. This seems pretty bad. Good Catch. I'll see if there's something I can do... http://gwt-code-reviews.appspot.com/1442805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Autoformats user/super and user/test-super (issue1442805)
http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java File user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java (right): http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java#newcode28 user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java:28: }-*/; Uh oh. The auto-formatter clobbers jsni. This seems pretty bad. http://gwt-code-reviews.appspot.com/1442805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Autoformats user/super and user/test-super (issue1442805)
Reviewers: rjrjr, scottb, Description: Autoformats user/super and user/test-super Please review this at http://gwt-code-reviews.appspot.com/1442805/ Affected files: M user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java M user/super/com/google/gwt/core/translatable/com/google/gwt/core/client/impl/WeakMapping.java M user/super/com/google/gwt/emul/java/io/Serializable.java M user/super/com/google/gwt/emul/java/io/UnsupportedEncodingException.java M user/super/com/google/gwt/emul/java/lang/Appendable.java M user/super/com/google/gwt/emul/java/lang/ArithmeticException.java M user/super/com/google/gwt/emul/java/lang/ArrayIndexOutOfBoundsException.java M user/super/com/google/gwt/emul/java/lang/ArrayStoreException.java M user/super/com/google/gwt/emul/java/lang/AssertionError.java M user/super/com/google/gwt/emul/java/lang/Byte.java M user/super/com/google/gwt/emul/java/lang/Character.java M user/super/com/google/gwt/emul/java/lang/Class.java M user/super/com/google/gwt/emul/java/lang/Double.java M user/super/com/google/gwt/emul/java/lang/Enum.java M user/super/com/google/gwt/emul/java/lang/Float.java M user/super/com/google/gwt/emul/java/lang/IllegalArgumentException.java M user/super/com/google/gwt/emul/java/lang/IndexOutOfBoundsException.java M user/super/com/google/gwt/emul/java/lang/Integer.java M user/super/com/google/gwt/emul/java/lang/Long.java M user/super/com/google/gwt/emul/java/lang/Math.java M user/super/com/google/gwt/emul/java/lang/NegativeArraySizeException.java M user/super/com/google/gwt/emul/java/lang/NullPointerException.java M user/super/com/google/gwt/emul/java/lang/Number.java M user/super/com/google/gwt/emul/java/lang/NumberFormatException.java M user/super/com/google/gwt/emul/java/lang/Object.java M user/super/com/google/gwt/emul/java/lang/RuntimeException.java M user/super/com/google/gwt/emul/java/lang/Short.java M user/super/com/google/gwt/emul/java/lang/StackTraceElement.java M user/super/com/google/gwt/emul/java/lang/String.java M user/super/com/google/gwt/emul/java/lang/StringIndexOutOfBoundsException.java M user/super/com/google/gwt/emul/java/lang/SuppressWarnings.java M user/super/com/google/gwt/emul/java/lang/System.java M user/super/com/google/gwt/emul/java/lang/UnsupportedOperationException.java M user/super/com/google/gwt/emul/java/lang/annotation/Annotation.java M user/super/com/google/gwt/emul/java/lang/annotation/AnnotationFormatError.java M user/super/com/google/gwt/emul/java/lang/annotation/AnnotationTypeMismatchException.java M user/super/com/google/gwt/emul/java/lang/annotation/Documented.java M user/super/com/google/gwt/emul/java/lang/annotation/ElementType.java M user/super/com/google/gwt/emul/java/lang/annotation/IncompleteAnnotationException.java M user/super/com/google/gwt/emul/java/lang/annotation/Inherited.java M user/super/com/google/gwt/emul/java/lang/annotation/Retention.java M user/super/com/google/gwt/emul/java/lang/annotation/RetentionPolicy.java M user/super/com/google/gwt/emul/java/lang/annotation/Target.java M user/super/com/google/gwt/emul/java/math/BigDecimal.java M user/super/com/google/gwt/emul/java/math/BigInteger.java M user/super/com/google/gwt/emul/java/math/BitLevel.java M user/super/com/google/gwt/emul/java/math/Conversion.java M user/super/com/google/gwt/emul/java/math/Division.java M user/super/com/google/gwt/emul/java/math/Elementary.java M user/super/com/google/gwt/emul/java/math/Logical.java M user/super/com/google/gwt/emul/java/math/MathContext.java M user/super/com/google/gwt/emul/java/math/Multiplication.java M user/super/com/google/gwt/emul/java/math/Primality.java M user/super/com/google/gwt/emul/java/math/RoundingMode.java M user/super/com/google/gwt/emul/java/security/DigestException.java M user/super/com/google/gwt/emul/java/security/GeneralSecurityException.java M user/super/com/google/gwt/emul/java/security/MessageDigest.java M user/super/com/google/gwt/emul/java/security/MessageDigestSpi.java M user/super/com/google/gwt/emul/java/security/NoSuchAlgorithmException.java M user/super/com/google/gwt/emul/java/sql/Date.java M user/super/com/google/gwt/emul/java/sql/Time.java M user/super/com/google/gwt/emul/java/sql/Timestamp.java M user/super/com/google/gwt/emul/java/text/ParseException.java M user/super/com/google/gwt/emul/java/util/AbstractCollection.java M user/super/com/google/gwt/emul/java/util/AbstractHashMap.java M user/super/com/google/gwt/emul/java/util/AbstractList.java M user/super/com/google/gwt/emul/java/util/AbstractMap.java M user/super/com/google/gwt/emul/java/util/AbstractQueue.java M user/super/com/google/gwt/emul/java/util/AbstractSequentialList.java M user/super/com/google/gwt/emul/java/util/AbstractSet.java M user/super/com/google/gwt/emul/java/util/ArrayList.java M user/super/com/google/gwt/em
[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)
http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
