Re: [gwt-contrib] Re: A possible JsInterop issue in GWT 2.8 RC2

[Daniel Gerson]

This tripped me up as well. I second adding a note to the Javadoc as Boris 
suggested.

On Thursday, August 25, 2016 at 10:07:00 PM UTC+1, Goktug Gokdogan wrote:
>
> Document includes a comment about it in the examples and the section that 
> describes the migration from 2.7 has an instruction to add the flag.
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/2372689d-3b71-485b-8582-b7d0630261b9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: A possible JsInterop issue in GWT 2.8 RC2

['Goktug Gokdogan' via GWT Contributors]

Document includes a comment about it in the examples and the section that
describes the migration from 2.7 has an instruction to add the flag.

On Mon, Aug 22, 2016 at 7:17 AM, Boris Brudnoy  wrote:

> Thanks guys. A note on this should certainly make it into the public
> JsInterop doc, somewhere close to the definition of the
> JsType/JsMethod/JsProperty contract.
>
> On Mon, Aug 22, 2016 at 8:04 AM Jens  wrote:
>
>>
>> Jens is spot on. We want people to explicitly use
>>> -generateJsInteropExports if they rely on exporting since it has a hit on
>>> code size.
>>>
>>
>> Maybe the mention of the parameter should be added to the JsType JavaDoc
>> for a final 2.8 release.
>>
>> -- J.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "GWT Contributors" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/ms
>> gid/google-web-toolkit-contributors/6ea6ad27-695d-4eec-8e0c-
>> c2a49be9a422%40googlegroups.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> *BORIS BRUDNOY*
> Web Application Developer, Java/GWT Enthusiast (LinkedIn
> )
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/ms
> gid/google-web-toolkit-contributors/CAD%3DgKQ0_A3T9i-6nn9rL5
> bFBC9SatO8rbYiY%2BWQ82arAQwmTsg%40mail.gmail.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA0E7L8QacGDRmrrMhUkSx6DA0CVQWrKs1vbzsZ7wocxxw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: A possible JsInterop issue in GWT 2.8 RC2

[Boris Brudnoy]

Thanks guys. A note on this should certainly make it into the public
JsInterop doc, somewhere close to the definition of the
JsType/JsMethod/JsProperty contract.

On Mon, Aug 22, 2016 at 8:04 AM Jens  wrote:

>
> Jens is spot on. We want people to explicitly use
>> -generateJsInteropExports if they rely on exporting since it has a hit on
>> code size.
>>
>
> Maybe the mention of the parameter should be added to the JsType JavaDoc
> for a final 2.8 release.
>
> -- J.
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit-contributors/6ea6ad27-695d-4eec-8e0c-c2a49be9a422%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>
-- 
*BORIS BRUDNOY*
Web Application Developer, Java/GWT Enthusiast (LinkedIn
)

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAD%3DgKQ0_A3T9i-6nn9rL5bFBC9SatO8rbYiY%2BWQ82arAQwmTsg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: A possible JsInterop issue in GWT 2.8 RC2

[Jens]

> Jens is spot on. We want people to explicitly use 
> -generateJsInteropExports if they rely on exporting since it has a hit on 
> code size.
>

Maybe the mention of the parameter should be added to the JsType JavaDoc 
for a final 2.8 release.

-- J.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/6ea6ad27-695d-4eec-8e0c-c2a49be9a422%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: A possible JsInterop issue in GWT 2.8 RC2

['Daniel Kurka' via GWT Contributors]

Jens is spot on. We want people to explicitly use -generateJsInteropExports
if they rely on exporting since it has a hit on code size.

On Mon, Aug 22, 2016 at 12:56 PM Thomas Broyer  wrote:

> FWIW, I believe this is
> https://github.com/gwtproject/gwt/commit/ca8ad7bc140bc23b237620c41d755ef787bd97b1
> (i.e. on-purpose)
>
>
> On Friday, August 19, 2016 at 9:38:32 PM UTC+2, Jens wrote:
>>
>> @JsType with isNative = false (the default) are probably treated as
>> normal classes now if you do not use -generateJsInteropExports as compiler
>> parameter. I guess it works again if you use the compiler parameter?
>>
>> -- J.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit-contributors/c901940b-5b21-4717-b9d7-58a471eaa357%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CALLujiqJgO%3DEGgTYpxJ5vx80vUN03p9hGsm%3D-HABO3Xe%2BODxHw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[gwt-contrib] Re: A possible JsInterop issue in GWT 2.8 RC2

[Thomas Broyer]

FWIW, I believe this 
is 
https://github.com/gwtproject/gwt/commit/ca8ad7bc140bc23b237620c41d755ef787bd97b1
 
(i.e. on-purpose)

On Friday, August 19, 2016 at 9:38:32 PM UTC+2, Jens wrote:
>
> @JsType with isNative = false (the default) are probably treated as normal 
> classes now if you do not use -generateJsInteropExports as compiler 
> parameter. I guess it works again if you use the compiler parameter?
>
> -- J.
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/c901940b-5b21-4717-b9d7-58a471eaa357%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: A possible JsInterop issue in GWT 2.8 RC2

[Jens]

Because all these non native JsTypes are considered entry points to your 
application when they are exported and thus all code referenced by them can not 
be pruned and maybe some other optimization a can't be applied to it as well.

Now consider GWT libraries that use non native JsTypes to export their API to 
JavaScript so they can be used by an Angular UI or similar. If it would be the 
default then lots of apps would miss optimization opportunities just because 
they use the libraries and might not use any pure js at all.

This is especially harmful as the flag is an all or nothing flag. So you have 
to explicitly decide to export to JS. in the future you should also be able to 
define a regex which tells the compiler which classes to export. This will be 
helpful if you depend on multiple such libraries but your app only needs to 
export one if them as well.

-- J.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/e7654865-f07e-4b45-8b82-dd8ebbb0b113%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: A possible JsInterop issue in GWT 2.8 RC2

[Boris Brudnoy]

Yes, field names return to being named in JavaScript as declared in Java
after the addition of the -generateJsInteropExports compiler parameter. Why
isn't this the default compiler behavior, though? After all, I followed the
JsInterop spec, which, in @JsType section
,
states:

"The contract says that any instance behind this interface must have
methods or properties with the original name in JavaScript (i.e not
renamed, not pruned)."
"As the class is annotated with @JsType, it will preserve its original
names for all of its public API. This makes the class easily accessible
from JavaScript"


On Fri, Aug 19, 2016 at 3:38 PM Jens  wrote:

> @JsType with isNative = false (the default) are probably treated as normal
> classes now if you do not use -generateJsInteropExports as compiler
> parameter. I guess it works again if you use the compiler parameter?
>
> -- J.
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit-contributors/3f124c9c-f38b-413b-91c9-ab1c0c741e24%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>
-- 
*BORIS BRUDNOY*
Web Application Developer, Java/GWT Enthusiast (LinkedIn
)

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAD%3DgKQ2SR1Tp0TrZ3midfYcRRz%2BiGb9C-vKL8eO7XRa65pWNtA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[gwt-contrib] Re: A possible JsInterop issue in GWT 2.8 RC2

[Jens]

@JsType with isNative = false (the default) are probably treated as normal 
classes now if you do not use -generateJsInteropExports as compiler 
parameter. I guess it works again if you use the compiler parameter?

-- J.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/3f124c9c-f38b-413b-91c9-ab1c0c741e24%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.