[gwt-contrib] Re: Comment on IE8Support in google-web-toolkit
Comment by t.broyer: This page has last been updated on Feb 4th of 2010, nearly 2 years ago; and it starts with IE8 was recently released, so it's quite clear that it's outdated. See http://code.google.com/webtoolkit/release-notes.html#Release_Notes_1_7_0 which says: This release adds explicit support for Internet Explorer 8 For more information: http://code.google.com/p/google-web-toolkit/wiki/IE8Support -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
For historical purposes, I figured out a working solution ( at least it works for me) and posted it in the gwt-maven-plugin user group. https://groups.google.com/forum/#!topic/codehaus-mojo-gwt-maven-plugin-users/Lha85tfYiz4 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/diff/4017/samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml File samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml (left): http://gwt-code-reviews.appspot.com/1547804/diff/4017/samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml#oldcode19 samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml:19: system-properties Have you tried deploying to GAE without this? I thought it was required. http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
Back to all apt all the time. I've learned the lesson from Jeff, but don't need most of it. * We're using build-helper to expose target/generated-sources/apt as a source path (no need for clean up under the target umbrella). * We also don't need his resource setting because we are not generating client code * And there is no need to turn on Eclipse's built in apt support unless you want the very cool red squiggles http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
Also, David: I confirmed that we can deploy without that logging stuff, no harm. http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
Jeff's fix good, no GPE change required! http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10651 committed - The DynaTable RF and Mobile Web App samples now use requestfactory-apt...
Revision: 10651
Author: rj...@google.com
Date: Fri Sep 16 10:13:44 2011
Log: The DynaTable RF and Mobile Web App samples now use
requestfactory-apt to
generate the decoder needed by the rf server.
Also drops some unneeded config from mwa
Works with GPE
Review at http://gwt-code-reviews.appspot.com/1547804/
Review by: drfibona...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10651
Deleted:
/trunk/samples/mobilewebapp/src/main/java/META-INF
Modified:
/trunk/samples/dynatablerf/pom.xml
/trunk/samples/mobilewebapp/pom.xml
/trunk/samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml
/trunk/samples/validation/pom.xml
===
--- /trunk/samples/dynatablerf/pom.xml Mon Sep 12 09:46:24 2011
+++ /trunk/samples/dynatablerf/pom.xml Fri Sep 16 10:13:44 2011
@@ -1,6 +1,8 @@
?xml version=1.0 encoding=UTF-8?
-project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
+project
+ xmlns=http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
modelVersion4.0.0/modelVersion
groupIdcom.google.gwt.sample.dynatablerf/groupId
@@ -23,23 +25,42 @@
/properties
dependencies
-!-- Google Web Toolkit (GWT) itself --
+!-- Google Web Toolkit (GWT) --
dependency
groupIdcom.google.gwt/groupId
- !-- Could use requestfactory-server instead --
- artifactIdgwt-servlet/artifactId
+ artifactIdgwt-user/artifactId
version${gwtVersion}/version
- scoperuntime/scope
+ !-- provided so that we don't deploy --
+ scopeprovided/scope
/dependency
+
+!-- For the servlet filter --
+
dependency
- groupIdcom.google.gwt/groupId
- artifactIdgwt-user/artifactId
+ groupIdjavax.servlet/groupId
+ artifactIdservlet-api/artifactId
+ version2.5/version
+/dependency
+
+!-- RequestFactory server --
+
+dependency
+ groupIdcom.google.web.bindery/groupId
+ artifactIdrequestfactory-server/artifactId
version${gwtVersion}/version
- scopeprovided/scope
/dependency
-!-- GWT RequestFactory will use JSR 303 javax.validation if you let
it --
+!-- Generate the decoder needed by RequestFactory Server --
+!-- Doesn't yet work in eclipse. See maven-processor-plugin below.
+dependency
+ groupIdcom.google.web.bindery/groupId
+ artifactIdrequestfactory-apt/artifactId
+ version${gwtVersion}/version
+/dependency
+--
+
+!-- RequestFactory will use JSR 303 javax.validation if you let it --
dependency
groupIdjavax.validation/groupId
artifactIdvalidation-api/artifactId
@@ -62,25 +83,8 @@
/exclusions
/dependency
-!-- GWT RequestFactory requires org.json --
-!-- TODO: can we declare the json and validation dependencies
somewhere for the world to pick up,
-rather than requiring everyone to know about them? --
-dependency
- groupIdorg.json/groupId
- artifactIdjson/artifactId
- version20090211/version
-/dependency
-
-!-- for the servlet filter --
-dependency
- groupIdjavax.servlet/groupId
- artifactIdservlet-api/artifactId
- version2.5/version
-/dependency
-
!-- Required by Hibernate validator because slf4j-log4j is
- optional in the hibernate-validator POM
- --
+ optional in the hibernate-validator POM --
dependency
groupIdorg.slf4j/groupId
artifactIdslf4j-log4j12/artifactId
@@ -94,10 +98,62 @@
/dependencies
build
-!-- Generate compiled stuff in the folder used for developing mode --
+!-- Generate compiled stuff in the folder used for development mode
--
outputDirectory${project.build.directory}/${project.build.finalName}/WEB-INF/classes/outputDirectory
plugins
+ !-- requestfactory-apt runs an annotation processor (APT) to
+ instrument its service interfaces so that
+ RequestFactoryServer can decode client requests. Normally
+ you would just have a dependency on requestfactory-apt
+ with scopeprovided/scope, but that won't work in
+ eclipse due to m2e bug
+ https://bugs.eclipse.org/bugs/show_bug.cgi?id=335036 --
+ plugin
+groupIdorg.bsc.maven/groupId
+artifactIdmaven-processor-plugin/artifactId
+version2.0.5/version
+executions
+ execution
+idprocess/id
+goals
+ goalprocess/goal
+/goals
+phasegenerate-sources/phase
+ /execution
+/executions
+dependencies
+ dependency
+groupIdcom.google.web.bindery/groupId
+
[gwt-contrib] Remove uneeded samples checkstyle exception. (issue1548804)
Reviewers: rjrjr,
Description:
Remove uneeded samples checkstyle exception.
Add a comment explaining the remaining exception
Please review this at http://gwt-code-reviews.appspot.com/1548804/
Affected files:
M samples/common.ant.xml
Index: samples/common.ant.xml
===
--- samples/common.ant.xml (revision 8405)
+++ samples/common.ant.xml (working copy)
@@ -189,7 +189,7 @@
target name=checkstyle description=Static analysis of source
gwt.checkstyle outputdirectory=${sample.build}
fileset dir=src
-exclude name=main/java/org/**/super/org/**/*.java/
+!-- ValidationMessages is generated and has funny method names --
exclude
name=main/java/com/google/gwt/sample/validation*/**/ValidationMessages.java
/
/fileset
/gwt.checkstyle
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10653 committed - Changed lifecycle mapping for exec-maven-plugin to maven-processor-plu...
Revision: 10653 Author: drfibona...@google.com Date: Fri Sep 16 14:53:25 2011 Log: Changed lifecycle mapping for exec-maven-plugin to maven-processor-plugin http://code.google.com/p/google-web-toolkit/source/detail?r=10653 Modified: /wiki/WorkingWithMaven.wiki === --- /wiki/WorkingWithMaven.wiki Mon Sep 12 11:34:00 2011 +++ /wiki/WorkingWithMaven.wiki Fri Sep 16 14:53:25 2011 @@ -105,11 +105,11 @@ /pluginExecution pluginExecution pluginExecutionFilter -groupIdorg.codehaus.mojo/groupId -artifactIdexec-maven-plugin/artifactId -versionRange[1.2,)/versionRange +groupIdorg.bsc.maven/groupId +artifactIdmaven-processor-plugin/artifactId +versionRange[2.0.5,)/versionRange goals - goalexec/goal + goalprocess/goal /goals /pluginExecutionFilter action -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove uneeded samples checkstyle exception. (issue1548804)
On 2011/09/16 21:23:38, Nick Chalko wrote: LGTM http://gwt-code-reviews.appspot.com/1548804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10654 committed - Remove uneeded samples checkstyle exception....
Revision: 10654
Author: ncha...@google.com
Date: Fri Sep 16 12:34:41 2011
Log: Remove uneeded samples checkstyle exception.
Add a comment explaining the remaining exception
Review at http://gwt-code-reviews.appspot.com/1548804
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10654
Modified:
/trunk/samples/common.ant.xml
===
--- /trunk/samples/common.ant.xml Wed Sep 14 06:33:50 2011
+++ /trunk/samples/common.ant.xml Fri Sep 16 12:34:41 2011
@@ -189,7 +189,7 @@
target name=checkstyle description=Static analysis of source
gwt.checkstyle outputdirectory=${sample.build}
fileset dir=src
-exclude name=main/java/org/**/super/org/**/*.java/
+!-- ValidationMessages is generated and has funny method names --
exclude
name=main/java/com/google/gwt/sample/validation*/**/ValidationMessages.java
/
/fileset
/gwt.checkstyle
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10655 committed - Integrates r10651 to releases/2.4, DynaTable RF and Mobile Web App sam...
Revision: 10655
Author: gwt.mirror...@gmail.com
Date: Fri Sep 16 15:47:37 2011
Log: Integrates r10651 to releases/2.4, DynaTable RF and Mobile Web
App samples now use requestfactory-apt
http://code.google.com/p/google-web-toolkit/source/detail?r=10655
Deleted:
/releases/2.4/samples/mobilewebapp/src/main/java/META-INF
Modified:
/releases/2.4/samples/dynatablerf/pom.xml
/releases/2.4/samples/mobilewebapp/pom.xml
/releases/2.4/samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml
/releases/2.4/samples/validation/pom.xml
===
--- /releases/2.4/samples/dynatablerf/pom.xml Tue Sep 13 08:28:51 2011
+++ /releases/2.4/samples/dynatablerf/pom.xml Fri Sep 16 15:47:37 2011
@@ -1,6 +1,8 @@
?xml version=1.0 encoding=UTF-8?
-project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
+project
+ xmlns=http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
modelVersion4.0.0/modelVersion
groupIdcom.google.gwt.sample.dynatablerf/groupId
@@ -23,23 +25,42 @@
/properties
dependencies
-!-- Google Web Toolkit (GWT) itself --
+!-- Google Web Toolkit (GWT) --
dependency
groupIdcom.google.gwt/groupId
- !-- Could use requestfactory-server instead --
- artifactIdgwt-servlet/artifactId
+ artifactIdgwt-user/artifactId
version${gwtVersion}/version
- scoperuntime/scope
+ !-- provided so that we don't deploy --
+ scopeprovided/scope
/dependency
+
+!-- For the servlet filter --
+
dependency
- groupIdcom.google.gwt/groupId
- artifactIdgwt-user/artifactId
+ groupIdjavax.servlet/groupId
+ artifactIdservlet-api/artifactId
+ version2.5/version
+/dependency
+
+!-- RequestFactory server --
+
+dependency
+ groupIdcom.google.web.bindery/groupId
+ artifactIdrequestfactory-server/artifactId
version${gwtVersion}/version
- scopeprovided/scope
/dependency
-!-- GWT RequestFactory will use JSR 303 javax.validation if you let
it --
+!-- Generate the decoder needed by RequestFactory Server --
+!-- Doesn't yet work in eclipse. See maven-processor-plugin below.
+dependency
+ groupIdcom.google.web.bindery/groupId
+ artifactIdrequestfactory-apt/artifactId
+ version${gwtVersion}/version
+/dependency
+--
+
+!-- RequestFactory will use JSR 303 javax.validation if you let it --
dependency
groupIdjavax.validation/groupId
artifactIdvalidation-api/artifactId
@@ -62,25 +83,8 @@
/exclusions
/dependency
-!-- GWT RequestFactory requires org.json --
-!-- TODO: can we declare the json and validation dependencies
somewhere for the world to pick up,
-rather than requiring everyone to know about them? --
-dependency
- groupIdorg.json/groupId
- artifactIdjson/artifactId
- version20090211/version
-/dependency
-
-!-- for the servlet filter --
-dependency
- groupIdjavax.servlet/groupId
- artifactIdservlet-api/artifactId
- version2.5/version
-/dependency
-
!-- Required by Hibernate validator because slf4j-log4j is
- optional in the hibernate-validator POM
- --
+ optional in the hibernate-validator POM --
dependency
groupIdorg.slf4j/groupId
artifactIdslf4j-log4j12/artifactId
@@ -94,10 +98,62 @@
/dependencies
build
-!-- Generate compiled stuff in the folder used for developing mode --
+!-- Generate compiled stuff in the folder used for development mode
--
outputDirectory${project.build.directory}/${project.build.finalName}/WEB-INF/classes/outputDirectory
plugins
+ !-- requestfactory-apt runs an annotation processor (APT) to
+ instrument its service interfaces so that
+ RequestFactoryServer can decode client requests. Normally
+ you would just have a dependency on requestfactory-apt
+ with scopeprovided/scope, but that won't work in
+ eclipse due to m2e bug
+ https://bugs.eclipse.org/bugs/show_bug.cgi?id=335036 --
+ plugin
+groupIdorg.bsc.maven/groupId
+artifactIdmaven-processor-plugin/artifactId
+version2.0.5/version
+executions
+ execution
+idprocess/id
+goals
+ goalprocess/goal
+/goals
+phasegenerate-sources/phase
+ /execution
+/executions
+dependencies
+ dependency
+groupIdcom.google.web.bindery/groupId
+artifactIdrequestfactory-apt/artifactId
+version${gwtVersion}/version
+ /dependency
+/dependencies
+
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/diff/8/samples/dynatablerf/pom.xml File samples/dynatablerf/pom.xml (right): http://gwt-code-reviews.appspot.com/1547804/diff/8/samples/dynatablerf/pom.xml#newcode136 samples/dynatablerf/pom.xml:136: as an additional source dir-- Probably want to call out here (or somewhere else) that they will actually want to try to find the m2e connector. I know I've gotten used to just always hitting the permanently ignore button since there are so few connectors currently. http://gwt-code-reviews.appspot.com/1547804/diff/8/samples/mobilewebapp/pom.xml File samples/mobilewebapp/pom.xml (right): http://gwt-code-reviews.appspot.com/1547804/diff/8/samples/mobilewebapp/pom.xml#newcode208 samples/mobilewebapp/pom.xml:208: as an additional source dir-- ditto http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Do RF validation via APT instead of command line. (issue1547804)
http://gwt-code-reviews.appspot.com/1547804/diff/8/samples/dynatablerf/pom.xml File samples/dynatablerf/pom.xml (right): http://gwt-code-reviews.appspot.com/1547804/diff/8/samples/dynatablerf/pom.xml#newcode136 samples/dynatablerf/pom.xml:136: as an additional source dir-- It basically auto-installed, so I think they'll figure it out. http://gwt-code-reviews.appspot.com/1547804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
