Re: [GRASS-dev] pywin32 missing

2019-05-16 Thread Helmut Kudrnovsky
Helmut Kudrnovsky wrote
> Anna Petrášová wrote
>>> which is the relevant xml-file?
>>>
>> 
>> it creates gui/wxpython/xml/menudata.xml and module_tree_menudata.xml
>> during compilation.
> 
> module_tree_menudata.xml is empty here. I have to wait for the next daily
> build to test.

daily winGRASS trunk is at r74479-24, so 1 behind r74480: pythonlib: cleanup
decoding/encoding in scripting library

let's see the next daily build




-
best regards
Helmut
--
Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Helmut Kudrnovsky
Martin Landa wrote
> čt 16. 5. 2019 v 8:25 odesílatel Helmut Kudrnovsky 

> hellik@

>  napsal:
>> https://trac.osgeo.org/grass/browser/grass-addons/tools/svn2git
>>
>> which file should be updated/checked?
> 
> tools/svn2git/AUTHORS.txt

AUTHORS.txt updated in svn to primary gh email




-
best regards
Helmut
--
Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] Migration to GitHub: please check your account name and email for contributor recognition!

2019-05-16 Thread Markus Neteler
Dear all,

we have identified ~180 contributors to GRASS GIS since 12/1999 (first
day of CVS code repository which was then changed to SVN later on).
Addon, sandbox and promo repository authors are included.

In order to properly identify as many contributors as possible, please:

- check the CVS/SVN account name and corresponding github account
name/email in the lookup table here:
  https://svn.osgeo.org/grass/grass-addons/tools/svn2git/AUTHORS.txt

- if you spot errors, omissions or mistakes, please let me know or fix
directly in the table.

Note: things can also be fixed after the migration but preferably we'd
like to get it right TODAY.

thanks much,
Markus
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3838: r74307 breaks GUI: UnicodeDecodeError

2019-05-16 Thread GRASS GIS
#3838: r74307 breaks GUI: UnicodeDecodeError
--+-
  Reporter:  marisn   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  wxGUI|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Linux
--+-

Comment (by marisn):

 Replying to [comment:11 pmav99]:
 > Dear Maris
 >
 > Could you please try the following patch:

 Yes, this patch solves most of problems. At least I can start GUI and do
 some simple things.

 I still see a new error when I try to run some raster modules with GUI
 (d.rast; d.rgb; r.lake):
 {{{
 'ascii' codec can't decode byte 0xc4 in position 3: ordinal not in
 range(128)
 }}}
 with following in the console:
 {{{
 Traceback (most recent call last):
   File "/home/maris/soft/grass_trunk/dist.x86_64-pc-linux-
 gnu/gui/wxpython/gui_core/forms.py", line 2499, in
 OnUpdateDialog

 self.parent.updateValuesHook()
   File "/home/maris/soft/grass_trunk/dist.x86_64-pc-linux-
 gnu/gui/wxpython/gui_core/forms.py", line 770, in
 updateValuesHook

 ignoreErrors=True)]))
 TypeError
 :
 'NoneType' object is not iterable
 }}}
 Still it is hard to say if it is related or a different set of problems.
 For sure before the r74307 they were absent.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3846: r.contour started producing broken/segmented contour lines since 7.4

2019-05-16 Thread GRASS GIS
#3846: r.contour started producing broken/segmented contour lines since 7.4
--+---
  Reporter:  metello  |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  Raster   |Version:  unspecified
Resolution:   |   Keywords:  r.contour ​helpwanted
   CPU:  x86-64   |   Platform:  MSWindows
--+---
Changes (by metello):

 * keywords:  r.contour => r.contour ​helpwanted


-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS-user] Early "warning": upcoming switch of SVN to readonly mode for planned GitHub migration

2019-05-16 Thread Stefan Blumentrath
Great news! Thanks to all contributing to this effort!

From: grass-user  on behalf of Markus 
Neteler 
Sent: Thursday, May 16, 2019 6:27:52 PM
To: GRASS-announce list
Cc: GRASS user list; GRASS developers list
Subject: [GRASS-user] Early "warning": upcoming switch of SVN to readonly mode 
for planned GitHub migration

Hi,

later tonight or tomorrow (Friday, May 17th, 2010) we'll switch the
GRASS GIS svn server to readonly-mode, in order make the GitHub
migration [1] possible.

Goal: have the repo up and running on Saturday (May 18th, 2019) for
the upcoming community sprint.

Some downtime of half a day or so cannot be avoided.
Git experts: please be available for questions :-)

@devs: please keep your upcoming commits locally and don't miss to
upload them later on to git(hub).

Thanks
Markus

[1] https://trac.osgeo.org/grass/wiki/GitMigration
___
grass-user mailing list
grass-u...@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-user
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] Early "warning": upcoming switch of SVN to readonly mode for planned GitHub migration

2019-05-16 Thread Markus Neteler
Hi,

later tonight or tomorrow (Friday, May 17th, 2010) we'll switch the
GRASS GIS svn server to readonly-mode, in order make the GitHub
migration [1] possible.

Goal: have the repo up and running on Saturday (May 18th, 2019) for
the upcoming community sprint.

Some downtime of half a day or so cannot be avoided.
Git experts: please be available for questions :-)

@devs: please keep your upcoming commits locally and don't miss to
upload them later on to git(hub).

Thanks
Markus

[1] https://trac.osgeo.org/grass/wiki/GitMigration
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Vaclav Petras
On Thu, May 16, 2019 at 8:26 AM Bas Couwenberg  wrote:
>
> On 2019-05-16 14:16, Markus Neteler wrote:
> >  External contributors
> > # workflow for external contributors - they have to fork the repo in
> > GitHub Web interface
> > # create fork via github GUI
> > git clone $my_for_url
> > # all steps see above
> > ...
> > # push feature branch to own fork repo of GRASS GIS
> > git push origin $feature_branch_name   # here: origin is fork repo
> > # create pull request in GitHub Web interface (the link is shown in
> > the terminal)
>
> May I suggest cloning the grass repo and adding the fork as an
> additional remote, this makes merging changes from the grass repo
> easier.
> ...

+1 for Markus, Carmen, and Bas. That's what I see used elsewhere too.
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3838: r74307 breaks GUI: UnicodeDecodeError

2019-05-16 Thread GRASS GIS
#3838: r74307 breaks GUI: UnicodeDecodeError
--+-
  Reporter:  marisn   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  wxGUI|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Linux
--+-

Comment (by pmav99):

 Dear Maris

 Could you please try the following patch:
 {{{
 index 1183e93b..0bd515b2 100644
 --- lib/python/__init__.py
 +++ lib/python/__init__.py
 @@ -1,6 +1,8 @@
  import gettext
  import os

 +import six
 +
  # Setup i18N
  #
  # Calling `gettext.install()` injects `_()` in the builtins namespace and
 @@ -17,9 +19,14 @@ import os
  # - https://www.wefearchange.org/2012/06/the-right-way-to-
 internationalize-your.html
  #
  _LOCALE_DIR = os.path.join(os.getenv("GISBASE"), 'locale')
 -gettext.install('grasslibs', _LOCALE_DIR)
 -gettext.install('grassmods', _LOCALE_DIR)
 -gettext.install('grasswxpy', _LOCALE_DIR)
 +if six.PY2:
 +gettext.install('grasslibs', _LOCALE_DIR, unicode=True)
 +gettext.install('grassmods', _LOCALE_DIR, unicode=True)
 +gettext.install('grasswxpy', _LOCALE_DIR, unicode=True)
 +else:
 +gettext.install('grasslibs', _LOCALE_DIR)
 +gettext.install('grassmods', _LOCALE_DIR)
 +gettext.install('grasswxpy', _LOCALE_DIR)


  __all__ = ["script", "temporal"]
 }}}

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Bas Couwenberg

On 2019-05-16 14:16, Markus Neteler wrote:

 External contributors
# workflow for external contributors - they have to fork the repo in
GitHub Web interface
# create fork via github GUI
git clone $my_for_url
# all steps see above
...
# push feature branch to own fork repo of GRASS GIS
git push origin $feature_branch_name   # here: origin is fork repo
# create pull request in GitHub Web interface (the link is shown in
the terminal)


May I suggest cloning the grass repo and adding the fork as an 
additional remote, this makes merging changes from the grass repo 
easier.


 git clone https://github.com/OSGeo/grass.git
 cd grass
 git remote add github https://github.com//grass.git
 git remote set-url --push github 
ssh://g...@github.com//grass.git

 ...
 git push github 

This way origin is the authoritative source for the code, and additional 
remotes are forks.


Kind Regards,

Bas
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Markus Neteler
On Thu, May 16, 2019 at 1:30 PM Vaclav Petras  wrote:
>
>
>
> On Thu, May 16, 2019 at 2:07 AM Martin Landa  wrote:
>>
>> Hi,
>>
>> st 15. 5. 2019 v 18:20 odesílatel Vaclav Petras  
>> napsal:
>> > Another thing is the need for new contributing guidelines. Git is not 
>> > Subversion and committing to master won't work
...
>
> That's the tricky part. The direct commit-push workflow brings issues and 
> projects tend to avoid it.

Agreed. Here two draft workflows, for
- core devs, and
- external contributors.



### Core developers
# workflow for core-developers, no fork needed but using feature
branches on master

# 
vim ...
# fetch all branches from all remotes
git fetch --all
# list existing branches:
git branch -a

# create new local branch (pick a new name for feature_branch_name)
git checkout -b $feature_branch_name

# list local changes
git status
git add file1.c file2.py ...
git commit -m 'my change with reasonable explanation...'

# push feature branch to origin, i.e. original GRASS GIS repo master
git push origin $feature_branch_name
# create pull request in GitHub Web interface (the link is shown in
the terminal)

# during PR review phase, make more local changes if needed
git add .
git commit -m 'my second change'
git push origin $feature_branch_name
# . will be added to existing pull request

# NOTE: for different pull requests, simply create different feature branches.

 External contributors
# workflow for external contributors - they have to fork the repo in
GitHub Web interface
# create fork via github GUI
git clone $my_for_url
# all steps see above
...
# push feature branch to own fork repo of GRASS GIS
git push origin $feature_branch_name   # here: origin is fork repo
# create pull request in GitHub Web interface (the link is shown in
the terminal)

Certainly we need to write this up in a Wiki page.

Thanks to Carmen Tawalika for drafting the workflow.

Best,
Markus
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Vaclav Petras
On Thu, May 16, 2019 at 2:07 AM Martin Landa  wrote:

> Hi,
>
> st 15. 5. 2019 v 18:20 odesílatel Vaclav Petras 
> napsal:
> > Another thing is the need for new contributing guidelines. Git is not
> Subversion and committing to master won't work (please, let me know if you
> want me to show some examples). What other OSGeo projects are doing is that
> contributing guidelines say that you should do pull request. It seems that
> this is often preferred way even for core developers. From what I gathered
> from a small sample of people at OSGeo sprint, the core devs don't go
> though fork, but they do go through a branch. In GitHub, we can set
> "Require pull request reviews before merging" and "Include administrators"
> for the master branch to enforce that. I think we should do it at least at
> the beginning.
>
> I tend to agree. Contributes with a write access should do PR for
> massive/tricky changes. It's perfect platform to discuss/improve
> changes before merging. Trivial changes can be committed/pushed
> directly, no PR needed.
>

That's the tricky part. The direct commit-push workflow brings issues and
projects tend to avoid it. The most direct access is (usually?) going
through a branch in a main repo and merging that (merging through GitHub
PR). The point of PR is not only discussion but also testing. The CI should
run for every commit (chunk of commits in PR to be exact) before it goes
into master.

Additionally, it there are simply no trivial changes. Even a change in
documentation page can introduce an HTML tag not recognized by g.html2man
causing compilation to fail. Similarly, with asynchronous commits you are
at risk of conflicts and always in need of merge and the question is how
you want this to be recorded in code history. With Subversion, each
developer needs to resolve that before commit individually. With Git, you
can have history with locally created automatic merge commits, you need do
git pull --rebase locally, or you need to do PRs*.

I'm not saying this because I particularly like that, but because that's
how Git/GitHub** is used and that's what we are signing up for.

* PRs are called merge requests in GitLab; perhaps hinting more on what
they are for.
** This is not limited to GitHub, for example, GitLab by default locks
master when you create a new repo.

Vaclav
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3838: r74307 breaks GUI: UnicodeDecodeError

2019-05-16 Thread GRASS GIS
#3838: r74307 breaks GUI: UnicodeDecodeError
--+-
  Reporter:  marisn   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  wxGUI|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Linux
--+-

Comment (by marisn):

 Replying to [comment:8 pmav99]:
 > and I still can't reproduce the error. The GUI opens without any
 tracebacks.
 Please try to run GRASS in a following way:LC_ALL=lv_LV.UTF-8
 LANG=lv_LV.UTF-8 LANGUAGE=lv_LV.UTF-8 grass77

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3838: r74307 breaks GUI: UnicodeDecodeError

2019-05-16 Thread GRASS GIS
#3838: r74307 breaks GUI: UnicodeDecodeError
--+-
  Reporter:  marisn   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  wxGUI|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Linux
--+-

Comment (by pmav99):

 Replying to [comment:6 annakrat]:
 > Yes, we need to support both Python 2 and 3, and wxPython 3 and 4, at
 least for some time.

 In that case, CI should build GRASS for all supported combinations.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3838: r74307 breaks GUI: UnicodeDecodeError

2019-05-16 Thread GRASS GIS
#3838: r74307 breaks GUI: UnicodeDecodeError
--+-
  Reporter:  marisn   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  wxGUI|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Linux
--+-

Comment (by pmav99):

 Just tried this with:

 - OS: Archlinux
 - Linux: 5.0.13
 - Python: 2.7.16
 - wxPython: 3.0.2.0.1
 - wxgtk**3**: 3.0.4-2

 and I still can't reproduce the error. The GUI opens without any
 tracebacks.

 I do get the same warning as @marisn:
 {{{
 Launching  GUI in the background, please wait...
 10:37:23: Warning: Mismatch between the program and library build versions
 detected.
 The library used 3.0 (wchar_t,compiler with C++ ABI 1013,wx
 containers,compatible with 2.8),
 and wxPython used 3.0 (wchar_t,compiler with C++ ABI 1011,wx
 containers,compatible with 2.8).
 /usr/lib/python2.7/site-packages/wx-3.0-gtk3/wx/_core.py:16629:
 UserWarning: wxPython/wxWidgets release number mismatch
   warnings.warn("wxPython/wxWidgets release number mismatch")
 }}}
 but this is related to the version mismatch between the installed versions
 of wxgtk3 and wxpython, which should not be relevant to the issue at hand.

 This might be related to GTK2 vs GKT3 after all. Those of you who can
 reproduce this, can you please post wxpython and GTK versions?

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Stefan Blumentrath
Hi,

Being no developer by education I can only second this!

Guidelines and simple, minimal example workflows would be very, very welcome 
(we learned fork->branch->commit->pull request (and then?, how do I keep my 
fork in sync, ...) ! I also agree that we should be vary of duplicating git 
documentation but rather have minimal description of recommended workflows, 
starting with the most common cases (which of course can evolve over time) and 
point to more lengthy explanations other places. Just like: 
https://trac.osgeo.org/grass/wiki/HowToSVN#SVNusage

git also has some pitfalls people should be aware of, like e.g. handling of 
line endings:
https://help.github.com/en/articles/dealing-with-line-endings
These can be pretty annoying, but circumvented if taken into account early on...

And then there are some more possible git adjustments (in the codebase), like 
proper markdown formating of the README as well as probably some stuff from 
here:
https://github.com/grass-svn2git/grass/community (yes, I am aware that this is 
not the final repo)

Thanks for the massive work, Martin (and others involved). Looking forward to 
GRASS on git!

Cheers
Stefan



Currently, I am struggling in another project with line endings which makes 
contributions across plattforms complicated...


-Original Message-
From: grass-dev  On Behalf Of Luca Delucchi
Sent: onsdag 15. mai 2019 22:21
To: Veronica Andreo 
Cc: Martin Landa ; grass-dev 
Subject: Re: [GRASS-dev] svn/trac -> git/github migration plan

On Wed, 15 May 2019 at 21:40, Veronica Andreo  wrote:
>
> Hi,
>

Hi,


>> Another thing is the need for new contributing guidelines. Git is not 
>> Subversion and committing to master won't work (please, let me know if you 
>> want me to show some examples).
>
>
> I am very interested in such examples, esp. how the workflow will be from now 
> on for example when making a small change in manuals.
>

Yes, it is important to know this. How to use branches and also how to update 
local version from the master one. Should we use a private clone and make pull 
request to the main repository o use the main repository directly?

> I think it is very important that those of you more familiar with git and 
> GitHub develop or show example workflows of how to contribute, backport (if 
> that will be still called like that), and so on.
>

+1

> my 0.01 cent
> Vero
>

--
ciao
Luca

www.lucadelu.org
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3838: r74307 breaks GUI: UnicodeDecodeError

2019-05-16 Thread GRASS GIS
#3838: r74307 breaks GUI: UnicodeDecodeError
--+-
  Reporter:  marisn   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  wxGUI|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Linux
--+-

Comment (by pmav99):

 Replying to [comment:6 annakrat]:
 > Regarding this ticket, I believe it's Python 2 vs 3 problem, not wx 3 vs
 4.

 I could not reproduce this either on Python2 or Python3. That's why I
 suggested that it might be related to WX. I tried again on current trunk
 and I still can't reproduce it. I will try to install wx3 on my virtualenv
 and report back.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Martin Landa
čt 16. 5. 2019 v 8:25 odesílatel Helmut Kudrnovsky  napsal:
> https://trac.osgeo.org/grass/browser/grass-addons/tools/svn2git
>
> which file should be updated/checked?

tools/svn2git/AUTHORS.txt

Ma

-- 
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Helmut Kudrnovsky
Martin Landa wrote
> Hi,
> 
> st 15. 5. 2019 v 21:32 odesílatel Helmut Kudrnovsky 

> hellik@

>  napsal:
>> svn: hellik
>>
>> gh account: hellik
>> email: 

> hkmyricaria@

> 
> in the case you have write access to Addons, you can directly modify
> the file :-) Thanks, Ma

I have write access :-).

https://trac.osgeo.org/grass/browser/grass-addons/tools/svn2git

which file should be updated/checked?




-
best regards
Helmut
--
Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Martin Landa
Hi,

st 15. 5. 2019 v 21:32 odesílatel Helmut Kudrnovsky  napsal:
> svn: hellik
>
> gh account: hellik
> email: hkmyrica...@gmail.com

in the case you have write access to Addons, you can directly modify
the file :-) Thanks, Ma

-- 
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Martin Landa
Hi,

st 15. 5. 2019 v 18:47 odesílatel Markus Neteler  napsal:
> This are the authors who have a GitHub account known to us. There is a lookup 
> table which maps SVN account to GitHub account (in addons/tools/svn2git 
> somewhere).

http://trac.osgeo.org/grass/browser/grass-addons/tools/svn2git/AUTHORS.txt

Please check if you are on the list. This list contains all
contributors including Addons!

Ma

-- 
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] svn/trac -> git/github migration plan

2019-05-16 Thread Martin Landa
Hi,

st 15. 5. 2019 v 18:20 odesílatel Vaclav Petras  napsal:
> Another thing is the need for new contributing guidelines. Git is not 
> Subversion and committing to master won't work (please, let me know if you 
> want me to show some examples). What other OSGeo projects are doing is that 
> contributing guidelines say that you should do pull request. It seems that 
> this is often preferred way even for core developers. From what I gathered 
> from a small sample of people at OSGeo sprint, the core devs don't go though 
> fork, but they do go through a branch. In GitHub, we can set "Require pull 
> request reviews before merging" and "Include administrators" for the master 
> branch to enforce that. I think we should do it at least at the beginning.

I tend to agree. Contributes with a write access should do PR for
massive/tricky changes. It's perfect platform to discuss/improve
changes before merging. Trivial changes can be committed/pushed
directly, no PR needed.

+1 my cent

Ma

-- 
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev