Re: Cosmetical change: remove inconsistent "$file ends here"?

[Ludovic Courtès]

Alex Kost  skribis:

> ng0 (2016-09-24 20:00 +) wrote:
>
>> We should either be consistent with this in all files or remove this
>> altogether in my opinion.
>>
>>> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here"
>>> gnu/build/vm.scm:323:;;; vm.scm ends here
> ...
>> What do you think?
>
> I don't know what the original purpose of this convention is, it was
> probably invented in those ancient times when dinosaurs walked by
> streets, but I kinda like these "ends here" things :-)

Yeah, I add them occasionally out of habit, but it’s not useful.

> Anyway, I vote for leaving them and adding the missing ones.

I vote for the status quo.  :-)  There’s not much value in spending time
either way IMO.

Ludo’.

Re: Cosmetical change: remove inconsistent "$file ends here"?

[Andy Wingo]

On Mon 26 Sep 2016 10:32, Christopher Allan Webber  
writes:

> It feels like cruft that nobody knows the reason for, or has a good
> reason in this modern age.  I'd rather they just be trimmed.
>
> But I also don't feel like it matters much, so whatever is decided is
> decided. :)

For what it's worth: +1 from me.  These things have cost in terms of
linting, code review, need for explaining to new people, and visual
ceremony, and they have very little benefit if any.

But, also like Christopher, I don't care strongly :)

Andy

Re: Cosmetical change: remove inconsistent "$file ends here"?

[Christopher Allan Webber]

ng0 writes:

> Alex Kost  writes:
>
>> ng0 (2016-09-24 20:00 +) wrote:
>>
>>> We should either be consistent with this in all files or remove this
>>> altogether in my opinion.
>>>
 ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here"
 gnu/build/vm.scm:323:;;; vm.scm ends here
>> ...
>>> What do you think?
>>
>> I don't know what the original purpose of this convention is, it was
>> probably invented in those ancient times when dinosaurs walked by
>> streets, but I kinda like these "ends here" things :-)
>>
>> The only purpose I see in using them: you can be sure that there will
>> not appear redundant newlines (introduced by untidy commits) in the end
>> of files.
>>
>> Anyway, I vote for leaving them and adding the missing ones.
>
> Okay, with your explanation this is the more reasonable thing to do.

I'm really fine either way, but that doesn't feel like a super
compelling reason to me.  Who cares if there's a redundant newline at
the end of the file?  Sure, it should be swept up, but one redundant
newline costs a lot less than "don't let any newlines after this".
Plus, do we have proof that no newlines will really appear afterwards?

It feels like cruft that nobody knows the reason for, or has a good
reason in this modern age.  I'd rather they just be trimmed.

But I also don't feel like it matters much, so whatever is decided is
decided. :)

Re: Cosmetical change: remove inconsistent "$file ends here"?

[John Darrington]

On Sun, Sep 25, 2016 at 07:55:48PM +0200, Vincent Legoll wrote:
 On Sun, Sep 25, 2016 at 7:45 PM, Hartmut Goebel
  wrote:
 > Am 25.09.2016 um 11:38 schrieb Danny Milosavljevic:
 >> That's probably enough reason to remove them.
 >
 > +1
 
 +1, but please do not post a patchbomb^Wseries for review on the ML,
 just script it
 and merge at the most appropriate time wrt rebuilding the world...

Such a change won't cause anything to be rebuilt.

J'

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.



signature.asc
Description: Digital signature

Re: Cosmetical change: remove inconsistent "$file ends here"?

[Vincent Legoll]

On Sun, Sep 25, 2016 at 7:45 PM, Hartmut Goebel
 wrote:
> Am 25.09.2016 um 11:38 schrieb Danny Milosavljevic:
>> That's probably enough reason to remove them.
>
> +1

+1, but please do not post a patchbomb^Wseries for review on the ML,
just script it
and merge at the most appropriate time wrt rebuilding the world...

-- 
Vincent Legoll

Re: Cosmetical change: remove inconsistent "$file ends here"?

[Hartmut Goebel]

Am 25.09.2016 um 11:38 schrieb Danny Milosavljevic:
> That's probably enough reason to remove them.

+1

-- 
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: Cosmetical change: remove inconsistent "$file ends here"?

[Danny Milosavljevic]

Hi,

On Sun, 25 Sep 2016 11:30:41 +0300
Alex Kost  wrote:
> I don't know what the original purpose of this convention is,

That's probably enough reason to remove them.

> it was
> probably invented in those ancient times when dinosaurs walked by
> streets, but I kinda like these "ends here" things :-)
> 
> The only purpose I see in using them: you can be sure that there will
> not appear redundant newlines (introduced by untidy commits) in the end
> of files.

I speculate it's that when you print source code out you know that you are not 
missing a sheet when you take them with you. Doesn't really serve a purpose now 
(also, diff tools show you if you forget the newline before the end of file - 
also many editors do, even nano). 

That said, touching it at all causes churn - not sure what the upside is.

Re: Cosmetical change: remove inconsistent "$file ends here"?

[John Darrington]

On Sun, Sep 25, 2016 at 11:30:41AM +0300, Alex Kost wrote:
 ng0 (2016-09-24 20:00 +) wrote:
 
 > We should either be consistent with this in all files or remove this
 > altogether in my opinion.
 >
 >> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here"
 >> gnu/build/vm.scm:323:;;; vm.scm ends here
 ...
 > What do you think?
 
 I don't know what the original purpose of this convention is, it was
 probably invented in those ancient times when dinosaurs walked by
 streets, but I kinda like these "ends here" things :-)
 
 The only purpose I see in using them: you can be sure that there will
 not appear redundant newlines (introduced by untidy commits) in the end
 of files.
 
 Anyway, I vote for leaving them and adding the missing ones.
 

I have a better idea.  Let's remove these verbose messages, and write an API,
which is capable of opening and streaming files , we could call those functions 
- 
for example  - "fopen" and "fread".  But here comes the clever bit:   We also
provide a function - let's call it "feof".

This approach will have the advantage that we could use this API to write things
called "editors" which might display some user friendly string such as "End of 
buffer" 
when the end is encountered.

Once these tools are developed, we could inform the community that they no 
longer
need to put the string "file ends here" at the end of their files.

WDYT ?


-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.



signature.asc
Description: Digital signature

Re: Cosmetical change: remove inconsistent "$file ends here"?

[ng0]

Alex Kost  writes:

> ng0 (2016-09-24 20:00 +) wrote:
>
>> We should either be consistent with this in all files or remove this
>> altogether in my opinion.
>>
>>> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here"
>>> gnu/build/vm.scm:323:;;; vm.scm ends here
> ...
>> What do you think?
>
> I don't know what the original purpose of this convention is, it was
> probably invented in those ancient times when dinosaurs walked by
> streets, but I kinda like these "ends here" things :-)
>
> The only purpose I see in using them: you can be sure that there will
> not appear redundant newlines (introduced by untidy commits) in the end
> of files.
>
> Anyway, I vote for leaving them and adding the missing ones.

Okay, with your explanation this is the more reasonable thing to do.

> -- 
> Alex
>

-- 
  ng0

Re: Cosmetical change: remove inconsistent "$file ends here"?

[Alex Kost]

ng0 (2016-09-24 20:00 +) wrote:

> We should either be consistent with this in all files or remove this
> altogether in my opinion.
>
>> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here"
>> gnu/build/vm.scm:323:;;; vm.scm ends here
...
> What do you think?

I don't know what the original purpose of this convention is, it was
probably invented in those ancient times when dinosaurs walked by
streets, but I kinda like these "ends here" things :-)

The only purpose I see in using them: you can be sure that there will
not appear redundant newlines (introduced by untidy commits) in the end
of files.

Anyway, I vote for leaving them and adding the missing ones.

-- 
Alex