[jira] [Commented] (HDDS-136) Rename dbPath,containerFilePath

2018-07-09 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537577#comment-16537577
 ] 

Hudson commented on HDDS-136:
-

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14547 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14547/])
HDDS-136:Rename dbPath,containerFilePath. Contributed by Bharat (bharat: rev 
7e228e54c56598e263d66e3ef74476e12a3b1f30)
* (edit) 
hadoop-hdds/container-service/src/test/resources/additionalfields.container
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/KeyValueYaml.java
* (edit) hadoop-hdds/container-service/src/test/resources/incorrect.container
* (edit) 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestKeyValueContainerData.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/KeyValueContainerData.java
* (edit) 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestKeyValueYaml.java


> Rename dbPath,containerFilePath
> ---
>
> Key: HDDS-136
> URL: https://issues.apache.org/jira/browse/HDDS-136
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-136-HDDS-48.00.patch, HDDS-136-HDDS-48.01.patch, 
> HDDS-136-HDDS-48.02.patch
>
>
> In KeyValueContainerData, we need to update 
> dbPath as - containerMetaDataPath (As it holds rockdb/leveldb file and 
> .container file)
> chunksLocation - location of the chunk files
>  
> It will be cleaner if we rename these variables and it will be easy for 
> reading the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-136) Rename dbPath,containerFilePath

2018-06-11 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508659#comment-16508659
 ] 

genericqa commented on HDDS-136:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 4 new or modified test 
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 35m 
 4s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
18s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
30s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 13s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 47s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
37s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
28s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 64m 47s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-136 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12927355/HDDS-136-HDDS-48.02.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 6a967daeb0a0 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDDS-48 / 143dd56 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDDS-Build/282/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDDS-Build/282/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 336 (vs. ulimit of 1) |
| modules | C: hadoop-hdds/container-service U: hadoop-hdds/container-service |
| Console output | 
https://builds.apache.org/job/PreCommit-HDDS-Build/282/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Rename dbPath,containerFilePath
> ---
>

[jira] [Commented] (HDDS-136) Rename dbPath,containerFilePath

2018-06-11 Thread Bharat Viswanadham (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508539#comment-16508539
 ] 

Bharat Viswanadham commented on HDDS-136:
-

[~hanishakoneru] Thanks for review.

Changed containerMetaDataPath to metadataPath in patch v02.

 

 

> Rename dbPath,containerFilePath
> ---
>
> Key: HDDS-136
> URL: https://issues.apache.org/jira/browse/HDDS-136
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-136-HDDS-48.00.patch, HDDS-136-HDDS-48.01.patch, 
> HDDS-136-HDDS-48.02.patch
>
>
> In KeyValueContainerData, we need to update 
> dbPath as - containerMetaDataPath (As it holds rockdb/leveldb file and 
> .container file)
> chunksLocation - location of the chunk files
>  
> It will be cleaner if we rename these variables and it will be easy for 
> reading the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-136) Rename dbPath,containerFilePath

2018-06-11 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508502#comment-16508502
 ] 

genericqa commented on HDDS-136:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 4 new or modified test 
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 29m 
20s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
43s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m 39s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
42s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 37s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
34s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
26s{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 61m 25s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-136 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12927340/HDDS-136-HDDS-48.01.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux ca7f0c4e3987 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDDS-48 / 143dd56 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDDS-Build/280/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDDS-Build/280/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 301 (vs. ulimit of 1) |
| modules | C: hadoop-hdds/container-service U: hadoop-hdds/container-service |
| Console output | 
https://builds.apache.org/job/PreCommit-HDDS-Build/280/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Rename dbPath,containerFilePath
> ---

[jira] [Commented] (HDDS-136) Rename dbPath,containerFilePath

2018-06-11 Thread Hanisha Koneru (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508471#comment-16508471
 ] 

Hanisha Koneru commented on HDDS-136:
-

Thanks for the patch [~bharatviswa].

LGTM overall. Just one suggestion - It might be good to rename 
{{containerMetaDataPath}} to something shorter like {{metadataPath}}. 

+1 pending Jenkins.

> Rename dbPath,containerFilePath
> ---
>
> Key: HDDS-136
> URL: https://issues.apache.org/jira/browse/HDDS-136
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-136-HDDS-48.00.patch, HDDS-136-HDDS-48.01.patch
>
>
> In KeyValueContainerData, we need to update 
> dbPath as - containerMetaDataPath (As it holds rockdb/leveldb file and 
> .container file)
> chunksLocation - location of the chunk files
>  
> It will be cleaner if we rename these variables and it will be easy for 
> reading the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-136) Rename dbPath,containerFilePath

2018-06-11 Thread Bharat Viswanadham (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508411#comment-16508411
 ] 

Bharat Viswanadham commented on HDDS-136:
-

Rebased the patch to apply to HDDS-48 branch.

> Rename dbPath,containerFilePath
> ---
>
> Key: HDDS-136
> URL: https://issues.apache.org/jira/browse/HDDS-136
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-136-HDDS-48.00.patch, HDDS-136-HDDS-48.01.patch
>
>
> In KeyValueContainerData, we need to update 
> dbPath as - containerMetaDataPath (As it holds rockdb/leveldb file and 
> .container file)
> chunksLocation - location of the chunk files
>  
> It will be cleaner if we rename these variables and it will be easy for 
> reading the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-136) Rename dbPath,containerFilePath

2018-06-11 Thread Bharat Viswanadham (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508330#comment-16508330
 ] 

Bharat Viswanadham commented on HDDS-136:
-

Current patch is not applying to trunk.

Will upload a new patch.

> Rename dbPath,containerFilePath
> ---
>
> Key: HDDS-136
> URL: https://issues.apache.org/jira/browse/HDDS-136
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-136-HDDS-48.00.patch
>
>
> In KeyValueContainerData, we need to update 
> dbPath as - containerMetaDataPath (As it holds rockdb/leveldb file and 
> .container file)
> chunksLocation - location of the chunk files
>  
> It will be cleaner if we rename these variables and it will be easy for 
> reading the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-136) Rename dbPath,containerFilePath

2018-06-11 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508272#comment-16508272
 ] 

genericqa commented on HDDS-136:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} 
| {color:red} HDDS-136 does not apply to HDDS-48. Rebase required? Wrong 
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDDS-136 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12925975/HDDS-136-HDDS-48.00.patch
 |
| Console output | 
https://builds.apache.org/job/PreCommit-HDDS-Build/279/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Rename dbPath,containerFilePath
> ---
>
> Key: HDDS-136
> URL: https://issues.apache.org/jira/browse/HDDS-136
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Attachments: HDDS-136-HDDS-48.00.patch
>
>
> In KeyValueContainerData, we need to update 
> dbPath as - containerMetaDataPath (As it holds rockdb/leveldb file and 
> .container file)
> chunksLocation - location of the chunk files
>  
> It will be cleaner if we rename these variables and it will be easy for 
> reading the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-136) Rename dbPath,containerFilePath

2018-05-31 Thread Bharat Viswanadham (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497065#comment-16497065
 ] 

Bharat Viswanadham commented on HDDS-136:
-

This patch is dependant on HDDS-123 and HDDS-133.

> Rename dbPath,containerFilePath
> ---
>
> Key: HDDS-136
> URL: https://issues.apache.org/jira/browse/HDDS-136
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Attachments: HDDS-136-HDDS-48.00.patch
>
>
> In KeyValueContainerData, we need to update 
> dbPath as - containerMetaDataPath (As it holds rockdb/leveldb file and 
> .container file)
> chunksLocation - location of the chunk files
>  
> It will be cleaner if we rename these variables and it will be easy for 
> reading the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org