[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-09 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537587#comment-16537587
 ] 

Hudson commented on HDDS-182:
-

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14547 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14547/])
HDDS-182:CleanUp Reimplemented classes. Contributed by Hansiha Koneru (bharat: 
rev 2c2351e87b60d3e8b50b94e9ca5ab78d7afae783)
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
* (edit) 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainer.java
* (add) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java
* (edit) 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/metrics/TestContainerMetrics.java
* (edit) hadoop-hdds/container-service/src/test/resources/incorrect.container
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ChunkManagerImpl.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ChunkUtils.java
* (edit) 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/testutils/BlockDeletingServiceTestImpl.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/background/package-info.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/KeyUtils.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerData.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerData.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/ChunkManagerImpl.java
* (edit) 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueHandler.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/ChunkUtils.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/Dispatcher.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeSet.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerUtils.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/interfaces/KeyManager.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/RandomContainerDeletionChoosingPolicy.java
* (edit) 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestVolumeSet.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerData.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/interfaces/ChunkManager.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerManagerImpl.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
* (edit) 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestRoundRobinVolumeChoosingPolicy.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/interfaces/ContainerManager.java
* (edit) 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java
* (delete) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/background/BlockDeletingService.java
* (add) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/package-info.java
* (edit) 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDeletionChoosingPolicy.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/TopNOrderedContainerDeletionChoosingPolicy.java
* (edit) 
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/genesis/BenchMarkDatanodeDispatcher.java
* (edit) 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/server/TestContainerServer.java
* (edit) 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestSCMCli.java
* (edit) 

[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-05 Thread genericqa (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534357#comment-16534357
 ] 

genericqa commented on HDDS-182:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 18 new or modified test 
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m  
4s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 46m 
32s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 35m 
28s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
25s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 
24s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
14m  7s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  
5s{color} | {color:red} hadoop-hdds/container-service in HDDS-48 has 4 extant 
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
28s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
56s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 30m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 30m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 15s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
14s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
56s{color} | {color:green} hadoop-hdds/container-service generated 0 new + 2 
unchanged - 2 fixed = 2 total (was 4) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
52s{color} | {color:red} hadoop-ozone/tools generated 1 new + 0 unchanged - 0 
fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} hadoop-hdds_container-service generated 0 new + 2 
unchanged - 3 fixed = 2 total (was 5) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} tools in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} integration-test in the patch passed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
22s{color} | {color:green} common in the patch 

[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-05 Thread Bharat Viswanadham (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534227#comment-16534227
 ] 

Bharat Viswanadham commented on HDDS-182:
-

Thank You [~hanishakoneru] for updated patch.

+1 for V03 patch.

> CleanUp Reimplemented classes
> -
>
> Key: HDDS-182
> URL: https://issues.apache.org/jira/browse/HDDS-182
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: HDDS-182-HDDS-48.001.patch, HDDS-182-HDDS-48.002.patch, 
> HDDS-182-HDDS-48.003.patch
>
>
> Cleanup container-service's ozone.container.common package. The following 
> classes have been refactored and re-implemented. The unused classes/ methods 
> should be cleaned up.
>  # org.apache.hadoop.ozone.container.common.helpers.ChunkUtils
>  # org.apache.hadoop.ozone.container.common.helpers.KeyUtils
>  # org.apache.hadoop.ozone.container.common.helpers.ContainerData
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
>  # org.apache.hadoop.ozone.container.common.impl.ChunkManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.KeyManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.ContainerManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
> Also, fix integration tests broken by deleting these classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-05 Thread Hanisha Koneru (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534216#comment-16534216
 ] 

Hanisha Koneru commented on HDDS-182:
-

Thanks for catching it, [~bharatviswa].

Removed the checks.

> CleanUp Reimplemented classes
> -
>
> Key: HDDS-182
> URL: https://issues.apache.org/jira/browse/HDDS-182
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: HDDS-182-HDDS-48.001.patch, HDDS-182-HDDS-48.002.patch, 
> HDDS-182-HDDS-48.003.patch
>
>
> Cleanup container-service's ozone.container.common package. The following 
> classes have been refactored and re-implemented. The unused classes/ methods 
> should be cleaned up.
>  # org.apache.hadoop.ozone.container.common.helpers.ChunkUtils
>  # org.apache.hadoop.ozone.container.common.helpers.KeyUtils
>  # org.apache.hadoop.ozone.container.common.helpers.ContainerData
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
>  # org.apache.hadoop.ozone.container.common.impl.ChunkManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.KeyManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.ContainerManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
> Also, fix integration tests broken by deleting these classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-05 Thread Bharat Viswanadham (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534091#comment-16534091
 ] 

Bharat Viswanadham commented on HDDS-182:
-

Hi [~hanishakoneru] 

Thanks for the patch.

Just one minor comment, do we need below code in ContainerData.java, as those 
are primitive fields.

Preconditions.checkNotNull(containerId);
Preconditions.checkNotNull(layOutVersion);

> CleanUp Reimplemented classes
> -
>
> Key: HDDS-182
> URL: https://issues.apache.org/jira/browse/HDDS-182
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: HDDS-182-HDDS-48.001.patch, HDDS-182-HDDS-48.002.patch
>
>
> Cleanup container-service's ozone.container.common package. The following 
> classes have been refactored and re-implemented. The unused classes/ methods 
> should be cleaned up.
>  # org.apache.hadoop.ozone.container.common.helpers.ChunkUtils
>  # org.apache.hadoop.ozone.container.common.helpers.KeyUtils
>  # org.apache.hadoop.ozone.container.common.helpers.ContainerData
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
>  # org.apache.hadoop.ozone.container.common.impl.ChunkManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.KeyManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.ContainerManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
> Also, fix integration tests broken by deleting these classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-05 Thread Hanisha Koneru (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534067#comment-16534067
 ] 

Hanisha Koneru commented on HDDS-182:
-

Thanks [~bharatviswa].
Addressed the review comments and some junit and findbug errors.

> CleanUp Reimplemented classes
> -
>
> Key: HDDS-182
> URL: https://issues.apache.org/jira/browse/HDDS-182
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: HDDS-182-HDDS-48.001.patch, HDDS-182-HDDS-48.002.patch
>
>
> Cleanup container-service's ozone.container.common package. The following 
> classes have been refactored and re-implemented. The unused classes/ methods 
> should be cleaned up.
>  # org.apache.hadoop.ozone.container.common.helpers.ChunkUtils
>  # org.apache.hadoop.ozone.container.common.helpers.KeyUtils
>  # org.apache.hadoop.ozone.container.common.helpers.ContainerData
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
>  # org.apache.hadoop.ozone.container.common.impl.ChunkManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.KeyManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.ContainerManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
> Also, fix integration tests broken by deleting these classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-05 Thread Bharat Viswanadham (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534026#comment-16534026
 ] 

Bharat Viswanadham commented on HDDS-182:
-

Thank you [~hanishakoneru] for the patch. Over all patch LGTM.
 
1.Container.java
 
Unused imports L21, L22
 
2. TestKeyValueHandler.java
We should remove waitFor, as dispatcher.dispatch is a blocking call

> CleanUp Reimplemented classes
> -
>
> Key: HDDS-182
> URL: https://issues.apache.org/jira/browse/HDDS-182
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: HDDS-182-HDDS-48.001.patch
>
>
> Cleanup container-service's ozone.container.common package. The following 
> classes have been refactored and re-implemented. The unused classes/ methods 
> should be cleaned up.
>  # org.apache.hadoop.ozone.container.common.helpers.ChunkUtils
>  # org.apache.hadoop.ozone.container.common.helpers.KeyUtils
>  # org.apache.hadoop.ozone.container.common.helpers.ContainerData
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
>  # org.apache.hadoop.ozone.container.common.impl.ChunkManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.KeyManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.ContainerManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
> Also, fix integration tests broken by deleting these classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-03 Thread genericqa (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531867#comment-16531867
 ] 

genericqa commented on HDDS-182:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 17 new or modified test 
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m 
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m 
10s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m 
43s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
25s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
44s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m 22s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
51s{color} | {color:red} hadoop-hdds/container-service in HDDS-48 has 4 extant 
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
27s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 28m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 56s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
58s{color} | {color:red} hadoop-hdds/container-service generated 1 new + 2 
unchanged - 2 fixed = 3 total (was 4) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
51s{color} | {color:red} hadoop-ozone/tools generated 1 new + 0 unchanged - 0 
fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
36s{color} | {color:green} hadoop-hdds_container-service generated 0 new + 2 
unchanged - 3 fixed = 2 total (was 5) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} tools in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} integration-test in the patch passed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  1m  4s{color} 
| {color:red} container-service in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
32s{color} | {color:green} tools in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 14m 11s{color} 
| {color:red} integration-test in the patch failed. 

[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-02 Thread Hanisha Koneru (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530573#comment-16530573
 ] 

Hanisha Koneru commented on HDDS-182:
-

Fixed the following integration tests in this patch
# TestContainerPersistence
# TestContainerServer
# TestSCMCli - Ignoring this test for now. Will open a new Jira to fix this.

> CleanUp Reimplemented classes
> -
>
> Key: HDDS-182
> URL: https://issues.apache.org/jira/browse/HDDS-182
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: HDDS-182-HDDS-48.000.patch
>
>
> Cleanup container-service's ozone.container.common package. The following 
> classes have been refactored and re-implemented. The unused classes/ methods 
> should be cleaned up.
>  # org.apache.hadoop.ozone.container.common.helpers.ChunkUtils
>  # org.apache.hadoop.ozone.container.common.helpers.KeyUtils
>  # org.apache.hadoop.ozone.container.common.helpers.ContainerData
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
>  # org.apache.hadoop.ozone.container.common.impl.ChunkManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.KeyManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.ContainerManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
> Also, fix integration tests broken by deleting these classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-182) CleanUp Reimplemented classes

2018-07-02 Thread Hanisha Koneru (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530570#comment-16530570
 ] 

Hanisha Koneru commented on HDDS-182:
-

This patch is dependent on HDDS-205.

> CleanUp Reimplemented classes
> -
>
> Key: HDDS-182
> URL: https://issues.apache.org/jira/browse/HDDS-182
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: HDDS-182-HDDS-48.000.patch
>
>
> Cleanup container-service's ozone.container.common package. The following 
> classes have been refactored and re-implemented. The unused classes/ methods 
> should be cleaned up.
>  # org.apache.hadoop.ozone.container.common.helpers.ChunkUtils
>  # org.apache.hadoop.ozone.container.common.helpers.KeyUtils
>  # org.apache.hadoop.ozone.container.common.helpers.ContainerData
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
>  # org.apache.hadoop.ozone.container.common.impl.ChunkManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.KeyManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.ContainerManagerImpl
>  # org.apache.hadoop.ozone.container.common.impl.Dispatcher
> Also, fix integration tests broken by deleting these classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org