[jira] [Commented] (HDDS-808) Simplify OMAction and DNAction classes used for AuditLogging
[ https://issues.apache.org/jira/browse/HDDS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703532#comment-16703532 ] Dinesh Chitlangia commented on HDDS-808: [~ajayydv] Thanks for review & commit. > Simplify OMAction and DNAction classes used for AuditLogging > > > Key: HDDS-808 > URL: https://issues.apache.org/jira/browse/HDDS-808 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Ozone Datanode, Ozone Manager >Affects Versions: 0.4.0 >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: logging > Attachments: HDDS-808.001.patch > > > While reviewing HDDS-120, [~ajayydv] suggested to simplify these class by > removing the constructor and the getAction(). > Refer review comment: > https://issues.apache.org/jira/browse/HDDS-120?focusedCommentId=16670495=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16670495 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-808) Simplify OMAction and DNAction classes used for AuditLogging
[ https://issues.apache.org/jira/browse/HDDS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703514#comment-16703514 ] Hudson commented on HDDS-808: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15528 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/15528/]) HDDS-808. Simplify OMAction and DNAction classes used for AuditLogging. (ajay: rev 184cced513c5599d7b33c9124692fbcd2e6d338e) * (edit) hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/DummyAction.java * (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/audit/DNAction.java * (edit) hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/audit/OMAction.java > Simplify OMAction and DNAction classes used for AuditLogging > > > Key: HDDS-808 > URL: https://issues.apache.org/jira/browse/HDDS-808 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Ozone Datanode, Ozone Manager >Affects Versions: 0.4.0 >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: logging > Attachments: HDDS-808.001.patch > > > While reviewing HDDS-120, [~ajayydv] suggested to simplify these class by > removing the constructor and the getAction(). > Refer review comment: > https://issues.apache.org/jira/browse/HDDS-120?focusedCommentId=16670495=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16670495 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-808) Simplify OMAction and DNAction classes used for AuditLogging
[ https://issues.apache.org/jira/browse/HDDS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703423#comment-16703423 ] Ajay Kumar commented on HDDS-808: - +1 > Simplify OMAction and DNAction classes used for AuditLogging > > > Key: HDDS-808 > URL: https://issues.apache.org/jira/browse/HDDS-808 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Ozone Datanode, Ozone Manager >Affects Versions: 0.4.0 >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: logging > Attachments: HDDS-808.001.patch > > > While reviewing HDDS-120, [~ajayydv] suggested to simplify these class by > removing the constructor and the getAction(). > Refer review comment: > https://issues.apache.org/jira/browse/HDDS-120?focusedCommentId=16670495=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16670495 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-808) Simplify OMAction and DNAction classes used for AuditLogging
[ https://issues.apache.org/jira/browse/HDDS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692585#comment-16692585 ] Dinesh Chitlangia commented on HDDS-808: failure unrelated to patch > Simplify OMAction and DNAction classes used for AuditLogging > > > Key: HDDS-808 > URL: https://issues.apache.org/jira/browse/HDDS-808 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Ozone Datanode, Ozone Manager >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: logging > Attachments: HDDS-808.001.patch > > > While reviewing HDDS-120, [~ajayydv] suggested to simplify these class by > removing the constructor and the getAction(). > Refer review comment: > https://issues.apache.org/jira/browse/HDDS-120?focusedCommentId=16670495=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16670495 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-808) Simplify OMAction and DNAction classes used for AuditLogging
[
https://issues.apache.org/jira/browse/HDDS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692545#comment-16692545
]
Hadoop QA commented on HDDS-808:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 8m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
15m 31s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
21s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 34s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 37s{color}
| {color:red} common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 33s{color}
| {color:red} common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}107m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-808 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12948782/HDDS-808.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux daf24c048f5e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / b5d7b29 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/1765/artifact/out/patch-unit-hadoop-hdds_common.txt
|
| unit |
[jira] [Commented] (HDDS-808) Simplify OMAction and DNAction classes used for AuditLogging
[ https://issues.apache.org/jira/browse/HDDS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692452#comment-16692452 ] Dinesh Chitlangia commented on HDDS-808: [~ajayydv] - Gotcha. Attached patch 001 for your review. > Simplify OMAction and DNAction classes used for AuditLogging > > > Key: HDDS-808 > URL: https://issues.apache.org/jira/browse/HDDS-808 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Ozone Datanode, Ozone Manager >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: logging > > While reviewing HDDS-120, [~ajayydv] suggested to simplify these class by > removing the constructor and the getAction(). > Refer review comment: > https://issues.apache.org/jira/browse/HDDS-120?focusedCommentId=16670495=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16670495 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-808) Simplify OMAction and DNAction classes used for AuditLogging
[ https://issues.apache.org/jira/browse/HDDS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692411#comment-16692411 ] Ajay Kumar commented on HDDS-808: - [~dineshchitlangia] My comment was about enum classes. We don't need those String constructors. We can keep getAction and return corresponding string value of enum variable. I am also fine with making AuditAction a marker interface. > Simplify OMAction and DNAction classes used for AuditLogging > > > Key: HDDS-808 > URL: https://issues.apache.org/jira/browse/HDDS-808 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: Ozone Datanode, Ozone Manager >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: logging > > While reviewing HDDS-120, [~ajayydv] suggested to simplify these class by > removing the constructor and the getAction(). > Refer review comment: > https://issues.apache.org/jira/browse/HDDS-120?focusedCommentId=16670495=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16670495 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-808) Simplify OMAction and DNAction classes used for AuditLogging
[
https://issues.apache.org/jira/browse/HDDS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692182#comment-16692182
]
Dinesh Chitlangia commented on HDDS-808:
Currently, interface AuditAction is implemented by OMAction, DNAction which
define the respective actions.
{code:java}
public interface AuditAction {
/**
* Implementation must override.
* @return String
*/
String getAction();
}
{code}
As proposed in this jira, if we are to remove {{getAction()}}, then the
interface itself becomes pointless and we might as well remove this interface
altogether.
I am fine with removing this interface.
[~ajayydv] , [~anu] - thoughts?
> Simplify OMAction and DNAction classes used for AuditLogging
>
>
> Key: HDDS-808
> URL: https://issues.apache.org/jira/browse/HDDS-808
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode, Ozone Manager
>Reporter: Dinesh Chitlangia
>Assignee: Dinesh Chitlangia
>Priority: Minor
> Labels: logging
>
> While reviewing HDDS-120, [~ajayydv] suggested to simplify these class by
> removing the constructor and the getAction().
> Refer review comment:
> https://issues.apache.org/jira/browse/HDDS-120?focusedCommentId=16670495=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16670495
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
