[jira] [Commented] (HDFS-10764) Fix INodeFile#getBlocks to not return null
[
https://issues.apache.org/jira/browse/HDFS-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429238#comment-15429238
]
Hudson commented on HDFS-10764:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10315 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10315/])
HDFS-10764. Fix INodeFile#getBlocks to not return null. Contributed by (jing9:
rev 0faee62a0c8c1b8fd83227babfd00fbc2b26bddf)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
> Fix INodeFile#getBlocks to not return null
> --
>
> Key: HDFS-10764
> URL: https://issues.apache.org/jira/browse/HDFS-10764
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0-alpha2
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Fix For: 2.8.0
>
> Attachments: HDFS-10764.01.patch
>
>
> Not all callers of INodeFile#getBlocks check for null. e.g.
> {code}
> public final QuotaCounts storagespaceConsumedContiguous(
> BlockStoragePolicy bsp) {
> ...
> // Collect all distinct blocks
> Set allBlocks = new HashSet<>(Arrays.asList(getBlocks()));
> {code}
> We can either fix each caller or alternatively fix getBlocks to never return
> null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10764) Fix INodeFile#getBlocks to not return null
[
https://issues.apache.org/jira/browse/HDFS-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429234#comment-15429234
]
Jing Zhao commented on HDFS-10764:
--
And thanks a lot for the contribution, [~arpitagarwal]!
> Fix INodeFile#getBlocks to not return null
> --
>
> Key: HDFS-10764
> URL: https://issues.apache.org/jira/browse/HDFS-10764
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0-alpha2
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Fix For: 2.8.0
>
> Attachments: HDFS-10764.01.patch
>
>
> Not all callers of INodeFile#getBlocks check for null. e.g.
> {code}
> public final QuotaCounts storagespaceConsumedContiguous(
> BlockStoragePolicy bsp) {
> ...
> // Collect all distinct blocks
> Set allBlocks = new HashSet<>(Arrays.asList(getBlocks()));
> {code}
> We can either fix each caller or alternatively fix getBlocks to never return
> null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10764) Fix INodeFile#getBlocks to not return null
[
https://issues.apache.org/jira/browse/HDFS-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423122#comment-15423122
]
Hadoop QA commented on HDFS-10764:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 57m 32s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 76m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestBootstrapStandby |
| | hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12823775/HDFS-10764.01.patch |
| JIRA Issue | HDFS-10764 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux ca64cda4cd8b 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / b427ce1 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/16441/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/16441/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/16441/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Fix INodeFile#getBlocks to not return null
> --
>
> Key: HDFS-10764
> URL: https://issues.apache.org/jira/browse/HDFS-10764
> Project: Hadoop
[jira] [Commented] (HDFS-10764) Fix INodeFile#getBlocks to not return null
[
https://issues.apache.org/jira/browse/HDFS-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423103#comment-15423103
]
Jing Zhao commented on HDFS-10764:
--
The patch looks good to me. +1 pending Jenkins.
> Fix INodeFile#getBlocks to not return null
> --
>
> Key: HDFS-10764
> URL: https://issues.apache.org/jira/browse/HDFS-10764
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-10764.01.patch
>
>
> Not all callers of INodeFile#getBlocks check for null. e.g.
> {code}
> public final QuotaCounts storagespaceConsumedContiguous(
> BlockStoragePolicy bsp) {
> ...
> // Collect all distinct blocks
> Set allBlocks = new HashSet<>(Arrays.asList(getBlocks()));
> {code}
> We can either fix each caller or alternatively fix getBlocks to never return
> null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10764) Fix INodeFile#getBlocks to not return null
[
https://issues.apache.org/jira/browse/HDFS-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421844#comment-15421844
]
Arpit Agarwal commented on HDFS-10764:
--
v01 patch avoid setting INodeFile#blocks to null.
Thanks to [~jingzhao] for taking a look at an earlier version of this change
offline!
> Fix INodeFile#getBlocks to not return null
> --
>
> Key: HDFS-10764
> URL: https://issues.apache.org/jira/browse/HDFS-10764
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-10764.01.patch
>
>
> Not all callers of INodeFile#getBlocks check for null. e.g.
> {code}
> public final QuotaCounts storagespaceConsumedContiguous(
> BlockStoragePolicy bsp) {
> ...
> // Collect all distinct blocks
> Set allBlocks = new HashSet<>(Arrays.asList(getBlocks()));
> {code}
> We can either fix each caller or alternatively fix getBlocks to never return
> null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
