[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455131#comment-16455131
]
Hudson commented on HDFS-12030:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14070/])
HDFS-12030. Ozone: CLI: support infoKey command. Contributed by Yiqun (omalley:
rev 5379ffa8de3ac3fb0cf4020b8e815e76249a34d2)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/InfoKeyHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/localstorage/OzoneMetadataManager.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/web/client/TestKeys.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/handlers/KeyHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/interfaces/Keys.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/localstorage/LocalStorageHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/storage/DistributedStorageHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ksm/TestKeySpaceManager.java
* (add)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ozShell/TestOzoneShell.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/interfaces/StorageHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/client/OzoneBucket.java
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
>Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch,
> HDFS-12030-HDFS-7240.004.patch, HDFS-12030-HDFS-7240.005.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450881#comment-16450881
]
Hudson commented on HDFS-12030:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HDFS-12030. Ozone: CLI: support infoKey command. Contributed by Yiqun (wwei:
rev b3c8f9c810ec995f30f868ac2ecb92e23290c004)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ksm/TestKeySpaceManager.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/web/client/TestKeys.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/interfaces/Keys.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/interfaces/StorageHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/localstorage/LocalStorageHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/storage/DistributedStorageHandler.java
* (add)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ozShell/TestOzoneShell.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/handlers/KeyHandler.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/localstorage/OzoneMetadataManager.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/client/OzoneBucket.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/InfoKeyHandler.java
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
>Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch,
> HDFS-12030-HDFS-7240.004.patch, HDFS-12030-HDFS-7240.005.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071286#comment-16071286
]
Weiwei Yang commented on HDFS-12030:
Just committed to the feature branch, thanks for [~linyiqun]'s effort to get
this done and thanks for [~xyao] and [~anu]'s review.
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch,
> HDFS-12030-HDFS-7240.004.patch, HDFS-12030-HDFS-7240.005.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071282#comment-16071282
]
Weiwei Yang commented on HDFS-12030:
Hi [~linyiqun]
The latest patch looks good to me, +1. I have tested the patch and it works
nicely. I will commit this shortly. Thank you.
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch,
> HDFS-12030-HDFS-7240.004.patch, HDFS-12030-HDFS-7240.005.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071109#comment-16071109
]
Hadoop QA commented on HDFS-12030:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m
43s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
4s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
8s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 69m 2s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}100m 21s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.container.ozoneimpl.TestOzoneContainer |
| | hadoop.ozone.container.common.TestDatanodeStateMachine |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140 |
| | hadoop.ozone.container.ozoneimpl.TestOzoneContainerRatis |
| | hadoop.ozone.container.ozoneimpl.TestRatisManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12030 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875363/HDFS-12030-HDFS-7240.005.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux b70660dfa725 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | HDFS-7240 / 2708e62 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/20125/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/20125/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/20125/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqu
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070965#comment-16070965
]
Weiwei Yang commented on HDFS-12030:
Hi [~linyiqun]
Thanks for the updates! It seems you added a {{key-info}} query parameter, that
is still against the design. Please take a look at the [design
doc|https://issues.apache.org/jira/secure/attachment/12799549/ozone_user_v0.pdf],
page 38, info key. The rest api schema is
{code}
GET /{volume}/{bucket}/{key}?info=key
{code}
and also we should make sure get key API schema is
{code}
GET /{volume}/{bucket}/{key}
{code}
So I guess we still need following changes
*Keys.java*
Remove default value for query parameter {{info}}, so in the handler we can
handle this like
* if {{info}} is null -> call getkey
* if {{info}} is key -> call getKeyInfo
* if {{info}} is some other strings -> invalid query parameter
Please remove non-used import.
*OzoneBucket.java*
line 528, 529 when sets up the http request to get key info, instead of using
{{info=key-info}}, change to use {{info=key}}.
*KeyHandler.java*
Instead of using a switch statement to check info value {{key}} or
{{key-info}}, lets check {{null}} (query header not set) or {{info}}.
Please fix java doc for {{#getKey}}, also some arguments seem to be missing or
mismatch in java doc.
Please let me know if this makes sense, thank you!
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch,
> HDFS-12030-HDFS-7240.004.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070117#comment-16070117
]
Hadoop QA commented on HDFS-12030:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m
23s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
32s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
54s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
47s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 32s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 73m 36s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}100m 3s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.web.TestWebHdfsTimeouts |
| | hadoop.ozone.container.ozoneimpl.TestOzoneContainerRatis |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010 |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 |
| | hadoop.ozone.container.ozoneimpl.TestRatisManager |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
|
| Timed out junit tests |
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12030 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875232/HDFS-12030-HDFS-7240.004.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux f10b7b784c82 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | HDFS-7240 / ba64776 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/20118/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/20118/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/20118/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/20118/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was a
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069853#comment-16069853
]
Weiwei Yang commented on HDFS-12030:
Thanks [~anu] for the comments, I agree. Since [~xyao] is out, [~linyiqun]
could you please post a new patch with respect to the rest API. I would be
happy to help to test and review. Thank you.
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069335#comment-16069335
]
Anu Engineer commented on HDFS-12030:
-
[~linyiqun] My vote is to go the way suggested by [~cheersyang]. Simply because
it keeps the REST protocol consistent. I would presume that is more important
than the internal consistency. I certainly prefer this as a query param than a
path param. I not even sure if can have this as a path param, due to issues
mentioned by [~cheersyang]
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067634#comment-16067634
]
Weiwei Yang commented on HDFS-12030:
Thanks [~linyiqun] for confirming that. Yes, lets wait for [~xyao]'s response.
Thank you!
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067626#comment-16067626
]
Yiqun Lin commented on HDFS-12030:
--
Hi [~cheersyang],
bq. But I doubt if getKey would still work if you give a default value to query
parameter "info"...
It will run okay. in v01 patch, I used {{OZONE_LIST_QUERY_KEY}} for getKey and
new defined {{OZONE_LIST_QUERY_KEY_INFO}} for getKeyInfo. The var
{{OZONE_LIST_QUERY_KEY}} is default value, so getKey request will still run
well. I have tested this when I worked for v01 patch. Let's wait for [~xyao]
the response.
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066736#comment-16066736
]
Weiwei Yang commented on HDFS-12030:
Hi [~linyiqun]
I see. I actually was expecting something like your v1 patch as that respects
the API design. But I doubt if getKey would still work if you give a default
value to query parameter "info"
{code}
+ @DefaultValue(Header.OZONE_LIST_QUERY_KEY)
+ @QueryParam(Header.OZONE_LIST_QUERY_TAG)
{code}
you may want to double check.
bq. I am thinking if there is one way we can handle this in different processor
meanwhile keep the url path not changed?
As far as I know the http request is dispatched to java handlers only by the
*path*, not parameters. So probably if the GET requests use same path, they
will be always routed to one handler. I am not sure how to address [~xyao]'s
comment in such case, maybe he can us a hint.
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066372#comment-16066372
]
Yiqun Lin commented on HDFS-12030:
--
Hi [~cheersyang], your comment makes sense to me. I am thinking if there is one
way we can handle this in different processor meanwhile keep the url path not
changed?
bq. Can we handle this in getKey processor?...
Actually in v01 patch, I used this way to handle this (You can have a look if
that way is what you expected). But the review comments from [~xyao] expect
that we should have a separate procesor for getKeyInfo, so I am thinking if I
am missing something from the comments from [~xyao]. How do you think of this,
[~cheersyang]? I am a little confused now.
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066187#comment-16066187
]
Hadoop QA commented on HDFS-12030:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
7s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
11s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
31s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 37s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 3 new + 12 unchanged - 0 fixed = 15 total (was 12) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}115m 55s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}148m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
| | hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy |
| | hadoop.cblock.TestCBlockReadWrite |
| | hadoop.hdfs.server.namenode.ha.TestDNFencing |
| | hadoop.ozone.scm.node.TestNodeManager |
| | hadoop.ozone.container.ozoneimpl.TestOzoneContainerRatis |
| | hadoop.ozone.container.ozoneimpl.TestRatisManager |
| Timed out junit tests | org.apache.hadoop.cblock.TestLocalBlockCache |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12030 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12874812/HDFS-12030-HDFS-7240.003.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux b7c75dc9f9bd 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | HDFS-7240 / f98c352 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/20069/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/20069/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/20069/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/20069/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This messa
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066062#comment-16066062
]
Weiwei Yang commented on HDFS-12030:
Hi [~linyiqun]
bq. I have tried the way as you commented, it will go into the getKey processor
rather than getKeyInfo.
I see. Can we handle this in getKey processor? Because otherwise I can see 2
problems
1. This changes the design, per design doc [ozone user
doc|https://issues.apache.org/jira/secure/attachment/12799549/ozone_user_v0.pdf],
infoVolume API looks like
{code}
GET /{volume}/{bucket}/{key}?info=key
{code}
both info volume/bucket use similar schema, so it would be a bit inconsistent
if we change it.
2. Potential problems
I don't think we disallow user to put a key with name like "2017/Jan/photos",
actually this is a common way to simulate file hierarchy in object store. So if
there is a key "/volume/user/key/info", the key name is "key/info", what
happens if we use REST API to get its info? We don't want to get ourselves to
handle such problems.
Let me know your thought.
Thank you.
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch, HDFS-12030-HDFS-7240.003.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065126#comment-16065126
]
Weiwei Yang commented on HDFS-12030:
Hi [~linyiqun]
Thanks for working on this one, most of the patch looks good to me. Please see
my comments below
*OzoneBuckets.java*
# line 518: better to revise the error message to "Unable to get key info, key
name is null or empty"
# line 527: is this the correct URL? I was expecting something like
"http://localhost:9864/volume/bucket/key?info=key";, according to the API
specification (just like infoVolume, infoBucket etc), but here it seems to be
"http://localhost:9864/volume/bucket/key/info";. Should we use following code
instead?
{code}
builder.setParameter(Header.OZONE_LIST_QUERY_TAG, Header.OZONE_LIST_QUERY_KEY)
{code}
*StorageHandler.java*
# line 279: minor, Returns info ...
# line 281 - 282 : minor, remove dash and format to 1 line
(Same applies to LocalStorageHandler.java)
*OzoneMetadataManager.java*
# line 1112: minor, Returns the key info ...
# line 1115: minor, remove extra spaces
*TestOzoneShell.java*
# Can we add a test case to test info a non-exist key to make sure we get
{{KEY_NOT_FOUND}} error ? I am asking because I noticed KSM side has defined
{{KSMException.ResultCodes.FAILED_KEY_NOT_FOUND}} but I did not see
{{ErrorTable}} has similar error code defined. Wondering if there might be a
mismatch.
Thanks
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch,
> HDFS-12030-HDFS-7240.002.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064882#comment-16064882
]
Hadoop QA commented on HDFS-12030:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
22s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
57s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
53s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 35s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 77m 19s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}107m 33s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.container.ozoneimpl.TestOzoneContainerRatis
|
| | hadoop.ozone.container.ozoneimpl.TestRatisManager |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 |
| Timed out junit tests |
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12030 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12874675/HDFS-12030-HDFS-7240.002.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 24a4bffcafaa 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | HDFS-7240 / f98c352 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/20060/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/20060/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/20060/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/20060/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.o
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063503#comment-16063503
]
Xiaoyu Yao commented on HDFS-12030:
---
Thanks [~linyiqun] for working on this. The patch looks good to me overall.
Here are a few comments:
*KeyHandler.java*
Line 55: remove the unused parameter info
Line 63-108: we should have a separate procesor for getKeyInfo as commented in
the Keys.java below.
*Keys.java*
Line 90-99: Since this is purely a KSM metadata operation, I think we should
define a new operation
like getKeyInfo for Keys interface instead of mixing with the existing one to
get the key designed for streaming data.
*DistributedStorageHandler.java*
Line 441/448: I don't think we should set the keySize here. Many times, the
callers make this call to figure
out the size of the key from KSM.
*Test*
Can you add a test to the oz shell command infoKey?
> Ozone: CLI: support infoKey command
> ---
>
> Key: HDFS-12030
> URL: https://issues.apache.org/jira/browse/HDFS-12030
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Xiaoyu Yao
>Assignee: Yiqun Lin
> Attachments: HDFS-12030-HDFS-7240.001.patch
>
>
> {code}
> HW11717:ozone xyao$ hdfs oz -infoKey
> http://localhost:9864/vol-2/bucket-1/key-1 -user xyao
> Command Failed : {"httpCode":0,"shortMessage":"Not supported
> yet","resource":null,"message":"Not supported
> yet","requestID":null,"hostName":null}
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12030) Ozone: CLI: support infoKey command
[
https://issues.apache.org/jira/browse/HDFS-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063040#comment-16063040
]
Hadoop QA commented on HDFS-12030:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
45s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
15s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
13s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 42s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 3 new + 12 unchanged - 0 fixed = 15 total (was 12) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
29s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m
2s{color} | {color:red} hadoop-hdfs-project_hadoop-hdfs generated 1 new + 10
unchanged - 0 fixed = 11 total (was 10) {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 70m 46s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}105m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010 |
| | hadoop.ozone.container.ozoneimpl.TestRatisManager |
| | hadoop.ozone.container.ozoneimpl.TestOzoneContainerRatis |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12030 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12874476/HDFS-12030-HDFS-7240.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 47f8b84e559f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | HDFS-7240 / 31eafb1 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/20043/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/20043/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/20043/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/20043/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/20043/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was
