[jira] [Commented] (HDFS-12963) Error log level in ShortCircuitRegistry#removeShm
[ https://issues.apache.org/jira/browse/HDFS-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336825#comment-16336825 ] Hudson commented on HDFS-12963: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13542 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13542/]) HDFS-12963. Error log level in ShortCircuitRegistry#removeShm. (yqlin: rev d95c13774e1bd5b3cc61bf4da8bae4a93ed0040c) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ShortCircuitRegistry.java > Error log level in ShortCircuitRegistry#removeShm > - > > Key: HDFS-12963 > URL: https://issues.apache.org/jira/browse/HDFS-12963 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: hu xiaodong >Assignee: hu xiaodong >Priority: Minor > Fix For: 3.1.0 > > Attachments: HDFS-12963.001.patch > > > {code:title=org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.java|borderStyle=solid} > public synchronized void removeShm(ShortCircuitShm shm) { > if (LOG.isTraceEnabled()) { > LOG.debug("removing shm " + shm); -- I think here > should be trace > } > // Stop tracking the shmId. > RegisteredShm removedShm = segments.remove(shm.getShmId()); > Preconditions.checkState(removedShm == shm, > "failed to remove " + shm.getShmId()); > // Stop tracking the slots. > for (Iterator iter = shm.slotIterator(); iter.hasNext(); ) { > Slot slot = iter.next(); > boolean removed = slots.remove(slot.getBlockId(), slot); > Preconditions.checkState(removed); > slot.makeInvalid(); > } > // De-allocate the memory map and close the shared file. > shm.free(); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12963) Error log level in ShortCircuitRegistry#removeShm
[ https://issues.apache.org/jira/browse/HDFS-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336800#comment-16336800 ] hu xiaodong commented on HDFS-12963: thank you, [~linyiqun] > Error log level in ShortCircuitRegistry#removeShm > - > > Key: HDFS-12963 > URL: https://issues.apache.org/jira/browse/HDFS-12963 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: hu xiaodong >Assignee: hu xiaodong >Priority: Minor > Fix For: 3.1.0 > > Attachments: HDFS-12963.001.patch > > > {code:title=org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.java|borderStyle=solid} > public synchronized void removeShm(ShortCircuitShm shm) { > if (LOG.isTraceEnabled()) { > LOG.debug("removing shm " + shm); -- I think here > should be trace > } > // Stop tracking the shmId. > RegisteredShm removedShm = segments.remove(shm.getShmId()); > Preconditions.checkState(removedShm == shm, > "failed to remove " + shm.getShmId()); > // Stop tracking the slots. > for (Iterator iter = shm.slotIterator(); iter.hasNext(); ) { > Slot slot = iter.next(); > boolean removed = slots.remove(slot.getBlockId(), slot); > Preconditions.checkState(removed); > slot.makeInvalid(); > } > // De-allocate the memory map and close the shared file. > shm.free(); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12963) error log level in ShortCircuitRegistry#removeShm
[ https://issues.apache.org/jira/browse/HDFS-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336786#comment-16336786 ] Yiqun Lin commented on HDFS-12963: -- +1, will commit this shortly. > error log level in ShortCircuitRegistry#removeShm > - > > Key: HDFS-12963 > URL: https://issues.apache.org/jira/browse/HDFS-12963 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: hu xiaodong >Assignee: hu xiaodong >Priority: Minor > Attachments: HDFS-12963.001.patch > > > {code:title=org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.java|borderStyle=solid} > public synchronized void removeShm(ShortCircuitShm shm) { > if (LOG.isTraceEnabled()) { > LOG.debug("removing shm " + shm); -- I think here > should be trace > } > // Stop tracking the shmId. > RegisteredShm removedShm = segments.remove(shm.getShmId()); > Preconditions.checkState(removedShm == shm, > "failed to remove " + shm.getShmId()); > // Stop tracking the slots. > for (Iterator iter = shm.slotIterator(); iter.hasNext(); ) { > Slot slot = iter.next(); > boolean removed = slots.remove(slot.getBlockId(), slot); > Preconditions.checkState(removed); > slot.makeInvalid(); > } > // De-allocate the memory map and close the shared file. > shm.free(); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12963) error log level in ShortCircuitRegistry#removeShm
[ https://issues.apache.org/jira/browse/HDFS-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336749#comment-16336749 ] hu xiaodong commented on HDFS-12963: hello, [~ajisakaa],can you commit this? than you very much. > error log level in ShortCircuitRegistry#removeShm > - > > Key: HDFS-12963 > URL: https://issues.apache.org/jira/browse/HDFS-12963 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: hu xiaodong >Assignee: hu xiaodong >Priority: Minor > Attachments: HDFS-12963.001.patch > > > {code:title=org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.java|borderStyle=solid} > public synchronized void removeShm(ShortCircuitShm shm) { > if (LOG.isTraceEnabled()) { > LOG.debug("removing shm " + shm); -- I think here > should be trace > } > // Stop tracking the shmId. > RegisteredShm removedShm = segments.remove(shm.getShmId()); > Preconditions.checkState(removedShm == shm, > "failed to remove " + shm.getShmId()); > // Stop tracking the slots. > for (Iterator iter = shm.slotIterator(); iter.hasNext(); ) { > Slot slot = iter.next(); > boolean removed = slots.remove(slot.getBlockId(), slot); > Preconditions.checkState(removed); > slot.makeInvalid(); > } > // De-allocate the memory map and close the shared file. > shm.free(); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12963) error log level in ShortCircuitRegistry#removeShm
[ https://issues.apache.org/jira/browse/HDFS-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305725#comment-16305725 ] Rushabh S Shah commented on HDFS-12963: --- +1 lgtm non-binding. > error log level in ShortCircuitRegistry#removeShm > - > > Key: HDFS-12963 > URL: https://issues.apache.org/jira/browse/HDFS-12963 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: hu xiaodong >Assignee: hu xiaodong >Priority: Minor > Attachments: HDFS-12963.001.patch > > > {code:title=org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.java|borderStyle=solid} > public synchronized void removeShm(ShortCircuitShm shm) { > if (LOG.isTraceEnabled()) { > LOG.debug("removing shm " + shm); -- I think here > should be trace > } > // Stop tracking the shmId. > RegisteredShm removedShm = segments.remove(shm.getShmId()); > Preconditions.checkState(removedShm == shm, > "failed to remove " + shm.getShmId()); > // Stop tracking the slots. > for (Iterator iter = shm.slotIterator(); iter.hasNext(); ) { > Slot slot = iter.next(); > boolean removed = slots.remove(slot.getBlockId(), slot); > Preconditions.checkState(removed); > slot.makeInvalid(); > } > // De-allocate the memory map and close the shared file. > shm.free(); > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12963) error log level in ShortCircuitRegistry#removeShm
[ https://issues.apache.org/jira/browse/HDFS-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303455#comment-16303455 ] genericqa commented on HDFS-12963: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m 35s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 33s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 53s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 57s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}110m 36s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 22s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}161m 25s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency | | | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting | | | hadoop.hdfs.server.datanode.TestDirectoryScanner | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 | | JIRA Issue | HDFS-12963 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12903622/HDFS-12963.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux ea87519e47b6 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 52babbb | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/22508/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html | | unit |