[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758761#comment-16758761 ] Hadoop QA commented on HDFS-14250: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 35s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 1s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 16s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 17m 45s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 54s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 26s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 15m 13s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 34s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 58s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}105m 52s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 33s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}192m 43s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap | | | hadoop.hdfs.TestReconstructStripedFile | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f | | JIRA Issue | HDFS-14250 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12957308/HDFS-14250.000.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux a5eab894b4a8 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 4123353 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | unit |
[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758715#comment-16758715 ] Erik Krogen commented on HDFS-14250: Great ! +1 from me pending Jenkins, will commit early next week unless there are any objections from others before then. > [Standby Reads] msync should sync with active NameNode to fetch the latest > stateID > -- > > Key: HDFS-14250 > URL: https://issues.apache.org/jira/browse/HDFS-14250 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Chao Sun >Assignee: Chao Sun >Priority: Major > Attachments: HDFS-14250.000.patch, HDFS-14250.001.patch > > > Currently the {{msync}} call is a dummy operation to observer without really > syncing. Instead, it should: > # Get the latest stateID from active NN. > # Use the stateID to talk to observer NN and make sure it is synced. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758707#comment-16758707 ] Chao Sun commented on HDFS-14250: - Thanks [~xkrogen]! Attached patch v1 to address the comment. > [Standby Reads] msync should sync with active NameNode to fetch the latest > stateID > -- > > Key: HDFS-14250 > URL: https://issues.apache.org/jira/browse/HDFS-14250 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Chao Sun >Assignee: Chao Sun >Priority: Major > Attachments: HDFS-14250.000.patch, HDFS-14250.001.patch > > > Currently the {{msync}} call is a dummy operation to observer without really > syncing. Instead, it should: > # Get the latest stateID from active NN. > # Use the stateID to talk to observer NN and make sure it is synced. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758643#comment-16758643 ] Erik Krogen commented on HDFS-14250: v000 patch LGTM, only minor nit is that I would probably switch the order of these two lines, so that we give some time for the reader thread to advance before asserting that it was blocked: {code} assertEquals(0, readStatus.get()); Thread.sleep(100); {code} > [Standby Reads] msync should sync with active NameNode to fetch the latest > stateID > -- > > Key: HDFS-14250 > URL: https://issues.apache.org/jira/browse/HDFS-14250 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Chao Sun >Assignee: Chao Sun >Priority: Major > Attachments: HDFS-14250.000.patch > > > Currently the {{msync}} call is a dummy operation to observer without really > syncing. Instead, it should: > # Get the latest stateID from active NN. > # Use the stateID to talk to observer NN and make sure it is synced. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757742#comment-16757742 ] Chao Sun commented on HDFS-14250: - Yes, I think we can just use {{activeOnly}} for this type of purpose. > [Standby Reads] msync should sync with active NameNode to fetch the latest > stateID > -- > > Key: HDFS-14250 > URL: https://issues.apache.org/jira/browse/HDFS-14250 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Chao Sun >Assignee: Chao Sun >Priority: Major > > Currently the {{msync}} call is a dummy operation to observer without really > syncing. Instead, it should: > # Get the latest stateID from active NN. > # Use the stateID to talk to observer NN and make sure it is synced. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757722#comment-16757722 ] Erik Krogen commented on HDFS-14250: I don't think we want to make it write anything per se, but IIRC we have an annotation that we can add which makes it always go to active? I think that would be sufficient? > [Standby Reads] msync should sync with active NameNode to fetch the latest > stateID > -- > > Key: HDFS-14250 > URL: https://issues.apache.org/jira/browse/HDFS-14250 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Chao Sun >Assignee: Chao Sun >Priority: Major > > Currently the {{msync}} call is a dummy operation to observer without really > syncing. Instead, it should: > # Get the latest stateID from active NN. > # Use the stateID to talk to observer NN and make sure it is synced. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757712#comment-16757712 ] Chao Sun commented on HDFS-14250: - [~xkrogen] you are right. Maybe {{msync}} can simply be a write call that just fetch the stateID from active NN? > [Standby Reads] msync should sync with active NameNode to fetch the latest > stateID > -- > > Key: HDFS-14250 > URL: https://issues.apache.org/jira/browse/HDFS-14250 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Chao Sun >Assignee: Chao Sun >Priority: Major > > Currently the {{msync}} call is a dummy operation to observer without really > syncing. Instead, it should: > # Get the latest stateID from active NN. > # Use the stateID to talk to observer NN and make sure it is synced. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14250) [Standby Reads] msync should sync with active NameNode to fetch the latest stateID
[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757704#comment-16757704 ] Erik Krogen commented on HDFS-14250: I think #2 is not necessary -- this will be handled automatically by any subsequent call that goes to the observer, right? > [Standby Reads] msync should sync with active NameNode to fetch the latest > stateID > -- > > Key: HDFS-14250 > URL: https://issues.apache.org/jira/browse/HDFS-14250 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Chao Sun >Assignee: Chao Sun >Priority: Major > > Currently the {{msync}} call is a dummy operation to observer without really > syncing. Instead, it should: > # Get the latest stateID from active NN. > # Use the stateID to talk to observer NN and make sure it is synced. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org