[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-05-10 Thread Ayush Saxena (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341854#comment-17341854
 ] 

Ayush Saxena commented on HDFS-16003:
-

Committed to trunk and branch-3.3

Thanx [~lei w] for the contribution, [~hexiaoqiao] and [~zhuqi] for the 
reviews!!!

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Assignee: lei w
>Priority: Minor
> Attachments: HDFS-16003.001.path, HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-05-10 Thread Ayush Saxena (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341852#comment-17341852
 ] 

Ayush Saxena commented on HDFS-16003:
-

Test test failures aren't related.

+1

 

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Assignee: lei w
>Priority: Minor
> Attachments: HDFS-16003.001.path, HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-05-10 Thread Hadoop QA (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341839#comment-17341839
 ] 

Hadoop QA commented on HDFS-16003:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||  Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
44s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue}  0m  
5s{color} | {color:blue}{color} | {color:blue} The patch file was not named 
according to hadoop's naming conventions. Please see 
https://wiki.apache.org/hadoop/HowToContribute for instructions. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green}{color} | {color:green} No case conflicting files 
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green}{color} | {color:green} The patch does not contain any 
@author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red}{color} | {color:red} The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 
32s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
22s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
14s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 2s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
21s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
15m 20s{color} | {color:green}{color} | {color:green} branch has no errors when 
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
31s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 20m 
45s{color} | {color:blue}{color} | {color:blue} Both FindBugs and SpotBugs are 
enabled, using SpotBugs. {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green}  3m  
1s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
13s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
13s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
13s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
8s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
8s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
55s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
13s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green}{color} | {color:green} The patch has no whitespace 
issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 54s{color} | {color:green}{color} | {color:green} patch has no errors when 

[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-05-10 Thread Ayush Saxena (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341800#comment-17341800
 ] 

Ayush Saxena commented on HDFS-16003:
-

[~lei w]  guess you had a typo in the patch name. Instead of having extention 
as .patch you have made it .path
Not sure if jenkins will pick it up.
Can you re upload with correct extension, if Jenkins doesn’t pick it up

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Assignee: lei w
>Priority: Minor
> Attachments: HDFS-16003.001.path, HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-05-10 Thread Qi Zhu (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341776#comment-17341776
 ] 

Qi Zhu commented on HDFS-16003:
---

LGTM +1. 

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Assignee: lei w
>Priority: Minor
> Attachments: HDFS-16003.001.path, HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-05-10 Thread Xiaoqiao He (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341694#comment-17341694
 ] 

Xiaoqiao He commented on HDFS-16003:


LGTM, +1 on [^HDFS-16003.001.path]. Pending Jenkins reports.

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Assignee: lei w
>Priority: Minor
> Attachments: HDFS-16003.001.path, HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-05-10 Thread lei w (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341681#comment-17341681
 ] 

lei w commented on HDFS-16003:
--

Thanks [~hexiaoqiao] and [~ayushtkn]. Fix the checkstyle at HDFS-16003.001.path

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Assignee: lei w
>Priority: Minor
> Attachments: HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-05-09 Thread Xiaoqiao He (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341511#comment-17341511
 ] 

Xiaoqiao He commented on HDFS-16003:


Thanks [~lei w] and [~ayushtkn]. Would you mind to fix checkstyle as Yetus 
reports above and submit another patch?

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Assignee: lei w
>Priority: Minor
> Attachments: HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-05-08 Thread Ayush Saxena (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341427#comment-17341427
 ] 

Ayush Saxena commented on HDFS-16003:
-

LGTM +1.

Will wait for [~hexiaoqiao] a couple of days, before proceeding with the commit

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Assignee: lei w
>Priority: Minor
> Attachments: HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-04-29 Thread Hadoop QA (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335598#comment-17335598
 ] 

Hadoop QA commented on HDFS-16003:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||  Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
48s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green}{color} | {color:green} No case conflicting files 
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green}{color} | {color:green} The patch does not contain any 
@author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red}{color} | {color:red} The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m 
22s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
34s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
38s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
15s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
38s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
20m 39s{color} | {color:green}{color} | {color:green} branch has no errors when 
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
8s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
41s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 27m 
38s{color} | {color:blue}{color} | {color:blue} Both FindBugs and SpotBugs are 
enabled, using SpotBugs. {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green}  4m 
13s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
47s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
32s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
32s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
27s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
28s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
1m  6s{color} | 
{color:orange}https://ci-hadoop.apache.org/job/PreCommit-HDFS-Build/594/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt{color}
 | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 
112 unchanged - 0 fixed = 114 total (was 112) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
34s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green}{color} | {color:green} The patch has no whitespace 
issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
16m 14s{color} | {color:green}{color} | {color:green} patch has no errors when 
building and testing our client artifacts. {color} |
| 

[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-04-29 Thread lei w (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335217#comment-17335217
 ] 

lei w commented on HDFS-16003:
--

Ok ,thank you so much for responding to my message.

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Assignee: lei w
>Priority: Minor
> Attachments: HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-04-29 Thread lei w (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335210#comment-17335210
 ] 

lei w commented on HDFS-16003:
--

In the actual production environment, the log level is generally info. We first 
judged the log level will save the time of traversing the collection. If the 
log level is debug, then we can traverse the collection and print the 
information. So we will not loss trace information about some specific blocks.

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Priority: Minor
> Attachments: HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-16003) ProcessReport print invalidatedBlocks should judge debug level at first

2021-04-29 Thread Xiaoqiao He (Jira)


[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335201#comment-17335201
 ] 

Xiaoqiao He commented on HDFS-16003:


Thanks [~lei w] for your proposal. It makes sense to me. But I am concerned if 
it will loss some trace information about some specific block.

> ProcessReport print invalidatedBlocks should judge debug level at first
> ---
>
> Key: HDFS-16003
> URL: https://issues.apache.org/jira/browse/HDFS-16003
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: namanode
>Affects Versions: 3.3.0
>Reporter: lei w
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org