[jira] [Commented] (HDFS-17007) TestPendingReconstruction.testProcessPendingReconstructions verify HDFS-11960 test case is wrong
[
https://issues.apache.org/jira/browse/HDFS-17007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722090#comment-17722090
]
ASF GitHub Bot commented on HDFS-17007:
---
hadoop-yetus commented on PR #5642:
URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1545449348
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 47s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 17s | | trunk passed |
| +1 :green_heart: | compile | 1m 18s | | trunk passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | compile | 1m 8s | | trunk passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | checkstyle | 1m 7s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 18s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 9s | | trunk passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | javadoc | 1m 32s | | trunk passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | spotbugs | 3m 28s | | trunk passed |
| +1 :green_heart: | shadedclient | 25m 35s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 8s | | the patch passed |
| +1 :green_heart: | compile | 1m 12s | | the patch passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | javac | 1m 12s | | the patch passed |
| +1 :green_heart: | compile | 1m 3s | | the patch passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | javac | 1m 3s | | the patch passed |
| -1 :x: | blanks | 0m 0s |
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/2/artifact/out/blanks-eol.txt)
| The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix
<>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | checkstyle | 0m 54s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 10s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 53s | | the patch passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | javadoc | 1m 27s | | the patch passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | spotbugs | 3m 17s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 37s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 226m 2s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 44s | | The patch does not
generate ASF License warnings. |
| | | 335m 24s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/5642 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux b11039115fec 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 969c6b6098c8a24330e7db71a941e5f2eb471d36 |
| Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/2/testReport/ |
| Max. process+thread count | 2229 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/2/console |
| versions |
[jira] [Commented] (HDFS-17007) TestPendingReconstruction.testProcessPendingReconstructions verify HDFS-11960 test case is wrong
[
https://issues.apache.org/jira/browse/HDFS-17007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721997#comment-17721997
]
ASF GitHub Bot commented on HDFS-17007:
---
LiuGuH commented on PR #5642:
URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1545058013
> [HDFS-15086](https://issues.apache.org/jira/browse/HDFS-15086) changed
storedBlock to blockInfo without any specific reason.
>
> > (1) It does not stop PendingReconstructionMonitor. The blockid will into
timeouts queue because of timout duration is 3s.
>
> I don't catch this, can you elaborate, what will fail? Does putting a
sleep of more than 3 seconds anywhere in the test lead to failures if this
isn't there, if yes, can you tell me where to put that, so that I can try
locally
GenericTestUtils.waitFor(() -> pendingReconstruction.size() == 0, 500,
1);
// The pending queue should be empty.
assertEquals("Size of pendingReconstructions ", 0,
pendingReconstruction.size());
} finally {
if (cluster != null) {
cluster.shutdown();
}
}
GenericTestUtils.waitFor() will sleep maximum 10s. The
pendingReconstruction will timeout after 3s ，then will be into timeout list.
PendingReconstructionMonitor will not be stoped if I change
GenericTestUtils.waitFor to 1s .
> TestPendingReconstruction.testProcessPendingReconstructions verify HDFS-11960
> test case is wrong
>
>
> Key: HDFS-17007
> URL: https://issues.apache.org/jira/browse/HDFS-17007
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: liuguanghua
>Priority: Minor
> Labels: pull-request-available
>
> TestPendingReconstruction.testProcessPendingReconstructions() verify
> HDFS-11960 is wrong.
> (1) It does not stop PendingReconstructionMonitor. The blockid will into
> timeouts queue because of timout duration is 3s.
> (2) Test blockid should be blk_1_1 with different genstamp.
> (3) The blk_1_1 should test with the same DatanodeDescriptor
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17007) TestPendingReconstruction.testProcessPendingReconstructions verify HDFS-11960 test case is wrong
[
https://issues.apache.org/jira/browse/HDFS-17007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721996#comment-17721996
]
ASF GitHub Bot commented on HDFS-17007:
---
LiuGuH commented on PR #5642:
URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1545057769
GenericTestUtils.waitFor(() -> pendingReconstruction.size() == 0, 500,
1);
// The pending queue should be empty.
assertEquals("Size of pendingReconstructions ", 0,
pendingReconstruction.size());
} finally {
if (cluster != null) {
cluster.shutdown();
}
}
GenericTestUtils.waitFor() will sleep maximum 10s. The
pendingReconstruction will timeout after 3s ，then will be into timeout list.
PendingReconstructionMonitor will not be stoped if I change
GenericTestUtils.waitFor to 1s .
> TestPendingReconstruction.testProcessPendingReconstructions verify HDFS-11960
> test case is wrong
>
>
> Key: HDFS-17007
> URL: https://issues.apache.org/jira/browse/HDFS-17007
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: liuguanghua
>Priority: Minor
>
> TestPendingReconstruction.testProcessPendingReconstructions() verify
> HDFS-11960 is wrong.
> (1) It does not stop PendingReconstructionMonitor. The blockid will into
> timeouts queue because of timout duration is 3s.
> (2) Test blockid should be blk_1_1 with different genstamp.
> (3) The blk_1_1 should test with the same DatanodeDescriptor
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
