[jira] [Commented] (HDFS-17008) Fix RBF JDK 11 javadoc warnings
[
https://issues.apache.org/jira/browse/HDFS-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722022#comment-17722022
]
ASF GitHub Bot commented on HDFS-17008:
---
simbadzina commented on code in PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#discussion_r1191935955
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java:
##
@@ -370,7 +372,9 @@ public static String getTrashRoot() throws IOException {
/**
* Subtract a TrashCurrent to get a new path.
*
- * @param path A path.
+ * @param path a path.
+ * @return new path with subtracted trash current path.
+ * @throws IOException if retrieval of router user information fails.
Review Comment:
`router user information` sounds vague in this context. Only when I looked
into getTrashRoot did I see that `RouterRpcServer.getRemoteUser()` is the
function that would throw the IOException.
I think over here writing `if retrieving current user's trash directory
fails` may be more appropriate vs. describing the root cause. It's quite
subjective though.
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederationUtil.java:
##
@@ -274,9 +274,9 @@ public static RouterRpcFairnessPolicyController
newFairnessPolicyController(
/**
* Collect all configured nameservices.
*
- * @param conf
- * @return Set of name services in config
- * @throws IllegalArgumentException
+ * @param conf the configuration object.
+ * @return Set of name services in config.
+ * @throws IllegalArgumentException if monitor namenodes are not correctly
configured.
Review Comment:
Typo `monitored`
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/security/token/DistributedSQLCounter.java:
##
@@ -50,7 +50,9 @@ public DistributedSQLCounter(String field, String table,
/**
* Obtains the value of the counter.
+ *
* @return counter value.
+ * @throws SQLException if SQL connection errors occur.
Review Comment:
`@throws SQLException if SQL errors occur` is a tautology.
`@throws SQLException if querying the database fails` may be slightly
better, but it also doesn't say much.
This is a minor issue though. The forced annotations make the javadocs kinda
verbose so it is okay to use the form you have.
> Fix RBF JDK 11 javadoc warnings
> ---
>
> Key: HDFS-17008
> URL: https://issues.apache.org/jira/browse/HDFS-17008
> Project: Hadoop HDFS
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Labels: pull-request-available
>
> HDFS-16978 excluded proto packages from maven-javadoc-plugin for rbf, hence
> now we have JDK 11 javadoc warnings (e.g.
> [here|https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/14/artifact/out/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt]).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17008) Fix RBF JDK 11 javadoc warnings
[
https://issues.apache.org/jira/browse/HDFS-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722006#comment-17722006
]
ASF GitHub Bot commented on HDFS-17008:
---
hadoop-yetus commented on PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#issuecomment-1545090106
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 31s | | trunk passed |
| +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | compile | 0m 33s | | trunk passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | checkstyle | 0m 29s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 38s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 42s | | trunk passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | spotbugs | 1m 30s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 38s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 31s | | the patch passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | javac | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 26s | | the patch passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | javac | 0m 26s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 30s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 26s | |
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 0 new + 0
unchanged - 73 fixed = 0 total (was 73) |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | spotbugs | 1m 18s | | the patch passed |
| +1 :green_heart: | shadedclient | 23m 33s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 22m 12s | | hadoop-hdfs-rbf in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not
generate ASF License warnings. |
| | | 119m 7s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5648/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/5648 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux f569c25e8c6a 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 77fae62ae1d7855581fbd6291931bb9cf8772a3f |
| Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5648/2/testReport/ |
| Max. process+thread count | 2453 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U:
hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output |
[jira] [Commented] (HDFS-17008) Fix RBF JDK 11 javadoc warnings
[
https://issues.apache.org/jira/browse/HDFS-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721981#comment-17721981
]
ASF GitHub Bot commented on HDFS-17008:
---
virajjasani commented on code in PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#discussion_r1191846344
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java:
##
@@ -670,6 +670,9 @@ public RouterServiceState getRouterState() {
/**
* Compare router state.
+ *
+ * @param routerState the router service state.
+ * @return true if the given router state is same as the state maintainer by
the router object.
Review Comment:
done
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##
@@ -484,14 +486,14 @@ private RetryDecision shouldRetry(final IOException ioe,
final int retryCount,
* Invokes a method against the ClientProtocol proxy server. If a standby
* exception is generated by the call to the client, retries using the
* alternate server.
- *
Review Comment:
done, added breakline
> Fix RBF JDK 11 javadoc warnings
> ---
>
> Key: HDFS-17008
> URL: https://issues.apache.org/jira/browse/HDFS-17008
> Project: Hadoop HDFS
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Labels: pull-request-available
>
> HDFS-16978 excluded proto packages from maven-javadoc-plugin for rbf, hence
> now we have JDK 11 javadoc warnings (e.g.
> [here|https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/14/artifact/out/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt]).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17008) Fix RBF JDK 11 javadoc warnings
[ https://issues.apache.org/jira/browse/HDFS-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721949#comment-17721949 ] ASF GitHub Bot commented on HDFS-17008: --- goiri commented on code in PR #5648: URL: https://github.com/apache/hadoop/pull/5648#discussion_r1191783244 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -484,14 +486,14 @@ private RetryDecision shouldRetry(final IOException ioe, final int retryCount, * Invokes a method against the ClientProtocol proxy server. If a standby * exception is generated by the call to the client, retries using the * alternate server. - * Review Comment: Does this give warnings? If no, it is easier to read with the break line. The other option is to explicitly add the breakline. > Fix RBF JDK 11 javadoc warnings > --- > > Key: HDFS-17008 > URL: https://issues.apache.org/jira/browse/HDFS-17008 > Project: Hadoop HDFS > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Labels: pull-request-available > > HDFS-16978 excluded proto packages from maven-javadoc-plugin for rbf, hence > now we have JDK 11 javadoc warnings (e.g. > [here|https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/14/artifact/out/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt]). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17008) Fix RBF JDK 11 javadoc warnings
[
https://issues.apache.org/jira/browse/HDFS-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721938#comment-17721938
]
ASF GitHub Bot commented on HDFS-17008:
---
simbadzina commented on code in PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#discussion_r1191736478
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java:
##
@@ -670,6 +670,9 @@ public RouterServiceState getRouterState() {
/**
* Compare router state.
+ *
+ * @param routerState the router service state.
+ * @return true if the given router state is same as the state maintainer by
the router object.
Review Comment:
Quick nit: Typo `maintained`
> Fix RBF JDK 11 javadoc warnings
> ---
>
> Key: HDFS-17008
> URL: https://issues.apache.org/jira/browse/HDFS-17008
> Project: Hadoop HDFS
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Labels: pull-request-available
>
> HDFS-16978 excluded proto packages from maven-javadoc-plugin for rbf, hence
> now we have JDK 11 javadoc warnings (e.g.
> [here|https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/14/artifact/out/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt]).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17008) Fix RBF JDK 11 javadoc warnings
[ https://issues.apache.org/jira/browse/HDFS-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721923#comment-17721923 ] ASF GitHub Bot commented on HDFS-17008: --- virajjasani opened a new pull request, #5648: URL: https://github.com/apache/hadoop/pull/5648 (no comment) > Fix RBF JDK 11 javadoc warnings > --- > > Key: HDFS-17008 > URL: https://issues.apache.org/jira/browse/HDFS-17008 > Project: Hadoop HDFS > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > > HDFS-16978 excluded proto packages from maven-javadoc-plugin for rbf, hence > now we have JDK 11 javadoc warnings (e.g. > [here|https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/14/artifact/out/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt]). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
