[jira] [Commented] (HDFS-7049) TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
[
https://issues.apache.org/jira/browse/HDFS-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14146740#comment-14146740
]
Haohui Mai commented on HDFS-7049:
--
+1
TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
Key: HDFS-7049
URL: https://issues.apache.org/jira/browse/HDFS-7049
Project: Hadoop HDFS
Issue Type: Bug
Components: test
Affects Versions: 2.5.0
Reporter: Juan Yu
Assignee: Juan Yu
Priority: Minor
Attachments: HDFS-7049-branch-2.002.patch, HDFS-7049-branch-2.patch
On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when
HftpFileSystem$RangeHeaderUrlOpener.connect
This is due to fix of HDFS-6143 WebHdfsFileSystem open should throw
FileNotFoundException for non-existing paths
public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException {
this.originalURL = o;
this.resolvedURL = r;
getInputStream();
}
the getInputStream() will be called in constructor now to verify if file
exists.
Since we just try to test if ByteRangeInputStream#close is called at proper
time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for
testing to avoid the NPE issue.
I believe the trunk version already does this, we just need to merge the test
from trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7049) TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
[
https://issues.apache.org/jira/browse/HDFS-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14146758#comment-14146758
]
Juan Yu commented on HDFS-7049:
---
Thanks all for reviewing.
TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
Key: HDFS-7049
URL: https://issues.apache.org/jira/browse/HDFS-7049
Project: Hadoop HDFS
Issue Type: Bug
Components: test
Affects Versions: 2.5.0
Reporter: Juan Yu
Assignee: Juan Yu
Priority: Minor
Fix For: 2.6.0
Attachments: HDFS-7049-branch-2.002.patch, HDFS-7049-branch-2.patch
On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when
HftpFileSystem$RangeHeaderUrlOpener.connect
This is due to fix of HDFS-6143 WebHdfsFileSystem open should throw
FileNotFoundException for non-existing paths
public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException {
this.originalURL = o;
this.resolvedURL = r;
getInputStream();
}
the getInputStream() will be called in constructor now to verify if file
exists.
Since we just try to test if ByteRangeInputStream#close is called at proper
time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for
testing to avoid the NPE issue.
I believe the trunk version already does this, we just need to merge the test
from trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7049) TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
[
https://issues.apache.org/jira/browse/HDFS-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140088#comment-14140088
]
Akira AJISAKA commented on HDFS-7049:
-
bq. Looks like Hadoop QA tried to apply the patch to trunk,
Yes, Hadoop QA always tests the patch on trunk.
+1 (non-binding). The test code is the same as trunk, and the test passed on my
environment.
[~wheat9], would you please review the patch?
TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
Key: HDFS-7049
URL: https://issues.apache.org/jira/browse/HDFS-7049
Project: Hadoop HDFS
Issue Type: Bug
Components: test
Affects Versions: 2.5.0
Reporter: Juan Yu
Assignee: Juan Yu
Priority: Minor
Attachments: HDFS-7049-branch-2.002.patch, HDFS-7049-branch-2.patch
On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when
HftpFileSystem$RangeHeaderUrlOpener.connect
This is due to fix of HDFS-6143 WebHdfsFileSystem open should throw
FileNotFoundException for non-existing paths
public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException {
this.originalURL = o;
this.resolvedURL = r;
getInputStream();
}
the getInputStream() will be called in constructor now to verify if file
exists.
Since we just try to test if ByteRangeInputStream#close is called at proper
time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for
testing to avoid the NPE issue.
I believe the trunk version already does this, we just need to merge the test
from trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7049) TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
[
https://issues.apache.org/jira/browse/HDFS-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139613#comment-14139613
]
Eric Payne commented on HDFS-7049:
--
Hi [~j...@cloudera.com]. Thanks for merging this fix and creating the patch.
The patch doesn't apply because it has the 'a/' and 'b/' at the beginning of
the filepaths. I downloaded the patch, removed those strings from the
filepaths, and I was able to apply the patch cleanly to branch-2. The test also
passes cleanly with no NPE.
Once you make that change to the patch, it looks good to me.
TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
Key: HDFS-7049
URL: https://issues.apache.org/jira/browse/HDFS-7049
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Juan Yu
Assignee: Juan Yu
Priority: Minor
Attachments: HDFS-7049-branch-2.patch
On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when
HftpFileSystem$RangeHeaderUrlOpener.connect
This is due to fix of HDFS-6143 WebHdfsFileSystem open should throw
FileNotFoundException for non-existing paths
public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException {
this.originalURL = o;
this.resolvedURL = r;
getInputStream();
}
the getInputStream() will be called in constructor now to verify if file
exists.
Since we just try to test if ByteRangeInputStream#close is called at proper
time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for
testing to avoid the NPE issue.
I believe the trunk version already does this, we just need to merge the test
from trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7049) TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
[
https://issues.apache.org/jira/browse/HDFS-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139615#comment-14139615
]
Eric Payne commented on HDFS-7049:
--
Sorry, I forgot to mention that in order to avoid the 'a/' and 'b/' prefix
problem, you can use {{git diff --no-prefix}} when creating the patch.
TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
Key: HDFS-7049
URL: https://issues.apache.org/jira/browse/HDFS-7049
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Juan Yu
Assignee: Juan Yu
Priority: Minor
Attachments: HDFS-7049-branch-2.patch
On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when
HftpFileSystem$RangeHeaderUrlOpener.connect
This is due to fix of HDFS-6143 WebHdfsFileSystem open should throw
FileNotFoundException for non-existing paths
public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException {
this.originalURL = o;
this.resolvedURL = r;
getInputStream();
}
the getInputStream() will be called in constructor now to verify if file
exists.
Since we just try to test if ByteRangeInputStream#close is called at proper
time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for
testing to avoid the NPE issue.
I believe the trunk version already does this, we just need to merge the test
from trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7049) TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
[
https://issues.apache.org/jira/browse/HDFS-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139940#comment-14139940
]
Hadoop QA commented on HDFS-7049:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12669904/HDFS-7049-branch-2.002.patch
against trunk revision 6434572.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8097//console
This message is automatically generated.
TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
Key: HDFS-7049
URL: https://issues.apache.org/jira/browse/HDFS-7049
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Juan Yu
Assignee: Juan Yu
Priority: Minor
Attachments: HDFS-7049-branch-2.002.patch, HDFS-7049-branch-2.patch
On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when
HftpFileSystem$RangeHeaderUrlOpener.connect
This is due to fix of HDFS-6143 WebHdfsFileSystem open should throw
FileNotFoundException for non-existing paths
public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException {
this.originalURL = o;
this.resolvedURL = r;
getInputStream();
}
the getInputStream() will be called in constructor now to verify if file
exists.
Since we just try to test if ByteRangeInputStream#close is called at proper
time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for
testing to avoid the NPE issue.
I believe the trunk version already does this, we just need to merge the test
from trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7049) TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
[
https://issues.apache.org/jira/browse/HDFS-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139941#comment-14139941
]
Juan Yu commented on HDFS-7049:
---
Looks like Hadoop QA tried to apply the patch to trunk, but this patch is just
for branch-2.
TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
Key: HDFS-7049
URL: https://issues.apache.org/jira/browse/HDFS-7049
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Juan Yu
Assignee: Juan Yu
Priority: Minor
Attachments: HDFS-7049-branch-2.002.patch, HDFS-7049-branch-2.patch
On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when
HftpFileSystem$RangeHeaderUrlOpener.connect
This is due to fix of HDFS-6143 WebHdfsFileSystem open should throw
FileNotFoundException for non-existing paths
public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException {
this.originalURL = o;
this.resolvedURL = r;
getInputStream();
}
the getInputStream() will be called in constructor now to verify if file
exists.
Since we just try to test if ByteRangeInputStream#close is called at proper
time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for
testing to avoid the NPE issue.
I believe the trunk version already does this, we just need to merge the test
from trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7049) TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
[
https://issues.apache.org/jira/browse/HDFS-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134245#comment-14134245
]
Hadoop QA commented on HDFS-7049:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12668811/HDFS-7049-branch-2.patch
against trunk revision 43b0303.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8032//console
This message is automatically generated.
TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2
Key: HDFS-7049
URL: https://issues.apache.org/jira/browse/HDFS-7049
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Juan Yu
Assignee: Juan Yu
Priority: Minor
Attachments: HDFS-7049-branch-2.patch
On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when
HftpFileSystem$RangeHeaderUrlOpener.connect
This is due to fix of HDFS-6143 WebHdfsFileSystem open should throw
FileNotFoundException for non-existing paths
public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException {
this.originalURL = o;
this.resolvedURL = r;
getInputStream();
}
the getInputStream() will be called in constructor now to verify if file
exists.
Since we just try to test if ByteRangeInputStream#close is called at proper
time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for
testing to avoid the NPE issue.
I believe the trunk version already does this, we just need to merge the test
from trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
